GitLab

R=dpranke

Bug: 879147
Change-Id: Ic975848737614812a94460f6c3ef7653d3d1329a
Reviewed-on: https://chromium-review.googlesource.com/1210682
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589200}

This CL improves accessibility based on feedback of issue 870627 and
mocks from issue 838387:
1. The keyboard accessory is announced when made visible (string [1]).
Before this CL, android:clickable=true was used to prevent clicks
from propagating to the content area behind it. This caused Talkback
to read "double-tap to activate". This is gone now, by setting the
appropriate listeners when initializing the layout.

2. The key icon's name changed to "Show passwords" (string [4]). Once
triggered, it changes to "Show keyboard" (string [2]) in accordance to
what it does.

3. An opened password sheet is immediately announced with string [3]:
"Showing saved passwords and password options".

4. The title ("Saved passwords for XYZ") doesn't read "Double-tap to
activate" anymore.

5. Disabled entries (e.g. password entries when email fields are
focused) are now read back with the proper "Disabled" suffix.


Uploaded pictures for the new hashes (because there is no way to
download them anywhere):
[1] IDS_AUTOFILL_KEYBOARD_ACCESSORY_CONTENT_DESCRIPTION:
https://photos.app.goo.gl/kiYYx8tzyjfPB7oA7

[2] IDS_KEYBOARD_ACCESSORY_SHEET_HIDE:
https://photos.app.goo.gl/RxuGqCZp6QtmNLUJ9

[3] IDS_PASSWORD_ACCESSORY_SHEET_OPENED:
https://photos.app.goo.gl/NBpw2HavFSiZ5NSq8

[4] IDS_PASSWORD_ACCESSORY_SHEET_TOGGLE:
https://photos.app.goo.gl/fMprsLC8Y8giAdxF7

Bug: 870627, 838387
Change-Id: Iebccefa8d5ede702b8bdc2dc92f055064981fa80
Reviewed-on: https://chromium-review.googlesource.com/1209405Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Friedrich Horschig [CEST] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589199}

- The StreamFailBeforeReadIsExecutedOnNetworkThread is flaky on Fuchsia.

Bug: 880474
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester
Change-Id: I36c11741d674fec99286f25bd8503bb77903e950
Reviewed-on: https://chromium-review.googlesource.com/1210364Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589198}

Make sure the USS implementation also clears data on signout, just like
the directory-based implementation does. This also enables an
integration test to test this in the butter scenario.

Also making a small fix: Updating the storage in PDM in
OnSyncInitialized, because if sync is disabled, we won't get the
OnStateChanged call.

Bug: 880735
Change-Id: I6aa49b8c459a48cb92a1e3d7283f05eed8e6eb5c
Reviewed-on: https://chromium-review.googlesource.com/1206490
Commit-Queue: Florian Uunk <feuunk@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589197}

Also actually use this ability when the "Set Up" button in multidevice
settings is clicked.

R=khorimoto@chromium.org

Bug: 870093
Change-Id: I3dd5bcd9c8e3946e1ae42a5db69f2bb7ed3ea586
Reviewed-on: https://chromium-review.googlesource.com/1185498
Commit-Queue: Jeremy Klein <jlklein@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589196}

Each leaked NSCandidateListTouchBarItem carried a CALayer and other
resources; holding on to them caused a major slowdown.

This change makes |-createCandidateListItem| return an autoreleased
NSCandidateListTouchBarItem instead of a retained one, and renames it to
|-makeCandidateListItem| to match the naming and ownership semantics of
|-makeTouchBar| (and be consistent with the create rule).

Bug: 877137
Change-Id: Icfb335c341cb86e8691562ade4c222a59c990bf7
Reviewed-on: https://chromium-review.googlesource.com/1208428Reviewed-by: Sarah Chan <spqchan@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589195}

This CL moves JpegDecodeAcceleratorTestEnvironment upwards so that
the test-specific classes and the static classes are grouped together.

No new code whatsoever.

Bug: 877694
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ida2c6024526baf62933f058b3539bbb51306406e
Reviewed-on: https://chromium-review.googlesource.com/1204772Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589194}

Unicode 11 added a new set of Georgian captial letters and changed
the case-conversion rule to map lowercase (pre-Unicode 11) Georgian
letters to the new Goergian capital letters. [1]

However, virtually nobody has a font to cover the new characters.
Because these are new characters, they're very unlikely to show up
unless 'text-transform: uppercase' is applied to generate contents.

This CL maps new Georgian capital letters back to the corresponding
pre-Unicode 11 lowercase letters for CSS text-transform: uppercase until
new Georgian fonts are more widely available. CrOS will get a couple
of Georgian fonts supporting new characters pretty soon.

FYI, Firefox added a similar work around:
   https://bugzilla.mozilla.org/show_bug.cgi?id=1476304

Another FYI: There's no worry about title-casing because Georgian
title-casing is not supposed to capitalize the first letter of a word
and ICU's title-casing API leaves alone Georgian lowercase letters.

[1] http://unicode.org/versions/Unicode11.0.0/ : see section 'Casing
issues'.

Bug: 865427
Test: fast/css/case-transform-georgian-capital.html
Change-Id: If957df8407cf08f6752499522518a90d3e55251e
Reviewed-on: https://chromium-review.googlesource.com/1205712Reviewed-by: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Jungshik Shin <jshin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589193}

Bug: 880886
Change-Id: Ie13ab55b4b35ffe24e0cbbbaf75a9796db132631
Reviewed-on: https://chromium-review.googlesource.com/1184221Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589192}

Shrinks expanded page.h size by ~2.1M.

Change-Id: I20c304f7c2a47e86a14dfecd792f0b9b4da35531
Reviewed-on: https://chromium-review.googlesource.com/1204131Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#589191}

Upon exiting fullscreen restore back to the default page scale instead
of restoring old values. This is a simplier model and doesn't cause
scroll jumping when the page scale isn't changing.

BUG=878773

Change-Id: I107e517bd3c76300d0a8ce02622f4a05dc9ce79b
Reviewed-on: https://chromium-review.googlesource.com/1195714
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589190}

Now Chrome parses the systemLanguage attribute as a COMMA separated-
list (with optional space), following the SVG specification
for systemLanguage attribute.

The previous behavior was:

- The systemLanguage attribute is a space-separated list
of langtags (the comma separator was treated as a character).

Example:

<text systemLanguage="en-US, zh-Hans,zh-Hant"></text>

Now, the three langtags are: "en-US", "zh-Hans", "zh-Hant".
Before, the three langtags were "en-US,", "zh-Hans,", "zh-Hant".

R=fs@opera.com, schenney@chromium.org

Bug: 732063
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I7738bc4eb77de2c1ca7593dd9277fab14d39cc1f
Reviewed-on: https://chromium-review.googlesource.com/1207250Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#589189}

Bug: 835234
Change-Id: Ic285e99e68b8371a06ad923b98ce7aa1cfb816fa
Reviewed-on: https://chromium-review.googlesource.com/1202204Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589188}

Desktop Omnibox component will need access to the profile-keyed
QueryInOmnibox service.

This can is provided by the embedder, so add its access to
OmniboxClient like the other embedder-provided profile-keyed services.

Bug: 874592
Change-Id: Ibc12b563a9d2fe7a2625cdc5fdc0d10bf85c45d7
Reviewed-on: https://chromium-review.googlesource.com/1208455
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589187}

The first usage will be full screen applist, so it doesnt show up while
overview windows are moving around.

Also move blur to after animations, and fix a bug with app list overview
animation pause, and add a pause for homecher -> overview window
animations.

Test: manual
Bug: 873394, 871875, 880613
Change-Id: Id9ede4b412c609cff6a1ec4c841b20aaab9aa5e2
Reviewed-on: https://chromium-review.googlesource.com/1199814Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Weidong Guo <weidongg@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589186}

Approved Intent to Ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/ODzbWn-xRrQ/dhkJzD8-CgAJ

BUG=383813

Change-Id: Ia0b1e681520728c290ce7e1f95388bc27ebf91d0
Reviewed-on: https://chromium-review.googlesource.com/1204595
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589185}

on web_requests. This causes us to crash when converting
FetchAPIRequest mojo type to content::ServiceWorkerFetchRequest
since the latter doesn't currently support request body.

Once we switch to using the mojo type everywhere in content, we
can start setting the blob data handle  again from blink.

Bug: 789854, 774054
Change-Id: Icec9a74b9302fb9731febc5adc30f4153dfb698c
Reviewed-on: https://chromium-review.googlesource.com/1209522
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589184}

This crash only affects pre-ui-refresh, but it is safe to add
this fix for all experiments.

Bug: 881229
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ic200f8dfac105b73fe8903b050249683d1f2d1c1
Reviewed-on: https://chromium-review.googlesource.com/1210162
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589183}

This feature has been enabled for the past few stable releases, so the
flag is not needed anymore.

Bug: 838789, 792840
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ib79921d30792dbd8e03fd2ec7652c15a76e84b73
Reviewed-on: https://chromium-review.googlesource.com/1203956Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589182}

Bug: 880959
Change-Id: I87d4d222ea3b748171624846bfade66cca994a1b
Reviewed-on: https://chromium-review.googlesource.com/1208145Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589181}

Refer here for details:
https://cs.chromium.org/chromium/src/base/bind_internal.h?rcl=9050148b1dffa4d6e695d0732c368e954e15a4e0&l=787

Change-Id: I6aab905a1fc8d21967a0aff5df6fea3eab7decfc
Reviewed-on: https://chromium-review.googlesource.com/1208726
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589180}

It's possible that the change landed in
https://chromium-review.googlesource.com/c/chromium/src/+/1172723
will resolve the flakiness seen in this test. If not, it would be
nice to get some fresh logs from the bots for debugging purposes.

Bug: 863971
Change-Id: I332b48990e0503e078ccc657d3537c3a6d4f9c7a
Reviewed-on: https://chromium-review.googlesource.com/1210042Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589179}

Moving InitOzone() from content::GpuProcessHost to viz::GpuHostImpl as
part of moving viz::mojom::GpuHost implementation out of content. This
is a follow-up to https://crrev.com/c/1180658.

BUG=709332

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I022ee15c3a1f194313bf2566e9503e357cd46494
Reviewed-on: https://chromium-review.googlesource.com/1195151Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589178}

Follow-up to https://crrev.com/c/1188664 to remove unnecessary
braces in test methods (originally kept to reduce the size of
the patchset).

Bug: none
Change-Id: I966c86d121ae7ea9861c895ed2492d52c8f94b71
Reviewed-on: https://chromium-review.googlesource.com/1196513
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589177}

ExternalStringResource can be locked in V8, meaning that it should not
be parked. Add support in Chrome for this.
Separately, some blink strings will never be parked. For these, allow V8 to
cache the data pointer.

Bug: 877044
Change-Id: I0100a3b13887c417dfcf568186c9cf7f9c57706f
Reviewed-on: https://chromium-review.googlesource.com/1203376
Commit-Queue: Benoit L <lizeb@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589176}

Throughout Chrome settings, we expose the textual content of a control twice at times.

1. As the visible label/sublabel
2. as the aria-label/aria-describedBy on the button or control

This is extremely painful when navigating through settings especially with a screen reader (and likely switch control).

When navigating, you will first land on the label, then the actual control, which repeats the label.

Change-Id: Ia8633f12ddd4ddbc6ad6658c051af57c9cf34d93
Reviewed-on: https://chromium-review.googlesource.com/1195804Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589175}

In Mash, ShelfWindowWatcher tags unidentified windows with a
default App ID rather than leaving the App ID blank. Update the
test to reflect that.

Bug: 880595
Change-Id: I844c4729b69c956fffd6a3acae1932f13e700158
Reviewed-on: https://chromium-review.googlesource.com/1208727
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589174}

Bug: 865902
Change-Id: Iaa2d643eb4cf679511573a6816849db925d346f5
Reviewed-on: https://chromium-review.googlesource.com/1206811
Commit-Queue: Markus Heintz <markusheintz@chromium.org>
Reviewed-by: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589173}

Also reenables the test on Chrome OS, where it was previously flaking.

Bug: 879984
Change-Id: Ida0391c7114afd77b7cb9ec8c2f9b00d8cc275b5
Reviewed-on: https://chromium-review.googlesource.com/1204330
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589172}

Bug: 880585
Change-Id: Ifd9107ef7fe6eabd8876063e47274275d9e1f55c
Reviewed-on: https://chromium-review.googlesource.com/1206332Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589171}

This intentionally CHECK-fails when shared memory allocation fails on
BigBuffer construction in the case where the buffer is would be too
large for IPC if inlined. This allows such cases to be disambiguated
from other large-IPC failures.

Bug: 872237
Change-Id: I518dbea3007094a3136bfa1449f85eaefbbc7171
Reviewed-on: https://chromium-review.googlesource.com/1208719Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589170}

TBR=eugenis@chromium.org

Change-Id: Ic95108d1e2c3fcec56fbe6de208b73262666f5ce
Reviewed-on: https://chromium-review.googlesource.com/1210322Reviewed-by: Oliver Chang <ochang@chromium.org>
Commit-Queue: Oliver Chang <ochang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589169}

Send one extra setting with a random reserved identifier and random
value in the initial SETTINGS frame.  Send a short frame of a random
reserved type, with random flags and payload, after every SETTINGS and
HEADERS frame sent, on the same stream.

The two behaviors are gated by separate field trials.

Send the same greased settings identifier and value on every connection.
Send the same greased frame type, flags, and payload on every
connection.  This is to prevent the retry logic from hiding bogus
servers.

Reserved settings identifiers and frame types are described at
https://tools.ietf.org/html/draft-bishop-httpbis-grease-00.

Bug: 841264
Change-Id: Ie1bd1e4f106bf64020f45171e350d37a10815bc8
Reviewed-on: https://chromium-review.googlesource.com/1207750
Commit-Queue: Bence Béky <bnc@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589168}

Minor cleanups of AccountTrackerService:
- fix style issues (automatically using clang-format)
- use standard algorithms, C++11 auto and for loops
- use FILE_PATH_LITERAL to declare path component constants

Bug: none
Change-Id: I89d0fdb08a974b2542183beaf030d68d952b6af6
Reviewed-on: https://chromium-review.googlesource.com/1196366
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589167}

A number of changes have landed recently that may eliminate the
flakieness seen in this test. This CL re-enables the test, but feel
free to revert this if the flakes continue.

Bug: 833380
Change-Id: Id1b94654a197d77af2ffdfbfdbf13c83ac485261
Reviewed-on: https://chromium-review.googlesource.com/1209962Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589166}

The audio_processing_sample_rate is currently only used in
media_stream_audio_processor.cc however this will be needed for crbug/731170 to
define valid constraints.

This CL turns the definition of such variable into a more generally
available static constant.

Bonus: I am associating a new bug to the comment written on top rather
than keep it assigned to a specific user.

BUG=731170

Change-Id: Ib69fed0a44dfa7a11732221b7ef5d143c739abfd
Reviewed-on: https://chromium-review.googlesource.com/1209702Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Armando Miraglia <armax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589165}

Fixes an issue where the visibility change was not percolated to the
DialogOverlay, which prevented resuming DRM playback on certain cast systems
as described in the internal bug.

Bug=b:78571682
Test=made sure the repro steps actually work w. the CL

Change-Id: I7b2f06a5b4c4eb1fd4ffd32a587444e49d1ffcf8
Reviewed-on: https://chromium-review.googlesource.com/1204718
Commit-Queue: Andrei Pascovici <apascovici@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589164}

Sandboxing flag should be enabled through field trial config instead:
https://cs.chromium.org/chromium/src/testing/variations/fieldtrial_testing_config.json

Change-Id: Ic34d3b1b5b52275bbee644e2a763cc50fed127da
Reviewed-on: https://chromium-review.googlesource.com/1209546Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589163}

Also move mac_views_browser out of declare_args so that it can no longer
be forced to false, and add a comment saying that this variable is supposed
to go away.

Bug: 832676
Change-Id: Ie2a6340715d45aa913db77595f0d578aea899ca4
Reviewed-on: https://chromium-review.googlesource.com/1209982Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589162}

This CL changes the backoff behavior from "backoff after N consecutive
declines/ignores" to "backoff after N declines/ignores unless accepted
once"

Bug: 840367
Change-Id: I18d3d1ac10da566d55950a62f705dc1da3efa587
Reviewed-on: https://chromium-review.googlesource.com/1208711Reviewed-by: Michael Martis <martis@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589161}