- 02 Dec, 2020 40 commits
-
-
Joel Hockey authored
http://go/chrome-ss/8aec11c357971886d745aa9ea5b89356399956d2 Added restore-from-trash command which is shown in the Trash root as both a top bar action, and a file context menu command. Modified delete action so that it shows for Trash root (even though the Trash root FakeEntry is read-only), and added remove() and removeRecursively() functions to TrashEntry which deletes both the filesEntry and infoEntry. Background restore() code previously expected the supplied TrashItem would come only from the TrashItem returned by removeFileOrDirectory(), but now that it can be set directly from the restore-from-trash command, it requires a change to the TrashConfig lookup and path prefix validation. Bug: 953310 Change-Id: I2cdf018fd1daab8f57f0ab7f679d47eeba2109b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564841Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#832700}
-
Gavin Williams authored
The first iteration of Scan app will not support having two instances open at once so we will not allow the app to be opened in a browser tab. Bug: 1059779 Change-Id: I900e4a8d5d8f38460330d5a358ad12a9df1b3b19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568826Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#832699}
-
Esmael El-Moslimany authored
Bug: 1146987 Change-Id: I81866a1302d3029d169bb76bb1586f58675fa963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535190Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#832698}
-
Thanh Nguyen authored
This CL add the json ChromeOSReinstallApps json config so that we can start ramping up the experiment. Bug: 1154520 Change-Id: I3ee97832853334ad199657b70ac8375481f47a10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567144Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#832697}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1606813079-a344323d078b1a32606141a981583fdc5b0903fc.profdata to chrome-win32-master-1606856354-fc38cf84d3ff4fdfaa4b246b52b741b3d145638e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic954dbda8ffa332ed7ab938c12b84a6d7ecebadb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568642Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832696}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6d300e3738db..2f460d3c3411 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I3cee0164673db056ddd403bf2401b58568525208 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569036Reviewed-by:
-
Ramin Halavati authored
WebUIFactory is updated to deny bookmarks and new-tab-page for ephemeral Guest profiles. Please see go/ephemeral-guest-profiles for more context. Bug: 1125474 Change-Id: I2ca675330402d656eb2afc5a691e4d59a2385f1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567395Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#832694}
-
Koji Ishii authored
This patch adds |NGPhysicalBoxFragment::IsOutlineOwner|, by moving the logic from a static function in |NGOutlineUtils|. By exposing the |InlineContainerFragmentIfOutlineOwner|, |AddOutlineRectsForInlineBox| no longer needs to traverse all fragments. Instead, it now creates an |NGInlineCursor| only for the container fragment. This patch has no behavior changes. Bug: 1145048 Change-Id: Ia4a084d5708d870a38800bed3494bcd869daf175 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567842 Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#832693}
-
Adam Rice authored
The stable leg of the experiment that uses this histogram has been postponed until next year, so extend its life by 6 months. BUG=1140054 Change-Id: Ia7348b345141e4a90d9bc23d8efa77263698eb3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567540 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
-
Joel Hockey authored
Bug: 953310 Change-Id: I9631628ae0ae8697ffa1df445cda9b84896d2fe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567510 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
-
James Zern authored
this allows flagging the code with -msse4.1; fixes a build failure with clang-cl as for msvc builds sse4 support is assumed, but clang-cl requires the -m flag to enable it. Bug: 1151489 Change-Id: I3d29e5c3d4985b76ad44e9ca15886c0428c5c140 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561030 Commit-Queue: James Zern <jzern@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#832690}
-
Joel Hockey authored
The inProgress_ Set was meant to stop removeOldItems_() deleting entries which are currently in progress. For this to work properly, we must ensure that item are not removed from the inProgress_ Set whilst removeOldItems_() is running. The single Set is replaced with Map<string, Set> so that each TrashConfig is independent. Entries are only ever added to the set, which is deleted once removeOldItems_() is run for each TrashConfig. Bug: 953310 Change-Id: I2f07e7f3c3cf8733e3c91fade20f37d9ffc95afb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563390 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#832689}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a599cfcd6638..86ca37f5fef0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC hajimehoshi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: hajimehoshi@google.com Change-Id: I5b7149e8e6fe287f669372b90c1a292e4cc4e96a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568842Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832688}
-
Oriol Brufau authored
Before this patch, for an ephemeral range created with different but equivalent positions, IsCollapsed() would return false. Analogously, for a selection created with an extent different than but equivalent to the the base, IsCaret() would return false. This could result in SelectionTypeAdjuster::AdjustSelection trying to create an ephemeral range with an end position preceding the start one, producing a DCHECK failure. Therefore, this patch changes the EphemeralRangeTemplate constructor and SelectionTemplate::Builder::Extend so that the end (or extent) position is set to the start (or base) one if they are equivalent. However, this is not done if the start (or base) position is a <br>, since editing/deleting/delete_after_block_image.html would fail. Bug: 1143292 TEST=EphemeralRangeTest.EquivalentPositions TEST=SelectionTest.EquivalentPositions Change-Id: I3e9194b09c4bda893c05a70fdae858aa6aa22f21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550834 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
-
Alan Cutter authored
This CL updates Chrome OS default web apps to be deployed to Chrome OS's app surfaces (app list, app search and app management) while maintaining the "do not deploy to OS" logic for non-Chrome OS. This CL upstreams the "do not deploy to OS" logic in GetPreinstalledWebApps() up to ExternalWebAppManager::PostProcessConfigs() where it can apply to all preinstalled web app configs uniformally. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=478376&signed_aid=ic4Nc7r-RtFyMKtH3FYXtA==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=478378&signed_aid=VMFIAzHdQv62wv7H0Cvz7Q==&inline=1 Bug: 1153233 Change-Id: Idcbb0d15fc8d3f333d1d59e27b8ff624fe7b1c64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562625 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#832686}
-
Hajime Hoshi authored
BackForwardCache: Rename SchedulingPolicy::RecordMetricsForBackForwardCache to DisableBackForwardCache Bug: 1147300 Change-Id: I17c1578a3ea7b71a09f7640bafc6dc5ef076a949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567060Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#832685}
-
James Cook authored
The main IsAccessAllowedInternal function has several #if blocks. Extract the per-platform logic into IsAccessAllowedChromeOS() and IsAccessAllowAndroid() helper functions. This simplifies the #if blocks in the main function, and allows all #ifs to be positive-sense (no !defined anymore). No functional changes -- this is just cleanup before I add yet another #if for lacros. Bug: 1150934 Test: existing unit_tests Change-Id: Ic0fb5ad7cc2d8b1d566c12baf8a7c8cb0d8898f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568813 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#832684}
-
Megan Jablonski authored
page_needs_translation() tells us if translation is allowed, not if the page needs translation. It should be renamed to page_level_translation_critiera_met. We can offer translation if the page doesn't have notranslate and the determined language isn't empty. Bug: 1152884 Change-Id: I647b17f4775787d04f34ee2076b32d53b330af55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561293 Commit-Queue: Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#832683}
-
Thiabaud Engelbrecht authored
This is not used anywhere in skia, so we are adding it to blink. Another CL deletes this from skia. This code was originally called SkRWBuffer, and was written by reed@. The only semantic changes to this code made here is disallowing copying and assigning of RWBuffer, neither of which happens in blink. Bug: 1151405 Change-Id: I035b53f8bc8ab0829bce9bb73c46a5dd95ca65ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551847 Commit-Queue: Thiabaud Engelbrecht <thiabaud@google.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#832682}
-
Alan Cutter authored
This reverts commit e2bb0435. Reason for revert: Original revert did not fix the issue. Real fix was: https://chromium-review.googlesource.com/c/chromium/src/+/2566814 Original change's description: > Revert "Add WebApp.Preinstalled.UninstallAndReplaceCount UMA histogram" > > This reverts commit 1ca3c153. > > Reason for revert: > Needed to land parent CL revert: https://chromium-review.googlesource.com/c/chromium/src/+/2567511 > > Original change's description: > > Add WebApp.Preinstalled.UninstallAndReplaceCount UMA histogram > > > > This CL adds metrics for how often preinstalled web apps migrate and > > remove an existing app install. > > > > This data is useful to monitor rollouts of default web apps that are > > replacing old Chrome apps to ensure the migration is happening as > > expected. > > > > Bug: 809304, 1058265 > > Change-Id: Ie9edb4a1cf89e84d7e56a20bad028dd8ea1aeb07 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561999 > > Commit-Queue: Alan Cutter <alancutter@chromium.org> > > Reviewed-by: Glen Robertson <glenrob@chromium.org> > > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#832148} > > TBR=rkaplow@chromium.org,alancutter@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,glenrob@chromium.org > > Change-Id: I46c1a678e09111d210d1385bdb17ecc4fcabb093 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 809304 > Bug: 1058265 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567056 > Reviewed-by: Alan Cutter <alancutter@chromium.org> > Commit-Queue: Alan Cutter <alancutter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#832227} TBR=rkaplow@chromium.org,alancutter@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,glenrob@chromium.org Bug: 809304 Bug: 1058265 Change-Id: I1139aa9380a809a4f96ab5664aa279973a60a788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567281 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a3bcd1c0e2e9..6d300e3738db If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I5242eb36a88c09c97356ac7b3ad06ba29344f6da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568443Reviewed-by:
-
Yoshifumi Inoue authored
This patch Introduces |ExpandWithGranularity()| and |NormalizeRange()| as replacement of |CreateVisibleSelectionWithGranuarlity()| and |VisibleSelection::ToNormalizedEphemeralRange()| to reduce usage of |VisibleSelection| for improving code health. Bug: 657237 Change-Id: Id94727b8048e00a9b157900da9fbdd539aec2c0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567280 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#832679}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Ie93b81cf3475368708d9795bcbacc4f6e4bc3902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569034Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6d300e3738db..2f460d3c3411 2020-12-01 primiano@google.com Speculative fix of Chromium Windows build 2020-12-01 primiano@google.com Update CHANGELOG for v10.0 release 2020-12-01 treehugger-gerrit@google.com Merge "tracing: Add interceptor support" 2020-12-01 treehugger-gerrit@google.com Merge "export_json: Set valid pid for shared nodes event" 2020-12-01 treehugger-gerrit@google.com Merge "Skip KernelAddressSymbolization on non-debuggable builds" 2020-12-01 treehugger-gerrit@google.com Merge "base: GCC compatibility fix" 2020-12-01 treehugger-gerrit@google.com Merge "Make base::TempFile win-friendly" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:174454879 Tbr: perfetto-bugs@google.com Change-Id: Ifcfa21a04155c8f916202d02e058ee729648fa7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568294Reviewed-by:
-
Yann Dago authored
Change the title enterprise confirmation dialog. Remove the "Link Data" button. Change the "Create New Profile" label for "Add Work Profile". Add a default button style. Update the general wording of the enterprise notice. Screenshot After: http://screen/AnT3LURCFbXEQmr Screenshot Before : http://screen/5GcNmNjEVtjpvdQ Bug: 1148173 Change-Id: Ief01580cd50d8951ef82a94a6549552fd3aa0bd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521055 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#832676}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I390cd257ee8223be081f91d936c2fd9ef11d4d1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568834Reviewed-by:
-
Andrew Moylan authored
This feature has happy results at 1% stable. See crbug.com/937063#c37 for details & discussion. Also remove fieldtrial testing config. Bug: 937063 Change-Id: Id61da3286a9ce5239d1ad9715eeac5b2d7056bbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563194 Commit-Queue: Andrew Moylan <amoylan@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I156a2f8a8e7453a637f8a968fea9418dc85043a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569032Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832673}
-
Sam Sebree authored
This CL addresses an issue in which the disabled dark mode button control text color did not match the spec. Bug: 1115749 Change-Id: I68f496b404443afda3042ad5ba10399f86fd4351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567615Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Sam Sebree <sasebree@microsoft.com> Cr-Commit-Position: refs/heads/master@{#832672}
-
Alan Cutter authored
Reland "Refactor PendingAppManager to report did_uninstall_and_replace as part of its install results" This reverts commit 2cc14d7c. Reason for revert: Original revert did not fix the issue. Real fix was: https://chromium-review.googlesource.com/c/chromium/src/+/2566814 Original change's description: > Revert "Refactor PendingAppManager to report did_uninstall_and_replace as part of its install results" > > This reverts commit a3d1ec5d. > > Reason for revert: > Suspecting cause of Mac failures: > https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.11%20Tests/57728/overview > deterministic failures [caused step to fail]: > All/SystemWebAppLinkCaptureBrowserTest.AnchorLinkClick/_Default > All/SystemWebAppLinkCaptureBrowserTest.AnchorLinkClick/_WebAppInfoInstall > All/SystemWebAppLinkCaptureBrowserTest.AnchorLinkContextMenuNewTab/_Default > All/SystemWebAppLinkCaptureBrowserTest.AnchorLinkContextMenuNewTab/_WebAppInfoInstall > All/SystemWebAppLinkCaptureBrowserTest.AnchorLinkContextMenuNewWindow/_Default > All/SystemWebAppLinkCaptureBrowserTest.AnchorLinkContextMenuNewWindow/_WebAppInfoInstall > All/SystemWebAppLinkCaptureBrowserTest.CaptureToOpenedWindowAndNavigateURL/_Default > All/SystemWebAppLinkCaptureBrowserTest.CaptureToOpenedWindowAndNavigateURL/_WebAppInfoInstall > All/SystemWebAppLinkCaptureBrowserTest.ChangeLocationHref/_Default > All/SystemWebAppLinkCaptureBrowserTest.ChangeLocationHref/_WebAppInfoInstall > All/SystemWebAppLinkCaptureBrowserTest.IncognitoBrowserOmniboxLinkCapture/_Default > All/SystemWebAppLinkCaptureBrowserTest.IncognitoBrowserOmniboxLinkCapture/_WebAppInfoInstall > All/SystemWebAppLinkCaptureBrowserTest.OmniboxPasteAndGo/_Default > All/SystemWebAppLinkCaptureBrowserTest.OmniboxPasteAndGo/_WebAppInfoInstall > All/SystemWebAppLinkCaptureBrowserTest.OmniboxTypeURLAndNavigate/_Default > All/SystemWebAppLinkCaptureBrowserTest.OmniboxTypeURLAndNavigate/_WebAppInfoInstall > All/SystemWebAppLinkCaptureBrowserTest.WindowOpen/_Default > All/SystemWebAppLinkCaptureBrowserTest.WindowOpen/_WebAppInfoInstall > All/SystemWebAppLinkCaptureBrowserTest.WindowOpenFromOtherSWA/_Default > All/SystemWebAppLinkCaptureBrowserTest.WindowOpenFromOtherSWA/_WebAppInfoInstall > All/SystemWebAppManagerAdditionalSearchTermsTest.AdditionalSearchTerms/_Default > All/SystemWebAppManagerChromeUntrustedTest.Install/_Default > All/SystemWebAppManagerFileHandlingOriginTrialsBrowserTest.FileHandlingWorks/_Default > All/SystemWebAppManagerLaunchDirectoryBrowserTest.LaunchDirectoryForSystemWebApp/_Default > All/SystemWebAppManagerLaunchDirectoryBrowserTest.ReadWritePermissions_OrdinaryDirectory/_Default > All/SystemWebAppManagerLaunchDirectoryBrowserTest.ReadWritePermissions_SensitiveDirectory/_Default > All/SystemWebAppManagerLaunchFilesBrowserTest.LaunchFilesForSystemWebApp/_Default > All/SystemWebAppManagerNotShownInSearchTest.NotShownInSearch/_Default > All/SystemWebAppManagerOriginTrialsBrowserTest.ForceEnabledOriginTrials_FirstNavigationIntoPage/_Default > All/SystemWebAppManagerOriginTrialsBrowserTest.ForceEnabledOriginTrials_IntraDocumentNavigation/_Default > ... 12 more (42 total) ... > > > Original change's description: > > Refactor PendingAppManager to report did_uninstall_and_replace as part of its install results > > > > This CL updates PendingAppManager to return an InstallResult struct > > instead of just an InstallResultCode. This struct contains an additional > > bool to indicate whether the app installation uninstalled and replaced > > an old app. > > > > This is in preparation to add a > > WebApp.Preinstalled.UninstallAndReplaceCount UMA histogram: > > https://chromium-review.googlesource.com/c/chromium/src/+/2561999 > > > > There are three refactors and no behavioural changes in this CL: > > - PendingAppManager::InstallResult struct added to replace > > InstallResultCode. > > - PendingAppInstallTask::Result removed in favour of passing > > base::Optional<AppId> app_id, PendingAppManager::InstallResult result > > params. > > - WebAppUiManager::UninstallAndReplaceIfExists() now returns a bool > > indicating whether it did anything. > > > > Bug: 809304, 1058265 > > Change-Id: I4d46052be13f86122215d3ef93eddcadc5f2fa2f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563148 > > Reviewed-by: Azeem Arshad <azeemarshad@chromium.org> > > Reviewed-by: Glen Robertson <glenrob@chromium.org> > > Commit-Queue: Alan Cutter <alancutter@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#832095} > > TBR=alancutter@chromium.org,azeemarshad@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,glenrob@chromium.org > > Change-Id: I0cb65468451b6c93360e34e2ad50a3b2c513d82d > Bug: 809304 > Bug: 1058265 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567511 > Reviewed-by: Alan Cutter <alancutter@chromium.org> > Reviewed-by: Glen Robertson <glenrob@chromium.org> > Commit-Queue: Alan Cutter <alancutter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#832247} TBR=alancutter@chromium.org,azeemarshad@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,glenrob@chromium.org # Not skipping CQ checks because this is a reland. Bug: 809304 Bug: 1058265 Change-Id: I3276a9d3137cbf64accfe146da449584f0b13172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566402Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
-
Luciano Pacheco authored
Bug: 1133186 Change-Id: I946ef11bb82102fc589746e7e38a5f891380293a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560525 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#832670}
-
Alan Cutter authored
This CL enables the migration from default installed Chrome apps to default installed web apps. This still needs feature launch approval: - Chrome OS: https://crbug.com/1099150 - Desktop: https://crbug.com/1130075 This migration is being enabled to get test coverage and user reports in canary. If this is not approved by branch point it will be disabled again. Test: ExternalWebAppMigrationBrowserTest Bug: 1058265, 809304 Change-Id: I22f8b43631708a40b5333a7ce1bd4177e9792b49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562922Reviewed-by:
-
Hiroki Nakagawa authored
This is a cleanup and doesn't change functionalities. Before this change, each browser test case had its own html file that triggers <link rel=prerender>. This was not scalable. After this change, browser tests share the common html file that can dynamically add <link rel=prerender> from C++. In addition to that, this CL factors out common routines into helper functions. Bug: 1132746 Change-Id: I7aea316da481c86832314384f2d2d997c30deaea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567054 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#832668}
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 89-4324.9-1606128713-benchmark-89.0.4337.0-r1 to 89-4324.9-1606733211-benchmark-89.0.4337.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Icb50b506bb742085e2a8d83b2fa204825621e78d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568473Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d7b599b52009..a599cfcd6638 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC hajimehoshi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1122784,chromium:1148325,chromium:1153908 Tbr: hajimehoshi@google.com Change-Id: I15fa437bb7c5c9a69af0290fb720d0f47158a2d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568837Reviewed-by:
-
Oriol Brufau authored
The PositionInFlatTree(const Node*, int) constructor checks the node with CanBeAnchorNode(). And for EditingInFlatTreeStrategy, this uses node->CanParticipateInFlatTree(), which may be a null deref. Therefore, this patch changes it to check whether the node is null. Change-Id: Icf908f586641c9b1b57ac9ae1bf4e0ea9a0f1893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567220 Auto-Submit: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
-
Hajime Hoshi authored
This reverts commit 71033a0d. Reason for revert: crbug.com/1154524 Original change's description: > Re-enable same origin subframe isInputPending WPT > > Now that the event wait time has been increased, this test should be less flaky. Re-enable it accordingly. > > Bug: 1124978 > Change-Id: I221ea9cb96106801d9266e94447660c323ecdd97 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567110 > Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> > Commit-Queue: Andrew Comminos <acomminos@fb.com> > Cr-Commit-Position: refs/heads/master@{#832622} TBR=npm@chromium.org,acomminos@fb.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I0579294db97125f406f1fac715563b6eba83c7b9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1124978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566869Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#832664}
-
Mitsuru Oshima authored
https://chromium.googlesource.com/external/anongit.freedesktop.org/git/wayland/wayland.git/+log/e091839dd083..eb1339edd398 $ git log e091839dd..eb1339edd --date=short --no-merges --format='%ad %ae %s' 2020-02-12 contact build: bump to version 1.18.0 for the official release 2020-02-05 contact build: bump to version 1.17.93 for the RC1 release 2020-02-04 contact autotools: add Meson files to EXTRA_DIST 2020-01-28 contact build: bump to version 1.17.92 for the beta release 2019-09-10 contact tests: fix memory leak in proxy-test 2020-01-17 ihor os: fallback for unsupported posix_fallocate 2020-01-22 linkmauve Remove unused HAVE_CONFIG_H define in meson 2020-01-21 contact build: bump to version 1.17.91 for the alpha release 2020-01-13 contact protocol: add missing enums for wl_data_device_manager.dnd_action 2019-12-25 code event-loop-test: Add test to verify timer ordering 2019-12-21 code event-loop: Track timer event sources in userspace 2020-01-16 code event-loop-test: Confirm distant timers do not fire 2020-01-03 code event-loop-test: Verify proper timer cancellation 2020-01-13 contact build: check wayland-scanner version 2020-01-13 contact autotools: use strict wayland-scanner mode 2020-01-13 contact meson: use strict wayland-scanner mode 2020-01-11 code tests: Ensure that overflow test always overflows 2019-12-24 code tests: Fix race condition in send overflow test 2020-01-13 contact Revert "build: check wayland-scanner version" 2020-01-13 contact build: check wayland-scanner version 2020-01-13 daniels display-test: Remove unused variables 2018-04-23 ebassi Add Meson build 2019-03-11 pekka.paalanen scanner: include config.h from command line 2018-04-23 ebassi Support running tests from different build directories 2018-07-22 daniels build/doc: Ensure destination dir exists despite VPATH 2020-01-04 asynts doc: Expand the abbreviation "hw" to "hardware". 2020-01-02 mforney protocol: fix typo in wl_data_offer.set_actions description 2019-11-05 JPEWhacker Move wl_priv_signal to wayland-server-private.h 2019-10-25 JPEWhacker scanner: Add configure check for strndup 2019-10-24 renjiayuan1314 adding O_RDWR flag in the open() 2019-09-10 contact tests: add a test for wl_global_remove 2019-07-20 contact server: add wl_global_remove 2019-07-22 linkmauve wayland-shm: Don’t set SIGBUS handlers on unshrinkable fd 2019-07-22 contact server: add wl_global_set_user_data 2019-09-16 m.giordano Add $(RT_LIBS) to fixed-benchmark LD dependencies 2019-05-11 hanetzer scanner: prepend protocol name to types symbol 2019-08-18 code tests: Test that send overflow doesn't abort 2019-07-13 code client: Don't abort when sending a request fails 2019-07-13 code client: Ignore new requests if display has a fatal error 2019-07-11 contact protocol: invalid_method is sent on malformed request 2019-09-03 simon.ser tests: test that binding to a global with an interface mismatch fails 2019-08-28 simon.ser server: check global interface on bind 2019-09-02 contact protocol: sync wl_shm.format with libdrm 2.4.99 2019-09-02 contact protocol: add a comment about the wl_shm.format script 2019-09-02 contact Add an automated script to update wl_shm.format 2019-09-02 contact Update .editorconfig for Python 2019-08-28 simon.ser client: check event opcode in queue_event 2019-08-26 liuwl.fnst server: Fix fake "Address already in use" error 2019-08-02 sir Improve description of wl_surface 2019-08-02 sir Add .editorconfig 2019-07-29 sir Document unusual wl_registry.bind new_id behavior 2019-07-10 jadahl proxy: Add API to tag proxy objects 2019-02-16 linkmauve cursor: Use memfd_create() when available 2019-07-05 code connection: do not abort when dup(fd) fails 2019-05-13 scott.anderson wayland.xml: Make releases for multiple 'wl_surface.attach' undefined 2019-07-05 code protocol: clarify wl_display.delete_id description 2019-06-01 mforney Avoid pointer arithmetic on `void *` 2019-06-01 mforney Use wl_container_of internally 2019-05-31 orbea Add a missing -pthread to fix compile with slibtool. 2019-04-26 borneo.antonio log: remove "%m" from format strings by using strerror(errno) 2019-04-13 code tests: Verify that wayland_scanner can catch bad identifiers 2019-04-13 code scanner: error when element names will not compile 2018-09-29 contact protocol: allow to send a zero output refresh rate 2019-04-19 harishkrupo wayland.xml: document invalid_finish error in wl_data_offer.finish 2019-04-19 harishkrupo docs: Abort configure if docbook-xsl package is missing 2019-04-12 contact releasing: fixup section numbers 2019-04-11 contact releasing: adapt for Wayland 2019-04-08 contact Add releasing.txt 2019-04-08 pekka.paalanen configure.ac: reopen master for regular development 2019-02-25 mazocomp configure: detect libdl and librt Created with: roll-dep src/third_party/wayland/src Also updted the protocol files per README.chromium instruction. Change-Id: Ibe44c8f84f4962688c9d6115109c0cb11b16194f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552372Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#832663}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ac41b8da..d4fd978f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I66ac658384115fd4494405457db11dae23a1065c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568631Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832662}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1606834243-e828e7c1abf6992c40e6e24872b0e913b727a4f7.profdata to chrome-win64-master-1606856354-2e9ef696f065b87bf554fe505ea1d147a1b0c51a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iebfdc62e9cddd8e58e71e3cbd072cc11835ff2ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568386Reviewed-by:
-
