- 06 Jun, 2018 40 commits
-
-
Josh Karlin authored
What: If two tasks have the same priority, they should run in posting order. A second thing this CL does is fix a race in the unittests. I meant to block the task runner before queueing up requests but failed to. Fixed here. Why: This can prevent hypothetical task starvation. It's also necessary for the SimpleCachePrioritization control group to ensure that we maintain old behavior. Bug: 850085 Change-Id: I1f259296604bf04ea33ecbee9ad3180f064c4266 Reviewed-on: https://chromium-review.googlesource.com/1088759 Commit-Queue: Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#564933}
-
Xida Chen authored
This CL adds a new layout test to make sure that the following APIs: lineWidth lineDash lineDashOffset works properly with browser zoom. Bug: 849706 Change-Id: I07c07e688203c26b2b2223377da88591a44a4e55 Reviewed-on: https://chromium-review.googlesource.com/1088870Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#564932}
-
Nico Weber authored
Run headless_browsertests, headless_unittests on the the clang tot bots, and on some memory bots. Both suites are very leaky, so they don't run on asan bots, and headless_browsertests is also very racy so it doesn't run under tsan, but headless_unittests runs under tsan. Both run under msan and cfi. They also run under asan/mac, which seems to be happy. This is part of an effort to reduce the number of test configurations. Originally reviewed as part of https://chromium-review.googlesource.com/1061795, which I'm now landing in smaller pieces. TBR=kbr Bug: 843511,843732,843734 Change-Id: I3ba57446830d44f3651100e216f1d546ee7532b6 Reviewed-on: https://chromium-review.googlesource.com/1088754 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#564931}
-
Nico Weber authored
mojo_core_unittests was added to the main waterfall in https://chromium-review.googlesource.com/c/chromium/src/+/978368/11, but not to the main and clang tot waterfalls. Things that run on the main waterfall should run on the memory bots (needed to check correctness), and they must run on the clang tot waterfall to make sure new compilers don't break them. Bug: 843511,822034 Change-Id: I4431298f53d967e4aa3d7fa3b98c3d4a27ffb9bb Reviewed-on: https://chromium-review.googlesource.com/1088761 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#564930}
-
Katie D authored
Bug: 849893 Change-Id: Iaf8c30493e383e754940afbb928994c9ffcd12fd Reviewed-on: https://chromium-review.googlesource.com/1087325 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#564929}
-
Evan Stade authored
Only support native notifications, i.e. those passed over mojo. Some tests are permanently removed on Chrome OS. Some tests are migrated to message_center_unittests. Bug: 578868 Change-Id: Ibd4edcd1968c94af2d24b15ed3c1329ea7bf49b1 Reviewed-on: https://chromium-review.googlesource.com/1083937Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#564928}
-
Alexis Hetu authored
Now that synchronization issues have been fixed on MacOS, most previously disabled layout tests can be re-enabled. TBR=kbr@chromium.org Bug:chromium:726075 chromium:646528 chromium:845267 chromium:614910 chromium:845266 chromium:791941 chromium:847094 chromium:849256 Change-Id: Ifa59c2594c429a94643ea9f19b2e08e974cc6c53 Reviewed-on: https://chromium-review.googlesource.com/1088197Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#564927}
-
Justin Cohen authored
Undefined keychain types are now defined in the iOS12 SDK, and annotated as unavailable on iOS. Remove the types that aren't used by mac or ios, and redefine the ones used by mac so it can be typedef-ed away on ios. Bug: 843234 Change-Id: If94222cde31a89185ce2f9bd6d77af8ac7c41fd7 Reviewed-on: https://chromium-review.googlesource.com/1087927 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#564926}
-
Ted Choc authored
In my local testing, the translate infobar was showing up on the webpage because it uses latin placeholder text. This reworks the infobar check to not check for an exact count, but to look for infobars of a particular type. BUG=771103 Change-Id: Ia6544c386e9e8288f7980a2c14e0b0fba0b14e98 Reviewed-on: https://chromium-review.googlesource.com/1087684Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#564925}
-
Tetsui Ohkubo authored
This CL fixes ShowSystemTrayOnPrimaryLoginScreen when UnifiedSystemTray is enabled. A system tray should not SetVisible(true) before UpdateAfterLoginStatusChange is called. TEST=LoginScreenControllerNoSessionTest.ShowSystemTrayOnPrimaryLoginScreen (--enable-features=SystemTrayUnified) BUG=847104 Change-Id: I2ca02dd55def1385e769f00604cd42281413d8b7 Reviewed-on: https://chromium-review.googlesource.com/1088266 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#564924}
-
Tetsui Ohkubo authored
In the unit test, focusing in status area widget was tested using NotificationTray button and SystemTray button. As they are consolidated in UnifiedSystemTray, the test did not work with the flag enabled. This CL fixes the test to use IME tray button so it keeps working with UnifiedSystemTray. TEST=StatusAreaWidgetFocusTest.FocusOutObserver (--enable-features=SystemTrayUnified) BUG=847104 Change-Id: I8d8d3f274153daeb66ebc594d23b7ce4787a2cac Reviewed-on: https://chromium-review.googlesource.com/1088331Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#564923}
-
Keishi Hattori authored
Bug: 849627 Change-Id: I03070180380f739f079ca8e04011a94696ea7a08 Reviewed-on: https://chromium-review.googlesource.com/1088271 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#564922}
-
Peter Kvitek authored
Page.setFontFamilies method overrides default settings for generic font families. Change-Id: I17645126b1d9fd19b07322c521322ed47e9b73d8 Reviewed-on: https://chromium-review.googlesource.com/1086212 Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#564921}
-
Maks Orlovich authored
Those were important when how packing streams 0 and 1 together was going to work was being designed, but that's long been done now. Bug: 849518 Change-Id: I41b21bc0b7235725f1650490e64f4cd243ee59ab Reviewed-on: https://chromium-review.googlesource.com/1087581Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#564920}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/74ed554..8ae3209 git log 74ed554..8ae3209 --date=short --no-merges --format='%ad %ae %s' 2018-06-06 tsepez@chromium.org Better error reporting on XFA JS errors Created with: gclient setdep -r src/third_party/pdfium@8ae3209 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I540ea25f51b519916f68e7054dbd6e47f45bdf3f Reviewed-on: https://chromium-review.googlesource.com/1088210Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564919}
-
Joe Downing authored
This CL contains a base class and unittests for generating a keyboard layout map for the KeyboardMap API. It also includes a a Windows implementation which uses the base class. BUG=832811 Change-Id: I7ff20cf8b2a34cf8c7a9bbe9609e40f39bb89634 Reviewed-on: https://chromium-review.googlesource.com/1077596 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#564918}
-
Koji Ishii authored
This patch fixes InsertRunForTesting inserts glyph data in the incorrect order for RTL. Fixing it discovers errors in Next/PreviousSafeToBreakOffset(), and that they are fixed as well. Bug: 636993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Idc0d7e6f0e653542a4aa93e1ee53d257848f3342 Reviewed-on: https://chromium-review.googlesource.com/1088718 Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#564917}
-
Amy Qiu authored
Due to https://chromium-review.googlesource.com/c/chromium/src/+/1084057, rendering_shared_state needs to be updated to directly call GetSystemInfo(), the way webgl_supported_shared_state does. Bug: 849392 Change-Id: I9c974fb42a52522c203dd4dcdbdb49cc1d95bd5b Reviewed-on: https://chromium-review.googlesource.com/1088209Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Amy Qiu <amyqiu@google.com> Cr-Commit-Position: refs/heads/master@{#564916}
-
David Tseng authored
Bug: 849726 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie758887410ce95bd4650e46c31a3d81c9b450930 Reviewed-on: https://chromium-review.googlesource.com/1087499Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#564915}
-
Adithya Srinivasan authored
This reverts commit 75d3f6c9. Reason for revert: Causes crashes: https://crash.corp.google.com/browse?q=expanded_custom_data.ChromeCrashProto.magic_signature_1.name%3D%27blink%3A%3ADocument%3A%3ASetFocusedElement%27+AND+expanded_custom_data.ChromeCrashProto.ptype%3D%27renderer%27+AND+product.Version%3D%2769.0.3451.0%27 Original change's description: > Crash when SetFocusedElement is called during layout > > I think the crash in https://crbug.com/848212 is caused due to > Document::focused_element_ being cleared out during the > UpdateStyleAndLayoutIgnorePendingStylesheetsForNode call in > Document::SetFocusedElement, but I'm unable to reproduce a situtation > where this happens. This CL adds a CHECK that crashes when > SetFocusedElement is called during UpdateStyleAndLayout, just so I can > get some stack traces in the wild and confirm this theory. > > Bug: 848212 > Change-Id: Ia9293ea155e4ae976592166e7ab4f936f25f3f38 > Reviewed-on: https://chromium-review.googlesource.com/1085607 > Commit-Queue: Kent Tamura <tkent@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#564337} TBR=tkent@chromium.org,adithyas@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 848212 Change-Id: Ie0ee4b7e3fa8e6dd94a8f8a04e6866743f38440d Reviewed-on: https://chromium-review.googlesource.com/1088950Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#564914}
-
Lukasz Anforowicz authored
Before this CL, the name of the method was ambiguous (i.e. what exactly is meant by "connection") and incorrect (some aspects of connectivity like queueing of IPCs are set up in the constructor of RenderProcessHostImpl, before |is_initialize_| is true and before HasConnection / IsInitializedAndNotDead returns true). After this CL, the name of the method will much closer match the implementation: bool RenderProcessHostImpl::IsInitializedAndNotDead() const { return is_initialized_ && !is_dead_; } Bug: 840409 Change-Id: Id1d7752f7b55a4d139aeba4d56d25c68b804ff8d Tbr: reillyg@chromium.org Tbr: sky@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1083348 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#564913}
-
Chris Hamilton authored
BUG=749785 Change-Id: Ie89ec2c4869851e5734fde94656052e933faac96 Reviewed-on: https://chromium-review.googlesource.com/1088970Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#564912}
-
Anthony Vallee-Dubois authored
Bug: 848859 Change-Id: Ic242ff51351de2de5db6fd80e7f3d045b995eb04 Reviewed-on: https://chromium-review.googlesource.com/1082819 Commit-Queue: anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#564911}
-
Nico Weber authored
- Don't run gin_unittests on the cros asan bot instead of suppressing all test results in the lsan_suppressions file to be consistent with how we suppress the test on the linux asan bot - Do run gin_unittests on ToTLinux and ToTLinuxMSan since the test runs fine on the main waterfall linux and msan bots. Bug: 843511,831667,831667 Change-Id: I224916e5fcf3d41654c2b042524cb896b9702db1 Reviewed-on: https://chromium-review.googlesource.com/1088756Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#564910}
-
Tetsui Ohkubo authored
Browser test requires all focusable views to have appropriate a11y texts. For EnterpriseManagedView, we manually override tooltip text, but it was not properly configured as a11y data. We can fix this by just using Button's SetTooltipText. TEST=SystemTrayClientEnterpriseTest.TrayEnterprise (--enable-features=SystemTrayUnified) BUG=847104 Change-Id: I8eb0e051446e4fcff4be691bf42e7af9fe99b8dd Reviewed-on: https://chromium-review.googlesource.com/1088328Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#564909}
-
Justin Cohen authored
Limit to 10.13.4 or 10.13.5. NOTRY=true Bug: 843236 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4319717afc3ad7d8fa64e2276c3b877d5f7b6837 Reviewed-on: https://chromium-review.googlesource.com/1089037 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#564908}
-
Tetsui Ohkubo authored
This CL adds right/left shelf alignment support for UnifiedSystemTray. TEST=PanelLayoutManagerTest.TouchHitTestPanel (--enable-features=SystemTrayUnified) BUG=847104 Change-Id: I69d2755dd18d40508c3183ae08a75eef732dcce8 Reviewed-on: https://chromium-review.googlesource.com/1086900Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#564907}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/01ad164d..830256ae Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ia3311b80b1cb35eb2652f5be94a422a809d5f272 Reviewed-on: https://chromium-review.googlesource.com/1088760Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#564906}
-
Amy Qiu authored
Copy polymer.py into the rendering folder and refactor classes to inherit from RenderingStory. Leave original polymer.py in page_sets folder for now because key_hit_test_cases needs it. Bug: 849392 Change-Id: I356f9887849cffb6f576f4c0d6567e3f185e818d Reviewed-on: https://chromium-review.googlesource.com/1087649Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Amy Qiu <amyqiu@google.com> Cr-Commit-Position: refs/heads/master@{#564905}
-
Rayan Kanso authored
Cleanup more thoroughly when a registration is deleted. - All associated information in the ServiceWorker database - The cache created to store responses. Bug: 848280 Change-Id: I394651edb5be07cf7d2352ab10b5e232a027e158 Reviewed-on: https://chromium-review.googlesource.com/1088705 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#564904}
-
Steven Bennetts authored
This allows the image source to be available to Tether notifications. This also adds kTrayImageBgAlpha to ash_constants.h for use in all tray icon code. Bug: 826370 Change-Id: Ib3acedfc9c87e2e6f826cc6d2190a3be0a20eba8 Reviewed-on: https://chromium-review.googlesource.com/1082655Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#564903}
-
Robert Kroeger authored
It is possible to build and run CrOS/Chrome on a Linux DRM system with Nouveau. Add docs describing the approach. Bug: 848856 Change-Id: I2e8a0a11e3e939a57023e5b744a2fbead3d62264 Reviewed-on: https://chromium-review.googlesource.com/1083552 Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#564902}
-
Rohit Rao authored
The interaction controller is functionally acting as a coordinator, so BookmarkHomeViewController now uses it to present editor view controllers. BookmarkInteractionController supplies APIs to present an editor for a given BookmarkNode and abstracts away the actual presentation and specific view controller subclasses used. BUG=805182 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie7c7200766439d0acd161a1c94d20249a17d861e Reviewed-on: https://chromium-review.googlesource.com/1081013 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#564901}
-
Ehsan Chiniforooshan authored
This CL adds the new TBMv2 rendering metrics to the set of legacy smoothness and thread-times metrics that are currently used in the rendering benchmark. This is a temporary situation to verify that the new metrics catch regressions correctly before retiring old thread-times metrics. Bug: chromium:760553 Change-Id: I3cd37e632f328fa79919d936cbe5714b8b742ed5 Reviewed-on: https://chromium-review.googlesource.com/1054253 Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Reviewed-by:
Ben Hayden <benjhayden@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#564900}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0211346..096a6c8 git log 0211346..096a6c8 --date=short --no-merges --format='%ad %ae %s' 2018-06-06 yunchao.he@intel.com ES31: copy to a texture with RGB9_E5 internalformat is invalid. Created with: gclient setdep -r src/third_party/angle@096a6c8 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Ieba599041bde4841bc23c5e89ca537015deaef45 Reviewed-on: https://chromium-review.googlesource.com/1088830Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564899}
-
Nico Weber authored
This is part of an effort to reduce the number of test configurations. Originally reviewed as part of https://chromium-review.googlesource.com/1061795, which I'm now landing in smaller pieces. TBR=kbr Bug: 843511 Change-Id: Ifb26ba762a05686fa751f2bde902f36fc868fdb5 Reviewed-on: https://chromium-review.googlesource.com/1088758Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#564898}
-
Scott Violet authored
When a remote client creates a window, the remote client should control when it is closed. This makes it to so that when the user attemps to close a window created by a remote client, the remote client is asked to close the window. BUG=842298 TEST=covered by test Change-Id: I9ace655c0648fc0f8943425c67fb57e088ef00fa Reviewed-on: https://chromium-review.googlesource.com/1087870 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#564897}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7052b23c. With Chromium commits locally applied on WPT: e8832df8 "webrtc wpt: remove test_state_change_event" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19121 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=foolip No-Export: true Change-Id: I7ec108d1d00c983558ebfc0c5c0c462942c56587 Reviewed-on: https://chromium-review.googlesource.com/1088208 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#564896}
-
Alexander Potapenko authored
TSan error reports involve destruction stacks, which means the same tests may crash on other builders. TBR=nasko@chromium.org Bug: 847326 Change-Id: Ibac5d6eb25232ece33029eea2a563ab72a6d79f1 Reviewed-on: https://chromium-review.googlesource.com/1088915 Commit-Queue: Alexander Potapenko <glider@chromium.org> Reviewed-by:
Alexander Potapenko <glider@chromium.org> Cr-Commit-Position: refs/heads/master@{#564895}
-
Ramya Nagarajan authored
Verifies that observer list is empty on service shutdown. Change-Id: If379ca134bf42cfde3bf76cedffaedf0696409fc Reviewed-on: https://chromium-review.googlesource.com/1087437 Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#564894}
-