- 09 Jun, 2020 40 commits
-
-
Haiyang Pan authored
Bug: 954217 Change-Id: I493798fb9e901c68455cc2f1b2772b956fd240ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238422 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#776751}
-
Stefan Zager authored
They aren't needed, and they introduce flakiness. BUG=1059044 Change-Id: I988866c0da79adafb493c9ba1d263c19ecf8c033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2191735 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#776750}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ic822fa19561666ffa635b3f084a04356ad3f3268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238762Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776749}
-
Erik Chen authored
This config change is necessary to successfully compile lacros. This CL also comments out an inappropriately failing assert. Change-Id: Ibe3a18f9cdcebcb0864bb744c918d540177952b4 Bug: 1093038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238380 Commit-Queue: Erik Chen <erikchen@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#776748}
-
Taylor Bergquist authored
Many rough edges, which I'll document somewhere and fix. Crashes unless the #scroll-unification flag is enabled. Bug: 951078 Change-Id: If8570648b62fe435b9ca9c03b483e7a503012362 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236237Reviewed-by:
Collin Baker <collinbaker@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#776747}
-
Matt Jones authored
Bug: 1002277 Change-Id: I70219c5eef14630f8fd1584d2af085c4a9c3ae21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236503 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#776746}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I88261059ebbadd939908e8f152e729056f14194f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238888Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f8fd9cfb25a0..d80d9044857e 2020-06-09 etienneb@chromium.org Reland "Add trace event to angle Program compilation API" 2020-06-09 jmadill@chromium.org Update glslang_validator binary for Windows. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1064662,chromium:1091723 Tbr: cnorthrop@google.com Change-Id: I31aa040fba5eff0ca658aeb51623ef852b0808cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238613Reviewed-by:
-
Jeremy Roman authored
Change-Id: If33452721935f67d46642507442decae9b8426a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238498 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#776743}
-
Tommy Li authored
With this CL, temporary text works correctly now when tabbing through a suggestion list containing headers. The temporary text won't change while moving ONTO a header, and will update while moving OFF of a header. In other words, the temporary text only changes when moving onto the bona-fide match, and not when just tabbing onto the header. This also adds a test onto OmniboxPopupModelTest to verify this new behavior (as well as the old temporary text behavior in general). Bug: 1078183, 1052522 Change-Id: Idf2e64ccd728f2c35aaa4f34a10850de2301c64e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238846Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#776742}
-
danakj authored
This is a reland of 072a75f6 The test was written in a flaky way, this adds a wait for the row removal to happen before finishing the test. It's rebaselined to match this expectation, which was previously considered a flaky failure. Original change's description: > Re-enable and re-baseline table_overflow_dirty_reflow_tbody.html > > The test has new expectations as mock scrollbars have been removed. We > expect it's not flaky with the improvements made to the test harness > and site isolation. If it is flaky, we will investigate. > > R=vmpstr@chromium.org > > Bug: 891427 > Change-Id: I4791036524bcae1095f26b534d4416d941178bea > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232749 > Commit-Queue: danakj <danakj@chromium.org> > Reviewed-by: vmpstr <vmpstr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#776285} Bug: 891427 Change-Id: I892ef5233b86104dad8963186939be5c6123b38c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238022 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#776741}
-
Sreeja Kamishetty authored
This CL disables BackForwardCache when SpeechSynthesis API is used, as we believe that we do not handle the speech recognition properly when the page is put into BackForwardCache. Supporting the SpeechSynthesis feature is to be compatible with BackForwardCache is the next step. BUG=1091009 Change-Id: Id3fa13a6a7c7c44a0cf74eda6b8a1683746f98d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229433 Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#776740}
-
Robert Ma authored
1. artifacts["log"] now contains the full logs, including the harness status and passing subtests. 2. Base64-encoded reftest screenshots, if present, are now stored in artifacts["screenshots"]. R=lpz Change-Id: I6da1ba9e87f0dfbf1b1579d25f173d057c4e79e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225741 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#776739}
-
Jenny Zhang authored
This is how the single app folder is created: The single app item folder happens when a new user sign on a device for the first time, if a folder has two apps in it, one of the app takes less time to install than the other. After the first app is installed, app list item will be created for the app in app list model and user will see a single app folder on launcher page. If user removes it from the folder, the sync item of the app will be updated to be moved out of the folder, the folder will disappear on launcher page. Since the second app is not installed yet, it is not in app list model at this time. Later, when the second app is installed, it is still associated with the original folder, therefore, it shows up in a single app folder. On the other devices, when the update of the first app (moving out of the folder) is synced across, it will also show a single app folder. Our fix: When user removes the first app from chrome app list model and update its sync item, we check the sync data to see if the original folder will become a single item folder after that. If so, we update the sync item of the remaining app by moving it out of the folder and place it at the same location of its original folder. Later, when the second app is installed, it will show up at the top level at same spot as its original folder. Also the change will be synced to other devices and the second app will be moved to top level as well. Bug: 1082530 Change-Id: I764fc6c4111f5f76b028b53209ad8ce2abc8ad86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236993Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#776738}
-
Hazem Ashmawy authored
This records the timediff for histograms since they are first recorded using UmaRecorder in a non-embedded WebView process till they are actually sent to UMA in an embedded WebView. This required adding a Metadata field to the HistogramRecord proto. A small refactor is made to allow injecting a delegate to AwNonembeddedRecorder to allow mocking actions like adding metadata and service name in testing. Fixed: 1084757 Test: bin/run_webview_instrumentation_test_apk -f "*AwNonembeddedUmaRecorderTest*" Change-Id: Id96a3eb9a7d0831a0b8db0a181baf313881f2844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226737 Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#776737}
-
Dominique Fauteux-Chapleau authored
Bug: 1088082 Change-Id: I981e01ac0edb837c063febe8838ad67b7b1cd907 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231538Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#776736}
-
Li Lin authored
For some units, server doesn't always trigger unit conversion. We would like to force conversion in this case. Bug: b/158529218 Test: unit tests Change-Id: I553fcb09b3f36009682c54c64e0eab8de1963fe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238748 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
-
Asanka Herath authored
A prior CL introduced a concept of an IdentifiableToken. This CL introduces an incremental token builder that can be used to generate such a token based on disjoint buffers or objects. Bug: 973801 Change-Id: I9394878f36748fd2d97f2b220d1d57444bf7600f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214426 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
-
Matt Jones authored
This patch moves all of the chrome-based dependencies from the BottomSheetControllerImpl to BottomSheetManager. This will allow the impl class to be moved to an internal build in components. Facilitating this is a change to make suppression token based. With tokens, the glue code (BottomSheetManager) doesn't have to track whether each feature suppressing the sheet is gone; this is tracked by the impl class. If any tokens are acquired, the sheet is hidden and stays hidden until all tokens are released. Bug: 1002277 Change-Id: I88b6707e70079b238c9da427725a4c4d19c13113 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232828 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
-
Henrique Ferreiro authored
Migrate the legacy IPC message DragMsg_DragSourceEnded to the DragSourceEndedAt Mojo message in blink.mojom.FrameWidget. Bug: 1039255 Change-Id: I4cb623eee041433ab4bd677ddd297b5bfeebd8ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210353 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Jazz Xu authored
This CL fix the bug that the overlay media notification is not displaying correct title in taskbar. Bug: 1088008 Change-Id: I80b678d20f4dadf0f00046898026768fb280837f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2221431Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#776731}
-
Yi Gu authored
Bug: None Change-Id: I4e08f47bce5278549ee318bdd25dcf9b6aa07c88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234061Reviewed-by:
-
spdonghao authored
Set the recyclerView of Feed to transparent instead of invisible to remove the delay to show articles. The default animation is shown between placeholders and articles cards. Bug: 1076139 Change-Id: I9bf986c7c6f2c5e634b2f2a5311381fcfddb8565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232601 Commit-Queue: Hao Dong <spdonghao@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#776729}
-
Matt Menke authored
It doesn't look like this should actually fail live streams (or if it does, there's no test for it), but it has been failing streams with ERR_ABORTED, which is a special error code that should only be used when the next layer up fails requests, as it has special treatment by some consumers. Bug: 941651 Change-Id: I3c49fe3d7961c6bd857a828bc335ea1d21f0557d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232998 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#776728}
-
Haiyang Pan authored
The disabled tests are * testIncognitoToggle_thumbnailFetchCount * AccountPickerBottomSheetTest.* Bug: 1092987, 1093050 Change-Id: I30e1a9f63038cae8902405c6ee6916590f47756e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238887 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
-
Matt Kotsenas authored
http://crrev.com/c/2229335 added Python3 support for the `test_env_unittest.py` files, but appears to have broken the test on Windows in the process. Fixing by adding back `sys.executable` in the command to run, as Windows doesn't support running scripts via shebang. Bug: 942720 Change-Id: I40757a78ad707f36481e2906251ee8451aa89318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238269Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#776726}
-
Yan, Shaobo authored
This patch add srgb format support in CPU uploading path. The copy ensures color conversion happens in the canvas color space for srgb formats in WebGPU and leave the srgb conversion in shader part. This patch also add color format validation rules for CopyImageBitmapToTexture BUG=966582 Change-Id: I139dc7addd0f74e4b22c271dfb6194bf3d59bb73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234992 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#776725}
-
Fabrice de Gans-Riberi authored
* Add a CastStreamingReceiver mojo service to handle the Cast Streaming Session startup and receive audio and video buffers in the renderer process. * Add a Stop() API in CastStreamingSession. Bug: 1042501 Change-Id: I393a5a500a01fc6f1a966339bab698ea64a1526f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187153 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#776724}
-
Renato Silva authored
Extends the marketing email opt-in in OOBE to support the following additional countries: France, Germany, Netherlands, Finland, Sweden, Norway, Denmark, Spain, Italy, Japan, and Australia. All the countries are protected behind a flag, with a special flag just for double opt-in countries such as Germany. Added suffixes to the metrics that are recorded on that screen. Opt-in rates, and backend request responses will now be based on the country. Added additional metrics to track the success rate of the current geolocation approach. Fixed: 1090724 Change-Id: Icf71e8d07d1b97465649dbd1e5c02c93b50c003b Bug: 1090724 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232604Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#776723}
-
Dominic Mazzoni authored
This removes: Accessibility.ImageLabels.ContextMenuOption Accessibility.ImageLabels.FromSettings.ToggleSetting We still have overall stats on the feature usage, these distinctions don't seem important to keep around. Bug: 1061961, 1059787 Change-Id: Ic8fdc3d9e21fcf87e7f132088411f74f60ede118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233821Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#776722}
-
Ben Kelly authored
This CL extends the following histograms: ServiceWorker.CacheStorageInstalledScript.CachedMetadataSize ServiceWorker.CacheStorageInstalledScript.CachedMetadataTotalSize ServiceWorker.CacheStorageInstalledScript.Count ServiceWorker.CacheStorageInstalledScript.ScriptSize ServiceWorker.CacheStorageInstalledScript.ScriptTotalSize ServiceWorkerCache.Cache.Browser.Match.Initialized ServiceWorkerCache.DidGenerateCacheableMetadataMessageInCacheStorage.OriginAllowed ServiceWorkerCache.ListOriginsIndexValidity ServiceWorkerCache.Scheduler.OperationDuration2 ServiceWorkerCache.Scheduler.QueueDuration2 ServiceWorkerCache.Scheduler.QueueLength ServiceWorkerCache.UsedIndexFileSize SimpleCache.ConsistencyResult SimpleCache.ConsistencyResultAfterIndexFilesDeleted SimpleCache.DidDeleteIndexFilesAfterFailedConsistency SimpleCache.EntryTrailerPrefetchDiff SimpleCache.EntryTrailerPrefetchSize SimpleCache.OriginalConsistencyResultBeforeSuccessfulRetry SimpleCache.RetryConsistencyResult This CL removes the following histograms: ServiceWorkerCache.PeakParallelSharedOps2 ServiceWorkerCache.Scheduler.IsOperationSlow Fixed: 1089989,1089966,1089965,1089964,1089954,1089953,1089952,1089905,1089904,1089903,1089902,1089901,1089900,1089853,1089852,1089851,1089850,1089849,1089848,1089847,1089846,1089498,1089497,1089491,1089914,1089913,1089912 Change-Id: I62582053e4339a307ad422d4e4f1ead30211e113 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236068 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#776721}
-
rbpotter authored
- Move the GestureDetector instance to the viewport, since the PDFViewer methods for the events fired just call Viewport methods. - Move contextmenu event handling to the GestureDetector, since the PDFViewer just calls a GestureDetector method to see if it should call preventDefault(). - Move mousemove/mouseout listeners to the ToolbarManager, instead of listening for these in PDFViewer only to call ToolbarManager methods. Change-Id: I932a37278b0835cc780e3a7632952885a68cf26e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236951Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#776720}
-
Wan-Teh Chang authored
Chromium creates some image decoder instances just to get image metadata, so decoding the first frame when decoding metadata will result in decoding the first frame of an image multiple times. It turns out that the AVIF spec says the container "box" or property with the the image width, height, or bit depth is mandatory. Therefore, if decoder_->containerWidth/containerHeight/containerDepth is 0 after avifDecoderParse() returns, we can consider the image as invalid. Then, the only metadata we need that libavif doesn't expose yet is whether the image is monochrome (grayscale). This will be addressed in a new version of libavif. Partially revert the changes to avif_image_decoder_test.cc in commit 11746b04 because now Parse (decoding the metadata only) and Decode are distinct phases of decoding again. Test: 1. blink_platform_unittests --gtest_filter=*AVIF* 2. Run chrome with --enable-features=AVIF and visit https://resources.link-u.co.jp/avif/images.html. Bug: 1092694 Change-Id: If4d4ea7aa02591ba9269c810931bac7e4ff85895 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236888 Commit-Queue: Wan-Teh Chang <wtc@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#776719}
-
danakj authored
This was a linter error, for CLs coming after. TBR=bokan@chromium.org NOTRY=true Bug: 984438 Change-Id: Icc4d82fd806446e8a838af4a9bfeed1240f39bfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238356Reviewed-by:
-
Jinsuk Kim authored
When WebContents is destroyed, its ContentView is detached from View hierarchy to stop receiving UI events from framework. But it doesn't seem to stop it from processing some of events that were passed before it was detached. It uses EventForwarder to pass them to WebContents but the EventForwarder was destroyed as well, therefore can cause UAF exception. This CL updates ContentView to check EventForwarder before using it. Bug: 1080552 Change-Id: I7ab4099461d5906393e4305e4f5a88cf86302fd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235259Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#776717}
-
Rahul Singh (EDGE) authored
This CL moves shortcut_icon_bitmaps out of WebApplicationShortcutInfo. This data now lives in a separate std::vector<std::map<SquareSizePx, SkBitmap>> shortcuts_menu_icons_bitmaps; When detecting updates to the manifest, this enables direct comparison between the WebApplicationShortcutsMenuItemInfo created from the manifest and the shortcuts menu info persisted in AppRegistrar. This is The separation of icon bitmaps into shortcuts_menu_icons_bitmaps allows us to use WebApplicationShortcutsMenuItemInfo in the WebApp class. So this change also removes the WebApp::WebAppShortcutsMenuItemInfo struct. Finally, as part of this change, WebApplicationShortcutInfo has been renamed to WebApplicationShortcutsMenuItemInfo. This clarifies the feature powered by this struct. It also helps disambiguate it from the preexisting ShortcutInfo struct in the web_app namespace. This CL is part 1 of 2 to enable shortcuts menu updates when the Web App Manifest is updated. The follow up CL will contain code to detect changes to the manifest's shortcuts member and to unregister and register the Shortcuts Menu as part of the PWA update process. Bug: 1087212 Change-Id: Ib0d0401b0454ecae462acd0bdba2bda6735326d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229879Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Rahul Singh <rahsin@microsoft.com> Cr-Commit-Position: refs/heads/master@{#776716}
-
phillis authored
Badging.AppBadgeUpdate.Win.Result was made obsolete, revert the enum removal so that the label is still shown in UMA metric dashboard with historical data. Bug: 1088645 Change-Id: Icdaef4c0892da7c87cc7f6fd1a4a9ff4120fce82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238668 Commit-Queue: Phillis Tang <phillis@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#776715}
-
Kyle Horimoto authored
Fixed: 1090183 Change-Id: I13b9cb3590bbe06192190075939578615574aa32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236955 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#776714}
-
shrekshao authored
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/1b5de6a..d0fcf3d Tbr: kbr@chromium.org Bug: 1082525, 1082592 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64 Change-Id: I40dec355c5a31eb82fc80d90ffe42d3c7e812ffa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238416Reviewed-by:
Shrek Shao <shrekshao@google.com> Reviewed-by:
-
Bo Liu authored
Factor out ChildServiceConnection* classes and interfaces as separate files. They are all made package private. Unit tests is moved into the same package name to access the new interfaces. Rename bind/unbind methods on ChildServiceConnection to bind/unbindServiceConnection, to avoid name clashing with ChildProcessConnection methods. Only production change should be updating some tracing event names. Change-Id: Iacd788833028808d81f5f12fddd46cd88babeb26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231717Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#776712}
-
