- 18 Nov, 2020 40 commits
-
-
Christopher Cameron authored
The code prior to this patch did not fail if GetImage returns nullptr. Bug: 1149954 Change-Id: If87d16ea2573cc8e5db1e419b743d37bc5062ceb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545035Reviewed-by:
Yi Xu <yiyix@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#828940}
-
Dave Tapuska authored
Collapse root layer implementation into a common implementation. One subtle difference is that the root layer on the child root frames is now set to null during destruction, I believe this is more correct. BUG=1097816 Change-Id: I5556680d0170280918a21027ff602c37b16d5598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542757 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#828939}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/19da6ff2e87e..484196b73916 2020-11-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com Change-Id: Icc0a185dc3cba7ffb664be535a72a7d3c7f49a36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547101Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828938}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2e4ad365f6e4..5c2ea4d80c2b 2020-11-18 vidorteg@microsoft.com [Loc] Migrate layer_viewer to Loc V2 2020-11-18 aerotwist@chromium.org [unit test] Add inspector_overlay to coverage 2020-11-18 tvanderlippe@chromium.org Typecheck lighthouse_worker/LighthouseService.js with TypeScript 2020-11-18 aerotwist@chromium.org [unit test] Add placeholder test for missing entrypoints 2020-11-18 tvanderlippe@chromium.org Use TypeScript-authored files in node_main/ 2020-11-18 tvanderlippe@chromium.org Use TypeScript-authored files in wasmparser_worker/ 2020-11-18 tvanderlippe@chromium.org Use TypeScript-authored files in worker_main/ 2020-11-18 tvanderlippe@chromium.org Use TypeScript-authored files in workspace_diff/ 2020-11-18 tvanderlippe@chromium.org Use TypeScript-authored files in js_main/ 2020-11-18 tvanderlippe@chromium.org Use TypeScript-authored files in search/ 2020-11-18 tvanderlippe@chromium.org Typecheck input/InputTimeline.js with TypeScript 2020-11-18 tvanderlippe@chromium.org Use TypeScript-authored files in quick_open/ 2020-11-18 jacktfranklin@chromium.org [DataGrid]: disable pointer events on filler row 2020-11-18 jacktfranklin@chromium.org Remove UIComponents import eslint exception. 2020-11-18 alcastano@google.com Protocol update for Breakpoints on Trusted Type violation 2020-11-18 aerotwist@chromium.org [perf] Restore boot perf test 2020-11-18 tvanderlippe@chromium.org Use TypeScript-authored files in inspector_main/ 2020-11-18 bmeurer@chromium.org [bindings] Fix leaked UISourceCode's with Breakpoints. 2020-11-18 jacktfranklin@chromium.org Remove LitHtml and Marked exemption from ESLint modules rule. 2020-11-18 alexrudenko@chromium.org Implement persistent overlay for flexbox 2020-11-18 pfaffe@chromium.org Revert "Aria-label the scope entries" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1136655,chromium:1142804,chromium:1145997,chromium:1147888,chromium:1148296,chromium:1150259 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ifb9117661d309a01044850282a5399f366a1a8d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547882Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828937}
-
Ben Mason authored
Chrome will run in 64-bit, but WebView will run in 32-bit mode by default. Change-Id: Idc240b62a5c18c9109c02853459c073e4c53d851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536784 Commit-Queue: Ben Mason <benmason@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#828936}
-
Mason Freed authored
The [1] CL moved >210 tests to SlowTests and removed them from flaky status in TestExpectations. There were several fall-outs from this move: tests that are still flaky, even when given much more time. This CL groups them together in TestExpectations, and removes them from SlowTests. TBR=schenney@chromium.org TBR=wangxianzhu@chromium.org Editing the end of TestExpectations is hard: notry=true [1] https://chromium-review.googlesource.com/c/chromium/src/+/2538144 Bug: 1095379 Change-Id: I3ea0d4d115b08dffb9a3465f6c3dd7b993cd14d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547469 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#828935}
-
David Benjamin authored
Saves a tiny bit of code. Change-Id: I694306ac83c425a2d42c7381f9bc024c417591b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547760Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#828934}
-
Darren Shen authored
AutocorrectManager was hard to test because it required a full InputMethodEngine as a dependency. However, it really only needs two dependencies: an input context handler to manipulate text, and a suggestion handler to manipulate the autocorrect range. Pass in the suggestion handler via the ctor, and grab the input context handler via IMEBridge*. Add a few unit tests with mock handlers. In a future patch, we will add a proper fake input context handler so that it's easy to test UndoAutocorrect. * Note that there's an open bug to remove IMEBridge as it is global state. See crbug.com/1149751. Bug: b/172969200 Change-Id: Ic9deefb873ee94895846bd91efe608ef10418eb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543537 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#828933}
-
Koji Ishii authored
NOTRY=True TBR=yosin@chromium.org Change-Id: If8f1a4632b151e26372a54351ba3d232b0d3bdad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547745Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#828932}
-
Dale Curtis authored
These appear to be commonly generated from the canvas capture path when '{alpha: false}' is not specified. They may also be generated from alpha vp8/vp9 decoding R=sandersd Fixed: 1148800 Change-Id: I5da2aed405b6ed7c0708dae1aee2bb397731c26e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542936Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#828931}
-
Yicheng Li authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/50b570a8b17f..dfd19c1b9bbc $ git log 50b570a8b..dfd19c1b9 --date=short --no-merges --format='%ad %ae %s' 2020-11-12 acostinas system_api: Add method for NTLM token creation 2020-11-17 yichengli system_api: Add user_display_name to WebAuthn MakeCredential parameters Created with: roll-dep src/third_party/cros_system_api Change-Id: I6520c1af0ee3fcdaf8672b8fd6d5654183160802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547431Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Yicheng Li <yichengli@chromium.org> Cr-Commit-Position: refs/heads/master@{#828930}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b61a10d6bd1f..1ba982f47a9f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC dmazzoni@google.com,nsatragno@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1131051,chromium:912681 Tbr: dmazzoni@google.com,nsatragno@google.com Change-Id: I39d0af9c31dfc00f2d27d133893f3ffecf239969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547787Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828929}
-
Vladimir Levin authored
This patch ensures that we propagate the positioned movement layout dirty bit since it affects "self layout" in the sense that it is the object itself that could be positioned differently, not necessarily its child. The early out right now protects us from propagating child only dirty bits, since those updates would be blocked anyway. R=ikilpatrick@chromium.org, chrishtr@chromium.org Change-Id: I1ed4850317ff0248fc74a9ad09fedba2d5fa2041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542305Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#828928}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/43fcd32b4fae..259ce70939a8 2020-11-18 capn@google.com Only lower MSan codegen optimization for LLVM JIT If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ie470dee7969c91c364585198195586847a8e6162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547109Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828927}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/de5334a0..6e7e3279 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I55367e7d4f94cd5d2ffcbe3bb6ddfcc2fd5ee1eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547428Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828926}
-
Dominic Mazzoni authored
Bug: 981423 Change-Id: I4755f16d954eae2aa1566e166007fea4a4260a47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533818 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Chris Hall <chrishall@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Meredith Lane <meredithl@chromium.org> Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#828925}
-
Alex Newcomer authored
It should exist, and we assume that it exists. I'm not sure how it would not exist, but return in this case to avoid a crash. Bug: 1138665 Change-Id: I7a667f4e3744f7f5bb580139962b92860f763d5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546853Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Auto-Submit: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#828924}
-
Kartik Hegde authored
To facillate testing in classes that use the UdpProber, create an abstract UdpProber. Tests can derive from this abstract UdpProber class. BUG=b/172994051 TEST=unit_tests --gtest_filter=UdpProberWithFakeNetworkContextTest.* Change-Id: Ibdfba9690e996e211f1db85888f66fe15f24c75e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545047 Commit-Queue: Kartik Hegde <khegde@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#828923}
-
Brian Geffon authored
When we added support for versioned message we accidentally introduced a behavior where messages can be shorter than expected. This is what the behavior should be to allow older messages to be received. However, we know the minimum size is the oldest message version. We should never be allowed to go smaller than that. This second attempt will explicitly shutdown the channel in the test to avoid a UAF on Mac. BUG=chromium:1149805 Change-Id: I0a1daaf69db7ca74963803f8a92c31bfea3aa0df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547479 Auto-Submit: Brian Geffon <bgeffon@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Brian Geffon <bgeffon@chromium.org> Cr-Commit-Position: refs/heads/master@{#828922}
-
Anthony Vallee-Dubois authored
Bug: 1150509 Change-Id: If67fb599658b610c25498ebd8967dc4997314033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546996Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#828921}
-
Dale Curtis authored
We haven't seen any usage of xHE-AAC yet, so extend the histogram to ensure we have the data for making support plans. Fixed: 1140052 Change-Id: Iec7df9916f216e9e2897f0916587c8f548cadf72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543182 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#828920}
-
Henrique Nakashima authored
Bug: 1109013 Change-Id: I20b526652fb2a9134a472b885d49613d4acf2b33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511729 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#828919}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 28f2d530. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I1a4d887d25225f3525ba0eddb1c7fcfc8adca97e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547267Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828918}
-
Koji Ishii authored
This reverts commit 729ad65d. Reason for revert: The Mac10.13 Tests (dbg) bot still fails, but external/wpt/html/semantics/tabular-data/processing-model-1/span-limits.html is not failing before this revert. The waterfall from the previous (r828600): https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20(dbg)/20759 Original change's description: > Revert "Move OutlineRectsShouldIncludeBlockVisualOverflow to ComputedStyle" > > This reverts commit 706526c7. > > Reason for revert: Speculative reverting this for failures in external/wpt/html/semantics/tabular-data/processing-model-1/span-limits.html on Mac10.13 Tests (dbg) bot. > > Since this file touches things related to span before the first failure. > > Original change's description: > > Move OutlineRectsShouldIncludeBlockVisualOverflow to ComputedStyle > > > > Moving to |ComputedStyle| has following benefits: > > * Reduces the usage of |LayoutObject| in NG code. > > * Uses first-line style correctly when we have > > |NGPhysicalFragment|. > > > > This patch has no behavior changes. > > > > Bug: 1145048 > > Change-Id: If1298087754286e7a5ec1935fc1ba52d1298770f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536585 > > Reviewed-by: Aleks Totic <atotic@chromium.org> > > Commit-Queue: Koji Ishii <kojii@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#827948} > > TBR=kojii@chromium.org,atotic@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1145048 > Change-Id: I7473ebbce84f5a8496674de250eee9f306bca815 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545852 > Reviewed-by: Jiewei Qian <qjw@chromium.org> > Commit-Queue: Jiewei Qian <qjw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828601} TBR=kojii@chromium.org,atotic@chromium.org,qjw@chromium.org Bug: 1145048 Change-Id: I182d7ef40bbba12e67ecc298c7ae61317f1f7d60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547740 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#828917}
-
Sammie Quon authored
Enabling also exposed a DCHECK where the throughput tracker was being Stopped when it was not started. This was previously missed, because manual testing was all done on a device, where DCHECKs were disabled. Bug: 1148923 Test: none Change-Id: I9c9236f04da072e0a63eb118db0969716a71ffdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537131 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#828916}
-
Leonid Baraz authored
Instead of allocating MAX_BUFFER_SIZE always. Also, fix an error in metadata restore: open existing metadata file with actual size instead of 0. Bug: b:157943192 Change-Id: Ie59927e245c5f9f1bf75064f37f5f6a0996ab071 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547433Reviewed-by:
Zach Trudo <zatrudo@google.com> Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#828915}
-
Nico Weber authored
As of the clang roll in https://crbug.com/1149189, clang-cl understands this flag directly. Bug: 1139129 Change-Id: I5f484d259f48855967a1715e87d2f704826ceacd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547122 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#828914}
-
Xi Han authored
When Instant Start is enabled, the calculateButtonData() is called pre-native and early exits without calling the IdentityDiscController#ensureProfileDataCache(). As a result, the IdentityDiscController misses the event of the onProfileDataUpdated() and thus doesn't notify its observer StartSurfaceToolbarMediator to update the visibility of the identity disc button. To fix the issue, we call notifyObservers(true) in setProfile() when the Profile is created. It will notify the Start surface which calls IdentityDiscController#getForStartSurface() to create a ProfileDataCache if hasn't yet and listen to the event when Profile is updated. Bug: 1137535 Change-Id: I187ab8734144d61ae0a2eff761494792594e7b21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547200 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#828913}
-
Jesse Schettler authored
Display scanned images when a scan is complete. Bug: 1059779 Change-Id: I1341ece7bc7043ad34ba527dcbdec111563e23a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545293 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#828912}
-
Ian Struiksma authored
For many Autofill and Password Manager tests, the path to getting them running on Android will require access to Profile from a source other than browser()-profile(). Adding a method here that follows how content::WebContents is accessed. Bug: 1127019 Change-Id: I160d6bbc5d0d9437d9a8baef0075ed7566db4425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536552Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Ian Struiksma <ianstruiksma@google.com> Cr-Commit-Position: refs/heads/master@{#828911}
-
Keishi Hattori authored
Exclude MemoryDumpProvider::name from rewrite_raw_ptr_fields because it is used inside a TRACE macro. Bug: 1073933 Change-Id: I03a3d5460242f99fc668fb6a2ae67c4ab463bc4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545582Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#828910}
-
Stephanie Kim authored
Doesn't schedule Linux Tests Robocrop and Linux Builder Robocrop. linux-rel-builder will just mirror them and trigger tests in chromium.tests.robocrop Bug: 1143924 Change-Id: I70dc5ddb8b9f36f4c7b15bfcfc40605b589a717d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545646 Commit-Queue: Stephanie Kim <kimstephanie@google.com> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#828909}
-
Tommy Steimel authored
This CL changes the media/controls/doubletap-to-jump-backwards test to use a paused video instead of a playing video to prevent a race where the time was sometimes 1 second off. Bug: 1044569 Change-Id: Ifd0d2c5a2921e1f747d77aa4b9a47f7e651fac1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547781 Auto-Submit: Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#828908}
-
Daniel Hosseinian authored
The feature has been enabled by default on ToT since crrev.com/813922, which was released with M88. Bug: 696650 Change-Id: Idb9f2fef29052c8b420de5867a5f43b9f5298984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543188Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#828907}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d361e6028c27..2d31db0b3751 2020-11-18 treehugger-gerrit@google.com Merge "Fix missing include in kernel_symbol_map.h" 2020-11-18 fmayer@google.com Merge "Separate guardrails from heapprofd." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I96d27005627b5ed08cbbabd7fec54fccf091750f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547110Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828906}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fcc4e85f3c0b..75ae8fcc319e 2020-11-18 ccameron@chromium.org Remove unexpected color conversion in GrSurfaceContext::readPixels 2020-11-18 brianosman@google.com Revert "Replace skslc worklist files with -- delimited command lines." 2020-11-18 herb@google.com use the DirectSubRun to size the arena 2020-11-18 kjlubick@google.com [canvaskit] Document and tweak MakeImage API 2020-11-18 herb@google.com calculate glyph offset using (0,0) mapping 2020-11-18 johnstiles@google.com Optimize away swizzles on single-argument constructors. 2020-11-18 brianosman@google.com Remove (unused) SkSL::NodeArrayWrapper 2020-11-18 tdenniston@google.com [svg] Parse "inherit" generically for SkSVGProperty 2020-11-18 brianosman@google.com SkSL: Preserve coerced types of literals during dehydration/rehydration 2020-11-18 brianosman@google.com Remove nullptr default Type from IntLiteral 2020-11-18 nifong@google.com update externs for debugger_bindings.cpp If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1115317,chromium:1147712 Tbr: lovisolo@google.com Change-Id: I191272b95f5b59f637ff6689987b0062edb14531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547389Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828905}
-
Haoyue Wang authored
Change-Id: Ife0548334e75ae9e23c9c3b3824965ccfe182712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547210 Auto-Submit: Haoyue Wang <haoyuewang@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#828904}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c91cb9e0abfe..738092aeadaf 2020-11-18 m.maiya@samsung.com Add auto generated code for GL_EXT_tessellation_shader If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: Ic4bfb6350361bceab66fb3b609eb4b0309532ef8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547561Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828903}
-
Chan Li authored
Bug: 1108016 Change-Id: Ie47d14bf422d2b230c2d119dd395e6bf1a923ae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545070 Commit-Queue: Chan Li <chanli@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#828902}
-
Becca Hughes authored
Adds a histogram that measure the time taken it took from loading the page to when the user starts watching. Change-Id: Ifbbcb5ca07c8554e7157ba1b07d3015fb801fe35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537777 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#828901}
-