GitLab

BUG=658341

Review-Url: https://chromiumcodereview.appspot.com/2442883002
Cr-Commit-Position: refs/heads/master@{#426947}

This patch fixes max preferred width for LayoutText when break-all
preferred width ("word-break: break-all" or "word-break: break-word")
is used.

The problem only appears when the sum of character widths is not equal
to the word width. However, when the sum is larger (e.g., kerning,) the
difference is hardly noticeable.

Also an optimization in LayoutText::width() hides the problem when
!preserveNewline(), so it is visible only when "white-space: pre-wrap"
or "white-space: pre-line".

BUG=655590

Review-Url: https://chromiumcodereview.appspot.com/2438683006
Cr-Commit-Position: refs/heads/master@{#426946}

BUG=

Review-Url: https://chromiumcodereview.appspot.com/2438863003
Cr-Commit-Position: refs/heads/master@{#426945}

On 10.11+, when navigating away from the NTP with the bookmarks bar
"detached", AppKit currently complains about a constraint violation when
setting the bookmarks bar height to zero. It seems to occur because the
subview previously asked for 6 DIP of padding on the top and bottom
which won't fit in a height of 0 DIP. The subview height is set to 0 DIP
shortly after.

BookmarkBarView currently says it has a flexible height and fixed
padding. Change it to a fixed height and flexible padding to stop AppKit
complaining.

While investigating, improve the encapsulation of -layoutSubviews
slightly. BrowserWindowController called it after setting the view's
frame manually and unnecessarily tweaking (a different set of) layout
constraints. DCHECK instead.

BUG=655112

Review-Url: https://chromiumcodereview.appspot.com/2435593008
Cr-Commit-Position: refs/heads/master@{#426944}

Review-Url: https://chromiumcodereview.appspot.com/2434393002
Cr-Commit-Position: refs/heads/master@{#426943}

BUG=none

Review-Url: https://chromiumcodereview.appspot.com/2409703002
Cr-Commit-Position: refs/heads/master@{#426942}

This CL removes the Learn more row button in the Content settings and
puts that functionality in a new help button in the upper right of the
subpage.

BUG=658060
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://chromiumcodereview.appspot.com/2432383005
Cr-Commit-Position: refs/heads/master@{#426941}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/fe41618f8d39..b7d8fe883c16

$ git log fe41618f8..b7d8fe883 --date=short --no-merges --format='%ad %ae %s'
2016-10-21 bpastene devil: Add some logging to device_monitor.
2016-10-21 jbudorick Revert of [devil] Roll to ADB 1.0.36. (patchset #1 id:1 of https://codereview.chromium.org/2436373002/ )
2016-10-21 aiolos Add solidSelectedDots option to chart_series config.
2016-10-21 benjhayden Set text-overflow:ellipsis on Name column cells in histogram-set-table.
2016-10-21 benjhayden Fix and test metrics side panel.
2016-10-21 rnephew [Android][Telemetry] Show output of adb.ForwardList when error detected.
2016-10-21 rnephew [Devil] Fix more forwarder logging.
2016-10-21 jbudorick [devil] Roll to ADB 1.0.36.

BUG=649481,623989,655653,655625,623989

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://chromiumcodereview.appspot.com/2445473002
Cr-Commit-Position: refs/heads/master@{#426940}

BUG=657723

Review-Url: https://chromiumcodereview.appspot.com/2435723003
Cr-Commit-Position: refs/heads/master@{#426939}

Take advantage of a new function we defined already for what nodes are
"interesting" on Android.

When we get a hit test result back and it's not interesting, first see if
there's a single child that's interesting. If so, return that. If not,
walk up to the first interesting ancestor.

That will avoid returning something like a wrapper <div>.

BUG=656146

Review-Url: https://chromiumcodereview.appspot.com/2422773002
Cr-Commit-Position: refs/heads/master@{#426938}

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/b1aed3a..b973c09

BUG=656889
TEST=bots
NOTRY=true
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://chromiumcodereview.appspot.com/2433323007
Cr-Commit-Position: refs/heads/master@{#426937}

The signaling channel does not guarantee that the incoming IQs are
delivered in the order that it is sent.

This behavior leads to transient session setup failures.  For instance,
a <transport-info> that is sent after a <session-info> message is
sometimes delivered to the client out of order, causing the client to
close the session due to an unexpected request.

This CL implements a OrderedMessageQueue which guarantees the ordering of
the incoming GET and SEt IQ by extracting sequencing information from the
id attribute of incoming IQs.

Review-Url: https://chromiumcodereview.appspot.com/2417913002
Cr-Commit-Position: refs/heads/master@{#426936}

ChromeFullscreenManager will now register and listen
for updates internally and avoids the prior cyclical
dependency.

This also fixes a bug introduced in:
https://codereview.chromium.org/2414913004

In that, we were not clearing the reference to Tab when
reparenting and then there were two fullscreen managers
listening for updates.

BUG=656939

Review-Url: https://chromiumcodereview.appspot.com/2440643002
Cr-Commit-Position: refs/heads/master@{#426935}

functionality.

Screenshots on the bug - this is so vastly better looking IMO as to not
need UI review.

BUG=658410,633986

Review-Url: https://chromiumcodereview.appspot.com/2439863004
Cr-Commit-Position: refs/heads/master@{#426934}

xctest_utils.py is copied from chromium/tools/build/scripts/slave/ios/xctest_utils.py.

BUG=608537

Review-Url: https://chromiumcodereview.appspot.com/2437953002
Cr-Commit-Position: refs/heads/master@{#426933}

This moves PreviewType to previews_experiments.h and chagnes
IsOfflinePreviewsEnabled to IsPreviewsTypeEnabled to allow other
previews to use the code in a similar fashion.

BUG=615564

TBR=dimich

Review-Url: https://chromiumcodereview.appspot.com/2433793003
Cr-Commit-Position: refs/heads/master@{#426932}

https://chromium.googlesource.com/skia.git/+log/ee677f7afbbd..7a86423c4243

$ git log ee677f7af..7a86423c4 --date=short --no-merges --format='%ad %ae %s'
2016-10-21 liyuqian Fall back from analytic to sampling earlier

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=mtklein@google.com

Review-Url: https://chromiumcodereview.appspot.com/2442863002
Cr-Commit-Position: refs/heads/master@{#426931}

BUG=none

Review-Url: https://chromiumcodereview.appspot.com/2441093002
Cr-Commit-Position: refs/heads/master@{#426930}

This CL uses a GtkMenu insetad of a GtkHeaderBar to get the frame
color.  Additionally, we use a 1x1px widget since a menu has a uniform
color.

In the future, this code must be refactored further, but this is just
to fix the build so we can get a trybot config set up.

BUG=132847
R=erg@chromium.org

Review-Url: https://chromiumcodereview.appspot.com/2442113002
Cr-Commit-Position: refs/heads/master@{#426929}

The frame scroll layer and the inner viewport layer had previously been
given the same element id.

BUG=658252

Review-Url: https://chromiumcodereview.appspot.com/2443633002
Cr-Commit-Position: refs/heads/master@{#426928}

Both Local Credit Card and Server Credit card forms have a billing
address.
The Local Credit Card form additionally has the expiration date and expiration month.

BUG=623563

Review-Url: https://chromiumcodereview.appspot.com/2437143004
Cr-Commit-Position: refs/heads/master@{#426927}

Revert of [Reland] Upgrade to new Android SDK. (patchset #2 id:20001 of https://codereview.chromium.org/2438133002/ )

Reason for revert:
forward --list issues + gtest perf test adb locations need to be updated.

Original issue's description:
> [Reland] Upgrade to new Android SDK.
>
> https://codereview.chromium.org/2350013004/ was reverted due to breakage on the perf waterfall. After https://codereview.chromium.org/2438563004/, this should hopefully be resolved.
>
> BUG=623989
>
> Committed: https://crrev.com/a8b2a521ccd425935ef26a70e0f65b57de50d788
> Cr-Commit-Position: refs/heads/master@{#426777}

TBR=xunjieli@chromium.org,stip@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=623989

Review-Url: https://chromiumcodereview.appspot.com/2438913004
Cr-Commit-Position: refs/heads/master@{#426926}

We have already landed the NVIDIA driver updates, so removing the temporary
workaround in chrome and the old token definitions in the header.

BUG=chrome-os-partner:58718
TEST=nyan_big boots to login
TBR=kbr@chromium.org

Review-Url: https://chromiumcodereview.appspot.com/2443703002
Cr-Commit-Position: refs/heads/master@{#426925}

This CL adds MediaSessionClient mojo interface to allow Blink
MediaSession and content::MediaSession communicate for media control
messages.

BUG=656563

Review-Url: https://chromiumcodereview.appspot.com/2426653002
Cr-Commit-Position: refs/heads/master@{#426924}

BUG=

Review-Url: https://chromiumcodereview.appspot.com/2438193002
Cr-Commit-Position: refs/heads/master@{#426923}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/834b25f6..e923cdb9

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://chromiumcodereview.appspot.com/2441103002
Cr-Commit-Position: refs/heads/master@{#426922}

BUG=658414
TEST=none
TBR=mathp

Review-Url: https://chromiumcodereview.appspot.com/2434103006
Cr-Commit-Position: refs/heads/master@{#426921}

Corrects an expectation in a test filter which could lead to infrequent
flakiness. Also adds a new expectation for good measure.

BUG=657080

Review-Url: https://chromiumcodereview.appspot.com/2437283005
Cr-Commit-Position: refs/heads/master@{#426920}

delete remnants of previous Frame Timing (obsolete version).

BUG=655384

Review-Url: https://chromiumcodereview.appspot.com/2413353003
Cr-Commit-Position: refs/heads/master@{#426919}

BUG=
TBR=stgao@chromium.org

Review-Url: https://chromiumcodereview.appspot.com/2439003003
Cr-Commit-Position: refs/heads/master@{#426918}

BUG=657270

Review-Url: https://chromiumcodereview.appspot.com/2427323005
Cr-Commit-Position: refs/heads/master@{#426917}

Revert of Disable many tests with flaky accessibility audits. (patchset #2 id:20001 of https://codereview.chromium.org/2434473004/ )

Reason for revert:
This is done more efficiently by https://codereview.chromium.org/2436063002

Original issue's description:
> Disable many tests with flaky accessibility audits.
>
> BUG=657514
> TBR=stevenjb
>
> Committed: https://crrev.com/486e2998a18f28fa0a0afe8e1e485805fdc00be7
> Cr-Commit-Position: refs/heads/master@{#426325}

TBR=holte@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=657514

Review-Url: https://chromiumcodereview.appspot.com/2440973003
Cr-Commit-Position: refs/heads/master@{#426916}

A previous change had mistakenly filtered out some forms from showing
credit card suggestions. We now fix this and allow empty form actions
(which post to the current page) as well as "javascript:" handlers, for
example, all within pages that have a secure (and perhaps Mixed Passive) context.

BUG=652334
TEST=AutofillManagerTest,AutofillAssistantTest

Review-Url: https://chromiumcodereview.appspot.com/2432063003
Cr-Commit-Position: refs/heads/master@{#426915}

- Incremental paint invalidation now applies to LayoutBoxes only. For
  other objects, do full paint invalidation.

- Do full paint invalidation if the object has border radius.

- Simplfied code for incremental paint invalidation.

This will simplify spv2 raster invalidation when we implement
the same incremental invalidation as spv1.

Also make it ready for slimmingPaintInvalidation paint invalidation
rect subpixel snapping. Will change the extraWidth/extraHeight
parameter from 0 to 1 for slimmingPaintInvalidation to ensure the
subpixel along the edge of the delta between the old/new rects.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://chromiumcodereview.appspot.com/2423513002
Cr-Commit-Position: refs/heads/master@{#426914}

This fixes an issue where the old RenderView is reused by a new remote
subframe. We shouldn't be leaking resources, because now we are already
hiding the unused RenderView in the renderer, when the local main frame
gets detached and the WebViewFrameWidget is closed.

BUG=638375
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://chromiumcodereview.appspot.com/2415973002
Cr-Commit-Position: refs/heads/master@{#426913}

This prevents the overlay from jittering regardless of the performance of the
WebVR content.

BUG=389343

Review-Url: https://chromiumcodereview.appspot.com/2430543002
Cr-Commit-Position: refs/heads/master@{#426912}

BUG=

Review-Url: https://chromiumcodereview.appspot.com/2441113002
Cr-Commit-Position: refs/heads/master@{#426911}

This CL makes it possible to run "gn gen" with use_gtk3=true and
use_sysroot=true.  This is a first step toward adding build support on
the bots so we can have continuous integration in this area.

BUG=132847
R=thestig@chromium.org

Review-Url: https://chromiumcodereview.appspot.com/2444473002
Cr-Commit-Position: refs/heads/master@{#426910}

Use PointerWatcherEventRouter/ui::PointerEvent to detect when a user clicks outside the visible app-list widget,
and close it. Make sure the app list is dismissed if the presenter is destroyed while it is visible.

BUG=611447

Review-Url: https://chromiumcodereview.appspot.com/2434573004
Cr-Commit-Position: refs/heads/master@{#426909}

This moves:
NetworkConnect -> src/chromeos
NetworkStateNotifier -> chrome/browser/chromeos/net

It also moves the following from chrome/browser/ui/ash to keep all
network UI code in the same place:
NetwrokConnectDelegateChromeos -> chrome/browser/chromeos/net

All UI code in NetworkConnect has been moved to NetworkConnect::Delegate.

BUG=657127

Review-Url: https://chromiumcodereview.appspot.com/2434683003
Cr-Commit-Position: refs/heads/master@{#426908}