- 15 Mar, 2019 40 commits
-
-
Austin Eng authored
WebGPU objects will be backed by Dawn objects. If the Dawn client is destroyed, Dawn objects are destroyed by the Dawn Wire. The Blink WebGPU objects need to know if the client is destroyed so that they do not call the destructors and double-free Dawn handles. Bug: 941536 Change-Id: I288ec5c55a29ae135c4ec0b202bdd7d61e781d57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519552 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#641125}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/824201d8b700..ff717d8fff9b Created with: gclient setdep -r src-internal@ff717d8fff9b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=rogerta@chromium.org,yoichio@chromium.org,finnur@chromium.org,atotic@chromium.org Change-Id: I90c63a17303b8434c18708bb87a6a3d56e2a05f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525801Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641124}
-
Yoav Weiss authored
This CL brings in the pending test [1] for a null TAO check and opaque origins, adds another test to make sure only case-sensitive "null" is taken into account, and changes the TAO implementation to actually pass the tests. [1] https://github.com/web-platform-tests/wpt/pull/13507 Change-Id: I1656d5a5cf2a833ada4dc83278eda0a07cec66c7 BUG=940898 Change-Id: I1656d5a5cf2a833ada4dc83278eda0a07cec66c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517653 Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#641123}
-
Colin Blundell authored
PowerMonitorTestImpl must live entirely on the main thread of the child process, as the global PowerMonitor instance that it accesses can only be accessed from the main thread. Currently, content_shell's child processes create a PowerMonitorTestImpl instance and pass it to their BinderRegistry as a bound argument of a PowerMonitorTestImpl::MakeStrongBinding() callback. This BinderRegistry lives on the IO thread. While the child processes specify that the binding should be done on the main thread, if a PowerMonitorRequest never comes in from the browser the PowerMonitorTestImpl instance will be destroyed on the IO thread when the BinderRegistry is destroyed. This leads to MSAN crashes in content_shell (crbug.com/940283 is restricted, but just shows that that the PowerMonitor global that PowerMonitorTestImpl accesses in its destructor is unitialized, which is due to the PowerMonitorTestImpl destructor and PowerMonitor destructor racing with each other on different threads). To eliminate these crashes, this CL changes PowerMonitorTestImpl to be created on-demand. Making this change also requires that the PowerMonitor browsertest ensure that the PowerMonitorTestImpl instances have been created in the various child processes before simulating power state changes that those instances are supposed to observe, as the simulation of the power state changes occurs on a different Mojo pipe than that of the PowerMonitorTest connection. Bug: 940283 Change-Id: I369b365cfece451a89cc1844695d3571abfc310f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522992Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#641122}
-
Colin Blundell authored
Change-Id: I7ad4f41c3af77ea60587555f87a493462305bba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520597Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#641121}
-
Eyor Alemayehu authored
A G-Suite user should not be able to do a screen context query if it is disabled by the administrator. Therefore, we should not allow the G-Suite user to enable screen context queries during the setup flow. This is currently implemented by disabling the screen context toggle and setting it to false. Bug: 941818 Change-Id: I6bfff2387e2e2994e3358a5f24f621f70a9adfe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518062 Commit-Queue: Eyor Alemayehu <eyor@google.com> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#641120}
-
Dominick Ng authored
Prior to this CL, BookmarkAppInstallationTask exclusively passed WebappInstallSource::MENU_BROWSER_TAB to BookmarkAppHelper, which would eventually record the source in the Webapp.Install.InstallEvent metric. This causes huge skew in the metric on Chrome OS, which uses the pending queue for default installation. This CL introduces new metric categories for the different default install categories and updates BookmarkAppInstallationTask to use them, correcting the skew. BUG=942402 Change-Id: Iada40c6a918c095e35948ab8e73ff5da8726c7e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525256 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#641119}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5366a45c6103..61d38ade8c1d git log 5366a45c6103..61d38ade8c1d --date=short --no-merges --format='%ad %ae %s' 2019-03-15 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset 2019-03-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 979f3bbe2c50..2fb6563bf503 (2 commits) Created with: gclient setdep -r src/third_party/skia@61d38ade8c1d The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I6ab8ff085cf11408d663253c0d8c124c9895a3eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525469Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641118}
-
Yutaka Hirano authored
Bug: 914739 Change-Id: I95cc0ecfa16624e16aff17097e9587ecd4756dfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524394 Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#641117}
-
Austin Eng authored
This patch updates GPUAdapter::createDevice to take a GPUDeviceDescriptor which will contain parameters for Device creation. Bug: 941531 Change-Id: I2c96a892846a8ec7ee2e0cf253141faac5b871e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521236 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Rune Lillesveen authored
Also add the plumbing to pass it into blink. Bug: 889087, 925935 Change-Id: I5027a1fc30b14f77423b33ac9e85ba5697a95b13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522246Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#641115}
-
Cathy Li authored
and allow the new touchless suggestions files to depend on TileView Bug: 936050 Change-Id: Ib611b788b532a72a8fce6e8b982c4e288b91408b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518251Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#641114}
-
Takashi Toyoshima authored
CORS preflight cache wasn't skipped regardless of the load_flags, but with this change, it is skipped if the original request has one of flags that want to skip caches. Also, we do not store results to the cache if net::LOAD_DISABLE_CACHE is specified. Bug: 941297 Change-Id: Ibf356949dd6267eb65faf650d76b0c5e58ce5d5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520427Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#641113}
-
Christopher Lam authored
This CL extracts System Web App launch utilities into its own file as suggested in https://chromium-review.googlesource.com/c/chromium/src/+/1370239. It also changes the launch disposition for System Web Apps to CURRENT_TAB to correctly provide singleton behavior. Bug: 836128 Change-Id: Iefd691ed3a5c1f1858197599cff5282e22a254ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504603Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ddc3e674c3c0..824201d8b700 Created with: gclient setdep -r src-internal@824201d8b700 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:885919,chromium:885407,chromium:790659,chromium:790657,chromium:790654 TBR=jbudorick@chromium.org,anthonyvd@chromium.org,andypaicu@chromium.org,aboxhall@chromium.org Change-Id: I879a1d976a1d86275f8c5c6044ab61ca3470c5c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525460Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/58f92a13bcd8..5d06c3522353 git log 58f92a13bcd8..5d06c3522353 --date=short --no-merges --format='%ad %ae %s' 2019-03-15 bpastene@chromium.org cros_test: Point Tast to the specified SSH key when running outside the chroot. 2019-03-15 dhanyaganesh@chromium.org GetSlaveStatuses: Split some callers off to GetBuildStatuses Created with: gclient setdep -r src/third_party/chromite@5d06c3522353 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I6abe9a1411ea4458a6f2c4aa6fede53f7f63063e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525459Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes to |NGAbstractInlineText::GetOrCreate()| to take only |NGPaintFragment| to avoid to create |NGAbstractInlineText| having |NGPaintFragment| not to associated to |line_layout_item_| member variable. These invalid |NGAbstractInlineText| causes crash by referring destructed |LayoutObject| in |NGAbstractInlineText::Detach()|. This crash can be happend in following scenario: 1. Create |NGAbstractInlineText| by |LayoutText::FirstAbstractInlineText()| with layout object L1 and fragment F1_1 then get A1(L1, F1) 2. Create |NGAbstractInlineText::NextOnLine()| with L1 and F2 then get A2(L1, F2) where F2 is associated to L2. 3. Destroy L1 then call Detach() for A1(L1, F1) => no problem 4. Destroy L2 then call Detach() for A2(L1, F2) => crash since L1 is destroyed Bug: 928925 Change-Id: Ic0a55b4e15723e1988d0727aba45723aed4d3a4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525257 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#641109}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/9284a7cf9ba6..bcb9892d16d3 git log 9284a7cf9ba6..bcb9892d16d3 --date=short --no-merges --format='%ad %ae %s' 2019-03-15 tsepez@chromium.org Better bounds check in CFGAS_StringFormatter::GetCategory() 2019-03-14 tsepez@chromium.org Remove stringviews in cfgas_stringformatter.cpp, part2. 2019-03-14 tsepez@chromium.org Cache pattern span in xfa/fgas/crt/cfgas_stringformatter.h Created with: gclient setdep -r src/third_party/pdfium@bcb9892d16d3 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I0c57571b0ed4907cb09043a56f2fd4eead0c1998 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525458Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/26b4a64918d4..04600b4f26bd git log 26b4a64918d4..04600b4f26bd --date=short --no-merges --format='%ad %ae %s' 2019-03-15 yyanagisawa@chromium.org Expose gclient_paths via InputAPI. 2019-03-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-03-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@04600b4f26bd The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:939959 TBR=agable@chromium.org Change-Id: If95206c72c9ede5ea741929d60535cd7e604a6e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525457Reviewed-by:
-
Jan Krcal authored
This CL fixes a speculative bug in interaction between the wallet data bridge and the wallet metadata bridge. The bug occurs when the bridge deletes and re-creates a particular entity (because it is different than before). If these notifications are sent out in the wrong order (first ADD, then DELETE), we end up without the metadata entity. It is speculative because I am not sure that it can happen in reality that payments sends the same card with different data. Anyway, it feels safer to assume less. Bug: 928758 Change-Id: I74a2d6c68107fffdde18a69810828d629ca4e50f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518575 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#641106}
-
Nico Weber authored
This is a reland of 889a9665 Original change's description: > Use DWARF4 for mac and ios simulator builds, use DWARF3 for ios device builds. > > Removes some special-case code and potentially makes debug info a bit smaller. > > Also stop passing -g2 to (non-pnacl) nacl compiles on mac, like already the case > on linux -- this helps with build determinism. > > Bug: 942155,899438,906741,429358 > Change-Id: Ic4c7138d232813e12426de2c161c78121bd3fc80 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525041 > Commit-Queue: Nico Weber <thakis@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#640963} TBR=mark Bug: 942155, 899438, 906741, 429358 Change-Id: I382c93c02eefd3cbbcf1d8df0670297319f3ac31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525415Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#641105}
-
Hajime Hoshi authored
This CL switches task runners at several places from per-thread to per-frame. The purpose of this change is to make it possible to freeze tasks for bfcache. The callback of GC in extensions executes JavaScript, but this callback is now executed on the default task runner. This CL replaces this with a per-frame task runner. Some tests hit this: e.g. extensions_browsertests --gtest_filter=WebViewAPITest.TestDialogConfirmDefaultGCCancel Bug: 870606 Change-Id: Ic1c2968a2e9e07629e7c117e1e1c4e97c2df0457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514516Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#641104}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2fb6563bf503..de52ca373d98 git log 2fb6563bf503..de52ca373d98 --date=short --no-merges --format='%ad %ae %s' 2019-03-15 syoussefi@chromium.org Vulkan: Fix GraphViz dump in presence of queries and fences Created with: gclient setdep -r src/third_party/angle@de52ca373d98 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Idf3d1a755fe66d8df1ceda4c9d5105a21c2da579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525456Reviewed-by:
-
Fergus Dall authored
This fixes a regression introduced by crrev.com/c/1472013, which leaves the flag that decides to show/hide the uninstaller uninitialized. Depending on the build, this may end up in the hiding state initially, rather then the showing state. This CL fixes the regression and adds automated testing to prevent reoccurence. Bug: 941865 Change-Id: I7dc2c3c770fc5fbef838d82c82f46c0717fb7ff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522061 Commit-Queue: Fergus Dall <sidereal@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
David Bokan authored
This early-out was added in: https://crrev.com/ce8ea3446283965c7eabab592cbffe223b1cf2bc Back then, we applied fragment focus in LayoutUpdated() which could cause this issue. This got cleaned up in: https://crrev.com/45236fd563e9df53dc45579be1f3d0b4784885a2 so that focus is no longer applied after layout. +Cleanup: Goto considered harmful Bug: 795381 Change-Id: Ifeb4d2e03e872fd48cca6720b1d4de36ad1ecbb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524417 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#641101}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e545522146af..2ac348b5c0a5 git log e545522146af..2ac348b5c0a5 --date=short --no-merges --format='%ad %ae %s' 2019-03-15 dneto@google.com Repair test for unused storage buffer with descriptor (#2436) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@2ac348b5c0a5 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I16aa5cb80a3747d3da5e2ab796951cb6bc65dbe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525347Reviewed-by:
-
Adam Rice authored
Calling enqueue() on a TransformStream that was closed or errored would throw an exception with the message "Cannot read property 'Symbol(bit field for [[started]], [[closeRequested]], [[pulling]], [[pullAgain]])' of undefined". Fix the message. Also add a Chromium-specific test that the message is correct. BUG=941970 Change-Id: I690bfb909efe72a6ba6859dc886b37b2bda71ed8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523211Reviewed-by:
-
Xianzhu Wang authored
This is a reland of 54b17c7e The original CL called MutatorHost::InitClientAnimationState() before updating animations. The new CL calls it after updating animations. Not sure why the original CL caused flakiness of virtual/threaded/animations/hit-testing/composited-with-hit-testing.html, but the test is no longer flaky with this new CL. Original change's description: > [BGPT] Let cc initialize animation states in property nodes > > In this way, blink::PropertyTreeManager no longer needs to care about > the animation states. Now we initialize and change the states from a > single source to avoid duplicate code and inconsistency. > > Bug: 935770 > Change-Id: I7f98d66677f557213fd4559895e9c2069de196e7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1513922 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#640892} TBR=flackr@chromium.org, pdr@chromium.org Bug: 935770 Change-Id: Icd7ec59b9e5b95f2c268baf88732788cde5da9c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525449Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#641098}
-
Antonio Gomes authored
Previously, the success and error callbacks in the various classes in [1] were either invoked immediately or scheduled to run depending on the execution context's task runner. Lately, according to offline conversations with mek@chromium.org, it is possible to get rid of the scheduling logic altogether because an earlier, change made it so that things like FilesystmeDispatcher::DidReadMetadata already run on a per-execution context task runner, and presumably they would already be scheduled properly. This CL implements that idea, as part of the effort to clean FileSystemCallbacks's implementation. It also greatly simplifies FileSystemCallbacksBase, which can be eliminated in a follow up CL with minimal effort. [1] //third_party/blink/renderer/modules/filesystem/file_system_callbacks.h R=mek@chromium.org CC=blink-reviews-vendor@chromium.org, dgozman@chromium.org BUG=933878 Change-Id: Ib446249bab8ac1c9d9f2e4d11340d258cbac1751 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525101 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#641097}
-
Alexey Baskakov authored
This folder is an output for an experimental `-background-index` command line argument. Bug: None Change-Id: Iaa1db62f54d844d271b2c56a686cdad5117ebe74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524392Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#641096}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f4438d56e989..5366a45c6103 git log f4438d56e989..5366a45c6103 --date=short --no-merges --format='%ad %ae %s' 2019-03-15 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-03-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 9b156615197d..1b8cd2d9ce2c (1 commits) 2019-03-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-03-14 brianosman@google.com Ganesh: Clamp blend inputs when using F16_Clamped pixel config 2019-03-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader becb44f1177a..9b156615197d (1 commits) 2019-03-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-03-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader a2749f39f47d..becb44f1177a (1 commits) 2019-03-14 jvanverth@google.com Fix cached perspective shadows 2019-03-14 michaelludwig@google.com Blacklist compositor_quads_filter on chromecast 2019-03-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader af973b67141e..a2749f39f47d (1 commits) 2019-03-14 bsalomon@google.com Clamp override color to bytes in GrFillRectOp when half float vertex 2019-03-14 kjlubick@google.com [canvaskit] Fallback to CPU more gracefully 2019-03-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 37b996425a0e..979f3bbe2c50 (5 commits) 2019-03-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@5366a45c6103 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/123261126 TBR=benjaminwagner@chromium.org Change-Id: Idff8f55d51703b5bf63f6ba0948b349c84dceedb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525455Reviewed-by:
-
Abhijeet Kandalkar authored
The primary motivation is that the data member names are not following proper naming conventions within probe_sink.h.tmpl and instrumenting_probes_impl.cc.tmpl. This CL add to_snake_case function in make_instrumenting_probes.py to convert data members to snake case format. Bug: 936684 Change-Id: I9934aec12dfd85094335078f7c1784f56d6aafac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524801 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#641094}
-
Xianzhu Wang authored
- Skip virtual/binary-for-devtools/http/tests/devtools - Mark css3/masking/mask-composite-missing-image.html failing - Rebaseline 5 tests: - gradient, rounded edges and anti-alias differences - invalidation rect changes (no image failure) All because of base test rebaselines TBR=pdr@chromium.org Bug: 524134 Change-Id: I171f3eaff7e78649903441c142ebc9c25171ad2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525681Reviewed-by:
-
Kenichi Ishibashi authored
According to the flakiness dashboard it could take more than 10 sec on dbg build and 3 sec on release build. Mark it slow. Bug: 937378 Change-Id: I14fcd04a6d315a61f559fbc7a3cadf8ce2914dbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525255 Auto-Submit: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#641092}
-
Yoshisato Yanagisawa authored
Since we don't have "client"s in canary, let me remove that from the name. Also let me add an ios rule for the iOS latest builder. Bug: 874754 Change-Id: I46e1ec5d33f30caaa723184fdc7dea46f372de67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502892 Commit-Queue: smut <smut@google.com> Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by:
smut <smut@google.com> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#641091}
-
Maksim Ivanov authored
These enums haven't been used by any code for a while. Also remove the corresponding dead histogram definitions. BUG=chromium:690733 TEST=existing tests Change-Id: I93b00807807e1869e5a7ab8daae277a07b6cf1e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1425724Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#641090}
-
Jinsuk Kim authored
Preview (a.k.a Sneak Peek) panel needs to be closed on various events such as when a new tab is opened, or its base panel navigates, etc. This CL adds a couple of tab model observers to detect those events, and invokes |closePanel| accordingly. Bug: 940919 Change-Id: Ieee694db214ded1f031ac24db3586496d19bee42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519966 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#641089}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b58fe2ab9436..ddc3e674c3c0 Created with: gclient setdep -r src-internal@ddc3e674c3c0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:942176 TBR=jbudorick@chromium.org,anthonyvd@chromium.org,andypaicu@chromium.org,aboxhall@chromium.org Change-Id: Id383f2517feb021d79065d9a527de04c7a36f81a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525303Reviewed-by:
-
Luciano Pacheco authored
Re-sending CL: 1514005 based in the new strategy to make it non-flaky. Add more explicit waiting on checkContextMenu to wait for each entry to be displayed before trying to expand or click. Change-Id: Id7a6f9ea27d5bade800837480df79721dcab4329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524749 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#641087}
-
Pavel Feldman authored
Routes each message type into its own method. Change-Id: I8dacbc37d614794f6757d6b9c669fa751de5ab4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525263Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#641086}
-
