- 18 Jun, 2020 40 commits
-
-
Kent Tamura authored
This CL adds base::Feature for LayoutNGRuby runtime flag. We can disable the feature by Finch when we find a critical bug of the feature. Bug: 1069817 Change-Id: I93385fd2e6a67acad7af3e45310e254b6692f504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250140 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#779663}
-
Kent Tamura authored
ComputeAnnotationOverflow() produced annotation overflow values even without any ruby annotation text because text fragment height can be taller than line-height. Such annotation overflow values extended line spacing. This CL fixes this issue. Bug: 1069817 Change-Id: I044cf909567b549cec38d1b97de36e6dde836dc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251139 Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#779662}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592434762-368c9b0f65c1d2b4a5321bdc0e3bbf6ce9a20651.profdata to chrome-win32-master-1592441973-8f9a4741d5f9fee5ba7748f102e2fb2e80661b9c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Iefa9fb5c1c3e62c032fc8fb78372a084dab5a2e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250813Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779661}
-
Victor Costan authored
QuotaClient's methods will only be called with a StorageType in the list of types provided to QuotaManager::RegisterClient(). The QuotaClient implementation managing service worker registrations only provides kTemporary, like all modern storage APIs. Therefore, its QuotaClient implementation does not need to handle other StorageType values. Bug: 1016065 Change-Id: I15d6cd4dc503790d6ac3a7b1d7bd5c5db0b6da01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249635Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#779660}
-
Luciano Pacheco authored
Bug: 1064504 Change-Id: I08f2f92948113514e9288b440e2e4b7e954370bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245993 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#779659}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5ed965e4370d..7898d65dedca 2020-06-18 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8dc0bde668a0df0f5b14e484ecaad21f5b3742fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250816Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c84220a61be7..b623d84fd3d3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kinuko@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: kinuko@google.com Change-Id: Iadad6cff154d44135a9b56118edea3177266bb4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250363Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779657}
-
Robert Ogden authored
Leaves the UA and UA-Mobile hints though. Bug: 1096109 Change-Id: Ic15fb72c35deedabc9a9689cbe7df1795721f0d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250355Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#779656}
-
Haiyang Pan authored
API 23: emulator version: 29.0.11 -> 30.0.12 system image: 31 -> 32 API 28: emulator version: 29.0.11 -> 30.0.12 system image: 9 -> 10 API 28 with playstore: emulator version: 30.0.0 -> 30.0.12 Change-Id: I1baa0354767f3fed5b52a4bcb31dc2df09500760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251167 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#779655}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I67e1610c7e4499995f2659b2e8ddb230d4f816f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250470Reviewed-by:
-
Haiyang Pan authored
The following are disabled in both chrome_public_test_apk and network_service_out_of_process_chrome_public_test_apk: * org.chromium.chrome.features.start_surface.StartSurfaceLayoutTest#testThumbnailFetchingResult_defaultAspectRatio * org.chromium.chrome.features.start_surface.StartSurfaceLayoutTest#testRecycling_aspectRatioPoint75 * org.chromium.chrome.features.start_surface.StartSurfaceLayoutTest#testActivityCanBeGarbageCollectedAfterFinished Bug: 1092987, 1096295 Change-Id: Ia218e3b87b0df6f694a0e96d06a9ac79357eee43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250710 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
-
Xing Liu authored
When download is scheduled to start in the future, don't auto resume it from auto resumption handler. The DownloadSchedule::only_on_wifi() is ignored here, we use DownloadItem::AllowMetered() to check network condition for "later" downloads. Bug: 1078454 Change-Id: Ib7cbd605ee86863899173400d820fa5a05f226c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248926Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#779652}
-
chrome://media-appTrent Apted authored
The launch handler follows the approach of `setCurrentDirectory`, but it is much simpler. There's no need to obtain the File in order to get the MIME type, since we assume all selected files are "related". (The Files app does not offer the media app as a viable launch task if all selected files do not match the file handler type declaration). Update and consolidate the test helpers used to trigger launch. Expose the "real" launchConsumer and use it for existing tests as well for extra test coverage. Bug: b/159107125 Change-Id: I2c0239b58ba9ae0dfe472b600af086a941c828ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247922Reviewed-by:
dstockwell <dstockwell@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#779651}
-
Yue Zhang authored
http://crrev.com/c/2247142 sets top margins for some sections in start surface. However, setting top margin for some sections with app:layout_scrollFlags="scroll" makes the scroll behaves weird for variation with omnibox_scroll_mode = quick. Without digging into the root cause, this CL fixes issue by dynamically setting the margins in code and skip setting top margins for OMNIBOX_ONLY variations. Bug: 1091988 Change-Id: I88e8b9b0524c148879262e0250adf9b3c57777c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250934 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#779650}
-
Kent Tamura authored
If a line has block-end annotation overflow, we add the overflow amount to logical_block_offset as ever. (See NGBlockLayoutAlgorithm::ComputeInflowPosition()) Then, we adjust logical_block_offset if - The next line has block-start annotation space. (See NGInlineLayoutAlgorithm::CreateLine()) - The block container has block-end padding. (See NGBlockLayoutAlgorithm::Layout()) The block-end annotation overflow value is passed to the next line via NGConstraintSpace::BlockStartAnnotationSpace(). Bug: 1069817 Change-Id: I019b982783232e744abb2e709399ded4b7e9a644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249238 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by: -
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592427517-ded8b7e7fc728e470cefdc642111adb273503cec.profdata to chrome-win64-master-1592434762-d0256013ebfb9b66f1c9d30375481125009d55f6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I77a3eb4f15eef084a7bf2a3dee01d9fa0b1ea1ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250362Reviewed-by:
-
Victor Vasiliev authored
https://quiche.googlesource.com/quiche.git/+log/a5a2ca9cc20b..c0dc4ceb325c $ git log a5a2ca9cc..c0dc4ceb3 --date=short --no-merges --format='%ad %ae %s' 2020-06-16 renjietang Handle error as specified in https://tools.ietf.org/html/draft-ietf-quic-http-29#section-7.2.4.2 : If a server accepts 0-RTT but then sends a SETTINGS frame that omits a setting value that the client understands (apart from reserved setting identifiers) that was previously specified to have a non-default value, this MUST be treated as a connection error of type H3_SETTINGS_ERROR. 2020-06-16 renjietang Turn on ZeroRttResumption test. 2020-06-16 wub For loss detection tuning, if user agent is available, save it into quicsession. protected by --gfe2_reloadable_flag_quic_save_user_agent_in_quic_session. 2020-06-16 fayang In quic, use transport params to announce the support of handshake_done frame. protected by gfe2_reloadable_flag_quic_support_handshake_done_in_t050. 2020-06-16 dschinazi Replace enable flags for draft-25 and draft-27 with disable flags 2020-06-15 haoyuewang Deprecate gfe2_reloadable_flag_quic_bw_sampler_app_limited_starting_value Created with: roll-dep src/net/third_party/quiche/src Change-Id: I9f388e2ddcd1cc7cfe0c7d95776ae8a28c08e66c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249105 Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#779647}
-
Lukasz Anforowicz authored
This CL removes callers of blink::Platform::CreateDefaultURLLoaderFactory to help with eventual removal of this virtual method from blink::Platform. In particular, unit tests shouldn't need to go through a virtual method of Platform::Current, but should be able to instead directly interact with blink::TestingPlatformSupport or a similar class. This CL fixes PingLocalFrameClient. Before this CL, PingLocalFrameClient::CreateURLLoaderFactory would end up calling content::TestBlinkWebUnitTestSupport::CreateDefaultURLLoaderFactory. After this CL, a TestingPlatformSupport::CreateDefaultURLLoaderFactory is used instead. TestingPlatformSupport is provided by a newly introduced field in PingLoaderTest. blink::PageTestBase::platform() and EnablePlatform are not used, as they provide TestingPlatformSupportWithMockScheduler which doesn't work as a drop-in replacement for PingLoaderTest. Bug: 891872 Change-Id: Id69415930d6c4f7cce956a087662061965c96839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250554Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#779646}
-
Teresa Kang authored
AccelerationMode and RasterMode essentially mean the same thing. All instances of AccelerationMode are replaced with RasterMode::kCPU/kGPU. Bug: 1090180 Change-Id: I8bde7a5601b59e5ea53e666aeed4dab2efc6b0e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247341Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Teresa Kang <teresakang@google.com> Cr-Commit-Position: refs/heads/master@{#779645}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1592416728-1cfd8ef1020d6c6c9f6035d77a4acfb93f1c4dcb.profdata to chrome-mac-master-1592438165-4613e214984c35e27b9764a9abcf09412695e573.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I1e875084a8ab47866c3fc9cb1c9a2156a64459ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251165 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Hiroki Sato authored
CL:2222068 added IsAccessibilityFocusableContainer() in AccessibilityNodeInfoDataWrapper. The functionality of the method is very similar to CanBeAccessibilityFocused(). This change cleans up AccessibilityNodeInfoDataWrapper. AX-Relnotes: n/a. Bug: b:152930082 Test: unit_tests --gtest_filter="AXTreeSourceArcTest.*" Test: tast tests still passes. Change-Id: Ie461cdeae43278aabc21a6537dd530bec3415554 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246120 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#779643}
-
Jonathan Backer authored
Ideally we would tear down and recreate a new VkDevice on VK_ERROR_DEVICE_LOST. Until we can do that, we should restart the GPU process to do that for us. Bug: 1095744, 1095057 Change-Id: Ib89411e4715b797d8df53572ece4431467d65837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249721 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#779642}
-
Brandon Jones authored
For the moment the space is synced to the local reference space, but we have the ability to make it independent in the future as the lighting estimation feature gets more sophisticated. Bug: 1070819 Change-Id: I276cc2841b95d92e321b75b5c1515878c2f2486e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218374 Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#779641}
-
tby authored
We have three parameters we want finch control over: minimum query length, minimum query length for alternate matches, and minimum score for alternate matches. This CL is mostly a trivial move of the FilterResults function out of the anon namespace and into the OsSettingsProvider class, except for the addition of lines 141-151 in the ctor. Bug: 1068851 Change-Id: Iefd09e85d5677c376ec3ae23d28808416088b098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249258 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#779640}
-
Lukasz Anforowicz authored
This CL removes callers of blink::Platform::CreateDefaultURLLoaderFactory to help with eventual removal of this virtual method from blink::Platform. This CL fixes TestPluginLocalFrameClient. It turns out that all tests pass without overriding the CreateURLLoaderFactory that TestPluginLocalFrameClient inherits from EmptyLocalFrameClient (and which returns |nullptr|). Bug: 891872 Change-Id: I419359754373055e3499ea0577a5eda41298a831 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250947Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iedba599650615a4a560bb19e40663fbbdee7d8ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251106Reviewed-by:
-
Chris Harrelson authored
In this situation, we have an element like this: <div id=target style="transform: ...; backface-visibility: hidden; overflow: scroll"> </div> It will have two transform and one for scrolling: Transform ScrollTranslation However, overflow clipping is also a grouping property [1], so the ScrollTranslation will have flattens_inherited_transform true regardless of the transform-style style of #target. With TransformInterop on, definitely the scrolling contents should not be shown (except for pseudo- and stacking context descendants). This CL changes the behavior for non-TransformInterop also, because it doesn't seem reasonable to have the behavior the way it is right now. [1] https://drafts.csswg.org/css-transforms-2/#grouping-property-values Bug: 363609 Change-Id: Ib1f356e80644582120e37261d368f774cbcaa6e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246437 Auto-Submit: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#779637}
-
Yoshifumi Inoue authored
This patch chagnes |NGInlineItemsBuilder| to mark empty inlines due by white space collapsing by following node, e.g. <div>ab<span> </span></div>. Note: This patch is follow-up of the CL[1] creates box fragment for empty inlines before processing closing tag, e.g. <div>ab <span> </span></div>. [1] http://crrev.com/c/1774418 [LayoutNG] Fixes positions/sizes of empty inline boxes Bug: 707656, 997705 Change-Id: I0bdce9ec2bc073faa05155d6dcd5f8dbec9580be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249269 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Iba7c99f48b7f0f0121cfd6fd692af67404b91c0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250811Reviewed-by:
-
calamity authored
This reverts commit e8aa67c5. Reason for revert: Breaking win32-archive-rel https://ci.chromium.org/p/chromium/builders/ci/win32-archive-rel/14063? TBR=dvallet@chromium.org NOTRY=true NOTREECHECKS=true NOPRESUBMIT=true Change-Id: If0576038e2d07cf3e3ad5e5c35a64ff0007ee174 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248392 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#779634}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=pbommana@chromium.org Change-Id: If02c20dd926ccbef4ef48b6a29233eb53c32a593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251022Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779633}
-
Bugs Nash authored
CIPD package: https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/EocwFPUnfc1cjbhP-tAI6xF4V91NjZGZNpzaapzuEHEC Release notes: http://go/media_app-x20/relnotes/Stable/media_app_202006170800_RC00.html Bug: b/158631947, b/158793266, b/133374709, b/158797300 b/158642528, b/155462513, b/134975059, b/154069897, b/154069736, b/158964473, b/134975059, b/158710694 Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Change-Id: If363ecb508bfd3d345ed14d99811dd0382533329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249208Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#779632}
-
Kenichi Ishibashi authored
This CL increases the android binary sizes by ~30kb. Most of the increase (~29kb) comes from mojo generated code and there isn't much we can do to reduce them. Introducing the mojo interface is necessary for migrating ServiceWorkerStorage to the storage service. See the design doc [1] for the motivation of the migration and plans. [1] https://docs.google.com/document/d/1hO0WEuoEOgEBlf5nDE3fDjuQY2bV_d5hLtk25iBo0LM/edit?usp=sharing Bug: 1055677 Change-Id: I0e24b45a412220619197b4da03166670295be567 Binary-Size: Size increase is unavoidable (see above) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245160Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#779631}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592423969-e01d88a08e241296f5d620a14f440c7e17e47880.profdata to chrome-win32-master-1592434762-368c9b0f65c1d2b4a5321bdc0e3bbf6ce9a20651.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I104cca524dc9177da694c546fe2ca943f5611b98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251161Reviewed-by:
-
Frank Tang authored
Include consistent locale script/region variants by using filterType language. Change expectation in locale_util_unittest since now icu will return it-IT and de-DE in the available locales after we include all the script/region variants. Correct expectation in currency_formatter_unittest and remove comments. https://chromium.googlesource.com/chromium/deps/icu.git/+log/9e7dae8..bbf7f88a bbf7f88 Append a postfix to the icu target outputs on fuchsia (where target output is hardcoded) 7852ffc Use filterType: language 8d29692 Allow building icuuc/icui18n with -fvisibility=hidden Size will be reduced once we land ICU 68.1 which I reduced the break iterator data size. Binary-Size: Increase is temporary. Bug: v8:10599, v8:10601, 863749, 739812 Change-Id: I0050338bd967733d1a78ed52035d8e4bac510e24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247125 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
David Vallet <dvallet@chromium.org> Cr-Commit-Position: refs/heads/master@{#779629}
-
Jinsuk Kim authored
This CL moves the remaining fullscreen enter/exit-related tasks to FullscreenHtmlApiHandler. ChromeFullscreenManager is still the receiver of the requests but simply relays the call to the handler. Added another method |onEnterFullscreen| FullscreenManager interface. This is used by TabWebContentsDelegateAndroid to process the fullscreen initiation flow. Follow-up CL will split ChromeFullscreenManager and route the initiation/termination flow directly to the handler. Bug: 966272 Change-Id: I86b3ad0ee027cde26144469a262737711825cd15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245170 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#779628}
-
jchen10 authored
This uses yuv_util's ConvertFromVideoFrameYUV to import VideoFrame into SkImage converting YUV to RGB, and then creates AcceleratedStaticBitmapImage with the RGB SkImage. Finally given the AcceleratedStaticBitmapImage, ImageBitmap can be directly constructed from it. In this way, VideoFrame from either software or hardware decoder is supported, and the format may only be NV12 or I420. The current test case only covers software decoder. Once hardware decoder is available, new test case should be added. Bug: 897297 Change-Id: I961bc8506f69f86d395736af458157c53579c81e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242724Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Jie A Chen <jie.a.chen@intel.com> Cr-Commit-Position: refs/heads/master@{#779627}
-
Jarryd authored
AllSitesActions has been replaced by AllSitesActions2 since M82. Because of this, this histogram does not need a renewed expiry. Bug: 1055444 Change-Id: I323d83ef6303771340506a5dbc3bd0daf010064d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250169Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#779626}
-
Hiroki Nakagawa authored
This CL fixes ClickAnchorElementOffTheRecord test in NavigationPredictorBrowserTest. The test navigates an incognito browser to "/simple_page_with_anchors.html", makes the browser click one of the anchor links, and then checks PageLoad UKMs. Before this CL, the test checks the UKM recorder immediately after clicking the anchor link. This is not correct because PageLoad metrics are recorded when the page navigates away or becomes hidden (see callers of UkmPageLoadMetricsObserver::RecordPageLoadMetrics()). This means no UKMs are recorded regardless of the test configuration. After this CL, the test ensures that the browser navigates to the linked page before checking the UKM recorder. Also, this CL removes comments about cache interaction because this test doesn't refer to the cache. Bug: n/a Change-Id: Iecbe502718828f3dcb9bbbec811810ba66bc2d62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245428 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#779625}
-
John Delaney authored
Adds an aria-label to the interstitial icon when no text is being rendered. This reuses the interstitial heading data as the label. For non-small form frames, no aria-label is needed because the interstitial heading already describes the icon. However, when no text is rendered there is currently nothing that can be picked up by screen readers. Bug: 1095754 Change-Id: I51062e1028c74b61bc3e80922d05ad021f0e36e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249082 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Edward Jung (EMEA) <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#779624}
-
