- 19 Jan, 2021 40 commits
-
-
tby authored
This removes these two histograms and the logic related to them: Apps.AppListResultLaunchIndexAndQueryLength Apps.AppListResultLaunchIsEmptyQuery Bug: 1160781 Change-Id: Ifcd61df6a40dc6bb910bc7c2a6d27e83a0f84cbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628869Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#844957}
-
Yusuke Sato authored
BUG=None TEST=try Change-Id: I2c9220ff56432b946982685d22bec74b6307d027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631628Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#844956}
-
David Schinazi authored
This will allow us to query new records such as HTTPS. More details of the experiment are available internally at go/chrome-dns-concurrency. Bug: 1134205 Change-Id: If849689da3086290a3b61e33f42631db16398bdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636880Reviewed-by:
Renjie Tang <renjietang@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#844955}
-
tby authored
Launcher search results report a SearchResultType enum used for metrics. Some kinds of omnibox search result are being recorded as SEARCH_RESULT_BOUNDARY because they don't have their own value. AFAICT we never expected to see these results, as they used to trigger a NOTREACHED. From some testing, we see at least two of them in practice: - SEARCH_SUGGEST_ENTITY - NAVSUGGEST I've added enum values for these. I've also taken out the TODO saying to re-add the NOTREACHED, because I don't think we'll ever be confident we've covered all cases. Bug: 1121386 Change-Id: I4b8b1eaa696d84ad4752956fde925526777ab8b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631868 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
-
Curt Clemens authored
The placement of the invisible IronA11yAnnouncer element was causing trouble on the high visibility page with the apparent ordering of the elements. Since it is a replacement for the page subtitle, it needed to be located next to the subtitle in the html so that the node in the accessibility tree gets placed correctly. IronA11yAnnoucer was never designed to be used with modal dialogs. Explicitly placing an IronA11yAnnouncer on the page was a hack to get around the way modal dialogs are treated in the accessibility tree. While this mostly worked, the iron-announce event continued to bubble past the dialog and set the text on a second IronA11yAnnouncer element on the underlying settings page causing some strange behavior after the dialog is closed. Switching to a plain aria-live region fixes that. Another issue with invisible stand-in elements was that the visual highlight was not placed over the corresponding text when using search + arrow keys. Using absolute positioning to place the aria-live region on top of the subtitle it replaces achieves the desired highlight: https://screenshot.googleplex.com/6dHPQMDYaMBYsQ3.png When the page would initially load, Chromevox would read a few elements that weren't on the currently active view of the cr-view-manager. This turned out to be because elements with aria-hidden="false" were overriding the "display: none" applied by the view manager. Use "undefined" instead of "false" to fix. Also correct an issue where the interval timer wasn't getting cleared in the detached() event. Fixed: 1165982 Change-Id: Ia31dd52629fc27db55906d88de2160d908e4fccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632085Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Curt Clemens <cclem@google.com> Cr-Commit-Position: refs/heads/master@{#844953}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I0a8e4c80233244f46dd6e4e7f58d9dafe012561c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636878Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844952}
-
Miguel Casas authored
crrev.com/c/2628069 introduced to the V4L2VideoDecoder a limitation on the maximum number of decoder instances at a given time, making it behave like the legacy V4L2VideoDecodeAccelerator. That provision avoided the OOM observed on MS Teams (see bug). But the max number of instances (10) is too restrictive. A deeper look showed that every instance allocates all the necessary input buffers (i.e. those for the encoded chunks that go into the v4l OUTPUT q). V4L2VideoDecoder allocates 16 [1] whereas the legacy one only 8 [2]. FTR each buffer is relatively large: 4MB for platforms that support more than 1080p decoding, 1MB otherwise; MS Teams can successfully allocate 32 decoders on kukui, which gives us 32 * 16 * 1MB = 512MB of allocated memory; on trogdor this would be 2GB (!!). This CL tweaks a bit ToT numbers so we can allocate more decoder instances (32, good for kukui) and have a smaller number of input buffers allocated, aligning V4L2VideoDecoder with the legacy. [1] https://source.chromium.org/chromium/chromium/src/+/master:media/gpu/v4l2/v4l2_video_decoder.cc;l=34;drc=1bba741f920278b78341175ef888c19a6affd664 [2] https://source.chromium.org/chromium/chromium/src/+/master:media/gpu/v4l2/v4l2_video_decode_accelerator.h;l=145;drc=82e2036e3aadce02f587769c7ab6fc644953e008 Bug: b/170870476 Change-Id: If610ffe7c339ae3d883d893e41c92cc725e6fdaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633784Reviewed-by:
Fritz Koenig <frkoenig@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#844951}
-
Philip Rogers authored
This patch removes the kHasNonLayerViewportConstrainedObjects main thread scrolling reason because there are no longer any non-layer viewport constrained objects that scroll. All viewport constrained objects (fixed, sticky) are now composited if they scroll, and we do not need a main-thread scrolling reason if they do not scroll. Bug: 649096 Change-Id: Ia2c256a6b39983ef37b78a86aa761cbf33d5efe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622516 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#844950}
-
Siyu An authored
Bug: 1082013 Change-Id: If75e11b3b0c569bfda4bb0d178499e5488f00b5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623421 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Siddharth Shah <siashah@chromium.org> Cr-Commit-Position: refs/heads/master@{#844949}
-
Igor Ruvinov authored
Adjust new policy description to remove incorrect uses of PRODUCT_NAME which were applied to "Chrome" but should only be applied to "Google Chrome". This is a reland of 70b75301 Original change's description: > Update BrowsingDataLifetime policy description > > Update policy description of BrowsingDataLifetime policy to make it more > informative while cutting down on the technical details and complexity. > > Bug: 1163584 > Change-Id: I2764fbf7651625667b9199136f17ea6dc709ae41 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630865 > Commit-Queue: Igor Ruvinov <igorruvinov@chromium.org> > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844217} Bug: 1163584 Change-Id: I67d30f2a434b774b71262c7b48e02942ac10cc97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638101Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Igor Ruvinov <igorruvinov@chromium.org> Cr-Commit-Position: refs/heads/master@{#844948}
-
Bailey Berro authored
Bug: 1128204 Change-Id: I8801ebb4f65f5b867f084b5a55fbf4b81b13213c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634061 Auto-Submit: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#844947}
-
Theo Johnson-kanu authored
- This feature was never launched and the flag expired in M89. Extending expiry so that this flag can be re-used for a new unified cellular setup UI. - Updated team owner to cros-connectivity Bug: 1093185 Change-Id: I6edea8d789edf3d56c3142e2884ef11406ab4ef6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638358Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Cr-Commit-Position: refs/heads/master@{#844946}
-
Weblayer Skew Tests Version Updates authored
This CL will add skew tests for version 87.0.4280.152. R=ynovikov@chromium.org Bug: 1041619 Change-Id: I1cd3ed162a9c46fe81be79638100aa4c917ea740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636884 Auto-Submit: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#844945}
-
Bailey Berro authored
This change adds a GetContents() method to retrieve the current routine log. Bug: 1128204 Change-Id: If57dad4163dfce9843dffc4648fb728e73496807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627965 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
-
spdonghao authored
Bug: 1061906 Change-Id: I83b3021e5f0428dc6d2f46b6c2ec4deef75aa8e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623189Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Hao Dong <spdonghao@chromium.org> Cr-Commit-Position: refs/heads/master@{#844943}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/870bd0b9..6181c222 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic4f54ecaa6711ac59cc528e065744d45789000d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638356Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844942}
-
Eugene But authored
This metric will be recorded if applicationWillTerminate is called after applicationWillEnterForegroud. In that case the app will not properly mark the clean exit. Bug: 1167418 Change-Id: I0fa90862b18cc925b523d71d15fbf7af5c3b0e74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633974 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#844941}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/baf149636bd5..13d0f7c03fe3 2021-01-19 janscheffler@chromium.org [JSDOC2TS]: Migrate mobile_throttling If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1158760 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibc86ce3538a568be4a6d9e1738b586611602c341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637426Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844940}
-
Zhenyao Mo authored
R=kbr@chromium.org Bug: 1167875 Change-Id: I7c9d26f91ca130bfbb7b15f8ff9da340eb113f78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636375 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#844939}
-
Philip Rogers authored
PaintedScrollbarLayerImpl is used for overlay scrollbars on Mac. When the scrollbar thumb fades, |NoteLayerPropertyChanged()| should be called to ensure layer damage is recorded. Bug: 1038682 Change-Id: I57940907093fea57ba5a7a4fef8320ffb9246165 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629672Reviewed-by:
-
Matthias Körber authored
Currently, it is assumed that a name consisting of multiple words has the same number of words after normalization. In fact, the normalization replaces a list of known separators with spaces and the space is used to divide a name into its word. Therefore, running the normalization first can yield a larger number of tokens. This CL fixes the root cause of an issue that lead to a stability issue. The issue was mitigated by disabling this merge strategy since it was only used unintentionally. With this fix, the strategy becomes workable for future usage. Change-Id: I7f987e7e81f6ce968cbf728b529b3d6fe58a9313 Bug: 1158810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625884Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#844937}
-
Michael Crouse authored
This was behind a build flag but we also need it behind a switch so it isn't running in production for no reason. Bug: 1165517 Change-Id: I026e8a95a053efd000062c44b1ce7ff5e0aae845 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638413Reviewed-by:
-
Mustaq Ahmed authored
This is a reland of ce17e926 Original change's description: > PostMessage hookup to allow payment request delegation. > > This CL adds fields to postMessage data structures that convey > the sender Window's intention to delegate a capability to the > receiver Window. The change is behind two runtime flags: one flag > ("CapabilityDelegation") enables the parsing of a new postMessage > option for delegation, while the other flag > ("CapabilityDelegationPaymentRequest") enables transmission of > payment request delegation information to the receiver Window. > > Bug: 1130558 > Change-Id: Ifad482bc9629ea69b9bd802d5f0f7df7c24645f5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568627 > Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844548} Bug: 1130558 Change-Id: I63e31fd2959f08454421160f26a9e40414006f65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636836Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#844935}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f8dfc3b51883..f3087d8297fe 2021-01-19 mtklein@google.com allow a fourth Val/Reg arg per op 2021-01-19 fmalita@chromium.org [svg] Cleanup: use FP alpha for opacity 2021-01-19 mtklein@google.com remove reg/imm unions 2021-01-19 scroggo@google.com Fix decoding gifs with too-big-bounds 2021-01-19 bsalomon@google.com Fix DrawEdgeAAQuad degenerate issue where 3D points don't correctly project to 2D points. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1162942 Tbr: scroggo@google.com Change-Id: I7ed0b74cc37c0b75d0305d3f0cbcce5d2a66013f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638354Reviewed-by:
-
Sigurður Ásgeirsson authored
This reverts commit 5fce665c. Reason for revert: https://crbug.com/1168113 Original change's description: > PM: Enable service worker relationships in graph. > > Bug: 1143281 > Change-Id: Ibc54e560a2a2a5f38c6ef48c7352c40c1b82109c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636273 > Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> > Commit-Queue: Patrick Monette <pmonette@chromium.org> > Reviewed-by: Patrick Monette <pmonette@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844550} TBR=pmonette@chromium.org,siggi@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1143281,1168113 Change-Id: Ie84eef7095d735bd4e8b4e0d7fb097b20419a0b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637266Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#844933}
-
Garrett Beaty authored
The cores for the android CQ builders were recently doubled because they were long poles and it significantly improved the build execution time. However, on the branches where the machines are builderless, there are not currently builderlss machines with the doubled core count. This will use the old value for the branches to get CQ runs unblocked. (cherry picked from commit cd2034ee10fc3062749172582f6d57df6710b7ab) Change-Id: I904056c92b8b7be8ccfdfacdc31d052b21c553df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638094 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Original-Commit-Position: refs/branch-heads/4389@{#10} Cr-Original-Branched-From: 9251c5db-refs/heads/master@{#843830} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638443 Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#844932}
-
chrome://flagDale Curtis authored
Per discussion with the ChromeOS product team, they'd like to remove these low usage codecs. We'll start by putting them behind a flag that users can disable if they need an escape hatch. sweyn@ will identify an appropriate locale to notify users that these are being deprecated. Bug: 1167327 Change-Id: Ib4f59dba02a4a431ce9a883257c50bc4f9459c96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634063 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#844931}
-
Patrick Noland authored
This removal also lets us remove setUrlFocusChangeInProgress. As a replacement, SearchActivity makes itself a url focus change listener and uses the new LocationBarCoordinator#setUrlFocusChangeInProgress method to call setUrlFocusChangeInProgress(false) in the scenarios where SALBL used to do so. Change-Id: I25259c2d28e99d6404590ac4e15d158254722ca5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597221 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#844930}
-
Javier Ernesto Flores Robles authored
This CL applies the BVCContainer transforms directly to it instead of BVC applying them to its superview. Previous approach had a race condition where in some cases the BVC was already removed from it's container leaving the BVCContainer in the previous state. It also contains a few readability fixes in the involved methods. Bug: 1164978 Change-Id: I6e6cce85dca0478a062f04f7ba93aba14a051d74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629968Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Commit-Queue: Javier Flores <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#844929}
-
Mei Liang authored
TabContext listens to TabObserver#didFirstVisuallyNonEmptyPaint to invalidate the existing suggestion and fetch new suggestions. This CL ensures #didFirstVisuallyNonEmptyPaint is being notified only once before entering tab switcher. Bug: 1161272 Change-Id: Ic8a2410a68b116803c9f857bb7321a6a845c5ce0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626105Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#844928}
-
Glenn Hartmann authored
These are all long-lived metrics that will be relevant for the foreseeable future. BUG=1160721,1160761,1160763,1160762,1160764 Change-Id: Ieead4c86ad04638c18065a3b476dd911afc85cae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636275 Auto-Submit: Glenn Hartmann <hartmanng@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
-
Yuki Shiino authored
NULL is obsolete and doesn't work with the upcoming CheckedPtr, so rewrites NULL to nullptr. Change-Id: If1e2a15c95611157317aac48176d1cdbf3f23251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633487Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#844926}
-
Patrick Noland authored
To enable this, onClick for the delete and mic buttons is now implemented by LBMediator This extraction lets us: * Implement updateMicButtonState in LBMediator * Remove LBLayout methods: getVoiceRecognitionHandler, onWindowVisibilityChanged, getWindowAndroid, and setVoiceRecognitionHandlerForTesting Since SearchActivityLocationBarLayout used LBL's VoiceRecognitionHandler, we need to refactor the methods that do this to take one as an argument. Doing so is straightforward. Finally, some WindowAndroid methods are made non-final to allow them to be mocked in unit tests. Bug: 1147581 Change-Id: I54a6ba9b36b7a9991793b0f9d52a163e0b362bcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596424 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0d1002c96edb..7bcb61f96b8c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC dbertoni@google.com,xidachen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1063426,chromium:1138733,chromium:1150968,chromium:1151505,chromium:1155587,chromium:1162319,chromium:1164866,chromium:1166356,chromium:783819 Tbr: dbertoni@google.com,xidachen@google.com Change-Id: I3af28bc78f79cb18353f90c36ead8db058cbe8f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638357Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844924}
-
Sami Kyostila authored
Chrome is about to switch to the TRACE_EVENT macro implementation provided by Perfetto. The new implementation requires trace event statements to be terminated by semicolons, so this patch modifies the codebase to add semicolons where they were previously left out. No functional changes. Bug: 1006541 Change-Id: I2fffe5a69d13fec291795466da84d143c6d56005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629708 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#844923}
-
Sven Zheng authored
Bug: 1166113 Change-Id: I77db7600afdf04d82cf824b8395f96500c31b824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634086 Auto-Submit: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#844922}
-
Joey Arhar authored
In these spec PRs [1][2], the <link> element will no longer match :link, :visited, or :any-link, and it will no longer navigate the page when clicked. This patch also modifies the TestExpectations for one of the modified tests navigation.sub.html. There was one test case which was consistently timing out which I removed, which would stop the test from timing out. However, there are an additional two test cases which time out when run with run_web_tests.py but pass just fine with run_wpt_tests.py. In addition, the flags passed to run_web_tests.py on the trybots make it so that those two test cases which time out get written to a failure file instead of making the whole test runner time out, which would count as a failure in TestExpectations. Since the default flags for run_web_tests.py make it an actual timeout according to TestExpectations, I left the timeout expectation in there as well. Hopefully this test can just be run with run_wpt_tests.py in the future and we can get rid of this TestExpectation. [1] https://github.com/whatwg/html/pull/6269 [2] https://github.com/w3c/csswg-drafts/pull/5839 Bug: 611093 Change-Id: I7234eb6024450e28c1ca6ec1ede7fdfc8f2ece52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628037Reviewed-by:
Domenic Denicola <domenic@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#844921}
-
Dale Curtis authored
This allows the fuzzers to assign the right component as well as other integrations. R=tguilbert Bug: None Change-Id: I16e4b79d479ef1a704b31b3d1bf91e687a7c5ae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638453 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#844920}
-
Peng Huang authored
Bug: 1157501 Change-Id: I6f2035076423e5077bea0c295ef9211ac439cf20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634836 Commit-Queue: Peng Huang <penghuang@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#844919}
-
Dale Curtis authored
Now that we allow RGB VideoFrames through WebCodecs, we need to add support in VideoResourceUpdater since BreakoutBox allows them to reach our normal compositing path. R=sandersd Bug: 1167206,1167412 Test: Updated unittests. Change-Id: Ie7a72128ab4bf65c72a5a8a41014700b9db7d677 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634049 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#844918}
-
