- 05 Nov, 2019 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e9b546970ec2..7a13b461e6e0 git log e9b546970ec2..7a13b461e6e0 --date=short --no-merges --format='%ad %ae %s' 2019-11-05 mtklein@google.com x86-64 JIT support for Op::index 2019-11-05 csmartdalton@google.com ccpr: Fail gracefully when atlas instantiation fails Created with: gclient setdep -r src/third_party/skia@7a13b461e6e0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@google.com Bug: None Change-Id: Ifae4d72e4f1461a247a03c17cf72df7bea4522d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899419Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712701}
-
Christopher Cameron authored
When an app is profile-agnostic, change the Info.plist to: - Not embed the profile name in the kCFBundleIdentifierKey value - Not specify the kCrAppModeProfileDirKey value at all - Not specify the kCrAppModeProfileNameKey value at all - Strip the profile path out of the kCrAppModeUserDataDirKey value - Note that the user data dir still references the launching user's home directory, so these shims cannot be moved to /Applications. - That is tracked in the separate https://crbug.com/1021237 When searching for an app shim via bundle identifier, allow profile- agnostic apps to use either the profile-scoped or profile-agnostic shim. This will allow users to continue using pre-existing shims. A follow-on patch will add UMAs to query how often this occurs, so we can decide when to remove that code. This is all still behind a flag. Bug: 1001222 Change-Id: I2515fb179b6fde5ffa3b04c32e50fb93c6329860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894164 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#712700}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ia7250dd603ab0edaf6e49dcf60058b311b401842 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900108Reviewed-by:
-
Scott Violet authored
Now that launching waits for a first paint, this no longer seems flaky. At least I couldn't repro locally after ~10ish tries. BUG=1020065 TEST=test only change Change-Id: I1530fcb3f9811b0251a20bd151be5d55322283f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899336Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#712698}
-
Vadym Doroshenko authored
The only left warnings were recently introduced by CL https://chromium-review.googlesource.com/c/chromium/src/+/1811197 in files compositor_frame_reporter.cc and frame_sequence_tracker.cc. Bug: 999871 Change-Id: I77d50266a87ee8b3dbe9d9ed313b5019a364a8c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899986 Auto-Submit: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#712697}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/dbf9f7c39cbe..c277c38d9064 git log dbf9f7c39cbe..c277c38d9064 --date=short --no-merges --format='%ad %ae %s' 2019-11-05 cwallez@chromium.org Suppress failing VertexFormat tests on Mac Intel 2019-11-05 kainino@chromium.org Enable EmulateStoreAndMSAAResolve correctly by platform 2019-11-05 cwallez@chromium.org Vulkan: Reuse descriptor pools Created with: gclient setdep -r src/third_party/dawn@c277c38d9064 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I59a112ca5266d4138cc573ea4acfda2337225366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900089Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ac36a55cc2de..1bae56151db3 git log ac36a55cc2de..1bae56151db3 --date=short --no-merges --format='%ad %ae %s' 2019-11-05 jmadill@chromium.org Remove some ignores from export_targets.py. Created with: gclient setdep -r src/third_party/angle@1bae56151db3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: None Change-Id: I3e42c4e358433232327556b899f483de3467a3c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899484Reviewed-by:
-
Megan Jablonski authored
Bug: 976352 Change-Id: I0e8a1edd503654268c9b80f056107bf7bde88065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898089Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#712694}
-
Doug Arnett authored
Bug: 960961 Change-Id: I0d1003f4723d7482860e35cae50aeea8c77b835b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894322 Commit-Queue: Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#712693}
-
Maksim Sisov authored
The feature was accidentaly removed by crrev.com/c/1772537 This CL adds it back by adding necessary interfaces to DWTHLinux, PlatformWindowLinux and X11Window. The method is X11 specific and not in use for Wayland as long as Wayland does not allow to manipulate clients' windows. Bug: 1002358 Change-Id: Id43d5991f662f8986670ebef45f2443472806590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899464 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#712692}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a0fd7570. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ie3df3537178159264e4143564d1fc648c15d9369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899789Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712691}
-
Esmael El-Moslimany authored
The enhancements flag can be enabled by searching for webui-a11y-enhancements on chrome://flags or by adding the command-line switch --enable-features=WebUIA11yEnhancements. Bug: 1001742 Change-Id: I1d2b4162a8a5954172062d64aab871f4ca5b72ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898479 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#712690}
-
Mikhail Khokhlov authored
To avoid issues with quoting/unquoting cloud urls, we remove all unsafe characters from the remote name. Bug: 981349 Change-Id: Ia9a17642072d435141eb19d42c0692a5de86558b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899881 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#712689}
-
Nate Fischer authored
No change to logic, only docs. This clarifies that embedders may return the empty string from GetAppPackageName() for privacy concerns (previously this was not documented as a supported case). This removes embedder-specific terminology from the metrics component, and clarifies WebView's behavior in its method override. Bug: 969803 Test: N/A Change-Id: Idb57e4de11cc8c40b58f95a012a5110ba9bdf8b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897012Reviewed-by:
-
Dale Curtis authored
BUG=1016765 TBR=rsesek Change-Id: If47516e072201bf04750e76adb01420a999645eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900155Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#712687}
-
Dan Beam authored
Bug: None Change-Id: I8b7f574b49b92a6221462fd1b1139d4ab168731b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899007 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#712686}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 145 histograms that show frequent access in the past 90 days. These are the 80% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-05-03. Change-Id: I8fac8b4855e04e7bd9ba563ee428ec27c040c92a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899287 Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#712685}
-
Lan Wei authored
For the multiple touch points case, if we have one point move and the other point stay still, such as point 1: pointerdown, pointermove, pointerup point 2: pointerdown, pause, pointerup We should send five touch point events of "pointerdown", "pointerdown", "pointermove", "pointerup", "pointerup" with pointer id 1, 2, 1, 1, 2. Bug: 1020674 Change-Id: I2a738154fee5a4356b64467fd9483c69429217d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895861Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#712684}
-
Maksim Moskvitin authored
This is a reland of b9c8d354 CL was reverted because of test failures on many builders. The reason for this failures is ModifyEntitySpecifics() being wrapped in DCHECK(), which makes new test extremely flaky. Solution: unwrap it. Original change's description: > Add test for keystore key rotation > > New test mimics server-side behavior for triggering keystore key > rotation: generation of new keystore key with touching the Nigori > node. After that client should receive updated keystore keys and the > same Nigori node as it already has (modulo metadata update). The client > should commit the new Nigori node with rotated keystore key and this > verified by checking |encryption_keybag| encryption key name. > > Bug: 922900 > Change-Id: I91b86bbb0f68a55fdcc10049fa90afa70dc32155 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887611 > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> > Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> > Cr-Commit-Position: refs/heads/master@{#712502} Bug: 922900 Change-Id: I994af8befefb8207cedd37e53022329258455221 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899497 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#712683}
-
Tim Sergeant authored
These disk reads on the main thread are working as intended and safe enough to ignore. Change-Id: I67a9a2b94e26c97c7427d283a239acefc7a400a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899615 Commit-Queue: Tim Sergeant <tsergeant@chromium.org> Auto-Submit: Tim Sergeant <tsergeant@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#712682}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/51a6086ce618..287edca9b437 git log 51a6086ce618..287edca9b437 --date=short --no-merges --format='%ad %ae %s' 2019-11-05 taylori@google.com Merge "perfetto-ui: Only do logs queries when there are logs" Created with: gclient setdep -r src/third_party/perfetto@287edca9b437 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ica863f91fb995f837782726899fa719ec21ede6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900088Reviewed-by:
-
Daniel Murphy authored
content/browser/indexed_db/leveldb/leveldb_env.h is the leveldb_env::ChromiumEnv implemenation that is exlusively for IndexedDB. Because tests and other systems can create their own leveldb_env::ChromiumEnv, this can just be in the indexed_db/ directory, as there is no reason to share it. Bug: 1015212 Change-Id: I6f8ae76329d30bb25e6d4877fcaef80b3356f8b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898327Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#712680}
-
Mounir Lamouri authored
Bug: 1016906 Change-Id: I9baa32384e0b82490efc605583878681a85c7245 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898621 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#712679}
-
gogerald authored
Bug: 1021399 Change-Id: I7b9aa63e6613b495614b38acbf850786c159054b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899408 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#712678}
-
Nazerke authored
This CL - adds the source file to sources list, - adds required gn dependencies, - links to both eg1 and eg2 frameworks, - adds helper to +(void)setUp to support eg2. Bug: 866147 Change-Id: I7b3b794b6ef11ac2eae114904764a00151f901e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893066 Auto-Submit: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#712677}
-
khmel@chromium.org authored
This adds serialization/deserialization of information about tracing session in graphics model instead of attaching it per each session done. This includes app title, icon, timestamp and platform. This allows it to reuse when loaded offline. TEST=Locally, unit test extended. BUG=b/143532713 Change-Id: If8888e46c3327c725f15ea7dec28310f92e66920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898617Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#712676}
-
Elly Fong-Jones authored
After r712264 much of the controller for this class is const, so it is now clear that it's safe to create the signin promo view once in the constructor. Woo! Bug: 1011446 Change-Id: I9ac5b0c9e557915594e6da17a9e58c726296bf57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899417Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#712675}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/63c55152..4abff70f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I54ad7494662d8ebc38189db15c832e101b207369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899788Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712674}
-
Andrew Xu authored
Move the logic of adding the extra four-pixel padding for tablet mode from ScrollableShelfView::Layout to ScrollableShelfContainerView's layout. It helps to update the shelf view's layout after switching to the tablet mode. Bug: 1012354 Change-Id: I975954faf687c144166e8a86ae9fa89959e931f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850796Reviewed-by:
-
Andrew Luo authored
Bug: 1016864 Change-Id: If0df06cd26bec317e5838d0dea82e4e51cfdd43c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885156Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#712672}
-
Joshua Pawlicki authored
TBR=rsorokin@chromium.org Bug: 1021594 Change-Id: If3684e34bfcf3c36350175fa0154c7b43e933ec7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899889Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#712671}
-
Vladislav Kaznacheev authored
Currently --enable-dim-shelf flag has the opposite effect (dimming is disabled when the flag is present, and vice versa). This is due to a spurious negation in the IsUsingShelfAutoDim implementation. Bug: 996006 Test: manual Change-Id: I44340bbacb2a998f57176bb7405c39cf4309380d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899088Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Auto-Submit: Vladislav Kaznacheev <kaznacheev@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#712670}
-
Michael Ludwig authored
Just a minor clean up to some of the internal drawing/prep functions that don't actually modify SkiaRenderer itself. CalculateRPDQParams cannot be const because it needs to create ScopedSkImageBuilders, which don't work with const SkiaRenderer*'s. Bug: 1013735 Change-Id: Ic3bddd6cea28dfaf4b977ebef77e1ced4eea6089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863629 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by:
weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#712669}
-
Christopher Cameron authored
If an app shim doesn't specify a profile (as multi-profile shims will), or if the profile is no longer valid (as is the case for zombie shims), do something reasonable. Add tests for the new behavior - one where an invalid profile is specified, and we fall back to a profile for which the app is installed. - one where no profile is specified, and we use one for which the app is installed. Bug: 1001213 Change-Id: I96de89cf96697612f3ba56e680ef86411ded3212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894067 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
-
Andrew Grieve authored
Bug: 916880 Change-Id: I623ce658212173c116780d5816d0de8733acac65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878612 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#712667}
-
Raymond Toy authored
Continue to add to the rendering orphan handlers list if the destination is still rendering. If the destination is requested to stop, set a flag so that the rendering won't pull on the audio graph anymore, even if the audio device is still running and requesting data. In the test case from the bug, we were not adding the handlers to the list because the context was closed. However, the destination was still running because the audio device wasn't stopped yet. In the test, the handlers were being destroyed at the same time as the audio thread was accessing the handlers to render audio. Bug: 1003807, 1017961 Change-Id: I87052c8504c5698d71f041e6d4305cf42851f067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879784Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#712666}
-
Sinan Sahin authored
Bug: 971514 Change-Id: I925edaf78eb090d9c77fdcf3e36bde07b3ad4c0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894435Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#712665}
-
Clark DuVall authored
Actually granting and revoking permissions caused a lot of problems, instead this modifies the WebLayer implementation context to return the permission we want. Bug: 1021050 Change-Id: Ibd8dc3d42fc420b86060d8d8647df528aa0cef0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898626Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#712664}
-
Tommy Steimel authored
This CL adds horizontal alignment to the title and artist labels to ensure that they stay properly aligned to the left. This fixes a bug where overflowing text would shift slightly to the right. Bug: 1021589 Change-Id: I7c007f4d7af4abe1556941b901a57569dcc41f30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899089 Auto-Submit: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Jazz Xu <jazzhsu@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#712663}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/aaa64b76c0b4..b0a1f0a96806 git log aaa64b76c0b4..b0a1f0a96806 --date=short --no-merges --format='%ad %ae %s' 2019-11-05 capn@google.com Update Vulkan CTS testlist Created with: gclient setdep -r src/third_party/swiftshader@b0a1f0a96806 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/140172528 Change-Id: I2c83a7bcefd1083393d30dab942b6c35c88282d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899588Reviewed-by:
-
