GitLab

* Implement TestOAuthTokenGetter that loads the stored access token and
  runs the authentication flow.
* Move CLI related logic into cli_util.cc

These make it easier to implement FtlSignalingPlayground

Bug: 947337
Change-Id: I5fb56008f2952f9444d2e0760f4614fb46667484
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548599
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646629}

The test flakily fails on iPhone and iPad devices.

Bug: 944803
Change-Id: I102cfae6ed43d57db7d63deedb1cea61a1bd0405
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548534
Commit-Queue: Eugene But <eugenebut@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Auto-Submit: Eugene But <eugenebut@chromium.org>
Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646628}

This work is for separating TabFeatures calculation from ukm logging.

(1) PageMetrics is expanded to also have page_transition.

(2) TabMetrics is not needed any more.

(3) More tests are added to confirm that each TabFeature is populated
    correctly. (There will be another cl that confirms features in
    TabActivityWatcher are all populated correctly.)


Change-Id: Ie7f718155c03259513670cd0edce870f07a9c7cd
Bug: 945699
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538069
Commit-Queue: Charles . <charleszhao@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646627}

'string' clashes with 'String' in Googletest.

Change-Id: I6b0880e7bbd86d225dfae9e1996f2848c7040ef1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548603
Auto-Submit: Staphany Park <staphany@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646626}

Fall back to 3dof-orientation only when tracking is lost. If we
previously were tracking, use the last position.

This doesn't add emulated controller positions - controllers aren't
reported if tracking is lost.

Bug: 944605, 928814
Change-Id: Idc963f66b30905012a7fb6675c07e0d22a382d23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545153
Commit-Queue: Bill Orr <billorr@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646625}

This CL fixes two bugs for rounded corners:
- Rounded corners uniforms were not set for YUVDrawQuad.
- Rounded corners uniforms were set on the wrong program
  for TextureDrawQuads.

It additionally removes an early out in SetShaderRoundedCorner
when there is no current program or the uniform location
for rounded corners data is not there.
That was likely introduced since we were calling SetShaderRoundedCorner
on the wrong program or when a current program was not even set.

Bug: 946728
Test: Ran overview mode with a video on Linux and Nocturne.
Change-Id: I9902eff8349367199b24c3629e7949a68e453877
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544805
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Malay Keshav <malaykeshav@chromium.org>
Auto-Submit: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646624}

There is no functional or code change with this patch, only re-ordering

R=jsbell@chromium.org

Bug: 862456
Change-Id: I697154c774b316a5e827967103f005dbf13f3232
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544810Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646623}

Implement a PRESUBMIT check to check that GLES2, raster, and webgpu
autogenerated files match the output of the respective script when any
of them are changed.

Also checks that any changes to autogenerated headers have corresponding
generator changes.

Bug: 945670
Change-Id: I37e1709647dde25d111af01e945085689a1a4794
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546673Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646622}

Currently, the wrong context is being used inside the
SharedImageRepresentations when using multiple contexts
across multiple threads.

This CL will route the correct context to each
SharedImageRepresentation.

Bug: 938594
Change-Id: I5c0e7583258f3e1c7256d39223b4c9b4b738b8ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542785
Commit-Queue: Chris Blume <cblume@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646621}

* Fix some padding and gravity related bugs.
* Add elevation for TabGrid card on devices with API 19-22

Bug: 928388
Change-Id: I7833f2cc2eb3025c138533f457702efbb0b5a84b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546534Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Yue Zhang <yuezhanggg@google.com>
Cr-Commit-Position: refs/heads/master@{#646620}

Adds a header area to the top of the Extensions menu. This is not done
as a bubble title since the area needs to have non-standard buttons in
the captions area + transitions will be made between different pages.

Bug: chromium:943702
Change-Id: Ie9c62e0f1d9ea5cf5e53b94a18c5810ca83112af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548244
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Taylor Bergquist <tbergquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646619}

With the autofill-captured-sites-rel bots running in the Chromium lab
every 6 hours, we can increase the number of tests from 13 to 100.
This change checks in an additional ~90 captured sites tests into CIPD,
sites that I have verified are stable in the latest Chromium builds.

Please also note that the list now only has the FIRST 100 tests that
are passing. We actually have 128 tests passing at the moment.

Updates the CIPD yaml config file. (I uploaded new files from my local
machine by running a cmd against the new CIPD yaml file)
Updates DEPS to pull the new test support files.

Change-Id: Id962ab050df3bfb6c9a906a2d6f5f418187a6e63

Bug: 847905
Change-Id: Id962ab050df3bfb6c9a906a2d6f5f418187a6e63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546670
Commit-Queue: Pavel Lemeshev <lemeshev@google.com>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646618}

This setting is only used by Perfetto, which doesn't merge configs.

With this DCHECK in place, the trace buffer size can't be configured
through Telemetry as the setting isn't passed through any
command-line switches and hence the DCHECK is hit when the full
config is passed through the full Mojo path and merged with the
startup tracing one. As the option is only used within the tracing
service after startup tracing has already been set up, there's
no point in passing it through the command line and so we just
ignore it instead, if it changes.


R=ssid@chromium.org

Bug: 946517
Change-Id: I56d05dd4f7167dfada4560737d054132d0a47dc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548372Reviewed-by: ssid <ssid@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646617}

This CL is a preparation for building typemapping for
blink::ResourceRequest. In the current code, network.mojom.URLRequest
contains members like |render_frame_id|, |is_main_frame|, etc. In cpp
code, these data are saved in RequestExtraData, while blink::RR keeps
|sharable_extra_data_| as a base class point for RequestExtraData.

As a result, when converting blink::RR to URLRequest, the data saved in
RequestExtraData cannot be reached inside blink/ as RequestExtraData is
a data struct in content/.

This CL try to move data (and corresponding getter/setter), from
RequestExtraData to ExtraData. By doing this, we don't need to touch any
user of these two classes, as we are still keeping the original member
functions' prototype. Then moved data can be touched when making
conversion between blink::RR and network.mojom.URLRequest.

Change-Id: I6995b64ff9da6bef0d70b22b5ec1167bd1e8666f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542727Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Richard Li <richard.li@intel.com>
Cr-Commit-Position: refs/heads/master@{#646616}

https://android.googlesource.com/platform/external/perfetto.git/+log/21a33afeef56..cb851311e16f


git log 21a33afeef56..cb851311e16f --date=short --no-merges --format='%ad %ae %s'
2019-04-01 medinaandres@google.com Merge "Only enable ASAN annotations when passing ASAN compile flags."
2019-04-01 lalitm@google.com Merge "trace_processor: fix gcc and msan builds"
2019-04-01 lalitm@google.com perfetto: minor fix of build files
2019-04-01 lalitm@google.com perfetto: move from alias rules to rewriting target names
2019-04-01 lalitm@google.com perfetto: refactor and massively speed up gen_build
2019-04-01 lalitm@google.com perfetto: add build file generation script and build files
2019-04-01 lalitm@google.com Merge "trace_processor: unify all the numeric column implementations"
2019-04-01 lalitm@google.com Merge "trace_processor: fix minor include error"
2019-04-01 hjd@google.com Merge "ui: Collect power rails where possible"
2019-03-29 lalitm@google.com perfetto: attempt 2 at fixing is_trivially_{constructible, copyable}
2019-03-29 lalitm@google.com Merge "trace_processor: add missing file to BUILD.gn"
2019-03-29 treehugger-gerrit@google.com Merge "protozero: add missing \n to protozero generator"
2019-03-29 treehugger-gerrit@google.com Merge "protozero: temporarily disable is_trivially_{constructible, copyable} check on some platforms"
2019-03-29 primiano@google.com Merge "Fix tools/update_traceconv"
2019-03-29 oysteine@google.com Merge "Make sure to always create the SMA on the correct thread in the in-process case"
2019-03-29 oysteine@google.com Merge "Chrome: Add config for privacy safe mode"


Created with:
  gclient setdep -r src/third_party/perfetto@cb851311e16f

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:127775946,chromium:127775946,chromium:127775946,chromium:127775946
TBR=perfetto-bugs@google.com

Change-Id: I9822e8cffc788e266debbb8d015b5302ba9649c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548090Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#646615}

They are flaky on the bots.

BUG=948372
TEST=test only change
TBR=riajiang@chromium.org

Change-Id: Iad5a97d38ed0edf6bb0dfe6e9efa8017f5d062e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548330Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646614}

Per discussion thread in
https://groups.google.com/a/chromium.org/forum/#!msg/chromium-dev/QX1ZnJ0JROs/d2BBkL8SFAAJ

This directory is meant to help facilitate better code sharing
as well as help with reorganizing base in to finer grained
categories.

Bug: none
Change-Id: Iaa418198667dc262a99409d00179087f4fc3c7c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525470Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Albert J. Wong <ajwong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646613}

https://skia.googlesource.com/skia.git/+log/036503b07ea6..3f6a2ac63670


git log 036503b07ea6..3f6a2ac63670 --date=short --no-merges --format='%ad %ae %s'
2019-04-01 reed@google.com remove unneeded asACompose
2019-04-01 brianosman@google.com Remove ToolUtils::write_pixels


Created with:
  gclient setdep -r src/third_party/skia@3f6a2ac63670

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jlavrova@chromium.org

Change-Id: Id8c9f1455d32113a9a93a70f2adc3457d8d1d0ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548493Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#646612}

This behavior was lost in crrev/c/1546524.

Bug: 948174
Change-Id: Ic69c18b3bd6f3d990c95eca42df83ac29bdaf947
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548560
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Auto-Submit: Sidney San Martín <sdy@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646611}

As requested in https://crrev.com/c/1546002

R=dgrogan@chromium.org

Bug: 945214
Change-Id: I20f6d82971b3a1b4ab632f7ac30db56ff792c36f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546938
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646610}

So gn check will cover the directory.

Bug: b/123036198
Test: None.
Change-Id: Iec310e4ceb1c3a34fc955d1fd9a441f64213c163
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546636Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Kehuang Li <kehuangli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646609}

The old way of setting a flag on Window is deprecated, and doesn't work
correctly on some newer devices.

Bug: internal b/122813747
Test: unittests, P and pre-O manual tests
Change-Id: I593c287b755ba2dd68221820621af2e955b1fd65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548555Reviewed-by: Simeon Anfinrud <sanfin@chromium.org>
Commit-Queue: Thoren Paulson <thoren@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646608}

@IntDef/@StringDef annotation are preferred way for declaring
set of String/int values

1. they need less space in APK than enum, see
https://developer.android.com/topic/performance/reduce-apk-size#remove-enums
2. they give more control over allowed values than "static final" values

Patch is updating HWEncoderProperties to @IntDef with form common with other Chrome @IntDef:

1. with @IntDef first, @Retention second
   and related @interface third
2. with values inside @interface
3. with @Retention(RetentionPolicy.SOURCE)
4. without "static final" in the @interface
5. with NUM_ENTRIES

BUG=919666

Change-Id: I3dac5daa74145708436f63c6a8af0f50136addc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545928
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646607}

Wasm is a 32-bit system, and hence uses 32-bit integers. Restrict the
input image length (a JS int) to << 32-bits (2^30 for now).

Bug: 935285
Change-Id: I2d523e49b2392fb49f8b25e9b77e8334532b5b5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546803Reviewed-by: Alex Danilo <adanilo@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646606}

This driver upgrade is underway and using the Swarming-side solution
to send traffic to both the old and new driver versions.

Bug: 920665
Bug: 927414
Change-Id: Idc3fd9aa97335621ea7d3db44a1502d1be68d002
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548388Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646605}

Change-Id: I99aab3b42cc7d09fbcaabe6ab0cc41739c1bd556
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526438Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Aran Gilman <gilmanmh@google.com>
Cr-Commit-Position: refs/heads/master@{#646604}

Because Switch Access (the feature) is behind a flag, this setting
should only show when that flag is enabled.

Bug: 948084
Change-Id: I60f4a8e072be656045e920fb5ee39fec8490e031
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548363
Auto-Submit: Anastasia Helfinstein <anastasi@google.com>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Cr-Commit-Position: refs/heads/master@{#646603}

BUG=None

Change-Id: I46a53f84f4017d2b30bdfbe8f100187eaeba6010
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546648Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646602}

As advised in [1], this CL removes unnecessary Foo::Create() factory functions
which return an instance created by MakeGarbageCollected<Foo> in
//third_party/blink/renderer/core/layout, then this CL makes the callers
use MakeGarbageCollected<Foo> instead of Foo::Create() factory functions.

Additionally, this CL cleans up them in core/intersection_observer and core/invisible_dom
as well.

[1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ

Bug: 939691
Change-Id: I6b1f0b35ce48275f1eb746b265d5c52e91cf4df4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547531Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#646601}

This was only necessary for paged overflow for the viewport with
-webkit-paged-x which is now removed.

Bug: 940652
Change-Id: Id1d4a5b77fa1836106b677324450a3c06b331125
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548473
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646600}

Bug: 868561
Change-Id: I17995b34fc4b536720f895ba0e330293d9a49de1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548364Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646599}

https://pdfium.googlesource.com/pdfium.git/+log/010a4da72d17..7382a72a748f


git log 010a4da72d17..7382a72a748f --date=short --no-merges --format='%ad %ae %s'
2019-04-01 thestig@chromium.org Roll build/ e51ca1d98..c899486de (2 commits)
2019-04-01 tsepez@chromium.org Add single select box to field.fragment
2019-04-01 tsepez@chromium.org Add multiple select to field.fragment.
2019-04-01 thestig@chromium.org Sync third_party/yasm build files with Chromium's.
2019-04-01 tsepez@chromium.org Rename field.fragment subfields to more descriptive names
2019-04-01 tsepez@chromium.org Renumber JavaScript object in field.fragment
2019-04-01 tsepez@chromium.org Use span<> in more fxjs/xfa code.
2019-04-01 wnwen@chromium.org Rename android_tools to android_sdk


Created with:
  gclient setdep -r src/third_party/pdfium@7382a72a748f

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:948150,chromium:948150,chromium:947060
TBR=dsinclair@chromium.org

Change-Id: Ic3c128b09de63e950888c860fb961ce5a38bd5d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548108Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#646598}

This CL:
- Adds the "WebappSplashScreen.hidingAnimation" trace event which
  tracks the start and stop of the splash screen hide animation.
- Removes the "WebappSplashScreen" trace event because it is redudant
  with "WebappActivity.showSplash" and
  "WebappSplashScreen.hidingAnimation".

BUG=945784

Change-Id: If4e6513a288867b028c5a797d41ef32d754708e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547068Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646597}

+ Fix a crash on inflating vector drawable ic_add_circle_40dp in
  settings
+ Fix a bug on managed preference delegate that sets the icon to null
  on bind when the preference is not managed

Bug: 948267, 947905
Change-Id: Icd32fb599612ed980b6aa1bd8b2747de12bc8cff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548394
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646596}

Screenshots
1. focused email: https://screenshot.googleplex.com/SSjpDYjwm9C
2. focused name: https://screenshot.googleplex.com/UY7K1EndivM
3. focused street address: https://screenshot.googleplex.com/dVdx0p8AqDT
4. focused non-street address: https://screenshot.googleplex.com/AP3VGxgGt5T
5. focused phone: https://screenshot.googleplex.com/00x6eCP6BZw

Bug: 936168
Change-Id: I7c2e99fadb3d57dc6dfeec3af1d8c001f28be1e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542559
Commit-Queue: Caitlin Fischer <caitlinfischer@google.com>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646595}

This CL (hopefully) fixes a crash in IconLoadWaiter::RunCallback.
It looks like OnIconUpdated can get called after the timeout timer has
fired (before the delete is processed), causing the now null callback
to get executed. We avoid this by immediately deleting the object if
the timeout timer fires.

Bug: 941754
Change-Id: I21309cd34b04a7256e903927f4700fb03851cd4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546744Reviewed-by: Nicholas Verne <nverne@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646594}

This is a reland of 9d6b2ab9

Original change's description:
> overview: Move "No recent items" label out of shield widget.
> 
> Shield widget is getting removed. This is step one by moving the cannot
> snap window out into its own separate widget owned by overview_session.
> Since there is only ever one shown, it doesn't need to be owned by
> overviewGrid.
> 
> Test: ash_unittests OverviewSessionTest.*
> Bug: 942759
> Change-Id: I5c9e40763a35d27f2e383effada0f4f6d8791320
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535131
> Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
> Commit-Queue: Sammie Quon <sammiequon@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#644538}

Bug: 942759
Change-Id: Ied7f2e4ef9b7fe3d38055d58040d101378dff731
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542557
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646593}

Style guidelines encourage using either BindOnce() or BindRepeating(),
not Bind(). This CL converts some Bind() calls to their respective
type.

Change-Id: I7e816bfd102f9e28989cff40003fc0f7192458d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546887
Commit-Queue: Kevin Bailey <krb@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646592}

Bug: 944115
Change-Id: I42573db7c4e99f21c9ef208aeb31e0a10b9f10f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548319
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646591}

This CL :
1 - Disables the download auto-resumptions in native feature
2 - Adds a flag for testing purposes

Bug: 948299
Change-Id: I4a04eb17e61e40e9a4d471e1bfaccd77c0029270
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547763Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646590}