- 26 Sep, 2019 40 commits
-
-
Bill Budge authored
- Splits Write into two parts, response time and data. Uses stream 0 for response time, stream 1 for data, to avoid a slowdown. - Splits Read similarly. - Eliminates the extra data copy when writing caused by passing a span from CodeCacheHostImpl rather than the Mojo BigBuffer received from the renderer. - Changes the keyed PendingOperation queues to keep the active op at the head. This simplifies the helper method and callback signatures. - PendingOperations now own the IOBuffers for Write and Fetch. - Using stream 0 now will make deduplication of the code caches (not storing a copy of the code for each origin) easier in the future. Behavior changes: - IssuePendingOperations now runs PendingOperations through the queues rather than all at once. This was probably didn't happen in the real world but seems incorrect. - Reads where one or more parts fail now doom the entry. We should help the cache eliminate inaccessible data. - Response time is now stored in stream 0. This means any data in the cache from previous Chromes where response time was a prefix on stream 1 will cause a cache miss, since the time stamp read will fail. This CL then makes the data read fail, since returning data prefixed with a timestamp could be confusing now. Invalidating the caches shouldn't be a problem, since we expect a new version of Chrome/V8 to cause the code caches to become invalid since their version/feature header won't match, see: https://cs.chromium.org/chromium/src/v8/src/snapshot/code-serializer.cc?rcl=6c89d2ffb531b3c79181532b5de04adaf7206049&l=387 Bug: chromium:992991 Change-Id: If3c5e8a83bca811fcb809a8a89c6d22942456f13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814685 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#700307}
-
Xiaoqian Dai authored
See https://docs.google.com/document/d/1rskVuhK9wAqgntcq9WYPSknMEc_jsAp3zrqb4YSMAqE/edit# for the mock and expected behaviors. See crbug.com/997885#c5 for demo. For now with this CL in place, we can only drag the window around. More will be done in follow up Cls. Bug: 997885 Change-Id: Iecea3a8cb4a6fe3c6a64ddddea08bc010cfb72dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817105 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#700306}
-
chrome://flags/deprecatedYann Dago authored
Visual: http://screen/mG7ARfoC0iB Bug: 1008156 Change-Id: I6cf6cb84ef6b797162147900b978aea293f94a28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824836Reviewed-by:
Yann Dago <ydago@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#700305}
-
Kyle Horimoto authored
No margin was provided, so <cr-icon-button> used the default margin, which happened to be -8px. This CL sets the margin to 0. Bug: 981318 Change-Id: I6fa10935feecdda9626d3698ca10b707d28761e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825141 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#700304}
-
Henrique Nakashima authored
Everything has been moved to chrome/browser/util. Bug: 995916 Change-Id: I679927eef785f04f95f34604687ef81f1c794dd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816973Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#700303}
-
Boris Sazonov authored
Bug: None Change-Id: I44ce5e128389a0a64f310e5b6d9d26a0ae231710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823118 Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#700302}
-
Denis Kuznetsov authored
Bug: 1007180 Change-Id: I791e11308f6febc6cf3f73bb8c723341e0adee3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821523Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#700301}
-
Matt Menke authored
It was using separate HostSchemePorts for wss/https and ws/http. This CL makes it normalize scheme to https and http. Bug: 997241 Change-Id: Ic0688f6eb40a6a70f940ae7c4547c9d1475baaa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822819 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#700300}
-
Simon authored
TBR=perezju@chromium.org Bug: 1007355 Change-Id: I77060168b5135d016d8f0cb11f613f9cfb37bee7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822104Reviewed-by:
Simon Hatch <simonhatch@chromium.org> Commit-Queue: Simon Hatch <simonhatch@chromium.org> Cr-Commit-Position: refs/heads/master@{#700299}
-
Fredrik Söderquist authored
Nothing should call these through a StyleFetchedImage, so we can make these private. Add a comment about the overrides (also in StyleFetchedImageSet). Change-Id: I564d9603a77cf2452c504e3150f49dd11ea14053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824276Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#700298}
-
Steven Bennetts authored
Without this change, cr-dialog will scroll with the content. This fixes that issue. Bug: 828795 Change-Id: I75ed18dd8f8cc2b8f0f93395b207c99fd53bbf99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826118Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#700297}
-
Robbie Gibson authored
Before, when the scrim was up, dimming the results view, Voiceover would still read the dimmed elements. Now, as part of putting up the scrim, the table view marks all its subviews as accessibilityHidden, so they don't appear in Voiceover. The opposite happens when the scrim is removed. Bug: 981343 Change-Id: Ibfb9d37f64c30f75fbe6d05633c7e6f4790f3713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826888Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#700296}
-
Sebastien Lalancette authored
Test has been flaky in the recent runs: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=ash_unittests&tests=DropTargetOnCorrectDisplayForDraggingFromOverview TBR=sammiequon@chromium.org Change-Id: I30ff04ef28a9a4be996f76a7ae88c23d68b00771 Bug: 1008408 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827501Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Auto-Submit: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#700295}
-
David Maunder authored
TabContextObserver is used to signal changes to the tab model. It has applications where we want to prefetch the tab close suggestions after the tab model changes so they are available for the UI thread (and the UI thread doesn't have to block on them). Bug: 1005573 Change-Id: I91ea9367a90301d6bc6dc9a00c141c59a574db5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811935 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#700294}
-
Daniel Nicoara authored
* aura::Window default property values return 0 as the default value if the property isn't defined. So we can't initialize the IDs to 0 by default otherwise we could get matches on un-initialized Webviews. * Register the WebviewWindowManager::Observer when the Webview is created since this is when we have the Webview to parent. If it happens that we get a parenting request without a valid Webview it will crash the browser process. Bug: b/132811925 Test: Try to register Webview with ID=0 Change-Id: Ieb82c97be3850633b02894cb2a805272d38d227e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827582Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#700293}
-
Hazem Ashmawy authored
Add build.gradle and AndroidManifest.xml files that are needed to build these interfaces as an independent target in AndroidX repo. These files are used by AndroidX build scripts only and should not be used inside chromium project. Bug: https://issuetracker.google.com/issues/140178227 Change-Id: I7686c7e49bfc023dd818210e583b7f535fe9b61c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823119 Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#700292}
-
Dominik Röttsches authored
SetFontRenderParams() took only the family name of the returned fallback font, and performed rematching based on the run's styling. This rematching leads to an inaccurate recreation of the intended fallback font. The intention with fallback fonts returned from Skia is to use the exact SkTypeface that was returned by the fallback call, not to attempt to extract family, weight, style parameters and recreate. This CL split SetFontRenderParams() on TextRun::FontParams into two cases: One that allows rematching, which is useful for styling when doing the shaping runs with the primary fonts (as the Omnibox uses it for styling substring matches, for example). Secondly, for fallback, the new method SetRenderParamsOverrideSkiaFaceFromFont() is used which tries to extract the SkTypeface from PlatformFontSkia if that is the underlying PlatformFont implementation. Otherwise it performs a rematch using CreateSkiaTypeface() as in SetFontRenderParams(). This gives us a viable path forward towards moving to PlatformFontSkia exclusively, in which case we can remove the last resort rematching step, as we will always have an underlying SkTypeface. This CL is also preparation for fixing issue 1003829 in which a specific weight of Segoe UI is returned by the Skia fallback methods but inaccurately recreated in SetFontRenderParams() as the weight information is lost. Bug: 1003829 Change-Id: I8d0ed08754b97ec0254325c4b09cd74aec9e07ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824469 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#700291}
-
Huanzhong Huang authored
Show cookie controls notice on incognito ntp when the improvedCookieControls flag is enabled. screenshot: https://screenshot.googleplex.com/WTCUPwSowr9 Bug: 967668 Change-Id: I83b0d6c607ccd4a339ea66b829405224bfbc1732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814817Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Cr-Commit-Position: refs/heads/master@{#700290}
-
Sebastien Lalancette authored
This reverts commit 3dd95e21. Reason for revert: Suspect for android-builder-perf compile failures: https://ci.chromium.org/p/chrome/builders/ci/android-builder-perf/115402 Original change's description: > [Payments] Enable shipping and contact info delegation [4/5] > > This cl implements shipping address/option change events for PH. With > this change payment handlers can notify the merchant when the user > changes the selected shipping address/option, and wait for updated > details (e.g. new shipping cost, etc) from merchant. > > For overall flow please check > https://chromium-review.googlesource.com/c/chromium/src/+/1779003 > > Bug: 984694 > Change-Id: Id881ba22bf4c846a4570801bacc49e5d4e89a72b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804557 > Reviewed-by: Mike West <mkwst@chromium.org> > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Commit-Queue: Sahel Sharify <sahel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#700238} TBR=rouslan@chromium.org,mkwst@chromium.org,sahel@chromium.org Change-Id: I74d8507117fc9a0000142071b71146d14f17f8bf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 984694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827544Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#700289}
-
Lucas Furukawa Gadani authored
Bug: 759184 Change-Id: I72c874798047f89c08271ba471d67baf04f2a920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825899 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#700288}
-
Elly Fong-Jones authored
If an item in the Tab menu either is or recently was playing sound, append a sound state icon to it to make it stand out as such in the tab menu. This will help users with a lot of tabs find the ones making noise. Bug: 1006624 Change-Id: Ia718f655d25a23731d705b5f6faa7fbb2bb91978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827502Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#700287}
-
Finnur Thorarinsson authored
persistent failures. Bug: 1008275 TBR: nikitapodguzov Change-Id: Ie35e6388214e84095432fa5cadebcc69e53286c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827291Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#700286}
-
Mikel Astiz authored
In the new APIs the notion of readiness (which is more abstract) was replaced by the cryptographer's CanEncrypt() state. This patch addresses a TODO to rename some leftovers from earlier patches, as well as the string in chrome://sync-internals. Bug: 967417 Change-Id: Ia9c24a756c06fa4036dfedf0475b3d8cb5c3f37d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826781 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#700285}
-
Oleg Davydov authored
Before that it used static profile-bases map, which is exactly what KeyedService is about. One more small change to make this possible: ExternalProviderImpl no more accepts and deals with nullptr as a profile. The only place where it was used is one test, which has testing profile now. Bug: 949142 Change-Id: Ice9669be43104c76d71b140d2dfbc65a29fd1368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807252 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#700284}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 01bb204b. With Chromium commits locally applied on WPT: 561a338c "Convert SensorProvider client to use BrowserInterfaceBroker" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools jsbell@chromium.org: external/wpt/resources mkwst@chromium.org, jochen@chromium.org: external/wpt/subresource-integrity NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I2e05e386f3d80d6f9b61acf8daa2f7b40a446f17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827308Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700283}
-
Andrew R. Whalley authored
Also arrange existing reviewers in alphabetical order Change-Id: I628f0a2363b730fb26c7a7cc0afc2bdf3a8faea5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826863 Auto-Submit: Andrew Whalley <awhalley@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#700282}
-
Matthew Denton authored
Change-Id: I92a979d500490786dc0c33d30bc653fa1cee214b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825379 Auto-Submit: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#700281}
-
Tom McKee authored
Before this change, any callback that was waiting for a presentation timestamp would be attached to a layer tree, buffered in the PresentationTimeCallbackBuffer and then posted to the renderer main thread once we actually wanted to run it. This change adds support for registering similar callbacks which expect presentation timestamps but the callbacks are run on the compositor thread instead of being posted back to the main thread. One of the use cases for running callbacks on the compositor thread is to support First Scroll Delay (see referenced bug). First Scroll Delay needs to compute differences between some timestamps which are only available on and relevant to the compositor thread. Bug: 922980 Change-Id: I7683022bcf639808bc3d90eb3068a9e8bacdaf84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823557 Commit-Queue: Tom McKee <tommckee@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#700280}
-
Avery Musbach authored
The bug is caused by faulty logic in IsSnappedInSplitView in the anonymous namespace in browser_non_client_frame_view_ash.cc. This function is supposed to check whether a window is in split view. It actually has the effect of checking whether the window has the same window state as a window in split view. See Issue 1008207 for two workflows that demonstrate how an overview window may have the same window state as a window in split view, meaning the logic is faulty. Workflow 2 even works in tablet mode, but that does not matter because the caption buttons are always hidden in tablet mode anyway. I see no need to add a unit test, because the present CL only removes code, and because a regression seems highly unlikely. Bug: 1008207 Change-Id: Ifc60f53677b4de50458de5d2fbcb4219773dfcea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826008Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#700279}
-
Amr Aboelkher authored
A device policy which controls the dictation accessibility feature on the login screen.The policy can be applied as a recommended or mandatory policy. Test: 1. Set the login_screen_dictation_enabled policy to True, open System Tray => "Accessibility", check that "Dictation" is displayed with a green check in the login screen. 2. Set the policy to False, open System Tray, check that "Dictation" is not displayed in the login screen. Bug: 552439 Change-Id: Iabbdf63f0b6d8a21c02bc25ef8d5295f4a72da30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815119 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#700278}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/38d889b2a677..197c3c97970b Created with: gclient setdep -r src-internal@197c3c97970b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I6650b84d53abb0e2f9a1f615a301a06d0796bacd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827445Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700277}
-
Christopher Grant authored
DFMs that include both Java and native code will probably use JNI. This change introduces a reusable mechanism to load the native library and register its JNI methods. Key points: - There are 3 build variants supported: 1. Production builds with lld-generated partitions. 2. Component build (with feature code in a component). 3. Fallback release build (feature code in the main library) - For consistency, explicit JNI registration is done in both ChromeModern and Monochrome. - The Test Dummy module is moved over to use this new system. VR will join the fun in a follow-on change. - Currently, modules must supply an explicit JNI registration method. Common code will locate this method and call it, at the appropriate time, on behalf of the module. Bug: 870055 Change-Id: Id400ff00b4be65f71536a4acffdfcf93cc3bea58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822846 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#700276}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ef2033ab2793..e545db8d0486 git log ef2033ab2793..e545db8d0486 --date=short --no-merges --format='%ad %ae %s' 2019-09-26 fmayer@google.com Merge "Fix slow pprof_builder." 2019-09-26 fmayer@google.com Merge "Move normalization header lib to include" 2019-09-26 hjd@google.com Merge "perfetto-ui: Add Android async slice tracks" Created with: gclient setdep -r src/third_party/perfetto@e545db8d0486 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I387ca13c6001fc9c923f15fbcaf014b1b43ff0b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827447Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700275}
-
Thomas Tangl authored
- Profile heading "Manage people" -> "People" - Button "Open Guest window" -> "Guest" - Button "Add Person" -> "Add" - Guest icon of "Guest" button is updated - Button "Close all your windows" is removed Bug: 995720 Change-Id: I86dd1dcd14afec5b4e6d7ad911449ca9053d2910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827281Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Auto-Submit: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#700274}
-
Anton Bikineev authored
This change is needed to check canary for existing bugs caused by incorrect algorithm of page header extraction for large pages. To sherrifs: this causes regressions. The commit will be reverted in a few days. Change-Id: I0df59aa055b8783c834cfdf29717d388294fe9bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827364Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#700273}
-
Mia Glaese authored
Previous CL (ttp://crrev.com/c/1792857) caused feedless builder to fail lint checks. Moved ss_feed_header to appropriate place. Bug: 982018 Change-Id: If5b7997973c9d7230287a48aee4bf16490b65ac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822219 Commit-Queue: Mia Glaese <glamia@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#700272}
-
Eric Foo authored
See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: I77f00c39d2f6fc088eee250e3ed6e5b04374478b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808404Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#700271}
-
Fredrik Söderquist authored
Merge these two functions into one - InstanceListChanged - taking the list that changed as an argument. This is preparation for unifying this code-path with the other interval resolving code-path. Bug: 998526 Change-Id: I3727a5dfe76236bac7b6283a48d334426093d2ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827278Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#700270}
-
danakj authored
Only the main frame experiences the web test bits or the emulator, but the non-delegate branch is currently dependant on them, and lives in the else case of both of these. But not having a delegate means they can't be true. Reduce our nesting and variable dependencies. R=avi@chromium.org Bug: 1006052 Change-Id: I430d5ebeaf1777b05f5318c850c45e372cbf55fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825723 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#700269}
-
Matthias Körber authored
Bug: 1007974 Change-Id: I248c8f76fb5f3ade6dfdde8f1c957d3f4708f45a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827404 Commit-Queue: Matthias Körber <koerber@google.com> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#700268}
-