- 13 Aug, 2018 40 commits
-
-
Kyoko Muto authored
As the first step of implementing "Imperative Shadow DOM Distribution API", this CL makes element.attachShadow take an optional parameter, |slotting|, which should be 'manual' or 'auto'. This CL also introduces new Runtime flag, ManualSlotting, to guard the new feature. BUG=869308 Change-Id: I71b115886c07c0090bef16b66da48c88e723a622 Reviewed-on: https://chromium-review.googlesource.com/1166767 Commit-Queue: Kyoko Muto <kymuto@google.com> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#582524}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/62dc9deeea75..8d8a9d7701bd git log 62dc9deeea75..8d8a9d7701bd --date=short --no-merges --format='%ad %ae %s' 2018-08-13 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@8d8a9d7701bd The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I886dcabc2d0d391328bd566aa68c2f50615e1a24 Reviewed-on: https://chromium-review.googlesource.com/1172105Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582523}
-
Makoto Shimazu authored
This reverts commit fe36308d. Reason for revert: OfflinePageBridgeTest.testGetLoadUrlParamsForOpeningMhtmlFileUrl seems failing. This is the only CL relevant to offline pages, so let me revert this speculatively. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=org.chromium.chrome.browser.offlinepages.OfflinePageBridgeTest%23testGetLoadUrlParamsForOpeningMhtmlFileUrl Original change's description: > Report different UMA enums when clicking async download notification > > Currently it is reported as "Download Home". We now add the logic > to separate it out, together with the case that clicking from progress > bar. > > Bug: 869692 > Change-Id: I9f2fcbbac20da9cf23176a00505fe10d04136b2f > Tbr: dgn@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/1157644 > Commit-Queue: Jian Li <jianli@chromium.org> > Reviewed-by: Dmitry Titov <dimich@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Reviewed-by: Min Qin <qinmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581930} TBR=peter@chromium.org,dimich@chromium.org,jianli@chromium.org,qinmin@chromium.org,dgn@chromium.org,holte@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 869692 Change-Id: Ifaee7de7a978f3795a6cf701d4420aa04736b169 Reviewed-on: https://chromium-review.googlesource.com/1172182Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#582522}
-
Koji Ishii authored
This patch rebaselines 2 text failures that look good from a manual review of build 8803, and 5 removal that match to their base expectations. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I0efe930ada47e46163be831d7814c50a132ba195 Reviewed-on: https://chromium-review.googlesource.com/1172231 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#582521}
-
Alexey Baskakov authored
No behavior change. Bug: 860581 Change-Id: I808616a351c2f7912ebab1e6f052e00c10e4107a Reviewed-on: https://chromium-review.googlesource.com/1172171Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#582520}
-
Makoto Shimazu authored
TBR=robertma@chromium.org NOTRY=true Bug: 856601 Change-Id: I8527c9d7c1df382f08620378ac9931634cfdd5aa Reviewed-on: https://chromium-review.googlesource.com/1172226Reviewed-by:
-
Makoto Shimazu authored
TBR=jsbell@chromium.org NOTRY=true Bug: 873570 Change-Id: I1cf6d4ca729e7fdb7c14bf5b5288dc84de408f3c Reviewed-on: https://chromium-review.googlesource.com/1172228Reviewed-by:
-
Ramin Halavati authored
Preferences related to Rapor are moved to the incognito persistent storage list. This CL does not change the current behavior. Bug: 861722 Change-Id: Ie2212b845d2ce9a73d60a7fc24ae480b29b56420 Reviewed-on: https://chromium-review.googlesource.com/1166829 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#582517}
-
Makoto Shimazu authored
Tbr: andruud@chromium.org No-Try: true Bug: 873454 Change-Id: I713c5266cd9eb12cf49cfe8b952e709f47070ca9 Reviewed-on: https://chromium-review.googlesource.com/1172181Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#582516}
-
Yoichi Osato authored
This patch makes the function to only receive |const Text&| rather than |Text*| as other MarkersXXX functions. Bug: 868229 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I547e35fe6f95d959759b7042cebf81e27aad9d96 Reviewed-on: https://chromium-review.googlesource.com/1168948Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#582515}
-
Ramin Halavati authored
Tests are added to Extensions Tabs API to ensure extensions cannot create or query the tabs in incognito mode when they are not enabled to run there. Bug: 862075 Change-Id: I6081b4cc432c82d147a65f30311af0708efe03f9 Reviewed-on: https://chromium-review.googlesource.com/1158368 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#582514}
-
Giovanni Ortuño Urquidi authored
Changes BookmarkAppHelper, CrxInstaller, and ConvertWebAppToExtension so that clients can set the manifest location and extra install flags that will be used when creating the extension. Bug: 852244 Change-Id: I59077e015dc80d9461218f3722942e58e9bc5281 Reviewed-on: https://chromium-review.googlesource.com/1170152Reviewed-by:
-
Adam Rice authored
Design doc https://docs.google.com/document/d/17goe4jacAYjHHtprfVPSrqDvF_J58u2qirz0HQ58sQ4/edit Implement the C++ classes TransformStream and TransformStreamDefaultController. These provide thin wrappers for the equivalent JavaScript classes. Modify the JavaScript TransformStream implementation to pass the |controller| argument to the algorithms. This is a departure from the standard, but the difference is not observable to user code. It makes the memory management considerably simpler as no C++ reference to the TransformStreamDefaultController needs to be retained between calls. Define the interface TransformStreamTransformer. Also create unit tests for these new classes. Bug: 845427 Change-Id: I067a8ff15daaa4912760fbdb9ca4697705f2e3f8 Reviewed-on: https://chromium-review.googlesource.com/1156324Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#582512}
-
Ryan Sleevi authored
MCSProbe was refactored in r567674 to use Mojo, rather than interacting directly with //net APIs. However, as part of the refactor, many of the objects used to initialize the HttpNetworkSession became unused in the Mojo URLRequestContext. This restores the intended behaviour - namely, that the command-line can control whether a NetLog is generated, as well as whether certificate errors are ignored. In the process of cleaning up this code, it was the last remaining caller of ProxyResolutionService::CreateDirectWithNetLog(). However, because it was always using DIRECT, supplying the NetLog was unnecessary, and CreateDirect() works just as well. Fix the call site and remove the (now dead) ProxyResolutionService API. Bug: none Change-Id: I126b60db94c4f486eed9bfd2af3ba2971e34a4fd Reviewed-on: https://chromium-review.googlesource.com/1169826 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Cr-Commit-Position: refs/heads/master@{#582511}
-
Pin-chih Lin authored
Currently on VideoEncodeAccelerator::Initialize() deafult framerate is always used to initialize encoder. As we have profile and level of H.264 encoding in initial Config, framerate should be also adjustable on initialization for the client to configure a supportable parameter set under the limit of of profile/level. BUG=871154 TEST=build and deploy chrome on eve TEST=build and run video_encoder_accelerator_unittest on eve Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ifd6e33ada82d44c0e1b46f56856caeec9600e139 Reviewed-on: https://chromium-review.googlesource.com/1163592Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Pin-chih Lin <johnylin@chromium.org> Cr-Commit-Position: refs/heads/master@{#582510}
-
Kouhei Ueno authored
This is a speculative fix for crash reported on crbug.com/872672 . There is no guarantee that the DocumentLoader is always attached [1], so let's introduce a null check. [1] The DocumentLoader may be detached while FrameLoader::PrepareForCommit. Bug: 872672 Change-Id: I015651506a891c3344f1bdbf40ea013ce988a95f Reviewed-on: https://chromium-review.googlesource.com/1171972Reviewed-by:
-
Ramin Halavati authored
Preferences related to UKM are moved to the persistent storage list for incognito mode. This CL does not change any current behaviore. Bug: 861722 Change-Id: I80e3ab0ef4326e7e6105649c3fe376be1755c755 Reviewed-on: https://chromium-review.googlesource.com/1166826Reviewed-by:
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I098426b763ce553d7a23e4665951dcbb709ef760 Reviewed-on: https://chromium-review.googlesource.com/1172153Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582507}
-
Ryo Hashimoto authored
Removing the timeout to have one less sources of flakiness. BUG=872732 TEST=dbus_unittests Change-Id: I7ca390a19a77686df268332850e3951e6d13d3d1 Reviewed-on: https://chromium-review.googlesource.com/1170719 Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Satoru Takabayashi <satorux@chromium.org> Cr-Commit-Position: refs/heads/master@{#582506}
-
Matt Falkenhagen authored
The test no longer flakes since the bug was fixed. Bug: 862294 Change-Id: I4802c3a5d09ea487459a93726a841ae4dd7c437a Reviewed-on: https://chromium-review.googlesource.com/1172168Reviewed-by:
-
Ehsan Karamad authored
MimeHandlerViewContainer implements the renderer side of logic for embedding the MimeHandlerView extension. The logic is currently based on a GuestViewContainer which internally uses a WebPlugin (BrowserPlugin). MimeHandlerView will eventually get implemented on top of cross-process frames architecture; requiring its owner container class on the embedder side. This CL will extract the common code between the current BrowserPlugin version and the forthcoming frame-based version into a base class so that the similar code between the two containers is not duplicated. The common code includes a) logic in creating MimeHandlerViewGuest, b) support for network service and c) support for post message. Bug: 659750 Change-Id: Iabe44b1438fc22aa052b1ebf6d8696bdca00d0c9 Reviewed-on: https://chromium-review.googlesource.com/1170564Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#582504}
-
Koji Ishii authored
Following bot results are included. 8762 8763 8764 8766 8775 8780 8783 8784 8785 8786 8787 8791 8792 8793 8794 8796 0 lines were removed and 7 lines were deflaked by consecutive results since 8775. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Iacb8621bd123235f6347897915d2317093d10c06 Reviewed-on: https://chromium-review.googlesource.com/1170444 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
John Abd-El-Malek authored
Bug: 819663 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I5a79280401e460954a53de4db529061c3f9bae49 Reviewed-on: https://chromium-review.googlesource.com/1171257 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
-
Emil A Eklund authored
Computing whether an inline block spans multiple lines is more expensive than expected thus causing a small paint performance regression for both legacy layout and LayoutNG. This patch moves the computation to use-time thereby avoiding it when cached drawings are used or paint isn't needed. Bug: 714962 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I97380b2e304c3c3293514ecf118fffdf6f9b9292 Reviewed-on: https://chromium-review.googlesource.com/1170310Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#582501}
-
Makoto Shimazu authored
TBR=yosin@chromium.org NOTRY=true Bug: 873547 Change-Id: Ife2840825a7e24a6757da817806d35bd80cbd95c Reviewed-on: https://chromium-review.googlesource.com/1172166Reviewed-by:
-
James Cook authored
There's no separate "classic" mode in ash anymore. Collapse the superclass with its only subclass. Just cleanup, no functional changes. Bug: 873266 Test: ash_unittests Change-Id: I70cdf56a8cb534cc5f5f1385ef5d702d3694b5a5 Reviewed-on: https://chromium-review.googlesource.com/1171821Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#582499}
-
James Cook authored
There's no separate "classic" mode in ash anymore. Collapse the superclass with its only subclass. Just cleanup, no functional changes. Bug: 873267 Test: ash_unittests Change-Id: I8d4243ad50d66ac7982dbe12132a736903271f63 Reviewed-on: https://chromium-review.googlesource.com/1171807Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ia13ff3b9446189cc75d29f17f16435c0dcb3cf24 Reviewed-on: https://chromium-review.googlesource.com/1171997Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#582497}
-
Trent Apted authored
This one was straightforward. The deleted .html harness had a mock for ContentMetadataProvider and some chrome.* stuff. However it appears to be unnecessary: neither the test, nor dimmable_ui_controller.js itself use these. Bug: 867700 Change-Id: Iec0bbe7d7126e7dcf8eaffe5f189c0655e6a2e74 Reviewed-on: https://chromium-review.googlesource.com/1171971 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#582496}
-
Yuki Yamada authored
This CL renames V8EventListener to V8EventListenerOrEventHandler in order to use callback interface EventListener generated by event_listener.idl: https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/dom/events/event_listener.idl?type=cs&q=%22callback+interface+EventListener%22&sq=package:chromium&g=0&l=23 https://dom.spec.whatwg.org/#interface-eventtarget The generated class will be named as "V8EventListener", so we have to rename current V8EventListener. Bug: 872138 Change-Id: Iceaf2e0ccbfb0f0b4be38381b14d79c63d0982af Reviewed-on: https://chromium-review.googlesource.com/1170670Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Yamada <yukiy@google.com> Cr-Commit-Position: refs/heads/master@{#582495}
-
Trent Apted authored
The file itself already compiles, but when we audit the dependency tree, we find a bunch of hidden dependencies between externs files. To fix, move these externs to the volume_manager_wrapper target and update all modules already depending on the wrapper already to get these externs via that target instead of repeating them redundantly. Some modules depend on (e.g.) the volume_info.js extern but don't already have a dependency on volume_manager_wrapper. This CL doesn't add one for those, but they may need updating later. Bug: 867700 Change-Id: I4e4e5b3c9fb6f59af5f06fa945c34c58832f8fe4 Reviewed-on: https://chromium-review.googlesource.com/1171970Reviewed-by:
-
Makoto Shimazu authored
TBR=peter@chromium.org NOTRY=true Bug: 873540 Change-Id: I988b931a5c15ba946e2cbec30b9c1557c862ee58 Reviewed-on: https://chromium-review.googlesource.com/1171974Reviewed-by:
-
Kenneth Russell authored
This test became unacceptably flaky with the upgrade to 10.13.6. Tbr: ynovikov@chromium.org Bug: 872423 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I8fded8d47792dce57ea6da6532f7d42b5c075bd4 Reviewed-on: https://chromium-review.googlesource.com/1172148Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#582492}
-
Alexey Baskakov authored
Extract all the low-level skia/gfx/color_util stuff as ResizeIconsAndGenerateMissing function. This is a cut-and-paste CL, no behavior changes. Notes: - WebApplicationInfo::IconInfo becomes IconInfo. TODO for next CL: Merge IconInfo and BitmapAndSource - they are essentially the same. - BookmarkAppHelperExtensionServiceTest.LinkedAppIconsAreNotChanged test was always broken (a bug in ValidateAllIconsWithURLsArePresent helper) https://codereview.chromium.org/1066623008/patch/80001/90005 This is a re-land of: https://chromium-review.googlesource.com/c/chromium/src/+/1166751 MSan issue solved, ouput parameters initialized everywhere: SkColor generated_icon_color = SK_ColorTRANSPARENT; TBR=ortuno@chromium.org Bug: 860581 Change-Id: Ib26c765083e67e3a1c938a49994a5f5d5ecc8265 Reviewed-on: https://chromium-review.googlesource.com/1170665 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
-
Tetsui Ohkubo authored
On Chrome OS, there's no way to access notifier settings bubble from outside MessageCenterView, as right click menu is removed and inline settings is introduced. Therefore, they are dead code right now. BUG=802997 Change-Id: If498fa9b8949975d4c7c06a38667798b7124fc12 Reviewed-on: https://chromium-review.googlesource.com/1168268Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#582490}
-
Han Leon authored
This CL is the 4th step of the plan below aiming to eliminate the native struct content::ServiceWorkerResponse defined in content/common/service_worker/service_worker_types.h. 1st step: https://chromium-review.googlesource.com/c/chromium/src/+/1134731 2nd step: https://chromium-review.googlesource.com/c/chromium/src/+/1149706 3rd step: https://chromium-review.googlesource.com/c/chromium/src/+/1155999 4th step: (this CL) - Use blink.mojom.FetchAPIResponse to represent responses to background fetches. Specifically, use this mojom struct to replace the existing [Native] mojom struct content.mojom.ServiceWorkerResponse defined in content/common/service_worker/service_worker.mojom. Thus we can reduce the last 1 user of content::ServiceWorkerResponse. 5th step: - Remove content::ServiceWorkerResponse and do any left cleanup. BUG=789854 Change-Id: I85e6e9489dac50e1cc6905bd28a2d47b7a90fde7 Reviewed-on: https://chromium-review.googlesource.com/1164848Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#582489}
-
Makoto Shimazu authored
This is continuously fails on Android CFI. TBR=nyquist@chromium.org NOTRY=true Bug: 845180 Change-Id: I6829cc75cdd71eee0891838477a57c14c478e27b Reviewed-on: https://chromium-review.googlesource.com/1171973Reviewed-by:
-
Zhuoyu Qian authored
As the comment in login_user_view.h by jdufault@, rename user_dropdown_ to dropdown_. Signed-off-by:
Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: Id490ce8cb0a899da78d6fbab1cd2bfacd6169227 Reviewed-on: https://chromium-review.googlesource.com/1170157Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#582487}
-
Tetsui Ohkubo authored
Previously, settings button for volume slider was hidden when volume slider was shown as a single row bubble, not in a main bubble. This CL changes the settings button to be always shown. When the button is clicked in the slider bubble, it will open the main bubble. TEST=manual BUG=870473 Change-Id: Icc5b3d528414ee49ce6f0ffb4f4d47c0ce69c9ec Reviewed-on: https://chromium-review.googlesource.com/1170667 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
-
Tetsui Ohkubo authored
This CL implements a counter view at the top of UnifiedSystemTray that shows number of notifications hidden by scrolling. Screenshot: http://screen/LK1ETwVGn2d BUG=863635 Change-Id: I4cc16ec8f7e5f1f0b64836b1217655a52ca9882e Reviewed-on: https://chromium-review.googlesource.com/1168945Reviewed-by:
-
