GitLab

Notify the request failure of the current form to Java.
Also add test for the failure case.

Bug: 1151542
Change-Id: I3c6f9f5f4e2d118b887ce667c92ca7743ffdd826
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591911
Commit-Queue: Michael Bai <michaelbai@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837783}

Also change GFX_EXPORT to COMPONENT_EXPORT(x11).

R=sky

Bug: None
Change-Id: Ie1c81bbef832dd747e7601f70d593b46fe47061e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595524
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837782}

"compile" appears as part of the name of some tests, so using it as a
regex for tree closing is overly broad. This may still catch some
unwanted failures but should narrow the false closures.

Bug: 1159548
Change-Id: Ib19a6d5aad3818fe22430cb88007cb38f70c2615
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595973Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837781}

media_control has been working reliably on Fuchsia for some time. The
extra logging provides little benefits at this point.

Change-Id: I50ac840fc96fa95237e970af87c5400bbff7d26d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595972
Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Sharon Yang <yangsharon@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Commit-Queue: Yuchen Liu <yucliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837780}

When we are not applying site-isolation a DelegatedFrameHost can be 
re-used when navigating between different pages. This can occur on 
Android as well as with the un-supported flag
--disable-site-isolation-trials.

When RenderWidgetHostImpl::ForceFirstFrameAfterNavigationTimeout is 
invoked, as either from tab-changing, or from thumbnailing, we set 
fallback surfaces. This is intended to be the first viz::SurfaceId that 
was generated by navigation.

However if a navigation fails we don't actually embed a new surface. The
DelegatedFrameHost then ends up utilizing outdated surfaces as the 
fallback.

This change updates DelegatedFrameHost to be notified of when a 
navigation begins. If we fail to embed a new surface by the timeout, 
we evict the surface that predates the navigation.

The ThumbnailTabHelper has been updated to also clear its currently 
cached thumbnail in the case that the page has transitioned back to the
unready state. Thus clearing thumbnails that exist from before a 
navigation.

TEST=NoCompositingRenderWidgetHostViewBrowserTest.
         NoFallbackAfterHiddenNavigationFails

Bug: 1152894
Change-Id: Ia5734abb5201a56c271114a891bc81212a3aa975
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585790Reviewed-by: Dana Fried <dfried@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Collin Baker <collinbaker@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837779}

Some dependencies must also be moved to //ui/gfx/x
* XWindowEventManager is used by PropertyCache
* Parts of //ui/base/x/x11_util are used by PropertyCacheTest

BUG=739898
R=sky

Change-Id: I560be78262263b2c0fbe61d2f77a03305d44f454
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596108Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837778}

https://boringssl.googlesource.com/boringssl/+log/df75139becd7355e117c9860452265b898b49376..ca058c06474c4492f0fbd517679793234dde6165

Bug: none
Change-Id: I798ae79013c403802127ca077ae091487387e5ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595613
Commit-Queue: David Benjamin <davidben@chromium.org>
Commit-Queue: Adam Langley <agl@chromium.org>
Auto-Submit: David Benjamin <davidben@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837777}

Bug: 1152282
Change-Id: I9feb70e2ff921a1dc6d3c0a7b6ac41885ee9758d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595599Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837776}

https://chromium.googlesource.com/external/github.com/google/snappy.git/+log/f16eda346663..ea368c2f07de

This CL also regenerates config.h.

$ git log f16eda346..ea368c2f0 --date=short --no-merges --format='%ad %ae %s'
2020-12-16 costan Add AppVeyor status badge.
2020-12-16 costan Remove unused include in snappy_benchmark.cc.
2020-12-16 costan Split benchmarks and test tools into separate targets.
2020-12-16 costan Test stub improvements.
2020-12-15 cmumford Disable fuzzing on OSX.
2020-12-15 costan Fixup for adding the third_party/{benchmark, googletest} submodules. (#115)
2020-12-15 cmumford Fixed endif clause.
2020-12-15 cmumford Matching clang.
2020-12-15 cmumford Building with `-Werror` only with clang.
2020-12-15 cmumford Fix CHECK_EQ to call ok() instead of CheckSuccess().
2020-12-15 costan Fixup for adding the third_party/{benchmark, googletest} submodules. (#111)
2020-12-15 costan Rework file:: stubs.
2020-12-15 costan Wrap snappy_unittest in an anonymous namespace and remove static from functions.
2020-12-14 costan Fixup for adding the third_party/{benchmark, googletest} submodules. (#110)
2020-12-15 costan Fix unused local variable warnings.
2020-12-14 costan Remove custom testing and benchmarking code.
2020-12-14 cmumford Add Travis-CI build status badge to README.md.
2020-12-14 costan Update Travis CI config.
2020-12-14 costan Replace #pragma nounroll with equivalent used elsewhere.
2020-12-14 costan Remove inline qualifier from static variables.
2020-12-10 no-reply 1) Improve the lookup table data to require less instructions to extract the necessary data. We now store len - offset in a signed int16, this happens to remove masking offset in the calculations and the calculations that need to be done precisely give the flags that we need for testing correctness. 2) Replace offset extraction with a lookup mask. This is less uops and is needed because we need to special case type 3 to always return 0 as to properly trigger the fallback. 3) Unroll the loop twice, this removes some loop-condition checks AND it improves the generated assembly. The loop variables tend to end up in a different register requiring mov's having two consecutive copies allows the elision of the mov's.
2020-12-09 nafi Optimize zippy decompression by making IncrementalCopy faster.
2020-12-03 no-reply Internal change
2020-12-03 nafi Optimize zippy decompression by making IncrementalCopy faster.
2020-11-19 no-reply Fix opensource version
2020-11-18 no-reply Add LZ4 as a benchmark option. Snappy is starting to look really good compared to LZ4. LZ4 is considered the fastest solution by many on internet. We now see that Snappy is actually becoming very competitive with compression a little faster and decompression slower but certainly not terribly slower.
2020-11-16 no-reply Extend validate benchmarks over all types and also add a medley for validation.
2020-11-14 no-reply Bug fix. Error on 0 offset copies.
2020-11-14 no-reply Make zippy decompression branchless
2020-11-13 no-reply Revert zippy optimization that causes heap buffer overflows.
2020-11-13 nafi Optimize zippy unzipping by upto >10% by making IncrementalCopy faster.
2020-11-13 no-reply Add a benchmark that decreased the branch prediction memorization by increasing the amount of independent branches executed per benchmark iteration.
2020-11-09 veluca Change hash function for Compress.
2020-11-02 no-reply Fix the use of op + len when op is nullptr and len is non-zero. See https://reviews.llvm.org/D67122 for some discussion of why this can matter. I don't think this should have any noticeable effect on performance.
2020-10-30 veluca Run clang-format
2020-10-29 jan fix compile warnings due to missing override specifiers
2020-07-15 ckennelly Replace ARCH_K8 with __x86_64__.
2020-07-10 no-reply Replace the division with a constant table in IncrementalCopy

Created with:
  roll-dep src/third_party/snappy/src

Change-Id: Ica5844c3799c3ccf6c814602ce03514b43f5cd16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596010
Auto-Submit: Victor Costan <pwnall@chromium.org>
Reviewed-by: Chris Mumford <cmumford@google.com>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837775}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll
Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com
Change-Id: I557476c1e3a89e62b02af3a64efbd77e6dbdb35a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595694Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#837774}

This CL adds a couple of hooks for the OSIntegrationManager to call
into the upcoming implementation of the ProtocolHandlerManager. There
should be no observable difference in behavior with this CL.

Bug: 1019239
Change-Id: I88455e0dd868d0b8944de231dd2cbf5f1a89516a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577769
Commit-Queue: Fabio Rocha <fabio.rocha@microsoft.com>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837773}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2d976f379ec5..8a5112747ff0

2020-12-16 cpinnamaneni@microsoft.com adding image and icon support for markdownview.ts

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1154783
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I167e0b02fb898b6750279d6d65093f6b3e0b150a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595495Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#837772}

Update minimum version of NavigationCallback.LargestContentfulPaint now that it's been merged to M88.

Bug: 1156663
Change-Id: I7ce80e2c5312c411bf362868083ea47cf69132bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595922
Auto-Submit: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837771}

https://dawn.googlesource.com/dawn.git/+log/455dbfdd428f..307ece163070

2020-12-16 bclayton@google.com end2end: Enable textureLoad() tint tests

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC rharrison@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: rharrison@google.com
Change-Id: I45c9ba9aeacfeb48054046b644e1912014350c64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595703Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#837770}

MetricsRenderFrameObserver currently only trigger sending of metrics:
- When RenderFrame is destroyed, from its destructor.
- When RenderFrame is detached, from WillDetach().
- When a navigation commits in a RenderFrame, from ReadyToCommitNavigation().

This doesn't work with cross-RenderFrame navigations as the third case
doesn't happen, and the first two case will be too late as the current
RFH in the browser would've changed to the new RFH already by the time
the renderer's metrics update arrive in the browser, and we ignore
metrics update from non-current RFHs.

This CL adds two new triggers for sending metrics:
- ReadyToStartNavigation, which will be fired for renderer-initiated
navigations
- DidSetPageLifecycleState, a new RenderFrameObserver method which will
be fired on page lifecycle updates, including pagehide-in-commit that
happens before the browser updates the current RFH to the new RFH on
same-site cross-RenderFrame navigations that reuses the same process.
See doc: https://docs.google.com/document/d/1RXGDkrSWTfaeio76joXKWBLGDHAbiB48sHUdcTX6rdc/edit#heading=h.476deggm397n

See also linked bug for more details.

Bug: 1150242
Change-Id: I22e5016f71a39d2420b38bfb1b406ba4845d54bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592288Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837769}

This reverts commit 8451c986.

Reason for revert: Test is still flaky

Original change's description:
> Extend the time waiting for FirstRunIntegration completes
>
> DeferredStartupHandler.waitForDeferredStartupCompleteForTesting were
> timing out with previous timeout. ChromeActivityTestRule was working
> properly because this call was called when NTP is fully loaded, which
> the flaky test case did not. Thus increase the time out to deflake.
>
> Bug: 1157611
> Change-Id: I4587c151659000c8962b40b74b4bc3575ec0e6cd
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590550
> Commit-Queue: Wenyu Fu <wenyufu@chromium.org>
> Reviewed-by: Sky Malice <skym@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#837207}

TBR=skym@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,wenyufu@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1157611
Change-Id: Ic6630f4476b1231573d56f7d8c8f1fe7f3eba21d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596316Reviewed-by: Wenyu Fu <wenyufu@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Wenyu Fu <wenyufu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837768}

This CL changes GetAppProtocolHandlerInfos to be virtual and adds
web_app_protocol_handler_manager. This mimics the design of other
components and avoids a layer of indirection between web_applications
and web_applications/components.

Bug: 1019239
Change-Id: Ibf9abbe66a4bf1addb13955040889b740cf578bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577888
Commit-Queue: Fabio Rocha <fabio.rocha@microsoft.com>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837767}

Add the AutofillHintsService related aidls.

Bug: 1151542
Change-Id: Ic1c2c21c78a6305706613a7eb8e0693c608a6054
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592330
Commit-Queue: Michael Bai <michaelbai@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837766}

https://chromium.googlesource.com/openscreen.git/+log/958f1e8ca769..91beff4e632a

2020-12-16 vigeni@google.com Internal change

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/openscreen-chromium
Please CC jophba@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jophba@chromium.org
Change-Id: I3369745a53dba5177cfb951514fe9f20bf4ced00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595702Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#837765}

1. Add a ShopWithGoogleLensChip metric to ukm.xml
- go/ukm-collection-review-lens-chrome

2. Fix the merging logic for onClick callbacks.

3. Remove an unused field from LensQueryParams.

4. Fix direct intent enablement check in LensUtils.

5. Update the Classification UMA histogram to show EarlyTerminatedMs and SuccessOnQueryResultMs data.

6. Add a label to the ResultState UMA histogram to show a newly added enum value.

7. Update the ResultState UMA histogram labels for 'not shoppy image' cases.

Change-Id: Id00133ceb9039fb479dfa646570fe38c1a0bece3
Bug: b/166648354
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586221Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Sinan Sahin <sinansahin@google.com>
Reviewed-by: Ben Goldberger <benwgold@google.com>
Commit-Queue: Yu Su <yusuyoutube@google.com>
Cr-Commit-Position: refs/heads/master@{#837764}

The feature it's meant to help evaluate hasn't been enabled on
pre-release channels yet, let alone on stable, so we'll need it around
a fair bit longer than its original expiration date. We're planning on
enabling the feature on pre-release channels in January, after the
field trial freeze ends.

Bug: 969893
Change-Id: Iee2d0238978050cfb2f108693a6f571758052e3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596127Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837763}

This patch moves selection functions that are not related with
|NGPaintFragment| to |NGInlineCursor|, in preparation of
removing |ng_paint_fragment.cc|.

Bug: 1154531
Change-Id: I6c1849ab443b04ac6c7c608c800b568a69d3b7bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595748
Auto-Submit: Koji Ishii <kojii@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837762}

I plan on continuing the rollout of this in 2021, really.

BUG=930812

Change-Id: I8e7f3128ec143439428fda340a58bec151204ce1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595920
Commit-Queue: Adam Langley <agl@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Auto-Submit: Adam Langley <agl@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837761}

It was very hot at least for crbug.com/1154746, taking about 30% of the
frame CPU time. By inlining it and checking HasDisplayLockContext,
the function disappeared from the CPU profiling result.

Checking HasRareData() is not enough because most elements in test case
have rare data due to Element::classList().

Bug: 1154746
Change-Id: I2cff6567d081e559190c052b4176dae53e1fd9ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594431
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837760}

Migrate uses of the relevant set_* functions on the sql::Database object
to use the new DatabaseOptions constructor instead.

This change should have no intended behavioral effect.

Bug: 1126968
Change-Id: I03f0317eba59b68463a753fcd9c10f3dc4a19525
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594116
Commit-Queue: Shubham Aggarwal <shuagga@microsoft.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837759}

This also removes all blink core owners from the email list.

Change-Id: If38edec90c3ca9214e02ef78da714545dce8ca5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595520
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Ionel Popescu <iopopesc@microsoft.com>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837758}

For the purposes of testing on WebID-supporting IdP services running on
private infrastructure, this adds cookies to the requests to
/.well-known/webid.

Bug: 1159177
Change-Id: I507c461bc8d87d91f8d8d8d25565e1402b053999
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593696Reviewed-by: Sam Goto <goto@chromium.org>
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837757}

When we are inside the reading list folder, the empty view string is
changed to a reading list specific string.

The search string doesn't change.

Bug: 1148877
Change-Id: I521c988f5a2eda7744feb41d05cac0fe4cee9a17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595918Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837756}

This used to fail a DCHECK when nested multicol was specified on a
fieldset at an outer fragmentainer boundary, but apart from that, it
worked fine, because BreakBeforeChildIfNeeded() correctly detects the
situation (abortion) and inserts a break before. Just move the DCHECK a
bit down.

No code changes are required for legends, as they are monolithic. Just
replace the TODO with a proper comment, and keep the DCHECK (the legend
test also passes without the code changes in this CL).

Bug: 829028
Change-Id: I62bf97f9bd04c185f86e93103f204cc6d872c438
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595288Reviewed-by: Alison Maher <almaher@microsoft.com>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837755}

Because paths are case-insensitive on Windows, the DM server
normalizes profile paths to lower-case when they are reported.
This breaks the Clear Browsing Data remote command because it uses
that path to find the profile into which it'll clear the data.

This CL makes it so the path is compared in a case-insensitive manner
on Windows in order to find the correct profile.

Bug: 1159450
Change-Id: I07ebb206049ee848e1aae9e2059c3c69a4b367d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595728
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837754}

https://chromium.googlesource.com/catapult.git/+log/f600415e9265..92c77100518e

2020-12-16 bsheedy@chromium.org Revert "Reland "Switch to vpython version of mock""

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC skyostil@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1156832
Tbr: skyostil@google.com
Change-Id: Id7edbfdaf1b1bea09833490858e7bd3a00842328
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595696Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#837753}

The RemoteCommand logic will not be supported server-side in the near
future so I'm removing it from M89.  I don't think we can remove it
from the protos or we will break back compat so for now the host
will just log an error message if it receives a remote command.

Change-Id: Ieee15b0d225f645dff40b297f6fc3cce5f887f4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596109Reviewed-by: Yuwei Huang <yuweih@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837752}

This change loads the model from the file provided by the Opt Guide and
returns it via callback to any requestor of the model.

A future change will provide the model to the content translate driver
and the translate agent via mojo.

Bug: 1151406
Change-Id: If09871f3ad04a674d964a467586cfb0f24fd4708
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593589Reviewed-by: Trevor  Perrier <perrier@chromium.org>
Reviewed-by: Scott Little <sclittle@chromium.org>
Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Commit-Queue: Michael Crouse <mcrouse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837751}

Figured this would be a useful API extension while refactoring.

Bug: b/175360169
Change-Id: If6490aefacdb5110d3fe5dc423d311e6f7618c12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584434
Commit-Queue: Nic Hollingum <hollingum@google.com>
Reviewed-by: Daniel Ng <danielng@google.com>
Cr-Commit-Position: refs/heads/master@{#837750}

TBR=govind@chromium.org

Change-Id: Id349b468a1136388693ddf52ec5b78a7acb89a13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596128Reviewed-by: Ben Mason <benmason@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837749}

In particular, add DCHECKs when an empty NIK is passed when sending a
report, or when verifying a signed exchange's cert (which can send a
report of another type). The DCHECK is only enabled when
require_network_isolation_key is set. Actually respecting the received
NIK is disabled by default, but all consumers outside the network
service should now always be passing a non-empty NIK when using these
APIs.

Bug: 993805, 1087091
Change-Id: I5f4eef6f9f7b3b4faaaedca62e110e695ccabf2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595630Reviewed-by: Lily Chen <chlily@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837748}

This CL disabled the following tests on Android.

* SingleClientTypedUrlsSyncTest.DeleteNonTyped
* SingleClientTypedUrlsSyncTest.TwoVisits
* SingleClientTypedUrlsSyncTest.DeleteTyped
* SingleClientTypedUrlsSyncTest.Sanity

TBR=mastiz@chromium.org

Bug: 1159479
Change-Id: I49a93df85f6e48bbd661e77e41c467787c4e8b68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596119Reviewed-by: Salvador Guerrero <salg@google.com>
Commit-Queue: Salvador Guerrero <salg@google.com>
Cr-Commit-Position: refs/heads/master@{#837747}

This CL
* Adds a CartHandler mojo interface that will be used to provide info
  needed to render chrome cart module.
* Adds the basic HTML and JS code to render the skeleton of the cart
  module. More details will be added in later patches.
* Adds a dummy implementation of CartHandler that will later be hooked
  with cart backend infra to get real data.

Screenshot with fake data: https://drive.google.com/file/d/1WtYz9aEj0PKhiqn-eZupREv5WfQ0MA-7/view?usp=sharing&resourcekey=0-g9LEGFm9bLfl5HAtro0oUw

Bug: 1157892
Change-Id: Ic8dc20f4be347c97ff99d44717408ce5f182b765
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587099Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837746}

Vulkan memory usage has spikes as a result of caches not
taking the full lifetime of GPU resources into account.

This introduces two limits for Vulkan memory to
mitigate the problem:

--vulkan-sync-cpu-memory-limit-mb - Triggers synchronization
with the CPU in order to allow unused resources to be
freed immediately.

--vulkan-heap-memory-limit-mb - Makes Vulkan allocations
fail.

These two limits provide an effective way to reduce the
harm of the problem. The soft limit affects GPU work
submission and trade performance for reducing spikes as
early as possible without causing a severe impact on
the user experience. The hard limit is immediate and
prevent spikes from causing greater harm to the rest of
the system.

No change in behavior unless new command line flags
are used.

Bug: 1158000
Change-Id: I8e990d71aac780426b0398510c147af295c54f89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587431Reviewed-by: Peng Huang <penghuang@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837745}

Change-Id: Iafa21bda8d69d50dd5f78667ab6d21c616748fd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595514Reviewed-by: Carlos IL <carlosil@chromium.org>
Commit-Queue: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837744}