- 25 Jul, 2018 40 commits
-
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/42c1c03334c7..b284280be4cc git log 42c1c03334c7..b284280be4cc --date=short --no-merges --format='%ad %ae %s' 2018-07-25 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 096c5296c3b0..2160821e16db (1 commits) 2018-07-25 mtklein@chromium.org temporarily disable t8888 config on *SAN bots 2018-07-25 benjaminwagner@google.com Revert "Blacklist hanging test." Created with: gclient setdep -r src/third_party/skia@b284280be4cc The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I0b95381d5167f1c034b7c481cb00ac567652dabb Reviewed-on: https://chromium-review.googlesource.com/1150049Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577937}
-
Steven Bennetts authored
Currently calls to FindPolicyByGuidAndProfile produce an error when called with an empty profile path. There are several places where this can occur, but we recently added one to the system tray UI: https://chromium-review.googlesource.com/c/chromium/src/+/1101204/12/ash/system/network/network_list.cc#813 Rather than ensure that we test for an empty profile path everywhere (which just indicates a non favorite/saved network), just return nullptr with no error when the path is empty. Bug: None Change-Id: I692babc10ae2472e8fa5dbfef1c8be170cc841b2 Reviewed-on: https://chromium-review.googlesource.com/1149096Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#577936}
-
Joshua Peraza authored
ChildProcessCrashObserver.java serves a similar purpose as CrashDumpManager.java did (which it will replace), except without the need (or ability) to check for a minidump on the filesystem. Instead of a minidump path, the process ID of the crashed child is passed to the callback which it can use to identify the correct crash dump. Bug: crashpad:30 Change-Id: I718e653acfa35b14ebaa17d0e8c76804f9856dfb Reviewed-on: https://chromium-review.googlesource.com/1150202Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#577935}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e095b819400f..e71d1bb7fc22 git log e095b819400f..e71d1bb7fc22 --date=short --no-merges --format='%ad %ae %s' 2018-07-25 nisse@webrtc.org Delete obsolete file api/videosourceinterface.h. 2018-07-25 titovartem@webrtc.org Move g722 to proper third_party directory Created with: gclient setdep -r src/third_party/webrtc@e71d1bb7fc22 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I08c055b641e6c5040002b2ff1ff3c2e9730d59d9 Reviewed-on: https://chromium-review.googlesource.com/1150047Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577934}
-
tzik authored
NestedSubscription is a ref-counted object, and its first reference used to be made by base::BindOnce in its constructor. The reference is passed to another thread, and released when the callback instance is destroyed. However, if the PostTask failed or the posted task ran soon before the constructor finished to construct the NestedSubscription instance, the ref count is decremented to 0, and `new NestedSubscription` may return a stale pointer. This CL adds a static constructor to avoid that by splitting the ref-count related set up out of the constructor. Bug: 866456 Change-Id: Idf03b31b95b4a7ddee81fdebff78a594e52a62f8 Reviewed-on: https://chromium-review.googlesource.com/1149762Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#577933}
-
Chris Lu authored
In some languages, the translation is too long for the bottom toolbar to fit it and the "edit" button without truncating. Since we have little control over BarButtonItems, we should cap the length at 16em to allow for both to be readable. Bug: 841289 Change-Id: I19e76002baac55c2ed3099e54dfb504862662597 Reviewed-on: https://chromium-review.googlesource.com/1148996Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#577932}
-
Paul Jensen authored
Some methods like HttpURLConnection.getHeader() hide IOExceptions, but later calls to getResponseCode() would then throw unexpected IllegalStateExceptions. Instead getResponseCode() should rethrow the previously hidden IOException. Bug: 866911 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: Icc533d4a69875af5570a6f793463754d1bf477ab Reviewed-on: https://chromium-review.googlesource.com/1148475Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#577931}
-
Bo Liu authored
CrashMetricsReporter::CrashDumpProcessed can be called multiple times for the same process; see the comment in ChildProcessCrashObserver::OnChildExit. Previously we avoid duplicating collecting stats by checking that if the dump is missing, meaning it has already been crashed before. This mostly still works except for NotifyObserver call which is still called under kMissingDump, so fix that. Change-Id: I2145a0df8c604739f86fb9ab9cecf845168dcbfe Reviewed-on: https://chromium-review.googlesource.com/1148558Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#577930}
-
Malay Keshav authored
This patch manually snaps the omnibox dropdown popup widget window to the physical pixel grid. On CrOS the popup is treated as a top level window which is by default snapped to the root window. This patch also lazily marks the root windows as snapped. The root windows are snapped by default so marking them snapped makes sense. Bug: 843250 Change-Id: I1dd20ea57522e4987d23ba7dcaa3ae891bbc7182 Component: Omnibox popup, desktop window tree host Reviewed-on: https://chromium-review.googlesource.com/1139078Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#577929}
-
Adithya Srinivasan authored
Makes the method use TimeDelta instead of double to represent duration. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id95aface04fa2b72bc919fd4ab52af062908f8df Bug: 763980 Reviewed-on: https://chromium-review.googlesource.com/1140355Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#577928}
-
Bence Béky authored
This CL lands part of internal change 201519764. The rest of that change has been merged in https://crrev.com/c/1121700 (reviewed at https://crrev.com/c/1121285). Bug: 488484 Change-Id: I78b225c43af626eb7c6e3054b85e44018387b8cb Reviewed-on: https://chromium-review.googlesource.com/1146664 Commit-Queue: Yang Song <yasong@chromium.org> Reviewed-by:
Yang Song <yasong@chromium.org> Cr-Commit-Position: refs/heads/master@{#577927}
-
Tim Volodine authored
Currently the run_tests_rebaseline.sh script does not work as intended due to the switch to AndroidJUnitRunner. This CL fixes the script and makes it possible to rebaseline webview layout tests as originally intended. Change-Id: If055a4460925ea5e18d3996d927c8596b9027a7a Reviewed-on: https://chromium-review.googlesource.com/1150160Reviewed-by:
-
Lindsay Pasricha authored
Bug: 847948,852341 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I77f63093d642a51193787641568a639f80d5c5e1 Reviewed-on: https://chromium-review.googlesource.com/1148796 Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#577925}
-
Danyao Wang authored
Previously I assumed -webView:didReceivedAuthenticationChallenge callback is always called for the navigation associated with the current WKWebView.URL value. In testing, it turns out in back/forward navigation, this callback may be triggered for a subresource on the previous item after WKWebView.URL has already been updated to the new item. As a result, this DCHECK is incorrectly triggered when navigating back to NTP from a web page before the web page finishes loading completely. From code inspection, the implementation of this delegate call doesn't depend on states associated with self.currentNavItem. This scenario already exists between web pages. So the DCHECK is not protecting any meaningful state corruption. Bug: 864525 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I02a1678721e2db59ed1f288c9e4ec7139efc8632 Reviewed-on: https://chromium-review.googlesource.com/1147328Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#577924}
-
Tiger Oakes authored
Adds flags to the data.ndjson file, and exposed the information in the UI using custom highlighting options. The UI will additionally list the flags in the symbol infocard. Bug: 847599 Change-Id: If2c7b7f5147296cf13e0c0ef9c36d6748820e42f Reviewed-on: https://chromium-review.googlesource.com/1148795 Commit-Queue: Tiger Oakes <tigero@google.com> Reviewed-by:
Sam Maier <smaier@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#577923}
-
Martin Robinson authored
There are a few small issues with the code right now that prevent it from linting cleanly. This change, while not affecting the functionality, will make it much easier to catch linting errors in the future. Change-Id: Ib5284b025e7bc385810a2c171d36bef478fe83f5 Reviewed-on: https://chromium-review.googlesource.com/1150162Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#577922}
-
Xiaochu Liu authored
Increase EVN to 70.0 for crostini. From now on, EVN major is reved after each branch point to sync with the Chrome release milestone until we migrate to DLC. BUG=chromium:867062 TEST=None Change-Id: Ie970bc285e7225167054caac8ab8f0ac60f7a64a Reviewed-on: https://chromium-review.googlesource.com/1148943Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Xiaochu Liu <xiaochu@chromium.org> Cr-Commit-Position: refs/heads/master@{#577921}
-
Martin Robinson authored
The accessibility code for Aura on Linux was using the ATK_ROLE_EMBEDDED role for elements with the role ax::mojom::Role::kApplication so that it would not apply to ARIA applications. To be consistent with other applications, ATK_ROLE_APPLICATION is more appropriate. We only use this when the element is the root of the accessibility tree. TEST=accessibility_unittests --gtest_filter=AXPlatformNodeAuraLinuxTest.* Bug: 867006 Change-Id: I6c64b142cf3307c906f73235ed8247e828cd2394 Reviewed-on: https://chromium-review.googlesource.com/1148397Reviewed-by:
-
clamy authored
This CL adds a null check for the last committed NavigationEntry to fix a crash in CaptivePortalTabReloader. Bug: 857002 Change-Id: Ia26bd420cbee80958b3a74937ade9efb764ed03a Reviewed-on: https://chromium-review.googlesource.com/1146657 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#577919}
-
Xiaocheng Hu authored
The function's main loop is supposed to halt after timeout, but contains a branch that continues directly without checking timeout, which leads to renderer hang in some edge/buggy cases. This patch implements yoichio's idea (https://goo.gl/EQED8Y) to fix the issue, by rewriting loop conditions and ensuring timeout checking in all branches. Note: no test in this patch, because the only repro case we have hits a DCHECK earlier before entering the problematic branch. Bug: 862648 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I050909bd625f122c0df7ed905184c32e133170ce Reviewed-on: https://chromium-review.googlesource.com/1148645Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#577918}
-
Martin Robinson authored
The level attributes specifies the hierarchical level of the element. This is used for HTML heading elements. TEST=accessibility_unittests --gtest_filter=AXPlatformNodeAuraLinuxTest.* Bug: 866612 Change-Id: If3e1d5192dc6d0749bdaffda203d4539ea02bf63 Reviewed-on: https://chromium-review.googlesource.com/1150144Reviewed-by:
-
Ned Nguyen authored
This has several benefits: 1) No longer generating the authentication token for each benchmark results too early. Before this CL, we generate authentication for every benchmark results first, then process each perf results & upload them. With such logic, the last benchmark to be uploaded may have token generated for a long period of time. 2) Enables generating a new token for every retry attempt in core/results_dashboard.py. Bug:864565 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I8b2d681efdaa241a8af19a7ffbf126523caa12a9 NOTRY=true # CQ flakes Change-Id: I8b2d681efdaa241a8af19a7ffbf126523caa12a9 Reviewed-on: https://chromium-review.googlesource.com/1150080 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Simon Hatch <simonhatch@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#577916}
-
Evan Stade authored
This cl places the responsibility of determing the hit test component on individual Views, which gets rid of some ash/ dependencies and reduces code duplication. The one behavioral change in classic Ash is that padding parts of the hosted app button container (e.g. the medium sized space between the menu button and the minimize button) are now HTCAPTION, i.e. can be used to drag the frame rather than do nothing. Bug: 854704 Change-Id: Ia290a42652a9acbf9b4b01c86941e8d2bdcadc48 Reviewed-on: https://chromium-review.googlesource.com/1145545Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#577915}
-
Nate Chapin authored
Flatten DocumentThreadableLoader into the base class, ThreadableLoader. Same for DocumentThreadbleLoaderClient and DocumentThreadableLoaderTest. Bug: 706331 Change-Id: Ib15340f83bc38e6c0427d829cb0490f7b3ecd2c5 Reviewed-on: https://chromium-review.googlesource.com/1045522 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#577914}
-
Koji Ishii authored
This is a reland of 6ec9b32f Mac Retina bots were down when rebaselined last time, and they started failing when back. Original change's description: > [LayoutNG] Remove spaces before <br> to avoid crbug.com/40634 > > This patch removes spaces before <br> because the images do > not match due to crbug.com/40634, which LayoutNG does not > have the problem. > > TBR=eae@chromium.org > > Bug: 591099 > Change-Id: I8f0770f8911ce2d5c6f9e37ff90752011b84cb49 > Reviewed-on: https://chromium-review.googlesource.com/1142050 > Reviewed-by: Koji Ishii <kojii@chromium.org> > Commit-Queue: Koji Ishii <kojii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#576333} TBR=eae@chromium.org Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I2243c930a20a1b2404854df09fbdeec4a33c9807 Reviewed-on: https://chromium-review.googlesource.com/1149640Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#577913}
-
Sebastien Marchand authored
This CL adds a version number to the Local Site Characteristics DB and reset its content if it already exists. Bug: 773382, 866540, 867027 Change-Id: I0a68ad044456ab67c39a3f1537e9ff9534920d47 Reviewed-on: https://chromium-review.googlesource.com/1147113 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#577912}
-
Parastoo Geranmayeh authored
If the triggering element is no longer valid, update it, before checking if a triggering a refill is necessary. While updating the old element, check for nameless forms and unowned elements as well. Also, if the triggering element is not filled, triggering a refill is necessary. Tests added. Fixes (Desktop): etsy, staple and ysl. Bug: 863575 Change-Id: Id9a775a31a345c5c722687df5958c55b662ebbfd Reviewed-on: https://chromium-review.googlesource.com/1145486Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#577911}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/09f0990a2db0..cb29fbd231d6 git log 09f0990a2db0..cb29fbd231d6 --date=short --no-merges --format='%ad %ae %s' 2018-07-25 mikenichols@chromium.org cbuildbot_launch: Wrap duration with per instance timing metric. Created with: gclient setdep -r src/third_party/chromite@cb29fbd231d6 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I7e5fb32ce11a19647fa35aac7ca1c89814d7604b Reviewed-on: https://chromium-review.googlesource.com/1150046Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577910}
-
Sam Maier authored
This is a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1136730 I appear to have missed a few sites in the previous CL. Bug: 843745 Change-Id: I541f0db2e9cf8e419a3303b7ab2a08a1df0c0372 Reviewed-on: https://chromium-review.googlesource.com/1148982 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#577909}
-
Elly Fong-Jones authored
Latest revisions from UX in comment 17 on the linked bug: Text items reduced from 32 to 28 Container items reduced from 48 to 40 (not specced, but not doing this made them look very weird) Separator spacing reduced from 8pt to 4pt Bug: 860673 Change-Id: Iad700a22eb9aad43f2c328314a6bffa885843194 Reviewed-on: https://chromium-review.googlesource.com/1148467 Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#577908}
-
Kush Sinha authored
A race condition exists between Account Manager's JS components' initialization and AccountTrackerService callbacks. Bug: 833797 Change-Id: I8eaf0d134aef4c08e089494b3ddd7d1bf7d0b2ae Reviewed-on: https://chromium-review.googlesource.com/1150171Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#577907}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I13d873174d8167e70fb45f49a415de60addfbcb9 Reviewed-on: https://chromium-review.googlesource.com/1149996 Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577906}
-
Oriol Brufau authored
[css-logical] Replace uses of webkit-prefixed logical properties with standard ones in /chrome/common Bug 850000 added standard logical properties and aliased prefixed ones to them. The prefixed properties are still used in various places, but the standard ones should be used instead. This patch replaces all the uses in /chrome/common Spec: https://drafts.csswg.org/css-logical/#box BUG=862141 Change-Id: Ic8ec1308146f68a7c1bf82f850361adb3b4b63f8 Reviewed-on: https://chromium-review.googlesource.com/1150025Reviewed-by:
Paul Irish <paulirish@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#577905}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/096c5296c3b0..2160821e16db git log 096c5296c3b0..2160821e16db --date=short --no-merges --format='%ad %ae %s' 2018-07-25 jmadill@chromium.org Add gl::TexLevelArray. Created with: gclient setdep -r src/third_party/angle@2160821e16db The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I89a9cff4a950c4c40b323bff638a2b934313df1d Reviewed-on: https://chromium-review.googlesource.com/1150045Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577904}
-
Peter Beverloo authored
When a Background Fetch registration is created, a BGFetchJobContoller is created immediately after committing it to storage even if the job can't be started just yet -- this should be the scheduler's decision. This CL is the first step in removing the assumption that each existing Background Fetch registration is represented by a BGFetchJobController. Acknowledging creation of the registration is separated from indicating that a new registration is available, by adding an OnRegistrationCreated method to the BackgroundFetchDataManagerObserver. As part of this refactoring, in an effort to avoid passing around unique pointers to BackgroundFetchRegistration objects, these are now passed by const& where the receiver makes a copy when necessary. This enabled reducing knowledge of the protobufs throughout our system, which is a nice clean-up on its own. TBR=avi for BUILD.gn Bug: 850512 Change-Id: I8d3c42a11ab89f7b7c3573a6f9a21e096493b838 Reviewed-on: https://chromium-review.googlesource.com/1149871 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#577903}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c062b6be5a01..42c1c03334c7 git log c062b6be5a01..42c1c03334c7 --date=short --no-merges --format='%ad %ae %s' 2018-07-25 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms dad22fe0e646..4642d9fe69e1 (1 commits) Created with: gclient setdep -r src/third_party/skia@42c1c03334c7 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: Idf6d4304c03a18a301aa70e7cbd41e069c294be6 Reviewed-on: https://chromium-review.googlesource.com/1150042Reviewed-by:
-
Rayan Kanso authored
Change-Id: I229ea7ee210aa1a7abe3d7449294d2dcd24ce499 Reviewed-on: https://chromium-review.googlesource.com/1149921Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#577901}
-
Kim Paulhamus authored
Change-Id: I56db43cb851f267b50664702943614bcc9b25e0d Reviewed-on: https://chromium-review.googlesource.com/1145957Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#577900}
-
Sahel Sharify authored
This reverts commit e459c6e9. Reason for revert: <INSERT REASONING HERE> Original change's description: > Reland "fast/events/touch/gesture/* layouttests are using gpu benchmarking." > > This reverts commit cb66764a. > > Reason for revert: I re-wrote the flaky test. > > Original change's description: > > Revert "fast/events/touch/gesture/* layouttests are using gpu benchmarking." > > > > This reverts commit 8faf0805. > > > > Reason for revert: caused webkit layout tests failures. the first failure https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/22103 > > > > Original change's description: > > > fast/events/touch/gesture/* layouttests are using gpu benchmarking. > > > > > > Bug: 846424 > > > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > > > Change-Id: I13dc5826152a1b3f8157342a7f1d644f333a89e2 > > > Reviewed-on: https://chromium-review.googlesource.com/1144230 > > > Commit-Queue: Sahel Sharify <sahel@chromium.org> > > > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#577727} > > > > TBR=lanwei@chromium.org,nzolghadr@chromium.org,sahel@chromium.org > > > > Change-Id: I85c026c58b4a70626fe9c323c152b4ff92b455a0 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 846424 > > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > > Reviewed-on: https://chromium-review.googlesource.com/1150180 > > Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> > > Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#577856} > > TBR=lanwei@chromium.org,kolos@chromium.org,nzolghadr@chromium.org,sahel@chromium.org > > Change-Id: I3b9fcc55c7449028646d5d83958c73ed8f878312 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 846424 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Reviewed-on: https://chromium-review.googlesource.com/1150240 > Reviewed-by: Sahel Sharify <sahel@chromium.org> > Commit-Queue: Sahel Sharify <sahel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577897} TBR=lanwei@chromium.org,kolos@chromium.org,nzolghadr@chromium.org,sahel@chromium.org Change-Id: I41e015730a5df25f74d991f011aa15376bfd70d5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 846424 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1150123Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#577899}
-
Anita Woodruff authored
- Turns out these tests were failing because notification permissions were switched from info bars to modals a while ago and these tests were never updated. Bug: 853405 Change-Id: Ia663240507a7fa674f96170c4fdcbfdc9c028ec9 Reviewed-on: https://chromium-review.googlesource.com/1145309 Commit-Queue: Anita Woodruff <awdf@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#577898}
-
