GitLab

Rename the IntRectExtent class to IntBoxExtent to match the naming of
the LayoutUnit and floating point versions of the same concept.

R=leviw@chromium.org

Review URL: https://codereview.chromium.org/206373006

git-svn-id: svn://svn.chromium.org/blink/trunk@169675 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add new FloatBoxExtent class (to complement existing int and LayoutUnit
versions) and update HarfBuzzShaper to use this class instead of four
separate float values to represent the glyph bounding box.

R=dglazkov@chromium.org
BUG=354165

Review URL: https://codereview.chromium.org/206403004

git-svn-id: svn://svn.chromium.org/blink/trunk@169674 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Turns out the entry wasn't needed.

BUG=273904
TBR=leviw@chromium.org

Review URL: https://codereview.chromium.org/199733014

git-svn-id: svn://svn.chromium.org/blink/trunk@169673 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In particular, don't do it if the dirty bits are going to be cleaned up during synchronous
Blink execution anyway. To achieve this, this CL adds an m_updatingLayoutAndStyleForPainting state bit
in PageAnimator to indicate that code is in progress which is guaranteed to call
RenderLayerCompositor::updateCompositingLayers() at its end, and therefore any compositing dirty
bits set before that call do not require a call to scheduleAnimation().

Unfortunately, in a small number of cases RenderLayerCompositor::updateCompositingLayers will set
*new* dirty bits when updating direct compositing reasons. So put in code to check each
RenderLayerCompositor instance in the frame tree for dirty bits after
RenderLayerCompositor::updateCompositingLayers has run and call scheduleAnimation() if so. In the
future we can remove this once the compositing code is fixed to not leave around dirty bits.

BUG=340679

Review URL: https://codereview.chromium.org/202533003

git-svn-id: svn://svn.chromium.org/blink/trunk@169672 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=352300
NOTRY=true

Review URL: https://codereview.chromium.org/199543004

git-svn-id: svn://svn.chromium.org/blink/trunk@169671 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Turn the ConsoleBase object into a garbage collected object if Oilpan
is enabled, avoiding its ref forwarding to either Console or WorkerConsole.

R=haraken@chromium.org,ager@chromium.org
BUG=340522

Review URL: https://codereview.chromium.org/206093005

git-svn-id: svn://svn.chromium.org/blink/trunk@169670 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=350571
TEST=All layout tests still pass.

Review URL: https://codereview.chromium.org/203213008

git-svn-id: svn://svn.chromium.org/blink/trunk@169669 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This allows the registering page, or pages loaded via the worker,
to send arbitrary messages to the worker script.

BUG=350103
R=abarth@chromium.org, adamk@chromium.org, kinuko@chromium.org, marja@chromium.org

Review URL: https://codereview.chromium.org/185643009

git-svn-id: svn://svn.chromium.org/blink/trunk@169668 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/206253005

git-svn-id: svn://svn.chromium.org/blink/trunk@169667 bbb929c8-8fbe-4397-9dbb-9b2b20218538

AffineTransform.inverse() unexpectedly returned an identity matrix when
the matrix was not invertible. This caused invalid rendering for e.g
scale(0) matrices in svg.

BUG=352603

Review URL: https://codereview.chromium.org/200053005

git-svn-id: svn://svn.chromium.org/blink/trunk@169666 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When URL of an iframe changes from "unset" to "set", we don't want to
create new history entry. This worked for URLs without fragment
identifier but failed with it present.

This change takes the idea from the old code, before it was rewritten
in https://codereview.chromium.org/126453005

BUG=353096

Review URL: https://codereview.chromium.org/201773002

git-svn-id: svn://svn.chromium.org/blink/trunk@169665 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As of chromium r254438 this method is never called.

[1] https://src.chromium.org/viewvc/chrome?view=rev&revision=254438

Review URL: https://codereview.chromium.org/205733003

git-svn-id: svn://svn.chromium.org/blink/trunk@169664 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is in anticipation of adding support for attributes.

BUG=352300,335247

Review URL: https://codereview.chromium.org/204873003

git-svn-id: svn://svn.chromium.org/blink/trunk@169663 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Drive-by: fix navigation to Elements panel via context menu.

BUG=

Review URL: https://codereview.chromium.org/206123005

git-svn-id: svn://svn.chromium.org/blink/trunk@169662 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Oilpan: Move CSSStyleDeclaration and subclasses to the heap using transistion types. (https://codereview.chromium.org/195953003/)

Reason for revert:
Breaking tests.

Original issue's description:
> Oilpan: Move CSSStyleDeclaration and subclasses to the heap using transistion types.
> 
> R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org
> BUG=341815
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169652

TBR=ager@chromium.org,erik.corry@gmail.com,haraken@chromium.org,oilpan-reviews@chromium.org,tkent@chromium.org,vegorov@chromium.org,zerny@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=341815

Review URL: https://codereview.chromium.org/205033007

git-svn-id: svn://svn.chromium.org/blink/trunk@169661 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There is no need to manipulate the sorted state externally, we can
efficiently detect sorted color stops on the fly. This may also avoid
a sort pass in some cases.

R=pdr@chromium.org,schenney@chromium.org,rob.buis@samsung.com

Review URL: https://codereview.chromium.org/206493002

git-svn-id: svn://svn.chromium.org/blink/trunk@169660 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change makes the outline a first class visual effect instead
of being applied manually in the code. This removes the crazy fudge
factor logic that would grow *ANY* repaint rectangle by the maximal
outline on the page.

All test changes are progressions apart from 2 multi-column tests
regressing due to http://crbug.com/348064:
- fast/forms/range/slider-in-multi-column.html
- fast/forms/number/number-spinbutton-in-multi-column.html
A fix is in progress for the underlying issue that will make them
pass again (thanks to Morten Stenshome).

BUG=273904

Review URL: https://codereview.chromium.org/176953008

git-svn-id: svn://svn.chromium.org/blink/trunk@169659 bbb929c8-8fbe-4397-9dbb-9b2b20218538

During RenderInline::splitFlow(), floats are cleared on an anonymous containingBlock() for
the inline being split. This is a problem if siblings of the block contain references to
the same floats, since the float removal code in markSiblingsWithFloatsForLayout() will not
later find them.

R=inferno@chromium.org
BUG=245727

Review URL: https://codereview.chromium.org/203483002

git-svn-id: svn://svn.chromium.org/blink/trunk@169658 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The method is a noop as we first collect names of shortcut edges and then iterate through all non-shortcuts whose names are also in the collection.

BUG=None

Review URL: https://codereview.chromium.org/204913005

git-svn-id: svn://svn.chromium.org/blink/trunk@169657 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When the partial layout code was removed this changed the conditional
for triggering repaintTree from m_doFullRepaint || !partialLayout.isStopping()
to just m_doFullRepaint. This caused repaint to not happen in a lot of cases
because, typically, !paritalLayout.isStopping() was true and would trigger
repaintTree. I don't think we need the check at all and should be
unconditionally triggering repaintTree and using the information from layout to
determine what repaints.

BUG=283623,320139

Review URL: https://codereview.chromium.org/206413003

git-svn-id: svn://svn.chromium.org/blink/trunk@169656 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We don't actually need to rewind iterators. The iterators should be one-pass only and rewind just complicates the code.

BUG=None

Review URL: https://codereview.chromium.org/206393004

git-svn-id: svn://svn.chromium.org/blink/trunk@169654 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This extracts everything related to our tabbed editor from the sources panel to the separate SourcesEditor class.
This class could be later refactored into the view that could be embedded in other places (e.g. Drawer).

R=pfeldman, lushnikov

Review URL: https://codereview.chromium.org/206063003

git-svn-id: svn://svn.chromium.org/blink/trunk@169653 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org
BUG=341815

Review URL: https://codereview.chromium.org/195953003

git-svn-id: svn://svn.chromium.org/blink/trunk@169652 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/201123007

git-svn-id: svn://svn.chromium.org/blink/trunk@169651 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Introduced filtered iterator and iterator over array of indexes. This allowed to decompose HeapSnapshotFilteredOrderedIterator.

BUG=None
R=alph@chromium.org

Review URL: https://codereview.chromium.org/205993003

git-svn-id: svn://svn.chromium.org/blink/trunk@169650 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Adding ability to access objects from printed ObjectPropertySections (console, scopes pane and etc.).

BUG=306120
R=pfeldman

Review URL: https://codereview.chromium.org/201613004

git-svn-id: svn://svn.chromium.org/blink/trunk@169649 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL is to prepare for auto-dispatching baseValueToString in SVG*Element::parseAttribute.
SVGAnimatedLength required {Forbid,Allow}NegativeValues setting to be passed in as an argument of baseValueToString.
This was making auto-dispatch for baseValueToString calls difficult.

This CL removes the SVGLengthNegativeValuesMode argument from |SVGAnimatedLength::baseValueToString()|. The setting is passed in by |SVGAnimatedLength| ctor.

BUG=349370

Review URL: https://codereview.chromium.org/206133005

git-svn-id: svn://svn.chromium.org/blink/trunk@169648 bbb929c8-8fbe-4397-9dbb-9b2b20218538

DevTools: Remove unneeded willReceiveResourceData instrumentation and reuse didReceiveData instead of didReceiveResourceData.

R=eustas@chromium.org, pfeldman@chromium.org, caseq, pfeldman

Review URL: https://codereview.chromium.org/108103002

git-svn-id: svn://svn.chromium.org/blink/trunk@169647 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=353961
TBR=vsevik@chromium.org

Review URL: https://codereview.chromium.org/206373002

git-svn-id: svn://svn.chromium.org/blink/trunk@169646 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Breakage from r168748 which used the wrong time-source.

BUG=231576

Review URL: https://codereview.chromium.org/204673004

git-svn-id: svn://svn.chromium.org/blink/trunk@169645 bbb929c8-8fbe-4397-9dbb-9b2b20218538

By doing this, they can be packed together with the existing bit-field
member NodeRareData::m_connectedFrameCount, and save some space.

Impact according to sizeof(ElementRareData), on 64-bit Linux (GCC and
Clang alike,) is a modest 8 byte saving, from 144 bytes to 136 bytes.

BUG=

Review URL: https://codereview.chromium.org/201153006

git-svn-id: svn://svn.chromium.org/blink/trunk@169644 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The RequiredThisAnnotationChecker has been merged into FunctionReceiverChecker,
so it can now make use of the knowledge whether a nested function
references |this| or not. As such, the receiver checks now rely
on the fact of the |this| usage rather than the presence of the @this annotation.

R=aandrey@chromium.org, aandrey, sergeyv, vsevik

Review URL: https://codereview.chromium.org/199733011

git-svn-id: svn://svn.chromium.org/blink/trunk@169643 bbb929c8-8fbe-4397-9dbb-9b2b20218538

allocation by user-defined placement new operators.

Removing the placement new operators will lead to redefinition errors
if a class is marked as DISALLOW_ALLOCATION or STACK_ALLOCATED
and at the same time defines placement new operators.

R=oilpan-reviews@chromium.org, vegorov@chromium.org, zerny@chromium.org
BUG=

Review URL: https://codereview.chromium.org/199733009

git-svn-id: svn://svn.chromium.org/blink/trunk@169642 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We no longer have DRT in Blink.

BUG=327256

Review URL: https://codereview.chromium.org/205323004

git-svn-id: svn://svn.chromium.org/blink/trunk@169641 bbb929c8-8fbe-4397-9dbb-9b2b20218538

What we expect this case is just stability so output string itself is not related to test input.

BUG=

Review URL: https://codereview.chromium.org/206193003

git-svn-id: svn://svn.chromium.org/blink/trunk@169640 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is exact copy of r169554 with a fix for inpsector protocol tests.

Uin32Array already has subarray method that returns a new view for the same array buffer.

BUG=None
TBR=alph@chromium.org

Review URL: https://codereview.chromium.org/197533009

git-svn-id: svn://svn.chromium.org/blink/trunk@169639 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch adds a typedef for WebFrame so we can start converting
references to WebFrame in embedder implementations. It also updates most
references of WebFrame in the embedding API to WebLocalFrame instead.
Most locations should only ever have to handle WebLocalFrames, so it's
just a fairly straightforward rename. However, there are some corner
cases that need to be adjusted more carefully, since things like the
opener, parent frame, and child frames can be pointers to an eventual
WebRemoteFrame class.

BUG=346764

Review URL: https://codereview.chromium.org/191003006

git-svn-id: svn://svn.chromium.org/blink/trunk@169638 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It can avoid reading from previous unchanged WebGL layer content during printing.

BUG=351956

Review URL: https://codereview.chromium.org/197213014

git-svn-id: svn://svn.chromium.org/blink/trunk@169637 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Refactoring spelling-hasspellingmarker.js to use asynchronous spellchecking.
In addition, adds some bits for non-DumpRenderTree users.

It's based on WebKit changeset: http://trac.webkit.org/changeset/164100

BUG=295722

Review URL: https://codereview.chromium.org/204383002

git-svn-id: svn://svn.chromium.org/blink/trunk@169636 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Oilpan: Fix Heap::isConsistentForGC which only checks the heap for one attached thread at this point.

Thanks for noticing this Peter. :)

R=oilpan-reviews@chromium.org, pkasting@chromium.org, zerny@chromium.org
BUG=

Review URL: https://codereview.chromium.org/206113002

git-svn-id: svn://svn.chromium.org/blink/trunk@169635 bbb929c8-8fbe-4397-9dbb-9b2b20218538