- 05 Apr, 2018 40 commits
-
-
Matt Giuca authored
Fixed a regression introduced by r537588 which showed a location bar on all non-https pages. Extension pages are secure, but have scheme chrome-extension, so did not pass this test. Now chrome-extension pages are special-cased to be allowed without a location bar. Bug: 828233 Change-Id: Ic792007ddb8d8d29ab0dc0b82500e4833f6f2c7c Reviewed-on: https://chromium-review.googlesource.com/991932 Commit-Queue: Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#548372}
-
Darren Shen authored
Likely failing due to incorrect rebaselining from: https://chromium.googlesource.com/chromium/src/+/7a8765a7a7e0158e7f82681d06ce798bf8901328 TBR=beccahughes@chromium.org TBR=thomasanderson@chromium.org Bug: 829228 Change-Id: Icf2894aae0a4c0ed3baa85d82f7dd47417410d23 Reviewed-on: https://chromium-review.googlesource.com/997197Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#548371}
-
Raphael Kubo da Costa authored
Stop relying on the header being included implicitly. This fixes the build with libstdc++ after b1303e03 ("Add support in CloudPolicyClient for machine enrollment and reporting"): ../../components/policy/core/common/cloud/cloud_policy_util.cc: In function ‘std::__cxx11::string policy::GetMachineName()’: ../../components/policy/core/common/cloud/cloud_policy_util.cc:33:17: error: ‘HOST_NAME_MAX’ was not declared in this scope char hostname[HOST_NAME_MAX]; ^~~~~~~~~~~~~ ../../components/policy/core/common/cloud/cloud_policy_util.cc:33:17: note: suggested alternative: ‘_SC_HOST_NAME_MAX’ char hostname[HOST_NAME_MAX]; ^~~~~~~~~~~~~ _SC_HOST_NAME_MAX ../../components/policy/core/common/cloud/cloud_policy_util.cc:34:19: error: ‘hostname’ was not declared in this scope if (gethostname(hostname, HOST_NAME_MAX) == 0) // Success. ^~~~~~~~ ../../components/policy/core/common/cloud/cloud_policy_util.cc:34:19: note: suggested alternative: ‘basename’ if (gethostname(hostname, HOST_NAME_MAX) == 0) // Success. ^~~~~~~~ basename While HOST_NAME_MAX is only used in the Linux code path, it should be harmless to include the header unconditionally. BUG=812641 Change-Id: I6769792efe188ff437753e4cb1ba134c341c20e9 Reviewed-on: https://chromium-review.googlesource.com/987895Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#548370}
-
Dominick Ng authored
BUG=782120,811578 Change-Id: I240ed465ddab68c363fdbbac99c86ccd3ffd0194 Reviewed-on: https://chromium-review.googlesource.com/996833Reviewed-by:
-
Sylvain Defresne authored
This reverts commit 3c0ee4b6. Reason for revert: this is breaking the downstream autoroller as the file ios/public/provider/chrome/browser/voice/voice_search_presenter.h is still included. Original change's description: > [iOS] Remove StartVoiceSearchCommand. > > This is patch 3 of a 3-way patch, and must be landed after > crrev.com/c/981777 and crrev.com/i/595643. > > Bug: 805123 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: I71dd8dfa19f57b964e7ac08154e94db6614bb895 > Reviewed-on: https://chromium-review.googlesource.com/981779 > Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> > Reviewed-by: Mark Cogan <marq@chromium.org> > Reviewed-by: Justin Cohen <justincohen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#548355} TBR=marq@chromium.org,justincohen@chromium.org,kkhorimoto@chromium.org Change-Id: I597a099df96888857173632ebfb92bde002d95d3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 805123 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/997373Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#548368}
-
Chih-Yu Huang authored
This CL replace "base::Bind" to "base::BindOnce" or "base::BindRepeating". BUG=none TEST=git cl format TEST=Run video_encode_accelerator_unittest at scarlet device Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I1cb8ba08334c0bd082bca6c164eba10a7b8e8d4c Reviewed-on: https://chromium-review.googlesource.com/991628Reviewed-by:
Ricky Liang <jcliang@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#548367}
-
Matt Giuca authored
Use of R raw string literal was causing code review to stop syntax highlighting for most of the file. Changed to a regular backslash-escaped string literal. Change-Id: I89b24951508160d61017e374f2ebca0069f0cabc Reviewed-on: https://chromium-review.googlesource.com/997252Reviewed-by:
-
Koji Ishii authored
The 2nd patch of a large rebaselines following CL:997255. This patch extends rebaselines to where all of the below stand: * Images match. * Text dumps do not match after nomalizations. By quickly going through them, they are most likely from where the text intrinsic size changes. Easy ones are just changes in the size and positions of LayoutInline/LayoutText. Complex ones include size change of shrink-to-fit ancestors, in which case, reviews may not be really reliable. 1st patch (CL:997255) recovered 162, and this patch recovers 292, total 454. The rest might have changed images and that we'll need image reviews. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Id65a2818dc99a6b46c7ef6aa365909ce6d1516f1 Reviewed-on: https://chromium-review.googlesource.com/997257 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#548365}
-
Makoto Shimazu authored
ProceedWithResponse doesn't have to be implemented for ServiceWorkerNavigationLoader since it's not using MojoAsyncResourceHandler. This CL just removes the NOTREACHED() there. Bug: 822131 Change-Id: I5fb97dd8c0a0428b642f74368409b787e47f9315 Reviewed-on: https://chromium-review.googlesource.com/994496Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#548364}
-
Adam Rice authored
Previously URLSearchParamsIterationSource iterated over a copy of URLSearchParams, but it is specified in the standard as iterating over the live list. Modify it to reference the original URLSearchParams object instead of making a copy. Also add web-platform tests for delete during foreach, and a chromium- specific test for GC of URLSearchParams during iteration. Remove failing expectations. BUG=677322 Change-Id: I8c53fd8dd9863fe1146c5b7849d4f08245b37bc1 Reviewed-on: https://chromium-review.googlesource.com/987839Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#548363}
-
Jun Choi authored
GetAssertionRequestHandler guarantees at most one successful response to be sent to the relying party. Bug: 780078 Change-Id: Ibe8cb2374713f25fbabc73d23615349edb8589fb Reviewed-on: https://chromium-review.googlesource.com/942368 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#548362}
-
Yoshifumi Inoue authored
This patch changes extent of |AttachContext| to its lifetime for improving code health. Change-Id: I18b38b1a0e5f1299d8cdbf20c21608be1493a596 Reviewed-on: https://chromium-review.googlesource.com/996774Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#548361}
-
Tatsuhisa Yamaguchi authored
Bug: 714579 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4459f9a3b2e024ce6305f93a4c886600a81b73b6 Reviewed-on: https://chromium-review.googlesource.com/995243Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#548360}
-
Koji Ishii authored
Since the job 4583, ~1000 text/image failures started, probably due to further progress on Linux font change crbug.com/787020. CL:994554 added them as failures. This is a series of efforts to rebaseline pixel/text changes that are LayoutNG improvements. As a starter, this patch rebaselines 162 of them, where images match, and also text dump match after normalizations. A few more patches that apply different methods, combined with manual reviews, will follow. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I0eece6d2420568454c60df459a082188ed06a8ee Reviewed-on: https://chromium-review.googlesource.com/997255 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Jennifer Apacible authored
Currently, there is only a PiP button for the legacy / non-modern set of media controls. This adds and enables the modern version. BUG: 726619 823109 Change-Id: Iddb2d8393d5cf519bb6e32639d5f640bc341fc6f Reviewed-on: https://chromium-review.googlesource.com/966980 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#548358}
-
Rakina Zata Amni authored
Stylesheets from link elements that previously have rel = "stylesheet" but then changed to something else should be removed/not considered anymore until the rel attribute is changed back to "stylesheet" again. Currently this works correctly for link elements in the document tree, but fails in link elements within a shadow tree because link elements in shadow tree with rel attribute != "stylesheet" are skipped from processing. Because of that, the stylesheet in the link element was never cleared and no style recalc happened. JSBin from bug: http://jsbin.com/bojunajaju/edit?html,console,output Bug: 817355 Change-Id: I57c71c79c0cc471d36eb988b8a81eef82c33548a Reviewed-on: https://chromium-review.googlesource.com/995116 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#548357}
-
Koji Ishii authored
Following bot results are included. 4558 4561 4566 4569 4572 4573 4576 4577 4579 4580 4583 2 lines were removed and 0 lines were deflaked by consecutive results since 4509. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I7e0e9549c60cd5e504a7540f6c78fd9fa017aaea Reviewed-on: https://chromium-review.googlesource.com/994554 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
-
Kurt Horimoto authored
This is patch 3 of a 3-way patch, and must be landed after crrev.com/c/981777 and crrev.com/i/595643. Bug: 805123 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I71dd8dfa19f57b964e7ac08154e94db6614bb895 Reviewed-on: https://chromium-review.googlesource.com/981779 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#548355}
-
Morten Stenshorne authored
When changing a layout object from in-flow to out-of-flow positioned, we used to just remove it from the flow thread, risking that there'd no longer be a column set to associate it with. However, an out-of-flow positioned descendant may be contained by something that's inside the flow thread, e.g. if the containing block of an absolutely positioned object is a relatively positioned object, and that relatively positioned object is contained by the flow thread. Since it's hard to detect what the new containing block of an object is going to be before it has actually gone out of flow, we'll still remove it from the flow thread, but we'll now detect that we need to re-insert it when computed style has updated. Bug: 827424 Change-Id: I413348b0d3ecd0c4b5051e6e9d2a4526863bef60 Reviewed-on: https://chromium-review.googlesource.com/995439Reviewed-by:
-
https://chromium.googlesource.com/catapult.git/+log/a13166acf03f..5d3d40fb8894 $ git log a13166acf..5d3d40fb8 --date=short --no-merges --format='%ad %ae %s' 2018-04-03 dtu [pinpoint] Remove hashing from isolate keys. 2018-04-04 dtu [pinpoint] Make an expired Swarming task fatal to the job. 2018-04-04 dtu [pinpoint] Remove ChartJson Quest and Execution. Created with: roll-dep src/third_party/catapult BUG=chromium:792780 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I3f572cc571bfe3fad66e80bb2d9876f571270012 Reviewed-on: https://chromium-review.googlesource.com/996394Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#548353}
-
Donn Denman authored
Adds a simple Metrics Reporter for Contextual Suggestions for use with Explore on Content (EoC). The Reporter uses a simple UkmEntry class that ensures that a consistent record is always written to UKM for the Metrics Reporter. The Metrics Reporter also records some UMA histograms. Adds two simple test files for these new classes. This code is not yet connected to anything. UKM documentation is at go/ukm-eoc, and this CL should only log metrics that have been privacy-approved in that doc. BUG=824185 Change-Id: I2aed351c6670e42d5ed6f5f0ec222f54041e2989 Reviewed-on: https://chromium-review.googlesource.com/977059 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#548352}
-
Kenneth Russell authored
It's useful for DrawingBuffer to call out to its Client (typically the WebGL context) to restore its state while it's being destroyed, in order to honor its contract. However, if the WebGL context is also being destroyed, it must not attempt to touch other GC'd objects like WebGLTextures, which it would otherwise do in its DrawingBufferClient methods. Bug: 828525 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I6fa0a24878aeabe94ace17cf9437da667d6583bf Reviewed-on: https://chromium-review.googlesource.com/996800Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#548351}
-
Thomas Anderson authored
This reverts commit 6963de52. Reason for revert: Wanted to land without NOTRY=true Original change's description: > Revert "Disable 2 layout tests after r548309 and add a TODO to reenable them" > > This reverts commit f4132695. > > Reason for revert: Rebaselining and reenabling the tests > > Original change's description: > > Disable 2 layout tests after r548309 and add a TODO to reenable them > > > > BUG=787020 > > TBR=eae > > > > Change-Id: I9931e0f0c73a6a0bb7dbade9c8c189acec1cb9d2 > > Reviewed-on: https://chromium-review.googlesource.com/997174 > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#548331} > > TBR=eae@chromium.org,thomasanderson@chromium.org > > Change-Id: Ifd643ac484dc11bbd4f922bd01445e94b7f88f53 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 787020 > Reviewed-on: https://chromium-review.googlesource.com/997113 > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Emil A Eklund <eae@chromium.org> > Cr-Commit-Position: refs/heads/master@{#548348} TBR=eae@chromium.org,thomasanderson@chromium.org Change-Id: Ibad78cf3b62ec0995708a425d0855449aaf3d04a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 787020 Reviewed-on: https://chromium-review.googlesource.com/997182Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#548350}
-
Fergal Daly authored
https://drafts.csswg.org/css-shadow-parts/ Tests cover the following: - Simple - Part in selected host is styled - Host Stylesheet - Part in selected host is not styled by ::part in a stylesheet inside the host - Different Host - Part is not styled when host is not selected - Inner Host - Part in outer host is styled by document style sheet - Part in inner host is not styled by document style sheet - Compound Positive - Compound selector for host works - Compound Negative - Non-matching compound selector for host does not style - All Hosts - ::part with host selector styles in first host - ::part with host selector styles in second host - Chaining Negative - ::part cannot be chained to reach elements in the inner host Bug: 805271 Change-Id: I8c16ae09547bd833dbcc1eb0afb8be91a40c0a8e Reviewed-on: https://chromium-review.googlesource.com/983833 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Cr-Commit-Position: refs/heads/master@{#548349}
-
Tom Anderson authored
This reverts commit f4132695. Reason for revert: Rebaselining and reenabling the tests Original change's description: > Disable 2 layout tests after r548309 and add a TODO to reenable them > > BUG=787020 > TBR=eae > > Change-Id: I9931e0f0c73a6a0bb7dbade9c8c189acec1cb9d2 > Reviewed-on: https://chromium-review.googlesource.com/997174 > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#548331} TBR=eae@chromium.org,thomasanderson@chromium.org Change-Id: Ifd643ac484dc11bbd4f922bd01445e94b7f88f53 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 787020 Reviewed-on: https://chromium-review.googlesource.com/997113 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
Misha Efimov authored
Bug: 828899 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I14000553e3164529bcf11d7aadf38ceb8f76c01e Reviewed-on: https://chromium-review.googlesource.com/995636Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Julia Tuttle <juliatuttle@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#548347}
-
Timothy Loh authored
This patch extends the Crostini App Registry to record: - Localized names - Localized comments - Mime types - VM/Container name The launcher items are updated to use localized names, and the concierge call now passes the actual VM and container names. We also change the "app_id" we use for Crostini apps to also include these names, which should allow us to have multiple icons for an app installed in multiple containers. Bug: 821662 Change-Id: I47e4da783c987a026b09decc6a67612fff3f55de Reviewed-on: https://chromium-review.googlesource.com/995115 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#548346}
-
Tom Sepez authored
These add coverage and replace some of the existing layout tests with a more efficient method of testing. Tidy a comment in HTTPParsers.h while we're at it. Change-Id: Idae90404bbd43de2e15a0442c16801079f38c4cc Reviewed-on: https://chromium-review.googlesource.com/982750 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
-
Lei Zhang authored
https://pdfium.googlesource.com/pdfium.git/+/75f84a56 changed the PDFium rendering APIs to let callers better control how forms are drawn. The path for low quality printing / print as image never got updated. BUG=825985,pdfium:594 Change-Id: I36658f651da3911034648651c6118acbd4050712 Reviewed-on: https://chromium-review.googlesource.com/985133Reviewed-by:
dsinclair <dsinclair@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#548344}
-
Dominick Ng authored
BUG=824598 TBR=sky@chromium.org Change-Id: I09ac08a2042efffb8562b6a0d9764fdaa6231ff1 Reviewed-on: https://chromium-review.googlesource.com/991619 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#548343}
-
Sammie Quon authored
TBR=oshima@chromium.org Bug: 827435 Change-Id: I7d2fbf3869dbf8f3c14f386436a57f17def3bbf0 Reviewed-on: https://chromium-review.googlesource.com/997176Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#548342}
-
Jennifer Apacible authored
This change removes some a duplicate function to enable Picture in Picture for LayoutTests. It also consolidates TestExpectations and moves the existing tests to the same directory. BUG: 726619 Change-Id: I5f46bb6886ac9b88bb2bd23a2c38fe77ead00ace Reviewed-on: https://chromium-review.googlesource.com/994256 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
-
Kent Tamura authored
- Add event dispatching code to blink::FormSubmission -- Add isConnected() check after FormSubmission creation - Add event dispatching code to blink::FormData constructor - Add onformdata IDL attribute - Add onformdata content attribute The next CL will add tests. Bug: 825684 Change-Id: I43a03284a0206a71828dc420119562cdd177c0c2 Reviewed-on: https://chromium-review.googlesource.com/997032Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#548340}
-
Alexandre Courbot authored
Narrow down the set of watched files a bit. BUG=None Change-Id: I5f90948260fa1d588c3ba78fbc984a786fff72a4 Reviewed-on: https://chromium-review.googlesource.com/994435Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#548339}
-
David Tseng authored
It is sometimes necessary to distinguish among the three states of the selected attribute: - true: a node is selected (e.g. an option) - false: a node is unselected - undefined: the node is not meant to be selected The |selectable| state is implied by the first two values for selected. With this change, a client can trust that a control is *not* selected rather than not supporting selection. On the author side, (e.g. a views author), one does not need to remember to set selectable state along with the actual selected state. In ChromeVox, we sometimes want to speak the items which are selected (in the case of cells, for Sheets). However, in the common case, which is when selection follows focus, it is extremely verbose to speak selected. Instead, only speak items which are unselected. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iaf76784664a72ff7c99fff4ebf35f9b798b34cec Reviewed-on: https://chromium-review.googlesource.com/985473 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#548338}
-
Lei Zhang authored
Change-Id: Ifb231fe7f7b686c417cecc3cad6534239bec5066 Reviewed-on: https://chromium-review.googlesource.com/996315Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#548337}
-
tzik authored
This converts storage::FileSystemOperationRunner::operations_ from base::IDMap to std::map. All other users of base::IDMap don't store null value to base::IDMap, and the null value makes the interface of base::IDMap complex. So, this removes base::IDMap from FSOR as a preparation to refactor IDMap. Change-Id: I65b81ead88133b9ac5ea724af53df67b812e0fde Reviewed-on: https://chromium-review.googlesource.com/995652Reviewed-by:
-
Darren Shen authored
TBR=asanka@chromium.org Bug: 828954 Change-Id: Ifb43987ec0e7e892e6655d4f1469b57daae50be6 Reviewed-on: https://chromium-review.googlesource.com/997055Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/447b127a..77df816c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ic046c842c51db3736311c6d2d96c2db8ea797561 Reviewed-on: https://chromium-review.googlesource.com/996992Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#548334}
-
https://pdfium.googlesource.com/pdfium.git/+log/dc566b0a76f9..32942201a456 $ git log dc566b0a7..32942201a --date=short --no-merges --format='%ad %ae %s' 2018-04-04 hnakashima Caret blinks with lower frequency in XFA text field. 2018-04-04 fdegans Prepare for |is_posix| switch in the Fuchsia build 2018-04-04 rharrison Expand ~ when present in directory path Created with: roll-dep src/third_party/pdfium BUG=chromium:812974 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I3d406862bf3646ba6b53d031eb7b5172c169fbda Reviewed-on: https://chromium-review.googlesource.com/996307Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#548333}
-
