GitLab

StructTraitsTest for events and latency were removed from the build by
accident in https://codereview.chromium.org/2783973002.

BUG=686865

Review-Url: https://codereview.chromium.org/2802923002
Cr-Commit-Position: refs/heads/master@{#462902}

Reporting is a spec for delivering out-of-band reports from various
other parts of the browser. See http://wicg.github.io/reporting/ for
the spec, or https://goo.gl/pygX5I for details of the planned
implementation in Chromium.

This CL takes the pile of small classes that I've written so far and
wraps them in a single "context" object.

It also changes the classes to accept a pointer to the context instead
of several pointers to individual dependencies.

It *also* creates a ReportingTestBase class that provides a properly
configured context for all of the existing unittests to use, and
switches the tests over.

BUG=704259

Review-Url: https://codereview.chromium.org/2751103002
Cr-Commit-Position: refs/heads/master@{#462901}

Also, re-enables switching from sw to accelerated canvas.

BUG=704571

Review-Url: https://codereview.chromium.org/2799033002
Cr-Original-Commit-Position: refs/heads/master@{#462706}
Committed: https://chromium.googlesource.com/chromium/src/+/2f0fa56eb8fc2eee27d437e7b6c8038ba5a52d87
Review-Url: https://codereview.chromium.org/2799033002
Cr-Commit-Position: refs/heads/master@{#462900}

While we work on being able to relay all response headers from the
download system to the created Response object for Background Fetch,
these two will enable some minimum experimentation.

BUG=692579, 709489

Review-Url: https://codereview.chromium.org/2805813006
Cr-Commit-Position: refs/heads/master@{#462899}

We explicitly pass that in official builds now, and after we've built and
rolled in a compiler with this change here, we'll no longer ask the linker
to generate a build id in unofficial builds (where it's not needed), which
should speed up links a bit.

BUG=622775

Review-Url: https://codereview.chromium.org/2784423003
Cr-Commit-Position: refs/heads/master@{#462898}

By having BucketRanges keep a reference to where the data can be found
in persistent memory, the existing de-dup of the BucketRanges object
also serves to avoid duplicating the data in persistent memory.

Simple testing shows allocated persistent histogram memory in the
browser is reduced by about 22%.  This should be similar in all
processes though somewhat less as the number of histograms held goes
down.

BUG=705342

Review-Url: https://codereview.chromium.org/2794073002
Cr-Commit-Position: refs/heads/master@{#462897}

about_flags.cc today opt in/out configurations manually, rather
than using the existing ENABLE_NATIVE_NOTIFICATIONS build flag.

This fixes the OZONE/Linux build.

BUG=676220
R=thomasanderson@google.com

Review-Url: https://codereview.chromium.org/2802243002
Cr-Commit-Position: refs/heads/master@{#462896}

Disabling tests:
 - CrSettingsNonExistentRouteTest.All
 - SettingsSiteSettingsPageBrowserTest.labels
 - SettingsBasicSubPageBrowserTest.SubPages

BUG=709442
TBR=tommycli@chromium.org

Review-Url: https://codereview.chromium.org/2808473002
Cr-Commit-Position: refs/heads/master@{#462895}

This test (and possibly the others in this set) are
flaky on Mac.

BUG=709504
TBR=sky@chromium.org

Review-Url: https://codereview.chromium.org/2805533006
Cr-Commit-Position: refs/heads/master@{#462894}

Due to complexity between user gesture and vibrate, we decided to remove vibrate from V1 feature policy.

Review-Url: https://codereview.chromium.org/2801153002
Cr-Commit-Position: refs/heads/master@{#462893}

input image.

The pixels that are chosen are evenly distributed throughout the image.

This proved to be more effective than limiting the color space (i.e. the
number of unique colors).

On at least one large sample wallpaper and my workstation, this reduces
runtime from hundreds of ms to <10ms.

BUG=687852

Review-Url: https://codereview.chromium.org/2797033002
Cr-Commit-Position: refs/heads/master@{#462892}

For LargeIconService, we need to access Content-Location header for
images fetched by ImageFetcher. This CL reveals HttpResponseHeaders* in
image_fetcher::RequestMetadata.

BUG=644102

Review-Url: https://codereview.chromium.org/2793983002
Cr-Commit-Position: refs/heads/master@{#462891}

The previous implementation of nativeValue() for IDL interfaces and callback
functions simply called implTypeWithCheck() (or create() for callback
functions) and returned its value. This meant it was not possible for
callers to easily distinguish a nullptr returned here (meaning the
conversion failed) from nullptr being returned by a nativeValue() call for
another type (which can just be a nullptr).

BUG=690428
R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org

Review-Url: https://codereview.chromium.org/2802223002
Cr-Commit-Position: refs/heads/master@{#462890}

- Keep the current |PPB_Audio| interface unchanged
- Add a new dev interface: |PPB_AudioOutput_Dev|
- Implement |PPB_AudioOutput_Dev| using the typical HostResource
  implementations like |PPB_AudioInput_Dev|
- Add ppapi/proxy/audio_output_resource.h/cc etc. to implement
  |AudioOutputResource|
- Add content/renderer/pepper/pepper_audio_output_host.h/cc etc.
  to implement |PepperAudioOutputHost|
- Keep ppb_audio_proxy.h/cc, ppb_audio_shared.h/cc, ppb_audio_impl.h/cc
  unchanged, so that the current |PPB_Audio| will not be affected.
- Modify content/renderer/pepper/pepper_platform_audio_output.h/cc to
  accept both |AudioHelper| and |PepperAudioOutputHost| clients
- The way to implement |PepperAudioOutputHost| is borrowed from
  "media/audio/audio_output_device.cc" where audio output selection isi
  supported for javascript.
- Add necessary IPC message definitions for |PPB_AudioOutput_Dev|

BUG=701584
R= bbudge@chromium.org, tsepez@chromium.org, isherman@chromium.org

Review-Url: https://codereview.chromium.org/2755613002
Cr-Commit-Position: refs/heads/master@{#462889}

When the buffer for a ConvolverNode is set, the number of outputs
needs to be reconfigured based on the number of channels in the
response buffer.

BUG=709150
TEST=Convolver/convolver-response-4-chan.html

Review-Url: https://codereview.chromium.org/2799993002
Cr-Commit-Position: refs/heads/master@{#462888}

The ChromeMediaRouterDialogController now reports when the source URN is
not supported so that the native side can reject the PresentationRequest
correctly.
CastMediaRouteProvider now reports no sinks available if the source URN
is not supported or if Android MediaRouter's API are not present (like
on JB MR1). For the latter, we now do create ChromeMRP when MediaRouter
is null and check if it's null before using (was already checked
everywhere, except for one spot changed in this CL).

BUG=706882
TEST=manual at https://googlechrome.github.io/samples/presentation-api/

Review-Url: https://codereview.chromium.org/2783363002
Cr-Commit-Position: refs/heads/master@{#462887}

As part of enrollment, the firmware management parameters (FWMP)
partition from TPM has to be set including the flags to mark if the
devmode is blocked. The update has to be done before the TPM is locked
but after the policy is retrieved.

It is implemented by including additional step in enrollment process
that makes the D-Bus call to cryptohome to set the data in FWMP.

Similarly when the device is deprovisioned, the firmware management
parameters are removed from TPM when it is established that it is a
consumer owned device.

BUG=685144

Review-Url: https://codereview.chromium.org/2727713003
Cr-Commit-Position: refs/heads/master@{#462886}

This argument was optional until r462215.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2804913006
Cr-Commit-Position: refs/heads/master@{#462885}

BUG=564904

Review-Url: https://codereview.chromium.org/2596653002
Cr-Commit-Position: refs/heads/master@{#462884}

See https://w3c.github.io/webappsec-csp/#external-hash

Intent to Implement and Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/t2ai4lsHhWI/MndrZyEWCwAJ

BUG=706380

Review-Url: https://codereview.chromium.org/2784753003
Cr-Commit-Position: refs/heads/master@{#462883}

BUG=none

Review-Url: https://codereview.chromium.org/2792823002
Cr-Commit-Position: refs/heads/master@{#462882}

Blink has been using LayoutUnit(-1) to represent indefinite sizes or more in
general, sizes that cannot be resolved. That's unfortunate because it forces
us to use that magic number and also because negative LayoutUnits are valid
outcomes of some operations.

In our particular case, that was forcing us to check the SizingOperation
argument in the GridTrackSizingAlgorithm to know whether the passed
available and free sizes where actually indefinite or not. Actually that was
not totally correct as this was based on the assumption that we were doing
intrinsic size computations (preferred widths) whenever the sizes where
indefinite which is not correct for all the cases (it's true for widths but
a height:auto grid container would have indefinite height and require
indefinite size computations).

This does not require any additional tests as we are not changing any
behaviour. It's a step forward in the process of decoupling the concepts of
definite/indefinite sizes and intrinsicSize/layout operations.

Review-Url: https://codereview.chromium.org/2808453002
Cr-Commit-Position: refs/heads/master@{#462881}

Adjust the ownership of the instances used by most unit test fixtures.
The test Shell owns CLC as the ShelfDelegate, just like in production.
Fix up test helper functions and remove ProxyShelfDelegate.

Make BrowserWithTestWindowTest::TearDown more like production shutdown.
(first tear down the browser instance, then the Shell, then the profile)
Remove DestroyBrowserAndProfile, inline/recreate similar behavior.

Add a workaround for DefaultApps test teardown crash (crbug.com/709297).

BUG=557406
TEST=Automated tests still pass; more closely match production.
R=jamescook@chromium.org,sky@chromium.org

Review-Url: https://codereview.chromium.org/2804913002
Cr-Commit-Position: refs/heads/master@{#462880}

https://pdfium.googlesource.com/pdfium.git/+log/0e5d892fe86d..03c5e1725be9

$ git log 0e5d892fe..03c5e1725 --date=short --no-merges --format='%ad %ae %s'
2017-04-07 npm Gitignore jinja2 and markupsafe

Created with:
  roll-dep src/third_party/pdfium

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2805243002
Cr-Commit-Position: refs/heads/master@{#462879}

The status bar's color would incorrectly switch when changing tab
models in the tab switcher due to tab's onShow being called. The
tab switcher logic was not handled correctly since the Chrome Home
test existed in ChromeActivity instead of ChromeTabbedActivity;
this change moves that logic.

This change also adds a special case for the incognito NTP, since
that page is completely dark, that status bar should be too.

BUG=708680

Review-Url: https://codereview.chromium.org/2803673003
Cr-Commit-Position: refs/heads/master@{#462878}

Review-Url: https://codereview.chromium.org/2807523003
Cr-Commit-Position: refs/heads/master@{#462877}

1. Update default from 640x480 to 2880x1800. The goal is to use the native
screen resolution as default, but this is an improvement over the current
situation.
2. If a maximum resolution constraint is given, use that as default instead
of the hardcoded default. This makes the algorithm more compatible with
existing applications without breaking compatibility with the spec.

BUG=257097,709345

Review-Url: https://codereview.chromium.org/2806703002
Cr-Commit-Position: refs/heads/master@{#462876}

BUG=706118

Review-Url: https://codereview.chromium.org/2803943006
Cr-Commit-Position: refs/heads/master@{#462875}

If the users taps an offline url that does not match an entry, an error
message should be displayed.

BUG=703393

Review-Url: https://codereview.chromium.org/2800673002
Cr-Commit-Position: refs/heads/master@{#462874}

This CL changes the font of the fallback monogram of the favicons of suggested
articles, making it bigger and medium instead of regular.

BUG=none

Review-Url: https://codereview.chromium.org/2801323002
Cr-Commit-Position: refs/heads/master@{#462873}

Suborigins are supposed to make script from different suborigin
namespaces inaccessible to each other. canAccess (in spec terms
same-origin domain) is supposed to do that, so just fold the two
together

BUG=336894
R=mkwst@chromium.org

Review-Url: https://codereview.chromium.org/2805683005
Cr-Commit-Position: refs/heads/master@{#462872}

The reason for using the thick version of the progress bar was to make
it more visible against a black status bar. With recent Chrome Home
changes, the status bar is a much lighter color making the progress
bar easy to see and eliminating the need for it to be as large. This
change reduces the progress bar size for android M and above since
these versions allow themed status bars.

BUG=708680

Review-Url: https://codereview.chromium.org/2806633002
Cr-Commit-Position: refs/heads/master@{#462871}

These lint picks were noticed in the merge
https://codereview.chromium.org/2801603003/. I am putting the lint picks
into a separate issue because the original issue is big enough as is.

BUG=488484

Review-Url: https://codereview.chromium.org/2799913003
Cr-Commit-Position: refs/heads/master@{#462870}

When the shelf is in autohide, the shelf does not hide after launching from overflow shelf. This is because the overflow shelf remains visible after lauching an app, which this CL fixes.

BUG=625924
TEST=manual,ash_unittests --gtest_filter="ShelfViewTest.*"

Review-Url: https://codereview.chromium.org/2807473003
Cr-Commit-Position: refs/heads/master@{#462869}

- Initialize the URL request context getter on the IO thread.
- Initialize the response type to Default to match a DCHECK.
- Don't double initialize the fetches in BackgroundFetchedEvent

BUG=692579

Review-Url: https://codereview.chromium.org/2806713002
Cr-Commit-Position: refs/heads/master@{#462868}

Revert of Use dropdown list for admin areas in pr form. (patchset #18 id:1000001 of https://codereview.chromium.org/2680143002/ )

Reason for revert:
The patch causes chrome_public_test_apk failing on chromium.android/Marshmallow Tablet Tester: crbug.com/709491.

Original issue's description:
> Use drop-down list for admin areas (state, province, ..)
>
> -- In the payment request form (instead of the previous text-field).
>
> - For this purpose, the rules of the specified country are loaded from
>  the i18n aggregate server, and the country's sub-keys are retrieved from the right rule.
>
> - If the server doesn't respond, or there is a time-out, or if no
>   admin areas are recorded for that country, show text-field.
>
>    -- Add all the fields to the form, only when admin areas are loaded.
>       This way we can have the fields in order. Otherwise, admin areas
>       would show up at the end (since they are fetched asynchronously.)
>
> - In the Payment Request tests, the admin area field would always be a
>   text field (and not a drop down). This way, the tests would be
>   independent of the network connection state.
>
> - Tests were added to the AddressValidatorTest according to the
>   changes.
>
> BUG=675634
>
> Review-Url: https://codereview.chromium.org/2680143002
> Cr-Commit-Position: refs/heads/master@{#462611}
> Committed: https://chromium.googlesource.com/chromium/src/+/69b196d676ecbbb986009aaf9f5627fd6e332de1

TBR=sebsg@chromium.org,mathp@chromium.org,rouslan@chromium.org,dfalcantara@chromium.org,parastoog@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=675634

Review-Url: https://codereview.chromium.org/2800013004
Cr-Commit-Position: refs/heads/master@{#462867}

This method only sets the color for non-disabled states:
https://cs.chromium.org/chromium/src/ios/third_party/material_components_ios/src/components/Buttons/src/MDCButton.h?l=69

BUG=602666

Review-Url: https://codereview.chromium.org/2802033002
Cr-Commit-Position: refs/heads/master@{#462866}

This also applies when the element isn't contained by a multicol container
(which means that we shouldn't require the spanner placeholder to be present).

BUG=709362

Review-Url: https://codereview.chromium.org/2799363003
Cr-Commit-Position: refs/heads/master@{#462865}

Revert of memory-infra: Fill the memory dump callback result (2/2) (patchset #6 id:100001 of https://codereview.chromium.org/2766173003/ )

Reason for revert:
Causing build failure:
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests/builds/54494

Original issue's description:
> memory-infra: Fill the memory dump callback result (2/2)
>
> Fill in the part of the memory dump result struct
> that applies to OS's view of Chrome when finalizing
> a memory dump.
>
> BUG=703184
>
> Review-Url: https://codereview.chromium.org/2766173003
> Cr-Commit-Position: refs/heads/master@{#462849}
> Committed: https://chromium.googlesource.com/chromium/src/+/22fd5f0cf18a409dd72b96cb526a25a6cac88d24

TBR=primiano@chromium.org,fmeawad@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=703184

Review-Url: https://codereview.chromium.org/2806553005
Cr-Commit-Position: refs/heads/master@{#462864}

The timeline width seems to differ. https://crbug.com/709483 tracks
re-enabling these.

BUG=709483
TBR=mlamouri@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2802233002
Cr-Commit-Position: refs/heads/master@{#462863}