GitLab

This is a reland of 4a4f53a7

The original patch would fail to build on the mksnapshot step on
Windows 7 (and server equivalents). This was due to two APISet DLLs
that are required for the new dbghelp.dll. This change copies the two
of them during gn gen. In order to have them as part of the isolates
for cdb and in order to avoid dangerous ambiguity they are now
required, which means that when this change lands the new SDK will be
required. This is slightly disruptive for developers who aren't using
our toolchain, but it seems unavoidable.

Developers who don't have the latest SDK installed will hit this error
message during gn gen:

 Exception: api-ms-win-downlevel-kernel32-l2-1-0.dll not found in "..."
 You must install the "Debugging Tools for Windows" feature from the
 Windows 10 SDK, the 10.0.19041.0 version.

Original change's description:
> New toolchain for Windows 10 19041 SDK
>
> This change updates the toolchain package used to build Chromium with
> the 10.0.19041.0 (2020-04) SDK and VS 16.6.1. The d3dcompiler_47.dll
> DLLs for x86 and x64 were swapped out for the 10.0.17134 versions (as
> usual).
>
> The Debuggers directory was not swapped out this time because the
> problem with loading dbghelp.dll on Windows 7
> (https://crbug.com/1021650) has been resolved.
>
> The output for the cdb copy step was updated because one additional UCRT
> DLL is now copied.
>
> Packaging was done on a Windows Server 2019 VM, cleanly created for this
> purpose.
>
> The package was created by downloading the VS Professional 2019
> installer from https://visualstudio.microsoft.com/downloads/
> (free trial, not preview) and then running the installer like this:
>
> $ PATH_TO_INSTALLER.EXE ^
>     --add Microsoft.VisualStudio.Workload.NativeDesktop ^
>     --add Microsoft.VisualStudio.Component.VC.ATLMFC ^
>     --add Microsoft.VisualStudio.Component.VC.Tools.ARM64 ^
>     --add Microsoft.VisualStudio.Component.VC.MFC.ARM64 ^
>     --includeRecommended --passive
>
> Then the latest Windows 10 SDK was downloaded and installed from
> https://developer.microsoft.com/en-us/windows/downloads/windows-10-sdk/
>
> Then the packaging script was run like this:
>
>   python3 depot_tools\win_toolchain\package_from_installed.py 2019 -w 10.0.19041.0
>
> Since the new d3dcompiler_47.dll uses the UCRT and we want to avoid
> shipping that (https://crbug.com/920704) the final packaging step was to
> unzip the package, copy over the two copies of that DLL from the
> previous toolchain's win_sdk\Redist, and then repackage the toolchain
> with:
>   > python3 package_from_installed.py --repackage=<full-path-to-toolchain-dir>
>
> UWP and ARM64 support and Python 3 compatibility were previously added
> to package_from_installed.py.
>
> Future changes will require the new SDK, but for now the previous SDK
> can also be used to build Chromium.
>
> The failures on the win*msvc* bots are unrelated. This was proven by
> creating crrev.com/c/2245914 which is a NOP toolchain test. The existing
> toolchain was repackaged with a single text file added and that caused
> identical failures.
>
> Bug: 920704, 1014701, 10216507, 1089996
> Change-Id: Ie496354582458aa8c1292ed4ef63d949ee2eb15d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225224
> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
> Reviewed-by: Henrik Andreasson <henrika@chromium.org>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#778924}

Bug: 920704, 1014701, 10216507, 1089996, 1095767
Change-Id: I75e7653d57964e2929106e41b3f50594d3969e5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249394Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Jesse McKenna <jessemckenna@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780431}

https://chromium.googlesource.com/webm/libvpx.git/+log/5174eb5b9236..769129fb29fc

$ git log 5174eb5b9..769129fb2 --date=short --no-merges --format='%ad %ae %s'
2020-06-18 marpan vp9-rtc: Fix to resetting drop_spatial_layer
2020-06-17 marpan vp9-rtc: Fixes to resizer for real-time
2020-06-16 marpan vp9-svc: Add svc test for denoiser and dynamic resize

Created with:
  roll-dep src/third_party/libvpx/source/libvpx
R=jzern@google.com

Change-Id: Ic46eb8d417f4f9949f8b17bd12d4bb7e100831de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253133Reviewed-by: James Zern <jzern@google.com>
Commit-Queue: Jerome Jiang <jianj@google.com>
Cr-Commit-Position: refs/heads/master@{#780430}

These tests record traffic from a particular moment in time and
override the time in the browser on replay to the recorded time.

This change also has the replay override the AutofillClock so that tests
will continue to work even if credit card info or other info is past the
real life time.

Bug: 1090042
Change-Id: I8964ae1818b9a64c9a7417a7aec628d053a8bfa8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248346
Commit-Queue: Ian Struiksma <ianstruiksma@google.com>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780429}

Somewhat glitchy filtering has been added.
* Type in a package name (exact match) and click "Add" to add to filter.
* Click on any filter in the list to remove it.
Known issues:
* Locked nodes no longer appear locked when a filter is added/removed.
* Zoom/pan is reset when a new filter is added/removed.

These issues are mostly because of the way we interact with the d3
graph. A big upcoming TODO is to rework `renderGraph` into an API of
sorts which will give us finer control over what parts of the graph to
rerender, if nodes should keep their metadata (position, lock) upon
rerendering, etc.

This commit also pulls in and uses Vue.js via a CDN for the current
prototyping work. We will likely install via npm in the future.

Bug: 1093962
Change-Id: Ide0b6a649424deac56e2f4d8121b0029d9286e7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252378
Commit-Queue: James Long <yjlong@google.com>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780428}

TimeTicks::Now() is fairly cheap but not calling it twice is even
cheaper.

This CL is expected to have no functional impact.

Change-Id: I3b230d1ff22d29e88b594205c825bcbe68b6f558
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252746
Auto-Submit: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Sam Goto <goto@chromium.org>
Commit-Queue: Sam Goto <goto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780427}

If the file just needs the CHECK/CHECK_OP/NOTREACHED
macros, use the appropriate header for that instead.
Or if logging.h is not needed at all, remove it.

This is both a nice cleanup (logging.h is a big header,
and including it unnecessarily has compile-time costs),
and part of the final step towards making logging.h no
longer include check.h and the others.

Bug: 1031540
Change-Id: I1c26806fd85d59246594b2d206267b9575f3cf8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254761
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780426}

Hide the controls when the lock screen is created as a result of
closing lid and in suspend state already.

Bug: 1097101
Change-Id: Ifb1f92bc054c7278992d95c13d5f5e5d750c94c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254468
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Auto-Submit: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780425}

These functions provide a way to get at a LocalDOMWindow/LocalFrame
that works for attached Documents and Documents loaded via HTML imports,
but not other Documents (e.g., Documents created by
document.implementation.createHTMLDocument). A few callers genuinely
require this distinction between HTML import Documents and other
non-attached Documents, but most don't.

Bug: 1029822
Change-Id: I7bc23df7eca2b8bd1872e99b06249c1753c6af3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242384Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780424}

Add direct includes for things provided transitively by logging.h
(or by other headers including logging.h).

This is in preparation for cleaning up unnecessary includes of
logging.h in header files (so if something depends on logging.h,
it needs include it explicitly), and for when logging.h no longer
includes check.h, check_op.h, and notreached.h.

Bug: 1031540
Change-Id: Ib0673654853166ba85d84113357d1dbf40ef466f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252147
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780423}

This fixes an issue where both the New Tab Page and Chrome OS Settings
independently included generated .mojom files from the same directory,
which in some cases caused a race condition which broke the build.

Fixed: 1096255
Change-Id: I68c6bff99167025aea68effcecb1fc22d29e61fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251163
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780422}

If the file just needs the CHECK/CHECK_OP/NOTREACHED
macros, use the appropriate header for that instead.
Or if logging.h is not needed at all, remove it.

This is both a nice cleanup (logging.h is a big header,
and including it unnecessarily has compile-time costs),
and part of the final step towards making logging.h no
longer include check.h and the others.

Bug: 1031540
Change-Id: I06efc96d246fa1b34088e8e23d5f79095aacb61d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254759
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780421}

Remove unused gpu::GpuMemoryBufferFactory* from VideoDecoderPipeline

Bug: 1040291
Change-Id: I122f5141d0892aa31ed84d78a74ce4c65edc76e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254445
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Auto-Submit: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780420}

This would improve performance when reading these files.

Bug: b/158337735
Change-Id: I8fdf05c4cff2c05b7f717cd8c8d1b0189c9f6f69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236242Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780419}

If the file just needs the CHECK/CHECK_OP/NOTREACHED
macros, use the appropriate header for that instead.
Or if logging.h is not needed at all, remove it.

This is both a nice cleanup (logging.h is a big header,
and including it unnecessarily has compile-time costs),
and part of the final step towards making logging.h no
longer include check.h and the others.

Bug: 1031540
Change-Id: I88a9ca7c6ffd492c741bfbf067c4e006589e8e7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254661
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780418}

https://chromium.googlesource.com/openscreen.git/+log/dd945dd1c033..64150e03b378

2020-06-19 rwkeane@google.com DnsSd: Move DnsDataGraphImpl to .cc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/openscreen-chromium
Please CC jophba@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jophba@chromium.org
Change-Id: Iba74e915c0533a4618dee1e4ec32646cdbb6a93d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254730Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#780417}

We have two reports of "Invalid render pass ID" deserialization
failures. Change the DCHECK to CHECK for valid render pass id to catch
these earlier.

Bug: 1072407
Change-Id: I6f3895fc67b82935b2ea393308f6c256e9826867
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254440Reviewed-by: weiliangc <weiliangc@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780416}

The wptrunner output file contains a "screenshots" artifact which is a
list of files that were screenshotted, and the base64-encoded png of the
screenshot that was taken. We extract and decode these pngs and write
them to disk. The redundant data is then scrubbed from the output file
and replaced with the path to the newly-created file.

Bug: 937369
Change-Id: Ifeff993023219833e65af39548f556b54ac65b60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252682
Commit-Queue: Luke Z <lpz@chromium.org>
Reviewed-by: Rakib Hasan <rmhasan@google.com>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780415}

Bug: 1062619
Change-Id: If542ea96db20edf083b6ad74cdf0cf3bac7ae4e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198549
Commit-Queue: Ali Juma <ajuma@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780414}

Roll Chrome Win32 PGO profile from chrome-win32-master-1592571521-6d5e90687ec4debf3bbc06836041d35bc022b0d5.profdata to chrome-win32-master-1592578171-4cc99c312b5fc0958eac23d37e6dd9daa0e9f873.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win-chrome
Tbr: jeffyoon@google.com,liaoyuke@google.com
Change-Id: I7fd1768c48afc64b9cfa5d4a7eeb0873fb1a6ace
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254726Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#780413}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d43ba60f648c..d044efb50daa

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC aaronhk@google.com,btolsch@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: aaronhk@google.com,btolsch@google.com
Change-Id: I7f0d622fdb86608d6339193de0fe283c82cf3660
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254722Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Reviewed-by: Aaron Krajeski <aaronhk@chromium.org>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#780412}

I refactored the chrome code, so the WebLayer copy is no longer
necessary.

BUG=none
TEST=none

Change-Id: I191b3159ec92355ff4ef6014c245f811226e491e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254666Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780411}

This should make the code structure more clear.

Bug: 1096235
Change-Id: Ie84293a0ffad11eb79301c638299e23aaa2522f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250704Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780410}

If the file just needs the CHECK/CHECK_OP/NOTREACHED
macros, use the appropriate header for that instead.
Or if logging.h is not needed at all, remove it.

This is both a nice cleanup (logging.h is a big header,
and including it unnecessarily has compile-time costs),
and part of the final step towards making logging.h no
longer include check.h and the others.

Bug: 1031540
Change-Id: I63140c7aa4915f7c24085ec7a97b2e7320e87bf3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254778
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780409}

Switches the NaCL Python tests to use the version of mock/pymock
provided by vpython instead of manually importing the version from
//third_party/pymock. This is so that the //third_party version can
eventually be removed.

Also drive-by fixes some unidiomatic-typecheck PyLint warnings that
presubmit complained about.

Bug: 1094489
Change-Id: I886a9eaa9130c8babbefc40281c0de7f984026c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254583
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Sam Clegg <sbc@chromium.org>
Reviewed-by: Sam Clegg <sbc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780408}

Move FullscreenManager and FullsreenOptions to
//chrome/browser/fullscreen.

Bug: 995914
Change-Id: I013852910ce3ff34aa532582e61dd9e2fe167802
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252025
Commit-Queue: Theresa  <twellington@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780407}

The presubmit input API provides local path names in the OS's native
format. The mojom compatibility checking script effectively assumes
POSIX format. This leads to various wonderful forms of failure whenever
paths are used to represent module identity in scripts.

In this case, mismatches between changed input file paths and mojom
import paths can result in the stability checking tool using the newer
(i.e. post-change) version of an input file when processing the older
(pre-change) contents of other files. This can obviously lead to very
surprising behavior like missing type information.

In the limit we should be using pathlib to manipulate paths consistently
across platforms. For now, this change settles on rewriting the tool's
input paths to be in POSIX form consistently.

Fixed: 1096841
Change-Id: I4beff9a49d573df3815160e2320097886d94d692
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254709
Auto-Submit: Ken Rockot <rockot@google.com>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#780406}

This CL just cleans up includes, and doesn't actually change any
behavior.

Change-Id: I9e5f5b0f16f940be0c013214a7f649beb74890e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250551
Commit-Queue: Scott Little <sclittle@chromium.org>
Reviewed-by: Megan Jablonski <megjablon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780405}

This reverts commit 2621701f.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 780382 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzI2MjE3MDFmMTc0YTFmMWVmMWMyOGE0N2QzZDY3OWE3YjMzZDA0NzMM

Sample Failed Build: https://ci.chromium.org/b/8877036858738311632

Sample Failed Step: compile

Original change's description:
> Reland "Adds icon loading service with sandbox for Windows."
> 
> This is a reland of c3de1340
> 
> Original change's description:
> > Adds icon loading service with sandbox for Windows.
> >
> > Adds a new |SandboxType::kIconReader| with token and integrity
> > levels that allow PrivateExtractIcon to do its thing. The service is
> > only used for PE files which, as a complex format, should not
> > be parsed in the browser. Other icons are found based only on a
> > file's extension. These are handled in the browser as this is both
> > faster and allows a tighter sandbox to be applied to the PE file
> > parsing. PrivateExtractIcon (a documented but discouraged Windows API)
> > is used instead of SHGetFileInfo as SHGetFileInfo requires COM
> > which considerably weakens sandboxing.
> >
> > Adds basic icon loading test for all platforms.
> >
> > A follow-on CL will add a fallback for PE files for which no embedded
> > icon is available.
> >
> > Testing: adds a unit test for groups, plus
> > manual testing on Windows 7 x86 and Windows 10 x64.
> >
> > Bug: 1032250
> > Change-Id: I6975e5612d8b6f35e3216a67fc98592a45895c1b
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987273
> > Commit-Queue: Alex Gough <ajgo@chromium.org>
> > Reviewed-by: Robert Liao <robliao@chromium.org>
> > Reviewed-by: Will Harris <wfh@chromium.org>
> > Reviewed-by: Avi Drissman <avi@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#779502}
> 
> TBR=robliao@chromium.org
> 
> Bug: 1032250
> Change-Id: I7b5bd3c66ff7c6935939c1f21ef9c45384183522
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252842
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Will Harris <wfh@chromium.org>
> Reviewed-by: Alex Gough <ajgo@chromium.org>
> Commit-Queue: Alex Gough <ajgo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#780382}


Change-Id: I367d0f5483f93f8ccb78f1e5d79a54dabfb6373a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1032250
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254899
Cr-Commit-Position: refs/heads/master@{#780404}

This change is necessary when the message will be targeted at the
WidgetBase in a later CL. This just moves plumbing in an idempotent
CL for review.

BUG=1073560

Change-Id: If33da71b313886d2f3a224977a5c8bc25ba0ef2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245882
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780403}

Change-Id: Idd3f607b111b364f59f71a5e350240ced7c1486e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252040Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780402}

Only the content box should be multiplied by the aspect ratio to derive
the size of a side given the other side and the aspect ratio.

So, subtract the border/padding from the side you have, then multiply to
get the content size, then add that side's border/padding.

Bug: 1094311
Change-Id: Ib69a224cdb369c3fa46f5d432af73eb131781673
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251202Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780401}

This CL is one more step towards unification of classes used on Linux
with X11.

The lower level of the drag and drop on X11 is handling the XDND
protocol, which is done by ui::XDragDropClient; the latter is currently
used for both non-Ozone and Ozone paths, but historically it had been
part of DesktopDragDropClientAuraX11, so there were no tests for it.

Here DesktopDragDropClientAuraX11 tests that in fact test the XDND level
are moved out and test ui::XDragDropClient directly.  The higher level
ones (like, for example, DesktopDragDropClientAuraX11Test.HighDPI200
that tests that the drag widget is moved properly on different scales)
are subject to move to DesktopDragDropClientOzone tests.

Note: a better place for these tests would be perhaps x11_unittests but
they cannot be moved there easily.  We keep that in mind and will try to
address that later.

Bug: 990756
Change-Id: If1905b2abace0db72a6aa8e4d0f0834bdafded81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250104
Commit-Queue: Alexander Dunaev <adunaev@igalia.com>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780400}

Roll Chrome Mac PGO profile from chrome-mac-master-1592568001-2ce2e0984e1a1c64d6f424e415ec04a2dca940b3.profdata to chrome-mac-master-1592589290-7b40bba5d54824ecb168b95970b0e07434b386d4.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:mac-chrome
Tbr: jeffyoon@google.com,liaoyuke@google.com
Change-Id: Ifede94f958d8fc94ea331603cc4047735c16ede6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254729Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#780399}

The origin is used for storage isolation. Now the CDM service should
call a sync mojo API to get the origin from browser process.

Merge-With: eureka-internal/413835
Bug: internal b/159179276
Test: EME on x86
Change-Id: I0dc1292a207b7e05d204436e0f4d45a95857bb34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252636Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Sean Topping <seantopping@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Yuchen Liu <yucliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780398}

* When users click the "Run safety check" button, safety check has a 1s
  delay before it runs the actual safety check. This is done to ensure
  that the "running" state of safety check children is shown to users
  for at least 1s.
* If users reload the Settings page in that 1s delay the browser
  crashes with crbug.com/1096965.
* This fix makes safety check ensure that JS is still allowed after the
  delay, before it runs the actual checks.

Bug: 1096965
Change-Id: I8ab45e4e561ba051a87019d41af3ac7a6c00162e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254138Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Commit-Queue: Rainhard Findling <rainhard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780397}

Change-Id: Ic1e63c2c35d1e5e2add29cccb2e62606317903cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252936Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780396}

User actions are added to breadcrumbs that get attached to crashlogs to
help with steps to repro.

Bug: 1046223
Change-Id: Icf451a5d9bb72557d18555694227dd4e4d0b23b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250705
Auto-Submit: Eugene But <eugenebut@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780395}

If the file just needs the CHECK/CHECK_OP/NOTREACHED
macros, use the appropriate header for that instead.
Or if logging.h is not needed at all, remove it.

This is both a nice cleanup (logging.h is a big header,
and including it unnecessarily has compile-time costs),
and part of the final step towards making logging.h no
longer include check.h and the others.

Bug: 1031540
Change-Id: Ifdb52bdd094e9775d5ea91b9014152b950ccd08c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254147
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780394}

This reverts commit 75355920.

Reason for revert: The tests themselves are good. The culprit
breaking the test framework has been reverted in
a5c17494

Original change's description:
> Disabled external/wpt/editing/run flaky tests
> 
> TBR=xiaochengh@chromium.org
> 
> Bug: 1097000
> Change-Id: I94edbeb778bf35ea18a18412262ef57e4dfbabdf
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252145
> Reviewed-by: Andy Paicu <andypaicu@chromium.org>
> Commit-Queue: Andy Paicu <andypaicu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#780261}

TBR=xiaochengh@chromium.org,andypaicu@chromium.org

Change-Id: I80b2b64d5379ce8973e5ce26f8a030c2d496355b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1097000
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254717Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780393}

Adds feature flag WebUIThemeModeDoodles, which enables showing Doodles
on themed and dark mode NTPs. Furthermore, this CLs implements the dark
mode change protocol for interactive doodles. The protocol looks as
follows:

1. Append theme_messages=0 to the doodle URL. This tells the doodle that
   the mode change messaging protocol with version 0 is enabled.

2. Every time the mode changes postMessage
   {
     cmd: 'changeMode',
     dark: true|false,
   }
   to the doodle.

3. If the doodle postMessages
   {
     cmd: 'sendMode',
   }
   respond with the postMessage from 2. above. This is to work around
   a race condition where the NTP could postMessage the mode before the
   doodle has installed a message listener.

Bug: 688960
Change-Id: Icc1e333f33fd1f01a2c8d1d4a581fdf360ca7090
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253220
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780392}