- 05 Dec, 2019 40 commits
-
-
Changhao Han authored
DevTools CL that changes the expectation: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1934208 Bug: chromium:1025667 Change-Id: I8fa0339ff2c8d743741001c6b75b713fcce68f55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950535Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Changhao Han <changhaohan@chromium.org> Cr-Commit-Position: refs/heads/master@{#721933}
-
Mathias Carlen authored
This patch extends the expiration release of Android.DirectAction.Perform since this metric is still actively being used. R=szermatt@chromium.org Bug: 993082 Change-Id: I9d3b3653c0632b9071cd5e8a9b5d24f83059bee9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948425Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#721932}
-
Raphael Kubo da Costa authored
Follow-up to commit 50c8bd96 ("Make AssociateNextForSameLayoutObject() not to hit DCHECK for list marker"), which has a call that looks like DCHECK(...) << foo; where |foo| is a std::unique_ptr fails with libstdc++ because there is no operator<< overload for std::unique_ptr until C++20 (libc++ just happens to have it): ../../third_party/blink/renderer/core/layout/ng/inline/ng_fragment_items_builder.cc:204:56: error: invalid operands to binary expression ('std::basic_ostream<char, std::char_traits<char> >::__ostream_type' (aka 'basic_ostream<char, std::char_traits<char> >') and 'std::unique_ptr<blink::NGFragmentItem, std::default_delete<blink::NGFragmentItem> >') DCHECK(items_.IsEmpty() || items_[0]->IsContainer()) << items_[0]; ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~ Bug: 957519, 980914 Change-Id: Id9ae7ecf1bcb871c47127816703cf135630808a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950985 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#721931}
-
Colin Blundell authored
As we componentize more blocking pages, it will be convenient to localize their Chrome-specific construction within a single file; these blocking pages need to be created in two places in Chrome's production code (ssl_error_handler.cc and interstitials_ui.cc). This CL provides a place to house these construction functions by generalizing chrome_ssl_blocking_page.*, which already performs exactly this function for SSLBlockingPage. Bug: 1025059 Change-Id: I6365c49aaf7b18c8a834803f4ac91b1332c10d31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948936Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#721930}
-
Maciek Slusarczyk authored
Current implementation of SAML password change flow has 2 issues and does not work for Okta IdP: * Empirically chosen timeout used by Authenticator before communicating injected code on IdP page is too short. As a result injected code sometimes does not know where to send the message back. * Password scraping does not work for Okta since it is based on the number of scraped passwords and Okta has 2 old (the one used to authenticate is re-typed) and 2 updated (new + verified). As a result code is not able to determine how to change local credentials and asks user for confirmation every time. 2 changes has been introduced in order to address the issue: timeout was extended to 2s and new logic based on password field ids replaces existing logic for Okta. Bug: 145206636 Change-Id: I0e5083911fd129e4c04e76c07ef5f90cfa5039e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943140 Commit-Queue: Maciek Slusarczyk <mslus@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#721929}
-
Richard Knoll authored
The new regex uses too many resources to be enabled for all users. To gather experiment data, we will only use it if the flag is enabled. Only then will we compile the regex and run it against the selected text to get false positives and negatives data. Bug: 1029755 Change-Id: I19811328ce445612eea25a5b3d2b518211454469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950522Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#721928}
-
Carlos IL authored
Android webview has an embedding app controlled setting to allow mixed content, this makes it so that setting is followed when deciding whether or not to autoupgrade mixed content to HTTPS. This is covered by existing tests (testAllowMixedMode in AwSettingsTest.java) that will be set to run with the feature before launching. Bug: 1016573 Change-Id: I83c6a3b10a25bda374686537e4df24a17eb8cd6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947950 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#721927}
-
Colin Blundell authored
To componentize CaptivePortalBlockingPage, we are going to move the Chrome-specific elements of its creation into ChromeSecurityBlockingPageFactory. However, that move is currently hindered by the fact that there are two subclasses of CaptivePortalBlockingPage that supply the Wifi info for testing/debugging purposes. This CL eliminates the need for those custom subclasses by instead adding a method to CaptivePortalBlockingPage to override the wifi info for testing. This change will enable the transfer of all //chrome-level creation sites of CaptivePortalBlockingPage to do so via ChromeSecurityBlockingPageFactory in a followup CL. Bug: 1025059 Change-Id: I9b6feaddcb52ee994ecae8dc3ba73c51878d48fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949469 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#721926}
-
Koji Ishii authored
Following bot results are included. 514 515 516 518 519 520 522 524 525 526 527 185 lines were removed and 133 lines were deflaked by consecutive results since 513. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: Ib4ec6cda0656d1f3b3339864383b550d025575fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948689Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e2a516e4d1f2..58f2bae66e8b git log e2a516e4d1f2..58f2bae66e8b --date=short --first-parent --format='%ad %ae %s' 2019-12-05 dberris@chromium.org Add Dashboard-related services to deploy-dashboard 2019-12-05 fancl@chromium.org Log sherrif-config match results when finding anomalies Created with: gclient setdep -r src/third_party/catapult@58f2bae66e8b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:953181 Tbr: sadrul@google.com Change-Id: I2342b0a1aeeee3427ce4d08bc51754a8443fda66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952294Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721924}
-
Michael Achenbach authored
This reverts commit 5656d811. Reason for revert: V8-side was reverted. Need to revert this for API version compatibility: https://crbug.com/1031047 Original change's description: > Emit "function calls in detached window" use counters via UKM > > This change adds use counters for counting V8 function calls in detached > windows. They aren't emitted the usual way, because the use counter > infrastructure doesn't work on detached windows. Instead they're plumbed > through instance counters to be emitted via UKM. > > Bug: 1018156 > Change-Id: I2c85604c9a96b9aec50896a74c089cf5eacfa61d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925839 > Commit-Queue: Bartek Nowierski <bartekn@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Reviewed-by: Primiano Tucci <primiano@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#721875} TBR=primiano@chromium.org,rkaplow@chromium.org,tasak@google.com,haraken@chromium.org,msramek@chromium.org,ssid@chromium.org,bartekn@chromium.org Change-Id: I43797ed4ee07412e384ec94bc915af762e99b988 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1018156,1031047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950992Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#721923}
-
Koji Ishii authored
This patch implements |NGFragmentItem| support for |LayoutObject::PositionForPoint|. When only |Node| is needed (e.g., hovering), |NodeAtPoint| is used, but when text offset is needed (e.g., click), |PositionForPoint| does the work. Clicking on text works now, but draggig doesn't work yet. I'll work in following patches. This includes a semantics change to |NGInlineCursor:: PositionForPoint|. Before this change, it returned the position for the current item/fragment. The problem is that the root |LayoutBlockFlow| cannot be the current item. This patch changes it to return any items where the cursor can traverse. Fixes ~30 failures. Bug: 982194 Change-Id: Ie4f26fcda0ecfd0084afe9ff5272d9f4e682452b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948575 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#721922}
-
Markus Handell authored
Passthrough recording is enabled for video iff 1. mimeType is empty 2. the video source supports encoded output. When passthrough recording is enabled, a key frame is requested from the video source and recording starts when it appears. Bug: 1013590 Change-Id: I8ecd0970d59146336af001232545be42b840e4d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893992Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Markus Handell <handellm@google.com> Cr-Commit-Position: refs/heads/master@{#721921}
-
Kuo Jen Wei authored
Bug: 1012933 Test: For all modes, the border of button and focus ring are fully rounded. Change-Id: I9ab3cd96b5736d0c3c8133444429e7c8f057f9d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949835 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#721920}
-
Carlos IL authored
The new policy disables all changes in mixed content treatment if set, including the Not Secure warning for sites with passive mixed content and autoupgrades for images and videos (see https://blog.chromium.org/2019/10/no-more-mixed-messages-about-https.html for details). Bug: 1029236 Change-Id: I9d4de03ec625e441088a53f526dc2ad59d4e1e13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937034 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Juan Antonio Navarro Perez authored
Bug: 1029008 Change-Id: I8d91b24a8f4a593353ebafd481fd002177abb3e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950511Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#721918}
-
Guido Urdaneta authored
Bug: 1025218 Change-Id: Iacffae47f361b3e8491657cddcc268f1833da29b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950989 Auto-Submit: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Reviewed-by:
Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#721917}
-
Renato Silva authored
When clicking on "Google privacy policy" on the "Google Play apps and services" screen the screen reader will treat the pop up as a modal dialog and disable the navigation on the content behind it. Tested locally. Bug: 1024098 Change-Id: I924232eb7e423d579620146be4270e5ef43afc5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950516Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d056ed33f541..b2d058524db5 Created with: gclient setdep -r src-internal@b2d058524db5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I393781b277b04a705646a654c17531620e016655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952388Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721915}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=inferno@chromium.org Bug: 1023677 Change-Id: I27ecb9e2c6cc7238d5261d021420245056daae2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926947 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#721914}
-
Yan authored
copyImageBitmapToTexture API is part of WebGPU spec that copy image bitmap to a WebGPU texture. This patch adds idl related part for copyImageBitmapToTexture. BUG=966582 Change-Id: I08ffa4f8b42f2b6686bd6d197d9356fa2da241ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899173 Commit-Queue: Shaobo Yan <shaobo.yan@intel.com> Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#721913}
-
Lei Zhang authored
- Split GetApplicationLocaleInternal() so it's more readable. - Use more C++11 features. - Fit nits and lint errors. Change-Id: Iff2e9b3fce4622891ebb39ace03c64d1e7603d2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918163Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#721912}
-
Wanchang Ryu authored
Previously when a image element is invisible, it loads image eagerly for both 'auto' and 'lazy' by https://chromium-review.googlesource.com/c/chromium/src/+/1668710 But when attribute is set 'lazy' explicitly, we can still use lazy loading because lazy loading is intended. Bug: 1027153 Change-Id: Ibb0ad782049c66863d242d929f1e94fa6ddd1ed0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950104Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Wanchang Ryu <wanchang.ryu@lge.com> Cr-Commit-Position: refs/heads/master@{#721911}
-
Hiroshi Ichikawa authored
Bug: 1023250 Change-Id: I2210c0f38619ac8bf051fccf3d912f959c7a0787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939158 Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#721910}
-
Alex Danilo authored
First step in removal of the deprecated progress center. Bug: 1027012 Change-Id: I34ea74d0f56b8a6327dbdf2f6b37c6d5786ac084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952060 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#721909}
-
Christopher Lam authored
This CL removes --cr-toggle-ripple-opacity in favor of specifying opacity in --cr-toggle-ripple-color-checked and --cr-toggle-ripple-color-unchecked. This makes ripple color easier to reason about and allows a clearer point of ripple color override. Bug: 10292245 Change-Id: I9d80c13d0805494cfbc33a58ca002bad5955f16b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940003 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#721908}
-
Noel Gordon authored
CL:1947603 noted how to remove the .dialog-navigation-list dependency from the directory tree _and_ keep its unittest passing. Thus this CL. There are no integration tests of the FilesApp splitter or FilesApp window resize event handling. Add tests for both, and use them to test the tree "clipped" attribute, since it is active in both files-ng and normal FilesApp after this change. Bug: 992819 Change-Id: Id46cbee77fc39bb227f66fc2850ee09a6fe68df8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947620Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#721907}
-
Adrienne Walker authored
Currently, QuotaClient is a raw pointer, jointly owned by QuotaManager and AppCacheServiceImpl, with a complicated keep_alive dance and conditional self-destruction. This is just a drive-by cleanup to get rid of "raw new" calls that looked suspicious and to make the refcounting explicit. Once AppCache gets removed, it seems possible to make QuotaClient to be owned fully by QuotaManager as a unique_ptr. Change-Id: I4df4bda44f51666e99880812c49ff76a7635c13d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949579 Auto-Submit: enne <enne@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#721906}
-
Noel Gordon authored
Bug: None Change-Id: Ief982eb1150918c8f995f6b26332bc594924b856 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950374Reviewed-by:
-
Giovanni Ortuño Urquidi authored
Test is flaky on multiple platforms. It seems to be timing out: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8894975161591307904/+/steps/sync_integration_tests_on__none__GPU_on_Mac__with_patch__on_Mac-10.13.6/0/logs/Flaky_failure:_SingleClientExtensionsSyncTest.StartWithSomeExtensions__status_SUCCESS_TIMEOUT_/0 TBR=mastiz@chromium.org Bug: 1030556 Change-Id: I334eb74f5561360b1fa868ba580748d5265148f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951276Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#721904}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/be9c8b0410e0..e2a516e4d1f2 git log be9c8b0410e0..e2a516e4d1f2 --date=short --first-parent --format='%ad %ae %s' 2019-12-05 dberris@chromium.org PinpointScheduler: Wire the Execution Engine Created with: gclient setdep -r src/third_party/catapult@e2a516e4d1f2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:988912 Tbr: sadrul@google.com Change-Id: I46cc4634c14f8fccf5caa575236171397db58a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952466Reviewed-by:
-
Giovanni Ortuño Urquidi authored
Test seems to be timing out: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8894942310371245376/+/steps/content_browsertests/0/logs/Deterministic_failure:_WebRtcGetUserMediaBrowserTest.RecoverFromCrashInAudioService__status_FAILURE_/0 TBR=guidou@chromium.org Bug: 1031033 Change-Id: I4c9a0856bb58eba535c2d0f9c2052abb52fd98ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951275Reviewed-by:
-
Hitoshi Yoshida authored
Before this CL, ToFlexibleArrayBufferView() expected the given |value| has ArrayBufferView. But in its use cases, all in generated code, we don't check the fact, and instead, check the returned value is empty to throw an exception. FlexibleArrayBufferView var; // No check v8_var->IsArrayBufferView() ToFlexibleArrayBufferView(isolate, v8_var, var); if (var.IsEmpty()) { exception_state.ThrowTypeError(...); } To keep generated code's style, which is consistent with other ToFooBar(), this CL checks the given V8 value is in a correct type, and makes return value empty if it's not. Bug: 1029716 Change-Id: I1e58c998064b90a0a5b09f0e8895c9283a37e45b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949826Reviewed-by:Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#721901}
-
sczs authored
It also enables editing on the SaveCardModal if the flag is enabled and the card will be uploaded. Bug: 1029067 Change-Id: If8dd3c0ab5e2ef9e4b943a7ae3bf2347f2c47130 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947766 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#721900}
-
Theodore Olsauskas-Warren authored
Along with the elevation of the Privacy card out of advanced, the toggle for allowing Chrome Sign In is being moved out of Privacy and into the Sync and Google Services section. This toggle is disabled during the Sync setup flow if the user elects to go to settings during Sync setup. Additionally, the "Turn On Sync.." button is disabled when Chrome Sign In is disabled. This removes the possibility of enabling sync before restarting the browser after disabling sign in. Every change in behavior is behind the privacySettingsRedesignEnabled finch flag. Bug: 1014143 Change-Id: I4f2f11598ac22823310623d6bd079ece27bfe3b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943174Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#721899}
-
Yuki Shiino authored
CompositeNode supports Python's format-like composition of code nodes. Bug: 839389 Change-Id: Ie7689eb709eecefbb0c2ef4b46b1c59e2abea734 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952545Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#721898}
-
David Dorwin authored
Add an ICU-based implementation of time_exploded, removing the use of the POSIX implementation and thus the use of fuchsia.deprecatedtimezone. Bug: 985946 Test: base/time/ unit tests Change-Id: I91440ecae48684717b6fdcfe5f7ef66028b079c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949776 Commit-Queue: David Dorwin <ddorwin@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#721897}
-
Findit authored
This reverts commit a4d27f51. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 721832 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2E0ZDI3ZjUxM2ViNDBhODk1MDVmMDQyZDY4NjkzZWQ2NzAyNDAwZDkM Sample Failed Build: https://ci.chromium.org/b/8894942016495385648 Sample Failed Step: browser_tests Original change's description: > Move Audio Service off Service Manager > > All the details around if/when a service instance is started and whether > it's in- or out-of-process have been centralized into the implementation > of a single GetAudioService() helper in Content. > > A few other helpers are added to ease the transition off the Service > Manager, though they aren't necessarily ideal APIs. For example, > client library APIs which once took a Service Manager Connector may now > take a RepeatingCallback to bind a specific type of interface. > > In addition to GetAudioService(), Content provides helpers for > AudioSystem construction and StreamFactory binding from any sequence. > > Because all timeout/lifetime management logic is now generically > supported within Mojo and Content and requires no service implementation > details to get right (and because unit tests launching service processes > is no longer supported outside of Content), all Audio Service test > coverage relevant to lifetime management is deemed superfluous and has > been removed. > > Bug: 977637 > Change-Id: I4c59948eafce2322547bf2b0479961e095b3edee > Tbr: oshima@chromium.org > Tbr: guidou@chromium.org > Tbr: vollick@chromium.org > Tbr: xiaohuic@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941280 > Commit-Queue: Ken Rockot <rockot@google.com> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#721832} Change-Id: Ic59416fc7c5f5eda2c3b8b211773f9761d2ea03d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 977637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952526 Cr-Commit-Position: refs/heads/master@{#721896}
-
Chase Phillips authored
This CL extends the manifest scope behavior so a server can override the default scope. The default scope for a new AppCache instance is the manifest URL with an empty path. An upcoming change will update the default to be the manifest URL without the manifest filename. If a server wants to support the behavior that a manifest can specify resources outside of that scope, the server can pass a response header in their 200 or 304 response named X-AppCache-Allowed. The value of this header must be a URL path and have a last character equal to a forward slash. Bug: 999001 Change-Id: I0277c5ab0645346c4a7c6d5eec5ea67c9cbeeda2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935035 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
-
Meilin Wang authored
This CL: 1. Added a new class AmbientModeState to store states related to this mode. 2. Wired up AssistantManagerServiceImpl to observe the new state change in order to update action module as necessary. Misc: Fixed linter warnings. Bug: b/139698911 Test: run unittests added in this change Change-Id: I4dd078c19cc2ce73a8262fe3cfc0c39308949e82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906932 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
-
