GitLab

This class is no longer needed in anticipation of moving the scheduler
from Blink to the content layer.

BUG=391005

Review URL: https://codereview.chromium.org/640803003

Cr-Commit-Position: refs/heads/master@{#300243}

The adb_logcat_* scripts are extract attached devices names with
pattern 'w+', but it only works for real devices. Emulated devices
have names in form of 'emulator-5554' and '-' sign is not matched
by 'w+' parrent. This causes to logcat output to be missed while
tests are running

R=frankf@chromium.org, craigdh@chromium.org

TEST=Run tests with only emulators attached, ensure that resulting
log contains logcal output

Review URL: https://codereview.chromium.org/661843003

Cr-Commit-Position: refs/heads/master@{#300242}

As a first step just move it from chrome_content_browser client
to the desktop_notification_service.

BUG=392187

Review URL: https://codereview.chromium.org/660293002

Cr-Commit-Position: refs/heads/master@{#300241}

In unit tests for MidiManager, RunLoop was used, and is used to wait
a posted task finished. But, RunUntilIdle() can not be called
multiple times. To avoid this restriction, we can just create new
instance again for another iteration.

TEST=media_unittests

Review URL: https://codereview.chromium.org/656793004

Cr-Commit-Position: refs/heads/master@{#300240}

BUG=none

Review URL: https://codereview.chromium.org/658033003

Cr-Commit-Position: refs/heads/master@{#300239}

Make the 'char' to 'unsigned char' to fix the following build failure.

device/hid/hid_connection_unittest.cc: In member function ‘virtual void device::HidConnectionTest_ReadWrite_Test::TestBody()’:
device/hid/hid_connection_unittest.cc:166:23: error: array subscript has type ‘char’ [-Werror=char-subscripts]
       buffer->data()[j] = i + j - 1;
                       ^
device/hid/hid_connection_unittest.cc:179:285: error: array subscript has type ‘char’ [-Werror=char-subscripts]
       ASSERT_EQ(i + j - 1, read_callback.buffer()->data()[j])

Review URL: https://codereview.chromium.org/664983002

Cr-Commit-Position: refs/heads/master@{#300238}

The main differences are:
- it uses AdbWrapper.Shell to actually execute the command.
- when the cmd is supplied as a list of a command and its arguments,
  the arguments are quoted to prevent them from being (mis)interpreted
  by the shell.
- a new single_line option to check that the output produces contains a single line, and return the value of that line.

BUG=267773

Review URL: https://codereview.chromium.org/659533002

Cr-Commit-Position: refs/heads/master@{#300237}

Chrome4ChromeOS for Linux packages needs pNaCl but it is not part of package
so make it downloadable when running on Linux. In Chrome OS PNaCl is part of
rootfs.

BUG=422121
TEST=manual

Review URL: https://codereview.chromium.org/662713006

Cr-Commit-Position: refs/heads/master@{#300236}

This switch prevents the app list from being dismissed when it loses
focus (which is helpful when testing the app list or a launcher page).
The other dismissal methods (eg Esc) still work. Honoured on Linux and
Windows only.

BUG=405400

Review URL: https://codereview.chromium.org/661003003

Cr-Commit-Position: refs/heads/master@{#300235}

Use 0x00 rather than 0x30 ('0') to pad the DATA frame to be comply with the
HTTP/2 spec.

This lands server change 77448497 by raullenchai.

BUG=345769

Review URL: https://codereview.chromium.org/654253004

Cr-Commit-Position: refs/heads/master@{#300234}

The async result of net_request_->Read() in ServiceWorkerWriteToCacheJob::ReadNetData() is passed to ServiceWorkerWriteToCacheJob::OnReadCompleted().
In current code the case when bytes_read is 0 is not handled correctly.
So when bytes_read is 0 the script loading will hang.

LayoutTest is here: https://codereview.chromium.org/650193003

I hope this patch will reduce the test flakiness :)

BUG=419999
TEST=http/tests/serviceworker/chromium/load-flushed-script.html

Review URL: https://codereview.chromium.org/640923003

Cr-Commit-Position: refs/heads/master@{#300233}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/d12af70..468b181

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/662973002

Cr-Commit-Position: refs/heads/master@{#300232}

This patch remembers the observed entries in preferences, so they are restored
after a reboot.

Note, that more tests will come after a refactoring out writing to preferences
from Service, which is coming soon/

TEST=unit_tests, browser_tests: *FileSystemProvider*RememberFileSystem*, *FileSystemProvider*RestoreFileSystem*
BUG=248427

Review URL: https://codereview.chromium.org/658313002

Cr-Commit-Position: refs/heads/master@{#300231}

As discussed on chromium-os-dev [1], if there is no fsync() after writing to the
temp file, atomicity is not guaranteed.  Thus, to be able to guarantee
atomicity, we must check the return value of Flush() and bail in case Flush()
wasn't successful.

I'll update the UMA histogram enum in a separate CL.

[1] https://groups.google.com/a/chromium.org/forum/?hl=en#!topic/chromium-os-dev/Eef8gNIRwjc

BUG=none

Review URL: https://codereview.chromium.org/663463002

Cr-Commit-Position: refs/heads/master@{#300230}

This CL fixes an issue causing the app list to render without any apps
when shown in an RTL language.

BUG=422604

Review URL: https://codereview.chromium.org/656343003

Cr-Commit-Position: refs/heads/master@{#300229}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e862ddb..833fa84

TBR=

Review URL: https://codereview.chromium.org/662303002

Cr-Commit-Position: refs/heads/master@{#300228}

TBR=grt@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/666713002

Cr-Commit-Position: refs/heads/master@{#300227}

Revert of Support modal windows (patchset #4 id:80001 of https://codereview.chromium.org/662763002/)

Reason for revert:
Reverting because this CL because WithOrWithoutTargeter.* introduced a memory leak and made all of the Athena Asan tests fail http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)

Based on tools/lsan/suppressions.txt reverting is now preferred over adding a suppression

Original issue's description:
> Support modal windows
>
> * New ContainerParams
>  -  default_parent to specify the default parent when no
>     transient parent is specified.
>  - modal_container_priority now controls the modal container
>    used for a modal window created for the given container.
>  - if not specified, it will fallback downwards to find one.
>  - if window is specified as always_on_top, it will use top
>    most modal container.
>
> * Changed network selector/shutdown dialog to use the new API.
>
> * Other change:
>  Separated test windows to athena/test/base/test_windows.h
>
> BUG=410499
> TBR=sky@chromium.org,reed@chromium.org
> TEST=coverd by unit tests
>
> Committed: https://crrev.com/4903fd36b2b36f00efeb1b7bba81b7de6e9457a3
> Cr-Commit-Position: refs/heads/master@{#300192}

TBR=mukai@chromium.org,sky@chromium.org,reed@chromium.org,oshima@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=410499

Review URL: https://codereview.chromium.org/665803003

Cr-Commit-Position: refs/heads/master@{#300226}

Revert of Revert of [Telemetry] Set the number of attempts to retry a test if browser or tab crash to 1 (patchset #1 id:1 of https://codereview.chromium.org/661303002/)

Reason for revert:
The removal of Telemetry's retry logic wasn't the cause of the intermittent crashes on the GPU bots.

Original issue's description:
> Revert of [Telemetry] Set the number of attempts to retry a test if browser or tab crash to 1 (patchset #2 id:20001 of https://codereview.chromium.org/659753003/)
>
> Reason for revert:
> Possible cause of gpu telemetry bot flake
>
> Original issue's description:
> > [Telemetry] Set the number of attempts to retry a test to 1
> >
> > **SHERIFFS: if telemetry perf tests on waterfall become more flaky, this patch can be safely reverted.
> >
> > BUG=422339
> >
> > Committed: https://crrev.com/f5b75f261be7779ccca14d09ddaabb3e4ee5ee03
> > Cr-Commit-Position: refs/heads/master@{#299716}
>
> TBR=tonyg@chromium.org,dtu@chromium.org,nednguyen@google.com
> NOTREECHECKS=true
> NOTRY=true
> BUG=422339
>
> Committed: https://crrev.com/1c141bedc45cdef1ac7b7264ea1288c33e33d106
> Cr-Commit-Position: refs/heads/master@{#300218}

TBR=tonyg@chromium.org,dtu@chromium.org,nednguyen@google.com,hendrikw@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=422339

Review URL: https://codereview.chromium.org/662963002

Cr-Commit-Position: refs/heads/master@{#300225}

Revert of [ServiceWorkerCache] Implement storage::QuotaClient (patchset #12 id:320001 of https://codereview.chromium.org/651983002/)

Reason for revert:
bug 424923, top crash in canary.

Original issue's description:
> [ServiceWorkerCache] Implement storage::QuotaClient
>
> Adds a QuotaClient for the ServiceWorkerCache system.
>
> * Calls to the QuotaManagerProxy like (NotifyStorageAccessed/StorageModified/OriginInUse/etc..) will be in an upcoming CL.
>
> * The ServiceWorkerCacheQuotaClient is registered by the ServiceWorkerCacheStorageManager.  The QuotaClient holds a WeakPtr to the ServiceWorkerCacheStorageManager since the manager is destroyed before the QuotaClient.
>
> * Added a number of unittests.  They fit better into the StorageManager tests file than in their own file as they rely on a lot of the StorageManager infrastructure.
>
> * In order to support QuotaClient the ServiceWorkerCacheStorageManager needs to be able to list the origins it supports. This data is not currently stored so an "origin" member has been added to the CacheStorage index protobuf.  We won't report the origins of existing caches (if any even exist at this point) until their index is next written.
>
> BUG=420159
>
> Committed: https://crrev.com/22fcbd3c898136dfe839de3ca5cb0633c17bb163
> Cr-Commit-Position: refs/heads/master@{#300187}

TBR=michaeln@chromium.org,falken@chromium.org,jkarlin@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=420159

Review URL: https://codereview.chromium.org/651433005

Cr-Commit-Position: refs/heads/master@{#300224}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/bc9a196..e862ddb

TBR=

Review URL: https://codereview.chromium.org/667583002

Cr-Commit-Position: refs/heads/master@{#300223}

This patch ensures that the eviction tiles cache becomes invalid
when a tile is removed from it. Without this patch, it is possible
that the eviction cache holds on to a tile pointer that would end
up pointing to a deleted tile (and thus when it gets evicted,
we'll access an invalid tile).

BUG=424487
R=reveman

Review URL: https://codereview.chromium.org/669433002

Cr-Commit-Position: refs/heads/master@{#300222}

This patch adds an iterator similar to spiral difference iterator,
except that it iterates the indecies in reverse order. This is needed
for a fast eviction iterator.

R=danakj, enne

Review URL: https://codereview.chromium.org/645173004

Cr-Commit-Position: refs/heads/master@{#300221}

BUG=
TBR=stgao@chromium.org

Review URL: https://codereview.chromium.org/657143004

Cr-Commit-Position: refs/heads/master@{#300220}

This allows the removal of the IsAlgorithmAsymmetric() helper.

BUG=407846

Review URL: https://codereview.chromium.org/512023002

Cr-Commit-Position: refs/heads/master@{#300219}

Revert of [Telemetry] Set the number of attempts to retry a test if browser or tab crash to 1 (patchset #2 id:20001 of https://codereview.chromium.org/659753003/)

Reason for revert:
Possible cause of gpu telemetry bot flake

Original issue's description:
> [Telemetry] Set the number of attempts to retry a test to 1
>
> **SHERIFFS: if telemetry perf tests on waterfall become more flaky, this patch can be safely reverted.
>
> BUG=422339
>
> Committed: https://crrev.com/f5b75f261be7779ccca14d09ddaabb3e4ee5ee03
> Cr-Commit-Position: refs/heads/master@{#299716}

TBR=tonyg@chromium.org,dtu@chromium.org,nednguyen@google.com
NOTREECHECKS=true
NOTRY=true
BUG=422339

Review URL: https://codereview.chromium.org/661303002

Cr-Commit-Position: refs/heads/master@{#300218}

And stop mis-using user metrics action.

BUG=424689

Review URL: https://codereview.chromium.org/659333003

Cr-Commit-Position: refs/heads/master@{#300217}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/0a8c931..bc9a196

TBR=

Review URL: https://codereview.chromium.org/656793003

Cr-Commit-Position: refs/heads/master@{#300216}

Cr-Commit-Position: refs/heads/master@{#300215}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d1f9de7..0a8c931

TBR=

Review URL: https://codereview.chromium.org/668503002

Cr-Commit-Position: refs/heads/master@{#300214}

BUG=424216,420994
NOTRY=true

Review URL: https://codereview.chromium.org/661943002

Cr-Commit-Position: refs/heads/master@{#300213}

To allow the chromium WebView to build unbundled, we need to stop
linking to system libraries and instead link to the prebuilt libraries
in the NDK.

This change rolls gyp to include the required makefile generation
changes, and adjusts the chromium side to match:

1) Stop setting use_system_stlport and instead use the NDK stlport by
   specifying LOCAL_NDK_STL_VARIANT := stlport_static

2) Remove support for the use_system_stlport flag entirely as WebView
   was the only user.

3) Don't try to link standard libraries like -lc -lm as the NDK does
   this automatically.

4) Don't include the OpenAL headers from frameworks/wilhelm; these are
   already part of the NDK with no special include path needed.

BUG=409851

Review URL: https://codereview.chromium.org/571953002

Cr-Commit-Position: refs/heads/master@{#300212}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/0a93e49..d1f9de7

TBR=

Review URL: https://codereview.chromium.org/644203003

Cr-Commit-Position: refs/heads/master@{#300211}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/38b0e5f..0a93e49

TBR=

Review URL: https://codereview.chromium.org/664823002

Cr-Commit-Position: refs/heads/master@{#300210}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c8c9c60..38b0e5f

TBR=

Review URL: https://codereview.chromium.org/665723002

Cr-Commit-Position: refs/heads/master@{#300209}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2b06b87..c8c9c60

TBR=dstockwell@chromium.org,aboxhall@chromium.org

Review URL: https://codereview.chromium.org/663943002

Cr-Commit-Position: refs/heads/master@{#300208}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c6d24c6..2b06b87

TBR=dstockwell@chromium.org,aboxhall@chromium.org

Review URL: https://codereview.chromium.org/659793006

Cr-Commit-Position: refs/heads/master@{#300207}

The real changes are in mojo_url_resolver*.

The rest are renames that were generated with the following commands:

git grep -l 'mojo:mojo_' | xargs perl -pi -e 's|mojo:mojo_|mojo:|g'
git grep -l 'mojo://mojo_' | xargs perl -pi -e 's|mojo://mojo_|mojo://|g'
git cl format

Review URL: https://codereview.chromium.org/668483002

Cr-Commit-Position: refs/heads/master@{#300206}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c7265cd..c6d24c6

TBR=dstockwell@chromium.org,aboxhall@chromium.org

Review URL: https://codereview.chromium.org/662933002

Cr-Commit-Position: refs/heads/master@{#300205}

REJ or an SHLO to count. This should mean that anytime confirmation is
required, the handshake should be at most 1 effective RTT whereas
currently they can be 2 RTT.

Review URL: https://codereview.chromium.org/656303004

Cr-Commit-Position: refs/heads/master@{#300204}