- 20 Nov, 2018 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7da982abf99f..e47ac15d93b8 git log 7da982abf99f..e47ac15d93b8 --date=short --no-merges --format='%ad %ae %s' 2018-11-20 abenner@google.com Fix git cl format --python on windows Created with: gclient setdep -r src/third_party/depot_tools@e47ac15d93b8 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:846432 TBR=agable@chromium.org Change-Id: I2915800b137f3679f918b5cfa488a70469505ffe Reviewed-on: https://chromium-review.googlesource.com/c/1344271Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609777}
-
Evan Stade authored
This simplifies the test fixture and allows the tests to pass in single process mash. (Technically, they also pass in single process mash without this change, but would cease to do so after AuraTestSuite stops creating an InputDeviceClient, which will soon happen.) Bug: 905430 Change-Id: I9536989b016176b96db824732720b86d6442f27d Reviewed-on: https://chromium-review.googlesource.com/c/1343338 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#609776}
-
Kyle Horimoto authored
This CL adds latency metrics for sub-tasks of BLE connections: * start scan ==> receive advertisement * start scan ==> GATT connection * receive advertisement ==> GATT connection * GATT connection ==> authentication Bug: 870139 Change-Id: If1f4230bb873e097a10963f8fc86003afc1146ac Reviewed-on: https://chromium-review.googlesource.com/c/1336921Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#609775}
-
Ted Choc authored
This removes the duplicate parsing logic in Java. BUG= Change-Id: If43303f6a7bc708186601bdaca0e876c6c3ceee4 Reviewed-on: https://chromium-review.googlesource.com/c/1343080 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#609774}
-
Tommy C. Li authored
We aren't experimenting on this anymore. Bug: 900255 Change-Id: Idc932239bb767ffb602323d66b9cf2f89321891d Reviewed-on: https://chromium-review.googlesource.com/c/1343362 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#609773}
-
Fredrik Söderquist authored
This one using inline style instead of presentation attributes. Bug: 650147 Change-Id: I00ee6c52b95803a928dd0b95a33da89f531a05ac Reviewed-on: https://chromium-review.googlesource.com/c/1344102Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#609772}
-
Mohsen Izadi authored
This also cleans up initialization a bit. BUG=none Change-Id: Ic875db92a4f1b1e9e72bed180da3b4da1211fe29 Reviewed-on: https://chromium-review.googlesource.com/c/1343244Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#609771}
-
Saman Sami authored
Change-Id: I2e81f37f27ce73fd4ceac36f1c523b9dfdb90d42 Reviewed-on: https://chromium-review.googlesource.com/c/1343355Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#609770}
-
Daniel Bratell authored
Both components/policy/core/common/cloud/machine_level_user_cloud_policy_metrics.h and components/policy/core/common/cloud/enterprise_metrics.h define policy::kMaxValue in two different enums. If code includes both headers, it won't compile and this happens in some jumbo build configurations. This patch changes one of the enums to use enum class so that the symbols are in different namespaces. (One will shadow the other but as long as they are used correctly it will be fine) Bug: 905702 Change-Id: Ia4dd0c89dc8ec5c23c516e90eae7f6c3256a232a Reviewed-on: https://chromium-review.googlesource.com/c/1344129Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#609769}
-
Vincent Boisselle authored
needed by the download manager to handle the new api to reuse most of the logic in place for the legacy api. Change-Id: I529a55781919ddb8c23b3cebc9f1b1d0af148af6 Reviewed-on: https://chromium-review.googlesource.com/c/1334268 Commit-Queue: Vincent Boisselle <vincb@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#609768}
-
bsheedy authored
This is a reland of a8f4b170 No changes from original CL (erroneously reverted) Original change's description: > Cleanup XR usage of EmbeddedTestServer > > Cleans up manual usage of EmbeddedTestServer in XR tests, which was both > adding a lot of duplicate code and had the potential to fail to clean up > the server if the test failed, which could then affect other tests. > > This is achieved by making EmbeddedTestServerRule lazy and applying it > to all ChromeActivityTestRules, not just WebappActivityTestRule. > > Bug: 901923 > Change-Id: I431dac3ce2488a1a5762a1ab1f5ec68aea16c9f5 > Reviewed-on: https://chromium-review.googlesource.com/c/1320024 > Commit-Queue: Brian Sheedy <bsheedy@chromium.org> > Reviewed-by: Tommy Nyquist <nyquist@chromium.org> > Reviewed-by: Paul Jensen <pauljensen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609556} TBR=nyquist@chromium.org, pauljensen@chromium.org Bug: 901923 Change-Id: I1d538672fc6b67d97a47f4bd165c4169e9b3f37c Reviewed-on: https://chromium-review.googlesource.com/c/1344550Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#609767}
-
Gauthier Ambard authored
This CL prepares the AutofillEditItem to be changed to be used with UITableView. Bug: 894791 Change-Id: Iee510dd6cf2df483ef2977fba9ff4ca3a85f9326 Reviewed-on: https://chromium-review.googlesource.com/c/1344135Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#609766}
-
Dan Elphick authored
Replace use of deprecated Maybe<bool> BooleanValue(Context) with bool BooleanValue(Isolate*). The Maybe version is unnecessary as BooleanValue can never throw. Bug: v8:7279, v8:8238 Change-Id: Iaf827cedbf158c59727900ff551962e2af4ccbac Reviewed-on: https://chromium-review.googlesource.com/c/1344063 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#609765}
-
Robert Sesek authored
There are slightly different font metrics between macOS versions, and either macOS 10.10 or 10.11 will fail with a single hard-coded constant value for pixel widths. Just disable this test on 10.10, which is the oldest version that is supported, and let the test pass on 10.11+. Bug: 739386 Change-Id: I82ea6a3276ebe5de4906c33a906ebf76cf2c85b9 Reviewed-on: https://chromium-review.googlesource.com/c/1344769Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#609764}
-
Geoff Lang authored
ResetDecoder would always pass a true have_context to GLES2Decoder::Destroy causing some assertions in the destuction of GL objects when the context had previously been lost. BUG=877524 Change-Id: I8b455ba0aa9515764d5caca63668401b09cb124e Reviewed-on: https://chromium-review.googlesource.com/c/1344212Reviewed-by:
-
Stepan Khapugin authored
Reload the icon whenever the favicon for a given URL is loaded. This allows to correctly display favicons even when new most visited have been generated. Bug: none Change-Id: I75890f19f5de1b803096bc51d9c938537b96d4f7 Reviewed-on: https://chromium-review.googlesource.com/c/1341994 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#609762}
-
Nico Weber authored
Bug: none Change-Id: I28559ce545a5f1204fb40c34f4089614ef1c3eb3 Reviewed-on: https://chromium-review.googlesource.com/c/1344289 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#609761}
-
Geoff Lang authored
This reverts commit c60b7aa8. Reason for revert: <INSERT REASONING HERE> Original change's description: > Revert "Expose GL_CHROMIUM_compressed_texture_etc when ANGLE supports it." > > This reverts commit 2d170801. > > Reason for revert: might have broken angle_perftests https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20FYI%20Release%20%28NVIDIA%29/6461 > > Original change's description: > > Expose GL_CHROMIUM_compressed_texture_etc when ANGLE supports it. > > > > ANGLE now exposes this extension under the same conditions as Chrome: on top > > of a native ES driver. > > > > BUG=angleproject:1552 > > > > Change-Id: I6552e51bccd5ece43b7405b26d63127283a90c46 > > Reviewed-on: https://chromium-review.googlesource.com/c/1342497 > > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > > Commit-Queue: Geoff Lang <geofflang@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#609713} > > TBR=zmo@chromium.org,geofflang@chromium.org,kainino@chromium.org > > Change-Id: I92f0b2e98577af73cd23510e95868d29ac04e775 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: angleproject:1552 > Reviewed-on: https://chromium-review.googlesource.com/c/1344582 > Reviewed-by: Saman Sami <samans@chromium.org> > Commit-Queue: Saman Sami <samans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609758} TBR=zmo@chromium.org,geofflang@chromium.org,kainino@chromium.org,samans@chromium.org Change-Id: I639d66790d226f20f23965a59d29f1653e5c903d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: angleproject:1552 Reviewed-on: https://chromium-review.googlesource.com/c/1344553Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#609760}
-
Robert Sesek authored
Previously it used -[NSColor drawSwatchInRect:] which "adorns" the color with additional drawing. Bug: 641509, 36032 Change-Id: Ib3dd089980c4d942b0aac0435a94f5ad44fcd3e4 Reviewed-on: https://chromium-review.googlesource.com/c/1343045 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#609759}
-
Saman Sami authored
This reverts commit 2d170801. Reason for revert: might have broken angle_perftests https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20FYI%20Release%20%28NVIDIA%29/6461 Original change's description: > Expose GL_CHROMIUM_compressed_texture_etc when ANGLE supports it. > > ANGLE now exposes this extension under the same conditions as Chrome: on top > of a native ES driver. > > BUG=angleproject:1552 > > Change-Id: I6552e51bccd5ece43b7405b26d63127283a90c46 > Reviewed-on: https://chromium-review.googlesource.com/c/1342497 > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Commit-Queue: Geoff Lang <geofflang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609713} TBR=zmo@chromium.org,geofflang@chromium.org,kainino@chromium.org Change-Id: I92f0b2e98577af73cd23510e95868d29ac04e775 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: angleproject:1552 Reviewed-on: https://chromium-review.googlesource.com/c/1344582Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#609758}
-
Victor Costan authored
The authorizer now explicitly denies SAVEPOINT statements and recursive queries. This behavior was implicit before this CL, because the action codes were not handled, and the (correct) default is to deny any unknown action. The authorizer now always denies ATTACH and DETACH statements. Before this CL, these statements were allowed when security checks were disabled. However, security checks are only disabled to execute WebSQL-internal statements, and our implementation does not rely on attaching and detaching databases. The statements are very dangerous, so this CL denies them at all times. Change-Id: I4d1df92888670dcb5ceb7afa63767d1d4c7a741b Reviewed-on: https://chromium-review.googlesource.com/c/1342858 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#609757}
-
Corentin Wallez authored
These builder will run the dawn_end2end_tests on the GPU swarming bots through the Chromium recipe. BUG=chromium:901830 Change-Id: I2e462a872ff708d751cee9fd9c21c69761736690 Reviewed-on: https://chromium-review.googlesource.com/c/1341547 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#609756}
-
Victor Costan authored
Change-Id: I485e771fa8e7911565a9cd99209145b1cf26450c Reviewed-on: https://chromium-review.googlesource.com/c/1343572Reviewed-by:
-
Victor Costan authored
Chrome currently carries a SQLite patch at 0002-Use-seperate-page-cache-pools-for-each-sqlite-connec.patch which forces per-database (technically, per-connection) page cache pools. Asides from adding to our maintenance burden, the patch breaks an assert() in SQLite's code, suggesting that it doesn't work as intended anymore. Fortunately, SQLite has a few supported ways of specifying whether database connections use private page cache pools or a central pool. The most convenient method for Chrome is the SQLITE_OPEN_PRIVATECACHE flag on sqlite3_open_v2() [1]. This CL does the following: 1) Removes the SQLITE_SEPARATE_CACHE_POOLS build flag, which activates Chrome's page cache pool patch. The patch (which becomes inert when this CL lands) shall be removed from our SQLite version in a follow-up CL, after this CL sticks. 2) Removes the SQLITE_ENABLE_MEMORY_MANAGEMENT build flag. This flag is incompatible with private page cache pools, because it enables the sqlite3_release_memory() function [2], which assumes a centralized (shared) page cache pool [3]. Chrome doesn't use sqlite3_release_memory() today, so the flag is unnecessary. If we want to trim SQLite caches in response to memory pressure, we can still use sqlite3_db_release_memory() [4] and track all the open connections ourselves. 3) Adds the SQLITE_OPEN_PRIVATECACHE flag to our invocation of sqlite3_open_v2(). [1] https://www.sqlite.org/c3ref/open.html [2] https://www.sqlite.org/c3ref/release_memory.html [3] https://www.sqlite.org/sharedcache.html [4] https://www.sqlite.org/c3ref/db_release_memory.html Bug: 906396 Change-Id: Ib3b08b26364ad86d173111fc4e554bd07bd91aa1 Reviewed-on: https://chromium-review.googlesource.com/c/1343789Reviewed-by:
-
Peter Kasting authored
This is how other platforms work, and fixes some broken tests. Bug: 546240 Change-Id: I3b1dc74bbe50b7033aa75b93822f87bab32dfadb Reviewed-on: https://chromium-review.googlesource.com/c/1343563Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#609753}
-
John Rummell authored
Original change's description: > MediaLicenses can be cleared from the ClearBrowsingData dialog, so update the > BrowsingDataRemoverBrowserTest to check them as well. This uses the test-only > External Clear Key CDM to store the license in the file system, if it is > available. > This reverts commit 72f2d4cd. BUG=808690,879812 TEST=new browser_tests pass Change-Id: Ie9e9229fc85244eed922d93dce82cb3fa09bbe5c Reviewed-on: https://chromium-review.googlesource.com/c/1342779Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#609752}
-
Evan Stade authored
This simplifies the test fixture and allows the tests to pass in single process mash. (Technically, they also pass in single process mash without this change, but would cease to do so after AuraTestSuite stops creating an InputDeviceClient, which will soon happen.) Bug: 905430 Change-Id: I067e2e0affcf3f0b95fa687f303882a6233cb1cf Reviewed-on: https://chromium-review.googlesource.com/c/1343341Reviewed-by:
Kevin Bailey <krb@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#609751}
-
Tarun Bansal authored
This experiment has not been enabled for a while (see http://shortn/_sn5eJWqtjL), and there are no plans to revive it (already checked with relevant experiment owners). Removing the code since I plan to start an experiment which has some overlaps with this existing code. Note that resource_scheduler.cc has other experiments too which are disabled. This CL onl cleans up a single experiment. Change-Id: I58fd890a522e561942eb4e9ae3f7a437737242de Reviewed-on: https://chromium-review.googlesource.com/c/1343606Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#609750}
-
Evan Stade authored
This simplifies the test fixture and allows the tests to pass in single process mash. (Technically, they also pass in single process mash without this change, but would cease to do so after AuraTestSuite stops creating an InputDeviceClient, which will soon happen.) Bug: 905430 Change-Id: Ie2a08154d28fbe3a17148c3097eb1d2278ae8ef6 Reviewed-on: https://chromium-review.googlesource.com/c/1343293Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#609749}
-
Victor Costan authored
SQLiteStatement::GetColumn value currently uses sqlite3_column_value() to retrieve a sqlite3_value*, and then uses other API calls to extract information from the value. The SQLite documentation [1, 2] states that sqlite3_column_value() returns an "unprotected value", which should not be operated on directly. When SQLite is compiled with multi-threading support (as Chrome does), the incorrect usage triggers assets in SQLite. This CL replaces the incorrect usage of sqlite3_value* with SQLite API calls documented in [2] which are safe to use, inspired from sql::Statement. [1] https://www.sqlite.org/c3ref/value.html [2] https://www.sqlite.org/c3ref/column_blob.html Bug: 906396 Change-Id: Ic8f7caac31c5be91113af576c020236aeb4106dc Reviewed-on: https://chromium-review.googlesource.com/c/1343574 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
-
Victor Costan authored
The string "SQLITE_MMAP_READ_ONLY" only shows up the BUILD.gn file [1], so this macro does not impact the SQLite build at all. The comment above it suggests that the macro is intended to set up SQLite so it uses read-only mmap regions, to avoid having memory stompers corrupt databases. However, the SQLite documentation [2] indicates that the read-only mmap behavior is the default and only option available. In conclusion, this flag is misleading, and removing it will not result in any behavior change. [1] https://cs.chromium.org/search/?q=SQLITE_MMAP_READ_ONLY&ssfr=1&type=cs [2] https://www.sqlite.org/mmap.html Change-Id: I5fc3ae62f399fcfc6fbdd868258fef48cdc7fa61 Reviewed-on: https://chromium-review.googlesource.com/c/1343194Reviewed-by:
-
Corentin Wallez authored
https://dawn.googlesource.com/dawn.git/+log/391c8a9224e5..63997221d7d8 $ git log 391c8a922..63997221d --date=short --no-merges --format='%ad %ae %s' 2018-11-20 cwallez Fix #include casing breaking linux->windows cross compilation 2018-11-20 cwallez Make codegen not cast between fnptrs. 2018-11-20 cwallez WireServer: Check for ID 0 in hand-written handlers. 2018-11-20 cwallez DawnWireAndFrontendFuzzer: skip SwapChainBuilderSetImplementation 2018-11-20 cwallez DawnWireAndFrontendFuzzer: don't leak the device. 2018-11-19 rharrison Tighten when signal trap is used in SPIRV-Cross fuzzers Created with: roll-dep src/third_party/dawn TBR=kainino@chromium.org Bug= Change-Id: I1aab57dfd4355edd8e11ab6a5e3e34ab4ea7f5bf Reviewed-on: https://chromium-review.googlesource.com/c/1344138Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#609746}
-
Nico Weber authored
Bug: 840631 Change-Id: I047d71373b91c5b7a14ef22a274671b561792e30 Reviewed-on: https://chromium-review.googlesource.com/c/1344189Reviewed-by:
-
Stefan Zager authored
This disables the machinery of running layout while ignoring pending stylesheets, and gets rid of display:none "placeholder" style. With this patch, a forced layout that occurs while a stylesheet is pending will resolve styles and run layout based on whatever style information is available at the time. There is a bunch of code cleanup to do after this patch, but this should be the only functional change. BUG=521692 R=chrishtr@chromium.org,futhark@chromium.org Change-Id: I9b836c16aef67c43bd6170b23a39161302d6f810 Reviewed-on: https://chromium-review.googlesource.com/c/1334967Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#609744}
-
Brad Hall authored
This will allow them to try 10.13 first and fall back to 10.12 if there aren't any hosts available. Bug: 853356 Change-Id: I0fd82376ebb2c4e501a78360bbbc675c90ee7d34 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1330693 Commit-Queue: Brad Hall <bradhall@google.com> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#609743}
-
Reilly Grant authored
This change assigns owners for the following flags that are owned by myself: * enable-generic-sensor (launched) * enable-generic-sensor-extra-classes * new-usb-backend Bug: 897809 Change-Id: I7642770769398bb31035a18374b060a94f1b02cb Reviewed-on: https://chromium-review.googlesource.com/c/1340955Reviewed-by:
-
Jun Choi authored
When Bluetooth adapter is powered on and user has not previously connected with any Bluetooth authenticators, show Bluetooth device selection UI followed by PIN pairing UI. Also, record used Bluetooth authenticator ID on successful WebAuthN API in order to trigger WebAuthn BLE pairing UI for case when use has never paired to Bluetooth authenticator before. Bug: 877344 Change-Id: I312bdffa618c5f7d446fe24228acbad8e64f2067 Reviewed-on: https://chromium-review.googlesource.com/c/1333767 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#609741}
-
Clemens Arbesser authored
[Autofill Assistant] Fixed crash caused by TouchEventFilter when interacting with page after autofill assistant has given up. The crash was caused by listeners that were not properly unregistered. Bug: 806868 Change-Id: Id7514b6a1c6a2a6e97ecf57b4eb4c6812ed1cb4e Reviewed-on: https://chromium-review.googlesource.com/c/1344103Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#609740}
-
Johannes Kron authored
The kInvalid enum entries will be removed since they are not part of the standard T-REC H.273. kUNSPECIFIED may be used instead. Bug: webrtc:8651 Change-Id: I71ac3f5eebf73cb4188c5e15532b289a4be1bc50 Reviewed-on: https://chromium-review.googlesource.com/c/1343108Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Johannes Kron <kron@chromium.org> Cr-Commit-Position: refs/heads/master@{#609739}
-
Becky Zhou authored
+ Removed experiment flags + Refactor app modal JavaScript dialogs to use modal dialog + Use property model for JavaScript dialogs + Clean up tests Bug: 899318, 874537 Change-Id: Id9d5bf83d9bc086ffd064c0589eafcaba495f26b Reviewed-on: https://chromium-review.googlesource.com/c/1340974Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
-
