- 11 Apr, 2019 40 commits
-
-
Lucas Tenório authored
Bug: 927809 Change-Id: I5ec26029f1ece2c102e4a9b792112100413033b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558795 Commit-Queue: Lucas Tenório <ltenorio@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Maajid <maajid@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#649859}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/21a8eca7b39f..3ec1a396fb79 Created with: gclient setdep -r src-internal@3ec1a396fb79 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=harrisjay@chromium.org,ellyjones@chromium.org,btolsch@chromium.org Change-Id: I6714655081f99c965e22e65eb86213a9391989d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564252Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649858}
-
Vadym Doroshenko authored
With CL https://chromium-review.googlesource.com/c/chromium/src/+/1530980 NewPasswordFormManager::PasswordNoLongerGenerated might be called when NewPasswordFormManager is not in generating state. Bug: 886583, 866444 Change-Id: If69df52c77c10d195fad8b992462595942d45c11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561125Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#649857}
-
Lucas Tenório authored
The original intent for the GetApps method for the bridge was to only return installed apps. This change actually enforces that. Note that apps with Readiness == kUninstalledByUser are still represented in AppControllerClient notifications. After all, we still want the bridge to be notified when an app is uninstalled. Bug: 927809 Change-Id: Ibed29f80aefb02b6e66c1db6feb58f1a4da656d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562190 Commit-Queue: Lucas Tenório <ltenorio@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7061e51b48ee..7ddef1af8859 git log 7061e51b48ee..7ddef1af8859 --date=short --no-merges --format='%ad %ae %s' 2019-04-11 minyue@webrtc.org Revert "Replace usage of old SetRates/SetRateAllocation methods" Created with: gclient setdep -r src/third_party/webrtc@7ddef1af8859 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I65c9353539e69f49f495d398ead575b1dac2bcff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564533Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649855}
-
Bo Liu authored
Some devices are apparently crashing due to a null binding here. Plumbing the correct conditions is somewhat difficult and brittle. So just add a null check instead. Bug: 950472 Change-Id: I26b9d1c2ec0db7abe23a32f2e8d7078a59e5767a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564570Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#649854}
-
David 'Digit' Turner authored
Replace obsolete DictionaryValue and ListValue usage with Value instances and their method calls instead. + Add Value::CreateFromCopiedBuffer which returns a Value instance directly, replacing Value::CreateWithCopiedBuffer which returns a std::unique_ptr<Value>. BUG=646113 R=dcheng@chromium.org, palmer@chromium.org, rsesek@chromium.org, jdoerrie@chromium.org Change-Id: I8e13128de74216d5e36ef138214613193d846a1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553321 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#649853}
-
Raman Mazurkevich authored
- For devices, which support power management ALSA can switch audio outputs to suspended state. In this case PcmWritei is returning -EBADFD error. Bug: internal b/129408282 Change-Id: I5840eb943b0ff54e577084502771b0e2d97a8cfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562074Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Steven Zhu <jz@chromium.org> Cr-Commit-Position: refs/heads/master@{#649852}
-
Yashar Dabiran authored
This CL is part of the efforts to add |RuntimeEnabled| IDL attribute support for origin trial features. Design doc for the overall change: https://docs.google.com/document/d/1Qog5qwZ-6Rfx10AKkJxN-LrwhCw_GJ1xdLoQSnpsT1Q * bindings test expectations should not change with this CL Bug: 934451 Change-Id: Id8d8bc718b0c8d19c9e30f794e2d351ffb82206b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558688 Commit-Queue: Yashar Dabiran <yashard@google.com> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#649851}
-
Caitlin Fischer authored
This change applies to address plus phone and address plus email LabelFormatters. If a user is focused on a non-street-address field, e.g. city, the label will display the street address, a separator, and the contact info, which is either phone or email. Address plus phone: https://screenshot.googleplex.com/DEt8qpwi6ZJ Address plus email: https://screenshot.googleplex.com/YJhuVTiPySD Bug: 936168 Change-Id: I67848ec2a963bc5d07fcdc626d8477d25be2dfb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562373 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#649850}
-
David 'Digit' Turner authored
When shifting a constant integer more than 32 bits, ensure that it is a 64-bit constant, or chaos will ensue. BUG=895194 R=pasko@chromium.org, agrieve@chromium.org, rmcilroy@chromium.org Change-Id: I1fc334fc77b2f5f518b690936b60a0a7e0d78956 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563997Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#649849}
-
Elly Fong-Jones authored
TBR=avi@chromium.org Bug: None Change-Id: Ib6e8588afba2e918ab2195c1a72863cc6f41a5d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561670Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#649848}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/c005c9acf051..51fd66e3dd35 git log c005c9acf051..51fd66e3dd35 --date=short --no-merges --format='%ad %ae %s' 2019-04-11 jiawei.shao@intel.com Add missing Constants.h in src/common/BUILD.gn Created with: gclient setdep -r src/third_party/dawn@51fd66e3dd35 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Id90703c439eb60dd8facad9eac9106acfa60c0d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564532Reviewed-by:
-
Yashar Dabiran authored
This CL is part of the efforts to add |RuntimeEnabled| IDL attribute support for origin trial features. Design doc for the overall change: https://docs.google.com/document/d/1Qog5qwZ-6Rfx10AKkJxN-LrwhCw_GJ1xdLoQSnpsT1Q All the tests added here will be changed from OriginTrialEnabled to RuntimeEnabled in the next CL. Bug: 934451 Change-Id: I1e475850da88ced3e3de5f410505f36feb1427a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560334 Commit-Queue: Yashar Dabiran <yashard@google.com> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
-
Michael van Ouwerkerk authored
TBR=bsheedy Bug: 951375 Change-Id: I9e891f4353ba30d518562e8b592256684f8537d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564076Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#649845}
-
Elly Fong-Jones authored
TBR=avi@chromium.org Bug: None Change-Id: I89909c5855d69573d44c6eaf98bea86728bd79c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561612Reviewed-by:
-
Jan Krcal authored
The pervious CL 1563930 disregarded the fact the the initial Wait() calls IsExitConditionSatisfied() directly without exercising CheckExitCondition(). This Cl fixes that and implements the logic in IsExitConditionSatisfied(). Bug: 921386 Change-Id: I8974c13cdba54a0579e41c865a44ed67efcb9ca7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563995 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#649843}
-
David Jean authored
For now, keep two versions of CreateLogoVendor, one with and one without UrlLoader. Second one will be removed when implementation of CreateLogoVendor is updated. Bug: 907527 Change-Id: Ieef47388d9d78423344481259f21dd56a8618a7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546299 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#649842}
-
Yashar Dabiran authored
This CL is part of the efforts to use |RuntimeEnabled| attribute for origin trial features instead of |OriginTrialEnabled| and to be able to remove |OriginTrialEnabled| completely. Design doc for the overall change: https://docs.google.com/document/d/1Qog5qwZ-6Rfx10AKkJxN-LrwhCw_GJ1xdLoQSnpsT1Q Summary of the logic: 1. runtime_enabled_features pickle file is processed in compute_interfaces_info_individual.py to be put into the component_info, which is passed to the IDL compiler as part of the info_provider. 2. The runtime_features map is fetched from component_info and is passed to origin_trial_feature_name() and runtime_enabled_feature_name() (in v8_utilities.py) to determine whether the feature is a runtime feature or an origin trial feature. * CL also changes all bindings-generated OT calls from origin_trials::<feature>Enabled() to RuntimeEnabledFeatures::<feature>Enabled() * For the test idls, A mock runtime_enabled_features.json5 is created that has all the runtime features used in the tests. Bug: 934451 Change-Id: I07346e1127c2f0fecc6687201c9592191b60f045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557871 Commit-Queue: Yashar Dabiran <yashard@google.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#649841}
-
Mike West authored
We're aiming to ship most of Fetch Metadata before we've resolved `Sec-Fetch-Dest` completely. This patch adds another feature flag and RuntimeEnabledFeature to allow that. Bug: 843478 Change-Id: I392e20b0bb5a5ab117a720e5d3800258fd3e6e9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554662Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Auto-Submit: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#649840}
-
Greg Thompson authored
Tests that tickle local_discovery result in the Windows firewall dialog appearing. Once onscreen, this dialog hangs around in the foreground until dismissed by the user. I suspect that this dialog could linger on bots between test runs, resulting in failures in subsequent interactive_ui_tests (or similar) runs that require bringing windows to the foreground. BUG=951386,711256 Change-Id: If3ad0fdb70b26840ce76f617e1662f58ecd67707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564157Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#649839}
-
Jordan Demeulenaere authored
Before: * https://screenshot.googleplex.com/BpQHiNsZkrK.png After: * https://screenshot.googleplex.com/9m7YwMN9L03.png * https://screenshot.googleplex.com/udJvgvVyR5k.png Binary-Size: Adding image resources for the Autofill Assistant feature that will be in a DFM before M75. Change-Id: I0e0506dc235a3b06f712e47ddb0d01ebd3ede337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560155 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#649838}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/48cce4d9e827..7061e51b48ee git log 48cce4d9e827..7061e51b48ee --date=short --no-merges --format='%ad %ae %s' 2019-04-11 hta@webrtc.org Expose DtlsTransport::remote_ssl_certificates 2019-04-11 titovartem@webrtc.org Revert "Fix threading model of video quality test with audio enabled" 2019-04-11 danilchap@webrtc.org Introduce media engine factory where TaskQueueFactory dependency can be set. Created with: gclient setdep -r src/third_party/webrtc@7061e51b48ee The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:907849,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I7eb280f0e1c53b188744b212b2cfe515b1952eba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564530Reviewed-by:
-
David Jean authored
I removed the tab_grid_url_loader and replaced it by the regular case. Instead I’m passing in a isModal flag, when coordinators/controllers are originating from tab grid, since the only meaninfull difference compared to regular case is that tab_grid_url_loader always opens in a foreground, new, tab. Remains one external use of UrlLoader, to be removed in another CL. Bug: 907527 Change-Id: I669a21fe8724842dc4ef602e880c0d47d22d96e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545303 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
-
Maksim Moskvitin authored
GetForcedDataTypes() for supervised users used to return all datatypes controlled by APPS user settings except ARC_PACKAGE. We are going to introduce new enum for UserSelectableTypes() and this function should return this enum after refactoring. It means, that after refactoring ARC_PACKAGE will be enforced by putting APPS in the result. Absence of ARC_PACKAGE in old result of GetForcedDataTypes() should be a bug. Bug: 906611 Change-Id: I8a5ef8cca7ac442529723b8e445924b9b22cef4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564110Reviewed-by:
-
Kent Tamura authored
This CL has no behavior changes. TBR=yhirano@chromium.org, yutak@chromium.org Change-Id: I7d1a16b5760a20a3fd7e685aa248a28978fac491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564273Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#649834}
-
Jérôme Lebel authored
Before: https://drive.google.com/open?id=1GKDMouROHxUjhHsyQ-c-ys8N4HxAgykk After: https://drive.google.com/open?id=10y3l1arRrSAxFphOnsHAuEZh9Z8Oo4tW Bug: 950993 Change-Id: I5996c54a1cacca87d06e55269ead1012b74e4aa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564154Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#649833}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0ffd28c7. With Chromium commits locally applied on WPT: 0a8f3ffa "Use testdriver Action API in WPT pointerevent touch tests - Part 2" adc34f41 "Fix web_test pointerevent_coordinates_when_locked on wpt" 8659792f "[WPT] Move wrapResult to common.js and clarify requestVia*() return values" e525003f "Do not resume a suspended BaseAudioContext when AudioWorklet starts" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I18cfa217145aab17619cf59ce5fa223a52d32bc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564330Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649832}
-
Raul Tambre authored
The script still works with Python 2. There are no intended behaviour changes. Bug: 941669 Change-Id: I3ec0bcaf05a6b388a9d47d123364ec27b6e927a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559959 Auto-Submit: Raul Tambre <raul@tambre.ee> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#649831}
-
Jordan Demeulenaere authored
Bug: 933070 Change-Id: Ib921de52cbff937e63c3de568e3d8c9fde7220fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552833 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#649830}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7ac0d5f348f0..48cce4d9e827 git log 7ac0d5f348f0..48cce4d9e827 --date=short --no-merges --format='%ad %ae %s' 2019-04-11 hta@webrtc.org Parse "max-message-size" parameter from SCTP SDP description Created with: gclient setdep -r src/third_party/webrtc@48cce4d9e827 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:943975 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I497276362f6e23de56af76336fb5dc2d08592016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564370Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3304bd02..43d68733 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia9a189d80e5fd0fdec13d8e725dd182088160feb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564210Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649828}
-
Clemens Arbesser authored
[Autofill Assistant] Fixed terms & conditions radio buttons initially not triggering the listener notification. This is a hotfix for b/130205250. A proper fix is part of the larger PR refactoring: http://crrev/c/1538294 Bug: b/130205250 Change-Id: I3f28085b568dd73889ad989551b04a570226f2ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564151Reviewed-by:
-
Lutz Justen authored
The KerberosCredentialsManager is a layer on top of the Kerberos daemon D-Bus client (KerberosClient). It should be used to add/remove accounts, set configuration and authenticate. It makes sure that Kerberos tickets get put into a place where GSSAPI finds them, so Kerberos web authentication works. BUG=chromium:933798 TEST=Ran unit tests and ExistingUserControllerActiveDirectoryTest.* after temporarily enable disabled tests. Change-Id: I4287c269677322436f6809d07cc14105390397b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1511397 Commit-Queue: Lutz Justen <ljusten@chromium.org> Reviewed-by:Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#649826}
-
Ioana Pandele authored
This case was previously handled by the hiding logic of the autofill popup. Since the generation popup's handling logic has been separated from the autofill popup, this needs to be handled by the passwords code. Bug: 949090 Change-Id: I68ecec3c7eef983ab7d1f3ddcd987f8383422f11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552851 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#649825}
-
Jan Krcal authored
This CL adds debug logs to better understand why this integration test is flaky on Mac. Bug: 917498 Change-Id: Ibba39c5e72a5f543fea6ce9b6c0a2d475246f656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563854 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
-
Kush Sinha authored
Navigating to Gaia URLs like /AddSession opens the Chrome OS Account Manager (for adding a session) but we want to ensure that this does not happen for background navigations. Please check the attached bug for context. Bug: 945218 Change-Id: I0cafbe62b0215a9bcd9e8190031c9baab9c96466 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561139Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/71ec39e355a8..7ac0d5f348f0 git log 71ec39e355a8..7ac0d5f348f0 --date=short --no-merges --format='%ad %ae %s' 2019-04-11 sprang@webrtc.org Replace usage of old SetRates/SetRateAllocation methods Created with: gclient setdep -r src/third_party/webrtc@7ac0d5f348f0 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iea4e5a2c44dbc0fa78dfd2da34e86c26500a0504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563618Reviewed-by:
-
Nicholas Verne authored
Now says "Connect to Linux" Bug: 951522 Change-Id: I31ab3abc9bbe1dc1420e453fb2b2644963862647 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563533Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#649821}
-
Jérôme Lebel authored
Adding dispatcher to GoogleServicesNavigationCoordinator and AdvancedSigninSettingsCoordinator, to be able to open links from the advanced sign-in settings. Bug: 883075, 948681 Change-Id: I18db56209daa32a5b1c3ad6e7b2c26878b51c0f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559310Reviewed-by:
-
