- 06 Nov, 2020 40 commits
-
-
Ben Mason authored
This reverts commit 8933d94d. Reason for revert: Translation failure crbug/1146426 Original change's description: > Add support for items for bool policies > > Make this a required field for new main/bool policies. > > Since the item field isn't always copied over from main policies, > also add a warning check that the policy descriptions describe the > various cases. > > Add items to MediaRecommendationsEnabled and BlockThirdPartyCookies. > > No-Presubmit: true > BUG: 1139306 > Change-Id: I519202ed9eeb491b27f804f26fbe94ae8e501598 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507457 > Commit-Queue: Chris Sharp <csharp@chromium.org> > Reviewed-by: Yann Dago <ydago@chromium.org> > Reviewed-by: Owen Min <zmin@chromium.org> > Reviewed-by: Pavol Marko <pmarko@chromium.org> > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#824431} TBR=pastarmovj@chromium.org,csharp@chromium.org,zmin@chromium.org,pmarko@chromium.org,ydago@chromium.org Change-Id: I78f3830a59e52c104fd4cbdd48e452c7612e9960 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521617Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#824864}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I699e1e43313ca5ced45a5906e3890e4390f4d7f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523217Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824863}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1604609790-bc5437f446ee5ad42df312047e176901e766dccd.profdata to chrome-win64-master-1604653017-42c23ccace2f0081edeac3e89e9dffaf10021d96.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Icbe3df52c93fbf35649c3ecf1dbebe1c8f56f812 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521206Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3d5d22136720..86a7c52a9341 2020-11-06 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-11-06 yangguo@chromium.org Extend infra owners in support of l10n reviews 2020-11-06 aerotwist@chromium.org TypeScriptify OverViewGrid.js 2020-11-06 jacktfranklin@chromium.org Fix resettting user focused cell in data-grid. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I267e751f06354f556871529d364f99ba03ab8b03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523215Reviewed-by:
-
Dominique Fauteux-Chapleau authored
This CL refactors tests in downloads deep scanning to use Connector policies directly instead of the indirect helpers that map to legacy policies. Bug: 1109242 Change-Id: I040ae5acbc96008cfc70eb98d2bce0a806a26d12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521850Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#824860}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1604642156-6de658d746d924ba0793cdd79cc80ba08c1ee69e.profdata to chrome-mac-master-1604663931-0e7a1a6cfe18868c94b28acade631941d35c92c1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iadd3f58769fa100b9fde51928959f751492899dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523214Reviewed-by:
-
Christian Biesinger authored
R=ikilpatrick@chromium.org, mstensho@chromium.org Fixed: 1145358 Change-Id: Ia078ba495ea717ad0d1e1acda428b3d3704acd0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521041 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#824858}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1604642156-a25919d317c2bef6f3d61358a8f8892267c9f548.profdata to chrome-linux-master-1604663931-9bcb947a0377607416b3fb61f11cb5b7ddd933e4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie6cbaf943b59bc0bc583f17b547add3f3f2bb1f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523213Reviewed-by:
-
Illia Klimov authored
As part of the Flash/Plugins deprecation, the resource identifier becomes obsolete. This CL removes resource_identifier from the OriginIdentifierValueMap. This CL does not include Observer, Providers and HostContentSettingsMap. They will be cleaned separately. This CL does not change methods API but makes sure resource identifier is not used. Bug: 1134547 Change-Id: I4e222d928b80c73e2a1780619f641333d7a0bc6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517722Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Illia Klimov <elklm@google.com> Auto-Submit: Illia Klimov <elklm@google.com> Cr-Commit-Position: refs/heads/master@{#824856}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/dc515d41bba9..0781b693fa2d 2020-11-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from ad54c71632cc to 612ded0654a0 (4 revisions) 2020-11-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from 51c1c5ab56d5 to bd0ebb680792 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: I7d35d7e76bd916f98fc0de933907afdd333d0661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521207Reviewed-by:
-
Jordan Demeulenaere authored
This CL replaces the pick_one Selector filter by the nth_match filter, that matches the nth element of the elements currently matching. See [1] for more background. [1] https://docs.google.com/document/d/167LaI_WQNr31wBuO3DNlCPD2sx3If2GOHpPsT4atXIk Change-Id: I3024239d256201fe604c0c72b4985a9de3d45201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517535 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#824854}
-
arthursonzogni authored
Add tests about crossOriginIsolated, from a context where SharedArrayBuffer isn't enabled by default (e.g. like Android). I discussed with sigurds@ about crossOriginIsolated. I thought I could trigger a CHECK. I turns out, I wasn't able too. Instead, this just opened this question: https://crbug.com/1144838 Bug: 1144104, 1144838 Change-Id: I50f3ceb54ceef9f5029d7d28fcd346e3cfa758a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514211Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#824853}
-
Julie Jeongeun Kim authored
This CL adds crash key logging to track WebRequestType and URL on WebRequestPermissions::HideRequest(). Bug: 1145496 Change-Id: Ib4658ef497c922b181e84d530bf05ab4e532dc5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521885 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#824852}
-
Ewann authored
This CL fixes tests impacted by the EnableCloseAllTabsConfirmation feature before submitting the config. Bug: 1119319 Change-Id: I32c86bcc8f6132fbd93d04578e7cbc9d4460d543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443852 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#824851}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I08e7c26feeba95600d7c98a67829cd06d9788e83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523093Reviewed-by:
-
Clemens Arbesser authored
This hopefully fixes/workarounds a test failure. The fix is to avoid using the bottom sheet in the UI test directly. I was not able to repro the originally reported test failure, so this is only a best guess effort for now. We will have to monitor if this has indeed fixed the problem. I have created b/172639096 to track the root cause of the test failure. Bug: 1146084 Change-Id: I6ef0cb4f05717805f4ba7dd36b6c0c682b89ef3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521817 Commit-Queue: Clemens Arbesser <arbesser@google.com> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Auto-Submit: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#824849}
-
Antonio Gomes authored
... as well as kFrameRestoreLookKey. Dependency/include graph: - frame_util.cc uses kWindowManagerManagesOpacityKey and kFrameRestoreLookKey; - frame_utils.h is included by frame_header.cc; - frame_header.h is included by default_frame_header.h - browser_non_client_frame_view_ash.cc includes default_frame_header.h. So, in order to free browser_non_client_frame_view_ash.cc|h from including //ash/ headers, the items above will migrate step by step to //chromeos/ui. BUG=1113900 R=jamescook@chromium.org, sky@chromium.org Change-Id: If1ba34dca49f752ec3c9247e366879c10455a5c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521691Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#824848}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0891c367b8b2..d57e268ce139 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I1d7344bed6303d1ac2f9b7e9f916380525d19303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522590Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d57e268ce139..1e9cf1a8e1bd 2020-11-06 treehugger-gerrit@google.com Merge "protos: Use int32 instead of uint64 for ProcessSnapshot's pid field" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I0b541402505a8806376808dbd72348a29269d843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522589 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/41bb19c60930..9cde39469149 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC clamy@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:897470 Tbr: clamy@google.com Change-Id: I2225589c12002981314cc9098f89292f69915129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522586Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824845}
-
Mirko Bonadei authored
Instead of generating absl .def files at roll time, this CL switches the build config to generate the required .def file on the fly while building. The advantages are: 1. No need to re-generate .def files when something external to absl changes and affects .def files (e.g. when a new compiler optimization it enabled). 2. No need to hard-code supported build flavors in the .def generator script, resulting in multiple .def files checked-in. On the other hand, this makes the build slightly slower than it is today because reading all absl object files to generate the .def file can take a few seconds. Bug: 1046390 Change-Id: If3a8fb3dca0ed75dbd85655cff1263853dcc146a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270094 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#824844}
-
Sylvain Defresne authored
ChromeBrowserStateClient returned a hardcoded value of "1" when asked for the number of BrowserStates as using browser_state_info_cache.h would have introduced a circular dependency. Fix the circular dependency by moving browser_state_info_cache.h from the //ios/chrome/browser/browser_state:browser_state_impl target to the //ios/chrome/browser/browser_state target instead. Bug: 991575 Change-Id: I589fa36db8dc0e85d546982aaa096fd5a958b23d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521001 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#824843}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/eb8e1e991bc9..3d5d22136720 2020-11-06 aerotwist@chromium.org [unit test] Isolate connection and environment helpers 2020-11-06 yangguo@chromium.org Add stack trace for assertion failures in e2e tests 2020-11-06 aerotwist@chromium.org Updates coverage config 2020-11-06 tvanderlippe@chromium.org Use TypeScript-authored files in developer_resources/ 2020-11-06 tvanderlippe@chromium.org Use TypeScript-authored files in security/ 2020-11-06 tvanderlippe@chromium.org Use TypeScript-authored files in layers/ 2020-11-06 tvanderlippe@chromium.org Use TypeScript-authored files in help/ 2020-11-06 tvanderlippe@chromium.org Use TypeScript-authored files in web_audio/ 2020-11-06 yangguo@chromium.org Introduce allow list for expected assertion failures If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1132333,chromium:1145969 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I48cbe89c881e13a3498feee0019f72733d139059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522588Reviewed-by:
-
Hajime Hoshi authored
Before this CL, not-stored reasons are not recorded when the browsing instance is not swapped. This means we are missing records in these cases. This CL fixes this by adding an additional record at RenderFrameHostManager::ShouldProactivelySwapBrowsingInstance Bug: 1134847 Change-Id: Id683b7f94de4e8cb81da0b5779f56a496d040b96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466002 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#824841}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a61d347b99c9..ccc9dd2835f5 2020-11-06 landrey@webrtc.org Log full diagnostic data during insertion If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1146040 Tbr: skyostil@google.com Change-Id: I5fdaf1b7c52bed201b031381edd7441c205d3352 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522587Reviewed-by:
-
Stephane Zermatten authored
Before this change, ElementPositionGetter would round each coordinate it got before computing the center, then rounding it. With this change, only the center is rounded. This was puzzling. This change is expected to have no effect, as all coordinates should be integer values to begin with. It's just a cleanup. Change-Id: Ib0ac75f6e08d825f1521e32325c87672eb9f9d20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521734Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#824839}
-
Kyle Horimoto authored
Bug: 1146224 Change-Id: Ie240478c901e1ed791f05002d4f9d906072b1b45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522507 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#824838}
-
Karandeep Bhatia authored
Follow-up from https://chromium-review.googlesource.com/c/chromium/src/+/2419607. This documentation is not yet exposed on the docserver. BUG=113513 Change-Id: I164efcf67789e699b35322d1a5b6e519147944b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519041 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#824837}
-
Illia Klimov authored
Bug: 1142861 Change-Id: Ia1f80f799a7b809316fb040d49d8cc3c99946453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503692 Auto-Submit: Illia Klimov <elklm@google.com> Commit-Queue: Illia Klimov <elklm@google.com> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#824836}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b680e487. With Chromium commits locally applied on WPT: 9a749c24 "[scroll-animations] Handle implicit 'auto' offsets correctly" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I7ec9f31d4fc2153623d578c83184e3354404bd18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522232Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824835}
-
Ewann authored
This CL replaces the font for the 'Tap to cancel' label. Bug: 1146347 Change-Id: I0e7922f7fb71c5e6d23c65781677f66b734a1810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523031Reviewed-by:
-
Jan Krcal authored
This reverts commit 6b7290b3. Reason for revert: memory regression on Mac (crbug.com/1146299) Original change's description: > [Profiles] Use new colored default avatars for taskbar badges > > Recently, all logic around profile avatars has been integrated into > ProfileAttributesEntry::GetAvatarIcon() incl. new features such as > colored default avatars. > > This CL updates code that generates taskbar badges on Windows to > delegate most of its logic to GetAvatarIcon(). Only the pieces needed > for obtaining ImageLoadStatus remained in this code. > > The only behavioral change is for non-GAIA avatars: high-res / > 2x windows old avatars are returned instead of low-res avatars. This > means more downscaling is needed than before. This will be addressed > by further CLs that will make GetAvatarIcon() respect preferred_size in > more cases. > > Bug: 1122559 > Change-Id: I5eecc7c6647dc78f9ff92d74edb64214a48e8e63 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514153 > Commit-Queue: Jan Krcal <jkrcal@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Auto-Submit: Jan Krcal <jkrcal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#824494} TBR=droger@chromium.org,jkrcal@chromium.org Change-Id: I66f7b806a25b910d35b55f02805c4c8216049f55 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1122559, 1146299 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521118Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#824833}
-
Tanmoy Mollik authored
The sign in API uses CoreAccountInfo. So in the long run its better to use CoreAccountInfo for helper methods that interact with sign in API. This cl refactors AccountManagerTestRule so that the methods to add account and check signed in account return CoreAccountInfo. Bug: 1117006 Change-Id: I08245ea7b6325b1a62b3c27d53cc1f9877e9e75d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521571Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#824832}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ia6afa428aa33860f425f2b934391fbdbfa3eceb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522432Reviewed-by:
-
Tanmoy Mollik authored
Updating the promo state forcefully is not required for these tests. This cl does not change the behavior of the tests. It changes how the environment is set up. This cl also enables testPersonalizedSigninPromoInBookmarkPage test. Bug: 1123478, 1133426 Change-Id: I4382f857ca1e91676404fce1a1c6e76c315e4493 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517684Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8b665312ca15..0891c367b8b2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I573f8984ef5f6aae3f7aa9990f4c29d492749962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522007Reviewed-by:
-
Friedrich [CET] authored
This reverts commit 264cfbbf. Reason for revert: The fix seems to be worse than the problem (see newly linked bugs). Original change's description: > [Desktop][PwdCheck] Even icon paddings > > With https://crrev.com/c/2260639, the paddings weren't distributed > evenly anymore (start/end padding) causing misalignments. > Additionally, the non-square icon dimensions caused rounding errors > increasing that effect. > > This CL ensures consistent paddings for RTL and LTR mode. Screenshots > are in the linked bug. > > Bug: 1144629 > Change-Id: Ied4af63de6d94abb2b6510cfd061a970f8f98da8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513600 > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823262} TBR=jdoerrie@chromium.org,fhorschig@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1144629, 1145943, 1145931 Change-Id: Ifa4e0cd1cb705dec80968392506582c4894edd50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521512Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#824828}
-
Yuki Shiino authored
It turned out that a single function collect_forward_decls_and_include_headers does the job for IDL callback functions, IDL callback interfaces, IDL dictionaries, and upcoming IDL unions, so moves the function into codegen_utils.py to be shared among them. Bug: 839389 Change-Id: Ieee0e75388a90367c04da9c2adb40ce4bfad072a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521873Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#824827}
-
Regan Hsu authored
Accessing an empty sessions::SessionTab's |navigations| vector is resulting in an out of bounds access, causing BrowserTabsMetadataFetcherImpl to crash. Fixed: 1142562 Bug: 1106937 Change-Id: I0ec890135f6acafd61a39a7d06b52ef1956bed96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522497 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#824826}
-
Jan Krcal authored
The test CreateSignedInProfileSigninAlreadyExists is flaky on multiple platforms. Bug: 1144065 Change-Id: I6382c9d8757de99c1e5575a1101bdae647dc0cdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521184 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#824825}
-
![Friedrich [CET]'s avatar](https://secure.gravatar.com/avatar/f27b033ce4cd5371e6e413eed6db870f?s=80&d=identicon "Friedrich [CET]")
