GitLab

Revert of [ObjC ARC] Converts ios/chrome/browser/ui/toolbar:toolbar to ARC. (patchset #3 id:40001 of https://codereview.chromium.org/2808873002/ )

Reason for revert:
Reverting since ios_chrome_smoke_egtests its failing and it broke the autoroller.

https://uberchromegw.corp.google.com/i/internal.bling.main/builders/chromium-autoroller/builds/373/steps/ios_chrome_smoke_egtests%20%28iPhone%205s%20iOS%2010.0%29/logs/stdio

Original issue's description:
> [ObjC ARC] Converts ios/chrome/browser/ui/toolbar:toolbar to ARC.
>
> Automatically generated ARCMigrate commit
> Notable issues:None
> BUG=624363
> TEST=None
>
> Review-Url: https://codereview.chromium.org/2808873002
> Cr-Commit-Position: refs/heads/master@{#467947}
> Committed: https://chromium.googlesource.com/chromium/src/+/8b6e180812e904c59ff0d72a3b2d4d8df7d7f37b

TBR=stkhapugin@chromium.org,sdefresne@chromium.org,gambard@chromium.org,olivierrobin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=624363

Review-Url: https://codereview.chromium.org/2852713002
Cr-Commit-Position: refs/heads/master@{#467981}

BUG=694750

Review-Url: https://codereview.chromium.org/2832573002
Cr-Commit-Position: refs/heads/master@{#467980}

BUG=712809

Review-Url: https://codereview.chromium.org/2847893003
Cr-Commit-Position: refs/heads/master@{#467979}

Revert of Follow up from ARC conversion (patchset #2 id:20001 of https://codereview.chromium.org/2851713002/ )

Reason for revert:
Revert since its needed to revert https://codereview.chromium.org/2808873002 which broke the roller.

Original issue's description:
> Follow up from ARC conversion
>
> Addressing the comments raised in https://codereview.chromium.org/2808873002/
>
> BUG=none
>
> Review-Url: https://codereview.chromium.org/2851713002
> Cr-Commit-Position: refs/heads/master@{#467951}
> Committed: https://chromium.googlesource.com/chromium/src/+/6273712b527b4e13ec0d854fcd11e0b5e034eb2a

TBR=stkhapugin@chromium.org,sdefresne@chromium.org,gambard@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none

Review-Url: https://codereview.chromium.org/2849853002
Cr-Commit-Position: refs/heads/master@{#467978}

This CL replaces blink::GetContentDispositionType implementation by
net::HttpContentTypeDisposition. There are some behavior differences between
these two implementations, but because the former is used only to see if
the disposition type is attachement, there is only one difference that matters.
The former returns kAttachement for empty content disposition type (e.g.,
";foo"), but the latter returns kInline. It looks the former is intended to
return kNone, but it returns kAttachment due to misuse of confusing
WTFString::Split interface.

Hence this CL adds IsContentDispositionAttachment and makes it return false
when a value with an empty content disposition type is given.

BUG=696967

Review-Url: https://codereview.chromium.org/2844353003
Cr-Commit-Position: refs/heads/master@{#467977}

This is part of a series of CLs to get rid of the notion of
"Instant support" entirely, see
https://bugs.chromium.org/p/chromium/issues/detail?id=627747#c41

BUG=627747

Review-Url: https://codereview.chromium.org/2847083002
Cr-Commit-Position: refs/heads/master@{#467976}

VR no longer uses an HTML UI, so no longer uses the incognito profile.

BUG=

Review-Url: https://codereview.chromium.org/2845023003
Cr-Commit-Position: refs/heads/master@{#467975}

This is the first of a series of CLs to get rid of the notion of
"Instant support" entirely, see
https://bugs.chromium.org/p/chromium/issues/detail?id=627747#c41

BUG=627747

Review-Url: https://codereview.chromium.org/2845303002
Cr-Commit-Position: refs/heads/master@{#467974}

The test has been converted upstream to use ASSERT_DEATH_IF_SUPPORTED
and can now be built on iOS.

BUG=595645

Review-Url: https://codereview.chromium.org/2849713004
Cr-Commit-Position: refs/heads/master@{#467973}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/e80a730b1b1b..5fa840e82c50

$ git log e80a730b1..5fa840e82 --date=short --no-merges --format='%ad %ae %s'
2017-04-28 hjd [tracing] Add tests for ui/base/event_presenter.html

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I151ce9756fac64c0b3cceed142351f30c7f77005
Reviewed-on: https://chromium-review.googlesource.com/489694
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467972}

This CL lands server change 152524616 by yasong.

BUG=488484

Review-Url: https://codereview.chromium.org/2844963005
Cr-Commit-Position: refs/heads/master@{#467971}

Comparison of hashes of all suffixes of input with the sync password hash is implemented.

BUG=657041

Review-Url: https://codereview.chromium.org/2847743002
Cr-Commit-Position: refs/heads/master@{#467970}

Add net/spdy/PRESUBMIT.py that checks files in net/spdy/core and
net/spdy/platform/api to make sure that classes, functions, and macros
that have been factored out into net/spdy/platform are only used in that
form in shared code.

Review-Url: https://codereview.chromium.org/2847613002
Cr-Commit-Position: refs/heads/master@{#467969}

ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and
base/task_scheduler/post_task.h within its scope. It should be
instantiated in everytest that uses either of these APIs
(i.e. no test should instantiate a MessageLoop directly).

Motivation for ScopedTaskEnvironment can be found in:
https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3Pkk/edit

BUG=708584
R=gab@chromium.org
TBR=marq@chromium.org

Review-Url: https://codereview.chromium.org/2846073002
Cr-Commit-Position: refs/heads/master@{#467968}

Also s/ActiveDirectoryAccountData/ActiveDirectoryAccountInfo

BUG=662400
TBR=xiyuan@chromium.org

Review-Url: https://codereview.chromium.org/2841103002
Cr-Commit-Position: refs/heads/master@{#467967}

Revert of [WebAPKs] Make WebAPK update flow more sensible (patchset #4 id:100001 of https://codereview.chromium.org/2827233006/ )

Reason for revert:
broke official-* bots, see crbug.com/716330

Original issue's description:
> [WebAPKs] Make WebAPK update flow more sensible
>
> Previously, whenever the shell_apk in shell_apk_version.gni there was a period
> of time during which
> - Chrome tries to update the WebAPK because the "shell_apk" version with which
>   Chrome is compiled with was updated
> - The WebAPK server is unable to fulfill the update request because the new
>   ShellAPK has not yet been uploaded to the WebAPK server
>
> This CL splits shell_apk_version in shell_apk_version.gni into two variables:
> |template_shell_apk_version| and |expected_shell_apk_version|
>
> The new flow for updating android/webapk/shell_apk will be:
> 1) Write CL which:
>    - Makes changes to code in android/webapk/shell_apk
>    - Increments |template_shell_apk_version|
>    This will:
>    - Update the template ShellAPK which is built on the official build bot
>    - Trigger an alert that the ShellAPK on the WebAPK Minting Server needs to
>      be updated
>    - Does not affect the "WebAPK update logic".
> 2) Upload new ShellAPK template to the WebAPK Minting Server
>    At this point:
>    - new WebAPK installs will have the updated shell.
>    - Chrome will still not request updates to the new ShellAPK version
> 3) Write CL which:
>    - Increments |expected_shell_apk_version|
>    This will:
>    - cause Chrome to request updates to the new ShellAPK version
>
> BUG=708053
>
> Review-Url: https://codereview.chromium.org/2827233006
> Cr-Commit-Position: refs/heads/master@{#467708}
> Committed: https://chromium.googlesource.com/chromium/src/+/d71abed75b07b4b9fc50591cbeb2b6c8874bf448

TBR=hartmanng@chromium.org,hanxi@chromium.org,zpeng@chromium.org,dominickn@chromium.org,pkotwicz@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=708053

Review-Url: https://codereview.chromium.org/2845943006
Cr-Commit-Position: refs/heads/master@{#467966}

This is required to land https://chromium-review.googlesource.com/c/483199/ which changes the behavior. Currently those tests hardwire wrong behavior that exposes internal implementation details. The change in the referred CL makes it more uniform, and in line with at least Firefox.

BUG=chromium:713732

Review-Url: https://codereview.chromium.org/2831923003
Cr-Commit-Position: refs/heads/master@{#467965}

This avoids sending a second ack close frame when we get a flow
control request from the renderer while waiting for the connection to
be closed.

BUG=

Review-Url: https://codereview.chromium.org/2845033002
Cr-Commit-Position: refs/heads/master@{#467964}

https://heycam.github.io/webidl/#legacy-callback-interface-object
Legacy callback interface needs an interface object, but it has no instances and
no prototype.

This CL fixes 19 failures in external/wpt/dom/.

Implementation:

* This CL adds WrapperTypeInfo for NodeFilter, but we never make wrappers for
  NodeFilter.

* Add kWrapperTypeNoPrototype
  window.NodeFilter should not have a prototype, but it should be a constructor.
  V8PerContextData::ConstructorForTypeSlowCase() rejected to return a constructor
  if the type had no prototype. This CL introduces kWrapperTypeNoPrototype to
  avoid this issue.

* Add new legacy_callback_interface.*.tmpl
  Because NodeFilter can't use generated methods for callback interface for now.

* Source/bindings/tests/idls/core/TestLegacyCallbackInterface.idl
  Add it for quick check of legacy callback interface generation.

BUG=591919

Review-Url: https://codereview.chromium.org/2837923003
Cr-Commit-Position: refs/heads/master@{#467963}

This reverts the non-test part of https://codereview.chromium.org/2738773004/
but leaves most of the test changes in place since they should now work
regardless of the setTimeout behaviour.

BUG=711044

Review-Url: https://codereview.chromium.org/2853493002
Cr-Commit-Position: refs/heads/master@{#467962}

Hidden behind a new feature "OneGoogleBarOnLocalNtp".

BUG=583292
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2819553003
Cr-Commit-Position: refs/heads/master@{#467961}

R=kbr@chromium.org
BUG=670098
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2852453002
Cr-Commit-Position: refs/heads/master@{#467960}

BUG=

Review-Url: https://codereview.chromium.org/2844993005
Cr-Commit-Position: refs/heads/master@{#467959}

Revert of [tools/perf] Disable load:tools:drive system health story (patchset #1 id:1 of https://codereview.chromium.org/2848573002/ )

Reason for re-enabling the story:
The V8 CL that was causing the crash has been reverted in https://crrev.com/2852623002

Original issue's description:
> [tools/perf] Disable load:tools:drive system health story
>
> Story shows a high failure rate on many different perf bots.
>
> TBR=nednguyen@google.com
> BUG=715936
>
> Review-Url: https://codereview.chromium.org/2848573002
> Cr-Commit-Position: refs/heads/master@{#467640}
> Committed: https://chromium.googlesource.com/chromium/src/+/3721c3608a5aef73b1762e6906257c9d9f8e0d36

BUG=715936

Review-Url: https://codereview.chromium.org/2851703003
Cr-Commit-Position: refs/heads/master@{#467958}

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/f66bef3..5515dcd

$ git log f66bef3..5515dcd --date=short --no-merges --format=%ad %ae %s
2017-04-28 denicija@webrtc.org iOS/MacOS:Refactor metal rendering by extracting common implementation in separate super class.
2017-04-28 henrik.lundin@webrtc.org Add NetEqInput::PacketData::ToString method
2017-04-28 henrik.lundin@webrtc.org NetEq tests: BUILD target reorg
2017-04-27 zijiehe@chromium.org Forward capturer_id between DesktopFrame and its implementations
2017-04-27 glaznev@webrtc.org Reland of Support adding and removing MediaRecorder to camera 2 session. (patchset #1 id:1 of https://codereview.webrtc.org/2844233002/ )
2017-04-27 mbonadei@webrtc.org Hiding problematic targets from chromium
2017-04-27 ossu@webrtc.org Have AudioSendStream register CNG payload types with the RtpRtcpModule.
2017-04-27 brandtr@webrtc.org Add warning about timestamp non-monotonicity in the frame buffer.
2017-04-27 hewwatt@gmail.com This CL adds RTCMTLVideoView.h and RTCCameraVideoCapturer.h to WebRTC.h in order to fix a build issue that comes up when using WebRTC.framework from swift code.
2017-04-27 kwiberg@webrtc.org Run some peer connection end-to-end tests with an empty audio decoder factory
2017-04-27 magjed@webrtc.org Revert of Support adding and removing MediaRecorder to camera 2 session. (patchset #5 id:80001 of https://codereview.webrtc.org/2833773003/ )
2017-04-27 ossu@webrtc.org Injectable audio encoders: WebRtcVoiceEngine and company
2017-04-27 ossu@webrtc.org Normalize codec names to those used by AcmCodecDatabase.

TBR=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
BUG=

Review-Url: https://codereview.chromium.org/2849793002
Cr-Commit-Position: refs/heads/master@{#467957}

Run task queue observer callback even when there is immediate work
availaible. This will prevent some renderers from stucking in a
throttled state with a fence.

This is a temporary solution enabling delphick@ to revert his patch.
A proper fix and test coverage will come later.

R=skyostil@chromium.org
CC=delphick@chromium.org
BUG=710095

Review-Url: https://codereview.chromium.org/2844223004
Cr-Commit-Position: refs/heads/master@{#467956}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/63f6c513..e353f66b

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2851673003
Cr-Commit-Position: refs/heads/master@{#467955}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/778079b344c8..e80a730b1b1b

$ git log 778079b34..e80a730b1 --date=short --no-merges --format='%ad %ae %s'
2017-04-28 nednguyen [Telemetry] Switch Android platform to no longer uses test ca

Created with:
  roll-dep src/third_party/catapult
BUG=716084,711634


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I9b908c4f313ffe12cf8d75c317a490e5f6fe61cf
Reviewed-on: https://chromium-review.googlesource.com/489618
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467954}

BUG=chromium:496164

Review-Url: https://codereview.chromium.org/2844253005
Cr-Commit-Position: refs/heads/master@{#467953}

The 'motion-rotation' property has been replaced by 'offset-rotate'.

'motion-rotation' is among the properties disabled in M58.

BUG=711937

Review-Url: https://codereview.chromium.org/2840943003
Cr-Commit-Position: refs/heads/master@{#467952}

Addressing the comments raised in https://codereview.chromium.org/2808873002/

BUG=none

Review-Url: https://codereview.chromium.org/2851713002
Cr-Commit-Position: refs/heads/master@{#467951}

Some content suggestions categories are hidden when no content is
available. The UI used to completely ignore them, when when checking
that the list of categories didn't change, that caused the UI's data
to be always considered stale.

We now keep track of these hidden categories, blacklisting them when
they should not be shown, and removing them from the blacklist when
we get notified of a change about them.

BUG=689962

Review-Url: https://codereview.chromium.org/2846123002
Cr-Commit-Position: refs/heads/master@{#467950}

BUG=583682

Review-Url: https://codereview.chromium.org/2852673002
Cr-Commit-Position: refs/heads/master@{#467949}

Revert "Revert of 📺 Move fullscreen web content to a new Activity. (patchset #11 id:200001 of https://codereview.chromium.org/2807663002/ )"

This reverts commit d0f88cff.

TBR=bauerb@chromium.org
BUG=709042

Review-Url: https://codereview.chromium.org/2847823005
Cr-Commit-Position: refs/heads/master@{#467948}

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2808873002
Cr-Commit-Position: refs/heads/master@{#467947}

Automatically generated ARCMigrate commit
Notable issues:static_cast changed to __bridge cast.
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2819283004
Cr-Commit-Position: refs/heads/master@{#467946}

System default string resouce R.string.item_is_selected with expected
pattern %s is changed to %d on Samsung's 5.x  devices
(S4, S5, Note 3, Core Prime etc.). This small change causes
String.format() to throw exception when SimpleMonthView's content description
is requested (for example Accessibility/TalkBack is ON).
In case of Chromium this view is used only at DatePickerDialog.
The solution is to suppress this exception on 5.x devices and give
fixed string to view.

This fix is based on: http://stackoverflow.com/q/28618405
R=mlamouri@chromium.org, leandrogracia@chromium.org, tkent@chromium.org
BUG= crbug.com/710950

Review-Url: https://codereview.chromium.org/2790423002
Cr-Commit-Position: refs/heads/master@{#467945}

BUG=None

Review-Url: https://codereview.chromium.org/2849783002
Cr-Commit-Position: refs/heads/master@{#467944}

BUG=

Review-Url: https://codereview.chromium.org/2847663004
Cr-Commit-Position: refs/heads/master@{#467943}

This CL makes several minor changes to MockAccountManager:
1. Add 'Delegate' to the name, because it implements AccountManagerDelegate and
   should be used with AccountManagerHelper.
2. Replace 'Mock' with 'Fake' in the name.
3. Remove redundant testContext from constructor arguments.

BUG=698258

Review-Url: https://codereview.chromium.org/2845113003
Cr-Commit-Position: refs/heads/master@{#467942}