- 05 Oct, 2020 40 commits
-
-
Josh Simmons authored
This reverts commit 568372e8. Reason for revert: While these now skip the Marshmallow bot due to lack of network, it appears that these still fail on android-pie-x86-rel which apparently does have network access. Will investigate further but rolling this back for now. Original change's description: > Add network restriction for translate tests so we can reenable them. > > These tests were failing on networkless phones in lab. We should probably figure out how to mock out the translate service for these, but for now this is a step in the right direction. > > Bug: 1130712 > Bug: 1127786 > > Change-Id: Ifd7cb1176ae9beb89c1f44268af9c0add9f29a99 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446894 > Commit-Queue: Josh Simmons <jds@google.com> > Reviewed-by: Scott Little <sclittle@chromium.org> > Cr-Commit-Position: refs/heads/master@{#813456} TBR=sclittle@chromium.org,jds@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1130712 Bug: 1127786 Change-Id: Ib2809b0bcf973c841bd1cbb661a5fcd44a71500b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450729Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Josh Simmons <jds@google.com> Cr-Commit-Position: refs/heads/master@{#813850}
-
Elly Fong-Jones authored
It is obsoleted by the ability to set the initially focused view on WidgetDelegate. Bug: 1075649 Change-Id: I668de102313c3923b3e385b85aa640718e4a1d37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450949Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#813849}
-
Dylan Cutler authored
We are interested in seeing if using this method to see which rendering context types a particular client supports leaks identifying information about users that persists across different origins. The previous instrumentation just recorded what types of rendering contexts sites are using, but did not record whether those contexts were supported. This information can be recovered from the new instrumentation in the IdentifiableSurface type I created for this CL. Bug: 973801 Change-Id: I353e8d65af50a4a8e994dfa7f603d5823b88f019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442138 Commit-Queue: Dylan Cutler <dylancutler@google.com> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#813848}
-
Sorin Jianu authored
This is a white space change. Change-Id: Ic58d54926987e7e311f12868863b4520dc69ef23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449993 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#813847}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/25493aef9427..dee4a03873a1 2020-10-05 noreply@google.com Initial import of Cast Core protocol message definitions. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Ifd002fe50349dceff95d4643764f5916df7581cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450517Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813846}
-
Reid Kleckner authored
1. Have //tools/valgrind/OWNERS delegate to //tools/memory/OWNERS. We don't really used valgrind on Chromium anymore anyway. Sanitizer stuff lives in //tools/memory these days. 2. Add Vitaly Buka to OWNERS. He has committed to Chromium more recently than glider@ (May 2020 vs. 2018). 3. Remove bruening@. Derek has moved on to other projects, and Derek has not committed to Chromium since 2016. R=thestig@chromium.org Change-Id: I60caee6ab7163b05a50b50938c4bb2ba349a1452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450271Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#813845}
-
Scott Violet authored
Specifically in NewTabDelegate. BUG=1134224 TEST=covered by tests Change-Id: Icb3dcd49b70e27fc363b9a4a325daa51280f1f87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446716Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#813844}
-
Andre Le authored
- Added a timer to the controller when the button is pressed. If after a long time and the current state is different from the requested state, it means something when wrong and we should switch back to the original state. - Remove the connecting state in the controller. BUG=1106937,1126208 Change-Id: I4f20894e863b4285c9043702f099d6908d558857 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441256 Commit-Queue: Andre Le <leandre@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#813843}
-
Ali Juma authored
This re-enables tests that were broken in iOS 13.4 because of webkit.org/b/211449 and fixed in iOS 14. Bug: 1076598,1076233 Change-Id: I57590c7f1dde81d1104ec4f30f2681a1fa9b6304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446024Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#813842}
-
Jesse McKenna authored
This change replaces the reference to the deprecated "isTestCommand" setting in keybindings.json5 with its replacement, "group": "test". This makes keybindings.json5 match tasks.json5, which uses the new syntax. This also fixes a small typo. Change-Id: Ie5a6cdb22610f27222105ff079e47dddd7160378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432138Reviewed-by:
Chase Phillips <cmp@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#813841}
-
Matt Jones authored
This patch moves the ownership of the top toolbar's overlay to the top toolbar's coordinator. This way, the toolbar has complete control over the visual elements that constitute it. Bug: 1100332 Change-Id: I27e69fd4dc50d24d3ff667b8b833ef9e6d449690 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359737 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#813840}
-
Dana Fried authored
Creates a mode that allows scrolling without a scrollbar in either direction as well as the ability to treat scroll-specific events (e.g. mousewheel events) as horizontal scroll inputs. Changes: * Adds a third scrollbar state: visible but not enabled * Allows enabled/disabled/invisible state for vertical scrollbar as well as horizontal (previously only horizontal scrollbar could be hidden/ disabled). * Adds the option to treat vertical scroll events as horizontal, so that for example a mousewheel or vertical scroll gesture can allow a horizontal-scroll-only pane to scroll. Bug: 1122214 Change-Id: I7f01b26b33ede76e1903ee37a493a2818b7b1103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433254 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#813839}
-
Leonard Grey authored
This change fleshes out the model sent to the WebUI layer by CommanderHandler. It also switches inline strings for constants and sends a new WebUI message to reinitialize state on show. Bug: 1014639 Change-Id: I2e2fb7b4403cc201272feb01c53901243b8fe377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446774Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#813838}
-
Natalie Chouinard authored
This reverts commit 5a4717f4. Reason for revert: Compile failures on downstream build https://crrev.com/i/3309264 not yet rolled. Original change's description: > Rename font-related Chrome resources part 3/3 > > BUG=1129255 > TBR=twellington > > Change-Id: I7acff50f82c1a0bc0b7a2d55e09cd307b447f033 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446540 > Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#813828} TBR=yfriedman@chromium.org,pkotwicz@chromium.org Change-Id: I90d3fc2d8fb97047ca0edc3b1d955fcdfafecbd9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1129255 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450919Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#813837}
-
James Vecore authored
The fast advertising uuid was not being passed through to StartDiscovery in the NearbyConnections layer. Fixed: 1134779 Change-Id: I94e16540a41d635834cd74febd4eb2b4ffb309c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448110Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#813836}
-
Henrique Nakashima authored
This breaks about 2.7% of package dependencies cycles and makes it clear modules can use ChromeVersionInfo. Bug: 1131982 Change-Id: If1fed6174cd08bd2f20371d1de99c43011fd947c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429231Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#813835}
-
Eugene But authored
This CL adds the following key-values: - OSVersion (string) - in-background (bool) - session restoration (bool) Bug: 1103752 Change-Id: Ib9217d451bc4684a819e9f07fa968cf42792e586 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444389Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#813834}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/378347c17f31..83c2cb106077 2020-10-05 jleconte@google.com Reland "Fix pop up statement when triaging with an existing bug." 2020-10-05 nuwanda@google.com Add ListFiles function to cloud storage 2020-10-05 jleconte@google.com Revert "Fix pop up statement when triaging with an existing bug." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1128919,chromium:1134978 Tbr: oysteine@google.com Change-Id: Ic64a99c6861648c3507e9f149eeb784e90ddee79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450569Reviewed-by:
-
Antonio Gomes authored
BUG=1113900 R=jamescook@chromium.org Change-Id: I2f6f52bafa59f3c93a47b77c8429b9c0e25ac076 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446204 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#813832}
-
Elly Fong-Jones authored
This change: 1) Removes AuthDialogWidgetDelegate in favor of setters on the base WidgetDelegate class 2) Removes InSessionAuthDialog::contents_view_ in favor of storing the auth methods (which are the only thing it is used for) directly as a const member var 3) Simplifies construction of the auth dialog widget 4) Removes a couple of redundant calls to set bounds on the Widget (4) deserves more explanation: Before this change, CreateAuthDialogWidget() set the Widget's initial bounds to kDefaultSize centered within the primary display, then InSessionAuthDialog set the bounds again to change the height to the contents view's preferred height. The first bounds set should be unnecessary because system modals (which this is) are centered in the screen. The second bounds set should also be unnecessary because a widget's default size is its contents view's size. Therefore, what this code actually accomplishes is to set the width of the widget to 340. This value is at odds with AuthDialogContentsView's actual preferred width, which I believe is 512. After this change, the widget's bounds are not set, nor is its size; it is allowed to size itself to the size of its contents view, as widgets normally do. This will make the InSessionAuthDialog large enough to display its entire contents view, which may cause a visual change. Bug: 1075649 Change-Id: Ib7e972dba773ea3bf887d774fab328cbb306faad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441963Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Henrique Nakashima authored
The cached and the native flag defaults should match. This is a step to cleanup the flag. Change-Id: I83b4f08c5486de8a0dd08422dde4de0bdf53a26b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446554Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#813830}
-
Brian Malcolm authored
This is used as a header in the CROS device settings page. BUG=chromium:1081272 Change-Id: I20995464c23df17911ed5b425d0dfdb221434aca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446535 Commit-Queue: Brian Malcolm <bmalcolm@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#813829}
-
Peter Kotwicz authored
BUG=1129255 TBR=twellington Change-Id: I7acff50f82c1a0bc0b7a2d55e09cd307b447f033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446540 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
-
David Black authored
The purpose of this class is workaround dependency restrictions that prevent direct access to AshColorProvider from outside //ash:ash. Moving forward, all color lookups for holding space will go through our provider for consistency. Bug: 1133913 Change-Id: Iea7caa2eda7d60ba88cb95ce7efe5fcfa259a075 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446207Reviewed-by:
-
Xianzhu Wang authored
Change ContiguousContainer to allocate the initial buffer when adding the first element, so that the initial capacity can be passed as a parameter of the constructor. Remove ShrinkToFit() because it does nothing as we don't remove display items (and we don't have other users of ContiguousContainer). It was needed when we had paired display items and we may remove display items. Bug: 1130242 Change-Id: I263fc95db20b1571739fcbd6bb0ce13b393416f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446480Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#813826}
-
Jesse Schettler authored
Add the page number to the page callback so that ScanService can include it in filenames when saving scanned images. Bug: 1059779 Change-Id: I3085b6e180d0d60e8afc85be071d6370a08c2573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445670 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#813825}
-
Will Harris authored
Reports the PatchLevel of the current running Windows OS as reported by a call to VerQueryValue() on kernel32.dll. Also, add comments for missing functions in windows_version.h and add Kernel32VersionNumber function on OSInfo for determining Kernel32 version. BUG=1130738 Change-Id: I70c652e6524e15382a511cfc12311d5ffffedb1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444452Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
Koji Ishii authored
Presubmit does not accept Mac10.14 for NeverFixTests, so it was extended to Mac. The tests are not platform-specific. TBR=ikilpatrick@chromium.org Bug: 1135166 Change-Id: Ide3e1506d749cf121d4a8b51c86f0c36a2d08143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449831 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#813823}
-
Dave Tapuska authored
With flash removal happening in M88, remove RenderWidgetFullscreenPepper which was used to implement the Flash Fullscreen setting. Note this is different that the PPAPI Fullscreen which uses the normal blink fullscreen request via the WebContainer::RequestFullscreen call. BUG=1134674 Change-Id: I166596f6f5a677cc1028aed02f74297e0c458696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446593 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#813822}
-
Manu Cornet authored
This fixes a couple of build failures happening on a class of Python installs. I must say I can't quite pin down what characteristics in a Python installation would influence this, but it certainly does on all my machines that I setup to be non-corp machines to try and mimic what open source developers may do. Change-Id: Id60cd8b10141ca1486e0cdadfc7392b6d2bba3e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445878 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Lucas Radaelli authored
This is a reland of c14fae86 Original change's description: > [fuchsia][a11y] Refactors convert node ID logic. > > This change refactors the logic to convert an ax node ID to a fuchsia semantic node ID. > > It also fixes the bug where if a regular ax node had ID == 0, it would conflict with the root ID. > > R=yangsharon > > TEST: web_engine_unittests > Change-Id: Ie4ee52c65fbd5ad623986e015ad521e66c5e67fe > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430264 > Reviewed-by: Kevin Marshall <kmarshall@chromium.org> > Reviewed-by: Sharon Yang <yangsharon@chromium.org> > Commit-Queue: Lucas Radaelli <lucasradaelli@google.com> > Cr-Commit-Position: refs/heads/master@{#811926} Change-Id: I8b89cb69007c7e7557660ef70e71d28807fff436 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441278 Auto-Submit: Lucas Radaelli <lucasradaelli@google.com> Reviewed-by:
Sharon Yang <yangsharon@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#813820}
-
Avery Musbach authored
The mouse cursor will be hidden/shown when entering/exiting tablet mode, instead of when internal touchpad input events are blocked/unblocked. Examples: 1. Detach the internal keyboard/touchpad from a nocturne. It enters tablet mode, but it does not block internal touchpad input events, because the internal touchpad is gone. With the present CL, the mouse cursor will be hidden. Without the present CL, it is not. 2. Attach an external pointing device and then flip the lid to tablet position and back to clamshell position. Without the present CL, the mouse cursor will be hidden when you flip to tablet position, and then shown when you flip back to clamshell position. With the present CL, that will not happen. Fixed: 1123687, 1133031 Test: All/TabletModeControllerTest.ShowAndHideMouseCursorTest/? Change-Id: I22cb7d3ffeb6d62b1b74f182c4bbe73b2338ff2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436325Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#813819}
-
Michael Checo authored
Screenshots: - Diagnostics App (before) http://shortn/_9PftSxKEqe - Diagnostics App (after) http://shortn/_PIhlqmECzl Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I32bee1b48287b83153f1c3d1b43285ccf7779db3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443109 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#813818}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/01144ed91c35..6d93a63356e1 2020-10-05 capn@google.com Regres: limit the number of GL tests opening X connections 2020-10-05 bclayton@google.com CMake: Add flag for controlling the logging level If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ic871729d03f572debf6bb7bb7b4f4c5d75e86d58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450122Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8e4cda7de008..04482985b204 2020-10-05 tommi@webrtc.org Revert "[Sheriff] Revert "Remove MessageHandler[AutoCleanup] dependency from StreamInterface."" 2020-10-05 perkj@webrtc.org Add experimental extension RtpVideoLayersAllocation 2020-10-05 sprang@webrtc.org Cleans up code related to video packetization overhead. 2020-10-05 danilchap@webrtc.org Factor out common logic for full svc scalability structures 2020-10-05 hta@webrtc.org Separate PeerConnection's self-message functions to a new file If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I85ba25e24ccb443802048793d7a844d4bfe84c48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448687Reviewed-by:
-
George Steel authored
This replaces the existing virtual implementations of TransformOperation::CanBlendWith() with a single one that compares PrimitiveType() values, as defined in the spec. Years ago, CanBlendWith was only used by BlendedBoundsForBox, and returned false on operation types not supported by that method. As these checks are currently in BlendedBoundsForBox itself, and CanBlendWith is used in some Blend() implementations, eliminate the return false cases in favor of the as-specced primitive type comparison. As CanBlendWith is now to-spec for all operation types, replace the many ad-hoc primitive type comparisons with calls to CanBlendWith(). Change if/return type checks in TransformOperation::Blend() to DCHECKs as the there is already a type check at the call site in TransformOperations, so these should always succeed. In the case of SkewTransformOperation, replace the loose type check (which would allow blending between skewX and skewY which have different primitive types) with CanBlendWith. This causes no behavioral change since a primitive type comparison already existed in the caller. Change-Id: Ife892b72798fe81d61ff6528deff064f41bdbfbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432672Reviewed-by:
Kevin Ellis <kevers@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: George Steel <gtsteel@chromium.org> Cr-Commit-Position: refs/heads/master@{#813815}
-
Kristi Park authored
This reverts commit d46bdb4f. Reason for revert: Added web test is timing out on Mac10.15 Tests https://ci.chromium.org/p/chromium/builders/ci/Mac10.15%20Tests/4574 Original change's description: > [Editing] Fix canonical caret position at line break > > Consider this testcase: > <style>div { width: min-content; padding: 5px; }</style> > <div contenteditable>line1<wbr>line2</div> > which is rendered as > line1 > line2 > > Before this patch, when clicking at the beginning of the 2nd line, the > caret would appear at the end of the 1st one, because CanonicalPosition > would search backwards even with a downstream affinity. > > Also, when clicking at the beginning of the 1st line and pressing the > down arrow key, the caret would move to the end of the 1st line instead > of to the beginning of the 2nd one. And pressing the key again would > have no effect, the caret would refuse to go down. > > This patch fixes these problems by making CanonicalPosition take a > TextAffinity parameter which affects whether the canonical position is > first searched backwards or forwards. If no suitable candidate is found, > it will still search in the other direction. > > And then, VisiblePosition::Create takes care of deciding between the > upstream and the downstream canonical positions, depending on the > affinity and whether there is a line break. > > Bug: 1002937 > > Web tests: > TEST=external/wpt/editing/run/caret-navigation-around-line-break.html > > Unit tests: > TEST=All/ParameterizedVisibleUnitsLineTest.inSameLine/0 > TEST=All/ParameterizedVisibleUnitsLineTest.inSameLine/1 > TEST=All/ParameterizedVisibleUnitsWordTest.StartOfWordShadowDOM/0 > TEST=All/ParameterizedVisibleUnitsWordTest.StartOfWordShadowDOM/1 > TEST=VisiblePositionTest.ShadowV0DistributedNodes > TEST=VisibleUnitsLineTest.endOfLine > TEST=VisibleUnitsLineTest.isEndOfLine > TEST=VisibleUnitsLineTest.isLogicalEndOfLine > TEST=VisibleUnitsLineTest.isStartOfLine > TEST=VisibleUnitsLineTest.logicalEndOfLine > TEST=VisibleUnitsLineTest.logicalStartOfLine > TEST=VisibleUnitsLineTest.startOfLine > TEST=VisibleUnitsTest.canonicalPositionOfWithHTMLHtmlElement > TEST=VisibleUnitsTest.canonicalPositionOfWithInputElement > TEST=VisibleUnitsTest.canonicalizationWithCollapsedSpaceAndIsolatedCombiningCharacter > > Change-Id: I82d86d40a87513b2e92c024735957e9f71154094 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410404 > Commit-Queue: Oriol Brufau <obrufau@igalia.com> > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#813744} TBR=yosin@chromium.org,xiaochengh@chromium.org,obrufau@igalia.com Change-Id: I5f6da8b5b9be5167cf49dd5b27d0f9c03b0b285e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1002937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450770Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#813814}
-
Mario Bianucci authored
PredictionMetricsHandler appears to be designed to work for anything that is predicting points. However, it currently only reports metrics in the Event.InputEventPrediction.Scroll* histograms. De-couple the class from these histograms so it can be used for things only than scroll metrics. Bug: 1133785 Change-Id: Ib34129fc46b20b45810cbd5ca195483e88c513e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441197Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Mario Bianucci <mabian@microsoft.com> Cr-Commit-Position: refs/heads/master@{#813813}
-
Sharon Yang authored
This reverts commit fdae2298. Reason for revert: Test is causing Fuchsia trunk builder to fail https://ci.chromium.org/p/chrome/builders/ci/fuchsia-x64-trunk Original change's description: > [fuchsia][a11y] Sends full semantic tree when semantics are enabled. > > This change fixes the bug where chrome was sending the full semantic tree only for the first time that semantics were enabled. This happened because the semantic tree was not getting cleared on the chrome side when disabled. when semantic were disabled / enabled, the events fired on the tree included only the diffs from the previous state of the tree. > > Test: web_engine_browsertests > > Bug: fuchsia:59680, 1134147 > Change-Id: I8266d6436f9bfb9ee9e89a0f46c0916bac7a5e75 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442646 > Commit-Queue: Lucas Radaelli <lucasradaelli@google.com> > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> > Reviewed-by: Sharon Yang <yangsharon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#813771} TBR=wez@chromium.org,sergeyu@chromium.org,teisenbe@google.com,yangsharon@chromium.org,lucasradaelli@google.com Change-Id: Id3df2d7e4c31632f65d2dcc4a2a9b07fc92f9b83 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: fuchsia:59680 Bug: 1134147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450693Reviewed-by:
-
Koji Ishii authored
TBR=ikilpatrick@chromium.org Bug: 1135117 Change-Id: Ic1403098ce31c638da44b1c55c671f60ea0da5fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449512Reviewed-by:
-
