- 26 Sep, 2020 40 commits
-
-
Findit authored
This reverts commit 9d061cca. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 810917 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzlkMDYxY2NhZTAxZGQ2NWE2NjQxMmEyOTE0ZmJhZmFiOTMxOGUwOTUM Sample Failed Build: https://ci.chromium.org/b/8868132345808855984 Sample Failed Step: compile Original change's description: > Roll src/net/third_party/quiche/src/ ba9d95e43..f2e0d90a9 (3 commits) > > https://quiche.googlesource.com/quiche.git/+log/ba9d95e4328b..f2e0d90a970b > > $ git log ba9d95e43..f2e0d90a9 --date=short --no-merges --format='%ad %ae %s' > 2020-09-25 fayang Notify debug_visitor once any 0-RTT packet gets acknowledged. Client only (server + TLS does not send 0-RTT packets). > 2020-09-25 wub Add flag --ip_version_for_host_lookup to quic_client to indicate the preferred IP version of host address, if host lookup is needed. > 2020-09-25 quiche-dev Fix a latent query-of-death in a GFE+QUIC+Leto codepath > > Created with: > roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src > > Change-Id: I8c71cc9b663b6c2287661a999b7f72a02ecf6579 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432758 > Commit-Queue: Renjie Tang <renjietang@chromium.org> > Commit-Queue: David Schinazi <dschinazi@chromium.org> > Auto-Submit: Renjie Tang <renjietang@chromium.org> > Reviewed-by: David Schinazi <dschinazi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810917} Change-Id: I089d72f0478d9d8b992a18845d6eb9edbe0e8366 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432326 Cr-Commit-Position: refs/heads/master@{#810922}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I5868cb8f31024ff4009be22a58640ab184e800f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432763Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810921}
-
Findit authored
This reverts commit 22e4c40d. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 810904 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzIyZTRjNDBkNWE1NmU4Njg1MDk1MmFlZDNiMDdhZGE3YzNlYzczNzQM Sample Failed Build: https://ci.chromium.org/b/8868133565492231744 Sample Failed Step: compile Original change's description: > [libvpx] Use HighBD config for ARM64 Mac > > Also adds unit tests to cover HighBD support on various platforms. > > Bug: 1128445 > Change-Id: I9951a49f0fca311f48ff55c1618f3d18343dfca8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427556 > Commit-Queue: Xiaohan Wang <xhwang@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: James Zern <jzern@google.com> > Cr-Commit-Position: refs/heads/master@{#810904} Change-Id: I8182741ee91739c9ff313adf35ad9ab8044e081a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1128445 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432878 Cr-Commit-Position: refs/heads/master@{#810920}
-
Hui Yingst authored
This CL adds supports for navigating to view destinations with fit type 'XYZ' (See table 151 in ISO 32000-1 standard for more details about syntax of "XYZ"), which specifies the coordinates of the page's origin inside the view window and the zoom factor of the page. Bug: 55776,748852 Change-Id: I4f449f006ec9dda4be282aea75c2a6e36a35b87e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390997Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Hui Yingst <nigi@chromium.org> Cr-Commit-Position: refs/heads/master@{#810919}
-
Kelvin Jiang authored
This CL logs when declarativeContent actions are added to determine usage of the API and its various action types. Note: showPageAction is not logged because it is converted internally into showAction. Bug: 1127585 Change-Id: I764bc0a518097f20f0b2522bafdf4509653b6afc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415227 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#810918}
-
Renjie Tang authored
https://quiche.googlesource.com/quiche.git/+log/ba9d95e4328b..f2e0d90a970b $ git log ba9d95e43..f2e0d90a9 --date=short --no-merges --format='%ad %ae %s' 2020-09-25 fayang Notify debug_visitor once any 0-RTT packet gets acknowledged. Client only (server + TLS does not send 0-RTT packets). 2020-09-25 wub Add flag --ip_version_for_host_lookup to quic_client to indicate the preferred IP version of host address, if host lookup is needed. 2020-09-25 quiche-dev Fix a latent query-of-death in a GFE+QUIC+Leto codepath Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I8c71cc9b663b6c2287661a999b7f72a02ecf6579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432758 Commit-Queue: Renjie Tang <renjietang@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: Renjie Tang <renjietang@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#810917}
-
Chris Lu authored
If the Browser is destroyed, then OverlayPresentationContextImpl will soon be as well. Thus, OverlayRequestCoordinator's reference to it will be invalid, so OverlayPresentationContextImpl should remove itself as the delegate. This change also uses __weak references to self InfobarBannerOverlayCoordaintor. Bug: 1129962, 1129788 Change-Id: I082ad3f7acf671b61e23434f918d22d900d5227f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427407Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#810916}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5eff1172..e577a1c6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3e623f0ef08d8567f63f61aae36714f2835ff5d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432426Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810915}
-
Daniel Classon authored
Fix the "Smart lock screen lock options" search tag behavior to only appear when the smart lock feature is enabled by the user and the corresponding options buttons are visible. Bug: 1116553 Change-Id: Ib5a7194b8a97a639ba4df6b96952a92e4fb47270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429935 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#810914}
-
Orin Jaworski authored
This CL prevents the Translate page pedal from appearing when the current_url is any builtin chrome:// URL, including chrome://newtab . This prevents bad message crashes when in guest mode (see bug). Bug: 1131136 Change-Id: Id0c05a66d3bd6509c0f5f3b242555607fc6dcec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432209 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#810913}
-
Hidehiko Abe authored
According to the document, the zwp_test_input_v1_send_keysym's argument named |code| should be XKB keysym. Currently, XKB keycode is sent, so fixed to the collect one. BUG=1123705 TEST=Ran locally. Made sure expected keysym is sent to client. Change-Id: I9db31cf84b21a7c9a400d75bcbec2fbfe69a2ad4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432165Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#810912}
-
Lukasz Anforowicz authored
This CL introduces ExtensionURLLoaderFactory::Create static method that allow creating an ExtensionURLLoaderFactory that is owned by its |receivers_| and will self-delete when the last receiver disconnects. This CL removes the ability to directly construct and own a std::unique_ptr<ExtensionURLLoaderFactory>, because this ability means that the factory can be destructed while receivers bound via the Clone method are still alive (see the associated bug). In particular, this CL stops exposing ExtensionURLLoaderFactory constructor as a public member, which forces construction to go via the new Create static method. This CL mostly just follows the pattern established earlier by https://crrev.com/c/2337411. Bug: 1106995 Change-Id: I16565e8200a6d7190d6ce06ea5c0250cef696f10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357523Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
-
Michael Hansen authored
This addresses a bug in which advertising was not starting on sign-in. This was because Bluetooth adapter was not acquired in time for the initial round of checks. Bug: 1132063 Change-Id: I6ce9ad8ad9ca5c02a0cb00eb60b8d80f852a355e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431586Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Michael Hansen <hansenmichael@google.com> Cr-Commit-Position: refs/heads/master@{#810910}
-
Xiaocheng Hu authored
Finch experiments results on M85 [1] look good, so this patch enables it by default on trunk. A follow up patch will ship in all channels it via finch. [1] https://docs.google.com/document/d/1HenoksopNhJKvUfITMnfBPTllPSNcUVH06yCJB3asj4/edit?usp=sharing Bug: 441925 Change-Id: Ibd4f308875ff89979af83cf7b9a5e74709b5fba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429514Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#810909}
-
Kevin Marshall authored
Allows fuchsia-out-dir to be set independent of whether it will actually be consumed by the target type. Targets which don't use external Fuchsia outdirs, e.g. "qemu" and "aemu", simply ignore the arg. Otherwise, the arg parsing step is broken when the "default_fuchsia_build_dir_for_installation" GN arg is set. This is a likely event on x64 builds which run equally well on emulators and baremetal hardware. Bug: 1080854 Change-Id: I4690737a36f7d60c9992421a8752caeffed9084f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402100Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#810908}
-
Xiaocheng Hu authored
Following the CSSWG resolution to add metric override descriptors to @font-face, this patch also adds these descriptors as attributes to the JavaScript FontFace interface. Bug: 1098355 Change-Id: Ia5ef4ad870559457834fe9fafaaab79b24a0e08b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425484Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/aeae3a58e3da..68861e391313 2020-09-25 johnstiles@google.com Add unit tests for assignment and invalid field access. 2020-09-25 mtklein@google.com factor out some helpers in SkVMBlitter 2020-09-25 mtklein@google.com split apart uniformPremul() 2020-09-25 mtklein@google.com to_foo() -> to_Foo() 2020-09-25 bsalomon@google.com Remove deprecated Vulkan GrBackendRenderTarget constructor 2020-09-25 johnstiles@google.com Disallow assignment to unfoldable ternaries in SkSL. 2020-09-25 johnstiles@google.com Fail gracefully when Metal encounters a geometry shader. 2020-09-25 csmartdalton@google.com Move user stencil settings from GrPipeline to GrProgramInfo 2020-09-25 bsalomon@google.com Relax matrix check for fast case in rect blur shader 2020-09-25 fs@opera.com More conservative reverse mapping bounds for SkDisplacementMapEffect 2020-09-25 kjlubick@google.com [canvaskit] Followup feedback from shaping demo 2020-09-25 johnstiles@google.com Remove sk_ClipDistance. 2020-09-25 kjlubick@google.com [canvaskit] Expose Glyph ID APIs 2020-09-25 johnstiles@google.com Migrate setRefKind assignability checker into SkSLAnalysis. 2020-09-25 ethannicholas@google.com moved SkSL Block's data into IRNode If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1087705,chromium:1128962 Tbr: csmartdalton@google.com Change-Id: I12b5fd74673d90dae31183265169e7c072d714ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432796Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810906}
-
rbpotter authored
Bug: 1132403 Change-Id: Ib476e0a84de6e441f82c35029b2952d45a093993 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427309 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#810905}
-
Xiaohan Wang authored
Also adds unit tests to cover HighBD support on various platforms. Bug: 1128445 Change-Id: I9951a49f0fca311f48ff55c1618f3d18343dfca8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427556 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
James Zern <jzern@google.com> Cr-Commit-Position: refs/heads/master@{#810904}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 1045266 Test: OSSettingsNetworkSummaryItem* Change-Id: I9b18f35389a7b496a2a656c7fd93fa1738f587aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432659Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I669161cfd6e625dff62cde7b6cb6c79b4c249d74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432346Reviewed-by:
-
David Black authored
Previously opening holding space via keyboard would keep focus on the holding space tray and not be able to enter the holding space bubble. Also, we weren't previously watching for destruction of the holding space bubble widget so if it was closed without going through HoldingSpaceTray::CloseBubble(), we got in a bad state. This could happen if the user closed holding space via the ESC key. This has now been fixed. Bug: 1131261 Change-Id: Iad72a25e3798192c111bbdb929b4c70f22dd2c46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432678Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#810901}
-
Etienne Bergeron authored
This CL is fixing the fallback selection for Emoji. The problem got introduced here: https://chromium-review.googlesource.com/c/chromium/src/+/2075222 The original fallback implementation rely on CTFontCreateForString(...) over the whole text of a run. This was causing problem since the API on some versions of Mac (see crbug/1036652) is broken with ignorable codepoints (e.g. ZWJ and ZWNJ on arabic script). The skia implementation is calling CTFontCreateForString(...) but over a single codepoint. An algorithm is trying to find the best match by taking the font with the most codepoints. While this is working well for script, this is not working well for emoji. Emoji can have joiners (ZWNJ) between codepoints. The codepoints that are joined can be on different blocks. Emoji can have a presentation codepoint (<emoji> u+FE0E or <emoji> u+FE0F). The fallback font was broken because the algorithm tries to find a font for codepoints {u+2699, u+fe0f}. The codepoint u+fe0f is an ignorable codepoint and was not taken into account while choosing the fonts. The "Menlo" font was returned. The codepoints u+2699 favor the textual representation and was not taking the emoji color font. The Apple Emoji Color font support both codepoints. We could take into account the ignorable u+fe0f, but this is causing problem with this example: {u+2699, u+fe0e}. There is no font that has both of them. The selection can choose any font with {u+2699} or with {u+fe0e}. Selecting font with only {u+fe0e} is also wrong. Same issue can happen with the ZWNJ/ZWJ that can be found in emoji sequence. The proposal is to have a specific font for handling emoji. Bug: 1099591 Change-Id: Id02952b2fa2c7b4052611c06c3b2a535e20600ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429503 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#810900}
-
Kartik Hegde authored
Add the SignalStrength routine to the ServiceConnection. BUG=chromium:956783 TEST=1) chromeos_unittests --gtest_filter=CrosHealthdServiceConnectionTest.* 2) Applied SignalStrength changes and successfully ran the SignalStrength routine on a DUT (verified using cros-health-tool diag --action=run_routine --routine=signal_strength). Change-Id: Iffa5fe58ee8c03e0fed30cfc984f7bf2d02a4f00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343667Reviewed-by:
Paul Moy <pmoy@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kartik Hegde <khegde@chromium.org> Cr-Commit-Position: refs/heads/master@{#810899}
-
David Black authored
This CL implements support for multiselect in holding space. Previously it was only possible to operate on a single holding space item at a time but following this change it is possible to perform bulk operations. Bug: 1129981 Change-Id: I9bf82e748fa6f145af061b2ba8ffae2948cf48c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429433Reviewed-by:
-
Robert Liao authored
No optimization comes for free. There are too many places where selected_index_ can change without going through proper property change codepaths. At this stage of the release cycle, the safest change is to revert the optimziation introduced in r656230. Bug: 1132465 Change-Id: I332435d94a63ea6b86835df34bae6d4300e154d7 Fixed: 1132244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432810 Commit-Queue: Robert Liao <robliao@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#810897}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1601045991-448e0de5114b8171193e6ee9ab99aeaf1d5de1aa.profdata to chrome-win32-master-1601066350-493c228f7ec3e1753262b764503b9735ef24657c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC liaoyuke@google.com,sebmarchand@chromium.org,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: liaoyuke@google.com,sebmarchand@chromium.org,jeffyoon@google.com Change-Id: I1d87ca4553398a86b03fe2c81b25d5fab09d6763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432800Reviewed-by:
-
Elly Fong-Jones authored
This change: 1) Adds a new dialog, WindowNamePrompt, which contains just a textfield and okay/cancel buttons 2) Adds a new menu item to the browser's frame menu which invokes the window name prompt on the indicated browser window 3) Adds appropriate glue code and a command ID to make (2) happen 4) Adds unit tests covering the behavior of (1) 5) Adds some new test helpers in views::test for dealing with dialogs and finding specific views within Widgets Bug: 1096586 Change-Id: I079e15605eef0d84d413d3c3ed445ad52a01537e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422689 Commit-Queue: Ken Rockot <rockot@google.com> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#810895}
-
Eric Roman authored
(1) Net.TcpConnectAttempt.Latency.Error: Number of milliseconds a TCP connect took to fail. (2) Net.TcpConnectAttempt.Latency.Success Number of milliseconds a TCP connect took to succeed. (3) Net.TcpConnectAttempt.LatencyPercentRTT.Error How long a TCP connect took to fail, as a percentage of the estimated RTT (4) Net.TcpConnectAttempt.LatencyPercentRTT.Success How long a TCP connect took to succeed, as a percentage of the estimated RTT Bug: 1123197 Change-Id: I5b05956ff60e415d707ad14f95bbb44a2d5f0377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401335 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#810894}
-
Mohsen Izadi authored
Some methods in InputHandlerProxy take an event_with_callback argument, but they also take some other arguments that can be extracted from event_with_callback. These can be removed. Bug: 1079116 Change-Id: Ie4c70386e4e4c4d533eb56189bf0fee339ea7e6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431552 Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#810893}
-
Torne (Richard Coles) authored
If code used very early in startup reads shared preferences and the app is freshly installed the prefs directory might not exist yet, triggering a disk write in getDefaultSharedPreferences. Suppress this for StrictMode as it can happen in WebView. Bug: 1131941 Change-Id: Iaf738bad917673a1e5a0d3804f1c55f3181b10a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431730 Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#810892}
-
Piotr Bialecki authored
Change-Id: I0b0dc99e0e7ef9655d7308771822ffdece4057e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432671 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#810891}
-
Dylan Cutler authored
The method will only report digests to UKM if the study is enabled and collection of the specified web feature is allowed. Bug: 973801 Change-Id: Ia1f2dea99ce26a24d7130ebc6fed42edade287d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427363Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#810890}
-
Regan Hsu authored
* Adds controls for Do Not Disturb, Tether status, and is phone ringing * Controls are 2 ways - they reflect the current state of the status they control. I.e if the tether status changes without the user explicitly changing the status, it will show up in the dropdown. Likewise, if the user changes the status, it will change the status to the selected one. Same for DND and phone ringing. * Adds a control for showing onboard ui Screenshots: https://screenshot.googleplex.com/jjS26PAyiaK8KRz (quick action) https://screenshot.googleplex.com/8THgG3zX4nHfCdu (onboarding) Bug: 1106937 Change-Id: I5bd8a5d02c0be5aba95d6c816cf7c327c51c986d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429846 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7f386135788a..d08de1904727 2020-09-25 vadimsh@chromium.org [lucicfg] Update to v1.20.0. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1130833 Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: Ia8cd9798a459d78199a70adaa87adcc9fc7f5e5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432785 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I76d57b1c8197cf6386bde982fbce6c65c1559c79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432680Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810887}
-
Xiaocheng Hu authored
This patch enables the feature by default following the discussion in: https://docs.google.com/document/d/1L-Aphp1oGwJyPw8k_NEKPPR2siSUc2pBq9bJf7lXFXk/edit The enabled default parameters are: - intervention-mode: swap - lcp-limit-in-ms: 2000 Bug: 1065508 Change-Id: Iac8a1932ad9a4c468011ddf98ad723fe30f96d65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430045Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
-
ssid authored
The Android services use profile key to get provider and the provider in the key should be valid for incognito profile too. BUG=1124790 Change-Id: I392956f2b587fdf82a910a8b7db959c057f81cb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432212 Commit-Queue: ssid <ssid@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#810885}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1601034748-023a9c52685bf2df5bc5619a1b9c5135fdad71eb.profdata to chrome-win64-master-1601066350-377534304780c9dba5c0cc3dbbf14390e280f62b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand@chromium.org Change-Id: I40944542dca3a65d91842a9d9d4892513a26f397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432798Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b6c8813f8281..236c96a322d8 2020-09-25 michael.liao@microsoft.com [Accessibility]: Adding alert message to Application Cookies table to read how many cookies are shown after modifying the entries through filters/clear/etc. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1131142 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9458449211771d7f076ff3f7dc686822152c6b47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432588Reviewed-by:
-
