- 01 Oct, 2019 40 commits
-
-
Jay Harris authored
Previously, the flag was only shown on ChromeOS, however there is currently implementation work on Linux and Windows (and soon, on MacOS), so it makes sense to show it on other platforms. Bug: 829689 Change-Id: I91e0e37828bea9ebd3888d18def5ace42a475e97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833019 Commit-Queue: Jay Harris <harrisjay@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Auto-Submit: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#701452}
-
Koji Ishii authored
TBR=eae@chromium.org NOTRY=true Bug: 248894, 1008848 Change-Id: Iac61f0d1e8b1046c05f2b9c8c4b0efdb8a717abd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833342Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#701451}
-
Alex Danilo authored
When the connectedCallback is called on the panel item custom element, set any button onclick handlers since they could have been null'ed out if the panel item was removed from the DOM. Bug: 1009318 Change-Id: I621bf1bcda85c877c1c52a182474e6ec294c63ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832188 Commit-Queue: Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#701450}
-
Jay Harris authored
This is the result of some discussion at TPAC. Previously the BadgeManager applied badges to scopes. This CL changes the BadgeManager to work with AppIds instead (as the web facing API has been changed). Previous CLs have changed the API exposed to the Web, so this change only affects how Chromium stores/applies the badges. TPAC Discussion Summary: https://github.com/WICG/badging/issues/55 Related CLs: https://crrev.com/c/1817999 https://crrev.com/c/1818892 https://crrev.com/c/1816002 Bug: 1006665 Change-Id: I24d18bdad5a8a0a92b0d1b5ac14052b9de8913dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830485 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#701449}
-
Patrick Monette authored
When ServiceWorkerContextCore::DeleteAndStartOver() is used, the existing service workers still exist for a short time but new instances are created and they will reuse existing version_id because the count is reset to kInvalidServiceWorkerVersionId. This leads to multiple running notifications for indifferentiable service workers. To fix this, the ServiceWorkerContextWrapper is notified when DeleteAndStartOver() is called and prematurely sends a stopped notification for all currently running service worker versions. Then, to prevent future notifications from all the old versions, the ServiceWorkerContextCore silently drops notifications if the core associated with the version is no longer alive. Bug: 993029 Change-Id: I27b192141265828139416abb37d8e0c762308679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829865 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#701448}
-
Koji Ishii authored
TBR=eae@chromium.org NOTRY=true Bug: 1008790 Change-Id: I4e927365689ff14ecf87df4e3b180492f10645e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833341Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#701447}
-
Thanh Nguyen authored
This CL: 1. Adds prefix matching to the class. 2. Uses normalized text rather than raw text of TokenizedString. 3. Combines scores from all sources to give a final score. Bug: 990684 Change-Id: I200986fc38366be117c7c4b8849d4510b4f830bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826745 Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#701446}
-
Patrick Monette authored
This class observes running shared worker instances, keeps track of the connection to their client frames and manages the lifetime of worker nodes in the Performance Manager graph. Bug: 993029 Change-Id: I2e0c7cd9f194a06405293c22fd543a14ff3c6cbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757283 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#701445}
-
Koji Ishii authored
TBR=eae@chromium.org NOTRY=true Bug: 684968, 1008790 Change-Id: If358ae57659927c38fe2d65087f5aa3df1b336d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833031Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#701444}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cb6de9f661f3..a305a6276dfe git log cb6de9f661f3..a305a6276dfe --date=short --no-merges --format='%ad %ae %s' 2019-10-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader faa2a365b5c0..3044c24181e9 (4 commits) Created with: gclient setdep -r src/third_party/skia@a305a6276dfe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC rmistry@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmistry@google.com Bug: chromium:None Change-Id: Ia59a23cdca4a1e6cc57486259643f6b23aec9e3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833108Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701443}
-
Chinglin Yu authored
This refactors DebugDaemonClient by moving the the client to debug_daemon subfolder under //chromeos/dbus. metrics::DebugdClientProvider is also moved to the subfolder and renamed to to chromeos::DebugDaemonClientProvider to be consistent with chromeos::DebugDaemonClient. Bug: 998364 Test: Build Change-Id: Icfe85f1c2b55146f0130c42ceff3e57f8b376922 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794944 Commit-Queue: Chinglin Yu <chinglinyu@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#701442}
-
Austin Tankiang authored
File transfers of hosted drive files should be blocked when: - Transferring to outside of drive. - Transferring to another profile's drive. Also change to using URLsToEntriesWithAccess, as URLsToEntries does not work with files from a different profile. The code is covered by existing tests, however some tests are changed to copy non-hosted files from drive to downloads, as hosted files cannot be copied this way anymore. Bug: 1008328 Change-Id: I9cc86035d7955c9ca34d53587affd5786367a608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830491Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#701441}
-
Alan Cutter authored
Web apps that sync across devices are not considered locally installed for non-Chrome OS devices. This CL ensures we don't accidentally install them as part of manifest updating. Bug: 926083 Change-Id: I34ba3610b04a3cf62e6c7bd362bed2fd770d7b55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831737 Commit-Queue: Alan Cutter <alancutter@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#701440}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8c6278001533..86a375c756f2 Created with: gclient setdep -r src-internal@86a375c756f2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: Ie4e7d0e1ea1bef16b58ca39de1def0dd759e370f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833103Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701439}
-
Anand K. Mistry authored
BUG=972551,977313 Change-Id: Icdc9f46e31f779156ea66b4b3091f786150c08da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827266 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#701438}
-
Gyuyoung Kim authored
This CL converts old Mojo types to new Mojo types in CdmProxy interface. CdmProxy::Initialize applies pending_associated_remote to the first argument. Bug: 955171 Change-Id: I6d777b123809c9e56bd25d8204d71ee4d0c8999c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827102Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#701437}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d6a4a0164d45..c2a6ac81ca46 git log d6a4a0164d45..c2a6ac81ca46 --date=short --no-merges --format='%ad %ae %s' 2019-10-01 dtor@chromium.org usergroup_baseline: note that pluginvm belongs to cups-proxy group Created with: gclient setdep -r src/third_party/chromite@c2a6ac81ca46 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I45187ae57cd3e0743aa3bd69445ead4fe6eebce5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833107Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701436}
-
Dan Beam authored
R=tangltom@chromium.org Bug: 1009445 Change-Id: I75f51a6b3b4e22cc06a130e953d47cfd7fccf203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832264 Auto-Submit: Dan Beam <dbeam@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#701435}
-
Sadrul Habib Chowdhury authored
NOTIFICATION_BOOKMARK_CONTEXT_MENU_SHOWN is used to schedule a callback right before the bookmark context menu is run. This is used only in interactive tests. Instead of using this notification, use a more explicit API to register callbacks to run before running the context menu. BUG=268984 Change-Id: I43c78118d6fd7ef53f0b7e7c70aefc85670cf78b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831275 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#701434}
-
Jinsuk Kim authored
Moves the internal job handling API to Profile class where it suits better. The API is still present; it will be refactored by updating the call sites to use a helper method in other CL. Bug: 925242, 995903 Change-Id: I292adc2bb9d4bddaccc6857ad33d7b9444c51b53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830255Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#701433}
-
Alan Cutter authored
This CL re-enables updating for web app manifests targeting 79. Bug: 926083 Change-Id: Id94c2d74d833a3d9a7d7fbe857018ac4827657b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831661Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#701432}
-
Hiroki Nakagawa authored
FileSystemClient is used for checking permissions to access Filesystem APIs. The client is now used only from LocalFileSystem, and no longer has to be a separate class. Bug: 1009854 Change-Id: I8aa25d1e6c41d1114f7bd9904d53ae20dc089e4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833002 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#701431}
-
rbpotter authored
There's no reason for the longer name, and we want to be consistent when we add ScalingType in a future CL. Change-Id: Ieeb4e00fb9faeea03a6b82ac46627d175b181e54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832471Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#701430}
-
nancy authored
BUG=1009248 Change-Id: I16d4549b6a48002b288cfb89a4eefc609d7a6271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830248Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#701429}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c28e7f784c33..d6a4a0164d45 git log c28e7f784c33..d6a4a0164d45 --date=short --no-merges --format='%ad %ae %s' 2019-10-01 chrome-bot@chromium.org Update config settings by config-updater. 2019-10-01 jclinton@chromium.org Always sync chrome Created with: gclient setdep -r src/third_party/chromite@d6a4a0164d45 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I6c7c70972947a874cd0e6eecc2dbe7df9ec8a41c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833104Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701428}
-
Nicholas Verne authored
One usage in CHROMEOS was missed in https://chromium-review.googlesource.com/c/chromium/src/+/1829625 TBR=tapted@chromium.org Bug: 1003602 Change-Id: I8d43dd6c92023482c5b0ddc92e3fb058bc3a0265 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833009 Commit-Queue: Nicholas Verne <nverne@chromium.org> Auto-Submit: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#701427}
-
Jeevan Shikaram authored
This CL removes the notification view from tests, store and deletes assets related to notification view. There are no user facing changes. Bug: 1005051 Change-Id: Icefff925c2e1469a167158b461cb0e4006bf5a4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809135 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#701426}
-
Jeremie Boulic authored
Bug: 993292 Change-Id: I77b8cdc58812f97a69741b0d7bf9364a7ee0f4c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833010 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#701425}
-
Yutaka Hirano authored
We forgot to attach a KeepAliveHandler to a request with keepalive set is intercepted to a service worker. Fix that. Bug: 1008494 Change-Id: Ia3c2056b65aaedf2b9f865a324ea3f99d0f55506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830249Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#701424}
-
Anand K. Mistry authored
This change also adds a loading message to be displayed next to the spinner. BUG=916506,972551 Change-Id: I0ea753d7c594fc9b62ae73b8c8c7449cd72b6571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819092 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#701423}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2533afa3f8c6..cb6de9f661f3 git log 2533afa3f8c6..cb6de9f661f3 --date=short --no-merges --format='%ad %ae %s' 2019-10-01 herb@google.com Add maxGlyphCount to SkGlyphRunList Created with: gclient setdep -r src/third_party/skia@cb6de9f661f3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC rmistry@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmistry@google.com Bug: None Change-Id: I832ba8b1ae9700725bf4c0cfaf13317d27837d6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833102Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701422}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1945f397. With Chromium commits locally applied on WPT: 03ccd4e9 "html: Move autofocus tests to html/interaction/focus/the-autofocus-attribute/" ab4b7009 "[Native File System] Aborting a directory iteration succeeds" 8be89ae0 "Update emulated position on each XRFrame" a9f9aa4e "Port opacity-interpolation.html to wpt" dbc7244f "Port order-interpolation.html to wpt" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Ibe587256b0dddd6fa3527ff99973019441cbd410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833081Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701421}
-
Alexey Baskakov authored
This code is disabled by default behind kDesktopPWAsWithoutExtensions base feature. - Implement WebAppSyncBridge::GetClientTag and GetStorageKey to infer them from launch_url. On Init, pass sync metadata from WebAppDatabase to WebAppSyncBridge's change_processor. Read WebAppRegistrar apps data to implement WebAppSyncBridge::GetData (GetData is the sync "view" for our model data). Unit tests and browser tests will be added later in a follow up CL. An MVP implementation of the bridge needed first. This CL follows "Implementing ModelTypeSyncBridge: Initialization" section described here: https://chromium.googlesource.com/chromium/src/+/HEAD/docs/sync/model_api.md#Initialization In next CLs: Implement: MergeSyncData, ApplySyncChanges, "Local changes" sections. Sync-initiated installs/uninstalls will be an interesting case. Bug: 860583 Change-Id: If8c6e78e48031f4caf9eb39ef68f9de65ec65c6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797824Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#701420}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5f4659d6f7a8..ca0d0564630e git log 5f4659d6f7a8..ca0d0564630e --date=short --no-merges --format='%ad %ae %s' 2019-10-01 simonhatch@chromium.org Pinpoint - Switch back to using google-signin Created with: gclient setdep -r src/third_party/catapult@ca0d0564630e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Bug: chromium:1007043 Change-Id: Ideec25f53fe92b42b156f09ee047672ce522cbc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833101Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701419}
-
ccameron authored
This reverts commit 174dd932. Reason for revert: fixed by crrev.com/700989 Original change's description: > Skip tab_capture_end2end_tests on Mac FYI GPU ASAN Release > > TBR=kbr > > Bug: 1008508 > Change-Id: I2c1b3ba59535e7aa29c4ba174c737d7f0ca4630f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827776 > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#700538} TBR=ynovikov@chromium.org,kbr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1008508 Change-Id: Id32e6c5d6c9013bec430abc4ce009eea0d155d55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829876Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#701418}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I343760f44036efe2a5f208f2f9f93f24a1fdf645 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832314Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701417}
-
Peter Kotwicz authored
This CL changes the WebAPK host browser selection logic to launch a non-Chrome browser if: - there is no installed Chrome browser AND - the non-Chrome browser is the default browser BUG=1008716 Change-Id: Id14860628d6d170c0aee2e843ca719c1e94652d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828351 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#701416}
-
nancy authored
After install the ARC app, update the equivalent Chrome app to add the badge on the icon. When the ARC app is removed, update the equivalent Chrome app to remove the badge on the icon. Bug: b/141388525 Change-Id: I075cc0c585bbb89a32e88a25d5509c4375b22fbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833006Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#701415}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/a9dc7707d610..3044c24181e9 git log a9dc7707d610..3044c24181e9 --date=short --no-merges --format='%ad %ae %s' 2019-10-01 chrisforbes@google.com Use GL_RGB as implementation color read format for GL_RGB565 Created with: gclient setdep -r src/third_party/swiftshader@3044c24181e9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: I2bf9bdb05ca2aae6804eb2c63393650421e40702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832707Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701414}
-
http://browserbench.org/JetStream/Oystein Eftevaag authored
TBR=perezju@chromium.org Bug: 1009843 Change-Id: I31a331a31978f50c773674a0e3ab130d80b6667f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832474Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#701413}
-