GitLab

This CL modifies collected traced_slot_ in HeapCompaction.
In atomic pause GC world, slots that has nullptr references and only has an inline buffer are not collected by traced_slot_ because such HeapCollections are ealy returned in Trace method.
However, In incremental GC, we want to collect such slots because they might have references to OutOfLineBuffer after tracing.
So, we modified to collect all slots.

Bug: 864425
Change-Id: I08d94ae86eb33973addcd2f535a003d29c9eeb3b
Reviewed-on: https://chromium-review.googlesource.com/1156112
Commit-Queue: Haruka Matsumura <harukamt@google.com>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582102}

BUG=none

Change-Id: I175181a2cdcfc0e2a04e40e7901343cd003e1ae7
Reviewed-on: https://chromium-review.googlesource.com/1164948Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Satoru Takabayashi <satorux@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582101}

The current approach to externs in file_manager js code requires
js_type_check in various modules to re-list all the externs used by
their dependencies, even if none of them are used in that module.

This CL kills the js_library("closure_compile_externs") in the Gallery
image_editor and puts externs named there where they belong.

To help audit this, the js_unit_tests() template is modified to generate
a js_type_check target for each unit test. This ensures that each unit
test has a complete dependency chain, including externs attached properly
to any of its dependencies.

The changes do not attempt to do full IWYU: if an extern is picked up
transitively in a js_type_check target, it is not listed more than once.
Eventually, breaking out more unit tests will ensure we have dependencies
better described, since each unit test has its own js_type_check.

Bug: 867700
Change-Id: I06fc0359627728046408493088a5bc407e54484b
Reviewed-on: https://chromium-review.googlesource.com/1166610Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582100}

This CL updates the ONC Validator to not only log detailed
errors/warning messages, but also collect them for later use (e.g.,
reporting to policy server or displaying in chrome://policy).

DesignDoc: go/chromeos-robust-onc-policy

Bug: 794848, 855057
Change-Id: Ie22ed887b3b298a8b7e92b175376f98d5f492dc3
Reviewed-on: https://chromium-review.googlesource.com/1116787
Commit-Queue: Alexander Hendrich <hendrich@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582099}

When the LabelLink is displaying a text containing an unbreakable space,
the unbreakable space is preventing two words from being broken at the
end of a line. However, the ManualTextFramer used to get the position of
the link isn't respecting the unbreakable spaces.
So the displayed text isn't breaking the words at the end of the line
but the link is positioned as if the words were broken. So the position
of the link is wrong.

Bug: 872290
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I9b2bae32a47e19b14c397e230aade87b3cb88157
Reviewed-on: https://chromium-review.googlesource.com/1169014
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582098}

Using wpt-import in Chromium 836ab12f.
With Chromium commits locally applied on WPT:
7dad0f17 "Added new Sec-Metadata Web Platform Tests."


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22581

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
domenic@chromium.org, ricea@chromium.org:
  external/wpt/streams
mkwst@chromium.org:
  external/wpt/secure-contexts

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I9b98ffb1a68c9d79a96ce45414872cb43d7e0ccb
Reviewed-on: https://chromium-review.googlesource.com/1170563
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582097}

This CL relands "Don't show camera icon in guest mode", which was
reverted in
https://chromium-review.googlesource.com/c/chromium/src/+/1165962

Original description:

This CL hides camera icon of internal camera app in guest mode. Since
extensions are not allowed in guest mode, users can't perform any
actions after clicking on the camera icon.

TBR=stevenjb@chromium.org,melandory@chromium.org

Bug: 866412
Test: Tested on eve that there's no camera icon in guest mode.
Change-Id: Ia033c0899c5d23005c1c4779d20aff72f9a91501
Reviewed-on: https://chromium-review.googlesource.com/1167147
Commit-Queue: Sheng-hao Tsao <shenghao@google.com>
Reviewed-by: Ricky Liang <jcliang@chromium.org>
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582096}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/aba1649cfb98..3e655b0ac271


git log aba1649cfb98..3e655b0ac271 --date=short --no-merges --format='%ad %ae %s'
2018-08-10 saklein@chromium.org Update expected users/groups to reflect freon values.


Created with:
  gclient setdep -r src/third_party/chromite@3e655b0ac271

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I74de16d64ff43b28da7921d5446cf4d133166724
Reviewed-on: https://chromium-review.googlesource.com/1170287Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#582095}

TracingControllerTest.DoubleStopTracing
TracingControllerTest.EnableAndStopTracingWithEmptyFile

TBR=oysteine@chromium.org

Bug: 873073
Change-Id: I1455984cf656abb30f700cdf30c5a9f770971b16
Reviewed-on: https://chromium-review.googlesource.com/1170683Reviewed-by: vitaliii <vitaliii@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582094}

Move the functions to translate back and forth between the account id
used by the OAuth service chain and the account representation used by
Chrome OS Account Manager, to a util class.

This function was previously being performed internally in
|ChromeOSOAuth2TokenServiceDelegate|. Move it to a common util class
because other usages (ARC++) have cropped up that should not depend on
|ChromeOSOAuth2TokenServiceDelegate| for this use case.

Bug: 820046, 871690
Test: unit_tests --gtest_filter="*CrOSOAuthDelegateTest*"
Change-Id: Ie5d9fe672c521c0ddf3d6e376649d3a3fb9d33cb
Reviewed-on: https://chromium-review.googlesource.com/1165352
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582093}

Add a timeout parameter for ImageFetchTabHelper::GetImageData in case the
JavaScript does not response.

Bug: 163201
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ibee9284d937f020ae8deed55eab9eb3aabdba5c1
Reviewed-on: https://chromium-review.googlesource.com/1169168
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582092}

Current implemtation for chrome.windows.create cannot handle
following combination, but throw an error message instead.
- minimized with 'focused'.
- maximized, fullscreen with 'not-focused'

This change slightly improve documentation about it

Bug: 459841
Change-Id: Id925904c2e8c1b319041a455970252bc4f59750e
Reviewed-on: https://chromium-review.googlesource.com/1169039Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Sungguk Lim <limasdf@gmail.com>
Cr-Commit-Position: refs/heads/master@{#582091}

This patch changes |CorrectedSelectionAfterCommand()| to use |Position::
IsValidFor()| to make it to check |Position| offset and return valid
selection.

Bug: 873037
Change-Id: I70c7d6f514a39414a4c3245b59969d19beb13f45
Reviewed-on: https://chromium-review.googlesource.com/1170458Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582090}

Whenever HostGpuMemoryBufferManager tries to get the GpuService instance
using GpuServiceProvider callback, it also sends a callback to be used
as the connection error handler for the GpuService. The code is also
updated such that the provider callback is called only when GpuService
has changed and the return value is cached.

BUG=733482

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I7f30dc4fd63fe079a02f6c2484ac14c75da3c36a
Reviewed-on: https://chromium-review.googlesource.com/1161211
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582089}

Minor cleanups to the code base. Preparing for future changes.

BUG=843987,802068
R=agrieve@chromium.org, pasko@chromium.org, rmcilroy@chromium.org

Change-Id: I65598259521b3e21b540cedadba99cfa58f13051
Reviewed-on: https://chromium-review.googlesource.com/1169480Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Commit-Queue: David Turner <digit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582088}

On chrome/x11, right-clicking on the window decoration bar toggles a
context menu whose one of the menu items allows switching between
builtin and system/native window decorations.

Today, chrome/ozone/wayland crashes when building the menu because it tried to
read a preference only registered in use_x11: kUseCustomChromeFrame.

So this CL does two things:

- registers the preference [1] based on PlatformProperties in case of USE_OZONE.

- checks whether using system title bar[2] is supported by underlying ozone platform.
By default, ozone platforms have this feature disabled.

[1] kUseCustomChromeFrame
[2] IDC_USE_SYSTEM_TITLE_BAR

Based on tonikitoo@igalia.com's patch.

Bug: 578890, 849596
Change-Id: Ib05d2057f1193a9e41580d0133e35dff4bc2ea77
Reviewed-on: https://chromium-review.googlesource.com/1167045
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582087}

When building with jumbo the compiler sees two
operator==, declared in the files:
content/common/media/media_devices.h
content/browser/indexed_db/scopes/scopes_lock_manager.cc

Therefore, it throws an error. This commit solves the
issue by replacing the operator with a lamdba doing
the same operation.

Change-Id: I285a95a77ac55d2502d146316da12339de277fc9
Reviewed-on: https://chromium-review.googlesource.com/1169468
Commit-Queue: Oscar Johansson <oscarj@opera.com>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582086}

This is a reland of bd08401c92882ed1c69503217a67b17274439621
(Note that the original CL is no longer in the tree; it landed during yesterday's
Gerrit outage and was reset out of existence. So this is the first time it has
"officially" landed in the tree.)

Original change's description:
> Disable some LayerTreeHostBlendingPixelTest on Linux, because flaky.
>
> Disable on Linux
>
> LayerTreeHostBlendingPixelTest.BlendingWithRenderPassShadersWithMaskColorMatrixAA_GL
> LayerTreeHostBlendingPixelTest.BlendingWithRenderPassWithMaskColorMatrixAA_GL
> LayerTreeHostBlendingPixelTest.BlendingWithRenderPassWithMaskAA_GL
> LayerTreeHostBlendingPixelTest.BlendingWithRenderPassShadersWithMaskColorMatrix_GL_TextureRect
> LayerTreeHostBlendingPixelTest.BlendingWithRenderPassShadersColorMatrixAA_GL
> LayerTreeHostBlendingPixelTest.BlendingWithRenderPassShadersWithMaskColorMatrix_GL
> LayerTreeHostBlendingPixelTest.BlendingWithRenderPassShadersWithMaskAA_GL
> LayerTreeHostBlendingPixelTest.BlendingWithRenderPassColorMatrixAA_GL
>
> because flaky.
>
> TBR=ajuma@chromium.org
>
> Bug:872733
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I61a0b1cc99172da0437eec8f10149f0c46c966eb
> Reviewed-on: https://chromium-review.googlesource.com/1169204
> Reviewed-by: vitaliii <vitaliii@chromium.org>
> Commit-Queue: vitaliii <vitaliii@chromium.org>

TBR=ajuma@chromium.org

Bug: 872733
Change-Id: I044022d2db22b1cccb20692cf7300c3784ba2859
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1170543Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Commit-Queue: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582085}

Bug: 821926
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ie1a0d74985a7fb689ff0d47ba9404fd15803f0f8
Reviewed-on: https://chromium-review.googlesource.com/1158315Reviewed-by: Yuki Awano <yawano@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Eriko Kurimoto <elkurin@google.com>
Cr-Commit-Position: refs/heads/master@{#582084}

This CL adds code to PaintPropertyTreeBuilder to create transform node
for CSS object-fit. Currently only LayoutImage is supported.

BUG=854195

Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: If9002cae344c4a27c2c45cd8a7d9b94dda236861
Reviewed-on: https://chromium-review.googlesource.com/1168471
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582083}

This reverts commit 826c708a.

Reason for revert: This was speculatively reverted but wasn't the culprit.

Original change's description:
> Revert "Remove unnecessary NetworkService flag check in ResourceDispatcher"
> 
> This reverts commit 3d493dc6.
> 
> Reason for revert: FindIt blamed this CL with 85% confidence.
> 
> Sorry. I don't see anything wrong with this CL, but I also don't see
> anything wrong with any other CL in the blamelist, so I'm starting
> here. See https://crbug.com/873015 for analysis.
> 
> Original change's description:
> > Remove unnecessary NetworkService flag check in ResourceDispatcher
> > 
> > blink::ServiceWorkerUtils::IsServicificationEnabled() checks
> > whether NetworkService is enabled, so we don't need the check
> > in ResourceDispatcher::StartAsync().
> > 
> > Bug: N/A
> > Change-Id: I06bab175489f42dc0cefa2a257806db29192eba1
> > Reviewed-on: https://chromium-review.googlesource.com/1168707
> > Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
> > Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#581828}
> 
> TBR=yhirano@chromium.org,bashi@chromium.org,shimazu@chromium.org
> 
> Change-Id: Ia89cf9c0523395c7b331482f39e708f283cbc3ec
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: N/A
> Reviewed-on: https://chromium-review.googlesource.com/1170402
> Reviewed-by: Matt Giuca <mgiuca@chromium.org>
> Commit-Queue: Matt Giuca <mgiuca@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#582023}

TBR=yhirano@chromium.org,bashi@chromium.org,mgiuca@chromium.org,shimazu@chromium.org

Change-Id: Ia3b4db0a6d9586d4febc3a16c1d6f8c987b124fb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: N/A
Reviewed-on: https://chromium-review.googlesource.com/1170622Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582082}

AppWindow has its own ImmersiveFullscreenController therefore it has to
do this by itself. (similar to CustomFrameViewAshWindowStateDelegate).

Bug: 869945
Test: covered by unit tests.
Change-Id: Ibbbd71441138ff4f8cabaae6c98d30a1fc0c954d
Reviewed-on: https://chromium-review.googlesource.com/1166254
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582081}

Bug: 855465
Change-Id: I1736e5d83494341e068e4aeffeea535d624f3dd4
Reviewed-on: https://chromium-review.googlesource.com/1168944Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Cathy Li <chili@chromium.org>
Commit-Queue: Xunran Ding <xunran.ding@samsung.com>
Cr-Commit-Position: refs/heads/master@{#582080}

Change-Id: I4ba329c49203a99a9d0d2bd0c14d67b629e9da36
Reviewed-on: https://chromium-review.googlesource.com/1170448Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582079}

This is a reland of 13143b64ae10001dd25dcb8b2d8e707b9e439382

Original change's description:
> [Settings] UserEvents depends on history and passphrase
>
> The user events UI toggle should be grayed out and turned off
> when there is a passphrase or when history sync is disabled.
> Note that this is purely a UI change: the internal sync datatype
> is not really turned off in that case, and we assume that the Sync
> engines will correctly stop syncing user events in these cases,
> even if the preference is still ON.
>
> Bug: 865522, 865537
> Change-Id: I04844e2ab9c631300e88f02bbedd712f7618bc32
> Reviewed-on: https://chromium-review.googlesource.com/1160658
> Reviewed-by: Scott Chen <scottchen@chromium.org>

TBR=droger

Bug: 865522, 865537
Change-Id: Ifae79eaf00a42c3b536bc54fa5d23cbcbcabd18a
Reviewed-on: https://chromium-review.googlesource.com/1170202
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582078}

This is reland of https://crrev.com/c/1164570

Change summary: A header view may outlive the target widget,
which can be differet widget. Reset the reference and check
before calling target widget.

I also changed the ownership of the widget for WideFrameView because
its lifetime is controlled by ClientControlledShellSurface. This
fixed the asan issue.

Bug: b/112240082
Test: covered by unittests. asa build of exo_unittests passed
Change-Id: I2ef2cc4be2fa0294b689def79d35bc0884b0fe1a
Reviewed-on: https://chromium-review.googlesource.com/1169969
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582077}

Painters uses physical coordincates. Previously sometimes we mistakenly
skipped painting when a flipped element had asymmetric visual overflow.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: If9ae7f6b772fc5b64a3a0ce4f0a52f6c3eb90f90
Reviewed-on: https://chromium-review.googlesource.com/1167791Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582076}

Added the checkbox to disable logging in ChromeVox options page.

Bug: 871165
Change-Id: I69c6ecbb47bd15a0e058ce06e52e49bbbacd6f44
Reviewed-on: https://chromium-review.googlesource.com/1164736
Commit-Queue: Eriko Kurimoto <elkurin@google.com>
Reviewed-by: Yuki Awano <yawano@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582075}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=govind@chromium.org

Change-Id: I52d5f06a4b524307d6b1045e4e8057de641e6289
Reviewed-on: https://chromium-review.googlesource.com/1170260Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582074}

https://chromium.googlesource.com/catapult.git/+log/bca7d20ad76a..0d25dda9b148


git log bca7d20ad76a..0d25dda9b148 --date=short --no-merges --format='%ad %ae %s'
2018-08-10 benjhayden@chromium.org Clarify report_template.Static.
2018-08-09 dtu@chromium.org [pinpoint] Add `comparison_magnitude` field to /api/new.


Created with:
  gclient setdep -r src/third_party/catapult@0d25dda9b148

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:870324
TBR=sullivan@chromium.org

Change-Id: Ic7108e34fdecdb7971eb6bf6761da80d696e450b
Reviewed-on: https://chromium-review.googlesource.com/1170286Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#582073}

Bug: 872575
Change-Id: I5d94177e46ede0b1107da0a253ed58f450c2c7ff
No-Tree-Checks: true
Tbr: mgiuca@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1170161Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Commit-Queue: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582072}

The code and test (but not the flag) were deleted in March 2017.
https://codereview.chromium.org/2745913003

BUG=652448

Change-Id: Ic5fe2c9be786dfa57bdd03546c990889df2a5475
Reviewed-on: https://chromium-review.googlesource.com/1163059Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582071}

When the screen dim is deferred, its associated event will be logged along with
the next event (where screen dim doesn't get deferred). Previously we log the
latest event first and then log the earlier event associated with deferred dim.
Now we change the order to log earlier event first.

Bug: 862461
Change-Id: Ib29ebf60814ce266e6d271a0a4b7a52e6b5b36f3
Reviewed-on: https://chromium-review.googlesource.com/1170158
Commit-Queue: Jia Meng <jiameng@chromium.org>
Reviewed-by: Michael Martis <martis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582070}

AAGUID length received from AuthenticatorGetInfo response must be of
length 16[1]. Add this check when parsing response from device and if
AAGUID length is any number other than 16, return base::nullopt.

[1]: https://fidoalliance.org/specs/fido-v2.0-rd-20170927/fido-client-to-authenticator-protocol-v2.0-rd-20170927.html#authenticatorgetinfo-0x04

Bug: 872217
Change-Id: I58e86942ef7eedd3075dabcf49c25407ce3c3050
Reviewed-on: https://chromium-review.googlesource.com/1167798
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582069}

Adds a bunch of tests with high-probability flake due to timeout or
crash, to existing lists of very similar tests that were already
disabled.

Tbr: mgiuca@chromium.org
Bug: 873045, 838057, 856601, 869818
Change-Id: I66e14994ef4551d5690d3a66d51fce84a1eaf456
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1170450Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Commit-Queue: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582068}

The touchevent.clientX is in CSS pixel, and TrackWidth is in CSS * zoom.
This causes when drag on the timeline element by touch, the position set
is wrong.

Bug: 871146
Change-Id: I6ca3c199fc9ad9eede6eea9ae92bb946fdd2fbca
Reviewed-on: https://chromium-review.googlesource.com/1165320Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582067}

caused by frame change

* Set the NONE targeting policy to the subtree of the
shell surface so that WindowEventDispatcher does not
generate syntheiszed events when window is moved during
frame change (in WindowEventDispatcher::OnWindowBoundsChanged)

This will be updated in next version of ARC++.

Bug: b/111319005
Test: covered by unittests. also tested manually on nami device.
Change-Id: I40b86983857ef3ca564d8e3504bf23b448f0626b
Reviewed-on: https://chromium-review.googlesource.com/1170389Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582066}

Some changes in http://crrev.com/c/1111743 had made the default
referrer policy the only referrer policy used for fetching module
workers and worklet scripts, when in fact the spec indicates the
referrer policy of the fetch client settings object ("outer settings"
in the spec") should be used in the case where a ScriptFetchOptions'
referrer policy was not explicitly set. This CL ensures that we fallback
to the fetch client settings object's referrer policy in the appropriate
cases. It is a follow-up to the WPT fixes made in both:
 - https://github.com/web-platform-tests/wpt/pull/12321
 - https://github.com/web-platform-tests/wpt/pull/12330

Remaining failures are due to, and tracked by https://crbug.com/786862,
which revolves around SecurityPolicy::GenerateReferrer not taking into
account a request's origin when determining whether a request is same-origin
or not.

R=kinuko@chromium.org, kouhei@chromium.org, nhiroki@chromium.org, yhirano@chromium.org

Bug: 863769
Change-Id: If493b728df5410a332b064265bbea30527ec9e0f
Reviewed-on: https://chromium-review.googlesource.com/1164648Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Dominic Farolino <domfarolino@gmail.com>
Cr-Commit-Position: refs/heads/master@{#582065}

There's a "move these two files" comment in that list that should only
apply to two files.

Change-Id: Ic09f71fb8a41de2e2a8b99dc2f41c7e547c79b01
Reviewed-on: https://chromium-review.googlesource.com/1168942Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582064}

The following text failures:
  paint/invalidation/reflection/scroll-fixed-layer-with-reflection.html
  paint/invalidation/scroll/scroll-fixed-layer-with-transformed-parent-layer.html
  paint/invalidation/scroll/scroll-in-fixed-layer.html
  paint/invalidation/scroll/scroll-in-transformed-layer.html
  paint/invalidation/scroll/scroll-with-transformed-parent-layer.html
were added to FlagExpectations in the maintenance CL:1166930,
but they are improvements. Their invalidation images match,
and has one less object.

Reviewed the test result of build 8758.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I7665a49b24ab94f6871722f9cd172743d662ba63
Reviewed-on: https://chromium-review.googlesource.com/1170443
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582063}