- 23 Nov, 2018 39 commits
-
-
Luciano Pacheco authored
Add a message to screen reader once a volume has been ejected, it uses |speakA11yMessage| function introduced on crrev.com/c/1347956. Test: browser_test --gtest_filter="Providers/FilesAppBrowserTest.Test/providerEject" Bug: 758638 Change-Id: Id147eac183db099d8ae55f83a4632315c108cb6a Reviewed-on: https://chromium-review.googlesource.com/c/1349154Reviewed-by:
Anand Mistry <amistry@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#610544}
-
yiyix authored
Bug: 898680 Change-Id: Ib72c45a43c80a4f2ef90ee400e34274e9dff11f2 Reviewed-on: https://chromium-review.googlesource.com/c/1348858Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#610543}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4c32a64c6610..1da2242406fb Created with: gclient setdep -r src-internal@1da2242406fb The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ied2004a1ebff1c80dd45a9ed1d977e8874adbb80 Reviewed-on: https://chromium-review.googlesource.com/c/1349038Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610542}
-
Noel Gordon authored
Add a work-around for CSSRule.KEYFRAMES_RULE not being defined Closure, which does not define experimental web features. No change in behavior, no new tests. Bug: 907962 No-presubmit: true Change-Id: I4dd62588da812dbea641be898cf908056a842257 Reviewed-on: https://chromium-review.googlesource.com/c/1349147 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#610541}
-
Findit authored
This reverts commit 24d7413c. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 610526 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMjRkNzQxM2NkYmRhOGVhOTQ5NzBlYmE3NDhmZmQxYzExNDMzYzVmMww Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/16380 Sample Failed Step: viz_browser_tests Sample Flaky Test: Providers/FilesAppBrowserTest.Test/providerEject Original change's description: > Add spoken feedback for ejecting a volume > > Add a message to screen reader once a volume has been ejected, it uses > |speakA11yMessage| function introduced on crrev.com/c/1347956. > > --gtest_filter="Providers/FilesAppBrowserTest.Test/providerEject" > > Test: browser_test > Bug: 758638 > Change-Id: I16e20f828c05368a41046d71fcfbcf04cfb212f4 > Reviewed-on: https://chromium-review.googlesource.com/c/1348880 > Reviewed-by: Anand Mistry <amistry@chromium.org> > Commit-Queue: Luciano Pacheco <lucmult@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610526} Change-Id: Ifbc16215312062cd1593f497d96f1bddde0b2745 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 758638, 851904 Reviewed-on: https://chromium-review.googlesource.com/c/1348737 Cr-Commit-Position: refs/heads/master@{#610540}
-
Ben Wells authored
The two metrics are FileManager.ViewingFileType and Filemanager.ViewingRootType. Bug: 846132 No-try: true Change-Id: Iecafeabbeaa100495762af1d492c73cd23d9d6ac Reviewed-on: https://chromium-review.googlesource.com/c/1345949Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#610539}
-
Sam McNally authored
Bug: 907963 Change-Id: I2c7d91fa0d702b67d9b42e758030d1154dee9e2d Reviewed-on: https://chromium-review.googlesource.com/c/1349144Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I8d086ed979af370606a0e45b7f08748126a40469 Reviewed-on: https://chromium-review.googlesource.com/c/1349037Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610537}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I0789bb4b5ec0defff59e5a469f423e35c5bc3f38 Reviewed-on: https://chromium-review.googlesource.com/c/1348913Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#610536}
-
Luciano Pacheco authored
Change all unit tests inside ui/file_manager/file_manager/ to not require each translation string, by returning the message id as the translated string by default. Some tests check against specific text, so only those specific texts were kept. Bug: 907966 Change-Id: I9d6ad880c6cb7105b7828819391878a682b3e6ed Reviewed-on: https://chromium-review.googlesource.com/c/1349140Reviewed-by:
-
Noel Gordon authored
Bug: 907962 Change-Id: Ia16246c0c4685b07b721e18e48d4c4f23bc210e6 Reviewed-on: https://chromium-review.googlesource.com/c/1349139Reviewed-by:
-
Sam McNally authored
Bug: 907961 Change-Id: I2fb696f5829d822786380d6abd5573f18deb2474 Reviewed-on: https://chromium-review.googlesource.com/c/1349138Reviewed-by:
-
Joel Hockey authored
Bug: 627371 Change-Id: I55e322bd36ff7eeb5699f9e2bd9842c01938d1da Reviewed-on: https://chromium-review.googlesource.com/c/1349131Reviewed-by:
-
Joel Hockey authored
Bug: 653007 Change-Id: If42d9ae0a01f5936196a934d6db7bf9603d08213 Reviewed-on: https://chromium-review.googlesource.com/c/1349137Reviewed-by:
-
Xi Cheng authored
Change-Id: I0ab76534d1afcf7e5b0faaf0629f3687e1e8ec45 Reviewed-on: https://chromium-review.googlesource.com/c/1347064 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#610530}
-
Ben Wells authored
Bug: 907458 Change-Id: Id908b12851734524b0a5d656ce9b13ae1e9a1eea Reviewed-on: https://chromium-review.googlesource.com/c/1347636Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 98cf449e. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I30e03c63c4e830eda3e3bdfbc0c60aa76aa795b7 Reviewed-on: https://chromium-review.googlesource.com/c/1348734 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610528}
-
Giovanni Ortuño Urquidi authored
Replace ash::BluetoothDeviceInfo with device::mojom::BluetoothDeviceInfo. The new struct will be returned by the BT System interface and used instead of ash::BluetoothDeviceInfo. Bug: 882346 Change-Id: I01830955e5caef35b430d69e48ae129df47eac8c Reviewed-on: https://chromium-review.googlesource.com/c/1328624Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Ovidio Henriquez <odejesush@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#610527}
-
Luciano Pacheco authored
Add a message to screen reader once a volume has been ejected, it uses |speakA11yMessage| function introduced on crrev.com/c/1347956. --gtest_filter="Providers/FilesAppBrowserTest.Test/providerEject" Test: browser_test Bug: 758638 Change-Id: I16e20f828c05368a41046d71fcfbcf04cfb212f4 Reviewed-on: https://chromium-review.googlesource.com/c/1348880Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/7a3493e88767..095cc6722fa5 git log 7a3493e88767..095cc6722fa5 --date=short --no-merges --format='%ad %ae %s' 2018-11-22 gongminmin@msn.com Fix the missing pch files in spirv-reduce (#2097) 2018-11-22 dj2@everburning.com Add newline at end of file (#2098) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@095cc6722fa5 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ia4b11edb88ed99b18e11bdf3e6266c712cd44068 Reviewed-on: https://chromium-review.googlesource.com/c/1349029Reviewed-by:
-
Anand K. Mistry authored
Also resolve a couple of post-submit comments from adding the fuzzer. BUG=None Change-Id: I3327e4282903907bd6b1cc8df133fe076398ee59 Reviewed-on: https://chromium-review.googlesource.com/c/1345372 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#610524}
-
Sam McNally authored
Always invoke preventDefault() to avoid the default page-down from triggering. Bug: 750403 Change-Id: I7b8779a8bd51757192c9c1534f25d9d574ca5cc5 Reviewed-on: https://chromium-review.googlesource.com/c/1348878 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
-
Luciano Pacheco authored
Add two types of messages to announce to screen reader/Chromevox when a file or multiple files are open. Add a new 0px-wide DIV to not be shown in the UI but still be accepted by screen reader, if we set display:none screen reader ignores it. This DIV has aria-live="polite" which makes screen reader read it whenever its content is updated, the "polite" part means that it will wait for any current content being read before announcing this text. Add a new method on FileManagerUI |speakA11yMesage| to change the content of the DIV above so the text is announced via screen reader. When IN_TEST, this also stores the text so it can be checked via in the tests. Add a test helper function to return all messages announced via this new method. Add a check for the A11y message on Open Image test. Test: browser_test --gtest_filter="OpenImageFiles/FilesAppBrowserTest.Test/imageOpenGalleryOpenDownloads" Bug: 428530 Tbr: aboxhall@chromium.org Change-Id: I713300a828912722c4fbe795f0505ed7db371fe0 Reviewed-on: https://chromium-review.googlesource.com/c/1347956 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2c977b4cc57d..f40150d87487 git log 2c977b4cc57d..f40150d87487 --date=short --no-merges --format='%ad %ae %s' 2018-11-22 minyue@webrtc.org Removing ANA enabling field trials. Created with: gclient setdep -r src/third_party/webrtc@f40150d87487 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:b/119788974 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iaf88d2c8e7ad69966aae5cf24584991459d7ed13 Reviewed-on: https://chromium-review.googlesource.com/c/1348581Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/26e89c1206c6..4c32a64c6610 Created with: gclient setdep -r src-internal@4c32a64c6610 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I27a2a31b87fcd04450f99e5adf04966bbd3fdb7b Reviewed-on: https://chromium-review.googlesource.com/c/1349030Reviewed-by:
-
Nicolás Peña Moreno authored
Bug: 907948 TBR=tdresser@chromium.org Change-Id: I53d328b935ab235e441f555e625aa97fac1b9ea4 Reviewed-on: https://chromium-review.googlesource.com/c/1349033 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#610519}
-
Stuart Langley authored
Bug: 905932 Change-Id: Iaeb47847d3d631bd7c2633c2b8298b83e0a81e45 Reviewed-on: https://chromium-review.googlesource.com/c/1348883 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Sam McNally authored
This reverts commit d958e2ee. Reason for revert: Looks responsible for causing android-rel compile failure: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/android-rel/4748 Original change's description: > Refactor AnimationFrameTimeHistogram to use mockable static natives > > This CL adds the necessary dependencies to use the JNI annotation > processor in base/java and converts AnimationFrameTimeHistogram to > use mockable static methods. > > This abstraction should have little overhead once R8 is used instead > of proguard but for now it still adds methods. > > Bug: 898261 > Change-Id: I73141dfeb5916c40aafc3c58ae606fe0af7a392e > Reviewed-on: https://chromium-review.googlesource.com/c/1347202 > Reviewed-by: agrieve <agrieve@chromium.org> > Reviewed-by: Eric Stevenson <estevenson@chromium.org> > Commit-Queue: Aiden Benner <abenner@google.com> > Cr-Commit-Position: refs/heads/master@{#610514} TBR=agrieve@chromium.org,estevenson@chromium.org,abenner@google.com Change-Id: I3731924e03a3ab084bc761ae441f6bf71970ab27 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 898261 Reviewed-on: https://chromium-review.googlesource.com/c/1348886Reviewed-by:
-
Sam McNally authored
https://crrev.com/609910 made activating "Google Drive" via the enter key expand it and select "My Drive". However, it also made clicking on the expand icon have that effect. Correct this by plumbing through the event target so the same conditions apply for click events as before. Bug: 825779 Change-Id: I38661323ce1aa5fc9eeec9968aae09259c9dc84d Reviewed-on: https://chromium-review.googlesource.com/c/1347970Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/823d897350ca..15992bef28d8 git log 823d897350ca..15992bef28d8 --date=short --no-merges --format='%ad %ae %s' 2018-11-23 jiajia.qin@intel.com Update deqp31 test expectations Created with: gclient setdep -r src/third_party/angle@15992bef28d8 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Iba609b8ef80221baa4b933b168c180f1e5132111 Reviewed-on: https://chromium-review.googlesource.com/c/1349031Reviewed-by:
-
Aiden Benner authored
This CL adds the necessary dependencies to use the JNI annotation processor in base/java and converts AnimationFrameTimeHistogram to use mockable static methods. This abstraction should have little overhead once R8 is used instead of proguard but for now it still adds methods. Bug: 898261 Change-Id: I73141dfeb5916c40aafc3c58ae606fe0af7a392e Reviewed-on: https://chromium-review.googlesource.com/c/1347202Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Aiden Benner <abenner@google.com> Cr-Commit-Position: refs/heads/master@{#610514}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7dd3be88. With Chromium commits locally applied on WPT: f1fb6d61 "[EventTiming] Move tests to WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I3c1c25f71d639721bd0938c9487a0ef0bfedc106 Reviewed-on: https://chromium-review.googlesource.com/c/1349010 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
-
Findit authored
This reverts commit f1fb6d61. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 610504 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZjFmYjZkNjE4YmVhYjE4MzBhMDg2YzQzYWNlZTVjM2MxYzhkODAyOAw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/Mac10.13%20Tests/6917 Sample Failed Step: webkit_layout_tests on Intel GPU on Mac on Mac-10.12.6 Sample Flaky Test: external/wpt/event-timing/event-timing-timingconditions.html Original change's description: > [EventTiming] Move tests to WPT > > This CL moves Event Timing tests to web-platform-tests. Relevant changes: > * Move to using test_driver.click. > * Replace setTimeout with step_timeout. > * Move to using a python-based slow image resource. > > Bug: 841224 > Change-Id: I21f322546815d7d6bcec4dd1703de50a9296d992 > Reviewed-on: https://chromium-review.googlesource.com/c/1348855 > Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610504} Change-Id: Id18988562dc34b1686497c689605b8436760a10c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 841224, 907949 Reviewed-on: https://chromium-review.googlesource.com/c/1348732 Cr-Commit-Position: refs/heads/master@{#610512}
-
Jeremy Roman authored
volatile does not add atomicity or thread safety, and is unnecessary here. connection_ref_count_ is already accessed only while the graph mutex is held, so there is no added benefit of atomic operations. Change-Id: I69ecb8293360631872f8914b9bb013d06f49717d Reviewed-on: https://chromium-review.googlesource.com/c/1348854Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#610511}
-
Sam McNally authored
Bug: 901689 Tbr: jbudorick@chromium.org Change-Id: I48b28368a6474a279e6f0aa858bcfc3c969ead89 Reviewed-on: https://chromium-review.googlesource.com/c/1348876 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
-
Matt Giuca authored
Makes it not so prominent (after "open in incognito" rather than being the topmost item on the menu). Bug: 907298 Change-Id: I74997f18a7b6bb39db1210912ed1f40e69a4fffe Reviewed-on: https://chromium-review.googlesource.com/c/1345754 Commit-Queue: Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#610509}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4a3f1fe4eec5..1c0ea2893ed5 git log 4a3f1fe4eec5..1c0ea2893ed5 --date=short --no-merges --format='%ad %ae %s' 2018-11-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 18a84258b13d..46988abef6c8 (1 commits) Created with: gclient setdep -r src/third_party/skia@1c0ea2893ed5 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: Ifda265482d40098642ca49cef859098aeba1cf2b Reviewed-on: https://chromium-review.googlesource.com/c/1348590Reviewed-by:
-
Stuart Langley authored
Bug: 905932. 905931 Change-Id: I8a22dd234bd755038b557d896bba0a8981c0e58e Reviewed-on: https://chromium-review.googlesource.com/c/1348877Reviewed-by:
-
Noel Gordon authored
- remove media_scanner_unittest.html, update build rules to closure compile this unittest, auto-generate this unittest file. - fix closure type errors (the test mocks and unittest code diverged from the real world over time, sadly), fix or add commentary. - import*ScanResults => import*ScanResult, the former is undefined. - scanDirectory|File require a |mode| argument per the externs, so add it everywhere. - re-order the test media scan and scan result class definitions to follow the definition order of their extern file. - run the js formatter over the code. Bug: 905931 Change-Id: I27239333e2ab2d8bc1c50c6bcade75cc2d6b6701 Reviewed-on: https://chromium-review.googlesource.com/c/1348874Reviewed-by:
-
- 22 Nov, 2018 1 commit
-
-
Luciano Pacheco authored
Change EntryList method from children to use getUIChildren so it has the same API as VolumeEntry. Change util.isDescendantEntry to check getUIChildren for EntryList and VolumeEntry if the filesystem of both entris are different. These 2 types contain entries with different filesystem thus we should check those. Add toEntryList helper just to be able to check that an entry has the method getUIChildren without closure complaining that Entry and FilesAppEntry don't have such attribute, this method is only available in EntryList and VolumeEntry. Change directory_tree EntryListItem to add the volume type attribute to have it compatible with and without MyFilesVolume flag. Change file_display.js selector to use volume-type-icon makes downloads folder selector compatible with/without MyFilesVolume flag. Change FileManager to check if MyFiles actually exist before assigning to nextCurrentDirEntry, this happens if MyFiles is a volume and isn't mounted. Also in this condition (MyFiles being a volume but not mounted) change NavigationListModel to create a EntryList for MyFiles so it can display Linux or Play files if they exist. before this change. Test: Enabled a few tests with MyFilesVolume flag that were broken Bug: 873539 Change-Id: I66d2b95d5ea5897c2f2db558f46b0bcfcfd0c900 Reviewed-on: https://chromium-review.googlesource.com/c/1345708 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#610505}
-
