GitLab

Updated color ids for tab background and foreground colors. New tab
ids describe the specific tab state they represent. These ids will
help in transitioning over to Color Pipeline in future changes.

Bug: 1056916
Change-Id: I098955025bbdd00bb73b4dc9de63b877acfa4880
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092553
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749767}

Bug: 1049093
Change-Id: I0aff32daa6558e0984c75f93b5de744859e14d01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098786
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749766}

Apple filed a bug asking Edge to stop using deprecated CFBundleTypes
in the Edge Info.plist.
* Added LSItemContentTypes for all types already listed
* Created UTImportedTypeDeclarations for ones that aren't already listed
in Apple's list of supported types
* Removed entries for CFBundleTypeOSTypes, CFBundleTypeExtensions
and CFBundleTypeMIMETypes

Bug: 1060363
Change-Id: Ib31b33b28c74adb4efc6a1e253ae87cc90439cda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098569Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749765}

https://webrtc.googlesource.com/src.git/+log/f092e4d0ff25..b8996ddac0b1

git log f092e4d0ff25..b8996ddac0b1 --date=short --first-parent --format='%ad %ae %s'
2020-03-12 titovartem@webrtc.org Revert "Temporary debug logging for SingleProcessEncodedImageDataInjector"
2020-03-12 jakobi@webrtc.org Clamp stable target bitrate to min/max allocated bitrate.
2020-03-12 peah@webrtc.org ACM: Corrected temporary buffer size
2020-03-12 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 96fc083e..97afa2b0 (749472:749589)
2020-03-12 danilchap@webrtc.org Pass callbacks for RtcpReceiver at construction
2020-03-12 phoglund@webrtc.org Write protos as binary.

Created with:
  gclient setdep -r src/third_party/webrtc@b8996ddac0b1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1029452
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I8c59d536d109774f30672879bd295c7be30b47c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100298Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#749764}

This CL creates the TileService interface, factory in native and connects
them to the Java layer.

Bug: 1059409
Change-Id: I964eb6d662a86196f6dc764e7de33703765de7e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097304
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Hesen Zhang <hesen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749763}

WebLayer's logic for launching external intents currently resides in a
static Java method that is called directly by C++. However, we are in
the course of changing WebLayer to share //chrome's
ExternalNavigationHandler.java, which will need to be a member of
TabImpl.java. To prepare for that change, this CL changes the C++->Java
hookup to go via TabImpl.

This CL has no behavioral changes. I tested manually that basic intent
launching still works in weblayer shell.

Bug: 1031465
Change-Id: Iaa8a16838226b70ec865316543fe51d81f95bca4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100850
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749762}

Change-Id: I9d976bd4c1a7af54500afbab57dea102f4301498
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100768
Auto-Submit: Rainhard Findling <rainhard@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749761}

Surprisingly, some methods of a BrowserListObserver registered via
BrowserTabStripTracker never get invoked. This is the root cause of
a bug about reloading tabs when changing focus https://crbug.com/871834.
Also, OnBrowserSetLastActive() is invoked for all Browsers whereas
OnBrowserAdded()/OnBrowserRemoved() are invoked only for tracked
Browser.

This CL removes the support for adding a BrowserListObserver using
BrowserTabStripTracker. Code that needs a BrowserListObserver can add
it directly on the BrowserList. This makes the interaction with the
BrowserTabStripTrackerDelegate less ambiguous.

Bug: 871834
Change-Id: I3257004f0ac711c72ce3abcade333ea1032c467e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037455
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749760}

This CL adds a new thumbnail checksum to test-25fps.h264.json to fix a
failure in guado and rikku after a mesa uprev. buddy is also failing
flakily but it seems to be because it sometimes skips the affected test
(so that's a different bug). Interestingly, other Broadwell devices are
not affected (I don't know why).

See b:149099620 for details on why this is justified. TL;DR: the
difference in the result before and after the mesa uprev is visually
insignificant.

Additionally, we take the chance to fix an incorrect if statement that
was preventing the test from saving the result of the test as a PNG on
failure.

Tast will be modified accordingly after this CL lands.

Bug: b:149099620
Test: video.DecodeAccel.h264 passes on rikku.
Change-Id: I4f1d4a79e11059de4255a14f2e7a6d7c5342c9ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099408Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: David Staessens <dstaessens@chromium.org>
Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749759}

ResolveContext now allows registration of observers for DoH server
status to get notifications on session change or servers becoming
unavailable. This both replaces the started_doh_probe_requests_ in
HostResolverManager that was used for restarting things on
config/connection change, and it also allows triggering restarts on
servers becoming unavailable due to failures.

Additional changes:
*Probe runners Start() now only starts probes for servers for which it
is not running, and leaves alone probes that are already running.
*Now that probes aren't forced to completely restart on every Start()
call, to avoid leaking state between connections, DnsSession is now
refreshed on connection change.
*With DnsSession being changed on connection change, ResolveContext now
does all work on session change rather than having special logic to
handle connection change.
*Stopped handling probes differently for online vs offline, as it was
causing unnecessary complication, when it's safe to just let probes
attempt, even when offline.

Bug: 1022059
Change-Id: I65cc132baa04e74ea8d0f01e1844027dcbe60c21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067626Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Eric Orth <ericorth@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749758}

This is a reland of 5c614415
This CL now has checks for the bucket-specific keys in waterfall.pyl
as well as the generated bucket json files and makes sure they're consistent.

Original change's description:
> infra: Generate source side spec by bucket
>
> Doesn't include internal builders.
>
> Bug: 1028719
> Change-Id: Iec40cb84086ed23cd7d5ca60c317296460466497
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033847
> Commit-Queue: Gregory Guterman <guterman@google.com>
> Reviewed-by: Stephen Martinis <martiniss@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#745574}

Bug: 1028719
Change-Id: I830a3f4c100130eeedf5c676ce9b5003590a5e8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083938
Commit-Queue: Gregory Guterman <guterman@google.com>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749757}

We do not support Clang profiling in nacl toolchains, so disable it.

Bug: 1058979
Change-Id: I397e3c9feaf8eabcd6e7e9895c9f85d96199efd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100888Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749756}

Change-Id: I4b00efdc6fca7161d1ad82404b4bcac4a25a04ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098271
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749755}

DirectoryCryptographer usages are replaced with CryptographerImpl.
KeyParams moved to encryption_helper.h.

Bug: 1061045
Change-Id: I4674ea9b0d5c162b672269622d8361bdfdf25279
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100933
Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749754}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/c7796cf40d5e..27402f3ffd34

git log c7796cf40d5e..27402f3ffd34 --date=short --first-parent --format='%ad %ae %s'
2020-03-11 tcwang@google.com toolchain_util: Run yapf
2020-03-11 gredelston@google.com Fix broken cros_fuzz_unittest.py
2020-03-11 saklein@chromium.org api/controller: Convert manual BuildTarget instantiations
2020-03-11 saklein@chromium.org cros_build_lib: Move out GetSysroot.

Created with:
  gclient setdep -r src/third_party/chromite@27402f3ffd34

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel
Bug: None
Tbr: chrome-os-gardeners@google.com
Change-Id: I88a450737c0df3e55e7a9564cbcc0ea39a235bd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100576Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#749753}

Opaque, non-transient NIKs can be created by calling
CreateOpaqueAndNonTransient(). Since it is now possible to have opaque
origins being saved to disk, Origin and NIK can now serialize themselves
with an opaque NIK.

Serialization notes:
* url::Origin adds [De]serialize methods which fully serializes the
origin into a base64 string.
* Origin's [De]serialize methods are private and can only be used by
friend classes, which NetworkIsolationKey is.

Bug: 1055911
Change-Id: Ia6b949c9cc3b80b8d56f7ec3a1ea810c1c1308ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072906Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749752}

This change improves OOBE startup time for 0.8 sec in debug mode (~2%).

Bug: 1058022
Change-Id: I1a6a8780afc4a0c2e28759beb6faeaadaef547ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100807Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749751}

This doesn't affect most tab modals, such as permissions and js dialogs,
because those have associated C++ objects which react to navigations and
close the dialogs.

This affects/fixes the form re-post confirmation dialog, which until
now would not dismiss on a navigation. It also removes code to
explicitly close that dialog when the tab is destroyed, as it duplicated
functionality from TabModalLifetimeHandler.

Bug: 1059853
Change-Id: I9d6c3c1843c1b39faf5836adf535f108bfa00eaf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095137
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749750}

This CL is the Android counterpart of crrev.com/c/2097242. It sends the
real RenderFrameHost from Java to native when initializing service worker
based payment apps. This ensures that manifest fetching happens within
the correct frame.

Bug: 1055360
Change-Id: Ie1953ec749cf04a173cd80cc09cb07f5e60ffeaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100013
Commit-Queue: Danyao Wang <danyao@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749749}

Bug: 1059442
Change-Id: I150d2d3f7c4ead040bd144891b4d1e045ec5b4ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100791
Commit-Queue: Luca Hunkeler <hluca@google.com>
Reviewed-by: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#749748}

A lot of performance tests have been disabled but most of the
cases they're flaky only on asan/lsan/msan bots, and that is
natural because the performance is worse due to additional
sanitizing. Also those performance numbers won't be helpful
anyways.

Considering that, it would be better to simply exclude them from
sanitizer builds.

This CL does not re-enable disabled tests. I'll do that after
this CL is landed, one-by-one, so that we can handle the
problem separately in case of unexpected failures on dbg/rel
bots.

Bug: 1057868
Test: build interactive_ui_tests on asan flag
Change-Id: I69c22ab575d95d2ba500556ae81ab603fde44b2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099328Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749747}

bundletool was updated with the fix needed for shared_resources=true.

Bug: 1033098
Change-Id: I7b6f540a02d9ab4335e002726d83555d01655c12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099285
Auto-Submit: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749746}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3181426885c3..8297869795cb

git log 3181426885c3..8297869795cb --date=short --first-parent --format='%ad %ae %s'
2020-03-12 jacktfranklin@chromium.org Generate `protocol.d.ts` files in devtools-frontend
2020-03-12 taoalpha@google.com Fix “open in new tab” for URLs with newlines
2020-03-12 tvanderlippe@chromium.org Add missing license headers

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@8297869795cb

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1011811
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I9cb1aeaacf799fd6f182c0e353d03ec9970edd93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100579Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#749745}

This reverts commit 756820dd.

Reason for revert: content_browsertests failing on https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/81901, https://ci.chromium.org/p/chromium/builders/ci/Win%207%20Tests%20x64%20%281%29/64935, https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/100660

Original change's description:
> Ensure UI Automation GetFocus reaches focused node in web content
> 
> AXPlatformNodeDelegate::GetFocus() returns the node within the called
> node's subtree that currently has focus. When an element in web content
> has focus, and a delegate in Views is asked for focus, that delegate can
> only reach as far as the web content root. Calling GetFocus() again on
> the web content root ensures that the platform API returns the currently
> focused node.
> 
> Bug: 928811
> Change-Id: Ice47eed0a8ea4281beb48624942ac2428fb1950f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099162
> Reviewed-by: Ian Prest <iapres@microsoft.com>
> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com>
> Cr-Commit-Position: refs/heads/master@{#749386}

TBR=kbabbitt@microsoft.com,iapres@microsoft.com

Change-Id: I824a736750c54aaa81e9ef0bf6d8e23d41089a25
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 928811
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100892Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749744}

The new error state TOO_MANY_PASSWORDS_AND_QUOTA_LIMIT allows users to
start a check in the already existing state TOO_MANY_PASSWORDS until the
quota is exceeded.

Screenshots are available at https://crbug.com/1047726#c64

Bug: 1047726
Change-Id: Ibf8dace79cbd612701e5e6b35fea473fc8be797b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098687
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749743}

This histogram existed to check if specific condition still occurs,
and that condition still occurs.

Bug: 1059796
Change-Id: I8d52b04b6fafa274c0ced21fe619608ef0069e61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095351
Auto-Submit: Eugene But <eugenebut@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749742}

https://swiftshader.googlesource.com/SwiftShader.git/+log/7e857092052e..7e366320bba5

git log 7e857092052e..7e366320bba5 --date=short --first-parent --format='%ad %ae %s'
2020-03-12 bclayton@google.com Update Marl to 64d123947
2020-03-12 bclayton@google.com VkImage: Implement BC7 texture format
2020-03-11 bclayton@google.com Update Marl to 94a361cf0

Created with:
  gclient setdep -r src/third_party/swiftshader@7e366320bba5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1058107
Tbr: swiftshader-team+autoroll@google.com
Change-Id: Ic6e430df23520a2cbca93671c22edecb2e5fd7b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100578Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#749741}

While field trial testing configs' _experiment_ names don't matter, I
just learned it's necessary that their _study_ names match their
server-side configurations. This change renames the
ReducedReferrerGranularity field trial testing config entry to
LimitReferrerGranularity in order to meet this requirement.

Change-Id: I2403ebc3b20919639b875553d588209e46ed6b41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036663Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749740}

Bug: 1047726
Change-Id: I090fa23b5d3b4edc94cd9b40b5385be6a01fe14f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100971
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Auto-Submit: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749739}

Bug: 1044687
Change-Id: I698ba7bba434d30c6f2ed0928cc9c2059eb6a586
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097834Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749738}

The GPU service code assumes that all textures uploads made directly
to shared image interface are 4 byte aligned. While this is true for
RGBA resources, which have 4 bytes per pixel, its not the case for
ALPHA_8 resources. A mismatch in the expected size causes the upload
to fail and the service side tears down the GL context.

This change fixes the above by ensuring that UI resource creation code
allocates and initializes the SkBitmaps with a 4 byte alignment.

Bug:1013992
R=kbr@chromium.org,skyostil@chromium.org

Change-Id: I2bd8e4ce7764573f2cc7b78ac8582346cf9baf7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093272Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Auto-Submit: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749737}

TiclInvalidationService doesn't exist anymore, and
PerUserTopicRegistrationManager is now called
PerUserTopicSubscriptionManager. This CL updates the class diagram to
reflect these changes.

Bug: 1054367
Change-Id: I8fe14265e1ff14fc8b5488f795b2c15fc179d173
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100972
Commit-Queue: Marc Treib <treib@chromium.org>
Auto-Submit: Marc Treib <treib@chromium.org>
Reviewed-by: Maksim Moskvitin <mmoskvitin@google.com>
Cr-Commit-Position: refs/heads/master@{#749736}

This API is of questionable utility given Tab#dismissTransientUi. It
was added in 82, so it can be removed in 82 without going through
deprecation.

If it's deemed useful in the future, it will be possible to add it back.

Change-Id: I553a42e44c36471ef7b236c584a98f09d38c5c28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099763
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749735}

TimeTicks::Now() may be mocked, which means the retry logic in this
file may get stuck in an infinite loop causing tests never to shut
down. This converts to using TimeTicksNowIgnoringOverride() which is not
mockable.

BUG=1059965
TEST=none

Change-Id: I3398187f034588ce41e15bb7084328e81046f48e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096093
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749734}

If the activity is finishing or being destroyed, exit from
ChromeBrowserInitializer#handlePreNativeStartup before firing pre-native
and pre-inflation startup calls.

BUG=1059447

Change-Id: Ia907da1c39321b97cf3405b358831b71e0add482
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100110
Commit-Queue: Theresa  <twellington@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749733}

Previously landed strings for components of the Privacy Settings
redesign used place holder or slightly incorrect strings. This CL
uploads the final copy of these strings.

Bug: 1032584
Change-Id: I640636ea782e1dc2de63c0f055fc29ff793953ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100007
Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com>
Commit-Queue: dpapad <dpapad@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Auto-Submit: Theodore Olsauskas-Warren <sauski@google.com>
Cr-Commit-Position: refs/heads/master@{#749732}

Problems this is addressing:
1. The TaskRunnerImpl hierarchy is currently too complicated, with
derived classes changing how base classes function in ways that require
the two classes to update in sync without breaking each other.
2. BrowserTaskExecutor holds onto WeakReferences to
SingleThreadTaskRunnerImpls, allowing them to leak the native memory if
the caller doesn't destroy, or continuing to return destroyed runners if
the caller does destroy but GC hasn't cleaned up the runner.
3. SequencedTaskRunnerImpl creates and deletes the native side
potentially with every posted task, taking time.
4. TaskExecutors aren't reset between tests leading to tasks flakily
failing to run, or crashes in native code (haven't figured out what's
not holding onto what it should hold onto, it was too complicated, so I
fixed the caching instead).
5. UnitTestUtils#pollUiThread could time out if nothing posts tasks to
the UI thread while waiting on an AtomicBoolean or similar.

TaskRunnerImpl is now in full control of its native pointer, not
exposing it or its lock to derived classes, and only creates its native
side if a task is posted to it, as many task runners are created
statically and may never actually have a task posted to them.

A ReferenceQueue is used to detect when the TaskRunner is GC'd (or about
to be), and that queue is polled when creating new TaskRunners, or when
initializing native for a TaskRunner (basically the two operations that
aren't performance critical). In practice when running Chrome we have
approximately 5-10 TaskRunners alive at any given time, and we can't
build up many TaskRunners without creating them, so polling for deletion
at creation time should be sufficient to keep the number of dead but in
memory task runners small.

PostTask now also holds a Strong Reference to the PreNativeTaskRunners
so that they can't be deleted before their tasks are placed on the
refcounted native runner.

Bug: 1058790
Change-Id: Ib58320e6f23d83ff95dc52c52bbdcf5bf7435968
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091899Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749731}

This is a roll-back to 8.2.297. This is the most stable candidate out of the latest Canaries.

If this commit results in failures in Blink please contact the Blink sheriff. They may need to make changes to Blink because of the roll-back.

When in doubt please try to contact the committer and reviewers of this CL before reverting it.

TBR=machenbach@chromium.org,vahl@chromium.org

Change-Id: Ie5bd476974c8c9af7a5dfa008ff7755640a03277
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100848Reviewed-by: Michael Hablich <hablich@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Hablich <hablich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749730}

This change will forward the build arg to iOS test runner scripts. CL
changing how test runner scripts are consuming this arg is at
crrev/c/2092941.

Bug: 943883
Change-Id: I4f52cf5fcc83cdca75570c812fd1c0629a96f4ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099479Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749729}

Change-Id: Ia53892d8c17d8caa689c1b5e74e4df249626dfaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099477Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749728}