- 04 Nov, 2020 40 commits
-
-
dpapad authored
Bug: 1144866 Change-Id: I9607f191e309b2ce5f57f475157c17df778445f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512902 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#824171}
-
Eugene But authored
Add metric which record number of tabs after clean shutdown and after the crash. If users have more tabs in metrics recorded after the crash than there is a correlation between number of tabs and crashiness. These metrics will help us understand if reducing memory footprint from multiple tabs may have positive impact on stability. Bug: 1140990 Change-Id: I07026ac9671e72d9367faf01b5fa71d8d990bdc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516240 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
David Jean <djean@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#824170}
-
Sahel Sharify authored
debugger-inline-values-frames.js: flake portal: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVybAsSBUZsYWtlImFjaHJvbWl1bUBibGlua193ZWJfdGVzdHNAaHR0cC90ZXN0cy9kZXZ0b29scy9zb3VyY2VzL2RlYnVnZ2VyLXVpL2RlYnVnZ2VyLWlubGluZS12YWx1ZXMtZnJhbWVzLmpzDA sample failure: https://test-results.appspot.com/data/layout_results/linux-trusty-rel/17662/blink_web_tests/layout-test-results/results.html Sample failure continue-to-location-markers-in-top-level-function.js flake portal: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVybAsSBUZsYWtlImFjaHJvbWl1bUBibGlua193ZWJfdGVzdHNAaHR0cC90ZXN0cy9kZXZ0b29scy9zb3VyY2VzL2RlYnVnZ2VyLXVpL2RlYnVnZ2VyLWlubGluZS12YWx1ZXMtZnJhbWVzLmpzDA sample failure: https://test-results.appspot.com/data/layout_results/Linux_Tests/95147/blink_web_tests/layout-test-results/results.html TBR=paulirish@chromium.org Bug: 1046784, 1144273 Change-Id: If688f8666c072aad3bf6f02aa3bae44945832793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519996Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#824169}
-
Karan Bhatia authored
This reverts commit 2c7db28c. Reason for revert: The test failures were caused due to crbug.com/gn/215 which caused spurious failures in incremental rebuilds. The corresponding GN roll has now been reverted. Original change's description: > Disable JSONSchemaCompiler tests > > The tests started to fail on > https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests when > https://crbug.com/1113513#c16 was landed. > The revert was supposed to fix other failures. > > Tbr: karandeepb@chromium.org > Bug: 1113513 > Change-Id: Ia800eba3f90cf3be44bd800c999d7a694f819573 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517567 > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > Commit-Queue: Christian Dullweber <dullweber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823954} TBR=karandeepb@chromium.org,dullweber@chromium.org Change-Id: I30e936c84c9dcae8e2702eed89e320ad7f4ff5a1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1113513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518308Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#824168}
-
Michael Bai authored
This reverts commit dad827a2. Reason for revert: Change the test, previous test method caused DCHECK failure in L, M, N. The new way won't remove the view from view tree instead notify the window invisible to let the renderer think the frame is in background. Verified in N device with debug build, the issue was fixed. Original change's description: > Revert "ContentCapture: re-stream onscreen content when the frame show again" > > This reverts commit dbe0ea06. > > Reason for revert: New test fails on the following bots: > https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Phone%20Tester > https://ci.chromium.org/p/chromium/builders/ci/Marshmallow%20Tablet%20Tester > https://ci.chromium.org/p/chromium/builders/ci/Android%20WebView%20N%20%28dbg%29 > > Original change's description: > > ContentCapture: re-stream onscreen content when the frame show again > > > > Previously ContentCaptureConsumer had no way to know the the frame > > shows again because the visible content didn't change. > > > > This patch resets the task session when the frame was hidden, so > > ContentCapture task will stream on-screen content because they > > aren't streamed from the task point of view when the frame was > > shown. > > > > Adds the test to coverage this scenario. > > > > Bug: 1137463 > > Change-Id: I0065ce080101d2149622b0f9f6a3aa196c18d717 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511030 > > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > > Commit-Queue: Michael Bai <michaelbai@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#823251} > > TBR=michaelbai@chromium.org,wangxianzhu@chromium.org > > Change-Id: I219bd94c5dfc36b073590d6e604ce951aef3c966 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1137463 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518401 > Reviewed-by: Tommy Nyquist <nyquist@chromium.org> > Commit-Queue: Tommy Nyquist <nyquist@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823660} TBR=michaelbai@chromium.org,nyquist@chromium.org,wangxianzhu@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1137463 Change-Id: Ib7be9bf21a5aadcf88b79f4334e5298ee9d41275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518752Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Michael Bai <michaelbai@chromium.org> Commit-Queue: Michael Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#824167}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ie30eca62a20126b99006f0163e21f09ec764a70d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519994Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824166}
-
Jared Saul authored
Fixed: 1144787 Change-Id: I5ed58126470efc65ef8681cd7d30ce2bb1f98eda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515105 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#824165}
-
Ken Rockot authored
Several WebUI pages have recently been migrated to mojo JS modules. In the process, full closure type checking was inadvertently disabled due to incorrect use of js_type_check closure_flags. This re-enables full type checking for the affected pages and fixes any existing flaws revealed as a result Bug: 1004256 Change-Id: If11808a64501606a784495baeb2543cee33daf0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518089 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#824164}
-
Lan Wei authored
Use testdriver Action API to simulate mouse actions in uievents/mouse/layout_change_should_fire_mouseover.html. Bug: 1145677 Change-Id: If90ec00d39b773df06570aeebb0a98dbcdd1c463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518599Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#824163}
-
Mason Wilde authored
Adds a product_serial_number field to the SystemInfo struct. Bug: chromium:1140684 Change-Id: Id5f2c5db4c4282e3b0f8561fbb5edf40d57d47b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506010Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Mason Wilde <masonwilde@google.com> Cr-Commit-Position: refs/heads/master@{#824162}
-
Sean Topping authored
After https://chromium-review.googlesource.com/c/chromium/src/+/2486075, we need to re-enable the default AFDO profile. Bug: internal b/171409488 Test: CQ Change-Id: I6a9d1e27e337bb84404edf3a94b6189dd18dd0b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519720Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#824161}
-
Lan Wei authored
Use testdriver Action API to simulate mouse actions in uievents/order-of-events/mouse-events/mouseover-out.html. Bug: 1145677 Change-Id: I7438c4faea4e5bbb8e757a8db265571cc559003a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518819Reviewed-by:
-
Mark Mentovai authored
This creates a script, universalizer.py, which can create a universal .app by combining same-version x86_64 and arm64 .apps. Code-Word: calamity Bug: 1142017 Change-Id: I758469759aa0d4b9bd4559878943cdab3e6d3eb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515521 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#824159}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/46498235efc5..1ad9adae48c8 2020-11-04 tvanderlippe@chromium.org Typecheck main/MainImpl.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I87be15c0c4d98a0a1597f7b2ead13b81bea2a59b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518922Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/6d65c11720ff..ce0db01e081f 2020-11-04 btolsch@chromium.org Factor WaitForCondition to reuse in tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I2ed58e11e1dd5bb2933a64aa80f54ff9ccd915e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519583Reviewed-by:
-
Leonard Grey authored
Only enabled via the `--enable-commander` flag. Visuals still WIP, and not many commands are hooked up. Hotkey (Ctrl-Space) is probably temporary. Bug: 1014639 Change-Id: Ibb9ae8ad61d18cbb1d7bb6f0e6df9d8e5135f64a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508331Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#824156}
-
Sahel Sharifymoghaddam authored
SSLUIWorkerFetchTest.MixedContentSettings_AllowRunningInsecureContent/* is flaky on multiple platforms: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyZwsSBUZsYWtlIlxjaHJvbWl1bUBicm93c2VyX3Rlc3RzQFNTTFVJV29ya2VyRmV0Y2hUZXN0Lk1peGVkQ29udGVudFNldHRpbmdzX0FsbG93UnVubmluZ0luc2VjdXJlQ29udGVudAw TBR=agl@chromium.org Bug: 1145674 Change-Id: Ia5fad8376367f7a541290f7fed7fa173514f6ab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519588Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
-
Sky Malice authored
This usage here caused problems when trying to change the method signature of OneshotSupplier[Impl]. This method should not take OneshotSupplier objects because get() is never used. Similarly, the implementation of onAvailable() acts without any consideration for what get() would return. Refactored to use Callback<Callback<T>> to more closely match the usage. Bug: 1144824 Change-Id: I7018d3f66aeba3e7b4449f0afff379f0c7d72506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514595Reviewed-by:
David Maunder <davidjm@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#824154}
-
Pavol Marko authored
FakeCryptohomeClient is changed to simluate an ecryptfs user home only if this has been configured by FakeCryptohomeClient::SetEcryptfsUserHome, which supersedes set_needs_dircrypto_migration. Configuring a user home to be ecryptfs will have two effects: NeedsDircryptoMigration will return true for the user home and MountEx will fail if forcing dircrypto. Until this CL, FakeCryptohomeClient was pretending that all mounts are still on ecryptfs, which was masked by the migration being disallowed in ExistingUserController (due to assumed enterprise user policy in the browsertests). Bug: 832127 Change-Id: I0cd95c55d1c0fcb8a6bd862f7e9eeffcde9ecd46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515405 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#824153}
-
Lan Wei authored
Use testdriver Action API to simulate mouse actions in uievents/mouse/mouseevent_move_button.html. Bug: 1145677 Change-Id: Ie0924fe1086655c30ea765731a4927f9ec2191cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516439 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
-
Jinho Bang authored
Currently, the MediaSession.seekTo() in Java allows 0, but the JNI implementation doesn't allow 0. According to the method's description[1], it allows non-negative numbers. So, the JNI code should allow 0 as well. This issue was discovered while testing in downstream code. [1] https://source.chromium.org/chromium/chromium/src/+/master:content/public/android/java/src/org/chromium/content_public/browser/MediaSession.java;l=59 Bug: none Change-Id: I68481c484f40bd28259a98dd553c42ed3855e4ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519633Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#824151}
-
chrome://policyXiaoling Bao authored
Changes: 1) Add policy providers even when they are not active (to show potential policy conflict) 2) Returns caller the optional policy status (source of a policy, conflict etc), Bug: 1141124 Change-Id: I90356ac7c0ec376fed8cd57a1c7dbcc76a0c7814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490275Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Xiaoling Bao <xiaolingbao@chromium.org> Cr-Commit-Position: refs/heads/master@{#824150}
-
Findit authored
This reverts commit 02cc2edd. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 824126 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzAyY2MyZWRkMzBiODg3NGIyOTRkYTRjMGQ0OWQ5YjA1Y2VkN2MzNTgM Sample Failed Build: https://ci.chromium.org/b/8864530624610119968 Sample Failed Step: compile Original change's description: > [cast_bindings] Tests for MessagePort abstraction. > > Test coverage for public MessagePort interface and its interactions with > MessagePort::Receiver. Includes conversion to and from the underlying > platform type of MessagePortCast or MessagePortFuchsia. > > Bug: 1135377 > Test: //components/cast/message_port:message_port_test added > Change-Id: I5e51aa5e08eb1e3e8957963b033497a94fe0bdac > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515208 > Commit-Queue: Shawn Quereshi <shawnq@google.com> > Reviewed-by: Kevin Marshall <kmarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#824126} Change-Id: Ia7a781d21eb5f788389a350f24994fd7d0629502 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1135377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519407 Cr-Commit-Position: refs/heads/master@{#824149}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I7aa75755bd7c5148fa2b29f9e944f2768427830a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518797Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#824148}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8a275449c2e8..4989667a9c4c 2020-11-04 syoussefi@chromium.org Vulkan: Make ImageHelper::flushStagedUpdates take gl::LevelIndex 2020-11-04 jmadill@chromium.org Trace Gold Tests: Fix filter name. 2020-11-04 lehoangq@gmail.com Metal: Enable dEQP GLES3 tests on AMD 2020-11-04 ianelliott@google.com Vulkan: VVL errors once again cause dEQP tests to fail 2020-11-04 m.maiya@samsung.com Vulkan: Add support for VK_KHR_image_format_list extension If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: I83756de45dff316dd4811bd70faffdb587eeef0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518396Reviewed-by:
-
Kevin Babbitt authored
This CL plumbs CSSTokenizedValue down to CSSVariableData and uses it to keep a copy of the original text of the custom property. CSSVariableData also gains a Serialize method that returns the original text if available. Bug: 661854 Change-Id: Ieb2978b926671819b854ac04ff3a571b2989c73f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346856Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#824146}
-
Peter Kasting authored
Nearly all of this CL is removing the unused |event_flags| parameter everywhere, which allows for a simpler binding syntax at the lone callsite I'm functionally changing. Bug: 772945 Change-Id: Ia31f872d1fc58e102c9c185cf8d593176d06c6a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519855 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#824145}
-
Michael Checo authored
Screenshot: http://shortn/_BdvyNYw4ov Bug: 1059779 Test: browser_tests --gtest_filter=ScanningAppBrowserTest.All Change-Id: I1433ac215c770c9f30e043b77345b371a0d93d2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517902Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Michael Checo <michaelcheco@google.com> Cr-Commit-Position: refs/heads/master@{#824144}
-
cfredric authored
be as obvious and early as possible. This also makes some simplifications in the implementation, namely: * Using a single set to track all FPS elements, rather than separate sets for owners and members; * Building the mapping directly, rather than building a vector to be transformed into the map. Change-Id: Ia5d45e8d728e85f7831e7930021fa9bfaec45240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517702Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Cr-Commit-Position: refs/heads/master@{#824143}
-
Yue Zhang authored
This reverts commit 3474d136. Reason for revert: Try to fix the failed test. Original change's description: > Revert "Suppress TabStrip IPH when bottom sheet shows" > > This reverts commit fffc75e9. > > Reason for revert: New test consistently fails Marshmallow 64-bit Tester bot. > See: https://ci.chromium.org/p/chromium/builders/ci/Marshmallow%2064%20bit%20Tester > > Original change's description: > > Suppress TabStrip IPH when bottom sheet shows > > > > This CL hides TabStrip IPH when bottom sheet shows and reshows IPH > > right after bottom sheet hides. This CL is gated by Finch parameter > > "enable_launch_bug_fix" under flag "enable-tab-grid-layout", with gate > > function TabUiFeatureUtilities#isLaunchBugFixEnabled. > > > > Bug: 1135926 > > Change-Id: I97c80177b3fabf82aab751c6bf95a1c9b1e27432 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506618 > > Reviewed-by: Matthew Jones <mdjones@chromium.org> > > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > > Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#823416} > > TBR=mdjones@chromium.org,wychen@chromium.org,yuezhanggg@chromium.org > > Change-Id: I942224058529eb3e2eda72ca531f30d61d984724 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1135926 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518083 > Reviewed-by: Tommy Nyquist <nyquist@chromium.org> > Commit-Queue: Tommy Nyquist <nyquist@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823643} TBR=nyquist@chromium.org,mdjones@chromium.org,wychen@chromium.org,yuezhanggg@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1135926 Change-Id: I9dba86c6464f53ef76a8613af759258eee6f3931 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518262Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#824142}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1604491008-5013724a12e21f5f9a4783fc91443d2909a128dc.profdata to chrome-mac-master-1604512659-45eb42cef0308750e2a844fa6affa8130c8ae0d0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I40304dbd69fddb735bd9e80f73c42c58eb5ebede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518928Reviewed-by:
-
James Hollyer authored
This CL enables the Pointer Lock Options flag by default. Bug: 1124396 Change-Id: I8667dcba40dae0a62ac90d7e6453ee9776e158fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518107Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: James Hollyer <jameshollyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#824140}
-
David Black authored
The views for holding space items are inserted at a calculated index during item finalization. This requires us to determine which section of holding space UI these views belong to which is based on type. The previous calculation which returned whether or not two types belonged to the same section of holding space UI was flawed which could result in mis-calculation of index during item finalization. Bug: 1130625 Change-Id: Ib2211531c3281d525dd2bf2a5eac0ae985d94755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519057Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#824139}
-
Caitlin Fischer authored
Histograms that are whitelisted because they have expired should mention in their summaries the period for which there is incomplete data. Change-Id: I95f4e6946a0cab3fe3b3a92557385fa11c9d8a22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519398 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
-
My Nguyen authored
Bug: None Change-Id: Icd11d5edca583b42c7d63b79d679936aad2e8e08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517343 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
-
Alex Turner authored
base::Bind, base::Callback and base::Closure are deprecated and should be replaced with the more explicit base::Bind{Once,Repeating}, base::{Once,Repeating}Callback and base::{Once,Repeating}Closure. This cl finishes the conversion started by crrev.com/c/2493044 and removes the directory from the legacy exception list in PRESUBMIT.py. Bug: 1141564 Change-Id: Iaac5f197d740c806ded30ddbaea5c32015a118a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518030Reviewed-by:Daniel Rubery <drubery@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#824136}
-
Jesse McKenna authored
This change moves function GetSanitizedFileName(), used to sanitize web-app names for use as filenames on Windows, to the Windows-specific file web_app_shortcut_win. This also removes logic for non-Windows operating systems from the function. GetSanitizedFileName() is only used on Windows: its only callers are in web_app_shortcut_win.cc and web_app_handler_registration_utils_win.cc. Change-Id: I06aff89548636c986de0eca637b5a9c54d699505 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508362Reviewed-by:
Glen Robertson <glenrob@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#824135}
-
Matt Reynolds authored
chrome://bluetooth-internals used HTML imports, which have been deprecated along with other Web Components V0 APIs. The imports have been replaced with regular <script> tags. Bug:1110954 Change-Id: Ie7041825896a316af9617cb44dd9eeffc0a33de7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487688 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1604491008-3c33d4506f1877c8f5c193fdb795c1a4d1ae6438.profdata to chrome-linux-master-1604512659-4b84fe5629f68a4167b75a88f505e98c0dbfa654.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If8d8684a4468ecada1e3f6dba195c68da2d2063c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518927Reviewed-by:
-
Sahel Sharifymoghaddam authored
Example failure: """ Test that Inspector.targetReloadedAfterCrash is not fired when service worker just created(not restarted) Started and attached to service_worker target Stopped service worker and received Inspector.targetCrashed event FAIL: targetReloadedAfterCrash received for a new service worker """ TBR=yurys@chromium.org Bug: 1046784 Change-Id: I2415e6918957050273640c03e9d6a3b670eb4177 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519735Reviewed-by:
-
