GitLab

DiscardableMemoryAllocator::AshmemRegion used to implement an interface but this
is not the case anymore therefore there is no reason to keep ~AshmemRegion()
virtual (since AshmemRegion is/should never be subclassed either).

TBR=willchan@chromium.org

Review URL: https://codereview.chromium.org/141283006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245520 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245519 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=165279:165308&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/135853025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245518 0039d316-1c4b-4281-b951-d872f2087c98

Mac10.6 Tests (1) interactive_ui_tests
AppListServiceMacInteractiveTest.ShowAppListUsingShim is flaky.

http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests%20%281%29/builds/48525
http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests%20%281%29/builds/48527
http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests%20%281%29/builds/48529

interactive_ui_tests AppListServiceMacInteractiveTest.ShowAppListUsingShim
failed in these three builds, but not in the builds in between. Looks flaky.

A recent relevant change is r245472.

TBR=tapted
BUG=335550


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245517 0039d316-1c4b-4281-b951-d872f2087c98

It's required during compilation on the host for webui tests

BUG=331585
R=machenbach@chromium.org

Review URL: https://codereview.chromium.org/132233018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245515 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334841
TEST=manual

Review URL: https://codereview.chromium.org/138963007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245514 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds a command-line flag "file-manager-enable-multi-profile".

BUG=335467
TEST=manually

Review URL: https://codereview.chromium.org/140913008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245513 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245512 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/137113004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245511 0039d316-1c4b-4281-b951-d872f2087c98

147: Added support for Android and iOS to the grit policy generators.

BUG=None

Review URL: https://codereview.chromium.org/136793019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245510 0039d316-1c4b-4281-b951-d872f2087c98

InitInternal() and ReadInternal() were used to share the same implementation with UploadFileElementReaderSync.
There is no need to maintain them since UploadFileElementReaderSync is gone.
Abandon these unneeded functions and use FileStream in an asynchronous way.

BUG=294797
TEST=net_unittests

Review URL: https://codereview.chromium.org/139253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245509 0039d316-1c4b-4281-b951-d872f2087c98

Currently duration is simply returned or changed without checking whether the stream is seekable or not. MediaSourcePLayer deems a stream unseekable if the duration is more than 2^31 msec. I'm adding that check here as per the TODO.

Review URL: https://codereview.chromium.org/136523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245508 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245507 0039d316-1c4b-4281-b951-d872f2087c98

Chromium base revision: 245310 / 988ac94a
Old Skia revision: 13107
New Skia revision: 13115
Control CL: https://codereview.chromium.org/141023005

This CL was created by Skia's roll_deps.py script.

R=rmistry@google.com

Review URL: https://codereview.chromium.org/140663006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245506 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/132233017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245505 0039d316-1c4b-4281-b951-d872f2087c98

I'd like to add this for handling several features of Google Drive API
that is only available for whitelisted first-party client.
By checking the key by the newly added function, we can provide
better fallbacks for clients with third-party keys, instead of just failing.

BUG=332332, 324166

Review URL: https://codereview.chromium.org/131743018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245504 0039d316-1c4b-4281-b951-d872f2087c98

The avatar label should always be displayed on the same side
as the avatar button. Currently, the avatar label is always
displayed on the left, but the avatar icon can also be
displayed on the right. This CL moves the avatar label adds
support for displaying the avatar label on the right and moves
the avatar label to the right if the avatar icon is also on
the right.
A screenshot of the placement on the right can be found in the bug description.

BUG=332392
TEST=unit_tests

Review URL: https://codereview.chromium.org/127253004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245503 0039d316-1c4b-4281-b951-d872f2087c98

BUG=230862

Review URL: https://codereview.chromium.org/93633007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245502 0039d316-1c4b-4281-b951-d872f2087c98

ChromeCreateFileTest.CheckWriteAndReadParams crashes on Vista

> Use an alternate mechanism for CreateFile calls in Chrome
> 
> BUG=334379
> 
> Review URL: https://codereview.chromium.org/138593004

TBR=caitkp@chromium.org

Review URL: https://codereview.chromium.org/140783009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245501 0039d316-1c4b-4281-b951-d872f2087c98

Broke compilation on windows clobber builder: mc : error : -u switch cannot be used with non-Unicode message file!

> make utf-8 default encoding for remoting_localize.py
> 
> Review URL: https://codereview.chromium.org/140793007

TBR=sergeyu@chromium.org

Review URL: https://codereview.chromium.org/141003004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245500 0039d316-1c4b-4281-b951-d872f2087c98

BUG=332403
R=bulach@chromium.org

Review URL: https://codereview.chromium.org/141683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245495 0039d316-1c4b-4281-b951-d872f2087c98

thakis pointed out these are in resources.pak and so are unnecesary here.

TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/141603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245494 0039d316-1c4b-4281-b951-d872f2087c98

Because of introducing an async call during initialization, the new appstate was being changed. Playing a song adds a 'time' field to the appstate. Having a time field causes pausing the audio player once the initialization is finished.

To avoid this, a copy is made, to avoid altering the input 'playlist' object.

TEST=Tested manually. Partly browser tests.
BUG=335422

Review URL: https://codereview.chromium.org/141273004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245493 0039d316-1c4b-4281-b951-d872f2087c98

Try to insert again this image resources for showing item for task manager dialog.
(https://codereview.chromium.org/132543003/)

R=oshima@chromium.org
BUG=121242
TEST=NONE

Review URL: https://codereview.chromium.org/141083008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245491 0039d316-1c4b-4281-b951-d872f2087c98

 * Rename base_file_size to GetEstimatedFileSize
 * Simplify UpdateMaxWrittenOffset interface

BUG=334171

Review URL: https://codereview.chromium.org/140833003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245490 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/140793007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245489 0039d316-1c4b-4281-b951-d872f2087c98

BUG=335290

Review URL: https://codereview.chromium.org/140783005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245488 0039d316-1c4b-4281-b951-d872f2087c98

Replace the giant DictionaryValue with std::map.
No behavior change is intended.

Remove unused FakeDriveService::FindEntryByContentUrl().
Fix util::ConvertResourceEntryToFileResource() to set EntryKind of hosted documents correctly.
Stop depending on the results' order in SearchOperationTest.

BUG=334544
TEST=unit_tests

Review URL: https://codereview.chromium.org/135643005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245487 0039d316-1c4b-4281-b951-d872f2087c98

We should not consider event filtering info to be empty if a filter
is for a <webview> guest, i.e. it has an instance id.
This probably was an oversight while adding has_instance_id_/instance_id_
to EventFilteringInfo.

BUG=None
Test=None

Review URL: https://codereview.chromium.org/140633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245486 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/140513004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245485 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245484 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=165260:165278&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/137163005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245483 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://codereview.chromium.org/140173006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245482 0039d316-1c4b-4281-b951-d872f2087c98

When a client crash detected, the associated QuotaReservation object reclaims its reserved quota.
And then, in-flight operations should be ignored.

Review URL: https://codereview.chromium.org/139833006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245481 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds an API that SAML IdPs can use to pass credentials to
Chrome OS during login instead of relying on password scraping.

BUG=127095
TEST=New browser test + manual

Review URL: https://codereview.chromium.org/138133006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245480 0039d316-1c4b-4281-b951-d872f2087c98

R=enne@chromium.org
BUG=333045

Review URL: https://codereview.chromium.org/137993013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245479 0039d316-1c4b-4281-b951-d872f2087c98

We want to count the last the last swap in the embedding
chain. Usually there is a hardware swap for this but on mac
there doesn't appear to be one. This uses the decoder swap
for now until we know the canonical swap call and add a trace
there.

TBR=nduca@chromium.org
NOTRY=true

No-try since this is blocking this from working on the mac and I've run the tests locally.

Review URL: https://codereview.chromium.org/141163004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245478 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Add RGB565 Texture readback support in gl_helper (https://codereview.chromium.org/88033002/)

Reason for revert:
content_gl_tests failing on multiple gpu bots on the chromium.webkit buildbot.

Example: http://chromegw.corp.google.com/i/chromium.webkit/builders/GPU%20Mac10.7/builds/19123

Original issue's description:
> Add RGB565 Texture readback support in gl_helper
> 
> Plan is to add a RGB565 readback and copy conversion for RGBA8 to RGB565 in GLHelper.
> 
> BUG=323150
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245431

TBR=dtrainor@chromium.org,sievers@chromium.org,hubbe@chromium.org,aelias@chromium.org,piman@chromium.org,siva.gunturi@samsung.com
NOTREECHECKS=true
NOTRY=true
BUG=323150

Review URL: https://codereview.chromium.org/137783022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245477 0039d316-1c4b-4281-b951-d872f2087c98

> Revert 244857 "net: Remove classes which were used only by Chrom..."
>
> > net: Remove classes which were used only by Chrome Frame
> >
> > UploadData and UploadFileElementReaderSync were used only by Chrome Frame
> >
> > BUG=None
> > TEST=build
> > R=mmenke@chromium.org
> > TBR=jam@chromium.org for content/child/resource_dispatcher_unittests.cc
> >
> > Review URL: https://codereview.chromium.org/131903004
>
> TBR=hashimoto@chromium.org
>
> Review URL: https://codereview.chromium.org/139263007

TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/140733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245476 0039d316-1c4b-4281-b951-d872f2087c98

It is not necessary to explicitly make the GrContext current.
The underlying GL context is automatically made current via a
callback setup by all implementations of cc::ContextProvider.
Ganesh calls this callback before issuing any GL command, which
ensures the the appropriate GL context is current.

BUG=334886

Review URL: https://codereview.chromium.org/135753006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245475 0039d316-1c4b-4281-b951-d872f2087c98