GitLab

Updated StatusUploader to expose an API to determine if session data uploading
is allowed, and updated screenshot remote command to call this function.

BUG=487261

Review URL: https://codereview.chromium.org/1135413002

Cr-Commit-Position: refs/heads/master@{#330071}

Revert of Reland: Roll src/third_party/libsrtp 6446144:9c53f85 (svn 292694:295151) (patchset #1 id:1 of https://codereview.chromium.org/1130413005/)

Reason for revert:
This CL most likely breaks Chrome. I can't find any other reason to this issue:

https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64

Reverting to see if it helps.

Original issue's description:
> Reland: Roll src/third_party/libsrtp 6446144:9c53f85 (svn 292694:295151)
>
> This updates libsrtp to 1.5.2 and uses the OpenSSL/BoringSSL crypto code.
> See https://codereview.chromium.org/889083003/ and https://codereview.chromium.org/1098043003/
>
> Summary of changes available at:
> https://chromium.googlesource.com/chromium/deps/libsrtp/+log/6446144..9c53f85
>
> This previously landed in CL 981593002 but got reverted in CL 1131323002
> as it broke the Windows GN bots. The GN script now adds BoringSSL to the
> "public_deps" if necessary, so the include path is correct then.
>
> BUG=328475
>
> Committed: https://crrev.com/7c97ef229360cc10cae49569622bdfcba2d43f3c
> Cr-Commit-Position: refs/heads/master@{#330066}

TBR=jiayl@chromium.org,thakis@chromium.org,juberti@chromium.org,gcasto@chromium.org,jbauch@webrtc.org,mail@joachim-bauch.de
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=328475

Review URL: https://codereview.chromium.org/1139233002

Cr-Commit-Position: refs/heads/master@{#330070}

This CL starts to build nacl_helper_nonsfi_unittests.
The binary is not yet enabled to run on bots. It will be done in a following CL.

TEST=Ran locally. Ran build bots. Ran build bots with editing configuration to include nacl_helper_nonsfi_unittests.
BUG=358465

Review URL: https://codereview.chromium.org/1137553003

Cr-Commit-Position: refs/heads/master@{#330069}

The comment suggests that one can manage the factory instance using the Singleton class.
That is not possible as Singleton<T> has private methods only and declares only T::GetInstance as friend.
BrowserContextKeyedAPIFactory<X>::GetInstance cannot be defined by users however.

That misleading comment was added here
https://chromiumcodereview.appspot.com/11682005

Review URL: https://codereview.chromium.org/1135343003

Cr-Commit-Position: refs/heads/master@{#330068}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/3215e43..c338ecf

TBR=timvolodine@chromium.org

Review URL: https://codereview.chromium.org/1129223006

Cr-Commit-Position: refs/heads/master@{#330067}

This updates libsrtp to 1.5.2 and uses the OpenSSL/BoringSSL crypto code.
See https://codereview.chromium.org/889083003/ and https://codereview.chromium.org/1098043003/

Summary of changes available at:
https://chromium.googlesource.com/chromium/deps/libsrtp/+log/6446144..9c53f85

This previously landed in CL 981593002 but got reverted in CL 1131323002
as it broke the Windows GN bots. The GN script now adds BoringSSL to the
"public_deps" if necessary, so the include path is correct then.

BUG=328475

Review URL: https://codereview.chromium.org/1130413005

Cr-Commit-Position: refs/heads/master@{#330066}

This CL adds a launcherPage.hide() API which can be used by custom
launcher pages to implement custom hiding behavior. The API only works
if the custom launcher page is showing and does nothing otherwise.

BUG=481712

Review URL: https://codereview.chromium.org/1137503005

Cr-Commit-Position: refs/heads/master@{#330065}

Revert of Add the chrome.fileSystem.onVolumeListChanged event. (patchset #2 id:20001 of https://codereview.chromium.org/1135383002/)

Reason for revert:
Seems to break browser_tests failed interactive_ui_tests on
Linux Chromium OS ASan LSan Tests (1).

This CL was the best I could find in the blame list. Reverting as Chrome sheriff to see if it helps.

See https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/1252

Original issue's description:
> Add the chrome.fileSystem.onVolumeListChanged event.
>
> This CL adds an event which notifies extension about changed list of volumes
> which can be requested via chrome.fileSystem.requestFileSystem.
>
> TEST=browser_tests: *OnVolumeListChanged*
> BUG=440674
>
> Committed: https://crrev.com/a1cc3a6222b0027a3fcf7cf31787950b0496b85f
> Cr-Commit-Position: refs/heads/master@{#330047}

TBR=benwells@chromium.org,mtomasz@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=440674

Review URL: https://codereview.chromium.org/1145563002

Cr-Commit-Position: refs/heads/master@{#330064}

This expands the documentation on the protobuf definition for the
ExtensionCacheSize policy to mention the minimum allowed value and the
default.

BUG=none

Review URL: https://codereview.chromium.org/1123253004

Cr-Commit-Position: refs/heads/master@{#330063}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ea59f1a..3215e43

TBR=jsbell@chromium.org,timvolodine@chromium.org

Review URL: https://codereview.chromium.org/1135253006

Cr-Commit-Position: refs/heads/master@{#330062}

As each tiling iterator in raster and eviction queues iterates one
priority rect, those iterators know the priority rect for tiles. Thus
picture layer tilings compute priority rects only because iterators do
not pass that information to tilings. Therefore, unnecessary priority
rect computation can be avoided by passing priority rect information
from iterators to tilings.

Review URL: https://codereview.chromium.org/1126813002

Cr-Commit-Position: refs/heads/master@{#330061}

This is a reland of https://crrev.com/1117853002, which failed to compile
in CHECK_GT(size_t var, 0), and CHECK_LE(size_t var, 100) because the compiler
handles the numeric literals as signed. So compiler complained about comparing
signed and unsigned. This is fixed by using unsigned numeric literals like 0UL
and 100UL.

Calculates per-frame encode latency, which is basically the time delay from
input of each VideoFrame (VEA::Encode()) to output of the corresponding
BitstreamBuffer (VEA::Client::BitstreamBufferReady()).

It calculates encode latency values at the 50th(median), 75th, and 95th percentiles.

Also fix a wrong comment.

BUG=345181
TEST=Check "Encode latency for the 50%/75%/95%" in output logs.

Review URL: https://codereview.chromium.org/1139913009

Cr-Commit-Position: refs/heads/master@{#330060}

BUG=479246

Review URL: https://codereview.chromium.org/1129293007

Cr-Commit-Position: refs/heads/master@{#330059}

TBR=benwells@chromium.org
BUG=483615

Review URL: https://codereview.chromium.org/1141193002

Cr-Commit-Position: refs/heads/master@{#330058}

This mirrors the change in chrome/browser/extensions/api/desktop_capture/desktop_capture_api.cc in https://codereview.chromium.org/1131993005/

BUG=362214

Review URL: https://codereview.chromium.org/1138383007

Cr-Commit-Position: refs/heads/master@{#330057}

Changes:
- Update notification with type = PROGRESS, so the content is updated
  even when the message center is opened.
- Popup the notification when the download is interrupted or completed
- Add browser tests
- Fix the string ID of interrupted download

BUG=446112, 468562
TEST=run browser_tests

Review URL: https://codereview.chromium.org/1105953002

Cr-Commit-Position: refs/heads/master@{#330056}

Cr-Commit-Position: refs/heads/master@{#330055}

This CL expands padding of breadcrumbs from 5px to 9px.
Along with it, some padding are reduced to keep the overall layout.

BUG=480720
TEST=manually

Review URL: https://codereview.chromium.org/1128023006

Cr-Commit-Position: refs/heads/master@{#330054}

A new pool of resources -consisting of GpuMemoryBuffers, textures and
images- has been added to media/video and an instance is now allocated
in VideoRendererImpl.
This pool, disabled in this cl, will allow VideoRenderImpl to convert
software VideoFrames into VideoFrames backed by native resources.

Once we enable this conversion the software video playback will
benefit from this in different ways:
 - Reducing the number of copies of VideoFrame buffers, potentially
   having only one when native GpuMemoryBuffers are available.
 - Moving one copy in the media thread and removing it from the critical
   path.

BUG=485859

Review URL: https://codereview.chromium.org/1133563010

Cr-Commit-Position: refs/heads/master@{#330053}

Revert of [Chromoting] Show any startup errors in the LoadingWindow. (patchset #5 id:80001 of https://codereview.chromium.org/1139543002/)

Reason for revert:
Syntax error in the JS, breaking the closure bot and almost surely doesn't work well/breaking something in remoting.
http://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Linux/builds/22330/steps/compile/logs/stdio

Original issue's description:
> [Chromoting] Show any startup errors in the LoadingWindow.
>
> Show any connection errors during startup in the LoadingWindow rather
> than creating a new error window for the error.
>
> This cl also adds a new updateErrorMessage method to the MessageWindow
> to update the message and reset the message window as appropriate for
> an error message (disabling the spinner, updating the button label).
>
> BUG=
>
> Committed: https://crrev.com/d44e8a774ce99a89c350d10d5b3f9f644eb0c3d1
> Cr-Commit-Position: refs/heads/master@{#330022}

TBR=jamiewalch@chromium.org,garykac@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/1144593002

Cr-Commit-Position: refs/heads/master@{#330052}

Support building sandbox_linux_unittests without requiring the base
test framework.

It was already supported for Android, but make it a more generic option.

BUG=488310

Review URL: https://codereview.chromium.org/1147463003

Cr-Commit-Position: refs/heads/master@{#330051}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/98c859f..ea59f1a

TBR=jsbell@chromium.org,timvolodine@chromium.org

Review URL: https://codereview.chromium.org/1131883003

Cr-Commit-Position: refs/heads/master@{#330050}

To avoid showing wrong ServiceWorkers which are in another profile in DevTooks window.

BUG=488241

Review URL: https://codereview.chromium.org/1130093009

Cr-Commit-Position: refs/heads/master@{#330049}

This implements webstore_widget app window, and launches the app when the user
click on the notification shown when an unsupported printer is detected.

Note that the notification is behind switch --enable-printer-app-search

TODO: setting app icon; error handling.

BUG=477106
TEST=None

Review URL: https://codereview.chromium.org/1123373003

Cr-Commit-Position: refs/heads/master@{#330048}

This CL adds an event which notifies extension about changed list of volumes
which can be requested via chrome.fileSystem.requestFileSystem.

TEST=browser_tests: *OnVolumeListChanged*
BUG=440674

Review URL: https://codereview.chromium.org/1135383002

Cr-Commit-Position: refs/heads/master@{#330047}

This CL is a revert of r284166 which caused dominant color calculation
on Android to have the wrong swizzle format, producing results with
swapped R and B values.

BUG=482120

Review URL: https://codereview.chromium.org/1141503003

Cr-Commit-Position: refs/heads/master@{#330046}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/aab1d35..98c859f

TBR=jsbell@chromium.org,timvolodine@chromium.org

Review URL: https://codereview.chromium.org/1142583003

Cr-Commit-Position: refs/heads/master@{#330045}

f33cdd5  Make CFX_StringData be scoped
8b2d91c  Fix integer overflow in conversion from float to integer.
1b8a296  Use phantom handles instead of weak handles
8aa1eac  Tidy public/ directory.
fdc5e69  Fix comparison of CFX_ByteString and CFX_WideString against empty literals.
2a47d8d  Set pointers in internal fields directly instead of wrapping them
b2aa543  Make (and verify) public/ files compile under C.
e6bd866  Describe required properties of public/ files with a README.
feb10c5  Restore checked strlen conversions.

Also makes a corresponding change to pdfium_engine.cc to match a changed
pdfium API.

Review URL: https://codereview.chromium.org/1132293005

Cr-Commit-Position: refs/heads/master@{#330044}

Original CL (https://codereview.chromium.org/1059613002) works only debug build. Instead of defining two places, I think this is better.

BUG=471407

Review URL: https://codereview.chromium.org/1126013005

Cr-Commit-Position: refs/heads/master@{#330043}

This CL also refactor Reflector/BrowserCompositorOutputSurface as follows.

* BrowserCompositorOutputSurface ('s subclass) is responsible for creating Texture mailbox for mirroring
 - when reflector is set
 - or texture size is changed
* OutputSurface notifies reflector when mailbox is updated.

BUG=365662

Review URL: https://codereview.chromium.org/1123763003

Cr-Commit-Position: refs/heads/master@{#330042}

BUG=394931

Review URL: https://codereview.chromium.org/1130253007

Cr-Commit-Position: refs/heads/master@{#330041}

This completes the path from the secure surface preference, through requestMediaKeySystemAccess() and finally to CDM creation on Android where secure codecs are enabled. With this change, configs requiring secure codes are rejected without the preference and the CDM is only configures to use hardware-secure codecs if the config requires it.

There is a separate bug (http://crbug.com/478185) for implementing similar plumbing for the use of secure surfaces.

BUG=467779

Committed: https://crrev.com/9ce0a551c7f1d79dea793b5691473ef9d5fb9326
Cr-Commit-Position: refs/heads/master@{#330008}

Review URL: https://codereview.chromium.org/1131753003

Cr-Commit-Position: refs/heads/master@{#330040}

BUG=391045

Review URL: https://codereview.chromium.org/1141573002

Cr-Commit-Position: refs/heads/master@{#330039}

Previously this created an english localization folder and assumed OSX
would use it since it's the only one available. However, when english is
not one of the preferred languages, the metadata for the shim bundle
would report its filename as the display name. The metadata is used by
Spotlight, so the user would be unable to search for the app.
See the bug for more details.

With this CL, we still only create one localization folder, but use the
most preferred language reported by the OS.

This also deletes any existing shims before creating new ones.

BUG=482658

Review URL: https://codereview.chromium.org/1137373003

Cr-Commit-Position: refs/heads/master@{#330038}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d8327b3..aab1d35

TBR=jsbell@chromium.org,timvolodine@chromium.org

Review URL: https://codereview.chromium.org/1137383003

Cr-Commit-Position: refs/heads/master@{#330037}

As this bug is not repro in lab environment or locally and has been there for very long time, imagined and exprimented locally, where I intentionally crashed metro viewer before sending SetTargetSurface back to browser after channel connection and could repro this issue. Cause of why viewer process fails is still unknown, but there could be number of reasons and needs to be addressed separately.

This bug seem to be assigned to various people with different issue numbers, I plan to combine them together.
Cause of latest crash uptick might be Avast (as it seems more common than others), but low number of ClientID's and low percentage for Avast dll in rest of Chrome versions doesn't lead to any concrete conclusion.

BUG=487803
R=cpu@chromium.org,ananta@chromium.org
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/1128823009

Cr-Commit-Position: refs/heads/master@{#330036}

The enterprise enrollment oobe test helper needed some additional work
that I discovered once I started writing tests. This has been verified
to work on a VM with the new email/password separated UI.

BUG=474707
TESTING=Wrote a small autotest that passes in VM

Review URL: https://codereview.chromium.org/1130833003

Cr-Commit-Position: refs/heads/master@{#330035}

BUG=486911
TEST=Check if filenames are hidden for RAW files in a directory which hold only RAW files.

Review URL: https://codereview.chromium.org/1137343003

Cr-Commit-Position: refs/heads/master@{#330034}

This follows the refactor of CertVerifier::RequestHandle --> CertVerifier::Request.

BUG=475153

Review URL: https://codereview.chromium.org/1132103004

Cr-Commit-Position: refs/heads/master@{#330033}

This is cleanup from https://codereview.chromium.org/1122863005/

BUG=472772

Review URL: https://codereview.chromium.org/1124163003

Cr-Commit-Position: refs/heads/master@{#330032}