- 06 Jun, 2018 40 commits
-
-
Kevin McNee authored
This reverts commit 1ff37758. Reason for revert: external/wpt/webusb/idlharness.https.any.* tests are failing Original change's description: > Multi-global WebUSB WPT for window and worker > > This change updates the existing web platform tests for WebUSB to use > multi-global tests to test the API in the supported contexts. The > change updates the following tests: > * idlharness > * usb > * usbConnectionEvent > > Bug: 841510 > Change-Id: I6b118aa4121109cd6a48054c2ebc69b831660afc > Reviewed-on: https://chromium-review.googlesource.com/1087209 > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> > Cr-Commit-Position: refs/heads/master@{#564981} TBR=reillyg@chromium.org,chongz@chromium.org,odejesush@chromium.org Change-Id: Ifde97a1736134477422b6fd81392b11bbd775a63 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 841510 Reviewed-on: https://chromium-review.googlesource.com/1089690Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#565022}
-
Vikas Soni authored
All the Aimages associated with AImageReader must be closed/deleted before we close/delete the AImageReader. Bug: 849218 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I9b013a7da53f0da716b869c48fe2ee024bee21a3 Reviewed-on: https://chromium-review.googlesource.com/1087827 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#565021}
-
Jun Cai authored
Noticed this presubmit warning when working on another CL which modifies this file. This CL adds explicit for single-parameter constructors in this file. Bug: None Change-Id: I03dc030cc981751bf754f0b5f391afa747f019d9 Reviewed-on: https://chromium-review.googlesource.com/1089357Reviewed-by:
Jian Li <jianli@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#565020}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/01f608b..1b40071 git log 01f608b..1b40071 --date=short --no-merges --format='%ad %ae %s' 2018-06-06 dtu@chromium.org [pinpoint] Plumb Swarming test exceptions to the job level. Created with: gclient setdep -r src/third_party/catapult@1b40071 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I7ac3c50b2389dbf02afbaf151d2a106ac1cf9ca9 Reviewed-on: https://chromium-review.googlesource.com/1089490Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565019}
-
Wei Li authored
Turn on using pdf compositor service for printing by default. Still keep the feature flag as a kill switch for now. BUG=824867 Change-Id: I5b7751c5ce453a7ffcda1bf38b5f141135f850f6 Reviewed-on: https://chromium-review.googlesource.com/1087872Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#565018}
-
Lukasz Anforowicz authored
Bug: 807651, 848909 Change-Id: If109b4fed7cdbfcf3774335bdebc1db4b9182b4c Reviewed-on: https://chromium-review.googlesource.com/1083494 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#565017}
-
Kenneth Russell authored
A few entry points were missing the correct validation. Tested with improved conformance tests in https://github.com/KhronosGroup/WebGL/pull/2654 . Bug: 848914 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib98a61cc5bf378d1b3338b04acd7e1bc4c2fe008 Reviewed-on: https://chromium-review.googlesource.com/1086718Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#565016}
-
Ryan Hansberry authored
R=khorimoto@chromium.org Bug: 824568, 752273 Change-Id: I686f20e3933d35d58d94a5d83f89d5e171882b70 Reviewed-on: https://chromium-review.googlesource.com/1089373Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#565015}
-
Emily Hanley authored
Bug: 849541 Change-Id: Idbd3c3a0339c933c70a5a2335a1faca5f507eb72 Reviewed-on: https://chromium-review.googlesource.com/1089118 Commit-Queue: Emily Hanley <eyaich@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#565014}
-
Raymond Toy authored
When a connection is made, we remove the node from the list of tail processing nodes. But we didn't remove the node from the list of finished handlers. This is needed too because if we don't, when the finished handlers are processed, they'll disable their outputs incorrectly. Bug: 849189 Test: Change-Id: I11a5467d8ed42d9819b19a63c27e7838225f39e1 Reviewed-on: https://chromium-review.googlesource.com/1087725Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#565013}
-
Kevin McNee authored
Other versions of media/controls/modern/scrubbing.html are marked slow, but not virtual/new-remote-playback-pipeline/, causing this to flakily time out. Bug: 793771, 850116 Change-Id: I3a45716ebd797f781573b2d5d86dfa58b213b271 Reviewed-on: https://chromium-review.googlesource.com/1089384Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#565012}
-
Maria Khomenko authored
This reverts commit 6d48958d. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=850084 Original change's description: > Ignore Intent filters with wildcard hosts when handling links. > > If the Android device has a package installed that declares > an Intent filter with `android:host="*"`, Chrome will launch > the Intent picker UX whenever a person taps a link. > This is a poor user experience. (Using `android:host="*"` > arguably doesn't make much sense; normally, Intent filters > would use `*` to match subdomains such as *.google.com.) Thus, > skip Intent filters with such wildcard hosts when handling > acceptable scheme links. > > R=dtrainor@chromium.org > > Bug: 841133 > Change-Id: I3cb14309ed53e0bd623ed0da59af6635391a8718 > Reviewed-on: https://chromium-review.googlesource.com/1053847 > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Reviewed-by: Chris Palmer <palmer@chromium.org> > Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org> > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#564487} TBR=palmer@chromium.org,mthiesse@chromium.org,dtrainor@chromium.org,mariakhomenko@chromium.org,huangxueqing@xiaomi.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 841133 Change-Id: I204d582d45dd27d25f47db45a6dac07d02f351b7 Reviewed-on: https://chromium-review.googlesource.com/1089470Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#565011}
-
Theresa authored
BUG=803317 Change-Id: I75fd7239f4369c849414bb36fe99bfde2ac13f4a Reviewed-on: https://chromium-review.googlesource.com/1081516 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#565010}
-
Amy Qiu authored
Move tough_scrolling_cases into the rendering folder and refactor to inherit from RenderingStory Bug: 849392 Change-Id: I7edf70dedb6fd74e2741c568cfc5df35a35ecbf1 Reviewed-on: https://chromium-review.googlesource.com/1089038 Commit-Queue: Amy Qiu <amyqiu@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#565009}
-
Chris Hamilton authored
Change-Id: If9a30072c41647cbb8588648728dab98e043217a Reviewed-on: https://chromium-review.googlesource.com/1085307 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#565008}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9930a7e4..91b51619 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ib0252b570663b570259e5cf301a79dc08fb14850 Reviewed-on: https://chromium-review.googlesource.com/1089145Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#565007}
-
James Darpinian authored
This reverts commit dcfaac01. Reason for revert: Regressed canvas 2d performance in some MotionMark tests. Will redo as a WebGL-specific change. Original change's description: > GPU: Remove transfer buffer autoflushing. > > This is change #2 of 3 reducing context switching during WebGL > rendering. On tiled rendering GPUs context switches are slow and can > even cause multisampling artifacts. Every time the command buffer is > flushed, a context switch is possible. > > Before, the transfer buffer would flush the command buffer after an > arbitrary number of bytes were sent. This change removes that threshold. > Any performance benefit of early flushing is killed by the additional > context switching. > > Bug: 828363,835353 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I8f71668d4b976332820d290868282d41286ab4fe > Reviewed-on: https://chromium-review.googlesource.com/1077568 > Commit-Queue: James Darpinian <jdarpinian@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#563404} TBR=piman@chromium.org,jdarpinian@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 828363, 835353, 849348 Change-Id: Iba27bae33f5395333f54db4bea4e79e41cca7e31 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1087370 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#565006}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c27967f..f454bd3 git log c27967f..f454bd3 --date=short --no-merges --format='%ad %ae %s' 2018-06-06 mtklein@chromium.org rm TestConfigParsing 2018-06-06 senorblanco@chromium.org GrTessellator: yet another out-of-range splitting fix. 2018-06-06 fmalita@chromium.org Build skottie_tool on Linux only 2018-06-06 kjlubick@google.com Add fuzzer option for Blur w/o occluder 2018-06-06 halcanary@google.com Revert "Have draw(Text|PosText|PosTextH) use a single entry on the device" 2018-06-06 fmalita@chromium.org Harden SkPerlinNoiseShader StitchData initialization 2018-06-06 caryclark@skia.org work around bug 8051 Created with: gclient setdep -r src/third_party/skia@f454bd3 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:846014,chromium:846010 TBR=halcanary@chromium.org Change-Id: I131a101b1c9cdb346382716f685d65766994e5c3 Reviewed-on: https://chromium-review.googlesource.com/1089174Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565005}
-
Scott Violet authored
BUG=837700 TEST=covered by tests TBR=tsepez@chromium.org Change-Id: I9d2fc168a33e9daf00ca9ca9f8b03989122cb848 Reviewed-on: https://chromium-review.googlesource.com/1089201Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#565004}
-
Mustaq Ahmed authored
Bug: 780556 Change-Id: Ic1feadf01adc9ea60b9246c57e503b29e801e305 Reviewed-on: https://chromium-review.googlesource.com/1089117 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#565003}
-
Krishna Govind authored
R=amineer@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I33e34ba064e7e7582d1556911728dce045853daa Reviewed-on: https://chromium-review.googlesource.com/1089468Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#565002}
-
Andrew Grieve authored
Hoping that this will resolve kitkat crashes where the JNI is looking for a LegacyLinker method on the Linker class (see bug). Bug: 849554 Change-Id: I11389b76142ead6281194cf6f363c8783d3ddbbc Reviewed-on: https://chromium-review.googlesource.com/1088875 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#565001}
-
Andres Calderon Jaramillo authored
This CL changes the JpegClient::SaveToFile method in jpeg_decode_accelerator_unittest.cc so that it saves the decode result as a PNG file for easy visualization. Previously, the output was a .yuv file which couldn't be readily visualized. This makes the problem with odd-sized images more evident. Here are examples of the PNG output for three images (compared to a reference output which is the result of opening the original JPEG image in GIMP): - 80x46 JPEG (even-sized): Reference: https://drive.google.com/open?id=15hv1c4d2Iy1SPXxTk6575JPGhkGMEYnr Unit test: https://drive.google.com/open?id=1ZQtNkZzwvfIwp9kBsbwf301aIjY7zSmY - 81x46 JPEG (odd-sized): Reference: https://drive.google.com/open?id=1WB2gW0H4XB9T4-fkRIBygXvfpKkX1rxY Unit test: https://drive.google.com/open?id=1Zprc8UaPyVoYw7IWGngSmwXNEsyy__jQ - 80x45 JPEG (odd-sized): Reference: https://drive.google.com/open?id=1tnOQU4cvbtgIH5036pbb2qmaOLPBLOmK Unit test: https://drive.google.com/open?id=1XWXYnStEqTtLQPqDxZidaPIH4ShzDSaq The issue with odd-sized images will be corrected in follow-up CLs. Bug: 849776 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I50a8662544b014c6d26ed8017c1a20f2fdca329f Reviewed-on: https://chromium-review.googlesource.com/1087727 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#565000}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I3cf27aabc19df521e01b3b66193e94abd91a12a7 Reviewed-on: https://chromium-review.googlesource.com/1089374 Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564999}
-
Bruno Kim Medeiros Cesar authored
We will attempt to cherry-pick this change into M68, to finish support of USM accounts in such release. Without this, accounts that transition from regular to child will not be supervised if they already have an initialized ARC container. Bug: 836246 Change-Id: Ie4711f62614fa7b965f0b8fa1a33f69dc87b03ce Reviewed-on: https://chromium-review.googlesource.com/1083471 Commit-Queue: Bruno Kim Medeiros Cesar <brunokim@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#564998}
-
Justin Donnelly authored
Enables the following features: - New answer layout - Tab switch suggestions - Steady-state elision of scheme and trivial subdomains - Favicons - Increased vertical margins (10px) - Swap title and URL This new flag was introduced to make it easier for everyone to enable all of the UI features under development. Change-Id: I551d75053fb1aa12ca9f76fb7e38f7c85683b8aa Reviewed-on: https://chromium-review.googlesource.com/1083215 Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#564997}
-
Oystein Eftevaag authored
https://android.googlesource.com/platform/external/perfetto.git/+log/706b28889182..1bc7e6d68e88 $ git log 706b28889..1bc7e6d68 --date=short --no-merges --format='%ad %ae %s' 2018-06-06 lalitm perfetto: fix debug build 2018-06-06 lalitm trace_processor: fix failing unittests 2018-06-06 lalitm trace_processor: insert ftrace events into trace storage 2018-06-05 oysteine Chrome events: Add a field for convertible trace event args 2018-06-05 oysteine Chrome: moved tests that rely on UnixTaskRunner specifically into a !is_win block. 2018-06-05 hjd ui: Add UI unittests to travis 2018-06-05 lalitm protozero: make ParseVarInt more explicit in its return value Created with: roll-dep src/third_party/perfetto TBR=primiano@chromium.org Change-Id: I13f6bc5c39564b161cc0dcc93f5b5d6b7a14f5d4 Reviewed-on: https://chromium-review.googlesource.com/1089197Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#564996}
-
Gabriel Charette authored
In preparation for further such tests for crbug.com/847501 Add support for custom reclaim time to TaskSchedulerWorkerPoolImplTestBase and remove its requirement for workers being idle before JoinForTesting() (it was overkill after task_tracker_.FlushForTesting() and worker_pool_->JoinForTesting() already waits for the workers to return from running their last task). R=fdoray@chromium.org Bug: 847501 Change-Id: I4437163427edf4778647fe1fe9e14f9332c466db Reviewed-on: https://chromium-review.googlesource.com/1085383Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#564995}
-
Mike Klein authored
We're (unintentionally?) triggering linear sRGB 8888 drawing here by copying the color space directly off the source image for our resized surfaces. That we don't notice this is a testament to the perfect round tripping of our from_srgb and to_srgb conversion functions. I'm trying to land https://skia-review.googlesource.com/c/skia/+/132261 to intentionally break linearly blended sRGB 8888, to flush out accidental uses just like this one. With that CL applied, our drawing pipeline for linear-blended sRGB 8888 is intentionally _very_ broken, and will do broken things like linearize sources but not linearize the destination or re-encode the result of the blend. We caught this with layout tests, https://test-results.appspot.com/data/layout_results/linux_trusty_blink_rel/30657/layout-test-results/results.html Change-Id: I5814c43d861deab8a2720790fb826ed2f0a9b2bf Reviewed-on: https://chromium-review.googlesource.com/1089135Reviewed-by:
Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#564994}
-
Peng Huang authored
The original implementation needs readback from the FBO, it doesn't work with SkDDL, because the FBO will not have the content until the recorded SkDDL is played back on the Gpu thread. This CL uses SkCanvas::saveLayer() to implement the backdrop effect. It doesn't need read the FBO. Test: Passed layeout tests css3/filters/*.html with and without SkDDL Bug: 822857 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I213fdff5f73c13af34a0295c666b80353642de96 Reviewed-on: https://chromium-review.googlesource.com/1073664 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#564993}
-
Bret Sepulveda authored
Since Refresh removes the avatar button in the frame area, the test is no longer needed. Bug: 846410 Change-Id: I58d40e94aa4e4f909ebec0674c923a0a9a7f0f82 Reviewed-on: https://chromium-review.googlesource.com/1087435Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#564992}
-
Richard Baranyi authored
Bug: 848861 Change-Id: I9e34aeca5ba01199f276a4d6fec76183eda0d40a Reviewed-on: https://chromium-review.googlesource.com/1082432 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#564991}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/8ae3209..ce4b14e git log 8ae3209..ce4b14e --date=short --no-merges --format='%ad %ae %s' 2018-06-06 art-snake@yandex-team.ru Simplify check info availability. Created with: gclient setdep -r src/third_party/pdfium@ce4b14e The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I35f52886eab5910de9d3cdbca3b4aa89a46bdc30 Reviewed-on: https://chromium-review.googlesource.com/1089171Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564990}
-
Lei Zhang authored
In gen_fuzzer_owners.py, GetSourcesFromDeps() receives a list of dependencies based on the fuzzer_tests in the GN build configuration. Existing configurations are fairly simple, with source_sets as direct dependencies. Introducing a GN group into a fuzzer_test will break gen_fuzzer_owners.py. This CL augments GetSourcesFromDeps() to look through the list of dependencies for groups and replace the groups with their direct dependencies. Since groups can depend on other groups, traverse the dependencies graph until all groups have been replaced. Change-Id: Ib0e15a18c7916af6790f41b1c752ab18bda970d9 Reviewed-on: https://chromium-review.googlesource.com/1077071Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#564989}
-
Fabio Tirelo authored
Bug: 850080 Change-Id: Iec8fdc70bb943fa153a4ffbacadda9ea3478370e Reviewed-on: https://chromium-review.googlesource.com/1088755Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#564988}
-
Chong Zhang authored
It's failing consistently on the Network Service bot, probably due to DCHECK. Sample Build: https://ci.chromium.org/buildbot/chromium.fyi/Mojo%20Linux/14273 TBR=falken@chromium.org,horo@chromium.org Bug: 849670, 789111 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I3d9da983aa3ba2006a75c27639da8e6fe716875c Reviewed-on: https://chromium-review.googlesource.com/1089356 Commit-Queue: Chong Zhang <chongz@chromium.org> Reviewed-by:
Chong Zhang <chongz@chromium.org> Cr-Commit-Position: refs/heads/master@{#564987}
-
Evan Stade authored
This reverts commit 4da4d1e4. Reason for revert: linkage failures: bin/ld.lld: error: undefined symbol: NotificationUIManager::Create() >>> referenced by browser_process_impl.cc:1198 (../../chrome/browser/browser_process_impl.cc:1198) >>> browser/browser_process_impl.o:(BrowserProcessImpl::CreateNotificationUIManager()) in archive obj/chrome/browser/libbrowser.a clang: error: linker command failed with exit code 1 (use -v to see invocation) ninja: build stopped: subcommand failed. Original change's description: > Chrome OS: remove non-native notifications codepaths. > > Only support native notifications, i.e. those passed over mojo. > > Some tests are permanently removed on Chrome OS. Some tests are > migrated to message_center_unittests. > > Bug: 578868 > Change-Id: Ibd4edcd1968c94af2d24b15ed3c1329ea7bf49b1 > Reviewed-on: https://chromium-review.googlesource.com/1083937 > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#564928} TBR=stevenjb@chromium.org,sky@chromium.org,estade@chromium.org Change-Id: I91f175ba1d9d23545c4377c8c131d6c0170431db No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 578868 Reviewed-on: https://chromium-review.googlesource.com/1089471Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#564986}
-
Cathy Li authored
Change-Id: Ib56a9240c13723d5a4a2f3bb3a5ca16e6d1acaa6 Reviewed-on: https://chromium-review.googlesource.com/1087670 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#564985}
-
John Chen authored
On hosts that support both IPv4 and IPv6, ChromeDriver now listens on both protocols. Bug: chromedriver:779 Change-Id: I4a115cc0ca5cf0396acdad8d4c1a72f169120368 Reviewed-on: https://chromium-review.googlesource.com/1080448Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Jonathon Kereliuk <kereliuk@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#564984}
-
Ahmed Fakhry authored
This CL converts the Night Light command-line switch to a feature and makes it enabled by default BUG=705611,749250 Change-Id: Ie7dcfbf5539c212b964b8824c99aae44a425548e Reviewed-on: https://chromium-review.googlesource.com/1088132 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#564983}
-