- 27 Mar, 2015 40 commits
-
-
robliao authored
Local profiling suggests that converting std::set to std::vector will save around 10% of the overall startup time, likely due to the reduced allocs involved with std::vector. This change also reduces lookups by traversing the incoming dictionary and iterating on the available values instead of looking through all values for all features. Finally, cleaned up and enforced the testing accessors via code and friend declarations BUG=460987 Review URL: https://codereview.chromium.org/1010973013 Cr-Commit-Position: refs/heads/master@{#322609}
-
erikchen authored
The extension profile generator and its subclasses have been in various states of broken for quite some time. Removing them entirely. BUG=444230 Review URL: https://codereview.chromium.org/1036373002 Cr-Commit-Position: refs/heads/master@{#322608}
-
spang authored
Use the captured description of the touchscreen for Chromebook Pixel to initialize the mock touchscreen, instead of just faking a couple of the members and leaving the rest uninitialized. The press, release, & move tests are merged into one test using real captured data from the Pixel touchscreen. The other tests just got their "pressure" values rescaled to the new axis. Now we can add a test that pases in a non-MT device description. BUG=461518 TEST=events_unittests Review URL: https://codereview.chromium.org/1019803006 Cr-Commit-Position: refs/heads/master@{#322607}
-
qiangchen authored
Test= FakeVideoCaptureDeviceTest in media_unittests Review URL: https://codereview.chromium.org/1033733009 Cr-Commit-Position: refs/heads/master@{#322606}
-
sadrul authored
The CL was previously reverted in crrev.com/322355 because it broke downstream android builds. This is a straight-forward reland of the original issue. A fix will be landed for downstream once this CL lands. Original issue's description: > > precache: Move the java files into //components/precache/android > > > > This moves code out of //java/apps/chrome/.../precache into: > > . //components/precache/android/: classes that provide information about > > device-state, network connectivity etc. > > . //chrome/android/.../precache/: precache service and service launchers. > > > > BUG=401552 TBR=bengr@chromium.org,yfriedman@chromium.org,thestig@chromium.org,alexclarke@chromium.org NOPRESUBMIT=true BUG=401552 Review URL: https://codereview.chromium.org/1036363002 Cr-Commit-Position: refs/heads/master@{#322605}
-
tengs authored
This tool is based on telemetry and exercises the Smart Lock setup flow. This CL also introduces the framework that will allow implementing other end-to-end tests. BUG=chromium:442728 NOTRY=true Review URL: https://codereview.chromium.org/1004283002 Cr-Commit-Position: refs/heads/master@{#322604}
-
ianwen authored
Upper case letters for all words is not Android style. BUG=NONE Review URL: https://codereview.chromium.org/1029423011 Cr-Commit-Position: refs/heads/master@{#322603}
-
xdai authored
Reland of "Decrease the lag when switching between different categories in the Cros wallpaper selector". The original one (https://codereview.chromium.org/1028513003) caused failures in the cros_trunk official builder (see http://master.chrome.corp.google.com:8011/builders/cros%20trunk/builds/31816 for detail). The issue should fix the broken tests. BUG=454932 Review URL: https://codereview.chromium.org/1038543002 Cr-Commit-Position: refs/heads/master@{#322602}
-
dgozman authored
BUG=470453 Review URL: https://codereview.chromium.org/1039543003 Cr-Commit-Position: refs/heads/master@{#322601}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/7bc68ec..5c3405c TBR=pkasting@chromium.org,yutak@chromium.org Review URL: https://codereview.chromium.org/1039233003 Cr-Commit-Position: refs/heads/master@{#322600}
-
spang authored
These are currently DLOG() but we really shouldn't be hiding them. Also use PLOG() when we know errno will be set. BUG=none TEST=build Review URL: https://codereview.chromium.org/1032233002 Cr-Commit-Position: refs/heads/master@{#322599}
-
timvolodine authored
The test appears to be flaky on https://uberchromegw.corp.google.com/i/clank/builders/instrumentation-hammerhead-clankium-hera BUG=471211 TBR=peter@chromium.org Review URL: https://codereview.chromium.org/1036353003 Cr-Commit-Position: refs/heads/master@{#322598}
-
vabr authored
This changes the code for enabling password manager in chrome://settings. Currently, it only changes the .checked property of the associated checkbox. That does not trigger the update in preferences, one has to .click() the checkbox. BUG=369521 Review URL: https://codereview.chromium.org/1043453002 Cr-Commit-Position: refs/heads/master@{#322597}
-
knn authored
BUG=470877 Review URL: https://codereview.chromium.org/1038903002 Cr-Commit-Position: refs/heads/master@{#322596}
-
halliwell authored
This is a refactoring of our existing Ozone implementations to extract the common parts: implementing the single-full-screen-window assumption, stubbing out the bits of Ozone we don't use, and the GPU resource relinquish logic. Implementing Ozone for new hardware is now a lot simpler - just implement the ChromecastEglPlatform interface. For now, each platform still has to define the Ozone constructor function themselves, supplying an instance of the ChromecastEglPlatform subclass. BUG= Review URL: https://codereview.chromium.org/1025453002 Cr-Commit-Position: refs/heads/master@{#322595}
-
torne authored
We no longer build with the Android.mk build system, and so we don't need the special case to handle it not renaming resources when the APK package name is renamed. BUG=447666 Review URL: https://codereview.chromium.org/1040743002 Cr-Commit-Position: refs/heads/master@{#322594}
-
gayane authored
Added a histogram to log the network connection type for each successful metrics log upload. Will be used to monitor cellular uploads on Chrome on Android. BUG=455847 Review URL: https://codereview.chromium.org/1033493002 Cr-Commit-Position: refs/heads/master@{#322593}
-
earthdok authored
Make the list of libraries which are built from source match the list of pre-built libraries which are downloaded from GCS. BUG=none TBR=glider@chromium.org Review URL: https://codereview.chromium.org/1039723002 Cr-Commit-Position: refs/heads/master@{#322592}
-
lionel.g.landwerlin authored
BUG=470517 Review URL: https://codereview.chromium.org/1041803002 Cr-Commit-Position: refs/heads/master@{#322591}
-
torne authored
We no longer support building WebView with the Android build system; delete the makefiles and makefile generation scripts used for this. BUG=440793 TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/1033263002 Cr-Commit-Position: refs/heads/master@{#322590}
-
knn authored
This was broken on M42 as it was being called before JNI registration. However that code has been moved since then and it should and is working fine post M42. BUG=467938 Review URL: https://codereview.chromium.org/1034403003 Cr-Commit-Position: refs/heads/master@{#322589}
-
lazyboy authored
This was done previously accessing array by index, which is brittle b/c this depends on the ordering of the events in web_view_internal.json. BUG=None Test=None, internal only cleanup. Review URL: https://codereview.chromium.org/1039043003 Cr-Commit-Position: refs/heads/master@{#322588}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/6b1db99..7bc68ec TBR=pkasting@chromium.org,yutak@chromium.org Review URL: https://codereview.chromium.org/1034413002 Cr-Commit-Position: refs/heads/master@{#322587}
-
knn authored
BUG=471229 Review URL: https://codereview.chromium.org/1039233002 Cr-Commit-Position: refs/heads/master@{#322586}
-
timvolodine authored
Revert of Remove Qualcomm MSAA from blacklist for versions >= Lollipop. (patchset #2 id:20001 of https://codereview.chromium.org/1034933002/) Reason for revert: speculative revert, this probably broke the instrumentation-hammerhead-clankium-lmp bot: https://uberchromegw.corp.google.com/i/clank/builders/instrumentation-hammerhead-clankium-lmp also see crbug.com/471200. Original issue's description: > Remove Qualcomm MSAA from blacklist for versions >= Lollipop. > > BUG=449116 > > Committed: https://crrev.com/1e8ac18cbd0e503335e5062a677609c38d75f1be > Cr-Commit-Position: refs/heads/master@{#322472} TBR=kbr@chromium.org,senorblanco@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=449116 Review URL: https://codereview.chromium.org/1037303002 Cr-Commit-Position: refs/heads/master@{#322585}
-
knn authored
This is a cleanup change that removes support for the depfile based on first grit output. BUG=466315 Review URL: https://codereview.chromium.org/1030383003 Cr-Commit-Position: refs/heads/master@{#322584}
-
dmazzoni authored
Depends on: https://codereview.chromium.org/1020473004 BUG=323462 Review URL: https://codereview.chromium.org/1015403002 Cr-Commit-Position: refs/heads/master@{#322583}
-
sky authored
We want to use this from html_viewer, which can't depend on content. BUG=none TEST=none R=jam@chromium.org, sadrul@chromium.org, jochen@chromium.org Review URL: https://codereview.chromium.org/1034713004 Cr-Commit-Position: refs/heads/master@{#322582}
-
erikchen authored
This broke when I migrated the Handoff Manager from chrome/ into components/ BUG= Review URL: https://codereview.chromium.org/1000723003 Cr-Commit-Position: refs/heads/master@{#322581}
-
spang authored
Currently we stub out TouchEventConverterEvdev::Initialize() in the tests, but we now need to fix that because that's where we'll detect if a device is MT-capable. Initialize() looks up slot values, so we'll need to populate them from captured device descriptions in CapabilitiesToDeviceInfo(). The initial state is all zeroes except for tracking id (this matches kernel initial slot state). While we're here, clean up a bunch of the slot values setup & access code in EventDeviceInfo. BUG=461518 TEST=events_unittests Review URL: https://codereview.chromium.org/1037843003 Cr-Commit-Position: refs/heads/master@{#322580}
-
pkotwicz authored
touch noise filtering is at https://chromium.googlesource.com/chromiumos/platform/touch_noise_filter/+/master When a touch is detected as touch noise, an ET_TOUCH_CANCELLED event is sent and all of the subsequent events for that touch are dropped. A "touch press" initiates a new touch. BUG=407840 TEST=TouchNoiseFinderTest.*, TouchEventConverterEvdevTouchNoiseTest.* R=spang TBR=sadrul Review URL: https://codereview.chromium.org/1030403002 Cr-Commit-Position: refs/heads/master@{#322579}
-
phoglund authored
In other words, the old binary was built in debug, which requires a certain visual studio to be installed, whereas the new one is built in release. BUG=468779 Review URL: https://codereview.chromium.org/1035523006 Cr-Commit-Position: refs/heads/master@{#322578}
-
xunjieli authored
Use CronetURLRequestAdapter::PostTaskToNetworkThread instead of posting the task directly to network thread to make sure the start/stop netlog task is executed after request context is fully initialized. Also changed the test cases to make sure that we don't regress. BUG=470196 Review URL: https://codereview.chromium.org/996163005 Cr-Commit-Position: refs/heads/master@{#322577}
-
treib authored
Before, the colon in "extensionid:version" would get escaped, leading to confusion all around BUG=397951 Review URL: https://codereview.chromium.org/1033253002 Cr-Commit-Position: refs/heads/master@{#322576}
-
eustas authored
BUG=427418 Review URL: https://codereview.chromium.org/1035173002 Cr-Commit-Position: refs/heads/master@{#322575}
-
vabr authored
This CL changes the structure of the tests. Instead of many repetitions, there are now just 3 types of tests: failed login, successful login, and autofill test. The Environment and WebsiteTest classes are also being refactored for clarity. BUG=369521 Review URL: https://codereview.chromium.org/1026833003 Cr-Commit-Position: refs/heads/master@{#322574}
-
tfarina authored
The internal stuff will come later. Tested on Linux with the following command lines: $ gn gen out-gn $ ninja -C out-gn gles2_conform_test BUG=432959 TEST=see above R=dpranke@chromium.org,sievers@chromium.org Review URL: https://codereview.chromium.org/1038243002 Cr-Commit-Position: refs/heads/master@{#322573}
-
phoglund authored
mcasas tested it and it appears to work now. BUG=440762 Review URL: https://codereview.chromium.org/1039163002 Cr-Commit-Position: refs/heads/master@{#322572}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/d747057..6b1db99 TBR=pkasting@chromium.org Review URL: https://codereview.chromium.org/1038413002 Cr-Commit-Position: refs/heads/master@{#322571}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/daee7ea..1e37d17 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=hcm@google.com Review URL: https://codereview.chromium.org/1037173004 Cr-Commit-Position: refs/heads/master@{#322570}
-