- 29 Aug, 2020 9 commits
-
-
David Black authored
This delegate is the first of the `HoldingSpaceKeyedServiceDelegates` to be added. A follow up CL will refactor existing service logic into a `HoldingSpaceDownloadsDelegate` and `HoldingSpacePersistenceDelegate`. The delegate added in this CL is tasked with watching the local file system for changes to files backing holding space items. It notifies the service on file removal so that it can perform model updates. Currently, a watcher is added per file but this will later be changed to a single watcher per directory. This CL is mostly concerned with getting things in place and additional optimization can come later. Bug: 1122418 Change-Id: I9a796bd1318268a62e0c7227a9a299b566cc2ffc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382399 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#802863}
-
rbpotter authored
Fixed: 1123220 Change-Id: Iefc01cc978f6aff863f3c4244c32ed57b137df59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382884Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#802862}
-
wutao authored
Bug: b/164190937 Test: manual Change-Id: I8b2f4bf1ec90cb1869add3f1f71c8b96175589a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382214 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#802861}
-
nancylingwang authored
The new app icon factory code in AppService calls display::Screen::GetScreen to get the scale, so in unit tests, sometime, it crashes: 0x7f3430a96390 (/lib/x86_64-linux-gnu/libpthread-2.23.so+0x1138f) #4 0x558ca24e91ea (anonymous namespace)::GetPrimaryDisplayScaleFactor() Modify unit tests to set the TestScreen. Built bots run 20 times, and there is no flaky tests for BuiltInAppTest.Build. BUG=1115837 Change-Id: Id3ad017f5e15dbadfc6b28ef0d65295bfcc799b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379419 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#802860}
-
Thomas Guilbert authored
WebCodec already has UseCounters on its different subcomponents. Origin trial infrastructure cannot aggregate UseCounters. This CL adds a global counter that tracks anytime WebCodecs is used, to allow running an origin trial. Bug: 1123170 Change-Id: Ic8c816d99af16c78a50ebc16d693362368a7483b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382408 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#802859}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ae1672bdb5c3..6fd391a016f3 2020-08-28 herb@google.com uv in x - fix iphone6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: mtklein@google.com Change-Id: Ia54f3d5e2bd63b26676d4a830693a371bdf3198f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382018Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802858}
-
Brandon Jones authored
Blink counterpart to https://bugs.chromium.org/p/dawn/issues/detail?id=502 Due to an issue with Blink's bindings generation this CL needed to be a bit sneaky about handling the method overloading, which resulted in some annoying manual validation. The alternative, however, would be exposing a different method name which would add several more steps to the whole deprecation process, so this feels worthwhile. Bug: 1121762 Change-Id: I3f4ac324c6d91a27bfd5fabb17b1b142f7021598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376456 Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#802857}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I93ca2df444e6277bfe02c22ac19666f0a137896b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383231Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802856}
-
Maggie Chen authored
This reverts commit 8ce938a2. Reason for revert: <Suspect this CL breaks Linux FYI Ozone bot and Linux FYI SkiaRenderer Vulkan (NVIDIA)/(Intel HD 630) > Original change's description: > Reland "Reland "X11 and Ozone: enable use_x11 and use_ozone"" > > This is a reland of 75363679 > > Original change's description: > > Reland "X11 and Ozone: enable use_x11 and use_ozone" > > > > This is a reland of f985905e. > > > > This change broke our headless build: > > ERROR at //ui/events/platform/x11/BUILD.gn:51:5: Assertion failed. > > assert(ozone_platform_x11) > > ^----- > > See //components/viz/demo/BUILD.gn:73:7: which caused the file to be included. > > "//ui/events/platform/x11",. > > > > Fix: > > Don't include x11 build for headless case. > > > > Original change's description: > > > X11 and Ozone: enable use_x11 and use_ozone > > > > > > This is the final change that enables use_x11 > > > and use_ozone for Linux builds and (as it was > > > before) excludes X11 for chromeos, chromecast, > > > lacros. > > > > > > in order to run ozone/X11/wayland, one must pass > > > —enable-features=UseOzonePlatform > > > —ozone-platform=x11 or wayland. otherwise, > > > non-ozone/X11 is used. > > > > > > it’s also possible to completely disable X11 > > > so that clients, who need that kind of build can > > > continue to have that. > > > > > > Bug: 1085700 > > > Change-Id: I171bcb53c406555a1d4bec3e88d76dc676310d48 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315869 > > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > > > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > > > Reviewed-by: Scott Violet <sky@chromium.org> > > > Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> > > > Cr-Commit-Position: refs/heads/master@{#801523} > > > > Bug: 1085700 > > Change-Id: I8bf0abead6c94c95ddc58443de7cf2268c977cf1 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376806 > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > > Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> > > Cr-Commit-Position: refs/heads/master@{#801692} > > Bug: 1085700 > Change-Id: Ia5ed2af9376354d3378d8edd98a7a1446f13c88b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379190 > Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802773} TBR=rjkroege@chromium.org,sky@chromium.org,thomasanderson@chromium.org,msisov@igalia.com Change-Id: I093bf5be51d6858d895c59d6bb31f3aa61c162b9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1085700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383110Reviewed-by:
Maggie Chen <magchen@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#802855}
-
- 28 Aug, 2020 31 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/af2dca5c5320..79257bae3c9a 2020-08-28 lalitm@google.com Merge "tp: fix startup metric when success is seen multiple times" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I8fd84566dd12f0cc0bdc1f2df9a5d20005d6a028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382501Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I3a542a140fac7a43a24de761e6f46afb31e166a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382506Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a745d8886808..bb235b33d3dd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mek@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: mek@google.com Change-Id: I31f257e95524fe3b9fd7b7a66a54a904809bcfa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382505Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802852}
-
chrome://multidevice-internalsRegan Hsu authored
* New PhoneHub tab to chrome://multidevice-internals * Adds a toggle that when flipped on, will cause a FakePhoneHubManager to be used instead. Screenshot: https://screenshot.googleplex.com/7dimKet6oWrzeR4 Bug: 1106937 Change-Id: Ib2697abfaf15153b394689a804ff5ff73994ed15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380608Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#802851}
-
Mohammad Refaat authored
for iOS 13 we added fetchDataRecordsOfTypes call to make sure that cookiestore exist. but with iOS 14 this doesn't seem to be enough as the order of callbacks is not grantueed anymore. We have to wait for the fetchDataRecordsOfType callback to finish before asking for cookies operations. Bug: 1121425 Change-Id: I6a52e54ff2663ac77e8edc6dde1359a68f11604e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381091 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Auto-Submit: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#802850}
-
Jesse McKenna authored
This change skips attempting PWA launcher update if the launcher path does not exist. Chrome updates PWA launchers by iterating over a list of enabled bookmark apps. It determines each app's expected launcher path and attempts to update it. This fails if the launcher path does not exist. This change saves time spent attempting update when it's not necessary, and should reduce noise in the WebApp.Launcher.UpdateResult metric. Bug: 1123064 Change-Id: Ibb30bb054ad338b84f8fe6ab66f919d800755ce4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382752Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#802849}
-
Dana Fried authored
As pointed out, the IDS name of the string was previously changed, but the comment associated with it was not. This makes the comment both correct in context and follow the inclusive code guidelines. Skip-Translation-Screenshots-Check: True Bug: 1100024 Change-Id: I8a5dfa4e1a2f641c710aa636ba0be351f2d2e246 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373946Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#802848}
-
Alan Screen authored
Cleanup born from move of printing::ColorModel enum into mojom in r799398. Reduce the number of static_cast<int> in the code by updating the API to accept printing::mojom::ColorModel in as many places as possible. Bug: 809738 Change-Id: Ib1d0024a94e21b9bf982174d99e85b04616f1009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368082Reviewed-by:
-
Zach Trudo authored
CloudPolicyClient must be built on the main UI thread, this means that it needs to be built asynchronously. Bug: chromium:1078512 Change-Id: I7aca6e9085091a8ac4d2c6209e10260f1295c450 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368318 Commit-Queue: Zach Trudo <zatrudo@google.com> Reviewed-by:
Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#802846}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/2014e7b9290e..a2e6c1a149f4 2020-08-28 capn@google.com Optimize multisample resolve with SSE2 instructions 2020-08-28 capn@google.com Add a fast multisample resolve code path 2020-08-28 capn@google.com Make multisample resolve a Blitter method If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I3f6c31b6221b3b4cf12bc265a6fce2f959b1b817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382696Reviewed-by:
-
Bence Béky authored
Follow-up to https://crrev.com/c/2380573. Change-Id: I9dfff2099fd47601998ff775d019e79d7710c2af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382198Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#802844}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b1e3f57ef7c0..af2dca5c5320 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie0f95ddc51a0a5bd4b15cd081a1bb2352cf1cc22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382306Reviewed-by:
-
Yuly Novikov authored
Flaky timeout. TBR=bsheedy Bug: 1122373 Change-Id: I5a10681d5d0bc5dea24c168c9c27e254623cdce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382409 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#802842}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I3e6999154e2cbb54e35a1428762970d973732f0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382871Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802841}
-
Mei Liang authored
This CL uses AccessibilityNodeInfo to set the checked state of the selectable tab, so it can be used by the accessibility services. Bug: 1117205 Change-Id: Ia42b44fc2c280ceb690c2b08114368279a541d68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380412 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#802840}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1e87a9ab4a13..ae1672bdb5c3 2020-08-28 egdaniel@google.com Remove the kFramebufferOnly flag from our validation checks again. 2020-08-28 herb@google.com secure AtlasLocator 2020-08-28 herb@google.com store the page bits in U only If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: mtklein@google.com Change-Id: Ie25f6878190999ad6e0094bcae281e98ef46d627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382503Reviewed-by:
-
Himanshu Jaju authored
Replacing my name with correct crbug issues. Change-Id: I9911cbfa68b6f41a50cf9c7aecfb4f9045fdcd98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382830Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: James Vecore <vecore@google.com> Auto-Submit: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#802838}
-
Ian Kilpatrick authored
There should be no behaviour change. Change-Id: Idcb508733afafbc8b4b22ee65ad93c4362224855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376981Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#802837}
-
Vikas Soni authored
Adding a fix to do a null dereference check in AbstractTextureImplOnSharedContextPassthrough destructor which might be the reason of webgl2_conformance_gles_passthrough_tests failures on android. Bug: 1122631 Change-Id: Ia5fa32fcd0ca70407b8f28ceecba1748f78b692f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382314Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#802836}
-
Maciek Kumorek authored
TabHoverCardEventSniffer calls GetNativeWindow() in the destructor and it appears that on latest prerelease versions of Windows the NativeWindow is nulled at this point - DesktopNativeWidgetAura::OnHostClosed is called first. Work around this by keeping the pointer to owning view. Bug: 1122123 Change-Id: I9e688c05b3182c659de0afb8e0a1d27d362f3df5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377651Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Maciek Kumorek <makumo@microsoft.com> Cr-Commit-Position: refs/heads/master@{#802835}
-
Noah Rose Ledesma authored
This is a reland of 442effe1 Original change's description: > Add a MediaSessionAction for audio output device switching. > > This change adds an action to the MediaSessionAction enum for signaling > if audio output device switching is possible for that session. A session > supports switching audio devices if and only if the session has at > least one player and all of the players support audio device switching. > > When the audio output device cannot be changed, the Global Media > Controls UI should not display a device picker. This change is a part > of a series of changes for appropriately hiding this UI. > > Bug: 1120620 > Change-Id: If03ef110ff32fa0db3463c63a6a1730da60d2278 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369440 > Commit-Queue: Noah Rose Ledesma <noahrose@google.com> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org> > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Reviewed-by: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802666} Bug: 1120620 Change-Id: Ibdc5853b75e6562b82d3bd422e57bb2a16daf256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382193Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Cr-Commit-Position: refs/heads/master@{#802834}
-
Lei Zhang authored
Also mark |queue_| as a const pointer. Change-Id: I582f4a1c26eadba4dd7757efb2ee4a516fe9f063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382402Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#802833}
-
Mei Liang authored
TBR=yusufo@chromium.org Bug: 1111942, 1117205 Change-Id: I636e872b04cada76f39601b6400327fd96c20636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376454Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
-
Bella Bah authored
tools/traffic_annotation/auditor/ is currently written in C++ which poses some problems in the way of convenience. Rewriting it in Python overcomes some of these issues. Missing: - Exporter to annotations.xml. - Exporter to tsv. - Writing to a summary file. - Matching/completing partial annotations. - Handling exceptions list. - Performing all other remaining checks on annotations. - Raise an error on mutable tags. - Safelist filtering of extracted annotations. - Enforcing consistency between summary/grouping.xml and new annotations. - Checking for reserved ids and deprecated hash codes. - ID checking on annotations. - Handling removed annotations and deprecated annotations. - The remaining TODOs found in this CL. Parity: - Extracting annotations according to the compiled proto. - Checking annotations' completeness. - Catching fatal/syntax errors. - "deserialization" of extracted annotations. Bug: 1119417 Change-Id: Idd09b89577342e59011441b30a54437234ddb1bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364935 Commit-Queue: Mohamadou Bella Bah <bellabah@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#802831}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/9ed8d518cacf..0b89b27263b1 2020-08-28 enga@chromium.org Move client-side OnCompletion callbacks to the server. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Iaa3e23116a627cd995b9707f4d27cbe2c14b5c40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382504Reviewed-by:
-
Lei Zhang authored
Now that https://crbug.com/755826 has been fixed, tests that read from the clipboard can use ClipboardMonitor to get notifications for when the clipboard changes, instead of polling the clipboard. This is more straight-forward, and hopefully more reliable. The first attempt to land this in https://crrev.com/802025 failed to land safely because it collided with https://crrev.com/801651, which added a new pure virtual method to ui::ClipboardObserver. Fix this by implementing the new required override as a no-op. Tbr: slangley@chromium.org Bug: 1121446 Change-Id: I209b4fd7cd33043d7428702afd3939e1b14cbe36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378779Reviewed-by:
-
Marijn Kruisselbrink authored
This reverts commit dd30c5d1. Reason for revert: only crostini related change in the blame list when crostini tests started failing Original change's description: > [CrostiniPage] Link "Set up Crostini" search result to the setting > > Fix a bug where the "Set up Crostini" search result did not connect to > the eponymous setting, so the setting was inaccessible for deep linking. > > Bug: 1084154 > Change-Id: I0b5452425eb19203c61c8b45ba4d2d96afc16264 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380749 > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Commit-Queue: Daniel Classon <dclasson@google.com> > Cr-Commit-Position: refs/heads/master@{#802704} TBR=khorimoto@chromium.org,dclasson@google.com Change-Id: I2ce99a8cfefe985f48196c427bc03cf3ada597db No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1084154, 1123194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382315Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#802828}
-
Peter Boström authored
Renames CONTEXT_MESSAGE_BOX_BODY_TEXT => CONTEXT_DIALOG_BODY_TEXT. Replaces ChromeTextContext::CONTEXT_DIALOG_BODY_TEXT_LARGE uses CONTEXT_DIALOG_BODY_TEXT. For consistency with the rename above, CONTEXT_BODY_TEXT_SMALL is renamed CONTEXT_DIALOG_BODY_TEXT_SMALL. What this functionally means is that CONTEXT_MESSAGE_BODY_TEXT takes on the old style of CONTEXT_DIALOG_BODY_TEXT_LARGE, so one style of dialog text is dropped and the new style can be used from views code. As a result dialog body text looks more uniform. Bug: 1122602 Change-Id: Ide5650b02f06a1925b441302e46815cfa73a3d21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381299Reviewed-by:
-
Carlos IL authored
simplified_domain_bounds_ is calculated on animation start via union, but was never being reset, this was causing bugs when an animation is reused (e.g. when switching tabs, or with URLs that redirect). This adds a reset. Bug: 1117631 Change-Id: I99d1eba536f39ad3c16fc09eca0aa79788b4bb62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382893 Commit-Queue: Carlos IL <carlosil@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Auto-Submit: Carlos IL <carlosil@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#802826}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/02f6b66357eb..6c484875cdcb 2020-08-28 gbeaty@chromium.org Ensure all keys in the bot_update revisions dict use forward slash. 2020-08-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-08-28 gbeaty@chromium.org Output a newline when there are warnings and no prompt. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1047893 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I30fb0762c998ae277263bf4fa8f45b1bba709ada Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382692Reviewed-by:
-
Gauthier Ambard authored
This CL fixes a crash where the navigationItem associated with a BackForwardListItem is nil on a back/forward navigation, leading to a null pointer crash. If the associated item is nil, the code path is now the same as a non-back/forwarad navigation. Fixed: 1121950 Change-Id: Ic4b66af2dc9aa368ff046d66095cf090591eed57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379724 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
-
