GitLab

SHERIFFS: This could make some benchmarks run faster on continuous bots
          because the devices gets cooled down. The benchmark touched by
          this change is _not_ monitored, but the benchmarks running
          _after_ this one may see a change. This is expected.

Traces from experiment [1] showed that waiting for battery to cool down
to 32C happens every 7 runs adds adds a couple of minutes of waiting and
does not remove the upwards trend on metrics entirely. During those cool
runs the noise was significantly lower than on bots, using the same
hardware (N5X). Trying if this value makes bots bappier.

Cooling down seems unnecessary on N5 and on Go devices, but it would be
good to keep an eye on them anyway and see later how to properly make
this device-dependent in the future, if there is need.

[1] NOT_FOR_COMMIT: Sleep before/after pagecache flush
    https://chromium-review.googlesource.com/c/chromium/src/+/1210643

Bug: 881384
Change-Id: I304437b4231503d7a5d461ee00190bdb8ee5f5cd
Reviewed-on: https://chromium-review.googlesource.com/1217035
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#590039}

https://chromium.googlesource.com/angle/angle.git/+log/480edb8c1d7d..8e9d23405644


git log 480edb8c1d7d..8e9d23405644 --date=short --no-merges --format='%ad %ae %s'
2018-09-10 jmadill@chromium.org Vulkan: Fix FragCoord scaling when a viewport is applied.


Created with:
  gclient setdep -r src/third_party/angle@8e9d23405644

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: Iad2c871b824c18e59c1cc34321fea0ba80dbf392
Reviewed-on: https://chromium-review.googlesource.com/1216867Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590038}

Bug: 874471
Change-Id: I536285a49e60006fb6ed6f5cde97ca97df8eb108
Reviewed-on: https://chromium-review.googlesource.com/1208725Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590037}

Mechanical build change. Will TBR after review.

TBR=agrieve@chromium.org

Bug: 877957
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester
Change-Id: If99deaf4070d7c327b2b8b253057aea3b7a80ca7
Reviewed-on: https://chromium-review.googlesource.com/1216853
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590036}

Bug: 854704
Change-Id: I04ac5dd52da8012189d338b2654d6b503ce7a3b1
Reviewed-on: https://chromium-review.googlesource.com/1214073Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590035}

Navid has been actively reviewing/contributing to input.

Bug: None
Change-Id: I0084071fc3dd21fb1ff8b1eeea1f43520c357046
Reviewed-on: https://chromium-review.googlesource.com/1217322Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590034}

Bug: 851163
Change-Id: Id6f2b0abc70fc70ae48ee398fbd5e8afadbeca6d
Reviewed-on: https://chromium-review.googlesource.com/1216848Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590033}

content languages.

Now Chrome reflects the user's preferred languages for content
to display in an SVG element during the conditional processing
(which are set in chrome://settings/languages).

The previous behavior was:
Chrome reflected the user interface language.

R=fs@opera.com, schenney@chromium.org

Bug: 490140
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I37971ed24294273c9100abc4b668b693bb496659
Reviewed-on: https://chromium-review.googlesource.com/1216343Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#590032}

It's possible for a server to advertise brotli encoding when it isn't normally
expected to. In these cases, we were previously triggering a DCHECK and
potentially adding a second Brotli Accept-Encoding. This has been changed so
that the Brotli Accept-Encoding is now only added when it is not already
present.

Bug: 879762
Change-Id: I5f9bb8eeec0cc03ee4953cd8fdf7fd7c15a92067
Reviewed-on: https://chromium-review.googlesource.com/1200386
Commit-Queue: Jered Gray <jegray@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590031}

https://chromium.googlesource.com/catapult.git/+log/0c8cc6141c62..77a15654a753


git log 0c8cc6141c62..77a15654a753 --date=short --no-merges --format='%ad %ae %s'
2018-09-10 simonhatch@chromium.org Dashboard - Make privileged and unprivileged access explicit
2018-09-10 jbudorick@chromium.org devil: remove references to chromium-side .gni.


Created with:
  gclient setdep -r src/third_party/catapult@77a15654a753

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:882504,chromium:881910
TBR=sullivan@chromium.org

Change-Id: I8dc56fda01b40bf75918241eb39845a1c2a28d3b
Reviewed-on: https://chromium-review.googlesource.com/1216866Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590030}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/6c8c214ab77e..4624f2fdcfda


git log 6c8c214ab77e..4624f2fdcfda --date=short --no-merges --format='%ad %ae %s'
2018-09-10 mikenichols@chromium.org cbuildbot: Drop all meowth builders and references.


Created with:
  gclient setdep -r src/third_party/chromite@4624f2fdcfda

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I9281f773abf080c266a8333766428638e4bee420
Reviewed-on: https://chromium-review.googlesource.com/1216863Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590029}

This change adds support for preconditions on URL,
ScriptPreconditionProto.domain and path_pattern.

Bug: 806868
Change-Id: I19d93b8083e67e7455a10e29535b082c2b642b2f
Reviewed-on: https://chromium-review.googlesource.com/1203374
Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590028}

CastActivityManager manages the lifetime of routes and corresponding
Cast sessions. This patch implements the minimum amount of message
handling necessary to launch a Cast session via CreateRoute() (to be
hooked up to CastMediaRouteProvider in next patch).

Bug: 809249
Change-Id: Ib6058a01d62113f8de1748cd2d9ca3dadabe8e49
Reviewed-on: https://chromium-review.googlesource.com/1159357
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590027}

Using wpt-import in Chromium e26b06fa.
With Chromium commits locally applied on WPT:
d7762551 "Consistently use single quotes in Background Fetch WPTs."


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24509

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa@intel.com

No-Export: true
Change-Id: Ib845efb830f9537910d6ec4818f2a200c1e21373
Reviewed-on: https://chromium-review.googlesource.com/1216849
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590026}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a68660d0bb5d..d91f0adca280


git log a68660d0bb5d..d91f0adca280 --date=short --no-merges --format='%ad %ae %s'
2018-09-10 nodir@google.com Reland "[bot_update] Stop using repository properties"
2018-09-10 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@d91f0adca280

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:877161,chromium:694348
TBR=agable@chromium.org

Change-Id: I06098b00b5b0e4dfa95e238d33730d8926ea4de7
Reviewed-on: https://chromium-review.googlesource.com/1216888Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590025}

Context: http://shortn/_Yfz0RFm2Gt

Bug: It's a feature
Change-Id: I22985dbdef6d47ef2e83f697b1d9ea8bb68b1e17
Reviewed-on: https://chromium-review.googlesource.com/1208524Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590024}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/75c1bf28431e..2c2fee797908


git log 75c1bf28431e..2c2fee797908 --date=short --no-merges --format='%ad %ae %s'
2018-09-10 jaebaek@google.com Validator: check OpTypeBool inside Blocks (#1405)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@2c2fee797908

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I92f9a757912589818116be4f9bc4c26d91d6b806
Reviewed-on: https://chromium-review.googlesource.com/1216887Reviewed-by: spirv-chromium-autoroll <spirv-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: spirv-chromium-autoroll <spirv-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590023}

Adds filter files for  chrome_public_test_apk and
webview_instrumentation_test_apk as well.

Bug: 880915
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I05e4fd7cf7234b0c8c2be824421765f9406d5c14
Reviewed-on: https://chromium-review.googlesource.com/1208442
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590022}

Bug: 864705
Change-Id: I2b929b8655092520b755693c92ee34990d5e1dec
Reviewed-on: https://chromium-review.googlesource.com/1184152
Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590021}

Since OS X type sniffs to determine if a file is executable, we should
type sniff within a ZIP to identify DMGs with no file extension as
executable files.

Change-Id: I8e5e19205d46e60be8cccb3e259fcb705c1ca1f3
Bug: 866021
Reviewed-on: https://chromium-review.googlesource.com/1152183Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Nathan Parker <nparker@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590020}

https://skia.googlesource.com/skia.git/+log/10494e34e453..a2bc1ca21bbc


git log 10494e34e453..a2bc1ca21bbc --date=short --no-merges --format='%ad %ae %s'
2018-09-10 herb@google.com Simplify plots to always be 512x512 and simplify GrDrawOpAtlasConfig


Created with:
  gclient setdep -r src/third_party/skia@a2bc1ca21bbc

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=caryclark@chromium.org

Change-Id: I255f56b2e832a299e89fe30a4c054d841765d79b
Reviewed-on: https://chromium-review.googlesource.com/1216864Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590019}

Bug: 878541
Change-Id: I2501fa03d737154697346a76c1a7e20758debd7f
Reviewed-on: https://chromium-review.googlesource.com/1214075Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590018}

Give the info button a label read by screen readers when it is in focus:
"No Cast destinations found. Need help?"

Bug: 869600
Change-Id: I90af935d528f7aa128469b98ecb691f6d13228a0
Reviewed-on: https://chromium-review.googlesource.com/1214044Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590017}

Problems have been fixed by:
- https://webrtc-review.googlesource.com/97620
- https://webrtc-review.googlesource.com/97622

Bug: 824831
Change-Id: Ibe2f12f6d935c61a37cd253d22960a1ccba9f50a
Reviewed-on: https://chromium-review.googlesource.com/1203773Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590016}

The access patterns work fine with std::vector. There is no need to use
std::list. Make changed files free of lint and presubmit errors as well.

Change-Id: I7cbc19dde51c3c400a55263771b7322709b266bf
Reviewed-on: https://chromium-review.googlesource.com/1215051Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590015}

Replaced deprecated WaitUntilCondition with WaitUntilConditionOrTimeout
(the former method wait 2 days before DCHECKing).

Replaced DCHECK with EXPECT in test helper.

Bug: 784735
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I823b1671280ed4d52133009af75691c044c06f9e
Reviewed-on: https://chromium-review.googlesource.com/1212267Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590014}

These are used from chrome, so they need to sent over as properties.

BUG=none
TEST=none

Change-Id: Ia06f53ae461cff7b5c3f7af87ab4200839dd81bd
Reviewed-on: https://chromium-review.googlesource.com/1212707
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Jun Mukai <mukai@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590013}

This reverts commit 17500caa.

Reason for revert: Tests do not pass in official builds (https://crbug.com/882397)

Original change's description:
> [tabCapture] add a new getMediaStreamId method
>
> This cl is to add a new getMediaStreamId method to tabCapture API.
> The object is to offer easy access to the content of current tab for
> sharing/recording together with mic/cam by web apps, by returning an
> encrypted device id from extension to web app.
> See design doc: https://docs.google.com/document/d/1YWFmFJaN-bbAxh01JP5qczERW9vda62vLInO32WvCM8/edit?ts=5ac7ebd8
>
> TEST = autotests and a modified tab_capture example.
>
> Bug: 867533
> Change-Id: I03283b2c6ce5187224e45370f8ca9b27881d570a
> Reviewed-on: https://chromium-review.googlesource.com/1167659
> Commit-Queue: Weiyong Yao <braveyao@chromium.org>
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Reviewed-by: Yuri Wiitala <miu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#589762}

TBR=miu@chromium.org,rdevlin.cronin@chromium.org,braveyao@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 867533, 882397
Change-Id: Ie45fd4c08a07b1c1b45e36be144340a7e8d8c1df
Reviewed-on: https://chromium-review.googlesource.com/1216807
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Reviewed-by: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590012}

Currently, we have different behaviors for the "having a provisional
document loader" state versus the "having a queued navigation" state. In
the first case, we call FrameLoader::StopAllLoaders(), which cancels the
ongoing navigation as well as fetches on the current page (e.g.
XMLHttpRequest). In the second, we merely cancel the task to navigate,
but do NOT cancel fetches.

Indeed, it is recognized that the spec is currently unclear about
canceling queued navigation vs. direct navigation (see [1]). However, it
is worth noting that Chrome does not always follow the spec with this
distinction in the first place (through location.href, for example,
which queues a navigation task in Chrome but navigates directly in
spec).

Additionally, since even the current code cancels navigation in both
circumstances (the only disagreement being if peripheral fetches are
also canceled), we see no reason to have an inconsistency in this regard
(see [2]).

This CL now always calls FrameLoader::StopAllLoaders(), for both when we
have a provisional loader and when we have a queued navigation, thus
ridding ourselves of the inconsistency.

By doing so, we implement the "ideal 2" plan laid out in [2], which
recently became part of the HTML Standard in [3]. Tests for this new
behavior (which this CL fully passes) are in [4], which was imported
into our tree by the WPT Importer bot, whose expectations this CL now
change.

[1]: https://github.com/whatwg/html/issues/3447
[2]: https://github.com/whatwg/html/issues/3975
[3]: https://github.com/whatwg/html/pull/3999
[4]: https://github.com/web-platform-tests/wpt/pull/10789

Bug: 866274
Change-Id: I4e3ffac6b7c07bc8da812f6f210ab5d6933bdfd1
Reviewed-on: https://chromium-review.googlesource.com/1195837
Commit-Queue: Timothy Gu <timothygu@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590011}

Advances should be store as doubles, but the previous code
was using a float as a part of their computation.

Bug: 880169
Change-Id: I47fd70bf947c9b1e0fdb827eba69108bd938a72a
Reviewed-on: https://chromium-review.googlesource.com/1213516Reviewed-by: Stephen White <senorblanco@chromium.org>
Commit-Queue: David Quiroz Marin <davidqu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590010}

Bug: 811661
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I8a6e18dd431384efd1fef06fb93beab93343e8ef
Reviewed-on: https://chromium-review.googlesource.com/1216065Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590009}

The logic for parsing intrinsicSize attribute is shared among
HTML{Image,Video}Element and SVGImageElement. Moving it to
blink/core/html/media/media_element_parser_helpers to avoidredundant
code.

Bug: 874629
Change-Id: I20e1dc6b626eb86e8919c621b1c98401eaa9d201
Reviewed-on: https://chromium-review.googlesource.com/1217163Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Luna Lu <loonybear@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590008}

Method getCameraParameters() in file VideoCaptureCamera.java may return
null on failure. But several call sites assume that this never happens.
Crash reports show that it does happen.

This CL adds null checks and performs the appropriate failure action.

Bug: 879678
Change-Id: I978f45c04696c9a5b272932a945da033bafc6a77
Reviewed-on: https://chromium-review.googlesource.com/1214072Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590007}

Migrate all callers to the variant of Add() that takes std::unique_ptr.

Change-Id: I95249807357b8d8a867d509a6f45290964a40106
Reviewed-on: https://chromium-review.googlesource.com/1198569Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590006}

Bug: 832933
Change-Id: I337a74c898d55070933f73254a57d9f4ec17de94
Reviewed-on: https://chromium-review.googlesource.com/1208943Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590005}

ViewHostMsg_ResizeOrRepaint_ACK_Flags is no longer used. This removes it and
updates the comments on ViewMsg_SynchronizeVisualProperties to reflec the
current reality.

TBR=piman@chromium.org

Bug: 655231
Change-Id: I388ab96bd0bdf46a84f4e1e92bd8378fcc4dd834
Reviewed-on: https://chromium-review.googlesource.com/1216069
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590004}

1. Add query params pgcl=14 and sclient=cros-launcher for launcher queries to completion server.
2. Enable ZeroSuggestProvider to process empty queries from cros launcher.
3. The above changes are only enabled when zero state is enabled by flag, which by default is off.

Bug: 854242
Change-Id: I9ca99a668b74ab642ff1d020eb14565fb4af12ff
Reviewed-on: https://chromium-review.googlesource.com/1178971Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Jenny Zhang <jennyz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590003}

This reverts commit e966ecca.

Reason for revert: Broke two DumpAccessibilityEventsTest tests. See https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-xenial-rel/3172 

Original change's description:
> Emit state-changed:selected events for ATK on Aura Linux
> 
> * Add an event notifier in AXPlatformNodeAuraLinux for browser chrome.
> * Check to see if focus should follow selection. If it should, also
>   emit state-changed:focused events.
> * Ensure that the correct states (focusable and selectable) wind up
>   in the state set of elements where focus should follow selection.
> * Forward events from Blink content to AXPlatformNodeAuraLinux.
> * Create an event listener so that DumpAccessibilityEventsTest tests
>   can be run. Add expectations for tests for which events are now
>   emitted. At the present time, that is only focus and selected.
> 
> R=​dmazzoni@google.com
> 
> Bug: 866340
> Change-Id: I0d3334c39b064afc75ac5e051969fb43a79a0d8a
> Reviewed-on: https://chromium-review.googlesource.com/1163724
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Reviewed-by: David Tseng <dtseng@chromium.org>
> Commit-Queue: Joanmarie Diggs <joanmarie.diggs@gmail.com>
> Cr-Commit-Position: refs/heads/master@{#589951}

TBR=dmazzoni@chromium.org,dtseng@chromium.org,aboxhall@chromium.org,nektar@chromium.org,aleventhal@chromium.org,joanmarie.diggs@gmail.com

Change-Id: If194799a765415ba34229b5315c54584021078e2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 866340
Reviewed-on: https://chromium-review.googlesource.com/1217069Reviewed-by: Ojan Vafai <ojan@chromium.org>
Commit-Queue: Ojan Vafai <ojan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590002}

There is no logic change - this just move the code around for
optimization.

Android's VM does run-time verification for all the methods in a class
if any of the methods fails in AOT compilation time. Therefore,
splitting out failing methods into a separate class containing it there
help reduce the overall time taken in the run-time verification.

Landing all 6 CLs saves up the startup time for WebView
(5% when locally tested), at the expense of slightly increasing method
count and increasing apk size.

See crbug.com/838702 for more information about run-time verification
issue.

Bug: 868250
Change-Id: Ibcf67a14882414a6fecad254378c9015d30cf6da
Reviewed-on: https://chromium-review.googlesource.com/1175444Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590001}

TBR=rbpotter@chromium.org

Bug: 881685
Change-Id: I26cf5783d26d7dfadd53b1db890b09d14fb09a7e
Reviewed-on: https://chromium-review.googlesource.com/1216625
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590000}