- 22 Dec, 2020 40 commits
-
-
Lan Wei authored
webxr/xrSession_requestReferenceSpace_features.https.html is flaky on MAC bots Mac10.15 Tests. TBR=klausw@chromium.org Bug: 1161301 Change-Id: Ia885d0a6f10ea7c0b9262a9c8d4a886564bf1c66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601066Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#838994}
-
Lan Wei authored
SingleClientExtensionAppsSyncTest.StartWithSomePlatformApps is flaky on MAC bots Mac10.15 Tests. TBR= ericwilligers@chromium.org Bug: 1161309 Change-Id: I89aa193b5c1f7a90545776e53bb29bf0e258515a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601556 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
-
Lukasz Anforowicz authored
The tests just document the current behavior: 1. When ActiveTab permission is granted, then CORS is relaxed for fetches from the extension background page in regular profile. 2. There are some minor issues with how incognito profile is handled. Bug: 1153952 Change-Id: Ic0574b0c452e67a1a1bf38afa9c7ca45810b6f95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585673 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#838992}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/735ac97eb4dc..f202babd6a03 2020-12-22 johnstiles@google.com Update 'determinant' intrinsic to use $square(H)Mat. 2020-12-22 brianosman@google.com Remove 'flags' feature from particles 2020-12-22 michaelludwig@google.com Skip drawing line when half width underflows 2020-12-22 johnstiles@google.com Reland "Add support for range-based for loops to SkTHashSet/Map." 2020-12-22 mtklein@google.com force portable features 2020-12-22 michaelludwig@google.com Add halfWidth/halfHeight functions to SkRectPriv 2020-12-22 brianosman@google.com Simplify raincloud particle effect 2020-12-22 adlai@google.com Revert "Yank out old reduceOpsTaskSplitting code" 2020-12-22 johnstiles@google.com Elide return expression temp-var in vardecl-less blocks. 2020-12-22 brianosman@google.com SkSL: Hide non-square matrices from runtime effects If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1146701,chromium:1160579 Tbr: bungeman@google.com Change-Id: Ib0515ff22c6817b79ba84f55e06a9b1ae0e07e9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601448Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838991}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Ic74ddfbc2a56687bd8a1cb980de29a8a86faaa76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601328Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838990}
-
Theresa Wellington authored
BUG=1161272 TBR=meiliang@chromium.org Change-Id: Idc2d711ff2fe8e3e872912124b3b341824a2af7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601334 Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Theresa <twellington@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#838989}
-
Jared Saul authored
- Cardholder name fix flow prompts are still useful - The Butter histogram's usefulness is less clear, but as it still shows the ratio of whether users have opted-in to Butter via the Autofill suggestions dropdown, IMO it can stay a little while longer. Fixed: 1160783, 1160784 Change-Id: Ie2f1c6b3e82b0f1d11c4648fadbb4db7033f911b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600357Reviewed-by:
Chris Thompson <cthomp@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#838988}
-
Zhenyao Mo authored
The way we compute feature status and problems identified depends on a few global states for example, if gpu compositing is enabled at the time when we do the computing. So currently when we compute the info for hardware gpu, if we already fallback to SwiftShader, then the global states may have changed. This is not what we want. We want to capture a state of info where we were still using GPU acceleration. So the fix here is that we also cache these global states for the later computing. BUG=1154047 TEST=manual R=kbr@chromium.org Change-Id: Ie9abedafe28a36f635bbe8bff183ba52495f4404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594315 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#838987}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e1ecd9b7c6ef..0af374b04bee 2020-12-22 andoli@chromium.org [module.json extensions] Migrate profiler settings If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1134103 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I00b9861fb4a9a3e9fc01d9881da0ecdf3c89132b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601449Reviewed-by:
-
Jao-ke Chin-Lee authored
Previously, VA configuration was tied to VaapiDevice, meaning that the VAProfile was static per VaapiDevice. This also forced users of decode_test to specify the profile and codec, i.e. VP9Profile0, even though the decoder can deduce both. Separate out ScopedVAConfig and introduce SharedVAContext so that decoders can manage this configuration and the configuration can manage its own lifetime, allowing decode_test to be used on most streams that change profile or resolution mid-stream. BUG=chromium:1062407,b:175909299 TEST=./decode_test -video=resolution_change_500frames-vp9.ivf -out-prefix=res_change/frame on nautilus Change-Id: I32ad5dfab57851166ce31844f6609784fbcaf900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358989 Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#838985}
-
Dominic Mazzoni authored
I suspect that in the AddNodeChildren() loop, soemthing is causing the current object to be deleted. Bug: 1158511, 1158385 Change-Id: Ic393b5163616dc6a4995c43d22ac2e2d627656c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596792 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#838984}
-
James Cook authored
The UX plan for UI language is to use a single shared locale for OS and browser. See bug. Pass the locale on the command line because Lacros needs it very early in startup, before zygote fork. This CL doesn't include the changes to browser WebUI settings. We'll need to add a link-out to OS settings, similar to how Chrome OS browser settings work today. Bug: 1139618 Change-Id: I0202ed54d4c4a4956ecb31f04ecde670aea5595f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600316 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#838983}
-
Xinghui Lu authored
Remove kill switch flags to reduce code complexity. Flags removed: kRealTimeUrlLookupEnabledForEP kRealTimeUrlLookupEnabledForEPWithToken kRealTimeUrlLookupNonMainframeEnabledForEP Bug: 1086752 Change-Id: I691dd054e336396d1efd897106dd9e1f6237c7a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601320Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#838982}
-
Lei Shi authored
Currently, the backward sentence navigation takes the user to the closest sentence start before the current position. If the user wants to go to the previous sentence, they have to click the backward button at the beginning of the current sentence before TTS speaking any word. This poses interaction challenges as the user has to compete with the TTS engine. After consolidating with our UXD, we plan to change the behavior of backward sentence navigation. Clicking the backward button will always go to the previous sentence, regardless of the user's position at the current sentence. However, we need to keep the behavior of the pause and resume feature, which brings the user back to the start of the current sentence. This CL modifies navigateToNextSentenceWithinNodeGroup_ and navigateToNextSentence_ to allow callers to set whether we will skip the current sentence when navigating backward. AX-Relnotes: N/A. Bug: 1143823 Change-Id: I71d05f62f38cb3dbba31b6375f11b537b611b4a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597178 Commit-Queue: Lei Shi <leileilei@google.com> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#838981}
-
Rakina Zata Amni authored
Currently WebNavigationParams::FillStaticResponse will always result in a http_status_code of 0, even when the browser side got a HTTP response before committing (e.g. some cases with data URLs, error pages). This CL ensures that static responses will use the HTTP status code given by the browser side at commit time, by saving it in WebNavigationParams. Bug: 1155414, 1131832 Change-Id: I12658ccf0bec420168c5e14cb909da77fa104a92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599779 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#838980}
-
Rakina Zata Amni authored
The code that sets is_overriding_user_agent in RenderFrameImpl's MakeDidCommitProvisionalLoadParams depends only on the value from the CommitNavigationParams (and whether it's a main frame or not), meanwhile the currently-used NavigationRequest::IsOverridingUserAgent depends on |entry_overrides_ua_| as well, so the browser-calculated value might differ currently. Bug: 1155414 Change-Id: If285669f74b3fa7c3cd35389edcb414ea4a937ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596665Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#838979}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1608638224-48eff614fc6cab6a979b2689e49e6c5a36101630.profdata to chrome-win64-master-1608649072-95a4cf9b59101d6f6ea631f49afe5baa9a8b257b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I8687ecf52ba69180f7ebe8574dd78ac395f9e87f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598148Reviewed-by:
-
Christopher Cameron authored
ImageData::BufferBase()->Data() does not necessarily give the address of the start of the ImageData. For example, if the ImageData is created from a Uint8ClampedArray that is sub-allocated from another, say, Uint8Array, then this will not be the case (unless the creation offset is 0). The function ImageData::BufferBase() is used inappropriately in this way in many places. Remove the function. One of the heavier users of the function was ImageData::Crop, which, it turns out, isn't used. Delete it. Bug: 1158205 Change-Id: I4c06fec041083326222c5eb43f034a6d1cab7b3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600243Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#838977}
-
Andrew Grieve authored
This reverts commit f8dfd440. Reason for reland: Removed detectCleartextNetwork() Original change's description: > Revert "Android: Disable detectUntaggedSockets StrictMode check." > > This reverts commit 90c1d6e9. > > Reason for revert: Should not add detectCleartextNetwork() > > Original change's description: > > Android: Disable detectUntaggedSockets StrictMode check. > > > > We don't tag our sockets, and this caused logspam on start-up. > > > > Bug: 770792 > > Change-Id: I23cc6494a7a3e61bcb8be761c877bf4a0345f921 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600033 > > Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org> > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#838953} > > TBR=agrieve@chromium.org,pkotwicz@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > Change-Id: I2e90528bbd41c580e647cb17e65efa4900f900f5 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 770792 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600035 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#838962} Bug: 770792 Change-Id: I85b7f81303cdd9a29e647cbb8c8d5b7d034cddb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601516 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#838976}
-
Shrek Shao authored
Suppress conformance/textures/webgl_canvas/tex-2d-rgb-rgb-unsigned_byte.html on chromeos amd as RetryOnFailure TBR=kbr@chromium.org Bug: 1161258 Change-Id: I9f9bcd2084c37fe87f422878dca63ce5d2e82647 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601185Reviewed-by:
Shrek Shao <shrekshao@google.com> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#838975}
-
Mason Freed authored
There were some crashes caused by nested slots (e.g. <slot><slot>Content</slot></slot>) being removed from the tree. These crashes were triggered by [1], which removed Shadow DOM v0, but my theory is that due to the old V0 shadow root code, more calls were being made to SlotAssignment::RecalcAssignment(). Now that the V0 code is gone, it has exposed some missing code. Three issues are being fixed here: 1. In Node::CheckSlotChange(), while removing the inner nested slot, the parent_slot will have already been removed from the tree, so we only need to call DidSlotChange if not. This used to be a DCHECK. 2. In TreeOrderedMap::Get(), while removing a key that previously had more than one element, we may walk the tree and find that none of the pre-existing elements are present. I.e. we're in a RemoveScope. In this case, the key should be removed from the map. 3. In SlotAssignment::DidRemoveSlotInternal(), given #2 above, we can just early-out if the slot isn't present in the map. I added a test for the crash conditions (variations on removing nested named and unnamed slots), plus I added a test for the TreeOrderedMap class, since there was none previously. The last test in the set documents the new Get() behavior. I also tried to improve some of the comments along the way. Finally, this CL rolls back a mitigation [2] previously landed for this crash. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2586019 [2] https://chromium-review.googlesource.com/c/chromium/src/+/2595967 Bug: 1159328, 1159727 Change-Id: I47fbf33b2313b9ae2efe229443af6e8c9a1920a9 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597040 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:Yu Han <yuzhehan@chromium.org> Reviewed-by:
Joey Arhar <jarhar@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#838974}
-
Sophie Chang authored
I'll do the hints manager in the next CL if this approach works Bug: 1151087 Change-Id: I81d204599983e10bda733c9ac63f577f1e506656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601321Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#838973}
-
David Bokan authored
The passed callback is stored and called from OnInstallPromptDone which is itself a callback passed to ShowDialog. ShowDialog is already a OnceCallback so this method will only be called once (and we convert the call to BindOnce). Further, we already clear the |callback_| member when calling it (using std::move) so this can be safely made a OnceCallback. Bug: 1152268 Change-Id: Ib1ad3d92c239403a35ad9d226304b6f92dfc80d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601061Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#838972}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6a13cf40462d..2752abe7e2cd 2020-12-22 jbudorick@chromium.org devil: clean up imports for py2 tests ahead of py3 work. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1007101 Tbr: wenbinzhang@google.com Change-Id: I4d8e1bfee67093aadb836294e668fbaa2ab0abf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601440Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4d368301b8df..d91ce64b5aed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC caseq@google.com,lanwei@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: caseq@google.com,lanwei@google.com Change-Id: Ia439e6d776817ea09dee2fad41cc0a51ffc498aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601193Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838970}
-
Sven Zheng authored
This reverts commit a23b68c3. Reason for revert: Tests are fixed in crbug.com/1159404 Original change's description: > Disabled flaky SingleClientTypedUrlsSyncTest tests on Android > > This CL disabled the following tests on Android. > > * SingleClientTypedUrlsSyncTest.DeleteNonTyped > * SingleClientTypedUrlsSyncTest.TwoVisits > * SingleClientTypedUrlsSyncTest.DeleteTyped > * SingleClientTypedUrlsSyncTest.Sanity > > TBR=mastiz@chromium.org > > Bug: 1159479 > Change-Id: I49a93df85f6e48bbd661e77e41c467787c4e8b68 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596119 > Reviewed-by: Salvador Guerrero <salg@google.com> > Commit-Queue: Salvador Guerrero <salg@google.com> > Cr-Commit-Position: refs/heads/master@{#837747} TBR=mastiz@chromium.org,salg@google.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I24bcdac6b58843f9ca7a1909f9720152d43845be No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1159479 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597744Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Salvador Guerrero <salg@google.com> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#838969}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1e69d7961394..c463a784c340 2020-12-22 henrikg@webrtc.org Clarification of RtpPacket constructor in comment. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I17084af412a7ec5ef4cb865b923dc2cc114640dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601192Reviewed-by:
-
Zach Trudo authored
This reverts commit 7447e48c. Reason for revert: Causing issues server side. Original change's description: > Switch all IDs from unsigned to signed. > > The purpose is to eliminate incompatibilities with server side > code - written in Java - which caused overflows when treating > large unsigned numbers as negative signed ones. > > Change in Proto will be reproduced in server code too, but there > is no need to synchronize the two - uint and int in proto are compatible, > as long as the numbers are not outside the limits. > > Bug: b:174509632 > Change-Id: I996177f2580949a00a35ddc9e83ca18fdecc87e3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596820 > Reviewed-by: Zach Trudo <zatrudo@google.com> > Commit-Queue: Leonid Baraz <lbaraz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#838140} TBR=chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,zatrudo@google.com,lbaraz@chromium.org Bug: b:174509632 Change-Id: I1b890e34566d46ada8dda5b4d2acfeff0979dd6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599925Reviewed-by:
Zach Trudo <zatrudo@google.com> Commit-Queue: Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#838967}
-
Charlie Hu authored
This CL adds feature SyncXHR to document policy. It will be controlled by both document policy and feature policy during the migration period, i.e. If either policy disabled the feature, the feature will be disabled. Bug: 1146505 Change-Id: I2a2d776da13be9f659bc0369fb5a19a94f5c18ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523440Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
-
Jinsuk Kim authored
This CL fixes wrong theme color bugs still left in the toolbar. 1) There are situations when WebContents theme color hasn't changed but we still need to check if the overall top UI theme can change. For this, TabThemeColorHelper invokes TabObserver#onDidChangeThemeColor with either the current tab theme or the one from WebContents accordingly. 2) When in tab switcher, location bar model's |mPrimaryColor| should be updated when going back and forth between normal/incognito tab model. Added a new line doing this, since this is not automatically done the after the toolbar theme refactoring. Bug: 1157417, 1157433 Change-Id: Ib648d4ce10f6589eae54742631fc083edf0119f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599678 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
-
Carlos IL authored
Bug: 1158636 Change-Id: I8d654ac690fbdc2da3212cacdc3e36018e5dede5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590665 Commit-Queue: Carlos IL <carlosil@chromium.org> Commit-Queue: Chris Thompson <cthomp@chromium.org> Auto-Submit: Carlos IL <carlosil@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#838964}
-
Nasko Oskov authored
When RenderFrameHostImpl::OnCrossDocumentCommitProcessed was removed in r830950, the only assignment of the navigation_request_ member was removed as well. Given that it is never written, it is unused and can be safely removed. Bug: 1020175 Change-Id: Ie8d0afce182a35df7269915936db90da8adf4b68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601179 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
-
Andrew Grieve authored
This reverts commit 90c1d6e9. Reason for revert: Should not add detectCleartextNetwork() Original change's description: > Android: Disable detectUntaggedSockets StrictMode check. > > We don't tag our sockets, and this caused logspam on start-up. > > Bug: 770792 > Change-Id: I23cc6494a7a3e61bcb8be761c877bf4a0345f921 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600033 > Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#838953} TBR=agrieve@chromium.org,pkotwicz@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I2e90528bbd41c580e647cb17e65efa4900f900f5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 770792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600035Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#838962}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/37a217750180..e1ecd9b7c6ef 2020-12-22 janscheffler@chromium.org [Recorder] Clean up state after recording is done If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I928089812b312859114891d40cbf886a72d90572 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601182Reviewed-by:
-
Jacques Newman authored
If the render-side tree was initialized with a root with an id != 1, the first update won't match the tree created on the browser process by CreateEmptyDocument. In this case, the update won't be able to set the right node_id_to_clear to the correct root. This will cause the "new" tree to be treated as an update, and a reparent. To mitigate this, if node_id_to_clear was set and the update's root_id doesn't match the old_root_id, we can assume that the update meant to replace the root. Bug: 1131848 Change-Id: Ia84c5a893a7b4846e0d81255455244171ec1d3d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598724 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#838960}
-
Thomas Lukaszewicz authored
This CL sets the kTabSearch flag to be enabled by default on ChromeOS and leaves it disabled by default on the remaining desktop platforms (Linux, Mac, Windows). This is part of the required launch cleanup for the ChromeOS Tab Search experiment. Launch config CL: https://critique-ng.corp.google.com/cl/347894919 Bug: 1116182 Change-Id: I4de20453851b095a62c099a02c8dcebfb26ca00c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596029 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Yuheng Huang <yuhengh@chromium.org> Reviewed-by:
Roman Arora <romanarora@chromium.org> Cr-Commit-Position: refs/heads/master@{#838959}
-
Nohemi Fernandez authored
Currently, Chrome strictly enforces that the fake Sync server is running to call |ClearSyncServerData|. This may be causing intermittent issues in EarlGrey tests if service startup is in an inconsistent state. This patch makes the test suites more flexible by allowing the inconsistent state, and changing a failure for a no-op case. Bug: 11530874 Change-Id: I4f20dc0c282d1b09ad54d43ab32dd10f54a2d42c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600741 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#838958}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e38beddbbf8a..735ac97eb4dc 2020-12-22 fmalita@chromium.org [svg] Relative postioning support for text 2020-12-22 brianosman@google.com SkSL: Add $squareMat and $squareHMat 2020-12-22 johnstiles@google.com Add SkSpan support to the Skia LLDB visualizer. 2020-12-22 brianosman@google.com Add .rte -> .skvm unit test framework 2020-12-22 johnstiles@google.com Test that the inliner uses a temp var for return statements. 2020-12-22 brianosman@google.com Add SkVM output to skslc 2020-12-22 johnstiles@google.com Revert "Add support for range-based for loops to SkTHashSet/Map." 2020-12-22 johnstiles@google.com Add support for range-based for loops to SkTHashSet/Map. 2020-12-22 johnstiles@google.com Fix for fuzzer-discovered crash with swizzles. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bungeman@google.com Change-Id: I7704689abb6138a0c9f9b287858d610df6522d78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599611Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Id29841fec1482659271c9693c334960dc0a5f583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601222Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838956}
-
danakj authored
Tests that want to talk to the RenderFrame via the mojom interfaces to it should create that RenderFrame by doing a navigation before attempting to use the mojo connections. Otherwise they are talking to nothing, and it will be a null mojo connection once the mojo binding is set up with the CreateFrame or CreateRenderView IPCs. R=nasko@chromium.org TBR=jam Bug: 1158869 Change-Id: I349d21222ae4a6aa79795ba2dc409cb39fc0d2e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600378 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
