- 07 Apr, 2020 40 commits
-
-
Johann authored
BUG=webm:1679 Change-Id: Ia2d3c1a81af2542dbe6c790405cc6d0492391005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136987Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#756928}
-
My Nguyen authored
This is the first change in Personal Info Suggestion Window. When "show_tab" is true, the suggestion window created remains the same with the screenshot view: http://screen/MO1QeHfRwi4 When "show_tab" is set to false, the suggestion window created is in this screenshot view: https://screen/moLGCKOrvwr Bug: 1068044 Change-Id: I5397d6a1175fcfca86cb7dc3321d231560b10e19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136008 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Jing Wang <jiwan@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#756927}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: Ia1031c5480e0b3aaf02371befc796db1166a6d2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136012 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#756926}
-
Michael Sun authored
Some Bluetooth audio peripheral devices negotiate with the Chrome OS Bluetooth stack (BlueZ) for a larger Advanced Audio Distribution Profile (A2DP) stream packet size, a.k.a. AVDTP MTU. In a noisy RF environment, the Bluetooth device may fail to consume such large packet and result in packet fragmentation, which caused audio to stutter. BluetoothFixA2dpPacketSize feature flag tells Chrome OS audio server (CRAS) to override the packet size with a prefixed smaller value. Bug=b:142499564 Test=Manual enable BluetoothFixA2dpPacketSize in chrome://flags and verified audio packet BlueZ send to the reconnected Bluetooth headset, using btmon, became smaller. Change-Id: Id68a05be87c858cce416af284f1321770028402f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134500 Commit-Queue: Michael Sun <michaelfsun@google.com> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#756925}
-
Matt Falkenhagen authored
* ServiceWorker.FetchEvent.Subresource.Status * ServiceWorker.FetchEvent.MainResource.Status Bug: 1059800, 1059801 Change-Id: Ibd6ade3eae1b8cc7b3c1a1c07e5b72f210fdb21f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137163Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#756924}
-
Sinan Sahin authored
Bug: 1066257 Change-Id: I6212cc2c8364307a17aa0e53e3276eae7143d494 Binary-Size: Re-added material lib component. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134769 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#756923}
-
dpapad authored
When the flag is on, chrome://settings serves the Polymer3 version. Bug: 1026426 Change-Id: I376abc974caa2772cd70ff4ce6f4d4b28b5b1796 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137912 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#756922}
-
Abigail Klein authored
This reflects the change in plan to launch on all platforms. While doing this change, also move the captions settings on non-Mac and non-ChromeOS up above the More Features link. They should be at the same place in the settings as the non-ChromeOS settings. The More Features link should be the last option listed. Bug: 1055150 Change-Id: Ib0d65756b0c23f7523e91a4e9508cf8d4ffa03e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138155Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#756921}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/afbf2aa737c8..76f4fff613b5 git log afbf2aa737c8..76f4fff613b5 --date=short --first-parent --format='%ad %ae %s' 2020-04-07 westont@google.com Begin using Debian10 for tryjobs. Created with: gclient setdep -r src/third_party/skia@76f4fff613b5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: csmartdalton@google.com Change-Id: Iaf57948ef5f7aa4dba98029bf788db47ee9c882f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138695Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756920}
-
Wan-Teh Chang authored
Change kUndefinedFormat to kWebPAnimationFormat in a comment in ImageDecoder: :GetCompressionFormat(). Change-Id: I369054831fa6913930c7a8e50f1d70abd0f4f538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135902Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#756919}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/eda150cb2208..dfe9760a8e2d git log eda150cb2208..dfe9760a8e2d --date=short --first-parent --format='%ad %ae %s' 2020-04-06 dberris@chromium.org Fix import order to unblock push-on-green 2020-04-06 jbudorick@chromium.org pinpoint: revert inadvertent copyright change. Created with: gclient setdep -r src/third_party/catapult@dfe9760a8e2d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1068133 Tbr: nuskos@google.com Change-Id: Ia78de2b386c2542cc82e0ecdd850b9e36c4bac5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138693Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I1a645d693e951060bfc10cb7b895a8b7564b7c84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138698Reviewed-by:
-
Zain Afzal authored
The media app now has a bucket for feedback (see b/139318556 for more detail). This CL adds this bucket id to our invocation of the feedback dialog so our reports end up in the right place. Bug: 996088, b/139318556 Change-Id: I30c9cd828c5f71e36f5d45b0603ea8e46b6fcabb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137170Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Zain Afzal <zafzal@google.com> Cr-Commit-Position: refs/heads/master@{#756916}
-
Azeem Arshad authored
This CL adds additional logging to help understand what is triggering pairing state change in https://crbug.com/1060823 Bug: 1060823 Change-Id: I774167ae0e420bae11c0c58a9caf8937f0c93961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138562 Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#756915}
-
Xinghui Lu authored
Fix: Initialize the resource_type field with a default value kMainFrame. We'd like to know for each safe browsing blocking page created, what is the resource type that triggers the page. This information can help us decide the priority of resource types that should be checked in real time. Metrics added in this CL: SafeBrowsing.BlockingPage.ResourceType Bug: 1065137 Change-Id: I38f2b0b4787fb1c04ee515e08856d4ab8b00aa07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133115Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#756914}
-
Wan-Teh Chang authored
This is suggested by a Tricium Robot Comment from ClangTidy/modernize-loop-convert. Change-Id: I352bc58595382cb5d419c0df52941455e4745d0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136883Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#756913}
-
Yusuke Sato authored
The job creates /home/root/<hash>/android-data which crosvm will export to the guest via virtio-fs in the near future. This CL depends on platform2's chromium:2134800. BUG=b:151683475 TEST=try, arc.Boot.vm Change-Id: I1c337740ee726e3acc689fb4a1c112ee9a1e7bbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135055 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Long Cheng <lgcheng@google.com> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#756912}
-
Tsuyoshi Horo authored
This member variable was added by crrev.com/c/659318, to show warning for legacy Symantec roots from content::SSLManager. But crrev.com/c/693315 stopped using it. So this member variable is not used anymore. Bug: 763984 Change-Id: Iffeb27972171bb0d231be6efd07c31cfcf2d951c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137199Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#756911}
-
Kevin Babbitt authored
https://crrev.com/c/2135054 resolved a threading issue by moving print operations to the browser UI thread on Windows. Prior to that CL, the work being done was marked as blocking at the task level, rather than at the individual API level. The blocking annotations were removed in order to not have a ScopedBlockingCall immediately preceded by a ScopedAllowBlocking. This CL reintroduces the ScopedBlockingCall marks at the point where potentially blocking APIs are actually called. Existing callers also gain ScopedAllowBlocking as needed. Bug: 1067666 Change-Id: Ifb96feb96f0e6ba38ac06f09f0aa9640c547dba2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128690 Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#756910}
-
Michael Sun authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/2e5dab7c2630..9c6bf7207bfe $ git log 2e5dab7c2..9c6bf7207 --date=short --no-merges --format='%ad %ae %s' 2020-04-02 michaelfsun system_api: Add CRAS dbus API SetFixA2dpPacketSize Created with: roll-dep src/third_party/cros_system_api BUG=b:142499564 Change-Id: I68616471a128382564eda7534f9d0da738629521 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138113Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6f985973. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 2688e49a "De-flake two lazyload WPT tests." 7e979350 "Handle k-rate AudioParam inputs for PannerNode" b32714e6 "Reland: [shapedetection] Upstream TextDetection tests to WPT" c64eec2c "Implement MediaCapabilities: HDR decoding query" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I7c30c4535d633c728eb2348319c001b7f329c9b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138571Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756908}
-
Xinghui Lu authored
It is possible that users are not signed in but enabled enhanced protection. In this case, the access token is not available. Add a signin status check in this CL. Bug: 1041912 Change-Id: I1095a3d26784c6ba4bcf8a768bbed064ae39088e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138164 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#756907}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/be73a51136ac..f526d777e0b3 git log be73a51136ac..f526d777e0b3 --date=short --first-parent --format='%ad %ae %s' 2020-04-06 kainino@chromium.org Fix is_asan build (at least on Mac) 2020-04-06 bryan.bernhart@intel.com Reland "D3D12: Stage BindGroups on CPU descriptor heaps." 2020-04-06 rafael.cintron@microsoft.com Make RefCounted derived objects have private destructors 2020-04-06 cwallez@chromium.org Make Toggles overriden automatically and device creation Created with: gclient setdep -r src/third_party/dawn@f526d777e0b3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I8a9fb528f5531e377f9997bbb2142f0be8b67afd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138460Reviewed-by:
-
Orin Jaworski authored
This CL adds three new focus states to the popup model line state enum for use when suggestion button row is enabled. The forward and back step logic is updated with care to respect the experimental flag, and to prepare for new keyword logic handling. Bug: 1046523 Change-Id: I336f74f3d1ed971ee23c245df196192ef29d0940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135381Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#756905}
-
Yusuke Sato authored
This will allow ArcVmClientAdapter to start arc-create-data job to create /home/root/<hash>/android-data directory. BUG=b:151683475 TEST=try Change-Id: I0769ca10a5b48dec0f6cb2c4891503a5915ab058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135308Reviewed-by:
-
Joel Hockey authored
Terminal will not be on by default in M83. This CL is created to be merged in M83 beta, then TerminalSystemApp will be re-enabled on trunk in a followup CL. Bug: 1016190 Change-Id: Idee2ccc19402a69fa33ef21506e48c6761f18a3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138651Reviewed-by:
Jason Lin <lxj@google.com> Commit-Queue: Jason Lin <lxj@google.com> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#756903}
-
Andrew Grieve authored
I've several times had to recreate this structure. Thinking it makes sense to have it checked in. Change-Id: Id8e6ec0cfff38725c1c9da925f9bb783fb79a8f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137814Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#756902}
-
My Nguyen authored
https://crrev.com/c/2123311 changes the route for os languages setting page. This results in the need to: - Update the hard-coded strings in os_languages_section.html - Update the constants in system_tray_client and virtual_keyboard_delegate (found this by doing a codesearch). Note: chrome::kOsLanguagesDetailsSubPage is equivalent to the old chrome::kLanguagesSubPage Bug: 1068045 Change-Id: Ifee9e8ab7fb392787c1a9450a56d5b30b5eff127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137105Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#756901}
-
Bruce Dawson authored
SystemSessionAnalyzerTest.ValidateEvents fails flakily (failing most of the time) and it is impossible to tell which failure point is being hit. This change adds recording of extended error codes so that the failure will be visible so that we can make progress on this old bug. Some multi-part logical-or statements were broken up to ensure that the precise failure is found. GetEventInfo was moved to be a member function so that it has access to the error-setting function. Test command line is: components_unittests --gtest_filter=SystemSessionAnalyzerTest.ValidateEvents Bug: 968440 Change-Id: Ie7b76d6e6607725819244ef22b3a2b1f8ab34d38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136061Reviewed-by:
Jesse McKenna <jessemckenna@google.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8ab0d8cc..1f44ca7b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I19109d4e71bd58c59c02fd65e3c60f86762c34cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137874Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756899}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/89624cdfd788..06c0b50c29e0 git log 89624cdfd788..06c0b50c29e0 --date=short --first-parent --format='%ad %ae %s' 2020-04-06 vadimsh@chromium.org [lucicfg] Update v1.12.7 -> v1.13.0. Created with: gclient setdep -r src/third_party/depot_tools@06c0b50c29e0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Iaa1d2093c2b1deded9ca0006ac5f8e4de3b49dc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138468Reviewed-by:
-
Ryo Hashimoto authored
Use the message pipe attached to the invitation for ArcBridgeHost. This requires Android version which includes the corresponding change. BUG=b:151063537 TEST=Launch Play Store Change-Id: Id326252882bdd3f845f4a126a91a8f5fb2b77b5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094840Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#756897}
-
Rakina Zata Amni authored
A reland of parts of crrev.com/c/2041711 that got reverted in crrev.com/c/2127998 for the M83 branch, with the crash cause fixed (we previously did not return after the DidFinishTask call when ShouldFindMatches returns false). Bug: 1065371 Change-Id: Iac0fa13dd953fd51169cdbcbc0f4c34afb824a2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129368Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#756896}
-
Devlin Cronin authored
Command::Type specified a type for a command of page action, browser action, or "named" (i.e., any other command). This was posing a bit of a problem for the generic "action" key, because we'd need to add a new entry for it. As it turns out, Command::Type was never really used. It was only ever passed as a hint of which command to look up for a helper function, and we can use ActionInfo::Type directly there. Remove Command::Type completely. Bug: 893373 Change-Id: Ie26b7ffbc50c541700947988bcef94dc5f4083a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132809Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#756895}
-
Mason Freed authored
The CSSWG resolved [1] that "@import doesn't parse in constructable stylesheets and as a result throw syntax errors". We have a comment [2] requesting clarification, but the working assumption is: - calling replace() with text that includes @import will ignore the @import, and issue a console warning. - calling replaceSync() with text that includes @import will ignore the @import, and issue a console warning. - calling insertRule() on a constructed stylesheet with an @import rule will throw a SyntaxError. (no change here) *Prior* to this CL, the behavior of Chromium was: - calling replace() with text that includes @import would work. The returned Promise would resolve once all @imports were loaded. Any invalid @import rules would cause a NetworkError to be thrown. - calling replaceSync() with text that includes @import would throw a "NotAllowed" exception. - calling insertRule() on a constructed stylesheet with an @import rule will throw a SyntaxError. The Intent to Remove for this change is at [3]. [1] https://github.com/WICG/construct-stylesheets/issues/119#issuecomment-597733392 [2] https://github.com/WICG/construct-stylesheets/issues/119#issuecomment-600410089 [3] https://groups.google.com/a/chromium.org/g/blink-dev/c/RKG8oxp22RY/m/fdFnG1rGCgAJ Bug: 1055943 Change-Id: I0a8444289b137b4c2880be5231696bb526331107 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106996Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#756894}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d2de511efbdc..84323449dfaf git log d2de511efbdc..84323449dfaf --date=short --first-parent --format='%ad %ae %s' 2020-04-06 cnorthrop@google.com Capture/Replay: Track buffer contents by ID Created with: gclient setdep -r src/third_party/angle@84323449dfaf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: I49fb36ed98c8135994c66d5e3666b9aa192f1b72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138459Reviewed-by:
-
Rahul Arakeri authored
This CL simplifies the implementation of thumb drag for the Compositor threaded scrollbar scrolling feature. It also aligns the implementation to main thread thumb drag more than before. The aim of doing this is to reduce the possibility of bugs arising from the disparity between main and cc manipulated scrollbars. Bug: 1067518 Change-Id: I501c68e9993afcb4b1e097d0aafce7670d8bec4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136412 Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#756892}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/430f07b53422..91aecef3b39e git log 430f07b53422..91aecef3b39e --date=short --first-parent --format='%ad %ae %s' 2020-04-06 lalitm@google.com tp: add support for annotations Created with: gclient setdep -r src/third_party/perfetto@91aecef3b39e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ib4fcd4420b17cd24a754cd4664108f36abaccd41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138456Reviewed-by:
-
Peter Kotwicz authored
BUG=None Change-Id: I94099f04a98d4aac77764a78367e5db8b085cad2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138251Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#756890}
-
Akihiro Ota authored
The new command is [Search + P + L], which prints the current node's detected and author-provided languages to the console. This is strictly a debugging feature and only works when one (or more) of the following flags have been enabled: enable-experimental-accessibility-chromevox-language-switching enable-experimental-accessibility-language-detection enable-experimental-accessibility-language-detection-dynamic Bug: 1067739 Relnotes: N/A Change-Id: Id645fde857dd5d0b7b9aa5cf6242d6aaec903e55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109255 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#756889}
-
