GitLab

There were some missing newlines in the macro expansions for shared
documentation that made the action and action_foreach docs look
wrong.

clang-format also changed the way the macros are defined.

Change-Id: Id32ac1f625db86008268c1692eed970f0ae59c10
Reviewed-on: https://chromium-review.googlesource.com/1057890Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558749}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/babd098f3684..cbf0204555fe

$ git log babd098f3..cbf020455 --date=short --no-merges --format='%ad %ae %s'
2018-05-14 vbendeb do not try collecting issues information for an empty issues list

Created with:
  roll-dep src/third_party/depot_tools


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I64e27eede61a4d0560b483a1493ac277466422be
Reviewed-on: https://chromium-review.googlesource.com/1059578Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#558748}

Posting headers gotten on IO thread from NetworkDelegate off to UI thread
isn't guaranteed to work (since the IO thread is still using them!); so
instead extract out the bits that are actually needed immediately.

Bug: 840235
Change-Id: I067378ab1fee252af6c6cbd7562b75776477e979
Reviewed-on: https://chromium-review.googlesource.com/1057875Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558747}

Factor the Extension object out of
PermissionsData::CanExecuteScriptEverywhere(), instead passing in the
extension ID and location directly.

Also clean up a few duplicate calls to the method by locally caching the
result.

Bug: 842270

Change-Id: I434a3df769d32d9f63e2e77bc393d634dcdba4da
Reviewed-on: https://chromium-review.googlesource.com/1056036Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558746}

This CL makes sure that a VR version ImeAdapter is used when WebContent
for current tab swapped.


Bug: 841607
Change-Id: I751221684c17101ae80c4ebeff5684f5f5b7f8c5
Reviewed-on: https://chromium-review.googlesource.com/1057827Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
Commit-Queue: Biao She <bshe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558745}

A few users have invalid Window entries in TabRestoreServiceHelper when
deleting history. These entries are created when individual tabs are
restored from a closed window. This is only possible on Mac.
It is fixed by adjusting the selected_tab_index after a deletion.

Bug: 840508
Change-Id: I429d117df8cf06ee1613220112901590f129d529
Reviewed-on: https://chromium-review.googlesource.com/1049976Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558744}

This CL splits data saver holdback experiment in two different
groups: One for Web API consumers (e.g., save-data client hint,
and the navigator.connection.saveData() JavaScript API).
The second for consumption within the media stack.

The goal is to separately measure the data saved by (i) not preloading
and not autoplaying muted videos when save data is enabled; and, (ii)
data saved by web developers when they consume the save-data client
hint and/or navigator.connection.saveData() JavaScript API.

Change-Id: I0953cc6ab34f268e587c58b13ba6be20acb2593e
Bug: 698367,840441
Reviewed-on: https://chromium-review.googlesource.com/1046145Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558743}

Otherwise the JS wrappers will get lost.

Bug: chromium:830910
Change-Id: I7f746698b6ce05d9b2e3ce26f778a2e08d0c3cd6
Reviewed-on: https://chromium-review.googlesource.com/1059251
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558742}

Test: none
Bug: 828646
Change-Id: I9af10d321e03a9a3e59c40696e314456dacf290e
Reviewed-on: https://chromium-review.googlesource.com/1058682Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558741}

https://chromium.googlesource.com/angle/angle.git/+log/a00ef3144f70..966cd5076be3

$ git log a00ef3144..966cd5076 --date=short --no-merges --format='%ad %ae %s'
2018-05-15 geofflang Add more dEQP EGL expectations for Linux and Android.
2018-05-14 jmadill dEQP: Clean up some style in gTest source.

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: If656e623b460c834e940a7faf1032bc082c87fd9
Reviewed-on: https://chromium-review.googlesource.com/1059701Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#558740}

TBR=dmazzoni@chromium.org

Change-Id: I966d459dbc98f3bb0fe607b20572f66fe006f069
Reviewed-on: https://chromium-review.googlesource.com/1059941Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558739}

This reverts commit 983e4035.

Reason for revert: Trying again

Original change's description:
> Revert "[Perf] Enable system_health.* for histogram uploads"
> 
> This reverts commit f3f89493.
> 
> Reason for revert: Causing failures
> 
> Original change's description:
> > [Perf] Enable system_health.* for histogram uploads
> > 
> > This CL switches all system_health benchmarks to the histogram pipeline.
> > 
> > Bug: 744736
> > Change-Id: Icb97397ec417d27220e489651cc51591757d8c9e
> > Reviewed-on: https://chromium-review.googlesource.com/1048626
> > Reviewed-by: Emily Hanley <eyaich@chromium.org>
> > Commit-Queue: Ethan Kuefner <eakuefner@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#556842}
> 
> TBR=eakuefner@chromium.org,eyaich@chromium.org
> 
> Change-Id: I53f1788cc1f488b207a0718e8fbe14e2899af5b7
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 744736
> Reviewed-on: https://chromium-review.googlesource.com/1052407
> Reviewed-by: Ethan Kuefner <eakuefner@chromium.org>
> Commit-Queue: Ethan Kuefner <eakuefner@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#557211}

TBR=eakuefner@chromium.org,eyaich@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 744736
Change-Id: Ie8e2f4a2e1c2d4b3e84a9edce1ca88e4d7005f39
Reviewed-on: https://chromium-review.googlesource.com/1059733
Commit-Queue: Simon Hatch <simonhatch@chromium.org>
Reviewed-by: Simon Hatch <simonhatch@chromium.org>
Reviewed-by: Emily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558738}

It seems to pass on some Android bots, but not ours, so adding
it to the list *shrug*.

Bug: 840756
Change-Id: I153923ee91fba5df8762fdff8682a58041cf40c7
Reviewed-on: https://chromium-review.googlesource.com/1059622
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558737}

Bug: 838777
Change-Id: I8a1a049ade70cadfebabc8115471732f15432ac1
Reviewed-on: https://chromium-review.googlesource.com/1058372Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558736}

Two relevant patches are ag/4013275 and crosreview.com/1043496.

Bug: b:78593133
Test: Pass test CtsVerifier test on MTU exchange
Change-Id: I527dee3d105d3b3db744f550c2c7003789d65c57
CQ-DEPEND: CL:1050621
Reviewed-on: https://chromium-review.googlesource.com/1058328Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Commit-Queue: Qiyu Hu <qiyuh@google.com>
Cr-Commit-Position: refs/heads/master@{#558735}

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7f84ea07d53d29dc967645d12b3c27654e19fc8c
Reviewed-on: https://chromium-review.googlesource.com/1058388Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Adam Parker <amp@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558734}

Change the order to match the enum.xml.

Bug: 843141
Change-Id: Ib8bf9be16aaf7a5d1f9369762bd966fb8c06b5a8
Reviewed-on: https://chromium-review.googlesource.com/1059579
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558733}

There are flaky failures in ash::tray::MultiProfileMediaTrayView
likely due to a race between media capture code's idea of the
number of users vs. ash::SessionController's idea of the number of
users.

Disable the test while that gets sorted out.

TBR=xiyuan@chromium.org

Tbr: xiyuan@chromium.org
Bug: 842442
Test: browser_tests
Change-Id: I8f80484190830aafb45ce4683be12206708d3ecc
Reviewed-on: https://chromium-review.googlesource.com/1059704Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558732}

Create one touch hud views::Widget per display and open/close new
widgets as displays are added and removed.

Bug: 840380
Test: run chrome --show-taps-app and add/remove displays
Change-Id: I21c87b35ec520bd1501f0cbf02c073d030c7ff64
Reviewed-on: https://chromium-review.googlesource.com/1058591
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558731}

Bug: b/78193960
Test: covered by added tests
Change-Id: I69d5651a76af3f49a39669f9ef10c2dae3718e7d
Reviewed-on: https://chromium-review.googlesource.com/1058594Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Qiang Xu <warx@google.com>
Cr-Commit-Position: refs/heads/master@{#558730}

Download Manager UI does not support multiple downloads per Tab.
When the second download is requested DM can either prompt the user to
replace the download or just silently drop the request.

Before this CL download request would be silently dropped if the user
typed the url into omnibox. This CL changes the login to prompt the
user.

It is still the desired behavior to silently drop the request if the
download was initiated by the web page to prevent page from spamming
the user.

Bug: 837602
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I262d3ef98c52995229567823e79df355761bff65
Reviewed-on: https://chromium-review.googlesource.com/1033332
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558729}

Remove custom Serialization and Deserialization logic used in background
fetch.

Bug: 826257
Change-Id: If9e13dd6bbffa0a521209f7cabbe5ed0f3d08991
Reviewed-on: https://chromium-review.googlesource.com/1059658
Commit-Queue: Peter Beverloo <peter@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558728}

This reverts commit 835ae72c.

Reason for revert: Fix for MSAN issue landed here: https://skia.googlesource.com/skia/+/3d945e840c1955b5756fdeb696599c2818ed95fc

Original change's description:
> Revert "Use Skia's new simplified read/write pixels code paths"
> 
> This reverts commit 6d0559c0.
> 
> Reason for revert: Breaks ImageBitmapTest.AvoidGPUReadback on MSAN, e.g. https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.memory%2FLinux_MSan_Tests%2F9783%2F%2B%2Frecipes%2Fsteps%2Fwebkit_unit_tests%2F0%2Flogs%2FImageBitmapTest.AvoidGPUReadback%2F0
> 
> Original change's description:
> > Use Skia's new simplified read/write pixels code paths
> > 
> > Bug: 826819
> > Change-Id: Ia6eaca75fe43f9d9ec94f8fe644a44e8e7436675
> > Reviewed-on: https://chromium-review.googlesource.com/1054520
> > Reviewed-by: Robert Phillips <robertphillips@google.com>
> > Commit-Queue: Brian Salomon <bsalomon@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#557943}
> 
> TBR=bsalomon@chromium.org,robertphillips@google.com
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 826819
> Change-Id: Ia4dca1186fbb79569672fbf5cdabd9657c702762
> Reviewed-on: https://chromium-review.googlesource.com/1056847
> Reviewed-by: Timothy Loh <timloh@chromium.org>
> Commit-Queue: Timothy Loh <timloh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#558215}

TBR=bsalomon@chromium.org,timloh@chromium.org,robertphillips@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 826819
Change-Id: Idd8043535288d6f224531f90d381f85ca548c01d
Reviewed-on: https://chromium-review.googlesource.com/1059793Reviewed-by: Brian Salomon <bsalomon@chromium.org>
Commit-Queue: Brian Salomon <bsalomon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558727}

This CL refactors RenderViewContextMenuMac by moving
the logic to show a Cocoa menu into a
RenderViewContextMenuMacCocoa class.

To show the context menu using Views, this CL adds a
RenderViewContextMenuMacViews.

Bug: 837230
Change-Id: Id07f9e758278638c6fc47003de1055d9357ed1fa
Reviewed-on: https://chromium-review.googlesource.com/1056468Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558726}

Bug: 773295
Change-Id: I6be6adefab29b5d4e67013f45ba5ffe4e058dbdc
Reviewed-on: https://chromium-review.googlesource.com/1030062Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558725}

Bug: 823365
Change-Id: I7fbf12296ec51b3685833f26371fe5f9467a6591
Reviewed-on: https://chromium-review.googlesource.com/1058128Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558724}

See spec: https://wicg.github.io/keyboard-map/

Bug: 832811
Change-Id: I74bf2ecd3581bd4e68a1c17390b24101a79721ab
Reviewed-on: https://chromium-review.googlesource.com/1053398Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Gary Kacmarcik <garykac@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558723}

https://webrtc.googlesource.com/src.git/+log/5702736f7e46..59216ec4a415

$ git log 5702736f7..59216ec4a --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=chromium:None,chromium:None


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I6549be88db6a4034fee7a2ae8ac98357efd7813b
Reviewed-on: https://chromium-review.googlesource.com/1059575
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#558722}

We should discard the incoming capture GpuMemoryBuffer and return when
VideoCaptureDeviceClient::OnIncomingCapturedGfxBuffer fails to reserve
the I420 output buffer. Otherwise we'll end up crashing.

BUG=b:79729317
R=emircan

Change-Id: I616d97ca618ad9cc40abdf9d1a8f06ce568cfbb0
Reviewed-on: https://chromium-review.googlesource.com/1059495Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Ricky Liang <jcliang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558721}

When the browser detects that a renderer is hung (via not ack'ing input
events), it displays a hung-page dialog. On Windows, if the user chooses
to kill the page, the browser will generate a minidump for the hung
process for post-mortem analysis. This CL implements the same on Mac.

Bug: 842806
Change-Id: I2d50fc7395fc6c4fe080a5cc05bfcee8f4f36e79
Reviewed-on: https://chromium-review.googlesource.com/1058009
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558720}

https://skia.googlesource.com/skia.git/+log/6bbd386a0e4b..81f60ecd9cc0

$ git log 6bbd386a0..81f60ecd9 --date=short --no-merges --format='%ad %ae %s'
2018-05-15 reed Allow slides/gms to extend the UI

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=herb@chromium.org

Change-Id: Ie5bab037e74f8928abc8fc0ec0f04254d231b3d6
Reviewed-on: https://chromium-review.googlesource.com/1059577Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#558719}

Bug: N/A
Change-Id: I8874134483806c01323042ad7593125e1e2c7b35
Reviewed-on: https://chromium-review.googlesource.com/1059782Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558718}

GetOpacity() didn't handle the active tab case where the close button should be always visible.



Bug: 822061
Bug: 842218
Change-Id: Id91e5ab402fb1e9e249f8cb60d1a26a3c9a3c46e
Reviewed-on: https://chromium-review.googlesource.com/1055648
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558717}

It's already excluded manually from almost all Android bots.

For some reason this also enables it on some chromium.clang and
chromium.memory bots. If it turns out to fail there, we can add
exclusions.

Bug: 842698, 840756, 843134
Change-Id: I6c119b5272163a41676f1a0f8b7a2081631c9564
Reviewed-on: https://chromium-review.googlesource.com/1059780Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558716}

Right now we use only single-line textboxes. It is difficult for admins
to make a large JSON dict fit into a single line textbox, so this change
displays a multiline textbox instead in the following situations:
- Only in Chrome OS policies - not for Windows. (We could also turn this
  on for windows once we have checked for side effects.)
- Whenever an policy of type 'dict' or 'external' is expected.
- Whenever a policy of type 'string' that is actually JSON is expected.

As of this change, we will also still show a single-line textbox along
with the multiline, so that admins can still see the old single-line
value, since the two types of textboxes aren't completely compatible.
Eventually, we can stop showing the single-line textboxes.
See the attached bug for more information.

Also: Show more example values in help-text -
- for dicts and external, not just for list + string.

Bug: 829328
Change-Id: Ic095d0e54dd324437dcfe89ef60c34a31f8ae16b
Reviewed-on: https://chromium-review.googlesource.com/1007082
Commit-Queue: A Olsen <olsen@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558715}

R=tandrii@chromium.org

Bug: 731967
Change-Id: Ie0d2a57cfb398032a9278324791dba6167b74aa0
Reviewed-on: https://chromium-review.googlesource.com/1058531Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Erik Staab <estaab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558714}

Instead of emitting write barriers for single writes in HashTable,
conservatively emit a barrier for the backing store during rehashing.

This moves us in the tradeoff space:
- Removes 40KiB of binary bloat
- Avoids emitting barriers when re-inserting single elements which
  improves throughput for the case where incremental marking is off
- Emits a single conservative barrier at the end of RehashTo. This
  potentially means that we (re-)scan more objects when incremental
  marking is on

Bug: chromium:839514, chromium:757440
Change-Id: Ib5495c9e2210836424d7b26f2138d852f8dafec7
Reviewed-on: https://chromium-review.googlesource.com/1055400
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558713}

This updates SkFontConfigInterface::SetGlobal calls to use the smart
pointer version. This removes the awkward trailing ->unref and will
allow Skia to remove the old non-smart version of this method.

Change-Id: Icf67a1976820f5f0f07243ab1539e90e18db2ef4
Reviewed-on: https://chromium-review.googlesource.com/1058019Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558712}

Simplify logic around |enable_canvas_2d_image_chromium| in runtime_features.cc.

Bug: 839970
Change-Id: I7371c6ce22e7a2c73013b75c8545e5fc91b983c7
Reviewed-on: https://chromium-review.googlesource.com/1057388Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558711}

This makes VSCode a lot faster in the DevTools codebase by only
autocompleting over the files depended on by this file.

Change-Id: I94421969291a135a46673c02722e77f0d6709426
Reviewed-on: https://chromium-review.googlesource.com/1058680
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Erik Luo <luoe@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558710}