GitLab

This reverts commit ee5f0d37.

Reason for revert: This CL has no effect because the |thread_checker_| in the class is a no-op implementation in Release builds. Will re-land a version of this CL that fixes that, in a single CL, so it's easy to revert.

Original change's description:
> history service: Turn DCHECKs to CHECKs to try to diagnose crash bug.
> 
> Bug: 1009795
> Change-Id: Ib33c1242228e674442f21dea8a56ef456d84b886
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899231
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Matt Falkenhagen <falken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#712948}

TBR=falken@chromium.org,sky@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1009795
Change-Id: I24a8c7ff548d43c315528e85556967800336aea9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918120Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715466}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5bd6ca022650..935c827ec93c

git log 5bd6ca022650..935c827ec93c --date=short --no-merges --format='%ad %ae %s'
2019-11-14 chshrest@microsoft.com Revert: Make add button in color-picker accessible https://chromium-review.googlesource.com/c/chromium/src/+/1688337

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@935c827ec93c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC v8-waterfall-sheriff@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=v8-waterfall-sheriff@grotations.appspotmail.com

Bug: chromium:1023748
Change-Id: I0675cfc734615754aedc461b9467779e2f4af2ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918040Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#715465}

https://chromium.googlesource.com/angle/angle.git/+log/968df09eed92..1a01b4b322a5

git log 968df09eed92..1a01b4b322a5 --date=short --no-merges --format='%ad %ae %s'
2019-11-14 tobine@google.com Refactor end2end test macros

Created with:
  gclient setdep -r src/third_party/angle@1a01b4b322a5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cnorthrop@google.com

Bug: None
Change-Id: I6a6a07036594a482d6bb53f016da1dbfc8a34949
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918039Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#715464}

This change moves the metric for fetch coverage at commit into the
navigation data so that the page loads recorded match across all
of the client hint coverage metrics.

This also adds an additional metric of whether a hint was available
on the client or had been covered by a fetch at commit.

Bug: 1022625
Change-Id: I6fcacba86df635d0f0ab22ae543031a9ca0d3d81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915293Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Michael Crouse <mcrouse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715463}

This patch rectifies a duplicate definition error, since certain proto
definitions are defined both in components/cast_channel and in
third_party/openscreen, by moving all consumers of these protos to using
the Open Screen version.

Change-Id: I0347424c019b1489eb09b3822fd4a97d062e0e0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902718Reviewed-by: Luke Halliwell (slow) <halliwell@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Jordan Bayles <jophba@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715462}

The rebaseline was incomplete in the previous
https://chromium-review.googlesource.com/c/chromium/src/+/1915461.

TBR=steimel@chromium.org

Bug: 377696
Change-Id: I2455acef8a0c628744bd7360de51f77511278da9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918442Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715461}

This change postpones calling RenderFrameObserver::DidCommitProvisionalLoad
until after RenderFrameImpl is done updating its own state and performing its
own work. This avoids running arbitrary other code from within the middle of
those state updates.

In particular, this ensures that observers that wish to execute script from
within DidCommitProvisionalLoad do not do so until after we have setup the new
BrowserInterfaceBrokerProxy and finished other critical steps associated with
committing a navigation in the renderer. See ChromeRenderFrameObserver, which
uses this signal to inject scripts for WebUI pages. (We might decide that is
non-ideal for other reasons and design a better injection point, but that can
be done in a subsequent CL.)

Injected script can call into local storage, which is a synchronous operation.
That operation requires a synchronous check of the ContentSettingsManager to
determine if the script can access local storage. That interface is acquired
through the BrowserInterfaceBrokerProxy. Hence, there is opportunity for a
dead-lock if the BrowserInterfaceBrokerProxy has not already been set-up
(meaning, not already had its receiver handle sent to the browser process) by
the time script tries to access local storage. In practice, this has not been
an issue, but in another change I am making, the ContentSettingsManager will
be lazily acquired causing this potential dead-lock to more easily occur and
to definitely occur in some of our WebUI browser tests.

As part of this change, the page_load_metrics/ module had to be revised to not
flush existing metrics from DidCommitProvisionalLoad. Doing so could attribute
metrics from the previous page to the newly committed page including especially
the navigation_start time which is used as a key to identify page loads by the
metrics system. That in turn could cause subsequent metrics on the newly loaded
page to simply be dropped. Fortunately, tests helped root out this issue. The
PageTimingMetricsSender grows a SendLatest method that can be used to trigger
when metrics should be flushed rather than having that be a side-effect of the
destructor running.

SendLatest is now called from ReadyToCommitNavigation to send any accumulated
metrics for the previous page before the new load commits. This may result in
dropping some metrics data between the calls to ReadyToCommitNavigation and
DidCommitProvisionalLoad, but that is probably reasonable. Also, a comment
from dgozman indicates that ReadyToCommitNavigation is something we want to
get rid of but MetricsRenderFrameObserver already implements this method so
whatever substitute there will be in the future for this method can hopefully
account for both this new use case as well as the existing use case.

Files w/ implementations potentially impacted:
  chrome/renderer/chrome_render_frame_observer.cc
  chrome/renderer/content_settings_agent_impl.cc
  chrome/renderer/content_settings_agent_impl_browsertest.cc
  chrome/renderer/net/net_error_helper.cc
  chrome/renderer/safe_browsing/phishing_classifier_delegate.cc
  chrome/renderer/searchbox/searchbox.cc
  components/autofill/content/renderer/autofill_agent.cc
  components/autofill/content/renderer/form_tracker.cc
  components/autofill/content/renderer/password_autofill_agent.cc
  components/autofill/content/renderer/password_generation_agent.cc
  components/data_reduction_proxy/content/renderer/content_previews_render_frame_observer.cc
  components/page_load_metrics/renderer/metrics_render_frame_observer.cc
  content/renderer/accessibility/render_accessibility_impl.cc
  content/renderer/media/audio/audio_renderer_sink_cache_impl.cc
  content/renderer/pepper/plugin_power_saver_helper.cc
  extensions/renderer/extension_frame_helper.cc

Change-Id: Ia6627b2db06ea51e769ed6c8889e37e554fcc1d1
Bug: 1023519
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898769Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Darin Fisher <darin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715460}

This is a reland of f5946a0a

It was reverted as 9948fd01

Fix: just exclude ASAN/LSAN bots from running this test.
Context: I was able to produce flaky failures locally, and I
believe these bots are simply timing out because there's now
30 realbox tests. Because these tests are basically just
Javascript, there's really no benefit from running them under
leak/address sanitizer bots (generally only helpful to C++).

Original change's description:
> Local NTP, Realbox: fix navigation to chrome:// URLs
>
> Partially borrowed from https://crrev.com/c/1836021 by Archana Simha <archanasihma@chromium.org>
>
> Bug: 1020025
> Change-Id: I7de22a41d872ec624f25d1633782d27448988c58
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893824
> Commit-Queue: David Bokan <bokan@chromium.org>
> Reviewed-by: David Bokan <bokan@chromium.org>
> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
> Reviewed-by: Nasko Oskov <nasko@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Auto-Submit: Dan Beam <dbeam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#715106}

TBR=dcheng@chromium.org,bokan@chromium.org,nasko@chromium.org,mahmadi@chromium.org

Bug: 1020025
Change-Id: I666c372b76a058702c29b88eff765c2cd90c0bb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917982Reviewed-by: Dan Beam <dbeam@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715459}

As discussed in crrev.com/c/1911067, this is where the majority of the
code for structured metrics will live, along with some initialization
in /chrome/browser/metrics.

This CL just creates the directory and adds me as OWNER. Same as for
crrev.com/c/1911067, let's revisit ownership once this is implemented.

Bug: 1016655
Change-Id: I498758fa1b7875e0bd782c32d3cc60cee7a94d33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915640Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Tony Yeoman <tby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715458}

This patch also removes some obsolete logic from the days of Chrome
Home like whether the android version of the toolbar is showing.

Bug: 986310, 1002277
Change-Id: Ib939d02cdf783cc0fde30dbf7089171ae52c92a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909930Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715457}

Extends the expiration of Finch experiment flags for:
 - OverlayNewLayout to 81
 - ContextualSearchDefinitions to 82
 - ContextualSearchLongpress to 83
 - Ephemeral Tab experiments to 82
 - Simplified Server to 79 (since it's at 100%).

Change-Id: Ia4a496183addae6a6e80d296415e138a1f3e02f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918141
Auto-Submit: Donn Denman <donnd@chromium.org>
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715456}

Allow users to set the compression level while using CompressHelper().
There is a 2x to 4x compression speed difference between levels [1..9], where
it is possible to trade speed for better compression ratios
(and vice-versa).

It is up the user to experiment with the data to find the sweet spot
for its application (default compression level is 6).

Bug: 833361
Change-Id: Ia710cc7322707ace242133b283610eaa48def31f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912791
Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Auto-Submit: Sam Maier <smaier@chromium.org>
Reviewed-by: Adenilson Cavalcanti <cavalcantii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715455}

This creates a directory for the structured metrics XML file. The next
CLs will add codegen and presubmits similar to UKM's here too. Some
notes:

Naming:
  In an attempt to use short names, I've called this 'smc' in code,
  for 'structured metrics collection'. I'm not wedded to this though,
  let me know if simply 'structured_metrics' is better.

Ownership:
  For ease of development I've added myself as OWNER, but I don't
  think this is needed in perpetuity. It might be wise to hand off
  ownership at some point, let's talk more about that later on.

  My intention was for the whole Metrics team to inherit ownership of
  this directory. I'm not sure how the owners system works though, so
  let me know if that's not the case.

Types:
  There was some discussion of allowing three kinds of metrics:
  unhashed, globally hashed, and per-user hashed. That will require
  some changes to the XML file format, but I don't think that's
  finalized yet, so let's tackle it in a follow-up CL.

Bug: 1016655
Change-Id: I064bca4ca7bd7b818451f6b49eb400fab43496d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911067Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Tony Yeoman <tby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715454}

Some Chromebooks come with an ambient sensor light.
Powerd will send signals containing an ambient temperature in Kelvin.

This CL lands a few functions to convert the temperature coming from
powerd to a RGB scale factors.
Those factors will be used to adjust the screen color temperature.

The table to convert the readings to overall temperature and the
functions to map the overall temperature to RGB scale factors
were provided by the Create team.

Bug: b/138731765, 1021193
Test: ash_unittests --gtest_filter="*AmbientTemp*"
Change-Id: Iffed207d0ceca89328c42a0e9bedbfc20a434ac3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902290Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715453}

Since we now consider scores of 0 in tail culling, move
DemoteOnDeviceSearchSuggestions() to before tail culling, in case a
suggestion score gets cleared. If done after, this could remove most
of the remaining suggestions.

Note that this doesn't move deduplication. This is because, if done
prior to tail culling, it could theoretically remove a suggestion
that would have played a significant role in culling.

Bug: 1023821
Change-Id: I50dbe38066209a900dc63e5ee0b95cb3540ffec6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913632
Commit-Queue: Kevin Bailey <krb@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715452}

Update code where NULL or 0 is assigned to a scoped_refptr to reset it. Just
call reset() instead. If operator=(std::nullptr_t) is added these assignments
become ambiguous.

This CL was uploaded by git cl split.

R=wfh@chromium.org

Bug: 1024981
Change-Id: I9ae14c4aa2ad7d048a2d8ed3c0e33081128b2d48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918202
Auto-Submit: kylechar <kylechar@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715451}

This CL switches all the Chromium dependencies from being direct
dependencies on WebRTC targets to a WebRTC component (which lives
at //third_party/webrtc_overrides:webrtc_component).

From now on, Chromium should never directly depend on WebRTC in
order to avoid issues explained at [1] (this will be guarded
by checkdeps and GN visibility (see [2])) but should only depend
on the WebRTC component.

This should solve a broad range of problems caused by WebRTC being
linked in different shared libraries when is_component_build=true
(from globals and singletons causing hard to debug issues, to ODR
violations and binary size increase).

[1] - https://chromium.googlesource.com/chromium/src.git/+/master/docs/component_build.md#dependencies-between-targets
[2] - https://webrtc-review.googlesource.com/c/src/+/154344

TBR: dcheng@chromium.org
Bug: webrtc:9419
Change-Id: Ice56827db1753f51592165a90c1094b468c8e188
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874722
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715450}

Proactive suggestions controller logic in ash currently lives in
AssistantUiController. It makes use of some of the same logic as
standalone Assistant UI (e.g. for calculating usable work area).

Proactive suggestions logic has grown and will grow again soon as we
update triggering conditions (to only show UI as a result of user
scrolling activity). This is going to further muddy the
AssistantUiController if added to the code in its current state.

To address this, I've refactored Proactive suggestions controller logic
into AssistantProactiveSuggestionsController, a sub-controller owned by
the AssistantSuggestionsController. It is fairly self-contained and
copies some logic (e.g. for calculating usable work area) from the
AssistantUiController. This will make it much easier to clean up the
AssistantUiController when standalone UI is deprecated.

Bug: b:142144655
Change-Id: I10f4892ae166618a588505d75634c6c18a7cc6d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906935Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#715449}

This change removes all dependencies on and mentions of DialogClientView
from //cbui/views/autofill.

The only wrinkle is that a couple of tests use GetViewByID() on the
DialogClientView; these have been changed to use it on the RootView
instead.

Bug: 1011446
Change-Id: I8276c676d085c611cd27ababddad9fd60d849191
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917542
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715448}

For this dialog, the LegalMessageLines parameter comes from
SaveCardBubbleControllerImpl, which has two code paths to show this
dialog. Both those code paths look roughly like this:

  if (already_showing_dialog)
    return;
  legal_message_lines_ = ...;
  ShowDialog();

and there are no other places that change legal_message_lines_, so it is
effectively const across the lifetime of the dialog. Unfortunately,
because the same SaveCardBubbleControllerImpl is used for several
different concrete bubble subclasses, changing the behavior of
ShowDialog to simply pass the message lines in as a constructor
parameter (which would make it obvious that it's const for the lifetime
of the dialog) is not easy to do.

Bug: 1011446
Change-Id: I9b0584de8495b97f685b2973134e9d04873c317e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917520Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715447}

These are all straightforward.

Bug: 1011446
Change-Id: I3895608ba6b671dac81a36928f58bc4b72955b3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917540Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715446}

No change to logic. This re-enables a test which was marked as flaky.
This passed 1000 local runs, so it appears it's no longer flaky.

Bug: 984705
Test: run_webview_instrumentation_test_apk --num_retries=0 \
Test: --break-on-failure --repeat=1000 \
Test: -f SafeBrowsingTest#testSafeBrowsingProceedThroughInterstitialForSubresource
Change-Id: I48bb6dbbeb1fa96f62d43da74de2a34255f2b3d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911150
Auto-Submit: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Reviewed-by: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715445}

This fixes navigator.language, navigator.languages and the
ACCEPT-LANGUAGE http header.

For now, the locale is only read at startup. In the future, WebLayer
should listen for changes to the system locale and allow the client
to specify an active locale that is not the system's default.

      LANGUAGE environment variable for Linux WebLayer shell.
      Navigate to test pages in linked bug, or google.com

Test: set Android system language to non English, or use
Bug: 1022616
Change-Id: Id680f38953c1a81fc155ef0d3434fa8fc0d59b6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906635Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715444}

To make debugging failures a bit easier.

Also add reasons for LifetimeAssert and JNI wrapper classes.

Bug: 1020936
Change-Id: Iccd027fa73baa6f7a56d97b6ac32e1d7283f48b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904752
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Auto-Submit: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715443}

In this CL, metrics are added for the following hotseat gestures:
(1) The gesture to enter overview mode from home page.
(2) The gesture to show/hide the in-app shelf.
(3) Fling up the in-app shelf to show the home page.
Test cases for the metrics are also created.

Bug: 1018921
Change-Id: I86bdee0e28f28d222a03d1b474fb47b74e5b23f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906301Reviewed-by: Nik Bhagat <nikunjb@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715442}

BUG=966644

Change-Id: I2d418578e03e42f4f6e638f1c21afb71ba202cce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917750Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715441}

Change-Id: Ic82967272461d063fdf4edc2b65028a59802397b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917979
Commit-Queue: Frank Liberato <liberato@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715440}

https://swiftshader.googlesource.com/SwiftShader.git/+log/90df527f91c3..168bb0dc14f2

git log 90df527f91c3..168bb0dc14f2 --date=short --no-merges --format='%ad %ae %s'
2019-11-14 swiftshader.regress@gmail.com Regres: Update test lists @ b2407dd7
2019-11-14 capn@google.com Rasterize 'Bresenham' line segments as parallelograms

Created with:
  gclient setdep -r src/third_party/swiftshader@168bb0dc14f2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=swiftshader-team+autoroll@google.com

Bug: chromium:b/80135519
Change-Id: I19c4d2ae2f9b1399b42732ebdbbdc0e8664da4ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917804Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#715439}

We're still running an experiment and are about to add a few more
experiment arms, so extend the metrics for the next few releases at
least, as the events only happen once or twice an update.

Bug: 1016400
Change-Id: Ibae4038579882ad4c96509f32aea70ffb464f228
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917752Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Auto-Submit: David Trainor <dtrainor@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715438}

Bug: 1024623
Change-Id: Ie5ca2f8259598130d9d046520c568c562d13f28c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915185Reviewed-by: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Matthew Mourgos <mmourgos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715437}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/d347d8903a96..bacb84b99758

git log d347d8903a96..bacb84b99758 --date=short --no-merges --format='%ad %ae %s'
2019-11-14 chrome-bot@chromium.org Update config settings by config-updater.
2019-11-14 dhanyaganesh@chromium.org chromite: Kill cros uprevchrome

Created with:
  gclient setdep -r src/third_party/chromite@bacb84b99758

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I5b3400ab9520c229d56635e912fe9efae58879f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917801Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#715436}

Previously, there were 3 navigation stops on the Google Accounts row
item in the People section with stops for 1) User name, 2) User email
address, and 3) The subpage button, marked as described by the user name.
With this change, there is now just one stop on the subpage button that
is described by both the user name and user email. "Google Accounts,
button, bailey test baileyberrotest2@gmail.com"

Bug: 1012565
Change-Id: I2c44a308dca82e0e0669be8e9a04f97385fc85c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915188
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Auto-Submit: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715435}

Skipping manual test in test harness causing tests
to fail due to timeout in some windows builders.

Win7 Tests (dbg)(1) constantly fails on MANUAL_ tests:
https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29

other builders fail or flake less frequently:

Win10 Tests x64
Win7 (32) Tests
win10_chromium_x64_rel_ng

https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyfQsSBUZsYWtlInJjaHJvbWl1bUBicm93c2VyX3Rlc3RzQFdlYlJ0Y0ludGVybmFsc1BlcmZCcm93c2VyVGVzdC5NQU5VQUxfUnVuc09uZVdheUNhbGw2MFNlY3NBbmRMb2dzSW50ZXJuYWxNZXRyaWNzV2l0aE9wdXNEdHgM

Skipping these tests in launcher will resolve flakiness on these builder.

Bug: 1020591
Change-Id: Ie2ea8510ab31a3c56b783f0e8b9bded98c21d9bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909958
Commit-Queue: Ilia Samsonov <isamsonov@google.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715434}

For example cr-camera's videocam-shutter has a red fill enclosed by a
white stroke. In this case, the ripple should be white matching the
outer region of the icon. Currently, --cr-icon-button-color to white
for all cr-icon-buttons in cr-camera. There should be no change in
behavior due to this CL.

This CL is needed for a follow-up CL that removes
--cr-icon-button-color.

Bug: 1022752
Change-Id: Ib22042d8719aa8d4d54cea9c87ce1641e7f7994b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914515
Commit-Queue: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715433}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/eb53c26684a5..cc70a4f8a96a


Created with:
  gclient setdep -r src-internal@cc70a4f8a96a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:1021528
Change-Id: I7b4495c8e736001cd1216f3dc3712fc5c64c497f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917802Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#715432}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e6e5db55004d..3da78c4bb7dc

git log e6e5db55004d..3da78c4bb7dc --date=short --no-merges --format='%ad %ae %s'
2019-11-14 jbudorick@chromium.org Revert git cache diagnostic tracing.

Created with:
  gclient setdep -r src/third_party/depot_tools@3da78c4bb7dc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=agable@chromium.org

Bug: chromium:1019824
Change-Id: Ifbfd2c41c4d5a063303996df407419767663c644
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917803Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#715431}

Most output clients are expecting that |worker_cb_| will consume N
frames and that subsequently the clock advances by N frames. Not
calling the |worker_cb_| stalls these internal clocks.

There's still the issue that tasks are incredibly delayed in the
ScopedTaskEnvironment on macOS. I.e., playback will still be slower than
realtime, but it at least won't be 0.25x as we spend forever trying to
catch up before executing the callback.

BUG=1003761,1014646
R=miu

Change-Id: Iaa98d683ba77fa664f13da2436cb69bf834251ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898641
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715430}

crrev.com/c/1900130 renamed //aw/apk to //aw/nonembedded, and
crrev.com/i/2103749 removed the last //aw/apk dependencies. Now that the
latter CL has landed, we can delete //aw/apk.

Test: ninja -C out/aw
Bug: 934152
Change-Id: I1e5322adfda9813d296ca0f027a75463db18efc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913597Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715429}

Regain some coverage before we can fully deflake pixel differences.

Bug: 1023299, 983170
Change-Id: Ia3d42a732e213377d97a4aefe2cc7eb8c63a1062
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916300
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Mei Liang <meiliang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715428}

Use trichrome_chrome_bundle instead.

Removed:
- trichrome_chrome_apk_pak_assets
- trichrome_webview_for_bundle_apk
- trichrome_library_for_bundle_apk
- trichrome_chrome_apk

Downstream target removed here: https://crrev.com/i/2095508

Bug: 1021196
Change-Id: I4b6e249f393adf6bb49d845aff430172c8658268
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914604
Auto-Submit: Peter Wen <wnwen@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715427}