- 20 Sep, 2019 40 commits
-
-
Manu Cornet authored
Change-Id: Ifda5eb576f1b8e7d8b635b319a1d02a661744e8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815588Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#698524}
-
Eric Foo authored
See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: If1168a9566a042902410d902057a09faafc1bc8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808310 Auto-Submit: Eric Foo <efoo@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#698523}
-
Pavel Feldman authored
Change-Id: Iba19664d4e350826ce89b89788bc2e68a5ed1c84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815885Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#698522}
-
Brian Sheedy authored
Changes use of PrintResult to PerfResultReporter in viz_perftests and whitelists the tests for conversion to histograms before uploading to the perf dashboard. Bug: 923564 Change-Id: I078c3094ca44c41b7a33c205a22b8017c3068975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815341Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#698521}
-
arthursonzogni authored
A new android bot has been added. This add the failing tests to the filters. TBR=lowell@chromium.org Bug: None. Change-Id: I4dd4511e8b14cca6d5ae113801bc6f3319769fed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816553Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#698520}
-
Natalie Chouinard authored
Remove unused context parameter in HelpAndFeedback's getInstance method. Also fix presubmit errors in affected files. Change-Id: I74d7f3bccedbf29f516554ffc53b20374edd6565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814394Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#698519}
-
Robert Ogden authored
Simply removing these tests since this implementation was never launched. Bug: 1005295 Change-Id: Ia2799658867ad5a0be45f238f0def5b95800ef32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815883Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#698518}
-
Robbie Gibson authored
These two items didn't have button set on their accessibility traits. Bug: 979696 Change-Id: I117a10155ca13a23145320f6296640fd7154d454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815122Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#698517}
-
Peter Kasting authored
This also fixes an issue I suspect has been present a long time, where the horizontal scroll arrows pointed the wrong way in RTL. (This is also visible in the "expected result" movie on the bug.) Bug: 1005767 Change-Id: I701c0b99e797855868110f17ce386cd0491d3b06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815878 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#698516}
-
Randy Rossi authored
This CL detects when the children's order has changed in a tree update in order to invalidate the unignored index in parent cache. Before this change, the added test case would fail and could cause an infinite loop in the tree walker in the extension. Bug: 1005799 Test: Added unit test and manual testing of display assistant Change-Id: I902e74b0b5e25b949486bc9d7edc208cdd2aa846 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813521Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Randy Rossi <rmrossi@chromium.org> Cr-Commit-Position: refs/heads/master@{#698515}
-
Collin Baker authored
Previously, only the highest priority alert was returned from GetTabAlertStateForContents. This changes it to GetTabAlertStatesForContents which returns all current alerts, in descending order of priority. A convenience function, GetFirstTabAlertStateForContents, is provided to keep existing call sites simple. Bug: 1004983 Change-Id: I170309007d5f3f01c6eff924fa451dd4809abc16 TBR=avi@chromium.org Change-Id: I170309007d5f3f01c6eff924fa451dd4809abc16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814545 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#698514}
-
Robert Ogden authored
Bug: 990083 Change-Id: I8d3ac999d517cd4ed56245150a4bba6c576291d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815589 Commit-Queue: Robert Ogden <robertogden@chromium.org> Auto-Submit: Robert Ogden <robertogden@chromium.org> Reviewed-by:
-
Greg Thompson authored
- Only create a task running for anonymization when needed. - Only post a task to delete the anonymizer when there is one. - Run the callback immediately if there don't happen to be any sources. Bug: None Change-Id: Ib1ed94ed22802850b4cf311d45e4800510309412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816471Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#698512}
-
David Maunder authored
It has been determined to remove 'stale' and roll our close suggestions into one flag. All variations for the feature (e.g. stale tab threshold) will be done under this one flag. Bug: 1004555 Change-Id: Ia199b84bef19ff2a91e267f8a05a3954d8b7fb02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808173 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#698511}
-
Yasmin authored
It's possible that GetWidget returns null if there is no parent view. Bug: 988461 Change-Id: I483153282f082f7531589dc06928913139549d33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816504Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#698510}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8f2d41d1be9d..d7f28aae3d89 git log 8f2d41d1be9d..d7f28aae3d89 --date=short --no-merges --format='%ad %ae %s' 2019-09-20 jmadill@chromium.org Vulkan: Pass CommandGraph when updating serials. Created with: gclient setdep -r src/third_party/angle@d7f28aae3d89 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Bug: None Change-Id: Ida52d73963ce6a437a730a8042f0dde381629f68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815651Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698509}
-
danakj authored
The zoom level is a member of the VisualProperties. The browser side RenderWidgetHostImpl reads it from the site map when building the visual properties. When a cross-origin navigation completes to a new RenderWidget/Frame then the RenderWidgetHost is shown, which triggers a VisualProperties update. Thus the RenderWidget gets the right zoom level after a cross-origin navigation. (Same-origin navigations don't change zoom level.) The page zoom limits are reset to constants after each navigation, but that is the only call to the method changing the limits. So they are already effectively a constant. Remove the plumbing to set them to their own values, and fix the constants in WebViewImpl to be correct. Drop the IPC back to the browser, it already has the right constant values there. R=avi@chromium.org, dcheng@chromium.org Bug: 419087 Change-Id: Idfab9518592201833dd782f82ab5c6adea829080 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809500 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Yasmin authored
Bug: 988461 Change-Id: Iaeccbb32fdac1fd236e7d0b9bed6ec0f0aec11ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816542Reviewed-by:
-
Rune Lillesveen authored
Bug: 1003192 Change-Id: Ic623462e77468d29baa0f3daf1acb7774b006cf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816457 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#698506}
-
Eric Stevenson authored
This CL was generated by //base/android/jni_generator/jni_refactorer.py. Tbr: agrieve@chromium.org Bug: 929661 Change-Id: Iead2b36f9526ba122fe1bfdfb73eab5c1696abbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815048 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Auto-Submit: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#698505}
-
Mugdha Lakhani authored
Mark BackgroundSync.LaunchTask.* metrics obsolete, now that the code logging them has been deleted. Bug: 924490 Change-Id: I66c445ef70e6bfed9c15aaaa28bc682416828ba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811119 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#698504}
-
Erik Chen authored
When creating a Popup Widget, we use the main frame, possibly undead RenderWidget. Instead we should use the local root RenderWidget. Instead it should use the local root render widget. Bug: 912193, 419087 Change-Id: I5280ea48e44f96f4cc4bc4d9a7885f3343c5b7cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814672 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Erik Chen authored
In the future, undead RenderWidgets will no logner exist. This CL updates RenderViewImpl::CloseWindowSoon to check for this condition. Bug: 912193 Change-Id: Icbe449794080d36368eac5c9ffe90a198709dbda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814673 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Jeremy Roman authored
It has no definition; all real calls access LocalDOMWindow::isSecureContext. Change-Id: I82c37f54baef4de6f5efde7702874eaf02d0e232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816487 Auto-Submit: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#698501}
-
arthursonzogni authored
Patch: https://chromium-review.googlesource.com/c/chromium/src/+/1803443 turned linux-bfcache-rel into linux-bfcache-debug. Then the web_tests failed to run: https://chromium-swarm.appspot.com/task?id=47612740eb139410 ~~~ Found 6800 tests (total 82400); running 6378, skipping 422. Checking build ... Unable to find test driver at /b/s/w/ir/out/Release/content_shell For complete Linux build requirements, please see: https://chromium.googlesource.com/chromium/src/+/master/docs/linux_build_instructions.md Build check failed ~~~ The web_tests is trying to use the release binaries to run the tests, but only the debug ones are build. Bug: 1005653,976219 Change-Id: Ice438ec30c263f88aed77c0ba8250822318dd920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811126Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#698500}
-
Matt Menke authored
This method is no longer used. It was added so that ResourceDispatcherHost could create a URLRequest itself, and then pass it over to ResourceLoader, which took ownership and set itself as the delegate. It also allowed the downloads code to create its own URLRequests before handing them off to the RDH. Also make URLRequest::get_upload() a test-only method. It had been used to allow extensions to poke at upload data, which is no longer done in the network stack. We could remove this method entirely, reworking the tests that use it, but that's probably not worth the effort. Bug: 934009 Change-Id: I9b2fc70da7b7d9867c396760b26d583067802b50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814393Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#698499}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fb59a6aa3f71..04fd21513bfa git log fb59a6aa3f71..04fd21513bfa --date=short --no-merges --format='%ad %ae %s' 2019-09-20 danilchap@webrtc.org Cleanup passing rtp packet to ulpfec receiver. 2019-09-20 philipel@webrtc.org Removed unused frame_size param from RtpFrameObject ctor. 2019-09-20 nisse@webrtc.org Delete support for enabling adaptive isac mode 2019-09-20 philipel@webrtc.org RtpFrameObject now takes an EncodedImageBuffer in its ctor. Created with: gclient setdep -r src/third_party/webrtc@04fd21513bfa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: If62c7d4996b16a90b9aa4402e957ca5ad68539a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816817Reviewed-by:
-
Bo Liu authored
Views used by PowerSaveBlocker should be allowed to be garbage collected. WebView relies on this in order to not leak. Bug: 1004166 Change-Id: I95a996f4de21ab437650cb4ac039adb56e21815e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816797 Commit-Queue: Bo <boliu@chromium.org> Auto-Submit: Bo <boliu@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#698497}
-
Sophie Chang authored
Bug: 969558 Change-Id: I648d7acb145ac9bb6b0d2c3814fb07d5d84fc1e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814503Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#698496}
-
Mohamed Amir Yosef authored
This CL removes all the complexity of unblacklisting listing an origin and uses the recently introduce Unblacklist() method inside PasswordStore. Change-Id: Ia66625be452e8545db44e86d6c0380d55ed13a5a Bug: 1004783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810898 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#698495}
-
Matt Menke authored
A URLLoader creates a URLRequest on construction, and destroys it on destruction. It can never have a null URLRequest. This wasn't always the case, but is now. As for the is_pending() check: A URLRequest can only be canceled in two places, and can't complete successfully when there's a pending callback. The cancel calls are in places that only happen in response to different pending callbacks, and only one pending callback can be outstanding at a time, so the is_pending() check isn't needed. This is the only invocation if URLRequest::is_pending() in production, so it can now be made test only, or removed (The underlying value is still used in DCHECKs, so we can't just remove it, unless we want to lose those). Bug: 934009 Change-Id: Iec5eb4467a5cda1a8afc12f204086bbfc00ab7b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814884Reviewed-by:
-
Michael Crouse authored
Change-Id: I04c17fe523a7d2701695c92c3026dfffefa7e95e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814763 Auto-Submit: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
-
Alexander Timin authored
R=carlscab@google.com Change-Id: I31de368fb76d6aeb18770122d0aa32d36c20a18b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815127Reviewed-by:
Carlos Caballero <carlscab@google.com> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#698492}
-
Stephen McGruer authored
This reverts commit bf2af3a0. Reason for revert: Speculative revert due to memory metric regression - crbug.com.1004669 Original change's description: > Add ontransition{run, start, cancel} to GlobalEventHandlers > > https://drafts.csswg.org/css-transitions/#interface-globaleventhandlers-idl > > Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/dxDGBFKvO3A > > Bug: 868224 > Change-Id: I68b33822badc36c3cebcdca7bf6f47d834160270 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797226 > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Reviewed-by: Xida Chen <xidachen@chromium.org> > Commit-Queue: Stephen McGruer <smcgruer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#696699} TBR=chrishtr@chromium.org,xidachen@chromium.org,smcgruer@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 868224, 1004669 Change-Id: Icbf013b21a3cb384ac396dff97ae1e7485e9db21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816818Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#698491}
-
danakj authored
This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1799386 Page zoom level is a page/view concept, but the code to manage it is currently in RenderFrameImpl, though only run when it is the root frame. This doesn't dramatically change ownership of responsibility but moves the code up into RenderViewImpl. RenderWidget still goes through RenderFrameImpl (though more explicitly) to set the zoom level on the RenderView. And RenderWidget takes responsibility for closing the page popup instead of having multiple "set page zoom" methods on RenderViewImpl. This uncovered some spooky action-at-a-distance and makes it more explicit and documented, though no less unfortunate. A local root LocalFrame does not initialize with the correct page zoom value because it has no parent to read it from. We (accidentally?) worked around that by setting the RenderView's page zoom to its current value when navigating a (new) LocalFrame, which would call into blink's WebView and walk through the entire frame tree setting the value on everything, eventually also on the new LocalFrame. Now on navigation, for a local root, we call RenderWidget's UpdateWebViewWithDeviceScaleFactor() which does the same thing by re-setting the WebView's page zoom factor. This was done when making a new main frame in multiple places (RenderView and RenderFrame both called it in the same CreateFrame() callstack). Now it is consolidated to a single place on navigation for the main frame and child frames giving them more consistent behaviour, and going explicitly through this method that should go away if things were well designed, rather than re-setting the RenderView to its own value. Remove calls to UpdateWebViewWithDeviceScaleFactor() scattered throughout RenderViewImpl and RenderFrameImpl. What we need is for 1) The Page to be updated with PreferCompositingToLCDText when the device scale factor changes. 2) The WebView to be updated when the device scale factor changes. 3) The LocalFrame of a local root needs its page zoom set by poking the WebViewImpl to walk through all frames and set it. Web tests also have 2 places to set the page zoom factor: One is on the WebView, and one is on a LocalFrame directly. Both of these skip past content. When setting the zoom factor on WebViewImpl directly, content believes the zoom factor is still at the default. When SynchronizeVisualProperties events come in it sees the content value hasn't changed, so it does not set a zoom on blink. This allows the web tests to override the value secretly behind content's back and not have content fix it. This patch changed web tests via eventSender to set the value in content so that they agree. This means content receiving SynchronizeVisualProperties IPC will race with the test setting the page zoom and we need to prevent the IPC from overwriting the zoom set from the test. A test-override-zoom-level is added to RenderWidget to support this, similar to device scale factor. Secondly, the path to set page zoom factor on LocalFrame directly takes things a step further and changes the zoom behind the back of WebViewImpl also. This means the zoom factor has no chance to combine with the device scale factor, as WebViewImpl combines these 2 to set a zoom on the LocalFrame. That resulted in incorrect test results. It also continues to prevent content and blink from agreeing and causes SynchronizeVisualProperties updates to race with the test. This patch drops this second method for setting the zoom factor via internals, leaving just the eventSender path, which goes to the main frame RenderWidget. Web tests were also resetting the zoom level on the WebViewImpl directly from the TestRunnerForSpecificView::Reset(). Instead, we have EventSender reset the zoom back to 0 (the default) on the RenderWidget. R=avi@chromium.org, dcheng@chromium.org Bug: 419087 Change-Id: I1c59f78c194410302fc9d95c549b7cfaa08b3784 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811859 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
-
danakj authored
The LatencyInfoSwapPromiseMonitors do not need to be heap allocated, they are destroyed within the same stack frame where they are created but they are put on the heap because the LayerTreeHost is treated as being possibly null. The LayerTreeHost would only be null if the RenderWidget is closing, and an IPC is received on the handler through some other channel. Instead, don't call to the handler from RenderWidget::HandleInputEvent if the RenderWidget is closing. Then no null checks are needed, and the LatencyInfoSwapPromiseMonitors can be created on the stack. Also narrow their lifetime to just be around the method call that they are monitoring, for clarity. R=avi@chromium.org Bug: 994926 Change-Id: I47a04f248479a6266fba673ea0a2e98ce1671e66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812915Reviewed-by:
-
Eric Foo authored
See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: Ib196ebb2f7a29f89106978144f0137c0c917c469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808457 Auto-Submit: Eric Foo <efoo@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#698488}
-
Ken Rockot authored
This is a first step towards eliminating the File Service and migrating DOM Storage code into the Storage Service. File Service and its only clients (DOM storage objects) are moved off of Service Manager APIs. LocalStorageContextMojo and SessionStorageContextMojo are changed to own their own FileService instance, now constructed directly over a directory path. No functional changes intended in this CL. Bug: 994911,977637 Change-Id: I2ffd0bef670304a0dc3c103981139603521a14ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778801 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#698487}
-
arthursonzogni authored
The bot is not running in debug mode, causing one new test to fail: SecurityExploitBrowsertest.InvalidBeginNavigationInitor. The bug is easy to fix, which I already have a fix for. TBR: lowell@chromium.org Bug: None. Change-Id: Icd4e2b52829db155e5644e207f10ccae2932fc9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816472Reviewed-by:
Lowell Manners <lowell@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#698486}
-
danakj authored
These methods simply call to the underlying LayerTreeHost. Expose the LayerTreeHost directly on RenderWidget and in frame_test_helpers (instead of through LayerTreeView) and have these callers call to the LayerTreeHost instead of calling it through LayerTreeView. R=avi@chromium.org Bug: 994926 Change-Id: I07326b55e6c2de1a70df798689c0685df5525a2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812912Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#698485}
-
