GitLab

MediaTransferProtocolDaemonClient currently provides a low-level
ReadDirectoryEntryIds() method, and MtpManager does the translation to
the high-level ReadDirectory() method that MTPDeviceTaskHelper
understands.

Change MtpManager's ReadDirectory() method to ReadDirectoryEntryIds(),
so it acts more like a pass-through. Make MTPDeviceTaskHelper handle the
translation.

BUG=769630

Change-Id: I5154bd4beac0b6ab15579f166cdf8b8add6a7dac
Reviewed-on: https://chromium-review.googlesource.com/1080214
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565441}

This makes the AvatarToolbarButton toggle like a MenuButton similarly to
the adjacent BrowserAppMenuButton (which is actually a MenuButton).

Bug: chromium:849911
Change-Id: I30690c61dd9b9b58b80e28dcbc85dc9e72835b9d
Reviewed-on: https://chromium-review.googlesource.com/1091592
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565440}

Using wpt-import in Chromium 0635a5ef.
With Chromium commits locally applied on WPT:
e8832df8 "webrtc wpt: remove test_state_change_event"
fbdd17fb "Improve RTCPeerConnection-setRemoteDescription-tracks.https.html tests."
c220be7c "Fire RTCPeerConnection.onsignalingstatechange in the correct order."


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19164

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
mkwst@chromium.org, andypaicu@chromium.org:
  external/wpt/content-security-policy

TBR=foolip

No-Export: true
Change-Id: I85260495f00161b3cca3115b491e62231aa838e8
Reviewed-on: https://chromium-review.googlesource.com/1091648
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565439}

This will be used by manifest parser.

We now pass around a Cursor struct instead of CharType*
and return error type from all internal parsing methods.

Bug: 704441
Change-Id: If2773404d66d6a264cc5b573d7132ad57db117cd
Reviewed-on: https://chromium-review.googlesource.com/1072525Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565438}

Also, making sure the source of motion events is set, in order
to avoid warnings from InputEventConsistencyVerifier.

BUG=848740

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: Id1ee62b2d9eb63a6a3058b7a0914914823cf81d9
Reviewed-on: https://chromium-review.googlesource.com/1089856
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565437}

To allow testing with a local collector (that has decryption disabled),
we no longer encrypt HTTP UMA uploads if the destination is localhost.

Bug: 849127
Change-Id: Ied550633e7c11724bb6f61932963914b09560978
Reviewed-on: https://chromium-review.googlesource.com/1091274Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565436}

Bug: 850565
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I6976b6e8a99938fd93a630955b9358153ab09fba
Reviewed-on: https://chromium-review.googlesource.com/1091280Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565435}

This log is huge and isn't going to make sense for users. Instead
of displaying it directly, we want to show a string explaining
what its contents are.

  there is a one-line message there, check filed feedback to see
  that the whole iwlwifi_dump log is included in system_logs

Bug: 792644
Test: file feedback, check system information dialog and see that
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I01048934d348243fd1b127eec0a30b33a6437922
Reviewed-on: https://chromium-review.googlesource.com/738868Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Eric Caruso <ejcaruso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565434}

Update a subset of the //net tests to pump the message loop until a
particular event occurs by creating a RunLoop and passing its
QuitClosure to TestDelegate::set_on_<event>(..), or by using the
RunUntilComplete() helper.

Bug: 850145
Change-Id: Icc3cff76d5a7b93e92d2799ef9410bd41a31024f
Reviewed-on: https://chromium-review.googlesource.com/1084034
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565433}

InitialCommitInChildFrame and HistoryInertCommit are handled ~identically, and
seem to be safe to merge.

Change-Id: I3f4eca1a6b2174a9fc6ae5e73b5240d19f6b36ce
Reviewed-on: https://chromium-review.googlesource.com/1089875
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565432}

Currently, in the new Android horizontal tab switcher, we show the close button
on the left side of the tab (in LTR mode) in both portrait and landscape
orientations. We've decided we want to put it on the right side to improve
readability of the favicons. This CL moves the close button to be on the right
in both portrait and landscape modes.

This CL also cleans up the logic for determining which side to put the button
on, since we currently repeat the same logic in multiple places, which is very
difficult to maintain. I'm adding a parameter on LayoutTab that Stack can keep
updated so TabListSceneLayer doesn't have to replicate the logic for the check.

Bug: 849397,831359
Change-Id: I01559d56d084ffe3c2a2a35468c8a62fa5a16a16
Reviewed-on: https://chromium-review.googlesource.com/1089572Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565431}

This CL fixes a memory leak that occurs in LocalSafeBrowsingDatabaseManager that
was seen on the Linux Asan bot [1].  The race occurs when a delayed
initialization task happens after the database is closed during shutdown.

[1] https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ASan%20LSan%20Tests%20%281%29/46741

BUG=None

Change-Id: I45043c243bc6b5af948c8171d72e50f203611395
Reviewed-on: https://chromium-review.googlesource.com/1090235Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565430}

Changes:
We fixed this for shelf before
(https://codereview.chromium.org/2894743002), but not for
app launcher which results in inconsistent behavior. So
fix this for launcher as well.

Bug: 850335
Change-Id: I19849658ad0617fe7326895b58efd72261eb8a8c
Reviewed-on: https://chromium-review.googlesource.com/1091277Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565429}

The CL maps the Page.setWebLifecycleState devtools
protocol method to httphandler endpoints.

Change-Id: I1eb66cb3e6c73b55949974fc572456c81ffaeed6

Bug: chromium:837709
Change-Id: I1eb66cb3e6c73b55949974fc572456c81ffaeed6
Reviewed-on: https://chromium-review.googlesource.com/1066395
Commit-Queue: Fadi Meawad <fmeawad@chromium.org>
Reviewed-by: Jonathon Kereliuk <kereliuk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565428}

Updated language and concept in extension overview document.

Bug: None
Change-Id: I02409acdeabd8597aa01be164dbcf8f316779f84
Reviewed-on: https://chromium-review.googlesource.com/1070320
Commit-Queue: Crystal Lambert <crystallambert@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565427}

This CL fixes flakiness on some WebGL tests. Before, if Time to Interactive was
not detected, the InteractiveDetector would try to unregister itself on its
destructor. If the weak pointer in |observers_| was cleaned up and another
observer was registered between the time the weak pointer was cleaned up and the
destructor of InteractiveDetector was called, we would call
AddTaskTimeObserver() again, hitting a DCHECK.

Bug: 848715
Change-Id: I6c6bef6811f570367aee3f983919e899ab0db1f5
Reviewed-on: https://chromium-review.googlesource.com/1085628Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565426}

TBR=palmer@chromium.org

Bug: 850696
Change-Id: Ibf535472226fafd2f1fe437bb0deb8ab4d9e9785
Reviewed-on: https://chromium-review.googlesource.com/1091531Reviewed-by: Glenn Hartmann <hartmanng@chromium.org>
Commit-Queue: Glenn Hartmann <hartmanng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565425}

Bug: 850261
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7269b851c9689f7a656bff594871ea873e7b51f8
Reviewed-on: https://chromium-review.googlesource.com/1091143Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565424}

Also updated the comments to explain when certain code
is executed.

Bug: 849303
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ib359d1b6291fb9c2c91506ac9fe44b22c9202775
Reviewed-on: https://chromium-review.googlesource.com/1089872Reviewed-by: Mohammad Refaat <mrefaat@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565423}

Just a speculative fix.
Still don't know why a scrollable box doesn't have paint properties.

Bug: 849278
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I4add45ef22ae71d6cc0ec617b4405fb5fdf2145f
Reviewed-on: https://chromium-review.googlesource.com/1090037Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565422}

The test failed because rendering the NTP was blocked on loading
machine statistics, which was done from a TaskPriority::BACKGROUND
task. The priority of that task was changed to
TaskPriority::USER_BLOCKING in
https://chromium-review.googlesource.com/c/chromium/src/+/1082608, so
the test can be enabled.

The test is still disabled when Mash is enabled, because the
non-empty paint signal isn't fired in this case (even when background
tasks aren't disabled).

Bug: 831835
Change-Id: Ie847b152b057883f62bef060c6294a427980c838
Reviewed-on: https://chromium-review.googlesource.com/1082609Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565421}

Update all remaining histogram_tester.h includes to include
//base/test/metrics/histogram_tester.h instead of
//base/test/histogram_tester.h, as well as a reference in the
documentation.

Remove the now-unnecessary hack file at //base/test/histogram_tester.h.

There should be no behavior change from this CL.

TBR=thestig@chromium.org (non-metrics //base/, //chrome files)
TBR=rockot@chromium.org (//services)
TBR=creis@chromium.org (//content)
TBR=jochen@chromium.org (//components)

Bug: 846421
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I3722f5856dda190c2802628a1214e4eaffbe69f0
Reviewed-on: https://chromium-review.googlesource.com/1087593Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565420}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/a206cf9..840fa58


git log a206cf9..840fa58 --date=short --no-merges --format='%ad %ae %s'
2018-06-07 dgarrett@google.com chromeos_config: Setup LUCI scheduler entries.
2018-06-07 dgarrett@google.com config_lib: Add scheduled/gitiles_triggered values.


Created with:
  gclient setdep -r src/third_party/chromite@840fa58

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:848547,chromium:848547
TBR=chrome-os-gardeners@chromium.org

Change-Id: Iecd89be164aaf7ec2fb396d70a3bcda749e97d4f
Reviewed-on: https://chromium-review.googlesource.com/1091530Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#565419}

R=amineer@chromium.org

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I8ab367d31ddd4392fd847518bdd5d980b64c4f27
Reviewed-on: https://chromium-review.googlesource.com/1091276Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565418}

We need to use v1.1 Vulkan APIs in order to do OpenGL interop.
This CL updates third_party/Vulkan to v1.1.76

BUG=850408

Change-Id: Ic90912d8933ccd89bc54d2ee32ece5bf937b116a
Reviewed-on: https://chromium-review.googlesource.com/1090571Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Chris Blume <cblume@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565417}

Change-Id: Icafc3b1ba9214723ace644f9cfa6f3e89a28897d
Reviewed-on: https://chromium-review.googlesource.com/1089337Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Cr-Commit-Position: refs/heads/master@{#565416}

Bug: 849991
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I3aee27a853c880ac5f20aca6b9a19b32bcd97d39
Reviewed-on: https://chromium-review.googlesource.com/1091292Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565415}

This reverts commit 0cc7b305.

Reason for revert: UX designer has new specification on this piece of UI, since we need to cherry-pick to M68, I'd revert this CL and include the new spec in another CL.

Original change's description:
> Download location: fix storage summary string.
> 
> The storage summary string under download home title currently uses
> SpannableString that can expand to multiple lines, and can only apply
> simple styles defined by Spannale.
> 
> This CL adds a view for the summary string.
> 
> 
> Bug: 849973
> Change-Id: If01d323022e0cc743540a02ba58801c664957aa4
> Reviewed-on: https://chromium-review.googlesource.com/1089815
> Reviewed-by: David Trainor <dtrainor@chromium.org>
> Commit-Queue: Xing Liu <xingliu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#565309}

TBR=dtrainor@chromium.org,qinmin@chromium.org,xingliu@chromium.org

Change-Id: I7a1c678d8dadfe66ef95b044daffde67282922b8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 849973
Reviewed-on: https://chromium-review.googlesource.com/1091810Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565414}

MediaTransferProtocolDaemonClient currently provides a low-level
GetFileInfo() method, and MtpManager does the translation to the
high-level GetFileInfo() method that MTPDeviceTaskHelper understands.

Change MtpManager's GetFileInfo() from the high-level method to the
low-level method, so it acts more like a pass-through. Make
MTPDeviceTaskHelper handle the translation.

BUG=769630

Change-Id: I21e20b71d333a1ee7173071f04aaf2e37dd61844
Reviewed-on: https://chromium-review.googlesource.com/1080212
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565413}

These tests mix use of QuitCurrent*Deprecated() with use of the current
RunLoop::Quit*Closure() model. Migrate them off the deprecated API so
that we can enforce quit-by-closure-only wherever QuitClosure is used.

Bug: 844016
Change-Id: Ie832373ecba2060b860b9f49e056f437c30b9b7e
Reviewed-on: https://chromium-review.googlesource.com/1089829
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565412}

Each PPAPI interface had an associated ppapi::AppID, used as its IPC
routing-Id. Many interfaces still have Ids listed, despite no longer
using them.

Change-Id: Id8017f5861e12d0be14c5dc108c6c6023c3bbd3f
Reviewed-on: https://chromium-review.googlesource.com/1086489Reviewed-by: Raymes Khoury <raymes@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565411}

BUG=849760
TEST=Manual

Change-Id: I13ff6e252ab39672ed2e01d49044ed31e4d00683
Reviewed-on: https://chromium-review.googlesource.com/1091176Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Muyuan Li <muyuanli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565410}

This change allows clients which need to frequently poll SecureChannel API
for connection metadata updates (e.g., Smart Lock) to do so.

Bug: 824568, 752273
Change-Id: Iad7cd7d9f37e22563ee46fc257b4f146ce260a60
Reviewed-on: https://chromium-review.googlesource.com/1091223
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565409}

This changes creates a NetBiosClient class that will implement
the UDP packet protocol for a NetBios Name Query Request. This change
creates the skeleton of the class in order to keep CLs small. This class
will be owned by a future NetBiosHostLocator class.

Bug: chromium:757625
Change-Id: I80cb6dba070118da02c046009de196ed41be2f55
Reviewed-on: https://chromium-review.googlesource.com/1062193
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565408}

Use SearchPathList::Find()'s ability to look directly inside
a zip archive if the path contains a ! separator to simplify
LibraryList::LoadLibraryFromZipFile().

+ LibraryList::LoadLibraryWithSystemLinker() is introduced to
  greatly simplify the code flow and the LibraryList::LoadLibrary()
  parameter list.

This is part of an ongoing effort to support the component build,
cleanup the crazy linker, and better detect system libraries.

NOTE: The LegacyLinker.java change is necessary to ensure
      RELRO sharing works properly. The issue was that the
      RELRO was associated with the file path of the APK itself,
      instead of the library SO_NAME.

BUG=802068,843987
R=pasko@chromium.org, agrieve@chromium.org, rcmilroy@chromium.org

Change-Id: I833b02635f71d0bf63794681ba78e9a33647e204
Reviewed-on: https://chromium-review.googlesource.com/1091058Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: David Turner <digit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565407}

Also a minor cleanup making GpuPreferences const.

TBR=boliu@chromium.org,tsepez@chromium.org

Bug: 785008
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I865682dc09a817a2d05a1ee9a410be5510f6bef9
Reviewed-on: https://chromium-review.googlesource.com/1091072
Commit-Queue: Jonathan Backer <backer@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565406}

Change-Id: Ia95b34635305bd2e0d7d4ce4c006fc8e9fd65aae
Reviewed-on: https://chromium-review.googlesource.com/1091500Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565405}

https://chromium.googlesource.com/chromium/src/+/b5c5c86c21a0bf51cc910e0b62611aea45aa0b0d
removed most of the custom logic for sync requests from
DocumentThreadableLoader. This left a lot of helper methods with only
one caller, where previously there had been two.

* Inline HandleResponse() into ResponseReceived()
* Inline HandleReceivedData() into DataReceived()
* Inline HandleSuccessfulFinish() into NotifyFinished()
* Merge LoadRequestAsync() and LoadRequestSync() paths, and inline
  the single path into LoadRequest().

Change-Id: Ie068b49396c355884e2d71588b35280dbe07a86f
Reviewed-on: https://chromium-review.googlesource.com/1087312
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565404}

This ensures we aren't running deferred runnables and reacting
to the omnibox positioning when the omnibox isn't focused.

BUG=512087,444670

Change-Id: Ie353c94caf9bbf753ea2c55dbb7974df78bcc9e4
Reviewed-on: https://chromium-review.googlesource.com/1091505Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565403}

This eliminates some console logging that should not be in production,
and fixes a potential bug in the reset screen that generates a
CONSOLE error in ResetTest but does not cause the test to fail.

Bug: 647411
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I54e8d9d6c93a3e6aeed42381f8658d182bd1c965
Reviewed-on: https://chromium-review.googlesource.com/1087210Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565402}