- 03 Dec, 2018 40 commits
-
-
Kenneth Russell authored
The GPU tests act much like integration tests for the entire browser, and tend to uncover flakiness bugs more readily than other test suites. In order to surface any flakiness more readily to the developer of the CL which is introducing it, we disable retries with patch on the commit queue. Bug: 906166 Change-Id: Iee56100a774377b9172325627da4694ce0a15009 Reviewed-on: https://chromium-review.googlesource.com/c/1357569Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#613319}
-
rajendrant authored
Bug: 911001 Change-Id: I72b6f8955be6c736f5c0063e76c3695bbde07e28 Reviewed-on: https://chromium-review.googlesource.com/c/1359128Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#613318}
-
Nicolas Ouellet-payeur authored
Fixes the alignment of the "Managed by your organization" footnote in the App Menu, to respect the spec from UX. Specifically: - Footnote no longer spills over the menu's bottom border - Add some top & bottom margin to make the footnote larger - Fix capitalization on Mac OS ('Organization' => 'organization') - Fix rounded corners not appearing on Mac OS Bug: 893626 Change-Id: Iccaa6e702bc4ccdc756b34f362874059a4347a18 Reviewed-on: https://chromium-review.googlesource.com/c/1355888 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#613317}
-
Akihiro Ota authored
Improve upon previous implementation of GetPosInSet and GetSetSize for AXNode, which computed pos_in_set and set_size values upon every call of either function. Introduced cache for these values in AXTree, which maps a node's id to a struct holding its pos_in_set and set_size values. Cache is invalidated upon updates to the AXTree. Change-Id: I70c0878b05b53b98648af1f2b76d1e1bf6e6d294 Reviewed-on: https://chromium-review.googlesource.com/c/1351782Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#613316}
-
Ned Nguyen authored
** NOTE TO PERF SHERIFF **: this CL might cause false regressions on "Win 7 Nvidia GPU Perf" & "Win 7 Perf" that are safe to ignore Commandline: $ ./tools/perf/generate_perf_sharding update --builders="Win 7 Nvidia GPU Perf" -r $ ./tools/perf/generate_perf_sharding update --builders="Win 7 Perf" -r Bug:906654 Change-Id: I420051f0629a8b8c79ac2e4da6cc736e911b02bb NOTRY=true # ios-simulator flake Change-Id: I420051f0629a8b8c79ac2e4da6cc736e911b02bb Reviewed-on: https://chromium-review.googlesource.com/c/1358911 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Emily Hanley <eyaich@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#613315}
-
Alexander Alekseev authored
This CL replaces CHECK with DCHECK to prevent fatal failures in the wild. TBR=asvitkine@chromium.org Bug: 910833 Change-Id: I070339cb47506b2b6823b9d3f8e4a7b06fc310ff Reviewed-on: https://chromium-review.googlesource.com/c/1357919Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#613314}
-
Kurt Horimoto authored
This callback can be used to notify FullscreenControllerObservers of changes to the viewport inset range. It can be used to trigger a viewport adjustment for new toolbar heights. Bug: 674649 Change-Id: I4ecdc374c1017716518118a27d4b9c5e0f1db48f Reviewed-on: https://chromium-review.googlesource.com/c/1340953 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#613313}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/0c172a6b74fc..d835d664bd3b git log 0c172a6b74fc..d835d664bd3b --date=short --no-merges --format='%ad %ae %s' 2018-12-03 dj2@everburning.com [val] Fixup id name output (#2158) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@d835d664bd3b The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I852dbbda7a2562d71be516546c95e8051e9a46ab Reviewed-on: https://chromium-review.googlesource.com/c/1358767Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#613312}
-
Kelvin Jiang authored
Occasionally, 2 activity log entries with the same api call exist in the database. When presented to the UI, this can confuse some users. This CL groups activities by their api call and sorts them based on the total number of calls. This achieves feature parity with the Chrome Apps and Extensions Developer Tool. Bug: 832354 Change-Id: I566a3620b6a5fd3b35825e49d3db5fb9fbb7f416 Reviewed-on: https://chromium-review.googlesource.com/c/1350924 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#613311}
-
Erik Luo authored
- Avoid showing scrollbar when creating new watch - Fix object watch alignment - Replace "minus" icon with "cross" Screenshot: https://imgur.com/a/pdrKIey Bug: 910683 Change-Id: I554f08295a4c92c954167f5e09f55f104d285bfb Reviewed-on: https://chromium-review.googlesource.com/c/1357602Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#613310}
-
Etienne Pierre-Doray authored
This CL splits ScheduleAdjustMaxTasksIfNeeded() into: - ShouldScheduleAdjustMaxTasksLockRequired() - ScheduleAdjustMaxTasks() To reuse taken lock and avoid reacquiring the same locks multiple times. Change-Id: I55e2f8fa1063e2cb5537ca14a96cb118b388047d Reviewed-on: https://chromium-review.googlesource.com/c/1357304 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#613309}
-
James Cook authored
AXTreeSourceAura doesn't exist any more. The tests exercise the integration of AXRootObjWrapper with AXTreeSourceViews, so rename the tests ot AXTreeSourceViewsRootTest. Note that the tests lived in //chrome/browser/ui/ash. If we need an ash-specific tree source we could introduce an AXTreeSourceAsh either in //ash (for mash) or //chrome/browser/ui/ash (for SingleProcessMash). Bug: 910672 Test: views_unittests Change-Id: I79438345e3ad9bd1aa69d74b3c34cc35efe87142 Reviewed-on: https://chromium-review.googlesource.com/c/1358972Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#613308}
-
Lei Zhang authored
Change-Id: Ia5f0d37480f95d9412f3d4f4534e227c9dae3733 Reviewed-on: https://chromium-review.googlesource.com/c/1357765Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#613307}
-
Charles Zhao authored
The 10% stable experiment has shown 10% improvement. Bug: 862413 Change-Id: I9c2422f8c19e0fb997160f49d822882b96f18aff Reviewed-on: https://chromium-review.googlesource.com/c/1351337Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#613306}
-
Yao Xiao authored
To get a sense of which sites are having sandboxed download, so we might be able to provide evidence that the blocking is worthwhile. Bug: 539938 Change-Id: I672077892064b0f156a78aac1ff5be044f6c3ef8 Reviewed-on: https://chromium-review.googlesource.com/c/1356890Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#613305}
-
Justin Donnelly authored
This feature has been approved for launch. Bug: 824893 Change-Id: I41dcae918a9649e2313dc592dfbe702f66123a03 Reviewed-on: https://chromium-review.googlesource.com/c/1359062 Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#613304}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/eec53b64a610..89808a631e39 git log eec53b64a610..89808a631e39 --date=short --no-merges --format='%ad %ae %s' 2018-12-03 achuith@chromium.org tast_test_stages: Launch VM outside cros_sdk shell 2018-12-03 zentaro@chromium.org cros image test: Update tss group baseline for oobe_config Created with: gclient setdep -r src/third_party/chromite@89808a631e39 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I56fc84a29929d20e721fd1c1355173021c3a429a Reviewed-on: https://chromium-review.googlesource.com/c/1358766Reviewed-by:
-
Saman Sami authored
This parameter is currently ignored. It was added with the intention of importing a SharedImage multiple times with different internal formats for RGB emulation, however an alternative solution that does not require this parameter is creating two different SharedImages wrapping the same GpuMemoryBuffer, with one SharedImage having a special usage flag that indicates RGB emulation. See http://crrev.com/c/1348974 Bug: 882591 Change-Id: Ia48d3dd78321f1c3f20816e5c1856ef23c56cda1 Reviewed-on: https://chromium-review.googlesource.com/c/1359058Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#613302}
-
Giovanni Ortuño Urquidi authored
This make it easier to write tests while still maintaining the flexibility of the fakes. Also gives more descriptive names to the adapter objects paths. This makes the adapter object paths easier to distinguish from future device, service, characteristic, and descriptor object paths. Bug: 870192 Change-Id: I716809e757ab2ddf4a261fa2105e2224ec982ee1 Reviewed-on: https://chromium-review.googlesource.com/c/1358117Reviewed-by:
Ovidio Henriquez <odejesush@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#613301}
-
Oleh Prypin authored
This is a reland of e14ed878 With correct output path to v4l2/v4l2_stubs.{h,cc} Original change's description: > Make a GN template for generate_stubs.py > > Make it produce a source_set which can be depended on rather than directly including sources into the parent target. > > Bug: chromium:682122 > Change-Id: I7ad9f94459f187481e656e3513eabb3e2a6f92a1 > Reviewed-on: https://chromium-review.googlesource.com/c/1348042 > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Reviewed-by: Mirko Bonadei <mbonadei@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Oleh Prypin <oprypin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#611117} Bug: chromium:682122, chromium:909020 Change-Id: I1d34d5bb0dc9f4f72a444e9463669793c3f5a171 Reviewed-on: https://chromium-review.googlesource.com/c/1356703Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Oleh Prypin <oprypin@chromium.org> Cr-Commit-Position: refs/heads/master@{#613300}
-
Robert Flack authored
This reverts commit 902bd031. Reason for revert: The DCHECK is regularly failing on telemetry_perf_unittests, sample https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29/73315: [9072:11232:1203/091954.734:FATAL:latency_tracker.cc(468)] Check failed: !pending_finished_lag_report_. Backtrace: base::debug::StackTrace::StackTrace [0x6F0548A6+102] base::debug::StackTrace::StackTrace [0x6F05387B+27] logging::LogMessage::~LogMessage [0x6F0A4A07+151] ui::LatencyTracker::CalculateAverageLag [0x5FB5FDD1+3281] ui::LatencyTracker::ComputeEndToEndLatencyHistograms [0x5FB5CC83+8595] ui::LatencyTracker::OnGpuSwapBuffersCompleted [0x5FB5AAAE+494] ui::LatencyTracker::OnGpuSwapBuffersCompleted [0x5FB5A6E4+260] viz::SoftwareOutputSurface::SwapBuffersCallback [0x5F92B4B0+64] base::internal::FunctorTraits<void (__thiscall viz::SoftwareOutputSurface::*)(bool),void>::Invoke<void (__thiscall viz::SoftwareOutputSurface::*)(bool),base::WeakPtr<viz::SoftwareOutputSurface>,bool> [0x5F92BB7C+76] base::internal::InvokeHelper<1,void>::MakeItSo<void (__thiscall viz::SoftwareOutputSurface::*)(bool),base::WeakPtr<viz::SoftwareOutputSurface>,bool> [0x5F92BA62+130] base::internal::Invoker<base::internal::BindState<void (__thiscall viz::SoftwareOutputSurface::*)(bool),base::WeakPtr<viz::SoftwareOutputSurface>,bool>,void __cdecl(void)>::RunImpl<void (__thiscall viz::SoftwareOutputSurface::*)(bool),std::tuple<base::Wea [0x5F92B98F+111] base::internal::Invoker<base::internal::BindState<void (__thiscall viz::SoftwareOutputSurface::*)(bool),base::WeakPtr<viz::SoftwareOutputSurface>,bool>,void __cdecl(void)>::RunOnce [0x5F92B804+84] base::OnceCallback<void __cdecl(void)>::Run [0x6F008900+80] base::debug::TaskAnnotator::RunTask [0x6F0566EB+859] base::MessageLoopImpl::RunTask [0x6F0D0656+886] base::MessageLoopImpl::DeferOrRunPendingTask [0x6F0D0B79+73] base::MessageLoopImpl::DoWork [0x6F0D15F0+400] base::MessagePumpForUI::DoRunLoop [0x6F0DA8BE+62] base::MessagePumpWin::Run [0x6F0D9837+119] base::MessageLoopImpl::Run [0x6F0CFF63+483] base::RunLoop::Run [0x6F189298+488] base::Thread::Run [0x6F2A0367+375] base::Thread::ThreadMain [0x6F2A0B58+1272] base::PlatformThread::GetDefaultThreadStackSize [0x6F292C86+406] BaseThreadInitThunk [0x74C8338A+18] RtlInitializeExceptionChain [0x770C9902+99] RtlInitializeExceptionChain [0x770C98D5+54] Original change's description: > Add Latency.AverageLag metric > > This CL adds a float value scroll_update_delta_ for GSU deltaY and > a time component for last coalesced event to latency_info. > And also adds implementation for Event.Latency.Scroll.AverageLag > metrics, which measures an average distance represents the lag > between finger movement and page scroll. > > detail of the metric see the design doc: > https://docs.google.com/document/d/154jddNiKtxELBvrjLz9v6A7sA1J3iwQQzySHgtY12Oo/edit?pli=1#heading=h.zf3l6o8vecuv > > Change-Id: I64adef4ebf107185ad4fd1eeec276ea527e1c5ef > Reviewed-on: https://chromium-review.googlesource.com/c/1239260 > Commit-Queue: Ella Ge <eirage@chromium.org> > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#611206} TBR=kenrb@chromium.org,rkaplow@chromium.org,tdresser@chromium.org,nzolghadr@chromium.org,eirage@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I08d00db01093c787afff59d6ed9714b9bf7ab746 Reviewed-on: https://chromium-review.googlesource.com/c/1359299Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#613299}
-
Jonathan Backer authored
This makes sure that when a RasterDecoderContextState context is lost that we follow the same logic for GLES2 decoder context loss. Change-Id: Ia46c54311cf8ae696b4b464cfb33b365601843f9 Reviewed-on: https://chromium-review.googlesource.com/c/1355338Reviewed-by:
-
Andrey Lushnikov authored
The --disk-cache-dir flag allows to use custom disk cache folder instead of using the one inferred from user data directory. BUG=882431 R=caseq Change-Id: I2da7e1c4b72eda32bccf6851c66ce44c1aaa837d Reviewed-on: https://chromium-review.googlesource.com/c/1359038Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#613297}
-
Ben Mason authored
This allows the 32-bit build of the shared library to overwrite the one built via the 64-bit build. Bug: 908115, 893125 Change-Id: I0ede727cfced2dd5285f75594f08b8c3450e8a27 Reviewed-on: https://chromium-review.googlesource.com/c/1357312Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#613296}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/d758e32610cb..f0b761f116f6 git log d758e32610cb..f0b761f116f6 --date=short --no-merges --format='%ad %ae %s' 2018-12-03 enga@chromium.org Implement timeline fences in Dawn Created with: gclient setdep -r src/third_party/dawn@f0b761f116f6 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I2d88b5fcbbfe4d15a173ab562115b02aefb08909 Reviewed-on: https://chromium-review.googlesource.com/c/1358809Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0a1293c2e432..f9910ea25812 git log 0a1293c2e432..f9910ea25812 --date=short --no-merges --format='%ad %ae %s' 2018-12-03 kjlubick@google.com [canvaskit] Add profile mode 2018-12-03 fmalita@chromium.org [skottie] Surface composition markers in CK 2018-12-03 reed@google.com add != for SkFont 2018-12-03 herb@google.com Clean up handling of lambda capture to use refs correctly 2018-12-03 kjlubick@google.com [canvaskit] remove POC Nima code Created with: gclient setdep -r src/third_party/skia@f9910ea25812 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: I06cc898945ffc9ef5209ceeed0ec0b48d12e83d4 Reviewed-on: https://chromium-review.googlesource.com/c/1358763Reviewed-by:
-
David Benjamin authored
Bug: none Change-Id: I71a0dbbe87ca76015107f61dbff9647ba33041bc Reviewed-on: https://chromium-review.googlesource.com/c/1359310Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#613293}
-
Xing Liu authored
This CL hides detail like download file size or percentage for in progress download notification. Now we only show "Downloading" in the notification text. Bug: 901393 Change-Id: I25a2f660c9004e6e5aafd671cfae291cea6bd5bd Reviewed-on: https://chromium-review.googlesource.com/c/1359053Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#613292}
-
Meilin Wang authored
Add an accessible window title called "Assistant" for Assistant container view, thus ChromeVox can read the window title when invoking multilayered shortcut:Search + a > w. Bug: 910559 Test: local compile and manually test. Change-Id: Ia71e08567cf448abce1e9a5d59b9fe50f34be8a2 Reviewed-on: https://chromium-review.googlesource.com/c/1357650 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#613291}
-
François Doray authored
Prior to this CL https://chromium-review.googlesource.com/1093015, the UserDataKey of a class T derived from WebContentsUserData<T> was the address of a static member variable of WebContentsUserData<T>. Storage had to be allocated for that static member variable. Unfortunately, it was not possible to allocate the storage if T was an exported class. Since https://chromium-review.googlesource.com/1093015, the UserDataKey of a class T derived from WebContentsUserData<T> is the address of a local static variable in a static method of WebContentsUserData<T>. Unfortunately, since the method is defined in a header file (it has to because it is part of a templated class), it can be instantiated multiple times and return different values if it is referenced from different components (e.g. in a component build). With this CL, the UserDataKey of a class T derived from WebContentsUserData<T> is the address of a static member variable of T. This solution works fine with exported classes, but it requires adding macros to declare/define the static member variable in T. TBR=avi@chromium.org Bug: 589840 Change-Id: Ie618c09f1ab5db1e11ac3e7a86405577872e932f Reviewed-on: https://chromium-review.googlesource.com/c/1354402 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#613290}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7808a519be73..d87b09662ee8 git log 7808a519be73..d87b09662ee8 --date=short --no-merges --format='%ad %ae %s' 2018-12-03 joenotcharles@google.com More context when _load_codereview_impl asserts Created with: gclient setdep -r src/third_party/depot_tools@d87b09662ee8 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:908466 TBR=agable@chromium.org Change-Id: Iaccfc54f9a3362befb6c1bc7cad0b7a020634f31 Reviewed-on: https://chromium-review.googlesource.com/c/1358764Reviewed-by:
-
Mike Reed authored
Bug: 899689 Change-Id: Ie69dda53e3be3b2ec1113cea5f763e2e016f26bd Reviewed-on: https://chromium-review.googlesource.com/c/1358693 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#613288}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c10a023a66f2..66f0d2c1e7b5 git log c10a023a66f2..66f0d2c1e7b5 --date=short --no-merges --format='%ad %ae %s' 2018-12-03 jmadill@chromium.org Make Framebuffer attachments angle::Subjects. Created with: gclient setdep -r src/third_party/angle@66f0d2c1e7b5 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I59224d226ee6fcd3829c7e66663a8239eccf813e Reviewed-on: https://chromium-review.googlesource.com/c/1358808Reviewed-by:
-
Tatiana Buldina authored
Bug: chromedriver:2677 Change-Id: I77946071bac5c924e2c56745f93309cada417fae Reviewed-on: https://chromium-review.googlesource.com/c/1358510Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#613286}
-
Giovanni Ortuño Urquidi authored
On real devices, AdapterPropertyChanged is called for each property in the adapter before AdapterAdded is called. During this, the adapter should be included when returning GetAdapter and all its properties should be accessible (though they will be empty). Changes TestBluetoothAdapterClient to match this behavior but instead of calling AdapterPropertyChanged for all properties, we call it for the two that are used in tests "Powered" and "Discovering". Bug: 870192 Change-Id: I501cfb8ad2665aee27314188e5a7f667e2209ebf Reviewed-on: https://chromium-review.googlesource.com/c/1358101Reviewed-by:
-
Scott Violet authored
This way Window::GetBoundsInScreen() returns screen coordinates. BUG=none TEST=covered by tests Change-Id: I701247ec7005b3f8bcedacbe7345154b51287a67 Reviewed-on: https://chromium-review.googlesource.com/c/1359305Reviewed-by:
-
Kristi Park authored
[NTP] Determine shortcut title direction by the first strong character and adjust RTL for edit shortcut dialog fields Determine text direction using the first strong character instead of whether the text contains any RTL character. Also add direction support in the edit shortcut dialog fields LTR browser: https://screenshot.googleplex.com/11Z58bTugPV.png https://screenshot.googleplex.com/ne61RSr24qg.png https://screenshot.googleplex.com/fr28i5Zzceh.png RTL browser: https://screenshot.googleplex.com/ZEGVSdiOsTS.png https://screenshot.googleplex.com/cNtF8s6htp9.png https://screenshot.googleplex.com/RHoZu97GL8y.png Bug: 910385 Change-Id: I842c1479e3a3003e218d58d5ccfa511fdddc4963 Reviewed-on: https://chromium-review.googlesource.com/c/1357637 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#613283}
-
Dale Curtis authored
Apparently zero byte, nullptr packets can still be attached to memory, who knew! BUG=852093,910896,910898,910928 TEST=local run shows no leaks. R=tmathmeyer Change-Id: Iff90057b02e37cb67b9d443ffeb92695e6e5c7f8 Reviewed-on: https://chromium-review.googlesource.com/c/1359060Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#613282}
-
Sebastien Marchand authored
Bug: 863441 Change-Id: Icd11498ed8f396c5506ae995da34d375af8f7655 Reviewed-on: https://chromium-review.googlesource.com/c/1355989 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#613281}
-
Ovidio Henriquez authored
This change implements two new helper methods for site settings that organize the chooser exceptions in a way that allows their corresponding site exceptions to be grouped under the same exception. The structure of the objects returned by GetChooserExceptionListFromProfile(), described in jsdoc notation, is the following: { chooserType: string, displayName: string, object: Object, sites: Array<!SiteException> } The objects in the sites array follow the same structure as the non-chooser exceptions. Design doc: https://docs.google.com/document/d/1MPvsrWiVD_jAC8ELyk8njFpy6j1thfVU5aWT3TCWE8w Bug: 854329 Change-Id: I92a654da2ef9d1d0f045df0a35eaf70a1940b44e Reviewed-on: https://chromium-review.googlesource.com/c/1357605 Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Reviewed-by:Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#613280}
-
