- 23 May, 2020 27 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cd91738658a1..0e9dcc8458c4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ramyan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: ramyan@google.com Change-Id: I673eca95862b4cdaabf2992d346e299723255507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213866Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771395}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1590191676-5c3f21023d82190a9464b9c5e89cd434c565ee7a.profdata to chrome-win32-master-1590233284-fd6678888e52eeab623146060a829ba63d1fa6df.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I94e3ffc5de80fc1f03905860d2b199a79678e339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213874Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771394}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5ede0f88f001..af8825a827c4 2020-05-23 John.Emau@microsoft.com [a11y] Add high contrast highlight to common suggestion box 2020-05-23 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-05-23 jalyn@microsoft.com Make DOM breakpoint markers accessible to screen readers 2020-05-23 joselea@microsoft.com Add e2e tests for WebAudio If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1079076,chromium:963183 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I472f4f8deccc9a67898dbacc316fb2b571121ee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213868Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1590217180-7f74db4cf012cca33f33b85c818d756cfd2194c3.profdata to chrome-win64-master-1590233284-8f8a16c96876d5156324618385b352c2ad39a0b8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ibb9f8f980885833beaea7bba7ef9b2b39a1d7550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213873Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590217180-51b9273d618b4d6dbb31ecb0a93ec2277a6c9b14.profdata to chrome-mac-master-1590233284-972be5f6ae8d3ad4588c9cb3d0679e65540952ff.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I01136bf94849917183e9e1cc79f016feea801ab9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213869Reviewed-by:
-
Ben Mason authored
This reverts commit 6e46cca3. Reason for revert: Breaking auth flow b/156844354 Original change's description: > webview: make extra header handling more sensible. > > Change how extra headers provided through loadUrl(url, extra_headers) > are handled in WebView: > > 1) Remove any extra headers from the request if the request is > redirected to a different origin, since they might be sensitive. > > 2) Don't attempt to add any extra headers for the redirect target URL > when we encounter a redirect; this is likely to be surprising and > unwanted. > > 3) Record metrics on when we add headers and what was done with them on > redirect. > > 4) Add an additional test verifying that the extra headers are cleared > if the app loads the same URL again via loadUrl(url). > > Bug: 1038002 > Change-Id: Ib39e2938f7b76d212cd20773aab56da138088b63 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999229 > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org> > Commit-Queue: Richard Coles <torne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#747517} TBR=isherman@chromium.org,torne@chromium.org,tobiasjs@chromium.org Bug: 1038002 Change-Id: I18791d4ef448d1ed9bcd4f0b02d4b8884018e8c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213114 Commit-Queue: Ben Mason <benmason@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#771390}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/dd4d881300f8..5ede0f88f001 2020-05-23 joselea@microsoft.com Disable animations e2e test If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1085569 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I83e2ac0144a6644ad38376c1063f0102289fe8c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213865Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3cc1a6509bf6..7eccfc6933c7 2020-05-23 tommi@webrtc.org Trigger bots 2020-05-22 tommi@webrtc.org Fork NackModule and RtpVideoStreamReceiver If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Icbc7da410cea8b9c71381118959e0d3add450414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213554Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium cfec860f. With Chromium commits locally applied on WPT: f6984fd9 "De-flaky pointerlock/pointerevent_pointermove_in_pointerlock.html" 45436d4d "CookieStore: WPT to verify subscribe/unsubscribe is idempotent" fc4093a6 "Move mouse-pointer-preventdefault.html to wpt" 3304d0fe "Revert "Move mouse-pointer-preventdefault.html to wpt"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I0aa6082cbee28239313ea394c591be3be360b81e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212385Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771387}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/01e27aa0861f..cd91738658a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ramyan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: ramyan@google.com Change-Id: Ic6cde2a52efa26549a8ca5526a57f8a57c2628f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214012Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590206289-f2583ee09947e45da7b7f23f035c3dabfb79111e.profdata to chrome-mac-master-1590217180-51b9273d618b4d6dbb31ecb0a93ec2277a6c9b14.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I7024a57f693d9b03bcb1aa15af2b9acd717d910a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214014Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1590206289-6352d847cb20dd6e1d54ae3f58ed7b3dd5403432.profdata to chrome-win64-master-1590217180-7f74db4cf012cca33f33b85c818d756cfd2194c3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Iad4a72cb61413b3a88204754f3aede99da38daaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214016Reviewed-by:
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: I9ffc4e7399aad299a37af2baeb5dd0817e9d1f45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214010 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#771383}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c3e2c610cae3..01e27aa0861f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ramyan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: ramyan@google.com Change-Id: I40f86bf106318199cbcd78fca141883c81703e7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213980Reviewed-by:
-
Kenneth Russell authored
conformance/glsl/misc/shader-with-non-reserved-words.html is likely the culprit test causing GPU process crashes. However, conformance/glsl/misc/shader-with-reserved-words.html is the one observed crashing the GPU process. Skip both on Win/NVIDIA/Vulkan/passthrough. Bug: 1085627 Change-Id: Iebd7c77e30785eda79202de5bef1abc5437053a2 No-Try: True Tbr: jmadill@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214009Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#771381}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/88a3b462962d..3422479f10c4 2020-05-23 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I483792ac7dd4b0917e9494dbc75dbadd3e7e53c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214001Reviewed-by:
-
David Tseng authored
This reverts commit 9cca4806. Reason for revert: <INSERT REASONING HERE> See flakey failures https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyTwsSBUZsYWtlIkRjaHJvbWl1bUBicm93c2VyX3Rlc3RzQENocm9tZVZveEJyYWlsbGVUYWJsZVRlc3QudGVzdEdldFVuY29udHJhY3RlZAw [7369:7369:0522/203957.919406:FATAL:chrome_extensions_browser_client.cc(148)] Check failed: context. #0 0x55cfe9dfc549 base::debug::CollectStackTrace() #1 0x55cfe9d09be3 base::debug::StackTrace::StackTrace() #2 0x55cfe9d20d7f logging::LogMessage::~LogMessage() #3 0x55cfe9d2156e logging::LogMessage::~LogMessage() #4 0x55cfed7b0e42 extensions::ChromeExtensionsBrowserClient::GetOriginalContext() #5 0x55cfed58f4c3 BrowserContextKeyedServiceFactory::GetContextToUse() #6 0x55cfebd733c3 KeyedServiceFactory::GetServiceForContext() #7 0x55cfea38f279 extensions::TtsExtensionEventHandler::OnTtsEvent() #8 0x55cfe73698c8 content::TtsUtteranceImpl::OnTtsEvent() #9 0x55cfe7365120 content::TtsControllerImpl::ClearUtteranceQueue() #10 0x55cfe7365f03 content::TtsControllerImpl::StopInternal() #11 0x55cfe7367071 content::TtsControllerImpl::OnBrowserContextDestroyed() #12 0x55cfe6d1d18c content::BrowserContext::~BrowserContext() #13 0x55cfea0f813f ProfileImpl::~ProfileImpl() #14 0x55cfea0f816e ProfileImpl::~ProfileImpl() #15 0x55cfea0f1f72 ProfileDestroyer::DestroyRegularProfileNow() #16 0x55cfea0f1d00 ProfileDestroyer::DestroyProfileWhenAppropriate() #17 0x55cfea1137e8 std::__1::unique_ptr<>::~unique_ptr() #18 0x55cfea114ee3 std::__1::__tree<>::destroy() #19 0x55cfea11473b ProfileManager::~ProfileManager() #20 0x55cfea10bfae ProfileManager::~ProfileManager() #21 0x55cfe9eac15a BrowserProcessImpl::StartTearDown() #22 0x55cfe9eaab2a ChromeBrowserMainParts::PostMainMessageLoopRun() #23 0x55cfe51c9e74 chromeos::ChromeBrowserMainPartsChromeos::PostMainMessageLoopRun() #24 0x55cfe6d41ccf content::BrowserMainLoop::ShutdownThreadsAndCleanUp() #25 0x55cfe6d43b6d content::BrowserMainRunnerImpl::Shutdown() #26 0x55cfe6d3eb02 content::BrowserMain() #27 0x55cfe97ac717 content::ContentMainRunnerImpl::RunServiceManager() #28 0x55cfe97ac2cf content::ContentMainRunnerImpl::Run() #29 0x55cfec99806a service_manager::Main() #30 0x55cfe7f60444 content::ContentMain() #31 0x55cfea5622a4 content::BrowserTestBase::SetUp() #32 0x55cfe9cf633b InProcessBrowserTest::SetUp() #33 0x55cfe579858e testing::Test::Run() #34 0x55cfe5799948 testing::TestInfo::Run() #35 0x55cfe579a5e7 testing::TestSuite::Run() #36 0x55cfe57aa747 testing::internal::UnitTestImpl::RunAllTests() #37 0x55cfe57aa179 testing::UnitTest::Run() #38 0x55cfe9e477e2 base::TestSuite::Run() #39 0x55cfe9cdf0e7 BrowserTestSuiteRunnerChromeOS::RunTestSuite() #40 0x55cfea5a72f4 content::LaunchTests() #41 0x55cfe9cdf494 LaunchChromeTests() #42 0x55cfe9cdf032 main #43 0x7f421a16f830 __libc_start_main #44 0x55cfe29b442a _start Fixed: Fixed: 1085878, 1085877 Fixed: 1085878, 1085877 Original change's description: > Fix UAF in TtsPlatformImpl if a BrowserContext is deleted. > > Bug: 1081350 > Change-Id: I2b1824abefbd7fc3e8ce1c0cb433896161bab4e5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211123 > Reviewed-by: David Tseng <dtseng@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771222} TBR=dmazzoni@chromium.org,dtseng@chromium.org,jam@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1081350 Change-Id: I88ec7e523fbe56845b8480b112535b2f8e18a520 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213553Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#771379}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1590177508-ab8e07852b85f9a8b9b3fea70f472cb98013b6e2.profdata to chrome-win64-master-1590206289-6352d847cb20dd6e1d54ae3f58ed7b3dd5403432.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I61a323b9c975a78fca6ebba6460a3507a1008843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213978Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590191676-a4db509c06232b1ce84802804d74b9954154103c.profdata to chrome-mac-master-1590206289-f2583ee09947e45da7b7f23f035c3dabfb79111e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Id08ff6190f840684009d106d992678466b9f8b9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213977Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4f8283ef4bdf..c3e2c610cae3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ramyan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: ramyan@google.com Change-Id: Ia541dd37256615f675e847a1730d5ce64895300a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213780Reviewed-by:
-
Gayane Petrosyan authored
Bug: 1085873 Change-Id: I2ec9e4e673757c31ea354bb542430512199771a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213882Reviewed-by:
Travis Skare <skare@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#771375}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d998d150. With Chromium commits locally applied on WPT: f6984fd9 "De-flaky pointerlock/pointerevent_pointermove_in_pointerlock.html" 45436d4d "CookieStore: WPT to verify subscribe/unsubscribe is idempotent" fc4093a6 "Move mouse-pointer-preventdefault.html to wpt" 3304d0fe "Revert "Move mouse-pointer-preventdefault.html to wpt"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Iba2508d67027feaaa30a2a8b712585b48b9f78f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213903Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=bindusuvarna@chromium.org Change-Id: Ibeccedca5c13ca28c7a7e1ce972d65c2aad67986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213844Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771373}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1590177508-82204ce5fd465758380fa192db925e711e803d9a.profdata to chrome-win32-master-1590191676-5c3f21023d82190a9464b9c5e89cd434c565ee7a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Id2c6be3878062bc85b82459cc5e50e46d1157152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213776 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/562c067f0813..4f8283ef4bdf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ramyan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: ramyan@google.com Change-Id: I6edaaeadb69c13b3c164ccecf545ab7eda5e9b53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213771Reviewed-by:
-
Jinsuk Kim authored
Added a missing deps in the target native_java_unittests_java which uses the newly added chrome/browsr/contextmenu:java. This reverts commit bb30c5c1. Bug: 952703 Change-Id: Ib29b8c62311f0bd70616a959022a605f6daebfb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210036Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#771370}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590177508-6c1b546bac84a3411fd7b6d2012a9c3c8fbfc260.profdata to chrome-mac-master-1590191676-a4db509c06232b1ce84802804d74b9954154103c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ia552ea239fdbd6453f0d7d374f7a59f5b0bb77b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213772Reviewed-by:
-
- 22 May, 2020 13 commits
-
-
Kenneth Russell authored
It's randomly crashing the GPU process, causing it and the test following it to fail. Skip this in both the WebGL 1.0 and 2.0 expectations though it's not run on the waterfall for WebGL 2.0 yet. Bug: 1085677 Change-Id: I91ee47fb9ebc345d33c2e8e885f3b40b4a7c2f27 Tbr: jmadill@chromium.org No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213766Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/870a83f93edf..562c067f0813 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ramyan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: ramyan@google.com Change-Id: Ia38af002398eafbada9688abe3e4440902df929d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213761Reviewed-by:
-
Alexander Surkov authored
Extend property filter format to name(args)=value to specify arguments for a method call. AX-Relnotes: n/a Bug: 1076955 Change-Id: I0c862b257808368e93c41e61a9b5525d35bb80d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2190175 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#771366}
-
Yury Semikhatsky authored
This reverts commit 1537d629. Reason for revert: potentially breaks gmail reloading when disabling offline mode with DevTools open. Bug: 1085150 Original change's description: > [DevTools] Properly notify devtools agent host when service worker is destroyed > > ServiceWorkerDevToolsAgentHost now stores thread-safe reference to > ServiceWorkerContextWrapper instead of ServiceWorkerContextCore that > could be deleted asynchronously on the service worker core thread. > > WorkerDestroyed notification is now sent to the observers of > ServiceWorkerDevToolsManager iff the worker version is both stopped > and doomed. Each worker can be terminated (and restarted) multiple times > and will result in a sequence of targetCrashed/targetReloadedAfterCrash > events in the protocol but the instance of its > ServiceWorkerDevToolsAgentHost will survive restarts and all connected > sessions will be preserved. > > It fixes the events generated in the protocol for service workers from > targetCreated, (detachedFromTarget, attachedToTarget, targetReloadedAfterCrash)* to > targetCreated, (targetCrashed/targetReloadedAfterCrash)*, targetDestroyed > and avoids inadvertent session terminations when workers are stopped and > also spurious targetReloadedAfterCrash events. > > Bug: none > Change-Id: I1125604d08b7842f7f8d74751091193b9af2cb59 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099590 > Commit-Queue: Yury Semikhatsky <yurys@chromium.org> > Reviewed-by: Tsuyoshi Horo <horo@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#750975} TBR=dgozman@chromium.org,horo@chromium.org,caseq@chromium.org,yurys@chromium.org,einbinder@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: none Change-Id: Ibba7ce840b8c8b73c32086d141005306591e21cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213448Reviewed-by:
Yury Semikhatsky <yurys@chromium.org> Commit-Queue: Yury Semikhatsky <yurys@chromium.org> Cr-Commit-Position: refs/heads/master@{#771365}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c9ebf905761c..d3d7b95bac19 2020-05-22 tobine@google.com Vulkan:Migrate timer sync functions to one-off cmd buffer If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: I71e9cadf99c470b6f64131ed368df229a515b774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213454Reviewed-by:
-
danakj authored
Tests that want to run the document lifecycle are changed to use updateAllLifecyclePhasesAndCompositeThen(). The test that wants to do printing in the renderer and grab the pixels is changed to capturePrintingPixelsThen(). This path explicitly prints the current frame, rather than going into the end-of-test-find-a-frame (non-OOPIF-compatible) path. This makes it possible to use the API from any frame. Remove all the main-frame-attached post/invoke v8 callback helpers in TestRunnerForSpecificView, as they are no longer used. R=nasko@chromium.org Bug: 866140, 1069111, 952399 Change-Id: I8271f093bbc0ad9c68b2c05acc24d2062d090f72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204408 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#771363}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1590161669-17629765fa6319602482bd35878adc03bc8e5e00.profdata to chrome-win32-master-1590177508-82204ce5fd465758380fa192db925e711e803d9a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ib67ff81d9e3bd02590af8711fa3dc4281ae832ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213763Reviewed-by:
-
Kurt Catti-Schmidt authored
Support for UIA_CulturePropertyId via GetPropertyValue was added in https://chromium-review.googlesource.com/c/chromium/src/+/1096255/, however it was not implemented according to spec. The MSDN spec for UIA_CulturePropertyId specifies that this property returns an integer with a language code, not a BSTR with the language attribute string as implemented previously. This change returns the proper culture ID as spec'd, via the existing 'GetCultureAttributeAsVariant' method added for TextPattern. Unit tests are added for a variety of scenarios. AX-Relnotes: Fixes an issue when looking up a node's language in UIA. Bug: 1085205 Change-Id: I60c9b83b65ecf7f56fd5cb7929d495ac7620a08c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212979 Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Adam Ettenberger <Adam.Ettenberger@microsoft.com> Cr-Commit-Position: refs/heads/master@{#771361}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1590161669-593ac6a44fd629dc3035fae6d797ac804dd4b719.profdata to chrome-win64-master-1590177508-ab8e07852b85f9a8b9b3fea70f472cb98013b6e2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Iae799d3d3dbf53b341e542f4690aa36c361b08db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213762Reviewed-by:
-
Sahel Sharify authored
This cl exposes payment features to java using a payment specific feature list rather than ChromeFeatureList.With this change payment features will be accessible from components/payments. Bug: 1085784 Change-Id: Ib7c1114b61519fd838842f0e53c2f9a7fb816b6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213334Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#771359}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590161669-1437af88aff1c6cc90f5b4a73d3631f0e7fd0e76.profdata to chrome-mac-master-1590177508-6c1b546bac84a3411fd7b6d2012a9c3c8fbfc260.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I4ae8b476f875f92a6b89826fe54211fffdef191e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213458Reviewed-by:
-
Sam Fortiner authored
Based on early results in dev/canary, this feature is looking promising and we would like to continue this experiment in Beta. To unblock that we are enabling this experiment for the perf bots now to get more data on the impact. Bug: 1058987 Change-Id: I5e771beb6d4085c25df353c68c37db05d220af65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211019Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Sam Fortiner <samfort@microsoft.com> Cr-Commit-Position: refs/heads/master@{#771357}
-
Pavel Yatsuk authored
This CL adds a dialog that is displayed when interaction with permission dialog is blocked because of overlay window covering permission dialog buttons. BUG=1014477 Change-Id: I1ab7a6342f77f28e3179a4f5129d8fcf292f3019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198365 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#771356}
-
