- 19 Jun, 2020 40 commits
-
-
Tanmoy Mollik authored
This reverts commit 4a914f21. Reason for revert: Build failure in https://ci.chromium.org/p/chrome/builders/ci/arm64-unpublished-builder and https://ci.chromium.org/p/chrome/builders/official/android-arm-official-next Possible reason might be renaming //chrome/android:monochrome_public_bundle__base_libs_and_assets_expectations and //chrome/android:trichrome_chrome_bundle__base_libs_and_assets_expectations Original change's description: > Android: Define paths to expectation files in leaf targets > > This is easier to follow then deriving it in the templates. > > Also changes webview expectations apk->bundle > > Bug: 1095654 > Change-Id: I5952ee9a660e4f32b22ef4100fea2f231d9eb96d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245880 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Richard Coles <torne@chromium.org> > Reviewed-by: Mohamed Heikal <mheikal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#780157} TBR=torne@chromium.org,agrieve@chromium.org,mheikal@chromium.org Change-Id: I8ef314098ae3949d21fc885b885b467314f6d695 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1096987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252344Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#780271}
-
Sharon Yang authored
Rename ComponentContextForCurrentProcess to ComponentContextForProcess. Move function to process_context from default_context. Remove default_context files. Remove unused includes. Test: CQ Bug: 1090364 Change-Id: I11d591cc87be7170513016713e77a816fc8e8fc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242163 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#780270}
-
Javier Ernesto Flores Robles authored
Update Tooltip specs to the ones detailed in the attached bug. Bug: 1090777 Change-Id: I4e76f3c2e168bc8e4ffd8bb1dc88fb343db817fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253899 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#780269}
-
Lukasz Krakowiak authored
Method QuitClosure() provides more deterministic behaviour than QuitWhenIdleClosure(). R=wez@chromium.org Change-Id: I523bae5be0a176d5e6239573f20c78894a43e352 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236398Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#780268}
-
Stephen Nusko authored
This reverts commit efddc7e5. Reason for revert: task runner needs to be set in slow_window_capturer_chromeos.cc Original change's description: > Revert "When Serializing the CopyOutputRequest use the threadpool for expensive copies." > > This reverts commit f248d2a2. > > Reason for revert: Suspected of causing failures for AuraWindowVideoCaptureDeviceBrowserTest.* > https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/19215 > > Original change's description: > > When Serializing the CopyOutputRequest use the threadpool for expensive copies. > > > > Currently when Chrome requests a screenshot we send a CopyOutputRequest > > from the browser. However while taking this screenshot we need to > > transfer it over a mojo pipe. This serialization takes 100-200 ms an > > example traces in the linked bug on the VizCompositor thread and then > > another 100-200 ms to deserialize it on the CrBrowserMain. This can > > block high priority tasks which delay input handling causing visible > > jank to users. > > > > We fix this by doing the expensive copies on the ThreadPool, most other > > copy tasks only take a couple ms so this removes most of the pain > > relatively easily. > > > > Tests had to be updated to know to wait for > > CopyOutputResult::SendResult to complete async. > > > > > > Bug: internal b/152858656 > > Change-Id: I114d65894c80742309bc2a02fdd2a0a7ad56dae7 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201762 > > Commit-Queue: Stephen Nusko <nuskos@chromium.org> > > Reviewed-by: Eric Seckler <eseckler@chromium.org> > > Reviewed-by: vmpstr <vmpstr@chromium.org> > > Reviewed-by: Mitsuru Oshima (slow:gardening) <oshima@chromium.org> > > Reviewed-by: Chris Palmer <palmer@chromium.org> > > Reviewed-by: Stephen Nusko <nuskos@chromium.org> > > Auto-Submit: Stephen Nusko <nuskos@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#779930} > > TBR=palmer@chromium.org,oshima@chromium.org,vmpstr@chromium.org,eseckler@chromium.org,nuskos@chromium.org > > Change-Id: I7c3a2011728b442580dd2c2da4816c0426649a4b > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: internal b/152858656 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253678 > Reviewed-by: calamity <calamity@chromium.org> > Commit-Queue: calamity <calamity@chromium.org> > Cr-Commit-Position: refs/heads/master@{#780185} TBR=palmer@chromium.org,oshima@chromium.org,vmpstr@chromium.org,calamity@chromium.org,eseckler@chromium.org,nuskos@chromium.org # Not skipping CQ checks because this is a reland. Bug: internal b/152858656 Change-Id: I9fa3e36dd6e874ada1fe336157eee73011b16b99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252802 Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#780267}
-
Javier Ernesto Flores Robles authored
Bug: 1090777 Change-Id: Idf8a990bf402771af5836f5f5bcd292dc46316b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253763 Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Andy Paicu authored
TBR=szuend@chromium.org Bug: 1097005 Change-Id: Ief101f02088c1bebe8a592f42aa81e7cb884d64a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252248Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#780265}
-
Tanmoy Mollik authored
This reverts commit 9b955d94. Reason for revert: org.chromium.chrome.features.start_surface.StartSurfaceTest#testSearchInIncognitoSingleSurface__Instant_Return is flaky. I suspect this cl is the reason for that Original change's description: > [StartSurface] Switch to normal tab model on resume to V2 start surface > > This CL also solves the scroll issue of the incognito description. > > Screen records: > Resume: > https://drive.google.com/file/d/1jPFCAEwTDzI4PO-Ef-HdvRV6KeZoW4fD/view?usp=sharing > > Scroll: > https://drive.google.com/file/d/1C2lFMBKmdTaipWcHBG9mAYCJNuhoiYK_/view?usp=sharing > > Bug: 1093506 > Change-Id: I5d7365daa530b23f897a19665076cbc32238224f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243334 > Commit-Queue: Ganggui Tang <gogerald@chromium.org> > Auto-Submit: Ganggui Tang <gogerald@chromium.org> > Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#779878} TBR=yusufo@chromium.org,gogerald@chromium.org,wychen@chromium.org Change-Id: I97a65d561d8b3c3a28cf8a4b40b4354166669d8e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1097002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252805Reviewed-by:
-
Tanmoy Mollik authored
This reverts commit 9d41ebe6. Reason for revert: org.chromium.chrome.features.start_surface.StartSurfaceTest#testSearchInIncognitoSingleSurface__Instant_Return is flaky. This cl is causing a merge error to revert the original cl https://crrev.com/c/2252688 Original change's description: > [StartSurface] Set incognito description height to match parent > > This CL fixes the bug in > https://chromium-review.googlesource.com/c/chromium/src/+/2243334 > > Without setting the height to match_parent, it will be unscrollable > when its content is short. > > Screen record before > https://drive.google.com/file/d/1CUOz6ErGL2fxkF2pGAC_fGWEcTGy8hrD/view?usp=sharing > > Screen record after > https://drive.google.com/file/d/1CeuBtjQbGRovJC8H0Vk-wY6wpWqmlQJ0/view?usp=sharing > > Bug: 1093506 > Change-Id: Iff9df7ef0050885c02fe55676dbfa2046d6e78a0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253143 > Commit-Queue: Ganggui Tang <gogerald@chromium.org> > Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Auto-Submit: Ganggui Tang <gogerald@chromium.org> > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#780086} TBR=gogerald@chromium.org,wychen@chromium.org Change-Id: I7abf532c1da073c32b1c604540c5ef68728587f6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1097002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252046Reviewed-by:
-
Francois Doray authored
With this CL, a PageScheduler has 2 WakeUpBudgetPools: - A WakeUpBudgetPool for frames that are same-origin with the main frame. - A WakeUpBudgetPool for frames that are cross-origin to the main frame. A FrameScheduler moves its throttleable TaskQueues to the appropriate WakeUpBudgetPool when its "FrameOriginType" changes. This CL does not affect behavior. However, in an upcoming CL, the WakeUpBudgetPool for frames that are same-origin with the main frame will allow unaligned wake ups if there hasn't been a wake up in the last 60 seconds. Bug: 1075553 Change-Id: Ic45306f7d20d2fc0f4a1d9618dc6eca449e946dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248320 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#780262}
-
Andy Paicu authored
TBR=xiaochengh@chromium.org Bug: 1097000 Change-Id: I94edbeb778bf35ea18a18412262ef57e4dfbabdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252145Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f2f2cf0206e5..3340bd2d130c 2020-06-19 mathias@chromium.org Fix stylelint-config-standard issues in accessibility/axBreadcrumbs.css 2020-06-19 kimanh@chromium.org Revert "Split computed-pane-properties_tests.ts to avoid timeouts" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1083142,chromium:1096439 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If533a9c60ee078736738c0d7bdeb68285cc6d127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253878Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780260}
-
arun manickam authored
The args - `cached_package_labels` is added in core gni. This CL updates the args in local-sdk script to prevent local script failures. Bug: None Test: manual testing Change-Id: I4d7ad136e461551540180ff463b1194a3bd42dcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252567 Auto-Submit: Arun Manickam <arunmanickam@google.com> Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
-
Andy Paicu authored
TBR=adanilo@chromium.org Bug: 1097013 Change-Id: I1ed5abccd73b2c8c2ad71dccca8fde5863232d15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253762Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e7ae237eb9e9..84fb97ba9452 2020-06-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 99651228b238 to 545d158a2ff9 (2 revisions) 2020-06-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 7a1d99d0be42 to eb6824408d08 (3 revisions) 2020-06-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 24a17f5fe4ef to 7942c0830780 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: I3fd23e39ecb467344088f6845141d47d4e524c41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253571Reviewed-by:
-
Victor Hugo Vianna Silva authored
This is a reland of 39818338 Reason for reland: The original CL missed .js extensions in two of its imports. When the new dialog started being used in crrev.com/c/2246157 this caused several tests to fail. TBR=aee@chromium.org Original change's description: > [b4p/Settings] Add dialog for removing duplicated passwords > > For a b4p user, in case some password has copies attached both to the > device and the Google Account, attempting to delete it should show a > dialog that allows selecting which copies to remove. This CL implements > this dialog but does not yet wire it in. Some details in the UI are left > for future CLs, such as the user avatar and displaying the website > associated with the password to be deleted. Note RemovePasswordBehavior > is not used here, for reasons that are better explained in > crrev.com/c/2246157. > > Screenshot of implementation: > https://screenshot.googleplex.com/hZnTiuy80tL > > Screenshot of mock: > https://screenshot.googleplex.com/pGV0iMTQBxw > > Bug: 1049141 > Change-Id: I50ca0e5bfc99dbc76c12c345c00f82788bbc377c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248180 > Commit-Queue: Victor Vianna <victorvianna@google.com> > Reviewed-by: Friedrich [CET] <fhorschig@chromium.org> > Reviewed-by: Esmael Elmoslimany <aee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#779743} Bug: 1049141 Change-Id: I39cc548744d7d290b98de3376b96eb7c5472efae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252246 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#780256}
-
Caitlin Fischer authored
As described in more detail here (crbug.com/1096582), this test seems to cause testSingleSyncSignout and testSingleDisableSync to be flaky. Added a bug to re-enable testRegularPlusIncognito. Bug: 1094932 Change-Id: I87ce718f3d533f5684d97ff5aadb6f8cf8c9ba2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252638Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#780255}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592545853-4aad13dd3d5b31e6b22212a49c45cb09e0a49e05.profdata to chrome-win64-master-1592557014-0fc653e79e8d54496b6e208718c321ae21bb710d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I6958144b98aa99629e5b26628b97c9328e361b3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253572Reviewed-by:
-
Maksim Sisov authored
It doesn't seem to be used at all. Thus, remove that. Change-Id: I5aba62543107efe4cc719d9e8168ac1f7f7c38db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250112 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#780253}
-
Caitlin Fischer authored
Original description: Replace GzipUncompress calls with DecodeLogDataToProto. Also, remove "ukm::", where applicable, from ukm_service_unittest.cc Bug: 1086910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222521Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Original-Commit-Position: refs/heads/master@{#777137} Change-Id: Ia59944a291b095755f5b9cb889f6c16b5388a704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248750 Cr-Commit-Position: refs/heads/master@{#780252}
-
Hans Wennborg authored
Add direct includes for things provided transitively by logging.h (or by other headers including logging.h). This is in preparation for cleaning up unnecessary includes of logging.h in header files (so if something depends on logging.h, it needs include it explicitly), and for when logging.h no longer includes check.h, check_op.h, and notreached.h. TBR=kinuko Bug: 1031540 Change-Id: I302009b875c8cdad1465cb72331fdd22dd33adeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249674 Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#780251}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I521397e8ea474bdf7a66d2b28d38508e06fe389c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251525Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#780250}
-
Alexander Hendrich authored
This reverts commit 88854e15. Reason for revert: replaced with new enterprise.networkingAttributes API Change-Id: I3e1553f3aad053a2c7780d8e1c1f4498c759ecc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250062Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#780249}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0ec56611a754..f2f2cf0206e5 2020-06-19 patrick.brosset@microsoft.com Split computed-pane-properties_tests.ts to avoid timeouts 2020-06-19 wolfi@chromium.org Add FrameManager to aggregate info about ResourceTreeFrames 2020-06-19 mathias@chromium.org Force-replace Windows-style path separators for stylelint If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1083142,chromium:1093247,chromium:1096439 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9e96dbd4bd62bba7e0657df41ed35368888a0f68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253782Reviewed-by:
-
arthursonzogni authored
It has been decided to monitor only the attributes marked as CrossOrigin instead of every attributes. Updating the tests accordingly. Along the way some improvements. Bug: chromium:1090273 Change-Id: Iecd0bd478ab348f75f3835105db5bdca9edcc39b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252339 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#780247}
-
Nektarios Paisios authored
This is a reland of 41e56b19 Dealt with crashes https://chromium.googlesource.com/chromium/src.git/+/a6705f429d0215f809bc98715c4a69aa0f3b6ca3 An occasional infinite loop was identified and fixed in AXPosition, between CreateParentPosition and AtStartOfLine methods. Original change's description: > Consolidated some text helper methods in AXNode > > This patch is a second precursor to a more substantial change that > would move hypertext computation to AXNode from AXPlatformNodeBase which will > in turn open the way for AXNodePosition to be merged with AXPosition and > for Views to be exposed as a tree of AXNodes. > See https://chromium-review.googlesource.com/2150294 > > Currently, we have multiple methods that compute inner text, IsLeaf and IsChildOfLeaf > one set in BrowserAccessibility and another in AXPlatformNodeBase. > We want to centralize all platform independent utility methods in AXNode and AXNodeData. > > There was some confusion in the existing codebase regarding what should be included in inner text. > Some code assumed that the name attribute of a leaf node could not be included, unless it was derived from its contents, > or its placeholder in the case of a text field. > Other parts of the codebase were more relaxed about this requirement. > > This patch adopts this requirement for the whole codebase, because the definition of inner text should only include visible > text that is present inside the node itself, but not text derived from an attribute, e.g. an ARIA label. > This is apparent from the name "inner text" itself, but it also stems out of the need > to support computing bounding boxes for character ranges in inner text. > If the name of an element is derived from an attribute such as an ARIA label, that attribute won't expose any bounding box information. > If the name of an element is derived from a related element, e.g. a figcaption or an HTML label, > the bounding box of that element is unrelated to the original element's inner text. > > APIs to compute bounding boxes are exposed in IAccessibleText, ATKText and ITextRangeProvider. > > See also the definition of IAccessibleText in the IAccessible2 Specification, > the definition of ATKText in the ATK Specification, or > the definition of ITextProvider in the UIA Specification. > 1. https://accessibility.linuxfoundation.org/a11yspecs/ia2/docs/html/interface_i_accessible_text.html > "The IAccessibleText interface should be implemented by all components that present textual information on the display like > buttons, text entry fields, or text portions of the document window." > 2. https://developer.gnome.org/pygtk/stable/class-atktext.html > "... if the text is editable, multi-line, typically longer than three or four words, attributed, selectable, > or if the object already uses the 'name' ATK property for other information, the atk.Text interface should be used" > 3. https://docs.microsoft.com/en-us/windows/win32/api/uiautomationcore/nn-uiautomationcore-itextprovider > "Provides access to controls that contain text." > 4. https://docs.microsoft.com/en-us/windows/win32/winauto/uiauto-implementingtextandtextrange > "If an embedded object spans a range of text, the plain text should include the inner text of the object, but not the alternative text (the name property of the embedded object) > because it might be inconsistent with the descriptive inner text." > > RELNOTES: N/A > > R=dmazzoni@chromium.org, aleventhal@chromium.org > TBR=rsesek@chromium.org > > Bug: 1049261 > Change-Id: Ic39687eb98c3ef7575214de2c659eb28d6633466 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2171436 > Commit-Queue: Nektarios Paisios <nektar@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771809} TBR=dmazzoni@chromium.org, rsesek@chromium.org Bug: 1049261 Change-Id: Iebe5f00e5119ce4020dedcee176ecf9fc8a40310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224224Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Auto-Submit: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#780246}
-
Mihai Sardarescu authored
Histogram Welcome.SignInPromptResult expired by mistake in M81. This CL resurects it as it is needed to understand how user interact with the welcome page. Bug: 814779 Change-Id: If6976a0ebdb84f979a3b6b91137a446a7310db3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252194 Auto-Submit: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#780245}
-
Jérôme Lebel authored
-[<ApplicationCommands> showAdvancedSigninSettingsFromViewController:] is needed by WelcomeToChromeViewController. Bug: 971989 Change-Id: Ie7800f0fcc5cb26fda3bfa3b1713cc05fb9aad21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252101 Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
-
Mario Sanchez Prada authored
Currently, AXContentTreeData and AXContentTreeUpdate are defined in the same source files than AXContentNodeData (ax_content_node_data.h), which makes it a bit unconvenient now that we are in the process of removing all these classes, in favour of those from //ui/accessibility. While technically this is not a requirement for the process, it would be convenient to have each definition on separate places so that we can work in a more iterative way towards removing those three classes, so this CL puts AXContentTreeData in ax_content_tree_data.{h|cc} and AXContentTreeupdate in ax_content_tree_update.h, in preparation for the removal of ax_content_node_data.h, which will be the first step. Bug: 1094150 Change-Id: Ied779d527fdff7dddeac896084872f4c15b31683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250603Reviewed-by:Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#780243}
-
Hajime Hoshi authored
Bug: 1014174 Change-Id: I27fc6bcfb0a0bfa2937f9ad26a1bdc2e984dd803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251858 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
-
Clemens Backes authored
It was only enabled on Intel platforms so far (which meant mostly desktop), after finching we now want to also enable it on mobile systems for M-85. R=haraken@chromium.org Bug: 1040030 Change-Id: I2a2c12b977b2c519f5a7eb61f380d75d11bb943f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252100 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Alex Rudenko authored
Sending CSS.styleSheetChanged allows DevTools to pick up the latest styles from the mutated stylesheet. Fixed: 1096371 Change-Id: I9acdee212309e2f6f98cdf8bdbbecf9046fd01f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253739Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#780240}
-
Yutaka Hirano authored
This is a speculative fix for a test flakiness. Bug: 1096444 Change-Id: Id9ae9124a542541c67e46bad9b891b3a3ce10ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253602Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#780239}
-
Yoichi Osato authored
This CL implements a part of https://fetch.spec.whatwg.org/#dom-request: " 37: If body is non-null and body’s source is null, then: 1. If r’s request’s mode is neither "same-origin" nor "cors", then throw a TypeError. 2. Set r’s request’s use-CORS-preflight flag. " Bug: 688906 Change-Id: Ie8bb1ba8ae9a3e4dca69d73b9de4078791d5f39d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235132Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#780238}
-
Christian Dullweber authored
This string is an example for a valid content settings pattern. Most translations leave it untouched but some change the url to something that is not a valid example domain or breaks the syntax. Bug: 1095878 Change-Id: I95fa441d9c356fe55e893b6a3ea4f191e03fd9de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249762 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Auto-Submit: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#780237}
-
Andy Paicu authored
TBR=mfoltz@chromium.org Bug: 1096988 Change-Id: I04e9202842d4e4e8c9929f77087e58d2b2c0684d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253760Reviewed-by:
-
Colin Blundell authored
This CL adds a basic test that the infobar container responds to scrolling as expected in WebLayer. To enable this test we also made the following changes: - Factored out some support for setting up scrolling in tests from BrowserControlsTest.java for reuse - Extended EventUtils.java's simulation of dragging to post the finger down/move/up events sequentially. This change is necessary to get the scroll events to be fully processed within //content and ripple out to the infobar container. Bug: 1093846 Change-Id: Ifb94f33c498a13d711336165029370e259e330c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247894 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I0436547843d6b2b0d311ef29fb454b45524fb413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253779Reviewed-by:
-
Dominic Battre authored
TBR=drubery@chromium.org Bug: 1068623 Change-Id: I7dafe5af78aa2d898d748df74842ede742b0e504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253759Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#780233}
-
Oleh Lamzin authored
Expose empty Mojo probe service to Telemetry Extension. The Telemetry Extension is a prototype System Web App only installed on non-official builds and only if the chromeos::features::kTelemetryExtension feature is enabled. The exposed Mojo APIs are being used to prototype the app. In the final version, it's quite likely the APIs will be exposed a different way e.g. Extensions or Web APIs, which will go through security review. Bug: b:158658869 Test: existing browser test verifies that we don't crash when bind to service Change-Id: I4e0ebf5b74559cb2b11955dce2ba975c0fff94ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235716Reviewed-by:Tom Sepez <tsepez@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#780232}
-
