- 14 Sep, 2018 40 commits
-
-
Mike Wittman authored
Change-Id: Id68c456d354ecae820de360d6c7a4b9ba8754eb7 Reviewed-on: https://chromium-review.googlesource.com/1226622Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#591405}
-
Sergey Ulanov authored
P2P sockets destroy themselves on errors, but there were some cases when they would still access themselves after an error has occured. Some, but not all of these issues were addressed in crrev.com/590539. This CL addresses remaining problems. Particularly errors from P2PSocketTcpBase::OnPacket() were not handled properly. Also updated unittests to destroy sockets, to make it possible to catch these issues in tests in the future. Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I9cae97c5715f199c3f6dbccd3fbcd687e276a325 Bug: 884242 Reviewed-on: https://chromium-review.googlesource.com/1220676 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Oskar Sundbom <ossu@chromium.org> Cr-Commit-Position: refs/heads/master@{#591404}
-
Weidong Guo authored
The removed code was originally used to make shelf remain transparent for fullscreen backdrop window [1]. Now the shelf is no longer transparent, it should be removed. [1] https://chromium-review.googlesource.com/c/chromium/src/+/606706 Bug: b/79201599 Change-Id: Ic5b214cc714a7699d8ea4fda1a059a7d03104f6c Reviewed-on: https://chromium-review.googlesource.com/1224640Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#591403}
-
Vladislav Kaznacheev authored
Blacklist this flaky test for single_process_mash_browser_test. Keyboard overlay is slated to be removed soon. Bug: 884216 Test: verify filter file locally Change-Id: I48c7cc0de3648c9a5445d502f3fe08f436631605 Reviewed-on: https://chromium-review.googlesource.com/1227139Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#591402}
-
Scott Graham authored
Bug: 813631 Change-Id: Ib179df82faf2052e86a7c1a26994eff4d9f0ab45 Reviewed-on: https://chromium-review.googlesource.com/1226355Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#591401}
-
Steve Kobes authored
This was a premature optimization. We don't need to guard it, because the TRACE_EVENT_* macros are smart enough to avoid evaluating their args if we're not actually tracing. It will be good if we can use canary builds to capture traces with jank regions. Bug: 581518 Change-Id: I320eff45154c2d156c9c64e9877e40358b779d9d Reviewed-on: https://chromium-review.googlesource.com/1224463Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#591400}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/7a956edb6b53..7557e7b0efc0 git log 7a956edb6b53..7557e7b0efc0 --date=short --no-merges --format='%ad %ae %s' 2018-09-14 thestig@chromium.org Add basic tests for some annotation APIs. Created with: gclient setdep -r src/third_party/pdfium@7557e7b0efc0 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I27c5ea6c41c0bedb620ee1abff24d50e25195d83 Reviewed-on: https://chromium-review.googlesource.com/1226385Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#591399}
-
Matthew Jones authored
This patch adds a missing call to onUpdateAnimation. Bug: 884111 Change-Id: Ib0da2dd284348970b98a166abaa7b7e7a8bc471b Reviewed-on: https://chromium-review.googlesource.com/1226919Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#591398}
-
Xida Chen authored
This is a temporary fix to ensure that there will be no crash at TouchActionFilter::ReportTouchAction when the |scrolling_touch_action_| has no value. TBR=nzolghadr@chromium.org Bug: 879511 Change-Id: I007efc418c6169bc4ca91e9ac3d8e1627a8f2a4c Reviewed-on: https://chromium-review.googlesource.com/1226823Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#591397}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 97a91779. With Chromium commits locally applied on WPT: eebc4d85 "DOMWindowTimers::setTimeout and setInterval modified to accept Trusted Types." f8019d26 "Amend pointerevent tests so they are stable while the test is executing" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24695 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=markdittmer No-Export: true Change-Id: Ibb35b458568baa966a19d694c7e5d9fb06bbf6f6 Reviewed-on: https://chromium-review.googlesource.com/1226102 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#591396}
-
Eric Seckler authored
This accidentally disappeared in crrev.com/c/1224115 :) Bug: 867421 Change-Id: Ib77fc096ffd4bd98f134107180a020d9f829db7f Reviewed-on: https://chromium-review.googlesource.com/1225763Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#591395}
-
bsheedy authored
Regular upgrade to current VR keyboard release version. TBR=bajones@chromuim.org Change-Id: I02cd2e6dbdc316387461c1f2c0ae3380051ee1dc Reviewed-on: https://chromium-review.googlesource.com/1226356Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#591394}
-
Charlie Harrison authored
The CSS scanning optimization has been removed, so these metrics aren't being recorded anymore. Bug: None Change-Id: I4f10216e45962c4c75c440518a1f13721e684361 Reviewed-on: https://chromium-review.googlesource.com/1222626Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#591393}
-
bsheedy authored
Regular upgrade to the current release version of ArCore. TBR=vollick@chromium.org Change-Id: I48dcf2c0cacbc0e09384c412889a898d852fcf88 Reviewed-on: https://chromium-review.googlesource.com/1226359Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8f8f600c..dba95ab0 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7daaa30a2ef2d2b0a257d9cc1f17816bb1f559dc Reviewed-on: https://chromium-review.googlesource.com/1226016Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#591391}
-
Andrew Grieve authored
Main motivation here is to have dex method counts easy to see. Change-Id: I51291bc77c233a0c3115b07bc99579ba2489d4eb Reviewed-on: https://chromium-review.googlesource.com/1226525 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#591390}
-
bsheedy authored
Adds the ability for the native and Java versions of EmbeddedTestServer to be started using a specified port instead of always using an auto selected one. The use case that prompted this is pixel tests in VR, which need to use the test server (instead of file URLs) in order to grant permissions to pages, but need the URL to remain constant so that captured images don't differ between test runs. Bug: 883940 Change-Id: I7c0fa1a86cdf15d0e3271de6722d315a0191327a Reviewed-on: https://chromium-review.googlesource.com/1225304Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#591389}
-
Koji Ishii authored
This patch fixes painting scrollbars that are attached to inline blocks that have inline children. Painting inline blocks is a little different from existing painters because they can be engine boundaries. PaintOverflowControlsIfNeeded was added for this reason, but we didn't call it for self painting atomic inlines. Bug: 714962, 849751 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1f8bec247a2625f5dba6fb2d5d1dc91229e08557 Reviewed-on: https://chromium-review.googlesource.com/1226790Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#591388}
-
Dan Harrington authored
Move prefetch preferences to the offline_pages component. This removes the need for PrefetchConfiguration. Change-Id: Ia5c5e4d908bfa9abbfc72f9c076a54fb6dc2daee Reviewed-on: https://chromium-review.googlesource.com/1217350 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#591387}
-
Quan Nguyen authored
This CL fixes the case where displaying the captive portal view and then closing it would break the Gaia screen email input, preventing users from typing into the box. Bug: 881498 Change-Id: Id79795566fbb4355be7954edc34929ee4cccd524 Reviewed-on: https://chromium-review.googlesource.com/1222314Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#591386}
-
Koji Ishii authored
SkTypeface::getUnitsPerEm() is not a fast function. This patch caches (size / units_per_em) in HarfBuzzFontData. Improves long-line-nowrap.html from 580ms to 547ms (~6%) Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I4decd9f66e6b99b4798b1c7cc522999bba372aba Reviewed-on: https://chromium-review.googlesource.com/1226773 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
-
David Tseng authored
This reverts commit a9965c86. Reason for revert: <INSERT REASONING HERE> still seems to flake even when run serially on bots Original change's description: > Split chromevox_tests into two targets > > - large chromevox tests will move to interactive_ui_tests > These tests drive the user interface by using automation and wait for text to speech feedback that comes from a real tts extension running in memory. > > These tests run within the context of an extension background page (so have access to all of the chrome extension apis available to ChromeVox). > > - chromevox_tests > > These tests will run in a content script-like environment and test js at a class level and not involve things like chrome extension apis. > > Bug: 881845 > Change-Id: I88ff32d2831017cfa350348dae20ed49d9fabe50 > Reviewed-on: https://chromium-review.googlesource.com/1222704 > Commit-Queue: David Tseng <dtseng@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#591351} TBR=dmazzoni@chromium.org,sky@chromium.org,dtseng@chromium.org Change-Id: If7537afdfb30abbf7effe65062b798b6dd9b36a6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 881845 Reviewed-on: https://chromium-review.googlesource.com/1226357Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#591384}
-
Jacobo Aragunde Pérez authored
When designing an application platform that is completely web-based, webview tags can be used as containers of the different applications, providing isolation, storage, etc. Depending on the contents and the origins of the application inside the webview, we might want to use the webview API to tune the features and permissions inside the tag. Spatial navigation is important for hardware with no pointer devices, but it is not always required. For example, if we control the web content that is being displayed, we can implement it taking into account the specific input restrictions on the hardware platform. Still, spatial navigation is a must to browse contents that are not under our control, like in a general-purpose browser. This patch implements new API for <webview> to check the status of spatial navigation inside the tag, and manage it independently from the spatial navigation status outside the webview or in other webviews. API consists of: - a new method `setSpatialNavigationEnabled(bool) to enable or disable the feature for a specific webview. - a new method `isSpatialNavigationEnabled(callback) to check if the feature is enabled or disabled for a specific webview. The new API interacts with the `--enable-spatial-navigation` runtime flag, which enables the feature by default in newly created webviews. Bug: 863458 Change-Id: I36a8a4fefda1b99bcba6bae537b4f45028073125 Reviewed-on: https://chromium-review.googlesource.com/1133011 Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#591383}
-
Vasilii Sukhanov authored
forget about it immediately. Before the CL: - you open a page with multiple credentials saved. - delete one through the bubble. - the credentials is still presented in the dropdown on click. After the CL the credential is removed from the dropdown. If there is nothing to show then the dropdown won't appear. Bug: 870220 Change-Id: I485a3243f51b0d5c738ec407c4ec71dc71aa06ff Reviewed-on: https://chromium-review.googlesource.com/1226598 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#591382}
-
Marijn Kruisselbrink authored
Addressing some of the post-land feedback from https://crrev.com/c/1197904. Bug: 872465 Change-Id: I9a959aa7234261a722e424144167e2344386ddda Reviewed-on: https://chromium-review.googlesource.com/1225214Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#591381}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/af6c139eb6ff..c7d935899ab9 git log af6c139eb6ff..c7d935899ab9 --date=short --no-merges --format='%ad %ae %s' 2018-09-14 henrika@webrtc.org Adds multi-channel support to new ADM2 on Windows. 2018-09-14 peah@webrtc.org audioproc_f: Modified and added further logging of used aec3 parameters 2018-09-14 gustaf@webrtc.org Revert "AEC3: Reduce filter divergence during low-echo double-talk" Created with: gclient setdep -r src/third_party/webrtc@c7d935899ab9 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:883264 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia9d7c190ab9176cf8b0c9a8c7f8d7a07df780b06 Reviewed-on: https://chromium-review.googlesource.com/1226382Reviewed-by:
-
Alexey Kozyatinskiy authored
V8 CL that changes position of EOS error was rolled to Chromium more then a week ago. TBR=dgozman@chromium.org Bug: v8:8092 Change-Id: I6956c1e4c22a50e45f83ed78f3ba3d51f4442acf Reviewed-on: https://chromium-review.googlesource.com/1226619 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#591379}
-
Alexis Hetu authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/108f3e1..fe79649 BUG= TBR=kbr@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Iae4b83198fc82d2554a2f10f2d97d55e7b4d20df Reviewed-on: https://chromium-review.googlesource.com/1220181 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#591378}
-
Sahel Sharify authored
Bug: 797708 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Icce9d0c3eeed94297936aebc81681f5db2ec0682 Reviewed-on: https://chromium-review.googlesource.com/1226825Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#591377}
-
Mustaq Ahmed authored
Bug: 778769 Change-Id: I8404561578d76a33032a21f050150d35ac0bd553 Reviewed-on: https://chromium-review.googlesource.com/1194336 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#591376}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3e071665b9f9..9f36d9f78813 git log 3e071665b9f9..9f36d9f78813 --date=short --no-merges --format='%ad %ae %s' 2018-09-14 pasko@chromium.org FlushOsPageCaches: wait for dust to settle 2018-09-14 ulan@chromium.org Revert "Output DevTools error messages as warnings while running a story." 2018-09-13 simonhatch@chromium.org Dashboard - Error out on empty or uncompressed uploads 2018-09-13 sadrul@chromium.org rendering: Ignore trace-events for canceled draws. 2018-09-13 vovoy@chromium.org Only download files for filtered stories in story_runner 2018-09-13 chiniforooshan@chromium.org Telemetry: fix a SF stats collector bug 2018-09-13 cbruni@chromium.org Include hash for wprgo archive names to reduce name collisions 2018-09-13 pasko@chromium.org clear_system_cache: update binaries 2018-09-13 anthonyalridge@google.com Create a link to traces from the CFG. 2018-09-13 anthonyalridge@google.com Add clip path at to prevent overlap with x axis label. 2018-09-13 wangge@google.com Add functions to include APK, generate isolate and upload it. 2018-09-13 cbruni@chromium.org Add more helpers in preparation for v8.loading.cluster_telemetry benchmark 2018-09-13 anthonyalridge@google.com Add padding to numeric labels for stacked bar plotter. 2018-09-13 ulan@chromium.org Output DevTools error messages as warnings while running a story. Created with: gclient setdep -r src/third_party/catapult@9f36d9f78813 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:811244,chromium:881384,chromium:883892,chromium:880432,chromium:883735,chromium:883592,chromium:882291,chromium:881873,chromium:878390,chromium:881384,chromium:866423,chromium:866423,chromium:863390,chromium:883322,chromium:866423,chromium:880432 TBR=sullivan@chromium.org Change-Id: I934e7e9b842518c75edbeb4a1604c2e06b577861 Reviewed-on: https://chromium-review.googlesource.com/1226380Reviewed-by:
-
Manu Cornet authored
I somehow mis-read the spec as "30%" instead of "20%". Bug: 881166 Change-Id: I5ac19b0c97a862f399ec1342c4b46a2e3864b8a5 Reviewed-on: https://chromium-review.googlesource.com/1226850Reviewed-by:
-
Jandro Alderman authored
While the goal and documentation for the IsStackingContext states that it denotes nodes that start a new stacking context, using IsStacked() to determine this ends up also marks nodes that are absolutely positioned. R=pfeldman@chromium.org Change-Id: I99831acefe92a28b18c9184e769a57eaeada3773 Reviewed-on: https://chromium-review.googlesource.com/1222268Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Jandro Alderman <aalderman@chromium.org> Cr-Commit-Position: refs/heads/master@{#591373}
-
Jialiu Lin authored
Introduce a new enum value to GaiaPasswordReuse:: PasswordReuseDialogInteraction to indicate user's clicked on change password card on chrome://settings page. Server side proto change landed in cl/212475859 Also remove user action logging on page info bubble, since they're seldom used. Bug: 882964 Change-Id: Id3492181efcbf862f7655438dad087922a91dc3d Reviewed-on: https://chromium-review.googlesource.com/1220558Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#591372}
-
Tatiana Buldina authored
Change-Id: I4f768d6b326b097c45a34b451055c7d953528d3f Reviewed-on: https://chromium-review.googlesource.com/1225769Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#591371}
-
James Cook authored
It was added in the early days of mustash to support the mus window server. Now that we have WS2 / window service as a part of ash it isn't needed anymore. It was only being used in tests. Bug: 842365, 866526 Test: ui_base_unittests, ash_unittests, manually try accelerators Change-Id: Ib156f42103ef21c6cdaf95183bf828d0959ad84e Reviewed-on: https://chromium-review.googlesource.com/1225594Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#591370}
-
Paul Jensen authored
This reverts commit 0b89497a. Reason for revert: This is a very sensitive network change observer and I don't think the conversion to OnNetworkChanged was done properly. OnNetworkChanged isn't a simple conversion, please see the doc in the linked bug or the comment above OnNetworkChanged. Observers need to be edge triggered. Original change's description: > Refactor host_resolver_impl.h to use NetworkChangeObserver > > Combine the IPAddressChanged and ConnectionTypeChanged signals > > Bug: 754695 > > Signed-off-by: Wang Hui <wanghui07050707@gmail.com> > Change-Id: I942eed13c59aa4f1bc021f766f8664abd5920f1b > Reviewed-on: https://chromium-review.googlesource.com/1206550 > Reviewed-by: Bence Béky <bnc@chromium.org> > Commit-Queue: Bence Béky <bnc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#591081} TBR=bnc@chromium.org,wanghui07050707@gmail.com Change-Id: Iaee4f0b5967da4d9be6efc25611ef3b02d9c22e4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 754695 Reviewed-on: https://chromium-review.googlesource.com/1226304Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#591369}
-
Navid Zolghadr authored
Enable pointerrawmove events for touch event path as well. Bug: 882908 Change-Id: I263b6dfdd4cccf0fb1fcfbe0bb5581411b5f5e79 Reviewed-on: https://chromium-review.googlesource.com/1219967Reviewed-by:
Ella Ge <eirage@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#591368}
-
Balazs Engedy authored
Bug: 881321 Change-Id: I6f4d2ad1ae27f8dbb6f85e24442cf3e25287a7bc TBR: sky@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1209746 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#591367}
-
Weidong Guo authored
Changes: 1. During the dragging to full page, allow inserting placeholder and push the last item to next page via PagedViewStructure::ClearOverflow(). 2. At the end of dragging, add a "page break" item behind the new last item and clear the "page break" item behind the old last item in local model and server. Bug: 880977 Test: AppsGridGapTest.MoveItemToPreviousFullPage Change-Id: I318d46bb6917846e05f5552b040e45d8fe036319 Reviewed-on: https://chromium-review.googlesource.com/1220946Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
