- 09 Jul, 2020 40 commits
-
-
David Bertoni authored
These IncognitoApiTest tests were disabled a long time ago for flakiness, but they passed 3000 iterations on the bots with no issues. Bug: 89054, 120484 Change-Id: I59b22ef5f7daa6d040279d388a2f4d90770c9f90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270687Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#786836}
-
Ken Rockot authored
This reverts commit 865d1b47. Reason for revert: There are clear signs of performance regression particularly around GPU IPC, and addressing them with a dedicated Mojo thread is probably not going to be worthwhile in the near term. See associated bug for details. Original change's description: > Reland "Add MojoDedicatedThread field trial testing config" > > This is a reland of 6eda333b > > The test-only bug which elicited the revert has been fixed, > so this is relanding the original CL unmodified. > > Original change's description: > > Add MojoDedicatedThread field trial testing config > > > > Bug: 1082761 > > Change-Id: Ief2b018876f8cb2ad77495c7158db5c53fd8c206 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240407 > > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > > Commit-Queue: Ken Rockot <rockot@google.com> > > Cr-Commit-Position: refs/heads/master@{#777367} > > Bug: 1082761 > Tbr: asvitkine@chromium.org > Change-Id: Icefe444d49199e402a772775f687374b7c14b1c6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264732 > Commit-Queue: Ken Rockot <rockot@google.com> > Reviewed-by: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#781943} TBR=rockot@google.com,asvitkine@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1082761 Change-Id: Ib65a4a5170638399e8debdad728e8a38cc7a746f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289406Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#786835}
-
Fredrik Söderqvist authored
The pattern used here matches the semantics of Set(). Change-Id: I927f5c3c389e0df3dc4b2628c10192eae6840321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289786 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#786834}
-
Robert Ma authored
Using wpt-import in Chromium a49f4811. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools guidou@chromium.org, armax@chromium.org: external/wpt/mediacapture-streams jsbell@chromium.org: external/wpt/resources mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy rego@igalia.com: external/wpt/css/css-grid skobes@chromium.org: external/wpt/layout-instability NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I8d15aa4748cbd367277043c5631f9c1b4dafa284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289612Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#786833}
-
Rayan Kanso authored
The CL also adds a DO_NOT_SEND_CERTS load flag and a new privacy mode key. This allows sending a new request without client certificates. A new privacy mode is required so the socket pool can work as expected. Bug: 775438 Change-Id: I0c706c78bf574f00c22024408e9376051d5796d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252798 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#786832}
-
Henrique Nakashima authored
A dropdown with all known packages/classes that include the currently input string is offered so that the full, exact name of the package or class does not need to be entered. Bug: 1093962 Change-Id: I124c646a0b8d703142f1c306c58d678abc84c620 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280424 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#786831}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Icdfe4a7fad31d3e3d537632753fd4b8419182bda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289084Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786830}
-
Regan Hsu authored
This feature was never launched and the flag expired in M85. Extending expiry so that this flag can be re-used for a new unified cellular setup UI. Bug: 1093185 Change-Id: Icf7f0e34e8b7162df92adf7cce660f18fa85f756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288361Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#786829}
-
Dylan Sleeper authored
WriteHTML wrote both an html and a text payload. This is unnecessary because WriteHTML ended up reimplementing much of the logic in WriteText. Split the writing of the text and html payloads and added a check to the WritePlainText function. Replaced all occurrences of WriteHTML with a WriteHTML and WritePlainText call as necessary. Change-Id: Ifccbdb9018ae945ed9bd6f51c000a7ac13733a50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252950 Commit-Queue: Dylan Sleeper <dsleeps@google.com> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#786828}
-
Theresa Wellington authored
Remove the code logging a number of (intentionally) expired histograms and mark histograms as obsolete. Bug: 1052896 Change-Id: Iccc9cfe8efc8bbbe211e69a884170d6e4c2d2bec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288364 Commit-Queue: Theresa <twellington@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Auto-Submit: Theresa <twellington@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#786827}
-
Joey Arhar authored
Using other build sheriff as tbr TBR=nektar@chromium.org Bug: 1103712 Change-Id: I93841cfdbea95d261a146d8aaff5cdaed8ab0cfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290072Reviewed-by:
Joey Arhar <jarhar@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#786826}
-
zhaoyangli authored
Fixed by a workaround in crrev/c/2278763. Bug: 1100962 Change-Id: I2b0c16952523e28ca50e8f3834eb958efb4f9f73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283930Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#786825}
-
Chris Dalton authored
Makes sure to set up bindings for glPatchParameteri when GL_ARB_tessellation_shader or GL_OES_tessellation_shader are supported. Bug: skia:10419 Change-Id: Ie28e440955063cb3d5f644c81cec97692a25c4c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285170Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Chris Dalton <csmartdalton@chromium.org> Cr-Commit-Position: refs/heads/master@{#786824}
-
Michael Moss authored
This reverts commit 8f372d5f. Reason for revert: The Str() syntax is not supported by all DEPS parsers (there is no standard lib for this stuff), which is breaking omahaproxy and a whole ton of downstream stuff. crbug/1103538, b/160846203, b/160862399. Original change's description: > Split the cros_boards gclient var into two for fetching QEMU images. > > This will help with the TODO at: > https://source.chromium.org/chromium/chromium/src/+/master:build/config/chromeos/rules.gni;drc=ded9eb5153bb13b3f8821a6fa6fac6b3f0f590fd;l=22 > > It will also remove the need for hard-coding the names of all these > QEMU-compatible boards. > > Bug: 937821 > Change-Id: Iab180fc012bd694b4908ba0654da93d42e2274fa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265498 > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Reviewed-by: Erik Chen <erikchen@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Cr-Commit-Position: refs/heads/master@{#786005} TBR=thakis@chromium.org,dpranke@google.com,erikchen@chromium.org,bpastene@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 937821 Change-Id: Iaf491902f7da27fe4a9da64e0057907b117093ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289991 Commit-Queue: Michael Moss <mmoss@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Auto-Submit: Michael Moss <mmoss@chromium.org> Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#786823}
-
Joey Arhar authored
TBR=masonfreed@chromium.org Bug: 1103701 Change-Id: Ic20e1420a3e93ca7c3533a00043735017db875e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289085Reviewed-by:
Joey Arhar <jarhar@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#786822}
-
Xing Liu authored
No notification should be shown for scheduled download for download later feature. OfflineItemSchedule for the old code path is moved from DownloadItem to DownloadInfo so the old notification code path can get the struct. Also fix an issue that offline item filter filtered out scheduled download after loading download home. Bug: 1103419,1078454 Change-Id: Iaf69f47273082f001f579b13babc2fce17b71b14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288314Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#786821}
-
Fergal Daly authored
Change-Id: Ib53e27f7df70ec7f468b5ba11801837761766b20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282835 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Auto-Submit: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#786820}
-
David Benjamin authored
These were easy. I tweaked some to test all versions for good measure and remove the client cert authorities configuring, as it wasn't doing anything. (But I did set up a MockClientCertVerifier in SendGoodCert just to check that the certificate we expected was sent.) Bug: 492672 Change-Id: I46d1a453a343ca01cb05148b26f49167140a5ce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278122 Commit-Queue: Steven Valdez <svaldez@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#786819}
-
Eero Häkkinen authored
This includes fix for https://github.com/intel/wds/issues/170. TBR=thakis Bug: 1100669 Change-Id: Ide39c76ffc31d924de1df8510ecc53b9d02a3a7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289836 Commit-Queue: Eero Häkkinen <eero.hakkinen@intel.com> Reviewed-by:
Eero Häkkinen <eero.hakkinen@intel.com> Cr-Commit-Position: refs/heads/master@{#786818}
-
David Bertoni authored
The LaunchTabApp test was fixed in a previous CL, but was never tested or re-enabled. The test passed 3000 iterations on the bots without any issues. Bug: 23016, 915339, 979399 Change-Id: Ib6d5ab1ac6244caa3d24f8ed2e3a96ec57b50469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288500Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#786817}
-
David Black authored
NOTE: This CL does not add production icons. That will be done in a follow up CL. Bug: b:157510970 Change-Id: Ifac659d79902d9bdd228925e8b057452f0837eaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288484 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#786816}
-
Klaus Weidner authored
The logic for enabling the DOM overlay feature was a bit inconsistent, checking various fields in conditionals. Replace that with a check if the feature is part of required/optional features, trusting the feature parsing/checking code to verify prerequisites. Bug: 1101193 Change-Id: I5d73277c7b5def28ad00001b356e8f248259e6fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285869Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#786815}
-
Raymond Toy authored
Split out the SIMD/NEON code to its own file, as requested in https://chromium-review.googlesource.com/c/chromium/src/+/2252957 No functional changes. Bug: 1087071 Change-Id: Idd8bb477b4ebf0642a0a21a0d9c80372678e5925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283622 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#786814}
-
Peter Kotwicz authored
This CL deletes recording for the following histograms: Tab.BackgroundTabsOpenedViaContextMenuCount Tab.LostTabAgeWhenSwitchedToForeground Tab.BackgroundTabShown BUG=1089549 Change-Id: I456f014cc4e7672bed52ffb01e9cd61447aaa62f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269584Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#786813}
-
David Bokan authored
Prior to scroll unification, the compositor checks to see that all ancestors of a hit scroll node can scroll on the compositor. As part of this check it looks at all intersected non-fast scrollable regions. If any of these checks don't pass, the scroll must be handled on the main thread[1]. In scroll unification, only the initial hit test can depend on the main thread so we don't have to be as conservative and can avoid looking up the scroll ancestor chain. However, our initial attempt at this was too optimistic and looked only at the non fast scrolling regions on the hit layer. To understand why this is wrong, we need to know about the kinds of non-scrollable layers we can encounter. There are two problematic cases I'm aware of: - "Squashing" layers. These are layers where multiple smaller layers are combined into a single layer to save memory. However, the constituent layers need not be contiguous. If you have a 10x10 layer at the origin and a 10x10 layer at (90,90) that get squashed, you now have a 100x100 layer. This entire layer is marked as hit testable but, outside the two 10x10 rects in the corners, the user would expect the hit test to pass through to the layer below. - |pointer-events:none| layers. A web page can set this style on an element to make it invisible to hit testing. If this element gets a layer, it remains marked as hit testable even though it isn't. The element may also have a child that sets |pointer-events:auto| so that a subtree is once again hit testable. In both these cases, we have a layer that the compositor sees as one hit testable unit but, in reality, is a mix of hit testable and non-hit-testable content. Thus, to correctly hit test in the presence of such layers, we need to assume a point on a non-scrollable hit layer could have hit either an opaque or a transparent (in terms of hit testability) point. We do this today by looking at which node would scroll in both cases of hitting a "swiss-cheese" layer. If the hit layer's scroll parent is the the first hit scrollable layer, we know that it doesn't matter if we hit a hole or if we hit cheese because the same scroller will scroll. Otherwise we give up and let the main thread handle the scroll. In the case where we do scroll on the compositor, scroll unification currently checks only the non-fast scrolling region on the swiss-cheese layer but not on the scroller; in cases where we hit a "hole" and there was a NonFastScrollingRegion below, we would do the wrong thing by scrolling on the compositor. As noted at the top, this works in the stable path because we check all ancestor scroll node's NFSRs. Unification doesn't need to check all the ancestors, but it does need to at least check the scrolling layer. ...However; even that is not quite correct! Note that the discussion above assumes that if we hit a "hole", the layer below is the scroller. What happens if we have another non-scrollable layer between this one and the first scroller? If that layer's scroll parent isn't the first hit scroller then the scroller to use will depend on whether we hit "hole" or "cheese". The current stable path gets this wrong as well. See https://crbug.com/1098425. Thus, to be fully correct, we need to look at each layer above the first hit scroller and perform this check, looking both at whether the scrolling node is dependent on this hit test. In the case of scroll unification, since we won't look at any ancestor scrollers, we also must look at whether we intersect any non-fast-scrollable-regions on these layers. [1] https://source.chromium.org/chromium/chromium/src/+/master:cc/trees/layer_tree_host_impl.cc;l=3917;drc=3d6356eb99583a1c578560a2daf9072f58d82a5b?originalUrl=https:%2F%2Fcs.chromium.org%2F Bug: 1098108,1098425 Change-Id: Ie30c39a9259ca329a2b34a7c2a73a3e6d4150e73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261226 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#786812}
-
Klaus Weidner authored
This defaults to true to maintain compatibility with current behavior, but supports opting out. Use this opt-out for ARCore integration, this uses a shared context for several features which requires exactly compatible properties. Change-Id: I4428815b5271e8c0a112e62b2a67c1d394f1e181 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288754Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#786811}
-
Xianzhu Wang authored
The PDF renderer is super slow for big filters. Previously we use infinite cull rect for filtered contents, causing all filtered contents to appear in every page and we needed number-of-pages times of time to render the result. Because we don't actually want filter outset to cross page boundaries, now don't use infinite cull rect for filters. Bug: 1085788 Change-Id: Id4236966a687b17e763bf36fce83d136798ff3f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286476Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#786810}
-
Peter E Conn authored
The output of print_package_dependencies includes a lot of dependencies between the package you give it and its subpackages. For example between browser.customtabs and: - browser.customtabs.content - browser.customtabs.dependency_injection - browser.customtabs.features For modularization, I care more about dependencies between browser.customtabs and other packages of the same level. I added the default off --ignore-subpackages flag to exclude these dependencies from the output. Change-Id: I53cd37a01a72394285b836335bd0391c7bb37d0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287431 Auto-Submit: Peter Conn <peconn@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#786809}
-
Liquan (Max) Gu authored
Since ComponentPaymentRequestImpl has taken over the PaymentRequest interface from PaymentRequestImpl, mClient (PaymentRequestClient) should be managed by ComponentPaymentRequestImpl instead, because it's a logical part of PaymentRequest and this makes it shareable to WebLayer. Change: * Move mClient into ComponentPaymentRequestImpl. * Move the first two conditions of Init() into ComponentPaymentRequestImpl to avoid the need of a setClient(). Bug: 1102522 Change-Id: I6fa6120d102afb41bbc4f24ed1f47ccb278f1ee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287896Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#786808}
-
Kyle Williams authored
Adds chromeos::cfm::ServiceConnection in order to access Cfm Service Context in chromium. This singleton class automatically performs D-Bus->Mojo Bootstrap as necessary, and exposes a method clients can use to bind CfmServiceContextPtr mojo interface and thereby access the Cfm Service Context Daemon. BUG=b:144483733 TEST='autoninja -C out/Default chromeos:chromeos_unittests \ && ./out/Default/chromeos_unittests --dbus-stub \ --single-process-tests --gtest_filter=CfmServiceConnectionTest.*' Change-Id: I7d36881712d27890b9bd36c8a0b5e3ca9971abd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281305 Commit-Queue: Kyle Williams <kdgwill@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#786807}
-
Shawn Gallea authored
Bug: NONE Test: Locally on device Merge-With: eureka-internal/421471 Change-Id: Id0127a8fa198a0e2e44f4d463d9466fb6cf69645 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288843 Commit-Queue: Shawn Gallea <sagallea@google.com> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#786806}
-
Matt Menke authored
It wasn't being used. Also fix up includes slightly in the file it was declared in. Bug: 651119 Change-Id: I80341535c68f4a71c1be9a8b244370f7e9227c48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289990Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#786805}
-
Nico Weber authored
Bug: 1098899 Change-Id: Ie10b458e0160b8c010f3eae0c3958a58e07d095d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289402 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#786804}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b66b830b89d9..496a4d532ff5 2020-07-09 skyostil@chromium.org tracing: Fix GetTraceStats() while the backend connection is pending If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:158460807 Tbr: perfetto-bugs@google.com Change-Id: Ic172ed8ddeefdf381529607f747e3f6febbde135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289898Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786803}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/76cae97fc14c..08a294d37693 2020-07-09 sdefresne@chromium.org Convert GN libs lists to frameworks If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1052560 Tbr: swiftshader-team+autoroll@google.com Change-Id: Id3373ccb599e81c1f0646074732c90c13b8162a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289790Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786802}
-
Chris Harrelson authored
LayoutShiftTracker determines movement of objects by comparing their visual rects. This was augmented by a previous CL (*) to take into account adjustments to paint offset translation. This CL extends that approach to measure a generic diff relative to the highest ancestor transform node that is the root or not a translation. In addition to measuring shift more accurately in additional cases, this also unblocks removing a force-removing of visual rects. See also conversation for this CL (**) Bug: 1100711 (*) https://chromium-review.googlesource.com/c/chromium/src/+/1786249 (**) https://chromium-review.googlesource.com/c/chromium/src/+/1636403 Change-Id: Ib93d418e7ac4e593e68957ff950f9c1ed01588cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288507 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#786801}
-
danakj authored
This is a reland of f293c606 Original change's description: > End each web test with a single renderer-browser control ipc. > > Now that renderer local dumps are all synchronous operations (thanks to > https://chromium-review.googlesource.com/c/chromium/src/+/2284373) we > can compute all the renderer-side dump results and pass them to the > WebTestControlHost in the browser immediately in InitiateCaptureDump() > ipc. > > Once we do this, we no longer need to call a separate CaptureDump() ipc > to the renderer, store a callback there, and reply asynchronously. The > browser already has everything it needs once it finishes doing text > (aka layout) and pixel dumps. > > We also can combine the InitiateLayoutDump() ipc with the > InitiateCaptureDump() so that we only have one ipc to the browser when > the renderer's main frame wants to signal that the test is done. To do > this we just need to move some code around in the renderer side in order > to land on a single InitiateCaptureDump() call. > > This greatly simplifies the end of the test, and removes a bunch of > async states from both the browser and the renderer. > > We change expectations for 2 web tests that do weird things with the > main window's WebContents. The portal test activates and destroys the > WebContents out from under WebTestControlHost, which it doesn't like. > Now it should end the test gracefully. The web platform test does a > window.close() which closes the Shell in the middle of the test, which > again the WebTestControlHost is not a fan of. But it should also now > print a FAIL indicating this happened and end the test instead of timing > out. > > R=avi@chromium.org > > Bug: 866140, 1069111, 1039247 > Change-Id: I051a18f875dff758232cc1ba3f573f0ab4bcde2a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285169 > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: danakj <danakj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#786433} TBR=avi,dcheng Bug: 866140, 1069111, 1039247 Change-Id: Ifef93e5de5e95bc85be328a84b36b4010f85a6fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290050Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#786800}
-
Yann Dago authored
Bug: 1096839 Change-Id: I1ddad7fed38cb44d0df4aa48b99ec2fe5ed50c4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288271Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#786799}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1594273686-2664da095b2e1b68ad4776d0968922dc0fc1ccf6.profdata to chrome-win64-master-1594295624-92c35bf9dc32b4e9c0ad4a0cc50c7afb92d2fa29.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I9d83462baf5bbee561d692ea1c76443f7c67c38e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289892Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786798}
-
Lijin Shen authored
1. CATEGORY_BROWSABLE -> CATEGORY_APP_BROWSER for a shorter list 2. Put an extra value in the intent to know whether the activity is launched by disambiguation sheet 3. Additional metrics Bug: 1090103 Change-Id: I247bda4c00f40fda57bef74c11f829d1dd2c608d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285937Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#786797}
-