GitLab

blocked frames sent/received when a connection is finished.

Histogram name: Net.QuicSession.BlockedFrames.Received and
                Net.QuicSession.BlockedFrames.Sent.

R=asvitkine@chromium.org, rch@chromium.org

Review URL: https://codereview.chromium.org/669793003

Cr-Commit-Position: refs/heads/master@{#300739}

BUG=none
TEST=mojo plays mp3s.

Review URL: https://codereview.chromium.org/664303002

Cr-Commit-Position: refs/heads/master@{#300738}

We no longer use that function.

TBR=tedchoc, ianwen
BUG=424244

Review URL: https://codereview.chromium.org/674593002

Cr-Commit-Position: refs/heads/master@{#300737}

BUG=413779
TEST=manual

Review URL: https://codereview.chromium.org/668833003

Cr-Commit-Position: refs/heads/master@{#300736}

BUG=424746

Review URL: https://codereview.chromium.org/661053002

Cr-Commit-Position: refs/heads/master@{#300735}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=erg@chromium.org

Review URL: https://codereview.chromium.org/654223009

Cr-Commit-Position: refs/heads/master@{#300734}

This is to remove the code dependency on //content/ so that more
content_settings files can be in components/content_settings/core.

At the first glance, it may look like adding a new restriction
that HostContentSettingsMap has to be initialized on UI thread.
However, this doesn't change any conditions. Actually, that
restriction already exists on the current code implicitly on:
- HostContentSettingsMap creates OverrideProvider
- OverrideProvider ctor calls ReadOverrideSettings
- ReadOverrideSettings assumes called on UI thread

So this CL simply moves the thread checking.

BUG=384876
R=bauerb@chromium.org, vabr@chromium.org, rlp@chromium.org, rocket@chromium.org, phajdan.jr@chromium.org
TEST=no breaks on existing tests

Review URL: https://codereview.chromium.org/615083004

Cr-Commit-Position: refs/heads/master@{#300733}

BUG=422814
TEST=None

Review URL: https://codereview.chromium.org/660643002

Cr-Commit-Position: refs/heads/master@{#300732}

This screen will be shown when the owner/administrator remotely disables
a device. The CL only adds the screen. A follow-up CL will hook it up
with the OOBE flow.

The UI and strings are still under review and may change slightly before
this feature launches.

BUG=425574
TEST=Manual

Review URL: https://codereview.chromium.org/669623006

Cr-Commit-Position: refs/heads/master@{#300731}

There are 2 different path that can possibly lead to
SetDataReductionProxyEnalbed:
1. AwContents initialization -> InitDataReductionProxyIfNecessary path
2. AwContents statistics SetDataReductionProxyEnalbed JNI path

In both paths, we need to make sure before SetDataReductionProxyEnabed
is called, we have set the statistics object on
DataReductionProxySettings.

BUG=b/17998706

Review URL: https://codereview.chromium.org/671823002

Cr-Commit-Position: refs/heads/master@{#300730}

BUG=318977

Review URL: https://codereview.chromium.org/646873007

Cr-Commit-Position: refs/heads/master@{#300729}

This addresses two issues:
* Disconnect will correctly disconnect from the first connected or
  connecting network
* Join other... is restored to the VPN dropdown

BUG=424723

Review URL: https://codereview.chromium.org/662063005

Cr-Commit-Position: refs/heads/master@{#300728}

BUG=406538

Review URL: https://codereview.chromium.org/612933002

Cr-Commit-Position: refs/heads/master@{#300727}

Revert of [DevTools] Migrate DevToolsTracingHandler to generated handler. (patchset #6 id:130001 of https://codereview.chromium.org/635733003/)

Reason for revert:
Broke compile, e.g. obj/content/gen/content/browser/devtools/protocol/content_browser.devtools_protocol_handler_impl.o
gen/content/browser/devtools/protocol/devtools_protocol_handler_impl.cc:951:7: error: no viable conversion from 'std::string' (aka 'basic_string<char>') to 'const std::string *' (aka 'const basic_string<char> *')
      in_categories,
      ^~~~~~~~~~~~~
../../content/browser/devtools/protocol/tracing_handler.h:40:26: note: passing argument to parameter 'categories' here
      const std::string* categories,
                         ^
1 error generated.
ninja: build stopped: subcommand failed.

Original issue's description:
> [DevTools] Migrate DevToolsTracingHandler to generated handler.
>
> This patch also adds SendRawMessage, which is used for performance
> in tracing handler.
>
> BUG=405566
>
> Committed: https://crrev.com/f7762cb9261c8e2e15f2cf2b36f5408c75d72bdd
> Cr-Commit-Position: refs/heads/master@{#300711}

TBR=caseq@chromium.org,vkuzkokov@chromium.org,dgozman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=405566

Review URL: https://codereview.chromium.org/675473005

Cr-Commit-Position: refs/heads/master@{#300726}

NOTRY=true

Review URL: https://codereview.chromium.org/675473003

Cr-Commit-Position: refs/heads/master@{#300725}

The error module is not a part of psutil's API and it has been moved
to _error in recent releases. The exceptions in psutil are supposed to
be accessed directly from the top level module.

BUG=406396
R=frankf@chromium.org

Review URL: https://codereview.chromium.org/497763002

Cr-Commit-Position: refs/heads/master@{#300724}

Modify Boolean extension preference "networkPredictionEnabled" to interact with native browser preference |prefs::kNetworkPredictionOptions| instead of obsolete |prefs::kNetworkPredictionEnabled|.

BUG=423748

Review URL: https://codereview.chromium.org/652013002

Cr-Commit-Position: refs/heads/master@{#300723}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=bauerb@chromium.org

Review URL: https://codereview.chromium.org/649683010

Cr-Commit-Position: refs/heads/master@{#300722}

Review URL: https://codereview.chromium.org/657423003

Cr-Commit-Position: refs/heads/master@{#300721}

ShareChangeProcessor is responsible for deleting GenericChangeProcessor.
Because ShareChangeProcessor's dtor may be invoked by either the UI
thread or the model type thread, it must take care to ensure
GenericChangeProcessor is destroyed on the model type thread.

For some model types, the model type thread *is* the UI thread.  In this
case it's preferable to destroy the GenericChangeProcessor directly in
ShareChangeProcessor's dtor.  Why does it matter?  It matters because we
want to ensure a model type's GenericChangeProcessor and its resources
have been destroyed before the model type completes its
KeyedService::Shutdown method.

BUG=425781

Review URL: https://codereview.chromium.org/671603005

Cr-Commit-Position: refs/heads/master@{#300720}

BUG=421631
NOTRY=true

Review URL: https://codereview.chromium.org/672643002

Cr-Commit-Position: refs/heads/master@{#300719}

This reverts commit 8396651c.

ChromeOS has moved driver initialization earlier before Chrome
starts.

BUG=425412
TEST=Reboot on peach pit, run apprtc loopback, and check histograms.

Review URL: https://codereview.chromium.org/651833005

Cr-Commit-Position: refs/heads/master@{#300718}

WeakPtr supported SequencedTaskRunner in
https://codereview.chromium.org/20754006, but the
documentation was not updated to match.

BUG=none

Review URL: https://codereview.chromium.org/323153002

Cr-Commit-Position: refs/heads/master@{#300717}

Revert of Roll src/third_party/WebKit 95c55ab:9fdcfe1 (svn 184068:184159) (patchset #1 id:1 of https://codereview.chromium.org/668063003/)

Reason for revert:
Reverting since 8633ad1 introduced "python -S" for running idl_compiler.py. This seems to be problematic.

Original issue's description:
> Roll src/third_party/WebKit 95c55ab:9fdcfe1 (svn 184068:184159)
>
> Summary of changes available at:
> https://chromium.googlesource.com/chromium/blink/+log/95c55ab..9fdcfe1
>
> TBR=aboxhall@chromium.org,kochi@chromium.org
>
> Committed: https://crrev.com/b7a7ed1acadd9f30b9733a6dd789a93549bb1f16
> Cr-Commit-Position: refs/heads/master@{#300662}

TBR=aboxhall@chromium.org,kochi@chromium.org,blink-deps-roller@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/671053002

Cr-Commit-Position: refs/heads/master@{#300716}

If 'Automatic' is not the current name server selection we should show
the saved values instead of the current values.

BUG=417387

Review URL: https://codereview.chromium.org/647713004

Cr-Commit-Position: refs/heads/master@{#300715}

On some circumstances, pause events are generated several times during start up.
Since current implementation finishes CastShellActivity on pause events, the
app doesn't start unexpectedly.

BUG=425812

Review URL: https://codereview.chromium.org/668053003

Cr-Commit-Position: refs/heads/master@{#300714}

This lands server change 77795511 by raullenchai.

BUG=345769

Review URL: https://codereview.chromium.org/661743003

Cr-Commit-Position: refs/heads/master@{#300713}

When removing ServiceWorker data with the QuotaClient we should remove both registrations and cache data.  This CL adds the cache data id.

BUG=420159

Review URL: https://codereview.chromium.org/672433002

Cr-Commit-Position: refs/heads/master@{#300712}

This patch also adds SendRawMessage, which is used for performance
in tracing handler.

BUG=405566

Review URL: https://codereview.chromium.org/635733003

Cr-Commit-Position: refs/heads/master@{#300711}

Added Net.QuicServerInfo.DiskCacheLoadTime histogram to track the read
time.

R=asvitkine@chromium.org, rch@chromium.org

Review URL: https://codereview.chromium.org/674453003

Cr-Commit-Position: refs/heads/master@{#300710}

Instead of implying the fences based on read and write access
to the underlying texture, have sync point insertion imply
an EGL fence which is acquired when we wait on that sync point.

BUG=399226

Review URL: https://codereview.chromium.org/661973003

Cr-Commit-Position: refs/heads/master@{#300709}

Added UserSessionManager::InitializeUserSession()
(1) Launches browser for most common case
(2) Continues new user sign in with TOS (public sessions)/image screen (new users)
(3) For kiosk flow delegates launching app to the existing kiosk initialization flow

(1) Currently results in LoginUtils::Get()->DoBrowserLaunch() which may postpone launching browser for these reasons:
(a) There's custom user login flow defined like SupervisedUserCreationFlow. In that case login UI continues to live and custom flow UI is launched in that context.
(b) User has different app locale which requires reloading resource_bundle prior to launching browser
(c) User has custom flags set (or user flags are different from login screen flags defined by the owner), this requires restarting Chrome which will be launched in the active user session.

Small refactoring in ExistingUserController, added

* PerformPreLoginActions() - performs sets of actions right prior to login has been started.
* PerformLoginFinishedActions() - performs set of actions when login has been completed or has been cancelled.

BUG=370175

Review URL: https://codereview.chromium.org/656283002

Cr-Commit-Position: refs/heads/master@{#300708}

BUG=401707

Review URL: https://codereview.chromium.org/649653003

Cr-Commit-Position: refs/heads/master@{#300707}

Note: I still plan to refactor these so that more logic is shared between
the platforms, but it's nontrivial. In the meantime I think this is worth it
as long as it keeps improving the tests, because that will make the refactoring
that much less error-prone.

BUG=417104

Review URL: https://codereview.chromium.org/665333004

Cr-Commit-Position: refs/heads/master@{#300706}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=rogerta@chromium.org

Review URL: https://codereview.chromium.org/649313004

Cr-Commit-Position: refs/heads/master@{#300705}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/b4384b9..22b5ab6

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/670953002

Cr-Commit-Position: refs/heads/master@{#300704}

The paint events were updating the document_state of whatever the last
frame in the frame list was. In a case of "how did this ever work" it
must have been sheer luck that the last local frame in the list was the
main frame.

The update just checks to make sure that the local frame is actually
the main frame (no parent) when selecting the frame to update the
document_state of.

Could be that this broke in 38 when the proxy frames were added and
maybe they were only tested on pages with a single frame.

BUG=422913

Review URL: https://codereview.chromium.org/670513003

Cr-Commit-Position: refs/heads/master@{#300703}

Moves most of the large file lists in chrome_tests to variables defined at the top of the file. This will allow the lists to be shared with the GN build.

R=brucedawson@chromium.org

Review URL: https://codereview.chromium.org/671503006

Cr-Commit-Position: refs/heads/master@{#300702}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=junov@chromium.org

Review URL: https://codereview.chromium.org/665373005

Cr-Commit-Position: refs/heads/master@{#300701}

The issue is that the WebRtcLocalAudioRenderer is using 128 samples as buffer size on Mac, which can screw up the CoreAudio. And it makes perfect sense to use the same buffer size to render both the local and remote audio stream.
And we have the same issue on Linux as well.

This patch fix the problem on all platforms.

BUG=412765,410258

Review URL: https://codereview.chromium.org/646033007

Cr-Commit-Position: refs/heads/master@{#300700}